jyknight created this revision.
jyknight added a reviewer: rsmith.
And, configure it to explicitly request equivalent behavior to
ConstantFold, instead of getting that behavior accidentally.
While it seems that diagnose_if and enable_if were intended to require
a constexpr argument, the code was
jyknight created this revision.
jyknight added a reviewer: rsmith.
And, since EM_OffsetFold is now unused, remove it.
While builtin_object_size intends to ignore the presence of
side-effects in its argument, the EM_OffsetFold mode was NOT
configured to ignore side-effects. Rather it was effective
Hello Louis,
This commit broke build step on one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/13042
. . .
FAILED: tools/clang/lib/Sema/CMakeFiles/clangSema.dir/SemaExprCXX.cpp.obj
C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP -DEXPENSI
arsenm added a comment.
Tests should also include some global variables
https://reviews.llvm.org/D52891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
I think the name needs work, but I'm not sure what it should be. I think it
should avoid using "non" and "amdgpu"
https://reviews.llvm.org/D52891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
vsk added a comment.
@rsmith, friendly ping. I'm not in a rush on this one, but I know you wanted to
see an improvement in lambda capture diagnostics.
https://reviews.llvm.org/D52064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
brad added a comment.
Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp?
Repository:
rC Clang
https://reviews.llvm.org/D52418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
tamur created this revision.
tamur added reviewers: compnerd, MaskRay.
tamur added a project: clang.
Herald added a subscriber: cfe-commits.
gcc defines macros such as __code_model_small_ based on the user passed command
line flag -mcmodel. clang accepts a flag with the same name and similar
eff
thakis added a comment.
krasimir, do you do clang-format reviews these days? If not, do you know who
does?
https://reviews.llvm.org/D52842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: tlively
Date: Thu Oct 4 17:59:37 2018
New Revision: 343837
URL: http://llvm.org/viewvc/llvm-project?rev=343837&view=rev
Log:
[WebAssembly] any_true and all_true builtins
Summary: Depends on D52858.
Reviewers: aheejin, dschuff, craig.topper
Subscribers: sbc100, jgravelle-google, sunfish
Author: tlively
Date: Thu Oct 4 17:58:07 2018
New Revision: 343835
URL: http://llvm.org/viewvc/llvm-project?rev=343835&view=rev
Log:
[WebAssembly] __builtin_wasm_replace_lane_* builtins
Summary: Depends on D52852.
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, sunfish, kris
Author: tlively
Date: Thu Oct 4 17:58:56 2018
New Revision: 343836
URL: http://llvm.org/viewvc/llvm-project?rev=343836&view=rev
Log:
[WebAssembly] saturating arithmetic builtins
Summary: Depends on D52856.
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, sunfish, kristina, cf
Author: tlively
Date: Thu Oct 4 17:54:44 2018
New Revision: 343834
URL: http://llvm.org/viewvc/llvm-project?rev=343834&view=rev
Log:
[WebAssembly] __builtin_wasm_extract_lane_* builtins
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, sunfish, kristina, cfe-commits
Differenti
leonardchan added a comment.
> This sounds like something that would be better handled in the build system
> rather than in source code. In particular, I think you don't actually want to
> detect "is this translation unit being compiled with ubsan enabled?", you
> instead want to detect "is the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343838: [WebAssembly] abs and sqrt builtins (authored by
tlively, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52913?vs=168402&id=168424#toc
Repository:
rC Clang
https://review
Author: tlively
Date: Thu Oct 4 18:02:54 2018
New Revision: 343838
URL: http://llvm.org/viewvc/llvm-project?rev=343838&view=rev
Log:
[WebAssembly] abs and sqrt builtins
Summary: Depends on D52910.
Reviewers: aheejin, dschuff, craig.topper
Subscribers: sbc100, jgravelle-google, sunfish, kristin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343838: [WebAssembly] abs and sqrt builtins (authored by
tlively, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52913
Files:
cfe/trunk/includ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343837: [WebAssembly] any_true and all_true builtins
(authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52910
Files:
cfe/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343836: [WebAssembly] saturating arithmetic builtins
(authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52858
Files:
cfe/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343835: [WebAssembly] __builtin_wasm_replace_lane_* builtins
(authored by tlively, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52856?vs=168387&id=168421#toc
Repository:
rC Clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343834: [WebAssembly] __builtin_wasm_extract_lane_* builtins
(authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52852
Files:
On Thu, Oct 4, 2018 at 11:42 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Perhaps libc++ could provide a __version file that contains the headers,
> and use #include <__version> internally? We'd still need a header
> that just includes <__version> for conformance, but t
jyknight created this revision.
jyknight added a reviewer: rsmith.
The comment said it was intentionally not emitting any diagnostic
because the declaration itself was already diagnosed. However,
everywhere else that wants to not emit a diagnostic without an extra
note emits note_invalid_subexpr_i
jyknight created this revision.
jyknight added a reviewer: rsmith.
Previously, it had been using CK_BitCast even for casts that only
change const/restrict/volatile. Now it will use CK_Noop where
appropriate.
This is an alternate solution to r336746.
https://reviews.llvm.org/D52918
Files:
cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343831: Thread safety analysis: Examine constructor
arguments (authored by aaronpuchert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52443?vs=167856&id=168414#toc
Repository:
r
Author: aaronpuchert
Date: Thu Oct 4 16:51:14 2018
New Revision: 343831
URL: http://llvm.org/viewvc/llvm-project?rev=343831&view=rev
Log:
Thread safety analysis: Examine constructor arguments
Summary:
Instead of only examining call arguments, we also examine constructor
arguments applying the sa
mgrang updated this revision to Diff 168403.
https://reviews.llvm.org/D52807
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-intrinsics.c
Index: test/CodeGen/ms-intrinsics.c
===
--- test/Code
mgrang added a comment.
In https://reviews.llvm.org/D52807#1255835, @efriedma wrote:
> How are you testing?
>
> You might see different behavior at -O0.
Yes, I was testing at -O0. At -O2 I can see monotonic ordering affect the
choice of LD/ST insts used.
https://reviews.llvm.org/D52807
__
aaronpuchert added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:893
private:
- SmallVector UnderlyingMutexes;
+ enum UnderlyingCapabilityKind {
+UCK_Acquired, ///< Any kind of acquired capability.
delesley wrote:
> aaronpuchert wrote
tlively created this revision.
tlively added reviewers: aheejin, dschuff, craig.topper.
Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google,
sbc100.
Depends on https://reviews.llvm.org/D52910.
Repository:
rC Clang
https://reviews.llvm.org/D52913
Files:
include/clang
delesley accepted this revision.
delesley added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Analysis/ThreadSafety.cpp:2046
const CXXConstructorDecl *D = Exp->getConstructor();
if (D && D->isCopyConstructor()) {
const Expr* Source =
void updated this revision to Diff 168395.
void marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D52854
Files:
include/clang/AST/Expr.h
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaExpr.cpp
Author: mgrang
Date: Thu Oct 4 15:32:42 2018
New Revision: 343824
URL: http://llvm.org/viewvc/llvm-project?rev=343824&view=rev
Log:
[COFF, ARM64] Add __getReg intrinsic
Reviewers: rnk, mstorsjo, compnerd, TomTan, haripul, javed.absar, efriedma
Reviewed By: efriedma
Subscribers: peter.smith, ef
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343824: [COFF, ARM64] Add __getReg intrinsic (authored by
mgrang, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52838
Files:
include/clang/Basic/BuiltinsAArch64.def
lib/CodeGen/CG
void marked 9 inline comments as done.
void added a comment.
In https://reviews.llvm.org/D52854#1255755, @rsmith wrote:
> Essentially, you would add a `ConstExpr` node (or similar), teach
> `IgnoreImplicit` and friends to step over it
I've been trying to do this to no avail. Here's the code I
tlively created this revision.
tlively added reviewers: aheejin, dschuff, craig.topper.
Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google,
sbc100.
Depends on https://reviews.llvm.org/D52858.
Repository:
rC Clang
https://reviews.llvm.org/D52910
Files:
include/clang
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
efriedma wrote:
> rnk wrote:
> > mgrang wrote:
> >
delesley added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:893
private:
- SmallVector UnderlyingMutexes;
+ enum UnderlyingCapabilityKind {
+UCK_Acquired, ///< Any kind of acquired capability.
aaronpuchert wrote:
> delesley wrote:
>
delesley added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:951
+}
} else {
+// We're removing the underlying mutex. Warn on double unlocking.
aaronpuchert wrote:
> delesley wrote:
> > I find this very confusing. A lock here
tlively added a comment.
In https://reviews.llvm.org/D52856#1255905, @dschuff wrote:
> W is int64_t (which is long long for wasm32 and would probably be long for
> wasm64 since that would probably LP64 (like Linux) rather than LLP64 (Like
> Win64). So if we want it to be the same for both wasm3
dschuff added a comment.
W is int64_t (which is long long for wasm32 and would probably be long for
wasm64 since that would probably LP64 (like Linux) rather than LLP64 (Like
Win64). So if we want it to be the same for both wasm32 and wasm64, I guess we
want LL.
Repository:
rC Clang
https:
tlively updated this revision to Diff 168388.
tlively added a comment.
- Remove V:128: attributes
Repository:
rC Clang
https://reviews.llvm.org/D52858
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/CodeGen/builtins
smeenai added a comment.
In https://reviews.llvm.org/D52674#1253408, @rjmccall wrote:
> In https://reviews.llvm.org/D52674#1253401, @smeenai wrote:
>
> > Actually, I take that back ... I just misread the stack trace.
> >
> > There are a bunch of hops between the `mangleCXXRTTI` call and the ultim
tlively updated this revision to Diff 168387.
tlively added a comment.
- Replace Wi with LLi and remove V:128:
Repository:
rC Clang
https://reviews.llvm.org/D52856
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/Cod
tlively updated this revision to Diff 168385.
tlively added a comment.
- Replace Wi with LLi in signature string
- Remove unnecessary V:128: attribute
Repository:
rC Clang
https://reviews.llvm.org/D52852
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/
ashi1 added a comment.
I've added a hip.amdgcn.bc library for the fence functions that were originally
in irif library.
https://reviews.llvm.org/D52673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
ashi1 updated this revision to Diff 168384.
ashi1 edited the summary of this revision.
Herald added a subscriber: jfb.
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Index: test/Driver/hip-device-libs.hip
simark added a comment.
I just tried this, this looks very promising! It should help build our outline
view in a much more robust way than we do currently.
A nit for the final patch, I would suggest omitting the fields that are
optional, like `children` (when the list is empty) and `deprecated
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343818: [clang-doc] Clean up Markdown output (authored by
juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52754?vs=167851&id=168
Author: juliehockett
Date: Thu Oct 4 14:34:13 2018
New Revision: 343818
URL: http://llvm.org/viewvc/llvm-project?rev=343818&view=rev
Log:
[clang-doc] Clean up Markdown output
Make the output for the MDGenerator cleaner and more readable.
Differential Revision: https://reviews.llvm.org/D52754
M
tlively added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:55
+BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:")
+BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:")
+BUILTIN(__builtin_wasm_replace_lane_f32x4, "V4fV
tlively added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:59
+BUILTIN(__builtin_wasm_add_saturate_s_i8x16, "V16cV16cV16c", "ncV:128:")
+BUILTIN(__builtin_wasm_add_saturate_u_i8x16, "V16cV16cV16c", "ncV:128:")
craig.topper wrote:
> D
aaronpuchert added a comment.
Additional branches (with non-tail recursion unfortunately) would allow the
following to work:
void foo16() {
if (cond ? mu.TryLock() : false)
mu.Unlock();
}
void foo17() {
if (cond ? true : !mu.TryLock())
return;
mu.Unlock();
}
W
tks2103 added a comment.
@modocache I do need someone to land this for me! Take it away!
Repository:
rC Clang
https://reviews.llvm.org/D51741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
tks2103 updated this revision to Diff 168380.
tks2103 added a comment.
comply with clang-format
Repository:
rC Clang
https://reviews.llvm.org/D51741
Files:
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutine-rvo.cpp
Index: test/SemaCXX/coroutine-rvo.cpp
==
devnexen added a comment.
ping compiler-rt component committed :-)
Repository:
rC Clang
https://reviews.llvm.org/D52610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a comment.
How are you testing?
You might see different behavior at -O0.
Repository:
rC Clang
https://reviews.llvm.org/D52807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
mgrang added a comment.
AArch64 Psuedo Expansion does not seem to honor AtomicOrdering types
(SequentiallyConsistent/Monotonic). It seems to always generate LDAXRX/STLXRX
for 64-bit Cmp_Xchg.
Repository:
rC Clang
https://reviews.llvm.org/D52807
___
mgrang added a comment.
MSVC seems to generate ldaxr/stlxr (as well as dmb) for
InterlockedCompareExchangePointer and ldxr/stxr for
InterlockedCompareExchangePointer_nf.
void *test_InterlockedCompareExchangePointer(void * volatile *Destination,
v
mgrang updated this revision to Diff 168371.
https://reviews.llvm.org/D52838
Files:
include/clang/Basic/BuiltinsAArch64.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
lib/Sema/SemaChecking.cpp
test/CodeGen/arm64-microsoft-intrinsics.c
test/Sema/builtins-microsoft-arm64.c
Index: t
mgrang updated this revision to Diff 168368.
https://reviews.llvm.org/D52838
Files:
include/clang/Basic/BuiltinsAArch64.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
lib/Sema/SemaChecking.cpp
test/CodeGen/arm64-microsoft-intrinsics.c
test/Sema/builtins-microsoft-arm64.c
Index: t
jranieri-grammatech created this revision.
Herald added a subscriber: cfe-commits.
Event types are uniqued by using the addresses of a local static defined in a
header files, but it isn't the same across shared library boundaries and
plugins can't currently handle ImplicitNullDerefEvents.
Repo
jranieri-grammatech created this revision.
Herald added subscribers: cfe-commits, mgorny.
The `GDMIndex` functions return a pointer that's used as a key for looking up
data, but addresses of local statics defined in header files aren't the same
across shared library boundaries and the result is
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
mgrang wrote:
> rnk wrote:
> > Is the no fence version r
nickdesaulniers added inline comments.
Comment at: test/Sema/builtins.c:125
+// __builtin_constant_p cannot resolve non-constants as a file scoped array.
+int expr;
such as
Otherwise it's possible to read this as the non-constants being resolved to a
file sco
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:15621-15623
+for (InitListExpr::iterator II = E->begin(), IE = E->end();
+ II != IE; ++II)
+ Visit(*II);
nickdesaulniers wrote:
> void wrote:
> > nickdesaulniers
rsmith added a comment.
Rather than adding a `CanDelayEvaluation` flag to call expressions, I think it
would be substantially better to introduce a new `Expr` wrapper node for
expressions that are required to be constant expressions. (That'd eventually
also give us a place to cache the evaluate
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343809: Update Clang Windows getting started docs (authored
by rnk, committed by ).
Changed prior to commit:
https://re
rnk marked an inline comment as done.
rnk added a comment.
I'm going to go ahead and commit this. Hopefully it's more accurate and useful
than what we have, and we can fix any issues in post.
https://reviews.llvm.org/D52843
___
cfe-commits mailing
Author: rnk
Date: Thu Oct 4 13:34:52 2018
New Revision: 343809
URL: http://llvm.org/viewvc/llvm-project?rev=343809&view=rev
Log:
Update Clang Windows getting started docs
Summary:
- Update the example VS project generation to use VS2017.
- Add docs for generating ninja build files, since they ar
aaronpuchert added inline comments.
Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:1879-1880
+ void foo13() {
+if (mu.TryLock() ? 1 : 0)
+ mu.Unlock();
+ }
aaron.ballman wrote:
> aaronpuchert wrote:
> > aaron.ballman wrote:
> > > Can you add
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:15621-15623
+for (InitListExpr::iterator II = E->begin(), IE = E->end();
+ II != IE; ++II)
+ Visit(*II);
void wrote:
> nickdesaulniers wrote:
> > nickdesaulniers
void added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:15621-15623
+for (InitListExpr::iterator II = E->begin(), IE = E->end();
+ II != IE; ++II)
+ Visit(*II);
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > `std::for_each`
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:15621-15623
+for (InitListExpr::iterator II = E->begin(), IE = E->end();
+ II != IE; ++II)
+ Visit(*II);
nickdesaulniers wrote:
> `std::for_each`?
Sorry, posted
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:15621-15623
+for (InitListExpr::iterator II = E->begin(), IE = E->end();
+ II != IE; ++II)
+ Visit(*II);
`std::for_each`?
https://reviews.llvm.org/D52854
__
void updated this revision to Diff 168356.
void added a comment.
Removed unused field.
https://reviews.llvm.org/D52854
Files:
include/clang/AST/Expr.h
include/clang/Sema/Sema.h
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaT
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, sorry it got lost.
Repository:
rC Clang
https://reviews.llvm.org/D52418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/readability/NumericalCostantsToMaxIntCheck.cpp:44
+SrcMgr::CharacteristicKind FileType) {
+
+ if (FileName == "limits") {
Unnecessary empty line.
Repository:
rCTE Clang Tools Extra
https://rev
efriedma added a comment.
Needs a testcase for the error message like we have for other intrinsics in
test/Sema/builtins-arm64.c . Otherwise LGTM.
https://reviews.llvm.org/D52838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
delesley added a comment.
For future patches, please add Richard Trieu (rtr...@google.com) as a
subscriber. I will continue to try and do code reviews, but Richard is on the
team that actually rolls out new compiler changes. Thanks!
BTW, the issue is not just that changes may introduce false
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343808: [AST] Revert mangling changes from r339428 (authored
by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52581?vs=167219&id=168354#toc
Repository:
rC Clang
https:/
Author: smeenai
Date: Thu Oct 4 12:50:14 2018
New Revision: 343808
URL: http://llvm.org/viewvc/llvm-project?rev=343808&view=rev
Log:
[AST] Revert mangling changes from r339428
As discussed in https://reviews.llvm.org/D50144, we want Obj-C classes
to have the same mangling as C++ structs, to supp
erik.pilkington added inline comments.
Comment at: clang/include/clang/AST/DeclTemplate.h:1771-1779
+ void setIsSpecializedMember(bool V = true) { IsSpecializedMember = V; }
+
+ /// If this class template specialization was declared at class scope
(DR727).
+ /// For example,
erik.pilkington updated this revision to Diff 168352.
erik.pilkington added a comment.
Address @rsmith's review comments.
https://reviews.llvm.org/D52521
Files:
clang/include/clang/AST/DeclTemplate.h
clang/lib/Sema/SemaTemplateInstantiate.cpp
clang/test/SemaCXX/member-spec-dr727.cpp
Inde
mgrang updated this revision to Diff 168353.
https://reviews.llvm.org/D52838
Files:
include/clang/Basic/BuiltinsAArch64.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
lib/Sema/SemaChecking.cpp
test/CodeGen/arm64-microsoft-intrinsics.c
Index: test/CodeGen/arm64-microsoft-intrinsics
simark added a comment.
So I revisited this today. In the end, restarting clangd in our IDE works
well. It should be merged anytime soon:
https://github.com/theia-ide/theia/pull/3017
But I am wondering what to do with the feature that allows clangd to change
compilation database path using t
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:6589
+std::string Reg = StrVal == "31" ? "sp" :
+ "x" + std::string(StrVal.c_str());
+
Could you just write this as `std::string Reg = Value == 31 ? "sp" : "x" +
Value
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:15604
+public EvaluatedExprVisitor {
+ Sema &S;
+
../tools/clang/lib/Sema/SemaExpr.cpp:15619:13: warning: private field 'S' is
not used [-Wunused-private-field]
Sema &S;
leonardchan updated this revision to Diff 168348.
leonardchan marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D52814
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/asan-new-pm.ll
Index: test/CodeGen/asan-new-pm.ll
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343807: [NestedNameSpecifier] Add missing stream-specific
dump methods (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5287
leonardchan added a comment.
In https://reviews.llvm.org/D52814#1254901, @philip.pfaffe wrote:
> Is this the right place in the pipeline to put the passes? The legacy PM
> inserts the asan passes at EP_OptimizerLast, why not do the same thing?
I noticed this also and thought adding this using
Author: steveire
Date: Thu Oct 4 12:22:00 2018
New Revision: 343807
URL: http://llvm.org/viewvc/llvm-project?rev=343807&view=rev
Log:
[NestedNameSpecifier] Add missing stream-specific dump methods
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D52870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
aaron.ballman added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:1445
+ if (!TCond && FCond) {
+Negate = !Negate;
+return getTrylockCallExpr(COP->getCond(), C, Negate);
aaronpuchert wrote:
> aaron.ballman wrote:
> > Rather than
aaronpuchert added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:1445
+ if (!TCond && FCond) {
+Negate = !Negate;
+return getTrylockCallExpr(COP->getCond(), C, Negate);
aaron.ballman wrote:
> Rather than do an assignment here, wh
rnk added a comment.
It doesn't address the version skew issue, but my blanket argument against any
new environment variable is the existance of things like `_CL_` and
`CCC_OVERRIDE_OPTIONS`. You can set any compiler flag you want from the
environment, so we should standardize on one way of set
steveire updated this revision to Diff 168338.
steveire added a comment.
Format
Repository:
rC Clang
https://reviews.llvm.org/D52870
Files:
include/clang/AST/NestedNameSpecifier.h
lib/AST/NestedNameSpecifier.cpp
Index: lib/AST/NestedNameSpecifier.cpp
===
zturner added a comment.
In https://reviews.llvm.org/D52773#1255491, @thakis wrote:
> In https://reviews.llvm.org/D52773#1255093, @zturner wrote:
>
> > I agree magic environment variables are bad, but without it we don’t
> > address the only current actual use we have for this, which is making t
Szelethus updated this revision to Diff 168334.
https://reviews.llvm.org/D52794
Files:
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist
test/Analysis/plist-macros-with-expansion.cpp
Index: test/Analysis/plist-macros-wit
1 - 100 of 271 matches
Mail list logo
