pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a comment.
This revision is now accepted and ready to land.
I glimpsed over this without spotting anything crucial. My Clang code base
knowledge is a bit lightweight though so you might want to wait for an another
reviewer. On t
atanasyan added a comment.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D52418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
void test(void) {
int *a;
int* b;
}
TranslationUnitDecl
`-FunctionDecl line:4:6 test 'void ()'
`-CompoundStmt
|-DeclStmt
| `-VarDecl col:10 a 'int *'
`-DeclStmt
`-VarDecl col:10 b 'int *'
Why not 'int*' in ast dump?
https://reviews.llv
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:110
+/// are usually useless
+static unsigned AdjustPrecision(unsigned precision) {
+ return (precision * 59 + 195) / 196;
rsmith wrote:
> xbolva00 wrote:
> > xbolva00 wrote:
> > > xbolva00 wr
tstellar added a comment.
I've implemented an alternative solution here that I think is a little more
robust: https://reviews.llvm.org/D52861
Repository:
rC Clang
https://reviews.llvm.org/D42608
___
cfe-commits mailing list
cfe-commits@lists.llv
tstellar created this revision.
Fedora ships cross-compilers on all platforms, so a user could end up
with a gcc x86_64 cross-compiler installed on an x86_64 system. clang
maintains a list of supported triples for each target and when all
else is equal will prefer toolchains with triples that app
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:59
+BUILTIN(__builtin_wasm_add_saturate_s_i8x16, "V16cV16cV16c", "ncV:128:")
+BUILTIN(__builtin_wasm_add_saturate_u_i8x16, "V16cV16cV16c", "ncV:128:")
Don't copy the "V:
tlively added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:46
+BUILTIN(__builtin_wasm_extract_lane_s_i16x8, "iV8sIi", "ncV:128:")
+BUILTIN(__builtin_wasm_extract_lane_u_i16x8, "iV8sIi", "ncV:128:")
+BUILTIN(__builtin_wasm_extract_lane_i32x4, "iV4iIi",
tlively updated this revision to Diff 168224.
tlively added a comment.
- Rebase
Repository:
rC Clang
https://reviews.llvm.org/D52858
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/CodeGen/builtins-wasm.c
==
tlively updated this revision to Diff 168223.
tlively added a comment.
- Force constant folding for lane
Repository:
rC Clang
https://reviews.llvm.org/D52856
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/CodeGen/b
tlively updated this revision to Diff 168222.
tlively marked an inline comment as done.
tlively added a comment.
- use isIntegerConstantExpr to force constant folding of lanes
Repository:
rC Clang
https://reviews.llvm.org/D52852
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/Code
mgorny added a comment.
Yes, I've tested it on Linux. I'll commit it once the dep is approved, and
hopefully build bots will answer if they work across all platforms.
Repository:
rC Clang
https://reviews.llvm.org/D52840
___
cfe-commits mailing l
steveire added inline comments.
Comment at: clang-query/Query.cpp:48
+"Set whether to dump binding ASTs.\n"
+" set print-output (true|false) "
+"Set whether to print matched text.\n"
Is the 'print' output useful at all? I'm thinking
mcgrathr added a comment.
The motivating use case always pairs `noderef` with an `address_space`
attribute, and it's already invalid to convert between pointer types in
different address spaces without a cast.
So I don't think we have a strong opinion one way or the other. In the
abstract, I'd
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
This is useful if using clang-query -f with a file containing multiple
matchers.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52859
Files:
clang-query/Query.cpp
steveire updated this revision to Diff 168218.
steveire added a comment.
Commit message
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/Q
steveire updated this revision to Diff 168217.
steveire added a comment.
Format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/QueryEngi
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google,
sbc100.
Depends on https://reviews.llvm.org/D52856.
Repository:
rC Clang
https://reviews.llvm.org/D52858
Files:
include/clang/Basic/Builtin
aheejin added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:55
+BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:")
+BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:")
+BUILTIN(__builtin_wasm_replace_lane_f32x4, "V4fV
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Replace it with granular options.
This makes it possible to
- Have both diag and dump active at once
- Extend the output with other queryable content in the future.
Repository:
r
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:55
+BUILTIN(__builtin_wasm_replace_lane_i32x4, "V4iV4iIii", "ncV:128:")
+BUILTIN(__builtin_wasm_replace_lane_i64x2, "V2WiV2WiIiWi", "ncV:128:")
+BUILTIN(__builtin_wasm_replace_lane_f32x4,
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks again, and sorry for the delay.
https://reviews.llvm.org/D51855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/Sema.cpp:648
+ !FD->getMostRecentDecl()->isInlined() &&
+ !FD->hasAttr())
continue;
What's the purp
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google,
sbc100.
Depends on https://reviews.llvm.org/D52852.
Repository:
rC Clang
https://reviews.llvm.org/D52856
Files:
include/clang/Basic/Builtin
rsmith added a comment.
In https://reviews.llvm.org/D51329#1229061, @leonardchan wrote:
> @rsmith So I chose to go with the type sugar route since we would prefer to
> have multiple attributes in one attribute list. This type just contains the
> underlying type and the macro identifier original
rsmith added a comment.
The consequence of this will be that we use a stale PCH / PCM file if files
have changed, rather than emitting an "out of date" error if / when we decide
we need to reference a modified file that was used to build the AST file. That
can lead to bad things happening: any
rsmith added inline comments.
Comment at: clang/include/clang/AST/DeclTemplate.h:1771-1779
+ void setIsSpecializedMember(bool V = true) { IsSpecializedMember = V; }
+
+ /// If this class template specialization was declared at class scope
(DR727).
+ /// For example, the speci
rsmith added a comment.
This seems like an unreasonably long flag name. Can you try to find a shorter
name for it?
Repository:
rC Clang
https://reviews.llvm.org/D52615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
rsmith added a comment.
I feel indifferent about this warning, but clearly you care about it enough to
work on it, and it's a pretty low-cost feature from a maintenance perspective,
so I suppose it's fine.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:56-58
+def war
rsmith added a comment.
In https://reviews.llvm.org/D52791#1254559, @rsmith wrote:
> int *ptr, (a), b, c;
>
Another possible heuristic for suppressing the check: only warn if there is
whitespace before the identifier. So:
int* a, b; // warning
int *a, b; // no warning
bmoody created this revision.
bmoody added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
Previously the location of a token immediately following an escaped newline was
the location of the backslash character in the escaped newline.
The change to test/SemaTemplate/instantiation-dep
rsmith added a comment.
I think we need some documented guidelines on what is and is not an appropriate
warning for Clang. I think it's reasonable to warn in cases where we are
confident that the code means something other than what the programmer or a
later reader is likely to expect; it's les
void added a comment.
This is related to https://reviews.llvm.org/D4276, which I believe has been
deleted. However, I believe that a modified version of that patch will work.
The idea of this patch is *not* to be fully compatible with gcc's
implementation, but to expand clang's implementation o
MaskRay abandoned this revision.
MaskRay added a comment.
Thanks for your prompt response https://reviews.llvm.org/rC343747 . I'll
abandon this revision!
Repository:
rC Clang
https://reviews.llvm.org/D52853
___
cfe-commits mailing list
cfe-commi
void created this revision.
void added reviewers: jyknight, eli.friedman, resistor, janusz.
Herald added subscribers: cfe-commits, kristina.
A __builtin_constant_p may end up with a constant after inlining. Use
the is.constant intrinsic if we're unable to determine if it's a
constant.
See: https:
rsmith added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:110
+/// are usually useless
+static unsigned AdjustPrecision(unsigned precision) {
+ return (precision * 59 + 195) / 196;
xbolva00 wrote:
> xbolva00 wrote:
> > xbolva00 wrote:
> > > craig.toppe
george.karpenkov added a comment.
Tracked in rdar://44992170.
Marking the test as unsupported for now.
Repository:
rC Clang
https://reviews.llvm.org/D52853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:46
+BUILTIN(__builtin_wasm_extract_lane_s_i16x8, "iV8sIi", "ncV:128:")
+BUILTIN(__builtin_wasm_extract_lane_u_i16x8, "iV8sIi", "ncV:128:")
+BUILTIN(__builtin_wasm_extract_lane_i32x4, "iV4i
krasimir added inline comments.
Comment at: lib/Format/Format.cpp:1823
+ unsigned LongestMatchLength = 0;
+ for (unsigned i = 0; i < Style.JavaImportGroups.size(); i++) {
+std::string GroupPrefix = Style.JavaImportGroups[i];
nit: LLVM Style uses CamelCase f
Author: george.karpenkov
Date: Wed Oct 3 17:07:45 2018
New Revision: 343747
URL: http://llvm.org/viewvc/llvm-project?rev=343747&view=rev
Log:
[analyzer] [quickfix] Temporarily disabling a failing test.
Modified:
cfe/trunk/test/Analysis/trustnonnullchecker_test.m
Modified: cfe/trunk/test/Ana
NoQ added a comment.
*reads the comments* no, NDEBUG won't work.
Ok, we'll take care of this, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
rsmith added a comment.
In https://reviews.llvm.org/D52386#1254483, @leonardchan wrote:
> In https://reviews.llvm.org/D52386#1254437, @rsmith wrote:
>
> > I'm not at all convinced that this is a good thing. There isn't such a
> > thing as "undefined behavior sanitizer". Rather, there are a whole
NoQ added a comment.
And, of course, we'll need to change `__OPTIMIZE__` to `NDEBUG`.
Also thanks for reporting the problem!
Repository:
rC Clang
https://reviews.llvm.org/D52853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
aheejin added inline comments.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:46
+BUILTIN(__builtin_wasm_extract_lane_s_i16x8, "iV8sIi", "ncV:128:")
+BUILTIN(__builtin_wasm_extract_lane_u_i16x8, "iV8sIi", "ncV:128:")
+BUILTIN(__builtin_wasm_extract_lane_i32x4, "iV4iIi",
NoQ added a comment.
Hmm, wait, right, i might have an idea of what's going on. I think we need to
revert.
Repository:
rC Clang
https://reviews.llvm.org/D52853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
MaskRay added a comment.
In https://reviews.llvm.org/D52853#1254486, @NoQ wrote:
> This should have been fixed by https://reviews.llvm.org/D52848.
>
> This is a very important fundamental assertion, we definitely should not
> remove it.
Sorry I don't understand the code at all but I get a diff
rsmith added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3513
+ int x = 2;
+ int &y = x; // warning: 'noderef' can only be used on an array or pointer
type
+
Should `noderef` appear somewhere in this example? :)
Comment at:
MaskRay added a comment.
This change appears to break `test/Analysis/trustnonnullchecker_test.m` in
non-optimized (__OPTIMIZE__ not defined) mode. Can you take a look?
Repository:
rC Clang
https://reviews.llvm.org/D52848
___
cfe-commits mailing
NoQ added a comment.
This should have been fixed by https://reviews.llvm.org/D52848.
This is a very important fundamental assertion, we definitely should not remove
it.
Repository:
rC Clang
https://reviews.llvm.org/D52853
___
cfe-commits mailin
MaskRay created this revision.
MaskRay added reviewers: NoQ, george.karpenkov, dcoughlin.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
JDevlieghere, szepet, xazax.hun.
This fixes test/Analysis/trustnonnullchecker_test.m in Debug mode.
Repository:
rC Clang
htt
leonardchan added a comment.
In https://reviews.llvm.org/D52386#1254437, @rsmith wrote:
> I'm not at all convinced that this is a good thing. There isn't such a thing
> as "undefined behavior sanitizer". Rather, there are a whole bunch of
> different checks that fall under the same umbrella. Th
Author: rupprecht
Date: Wed Oct 3 16:40:04 2018
New Revision: 343744
URL: http://llvm.org/viewvc/llvm-project?rev=343744&view=rev
Log:
[llvm-nm] Update clang tests based on changed llvm-nm output
Modified:
cfe/trunk/test/CodeGen/thinlto_backend.ll
Modified: cfe/trunk/test/CodeGen/thinlto_ba
rnk marked 3 inline comments as done.
rnk added inline comments.
Comment at: clang/www/get_started.html:179
svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm
STL_MSFT wrote:
> Can these be HTTPS? (I had to figure out HTTPS incantations for `git
rnk updated this revision to Diff 168205.
rnk added a comment.
- Use https: where possible over http:
- Fix CMake VS generator invocation
https://reviews.llvm.org/D52843
Files:
clang/www/get_started.html
Index: clang/www/get_started.html
==
nickdesaulniers added a comment.
Thanks for your suggestions and code review. I appreciate it.
Repository:
rL LLVM
https://reviews.llvm.org/D52849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
juliehockett updated this revision to Diff 168200.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D52847
Files:
clang-tools-extra/clang-doc/Representation.cpp
clang-tools-extra/clang-doc/Representation.h
clang-tools-extra/clang-doc/Serialize.cpp
clang-tools-extra/
rsmith added a comment.
I'm not at all convinced that this is a good thing. There isn't such a thing as
"undefined behavior sanitizer". Rather, there are a whole bunch of different
checks that fall under the same umbrella. This test seems on the surface to be
about as meaningless as `__has_feat
On Tue, 2 Oct 2018 at 01:18, Stephan Bergmann via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 28/09/2018 03:16, Richard Smith via cfe-commits wrote:
> > Author: rsmith
> > Date: Thu Sep 27 18:16:43 2018
> > New Revision: 343285
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=343285&
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google,
sbc100.
Repository:
rC Clang
https://reviews.llvm.org/D52852
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343740: [SEMA] split ExtWarn dupl-decl-spec's into
Extension and ExtWarn (authored by nickdesaulniers, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
Author: nickdesaulniers
Date: Wed Oct 3 16:09:29 2018
New Revision: 343740
URL: http://llvm.org/viewvc/llvm-project?rev=343740&view=rev
Log:
[SEMA] split ExtWarn dupl-decl-spec's into Extension and ExtWarn
Summary:
For types deduced from typedef's and typeof's, don't warn for duplicate
declarati
mgrang updated this revision to Diff 168192.
https://reviews.llvm.org/D52838
Files:
include/clang/Basic/BuiltinsAArch64.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
lib/Sema/SemaChecking.cpp
test/CodeGen/arm64-microsoft-intrinsics.c
Index: test/CodeGen/arm64-microsoft-intrinsics
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
zturner added inline comments.
Comment at: clang/www/get_started.html:246
+"C:\Program Files (x86)\Microsoft Visual
+ Studio\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" x64
+
zturner wrote:
> STL_MSFT wrote:
> > This assumes the Pro
zturner added inline comments.
Comment at: clang/www/get_started.html:246
+"C:\Program Files (x86)\Microsoft Visual
+ Studio\2017\Professional\VC\Auxiliary\Build\vcvarsall.bat" x64
+
STL_MSFT wrote:
> This assumes the Professional SKU; perh
Author: maskray
Date: Wed Oct 3 15:56:26 2018
New Revision: 343738
URL: http://llvm.org/viewvc/llvm-project?rev=343738&view=rev
Log:
Revert "[ASTMatchers] Fix DynamicASTMatchersTests again"
This reverts commit 8a6631a983ec9c1d22cc77c5f55a524a651740f0.
The last fix seems good in Debug mode.
Mod
Author: dergachev
Date: Wed Oct 3 15:48:00 2018
New Revision: 343736
URL: http://llvm.org/viewvc/llvm-project?rev=343736&view=rev
Log:
[analyzer] [tests] [quickfix] Make more test more resilient for non-defaut -std.
It is important to specify the version of the standard because tests should
test
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343735: [analyzer] Do not crash if the assumption added in
TrustNonNullChecker is… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https:/
leonardchan added inline comments.
Comment at: clang-tools-extra/clang-doc/Representation.cpp:193-216
+llvm::SmallString<16> Info::extractFileName() {
+ switch (IT) {
+ case InfoType::IT_namespace:
+// The case of anonymous namespaces is taken care of in serialization, so
+
Author: george.karpenkov
Date: Wed Oct 3 15:31:09 2018
New Revision: 343735
URL: http://llvm.org/viewvc/llvm-project?rev=343735&view=rev
Log:
[analyzer] Do not crash if the assumption added in TrustNonNullChecker is
enough to make the state unfeasible
rdar://43541814
Differential Revision: htt
STL_MSFT added inline comments.
Comment at: clang/www/get_started.html:160
http://www.cmake.org/cmake/resources/software.html";>
http://www.cmake.org/cmake/resources/software.html
+Visual Studio 2015 or later
This URL redirects to `https://c
nickdesaulniers added a comment.
Created: https://reviews.llvm.org/D52849
Repository:
rC Clang
https://reviews.llvm.org/D52248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
For types deduced from typedef's and typeof's, don't warn for duplicate
declaration specifiers in C90 unless -pedantic.
Create a third diagnostic type for duplicate declaration
nickdesaulniers abandoned this revision.
nickdesaulniers added a comment.
Well that didn't do what I wanted...(sorry, still learning arc). Going to
abandon this and push a much simpler fix.
Repository:
rC Clang
https://reviews.llvm.org/D52248
_
nickdesaulniers updated this revision to Diff 168183.
nickdesaulniers added a comment.
[SEMA] split ExtWarn dupl-decl-spec's into Extension and ExtWarn
For types deduced from typedef's and typeof's, don't warn for duplicate
declaration specifiers in C90 unless -pedantic.
Create a third diagnosti
steveire added inline comments.
Comment at: clang/www/get_started.html:197
+If you are using Visual Studio 2017:
+ cmake -G "Visual Studio 15 2017 Win64" ..\llvm
+This will generate x64 binaries by default, which should perform
better.
smeenai wrote
xbolva00 added a comment.
Yes, I am gonna work on it after I finish my some other patch :)
https://reviews.llvm.org/D52791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 168176.
xbolva00 added a comment.
- Support for Float16
https://reviews.llvm.org/D52835
Files:
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema/impcast-integer-float.c
Index: test/Sema/impcast-integer-float.c
xbolva00 updated this revision to Diff 168173.
xbolva00 added a comment.
- Check also int128_t to float
https://reviews.llvm.org/D52835
Files:
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema/impcast-integer-float.c
Index: test/Sema/impcast-integer-float.c
===
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:110
+/// are usually useless
+static unsigned AdjustPrecision(unsigned precision) {
+ return (precision * 59 + 195) / 196;
xbolva00 wrote:
> xbolva00 wrote:
> > craig.topper wrote:
> > > scano
xbolva00 updated this revision to Diff 168171.
xbolva00 added a comment.
- Addressed some comments
https://reviews.llvm.org/D52835
Files:
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema/impcast-integer-float.c
Index: test/Sema/impcast-integer-float.c
efriedma added a comment.
read_register only allows reading reserved registers because reading an
allocatable register is meaningless (the compiler can store arbitrary data in
allocatable registers).
The same applies to __getReg; given that, I would assume real code doesn't use
anything other
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:110
+/// are usually useless
+static unsigned AdjustPrecision(unsigned precision) {
+ return (precision * 59 + 195) / 196;
xbolva00 wrote:
> craig.topper wrote:
> > scanon wrote:
> > > erichke
smeenai added inline comments.
Comment at: clang/www/get_started.html:197
+If you are using Visual Studio 2017:
+ cmake -G "Visual Studio 15 2017 Win64" ..\llvm
+This will generate x64 binaries by default, which should perform
better.
Does the Win64
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:110
+/// are usually useless
+static unsigned AdjustPrecision(unsigned precision) {
+ return (precision * 59 + 195) / 196;
craig.topper wrote:
> scanon wrote:
> > erichkeane wrote:
> > > Hmm..
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
I didn't run it, but CMake-wise this looks fine. (I trust you did)
I notice some tests use
from tests.cindex.util import foo
while others use
from .util import foo
You might want to
Author: maskray
Date: Wed Oct 3 14:00:44 2018
New Revision: 343722
URL: http://llvm.org/viewvc/llvm-project?rev=343722&view=rev
Log:
[ASTMatchers] Fix DynamicASTMatchersTests again
Modified:
cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp
Modified: cfe/trunk/unittests/ASTMatchers/Dyn
Quuxplusone updated this revision to Diff 168169.
Quuxplusone edited the summary of this revision.
Quuxplusone added a reviewer: ldionne.
Quuxplusone added a comment.
Herald added a subscriber: libcxx-commits.
Rebased on master. Added @ldionne as reviewer.
Repository:
rCXX libc++
https://revi
craig.topper added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:110
+/// are usually useless
+static unsigned AdjustPrecision(unsigned precision) {
+ return (precision * 59 + 195) / 196;
scanon wrote:
> erichkeane wrote:
> > Hmm I don't terribly un
Author: maskray
Date: Wed Oct 3 13:53:53 2018
New Revision: 343721
URL: http://llvm.org/viewvc/llvm-project?rev=343721&view=rev
Log:
[test] Fix -Wunused-variable in rC343665
Modified:
cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp
Modified: cfe/trunk/unittests/ASTMatchers/Dynamic/Pa
Author: steveire
Date: Wed Oct 3 13:53:02 2018
New Revision: 343720
URL: http://llvm.org/viewvc/llvm-project?rev=343720&view=rev
Log:
Remove stray character from docs
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
URL:
Author: steveire
Date: Wed Oct 3 13:52:57 2018
New Revision: 343719
URL: http://llvm.org/viewvc/llvm-project?rev=343719&view=rev
Log:
Update documentation for correctness
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Author: steveire
Date: Wed Oct 3 13:52:45 2018
New Revision: 343716
URL: http://llvm.org/viewvc/llvm-project?rev=343716&view=rev
Log:
Sort list of matchers
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
URL:
http://llvm.org
Author: steveire
Date: Wed Oct 3 13:52:51 2018
New Revision: 343717
URL: http://llvm.org/viewvc/llvm-project?rev=343717&view=rev
Log:
Add matchers missing from dynamic AST registry
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.
Author: george.karpenkov
Date: Wed Oct 3 13:46:50 2018
New Revision: 343715
URL: http://llvm.org/viewvc/llvm-project?rev=343715&view=rev
Log:
[analyzer] [tests] [quickfix] Make the test more resilient for a non-defaut std
configuration
Modified:
cfe/trunk/test/Analysis/html_diagnostics/rele
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10883
+ precision = AdjustPrecision(precision);
+ FloatValue.toString(PrettyTargetValue, precision);
+ IntValue.toString(PrettySourceValue);
erichkeane wrote:
> I won
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10862
+ if (Source->isIntegerType() && Target->isFloatingType()) {
+const llvm::fltSemantics *FloatSem = nullptr;
+if (Target->isSpecificBuiltinType(BuiltinType::Float)) {
erichkeane w
Rakete added a comment.
There's a false positive.
int **A, *B; // false positive: declaring a variable of type 'int *'; did you
mean to declare a pointer?
And IMO this should also warn:
int **A, B; // no warning currently
https://reviews.llvm.org/D52791
___
krasimir added a comment.
Another example: we have to be careful with something like this as we don't
want to break correct code:
import x;
import a.loong.
c;
import y;
Comment at: unittests/Format/SortImportsTestJava.cpp:130
+ "// that do\n"
+
1 - 100 of 186 matches
Mail list logo
