[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. This also solves the examples in the comment of bug 32911 . https://reviews.llvm.org/D49074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D52401: Remove redundant null pointer check in operator delete

mclow.lists added a comment. In https://reviews.llvm.org/D52401#1250552, @MaskRay wrote: > > I seem to recall a problem with that > > I would like to know if your impression came from the common PWN technique > when the attacker found a heap buffer overflow :) No; that's not what I'm looking i

[PATCH] D52401: Remove redundant null pointer check in operator delete

lichray added a comment. In https://reviews.llvm.org/D52401#1250551, @MaskRay wrote: > `__free_hook` (defaults to NULL) is a user-supplied hook > (https://www.gnu.org/software/libc/manual/html_node/Hooks-for-Malloc.html). Very interesting, that means if we don't apply this patch, we essentiall

[PATCH] D52401: Remove redundant null pointer check in operator delete

MaskRay added a comment. > I seem to recall a problem with that I would like to know if your impression came from the common PWN technique when the attacker found a heap buffer overflow :) Repository: rL LLVM https://reviews.llvm.org/D52401 ___

[PATCH] D52401: Remove redundant null pointer check in operator delete

MaskRay added a comment. I just checked an extremely old version of glibc fetched from https://ftp.gnu.org/pub/gnu/glibc/ glibc-2.0.1.tar.gz 1997-02-04 03:003.7M `malloc/malloc.c` #if __STD_C void fREe(Void_t* mem) #else void fREe(mem) Void_t* mem; #endif { arena *

[PATCH] D52696: Update ifunc attribute support documentation

joerg added a comment. Yeah, I would restrict it to just mention that it depends on the target, link time editor and runtime linker. Even the concrete feature set on Linux changes with glibc versions. Repository: rL LLVM https://reviews.llvm.org/D52696 ___

[PATCH] D52696: Update ifunc attribute support documentation

emaste added a comment. Maybe "available for some architectures in at least..."? Or maybe we shouldn't bother trying to list versions, and mention it is dependent on CPU arch, linker, and rtld? Repository: rL LLVM https://reviews.llvm.org/D52696 __

[PATCH] D52401: Remove redundant null pointer check in operator delete

mclow.lists added a comment. I suspect it's fine, but I need to check some stuff on old versions of glibc (I seem to recall a problem with that). Repository: rL LLVM https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D51633: [ASTImporter] Added error handling for AST import.

a_sidorin added a comment. Herald added a subscriber: Szelethus. Hi Balasz, It's going to take some time to review the whole patch. Comment at: lib/AST/ASTImporter.cpp:194 + // FIXME: This should be the final code. + //auto ToOrErr = Importer.Import(From); + //if

[PATCH] D52445: [Index] Use locations to uniquify function-scope BindingDecl USR

MaskRay added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D52445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52705: First-pass at ARM hard/soft-float multilib driver (NOT WORKING YET)

kelledin created this revision. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. This is my first crack at implementing working ARM EABI multilib support (where multilib support is between hard/soft float ONLY, not between 32-bit and 64-bit).

r343425 - Use the container form llvm::sort(C, ...)

Author: maskray Date: Sun Sep 30 14:41:11 2018 New Revision: 343425 URL: http://llvm.org/viewvc/llvm-project?rev=343425&view=rev Log: Use the container form llvm::sort(C, ...) There are a few leftovers of rC343147 that are not (\w+)\.begin but in the form of ([-[:alnum:]>.]+)\.begin or spanning t

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 167664. EricWF added a comment. Build, cache and substitute the `SourceLocExpr` for a `StringLiteral` during constant evaluation. This is instead of the changes to `LValueBase`which stored the string value and type in addition to the original `SourceLocExpr`.

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF marked 10 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/APValue.h:66-73 +LValueBase(const Expr *E, const char *StrVal, + const ConstantArrayType *ArrTy); template -LValueBase(T P, unsigned I = 0, unsigned

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:660-678 - // Check if the range is entirely contained within a macro argument. - SourceLocation MacroArgExpansionStartForRangeBegin; - SourceLocation MacroArgExpansionStartForRangeEn

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri updated this revision to Diff 167661. lebedev.ri marked 5 inline comments as done. lebedev.ri added a comment. Address review notes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt cl

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

JonasToth added inline comments. Comment at: clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp:165 + + diag(LiteralLocation, "%0 literal suffix '%1' is not upper-case") + << LiteralType::Name << S.OldSuffix lebedev.ri wrote: > lebedev.ri wrote: > > Jon

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri updated this revision to Diff 167658. lebedev.ri marked 16 inline comments as done. lebedev.ri added a comment. Herald added subscribers: Sanitizers, llvm-commits. Addressed remaining review notes: - Fixed dangling links in docs - Don't mishandle user-defined literals - Don't ignore ma

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri added inline comments. Comment at: clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp:53 + const auto *T = dyn_cast(Node.getType().getTypePtr()); + if (!T) +return false; JonasToth wrote: > lebedev.ri wrote: > > JonasToth wrote: > > > Maybe t

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF added inline comments. Comment at: docs/LanguageExtensions.rst:2179 +Clang provides experimental builtins to support C++ standard library implementation +of `std::experimental::source_location` as specified in http://wg21.link/N4600. +With the exception of `__builtin_CO

r343420 - Fix linkage error on ProgramPoint's dump method.

Author: ericwf Date: Sun Sep 30 11:05:39 2018 New Revision: 343420 URL: http://llvm.org/viewvc/llvm-project?rev=343420&view=rev Log: Fix linkage error on ProgramPoint's dump method. Currently, ProgramPoint::dump calls the out-of-line function ProgramPoint::print. This causes libraries which incl

[PATCH] D52696: Update ifunc attribute support documentation

joerg added a comment. I think this is still too optimistic. Full support for ifunc seems to be generally limited to x86. Most other architectures lack even definitions for anonymous ifunc relocations or support proper relaxation only in limited forms. That's especially annoying when looking at

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D52334#1250439, @aaron.ballman wrote: > I've commit as r343415, thank you for the patch! I've reverted in r343418 as the commit broke some bots. htt

[clang-tools-extra] r343418 - Reverting r343415 as it breaks at least one of the bots.

Author: aaronballman Date: Sun Sep 30 10:39:39 2018 New Revision: 343418 URL: http://llvm.org/viewvc/llvm-project?rev=343418&view=rev Log: Reverting r343415 as it breaks at least one of the bots. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/37336 Modified:

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit as r343415, thank you for the patch! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[clang-tools-extra] r343415 - Allow clang-tidy to be built without a dependency on the clang static analyzer.

Author: aaronballman Date: Sun Sep 30 10:22:58 2018 New Revision: 343415 URL: http://llvm.org/viewvc/llvm-project?rev=343415&view=rev Log: Allow clang-tidy to be built without a dependency on the clang static analyzer. Patch by Stephen Kelly. Modified: clang-tools-extra/trunk/CMakeLists.txt

Re: r342827 - Fix modules build with shared library.

+rsmith (actually this time) On Sun, Sep 30, 2018 at 12:09 PM Eric Fiselier wrote: > +rsmith > > Hi All, > > Sorry, I'm not actually sure why this fix is correct.I stole both the fix > and the comment from a similar one on L150 of the module map left by > Richard Smith. > > /Eric > > On Tue, Sep

Re: r342827 - Fix modules build with shared library.

+rsmith Hi All, Sorry, I'm not actually sure why this fix is correct.I stole both the fix and the comment from a similar one on L150 of the module map left by Richard Smith. /Eric On Tue, Sep 25, 2018 at 8:36 PM Shuai Wang wrote: > I'd like to understand this better as well, in particular wha

[PATCH] D52703: Allow ifunc resolvers to accept arguments

emaste created this revision. emaste added a reviewer: DmitryPolukhin. Herald added a reviewer: javed.absar. Herald added subscribers: kristof.beyls, krytarowski. When ifunc support was added to Clang (in https://reviews.llvm.org/rC265917) it did not allow resolvers to take function arguments. Th

[PATCH] D52696: Update ifunc attribute support documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL343408: Update ifunc attribute support documentation (authored by emaste, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52696?vs=167626&id=1

r343408 - Update ifunc attribute support documentation

Author: emaste Date: Sun Sep 30 08:08:18 2018 New Revision: 343408 URL: http://llvm.org/viewvc/llvm-project?rev=343408&view=rev Log: Update ifunc attribute support documentation Previously we documented GNU binutils and glibc versions required for ifunc support, but our own lld linker and FreeBSD

[PATCH] D52696: Update ifunc attribute support documentation

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D52696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

Hahnfeld added a comment. Herald added subscribers: llvm-commits, guansong. Going through my list of reviews, this patch was reverted because of memory leaks in other changes. However, I don't think we need this anymore because Clang is raising the PTX level as needed for that CUDA version. Can

[PATCH] D52438: [CUDA] Add basic support for CUDA-10.0

Hahnfeld added a comment. I think this revision can be closed after https://reviews.llvm.org/rC342924? https://reviews.llvm.org/D52438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52437: [CUDA] Add preliminary support for CUDA 10.0

Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added a comment. I think this revision can be closed after https://reviews.llvm.org/rC342924? Repository: rC Clang https://reviews.llvm.org/D52437 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. In https://reviews.llvm.org/D50850#1250285, @wzssyqa wrote: > This is really for Clang. I guess you mean that compiler-rt directory also > need to be patched. If you take a look at the previous version of this patch https://reviews.llvm.org/D50850?id=167419, you see