[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added a comment. Please run test suite before sending a patch to review. After applying this patch the following tests failed: - test/CodeGen/target-data.c - test/Driver/mips-cs.cpp https://reviews.llvm.org/D51464 ___ cfe-commits mailing

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

wzssyqa updated this revision to Diff 167632. https://reviews.llvm.org/D51464 Files: lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

wzssyqa updated this revision to Diff 167631. https://reviews.llvm.org/D51464 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp Index: lib/Driver/ToolChains/Gnu.cpp === --- lib/Driver/ToolChains/Gnu.cpp +

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 167630. https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/CodeGen/target-data.c tes

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa added a comment. This is really for Clang. I guess you mean that compiler-rt directory also need to be patched. Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:115 + if (ABIName.empty() && (Triple.getEnvironment() == llvm::Triple::GNUABIN32)) +ABIName = "n32"; + -

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If you need this merged on your behalf, I can do so tomorrow or Monday, unless someone else gets to it first. Repository: rCTE Clang Tools Extra https://reviews.llvm.or

[PATCH] D52696: Update ifunc attribute support documentation

emaste created this revision. emaste added a reviewer: DmitryPolukhin. Herald added a subscriber: krytarowski. We documented GNU binutils and glibc versions required for ifunc support, but our own lld linker and FreeBSD's rtld also support ifuncs. https://reviews.llvm.org/D52696 Files: inclu

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri marked 8 inline comments as done. lebedev.ri added inline comments. Comment at: clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp:165 + + diag(LiteralLocation, "%0 literal suffix '%1' is not upper-case") + << LiteralType::Name << S.OldSuffix

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

JonasToth added a comment. > All those are UserDefinedLiteral, so we should be good.. > https://godbolt.org/z/PcGi0B > Also, it seems the suffix can't be set for these constants: > https://godbolt.org/z/YHTqke > So i'm not sure what to test. Can you give an example of a test? I am not suggest

[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri updated this revision to Diff 167621. lebedev.ri added a comment. As requested in https://reviews.llvm.org/D50902#1250110, actually document that `ICCK_IntegerTruncation` was only emitted by clang 7. Repository: rC Clang https://reviews.llvm.org/D50901 Files: docs/UndefinedBeha

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri updated this revision to Diff 167620. lebedev.ri marked 13 inline comments as done. lebedev.ri added a comment. Thank you for taking a look! - Rebased - Added an alias in `hicpp` module - Addressed //most// of the review comments. In https://reviews.llvm.org/D52670#1249898, @JonasToth

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri added inline comments. Comment at: clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp:33 +}; +constexpr llvm::StringLiteral IntegerLiteral::Name; +constexpr llvm::StringLiteral IntegerLiteral::SkipFirst; JonasToth wrote: > why are these declaration

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire marked an inline comment as done. steveire added a comment. > Once I'm happy, I will accept it. If @alexfh has further comments, then they > can be addressed at that time (pre or post commit). That's very reasonable, thanks. Repository: rCTE Clang Tools Extra https://reviews.llvm.o

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167619. steveire added a comment. Doc fix Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyP

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167618. steveire added a comment. Format docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangT

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

aaron.ballman added a comment. In https://reviews.llvm.org/D52334#1250166, @steveire wrote: > > I think a reasonable place would be docs/clang-tidy/index.rst in the > > "Getting Involved" area. > > Thanks, that's at least actionable, but not very specific. I've added docs > now. If they don't s

[PATCH] D52665: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC343388: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D52665 Files: lib/Headers

r343388 - [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

Author: ctopper Date: Sat Sep 29 10:49:42 2018 New Revision: 343388 URL: http://llvm.org/viewvc/llvm-project?rev=343388&view=rev Log: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics Summary: This patch adds _mm_loadu_si32 _mm_loadu_si16 _mm_storeu_si64 _mm_storeu_

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire marked 2 inline comments as done. steveire added a comment. > I think a reasonable place would be docs/clang-tidy/index.rst in the "Getting > Involved" area. That's at least actionable, but not very specific. I've added docs now. If they don't say what you want them to say, then please

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167615. steveire added a comment. Herald added a subscriber: arphaman. Docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri created this revision. lebedev.ri added reviewers: rsmith, aaron.ballman, efriedma. clang has `-Wextra-semi` (https://reviews.llvm.org/D43162), which is not dictated by the currently selected standard. While that is great, there is at least one more source of need-less semis - 'null s

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

aaron.ballman added a comment. In https://reviews.llvm.org/D52334#1249875, @steveire wrote: > @aaron.ballman Happy to add a note to the docs, but your request leaves me > wondering where? > > AFAIK, the fact that `clang-tidy` wasn't built at all when using > `CLANG_ENABLE_STATIC_ANALYZER` is no

[PATCH] D50403: [clang-format]AlignConsecutiveAssignments

owenpan requested changes to this revision. owenpan added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Format/Format.h:91-93 + /// int ddd += 12; + /// int ee += 22; + /// int f += 23; These are invalid C++

[PATCH] D52665: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. Thanks for checking - LGTM with the equivalent updates to sse2-intrinsics-fast-isel.ll https://reviews.llvm.org/D52665 ___ cfe-commits mailing

[PATCH] D52665: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

craig.topper added a comment. Looks like the load and store 64 are supported in 32-bit mode in icc https://godbolt.org/z/Wpezeu https://reviews.llvm.org/D52665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1250071, @krasimir wrote: > In https://reviews.llvm.org/D52676#1249828, @oleg.smolsky wrote: > > > In https://reviews.llvm.org/D52676#1249784, @krasimir wrote: > > > > > IMO `BinPackArguments==false` does not imply that there should

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 167611. oleg.smolsky marked an inline comment as done. oleg.smolsky added a comment. Tweaked if/else/return structure, added comments. No functional changes. Repository: rC Clang https://reviews.llvm.org/D52676 Files: lib/Format/ContinuationIndent

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri added inline comments. Comment at: docs/ReleaseNotes.rst:96 +- New alias :doc:`cert-dcl16-c + ` to :doc:`readability-uppercase-literal-suffix JonasToth wrote: > lebedev.ri wrote: > > Eugene.Zelenko wrote: > > > Please move alias after new checks. >

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

krasimir added a comment. In https://reviews.llvm.org/D52676#1249828, @oleg.smolsky wrote: > In https://reviews.llvm.org/D52676#1249784, @krasimir wrote: > > > IMO `BinPackArguments==false` does not imply that there should be a line > > break before the first arguments, only that there should no

[PATCH] D52691: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52691 Files: test/clang-tidy/performance-move-constructor-init.cpp Index: test/clang-tid

[PATCH] D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52690 Files: test/clang-tidy/misc-misplaced-const.c test/clang-tidy/misc-misplaced-const

[PATCH] D52688: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52688 Files: test/clang-tidy/fuchsia-default-arguments.cpp Index: test/clang-tidy/fuchsi

[PATCH] D52687: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52687 Files: test/clang-tidy/cppcoreguidelines-owning-memory-containers

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso added inline comments. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:1038 + + SmallString<128> NewAddNullTermExprStr; + NewAddNullTermExprStr = "\n"; aaron.ballman wrote: > JonasToth wrote: > > whisperity wrote: > > > aaron.ballman w

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso updated this revision to Diff 167597. Charusso marked 37 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. Thanks for the very in-depth review @aaron.ballman! I have not found a way to obtain the instance of Preprocessor nicely, but it is w

[PATCH] D52686: [clang-tidy] use CHECK-NOTES in test for cppgoreguidelines-avoid-goto

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52686 Files: test/clang-tidy/cppcoreguidelines-avoid-goto.cpp Index:

r343374 - Attempt to fix a -Wdocumentation-html warning. NFCI.

Author: rksimon Date: Sat Sep 29 06:30:43 2018 New Revision: 343374 URL: http://llvm.org/viewvc/llvm-project?rev=343374&view=rev Log: Attempt to fix a -Wdocumentation-html warning. NFCI. Modified: cfe/trunk/include/clang/Lex/CodeCompletionHandler.h Modified: cfe/trunk/include/clang/Lex/CodeC

[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

JonasToth updated this revision to Diff 167592. JonasToth added a comment. - fix missing file Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52684 Files: clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tidy/bugprone/SuspiciousSemicolonCheck.cpp clang-tidy/cppcoreguidel

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

JonasToth added a comment. Anything new here? Is there a LLVM foundation lawyer or something like that we can ask? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D36836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167591. JonasToth added a comment. - remove changes from lexerutils refactoring in other checks Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/IsolateDeclaratio

[PATCH] D52684: [clang-tidy] NFC refactor lexer-utils slightly to be easier to use

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. JonasToth added a project: clang-tools-extra. This patch is a small refactoring necessary for 'readability-isolate-declaration' and does n

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

Hahnfeld added a comment. In https://reviews.llvm.org/D52434#1249399, @gtbercea wrote: > In https://reviews.llvm.org/D52434#1249186, @Hahnfeld wrote: > > > In https://reviews.llvm.org/D52434#1249102, @gtbercea wrote: > > > > > You report a slow down which I am not able to reproduce actually. Do y

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167589. JonasToth added a comment. - fix spurious changes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tidy/bugprone/SuspiciousSemicolonCheck.cpp clang-tidy/cppcoregu

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167588. JonasToth marked 2 inline comments as done. JonasToth added a comment. - address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tidy/bugprone/Susp

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth marked 15 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclarationCheck.cpp:52 + const LangOptions &LangOpts) { + assert(Indirections >= 0 && "Indirections must be non-ne

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

JonasToth added a comment. Please upload the patch with full context (i belive `diff -c 999`) Comment at: lib/Format/TokenAnnotator.cpp:3054 + return true; +else if (!Style.BinPackArguments) + return true; please no `else` after return. You ca

[PATCH] D52665: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

RKSimon added a comment. Just to confirm - does icc provide the si64 intrinsics on 32-bit builds? https://reviews.llvm.org/D52665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

JonasToth added a comment. Thanks for working on this! Related as well: http://www.codingstandard.com/rule/4-2-1-ensure-that-the-u-suffix-is-applied-to-a-literal-used-in-a-context-requiring-an-unsigned-integral-expression/ I think its wort a alias is hicpp as well Please add tests that use user

r343372 - [clang][www] Fix typo. NFC

Author: kristina Date: Sat Sep 29 02:45:21 2018 New Revision: 343372 URL: http://llvm.org/viewvc/llvm-project?rev=343372&view=rev Log: [clang][www] Fix typo. NFC Fix a one letter typo in diagnostics.html. (Wanted to try it with arcanist). Patch by king6cong Differential Revision: https://review

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire marked 2 inline comments as done. steveire added a comment. @aaron.ballman Happy to add a note to the docs, but your request leaves me wondering where? AFAIK, the fact that `clang-tidy` wasn't built at all when using `CLANG_ENABLE_STATIC_ANALYZER` is not documented, so I can't just upd

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 167584. steveire added a comment. Whitespace etc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/Cla