majnemer added inline comments.
Comment at: lib/AST/DeclBase.cpp:1711-1712
+ // contexts are always skipped.
+ while (SkipRecords ? Ctx->isTransparentContext() || Ctx->isRecord()
+ : Ctx->isTransparentContext())
Ctx = Ctx->getParent();
Author: rsmith
Date: Thu Sep 27 20:18:53 2018
New Revision: 343293
URL: http://llvm.org/viewvc/llvm-project?rev=343293&view=rev
Log:
Handle dependent class template names in class template argument
deduction for new-expressions.
Modified:
cfe/trunk/lib/Sema/SemaInit.cpp
cfe/trunk/test/Sem
aaronpuchert added a comment.
Maybe you should have a look at the tests first. I thought about the semantics
that I think you are suggesting, but then we could have code like:
class SCOPED_LOCKABLE MutexLockUnlock {
public:
MutexLockUnlock(Mutex *mu1, Mutex *mu2) EXCLUSIVE_UNLOCK_FUNCTIO
aaron.ballman added a reviewer: echristo.
aaron.ballman added a comment.
Ping?
https://reviews.llvm.org/D52400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a reviewer: echristo.
aaron.ballman added a comment.
Ping?
https://reviews.llvm.org/D52384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaronpuchert added a comment.
I've thought about your concerns and the important thing is: I didn't actually
test this on a larger code base. The change makes sense to me, but maybe I'm
missing something. So maybe instead of pushing through further restrictions, I
should focus on rolling out th
Author: rsmith
Date: Thu Sep 27 18:16:43 2018
New Revision: 343285
URL: http://llvm.org/viewvc/llvm-project?rev=343285&view=rev
Log:
[cxx2a] P0641R2: (Some) type mismatches on defaulted functions only
render the function deleted instead of rendering the program ill-formed.
This change also adds a
wzssyqa updated this revision to Diff 167419.
Herald added a subscriber: dexonsmith.
https://reviews.llvm.org/D50850
Files:
include/llvm/ADT/Triple.h
lib/Support/Triple.cpp
lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp
unittests/ADT/TripleTest.cpp
Index: unittests/ADT/TripleTest.cpp
craig.topper updated this revision to Diff 167416.
craig.topper added a comment.
Add comment. Fix typo. Add preprocessor define checks to the various CPUs that
have MOVBE
https://reviews.llvm.org/D52586
Files:
lib/Basic/Targets/X86.cpp
lib/Headers/immintrin.h
test/CodeGen/movbe-builtins.
tstellar updated this revision to Diff 167413.
tstellar added a comment.
Use cmake's DEPRECATION message.
Repository:
rC Clang
https://reviews.llvm.org/D51714
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.tx
spatel added a comment.
In https://reviews.llvm.org/D30806#1248575, @efriedma wrote:
> This was merged in https://reviews.llvm.org/rC298491 .
But it got reverted soon after due to miscompiles:
https://reviews.llvm.org/rL298695
And the functionality hasn't been reimplemented AFAICT.
https://r
Looks like you fixed this in r343150, thanks!
On Tue, 25 Sep 2018 at 10:49, Vitaly Buka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/24083
>
> FAIL: Clang :: CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp (1692 of 13357)
>
delesley added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:893
private:
- SmallVector UnderlyingMutexes;
+ enum UnderlyingCapabilityKind {
+UCK_Acquired, ///< Any kind of acquired capability.
IMHO, it would make more sense to break
Author: rsmith
Date: Thu Sep 27 15:47:04 2018
New Revision: 343279
URL: http://llvm.org/viewvc/llvm-project?rev=343279&view=rev
Log:
[cxx2a] P0624R2: Lambdas with no capture-default are
default-constructible and assignable.
Added:
cfe/trunk/test/SemaCXX/cxx2a-lambda-default-ctor-assign.cpp
Mo
smeenai added a comment.
Is there anything holding this up?
Repository:
rC Clang
https://reviews.llvm.org/D51714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: george.karpenkov
Date: Thu Sep 27 15:31:13 2018
New Revision: 343276
URL: http://llvm.org/viewvc/llvm-project?rev=343276&view=rev
Log:
[analyzer] Hotfix for the bug in exploded graph printing
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
Modified: cfe/trunk/lib/StaticAna
delesley added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:2046
const CXXConstructorDecl *D = Exp->getConstructor();
if (D && D->isCopyConstructor()) {
const Expr* Source = Exp->getArg(0);
As a side note, we should probably special-case
delesley added a comment.
This looks good, and resolves an outstanding bug that was on my list. Thanks
for the patch!
Comment at: lib/Analysis/ThreadSafety.cpp:1537
void handleCall(const Expr *Exp, const NamedDecl *D, VarDecl *VD = nullptr);
+ void ExamineCallArguments(c
aaron.ballman added a comment.
In https://reviews.llvm.org/D52395#1248608, @delesley wrote:
> With respect to data, I really think these patches should be tested against
> Google's code base, because otherwise you're going to start seeing angry
> rollbacks. However, I don't work on the C++ tea
delesley added a comment.
With respect to data, I really think these patches should be tested against
Google's code base, because otherwise you're going to start seeing angry
rollbacks. However, I don't work on the C++ team any more, and I don't have
time to do it. When I was actively develop
delesley added a comment.
I have mixed feelings about this patch. When you pass an object to a function,
either by pointer or by reference, no actual load from memory has yet occurred.
Thus, there is a real risk of false positives; what you are saying is that the
function *might* read or writ
aaron.ballman added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:1970
+ // There can be default arguments, so we stop when one iterator is at end().
+ for (auto Arg = ArgBegin; Param != Params.end() && Arg != ArgEnd;
+ ++Param, ++Arg) {
aaro
efriedma closed this revision.
efriedma added a comment.
This was merged in https://reviews.llvm.org/rC298491 .
https://reviews.llvm.org/D30806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
aaronpuchert added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:1970
+ // There can be default arguments, so we stop when one iterator is at end().
+ for (auto Arg = ArgBegin; Param != Params.end() && Arg != ArgEnd;
+ ++Param, ++Arg) {
aaron
JonasToth updated this revision to Diff 167400.
JonasToth added a comment.
- last cleanup for today, testing on clang/lib looks good, but is already very
clean
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/read
spatel added a comment.
The struct hack isn't obvious to me. Without that, we would produce a load with
default alignment based on the size of the load (i132 -> align 4, etc)? But we
want to force align 1 regardless of the load size, so the __packed__ attribute
on the struct gets us that IIUC.
JonasToth updated this revision to Diff 167397.
JonasToth added a comment.
- fix doc typo
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/IsolateDeclCheck.cpp
clang-tidy/readability/IsolateDeclCheck.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343263: NFC: Fix some darwin linker warnings introduced in
r338385 (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52574?vs=167193&id=167394#toc
Repository:
rC
Author: epilk
Date: Thu Sep 27 13:36:28 2018
New Revision: 343263
URL: http://llvm.org/viewvc/llvm-project?rev=343263&view=rev
Log:
NFC: Fix some darwin linker warnings introduced in r338385
The darwin linker was complaining about Toolchains/RISCV.cpp and
Toolchains/Arch/RISCV.cpp had the same na
lebedev.ri updated this revision to Diff 167391.
lebedev.ri marked an inline comment as done and 3 inline comments as not done.
lebedev.ri added a comment.
- Rebased
Repository:
rC Clang
https://reviews.llvm.org/D50901
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Basic/Saniti
JonasToth updated this revision to Diff 167389.
JonasToth added a comment.
- bail out in transformation if there are PP directives in the source range of
the DeclStmt
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-ti
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343260: [OpenMP] Make default parallel for schedule in NVPTX
target regions in SPMD… (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52629?vs=167386&id=167387#to
Author: gbercea
Date: Thu Sep 27 13:29:00 2018
New Revision: 343260
URL: http://llvm.org/viewvc/llvm-project?rev=343260&view=rev
Log:
[OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD
mode achieve coalescing
Summary: Set default schedule for parallel for loops to schedu
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D52629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
gtbercea updated this revision to Diff 167386.
gtbercea added a comment.
Address comment.
Repository:
rC Clang
https://reviews.llvm.org/D52629
Files:
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
lib/CodeGen/CGStmtOpenMP.cpp
t
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:4103
+ScheduleKind = OMPC_SCHEDULE_static;
+Chunk = CGF.Builder.getIntN(CGM.getDataLayout().getTypeAllocSizeInBits(
+CGF.ConvertType(S.getIterationVariable()->getType())), 1);
Author: plyster
Date: Thu Sep 27 12:30:32 2018
New Revision: 343258
URL: http://llvm.org/viewvc/llvm-project?rev=343258&view=rev
Log:
Test commit. NFC
Modified:
cfe/trunk/lib/Sema/TreeTransform.h
Modified: cfe/trunk/lib/Sema/TreeTransform.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk
gtbercea created this revision.
gtbercea added reviewers: ABataev, Hahnfeld, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
Set default schedule for parallel for loops to schedule(static, 1) when using
SPMD mode on the NVPTX device offloading toolchain to ensure coalescing
ABataev added a comment.
I forgot to mention that you need an ast print test (the positive test)
Repository:
rC Clang
https://reviews.llvm.org/D52625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
JonasToth marked 9 inline comments as done.
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:211
+ std::vector Snippets;
+ Snippets.reserve(Ranges.size());
+
kbobyrev wrote:
> nit: It would be probably easier to have `Sni
JonasToth updated this revision to Diff 167381.
JonasToth marked 9 inline comments as done.
JonasToth added a comment.
- simplification on FIXME:/TODO:
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/I
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added projects: clang, OpenMP.
Herald added a subscriber: guansong.
Added new `unified_shared_memory` clause to existing OMP5.0 `requires` d
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
aaron.ballman wrote:
> JonasToth wrote:
> > kbobyrev w
JonasToth updated this revision to Diff 167377.
JonasToth added a comment.
- address review comments, most nits solved
- fix typedefs and function pointers with comments as distraction
- make memberpointer detection more accurate
- move functioning member pointer test
- clean debug output
- clean
smeenai added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.getTriple().isWindowsMSVCEnv
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343253: [OpenMP] Make default distribute schedule for NVPTX
target regions in SPMD mode… (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52434?vs=167326&id=16737
Author: gbercea
Date: Thu Sep 27 12:22:56 2018
New Revision: 343253
URL: http://llvm.org/viewvc/llvm-project?rev=343253&view=rev
Log:
[OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode
achieve coalescing
Summary: For the OpenMP NVPTX toolchain choose a default distri
ioeric added inline comments.
Comment at: clangd/FS.cpp:29
+PreambleFileStatusCache::lookup(llvm::StringRef File) const {
+ auto I = StatCache.find(File);
+ if (I != StatCache.end())
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > lock
> > After a s
ioeric updated this revision to Diff 167370.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Address review comments
- address review comments
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52419
Files:
clangd/CMakeLists.txt
clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343251: [clang][ubsan][NFC] Slight test cleanup in
preparation for D50901 (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.o
Author: lebedevri
Date: Thu Sep 27 12:07:48 2018
New Revision: 343251
URL: http://llvm.org/viewvc/llvm-project?rev=343251&view=rev
Log:
[clang][ubsan][NFC] Slight test cleanup in preparation for D50901
Reviewers: vsk, vitalybuka, filcab
Reviewed By: vitalybuka
Subscribers: cfe-commits
Differen
ioeric updated this revision to Diff 167361.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- simplify the code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52617
Files:
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
xbolva00 accepted this revision.
xbolva00 added a comment.
This revision is now accepted and ready to land.
ok, thanks
Repository:
rC Clang
https://reviews.llvm.org/D52574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
smeenai added a subscriber: rnk.
smeenai added a comment.
Adding @rnk, since this'll touch MS ABI mangling. For context, we want `struct
X` to have the same mangling as `@interface X` normally, but we want to be able
to distinguish them for the purpose of exception handling. See this diff's
sum
xbolva00 added a comment.
Herald added a subscriber: sanjoy.
Coming from https://reviews.llvm.org/D50039. This patch was accepted but never
merged?
https://reviews.llvm.org/D30806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343248: [clangd] Initial supoprt for cross-namespace
global code completion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52364?vs=167356&id=167357#toc
Repo
Author: ioeric
Date: Thu Sep 27 11:46:00 2018
New Revision: 343248
URL: http://llvm.org/viewvc/llvm-project?rev=343248&view=rev
Log:
[clangd] Initial supoprt for cross-namespace global code completion.
Summary:
When no scope qualifier is specified, allow completing index symbols
from any scope an
JonasToth marked 11 inline comments as done.
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:68
+if (Start.isInvalid() || Start.isMacroID())
+ return SourceLocation();
+ }
kbobyrev wrote:
> Also, I don't think th
ioeric updated this revision to Diff 167356.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52364
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.h
clangd/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343247: [clangd] Add more tracing to index queries. NFC
(authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52611
Files:
clang
Author: ioeric
Date: Thu Sep 27 11:23:23 2018
New Revision: 343247
URL: http://llvm.org/viewvc/llvm-project?rev=343247&view=rev
Log:
[clangd] Add more tracing to index queries. NFC
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Differential Re
NoQ added a comment.
As far as i understand, these driver-controlled thingies are for platform
owners to be able to say "hey we clearly don't want this checker to be turned
on on our platform". As long as there's no indication of that sort of issue, we
should instead keep it all in one place, w
lebedev.ri added a comment.
Thank you for the review!
Comment at: test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c:7
+////
+// Unsigned case.
+//---
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c:7
+////
jrmuizel added a comment.
Review ping
Repository:
rC Clang
https://reviews.llvm.org/D50318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343240: Fix greedy FileCheck expression in
test/Driver/mips-abi.c (authored by Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52619
Author: hahnfeld
Date: Thu Sep 27 10:27:48 2018
New Revision: 343240
URL: http://llvm.org/viewvc/llvm-project?rev=343240&view=rev
Log:
Fix greedy FileCheck expression in test/Driver/mips-abi.c
'ld{{.*}}"' seems to match the complete line for me which is failing
the test. Only allow an optional '.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343239: [analyzer] Highlight nodes which have error reports
in them in red in exploded… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
ht
Author: george.karpenkov
Date: Thu Sep 27 10:26:41 2018
New Revision: 343239
URL: http://llvm.org/viewvc/llvm-project?rev=343239&view=rev
Log:
[analyzer] Highlight nodes which have error reports in them in red in exploded
graph
Differential Revision: https://reviews.llvm.org/D52584
Modified:
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343237: Introduce completionItemKind capability support.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52616?vs=167346&id=167347#toc
Repository:
rCTE Cla
Author: kadircet
Date: Thu Sep 27 10:13:07 2018
New Revision: 343237
URL: http://llvm.org/viewvc/llvm-project?rev=343237&view=rev
Log:
Introduce completionItemKind capability support.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ilya-biryukov, ioeric, jkorous, arphaman, cfe-commits
kadircet updated this revision to Diff 167346.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
cl
usaxena95 created this revision.
Herald added subscribers: cfe-commits, mgrang.
Some files are only Statted by Clang and not read. Clang mostly uses
them for checking the existence of some files and in rare cases uses the
value of the Status to proceed further (for example while loading
module fil
sammccall added inline comments.
Comment at: clangd/FS.cpp:29
+PreambleFileStatusCache::lookup(llvm::StringRef File) const {
+ auto I = StatCache.find(File);
+ if (I != StatCache.end())
ioeric wrote:
> sammccall wrote:
> > lock
> After a second thought, I'm won
smeenai added a comment.
In https://reviews.llvm.org/D52581#1247409, @theraven wrote:
> > I would have done the same for the GNUstep RTTI here, except I don't
> > actually
> > see the code for that anywhere, and no tests seem to break either, so I
> > believe it's not upstreamed yet.
>
> I'm n
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:1251
+ // from any scope.
+ std::pair, bool> QueryScopes;
// Include-insertion and proximity scoring rely on the include st
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:325
+CodeCompletion::IncludeCandidates
+moveNonInsertingIncludesToFront(CodeCompletion::IncludeCandidates Includes) {
+ if (Includes.size() <= 1)
this seems a bit overly complicated. It does se
Hahnfeld created this revision.
Hahnfeld added reviewers: atanasyan, rnk.
Herald added subscribers: cfe-commits, jrtc27, arichardson, sdardis.
`ld{{.*}}"` seems to match the complete line for me which is failing
the test. Only allow an optional `.exe` for Windows systems as most
other tests do.
An
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdLSPServer.cpp:108
+ if (Params.capabilities.textDocument.completion.completionItemKind)
+for (CompletionItemKind Kind : *Params.capabi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343230: [OpenMP] Improve search for libomptarget-nvptx
(authored by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51686
Files:
include/clang/Driver/Options.td
lib/Driver
I updated N32 patch for clang.
Simon Atanasyan via Phabricator
于2018年9月27日周四 下午8:23写道：
>
> atanasyan added a comment.
>
> Could you please update the patch against the current trunk?
>
>
> Repository:
> rC Clang
>
> https://reviews.llvm.org/D50850
>
>
>
--
YunQiang Su
Author: hahnfeld
Date: Thu Sep 27 09:12:32 2018
New Revision: 343230
URL: http://llvm.org/viewvc/llvm-project?rev=343230&view=rev
Log:
[OpenMP] Improve search for libomptarget-nvptx
When looking for the bclib Clang considered the default library
path first while it preferred directories in LIBRAR
wzssyqa added a subscriber: rsmith.
wzssyqa added a comment.
I updated N32 patch for clang.
Simon Atanasyan via Phabricator
于2018年9月27日周四 下午8:23写道：
> atanasyan added a comment.
>
> Could you please update the patch against the current trunk?
>
> Repository:
>
> rC Clang
>
> https://reviews
wzssyqa updated this revision to Diff 167340.
https://reviews.llvm.org/D51464
Files:
lib/Basic/Targets/Mips.h
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Linux.cpp
test/CodeGen/atomics-inlining.c
test/CodeGen/mips-zero-sized-struct.c
test/
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
JonasToth wrote:
> kbobyrev wrote:
> > aaron.ballm
ioeric updated this revision to Diff 167336.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52611
Files:
clangd/index/MemIndex.cpp
clangd/index/Merge.cpp
clangd/index/dex/Dex.cpp
Index:
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
kbobyrev wrote:
> aaron.ballman wrote:
> > lebedev.ri
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Thanks Peter. LGTM!
https://reviews.llvm.org/D52595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
JonasToth added a comment.
There are testcases with macro around line 100 in the default tests. I
am not sure yet if `#define I_DECLS int i1, i2, i3;` should be
diagnosed, but the other cases should.
Am 27.09.2018 um 16:28 schrieb Kirill Bobyrev via Phabricator:
> kbobyrev added a comment.
>
>
donat.nagy added a comment.
Yes, moving StdCLibraryFunctionsChecker to an always-loaded package is probably
a better solution than adding this one particular dependency link. (Evaluating
these functions may be useful for other checkers as well, although it does not
seem to change the results of
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
stable_partition on objects is slow (due to copies). Do it on pointers
instead.
Repository:
rCTE Clang Tools Extra
https://reviews.llv
kbobyrev added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
aaron.ballman wrote:
> lebedev.ri wrote:
> > kbobyrev w
kadircet updated this revision to Diff 167332.
kadircet added a comment.
- Minimum CompletionItemKind is Text.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
clangd/Protocol.h
Index: c
filcab added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:305
enum ImplicitConversionCheckKind : unsigned char {
-ICCK_IntegerTruncation = 0,
+ICCK_IntegerTruncation = 0, // Legacy, no longer used.
+ICCK_UnsignedIntegerTruncation = 1,
Hahnfeld accepted this revision.
Hahnfeld added a comment.
In https://reviews.llvm.org/D52434#1248032, @gtbercea wrote:
> That is the intention. I just took out that part from here to not confuse
> things since I wanted to have that as a separate patch. :)
Ok, perfect. I was probably confused
gtbercea added a comment.
In https://reviews.llvm.org/D52434#1248012, @Hahnfeld wrote:
> Should we also change the default `schedule` to `static, 1`? I know that's
> not really needed for `teams distribute parallel for` (because the new
> default `dist_schedule` only leaves one iteration per th
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Prot
filcab created this revision.
filcab added reviewers: rjmccall, kcc, rsmith.
Repository:
rC Clang
https://reviews.llvm.org/D52615
Files:
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
lebedev.ri wrote:
> kbobyrev wrote:
> > JonasToth
1 - 100 of 162 matches
Mail list logo
