[PATCH] D52089: [clangd] Get rid of AST matchers in SymbolCollector. NFC

ioeric added a comment. In https://reviews.llvm.org/D52089#1235777, @malaperle wrote: > why? I wanted to get some numbers and update the patch summary, but somehow forgot. Sorry about that and thanks for asking! The AST matcher pops up in performance profile. Although not the most expensive

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

ioeric added inline comments. Comment at: clangd/index/FileIndex.h:93 std::pair indexAST(ASTContext &AST, std::shared_ptr PP, + bool IndexMacros = false, sammccall wrote: > I'm concerned about the proliferation of parameters here. (Not new with this >

[PATCH] D52093: [ToolChains] Linux.cpp: Use the same style across all all multi-arch includes. NFC.

lebedev.ri added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:674 // removing them. - "/usr/include/i686-linux-gnu/64", "/usr/include/i486-linux-gnu/64"}; const StringRef X86MultiarchIncludeDirs[] = { This *might* be what clang-form

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, Szelethus, jfb, mikhail.ramalho. A test introduced in https://reviews.llvm.org/rC329780 was disabled in https://reviews.

[PATCH] D52132: [CMake] Use cannonical triples for Fuchsia runtimes

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. This ensures that whether the user uses short or cannonical version of the triple, Clang will still find the runtimes under the cannonical triple name. Repository: rC Cl

[PATCH] D52114: [analyzer] Further printing improvements: use declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rC342316: [analyzer] Further printing improvements: use declarations, (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.o

r342317 - [analyzer] Temporary disabling svalbuilder-rearrange-comparisons test

Author: george.karpenkov Date: Fri Sep 14 19:35:06 2018 New Revision: 342317 URL: http://llvm.org/viewvc/llvm-project?rev=342317&view=rev Log: [analyzer] Temporary disabling svalbuilder-rearrange-comparisons test As debug printing has changed, and format was not guaranteed to be stable. Artem is

r342316 - [analyzer] Further printing improvements: use declarations,

Author: george.karpenkov Date: Fri Sep 14 19:34:45 2018 New Revision: 342316 URL: http://llvm.org/viewvc/llvm-project?rev=342316&view=rev Log: [analyzer] Further printing improvements: use declarations, skip pointers whenever redundant, use unique prefixes. Differential Revision: https://reviews

[PATCH] D52113: Generate unique identifiers for Decl objects

This revision was automatically updated to reflect the committed changes. Closed by commit rC342315: Generate unique identifiers for Decl objects (authored by george.karpenkov, committed by ). Changed prior to commit: https://reviews.llvm.org/D52113?vs=165564&id=165631#toc Repository: rC Cla

r342315 - Generate unique identifiers for Decl objects

Author: george.karpenkov Date: Fri Sep 14 19:03:58 2018 New Revision: 342315 URL: http://llvm.org/viewvc/llvm-project?rev=342315&view=rev Log: Generate unique identifiers for Decl objects The generated identifier is stable across multiple runs, and can be a great visualization or debugging aide.

r342314 - [analyzer] Generate and use stable identifiers for LocationContext

Author: george.karpenkov Date: Fri Sep 14 19:03:36 2018 New Revision: 342314 URL: http://llvm.org/viewvc/llvm-project?rev=342314&view=rev Log: [analyzer] Generate and use stable identifiers for LocationContext Those are not created in the allocator. Since they are created fairly rarely, a counter

r342313 - [analyzer] Dump reproducible identifiers for statements in exploded graph in store

Author: george.karpenkov Date: Fri Sep 14 19:03:17 2018 New Revision: 342313 URL: http://llvm.org/viewvc/llvm-project?rev=342313&view=rev Log: [analyzer] Dump reproducible identifiers for statements in exploded graph in store Differential Revision: https://reviews.llvm.org/D51826 Modified:

r342312 - [analyzer] Use correct end-of-line character when printing statements for exploded graph

Author: george.karpenkov Date: Fri Sep 14 19:02:56 2018 New Revision: 342312 URL: http://llvm.org/viewvc/llvm-project?rev=342312&view=rev Log: [analyzer] Use correct end-of-line character when printing statements for exploded graph Prevents bad centering. Differential Revision: https://reviews.

[PATCH] D51824: StmtPrinter: allow customizing the end-of-line character

This revision was automatically updated to reflect the committed changes. Closed by commit rL342311: StmtPrinter: allow customizing the end-of-line character (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

r342311 - StmtPrinter: allow customizing the end-of-line character

Author: george.karpenkov Date: Fri Sep 14 19:02:31 2018 New Revision: 342311 URL: http://llvm.org/viewvc/llvm-project?rev=342311&view=rev Log: StmtPrinter: allow customizing the end-of-line character Differential Revision: https://reviews.llvm.org/D51824 Modified: cfe/trunk/include/clang/AST

r342309 - Support generating unique identifiers for Stmt objects

Author: george.karpenkov Date: Fri Sep 14 19:01:47 2018 New Revision: 342309 URL: http://llvm.org/viewvc/llvm-project?rev=342309&view=rev Log: Support generating unique identifiers for Stmt objects The generated identifiers are stable across multiple runs, and can be a great debug or visualizatio

r342310 - [analyzer] Dump unique identifiers for statements in exploded graph

Author: george.karpenkov Date: Fri Sep 14 19:02:09 2018 New Revision: 342310 URL: http://llvm.org/viewvc/llvm-project?rev=342310&view=rev Log: [analyzer] Dump unique identifiers for statements in exploded graph Differential Revision: https://reviews.llvm.org/D51823 Modified: cfe/trunk/lib/St

[PATCH] D51822: Support generating unique identifiers for Stmt objects

This revision was automatically updated to reflect the committed changes. Closed by commit rC342309: Support generating unique identifiers for Stmt objects (authored by george.karpenkov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51822?vs=164547&id=165625#toc Repository

[PATCH] D51821: [analyzer] Skip printing duplicate nodes, even if nodes have multiple predecessors/successors

This revision was automatically updated to reflect the committed changes. Closed by commit rC342308: [analyzer] Skip printing duplicate nodes, even if nodes have multiple… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

r342308 - [analyzer] Skip printing duplicate nodes, even if nodes have multiple predecessors/successors

Author: george.karpenkov Date: Fri Sep 14 19:01:26 2018 New Revision: 342308 URL: http://llvm.org/viewvc/llvm-project?rev=342308&view=rev Log: [analyzer] Skip printing duplicate nodes, even if nodes have multiple predecessors/successors Still generate a node, but leave the redundant field empty.

r342307 - [modules] Don't bother creating a global module fragment when building a

Author: rsmith Date: Fri Sep 14 18:59:39 2018 New Revision: 342307 URL: http://llvm.org/viewvc/llvm-project?rev=342307&view=rev Log: [modules] Don't bother creating a global module fragment when building a header module. Modified: cfe/trunk/lib/Sema/Sema.cpp Modified: cfe/trunk/lib/Sema/Sema

[PATCH] D52089: [clangd] Get rid of AST matchers in SymbolCollector. NFC

malaperle added a comment. why? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342305 - [modules] Driver support for precompiling a collection of files as a single

Author: rsmith Date: Fri Sep 14 18:21:16 2018 New Revision: 342305 URL: http://llvm.org/viewvc/llvm-project?rev=342305&view=rev Log: [modules] Driver support for precompiling a collection of files as a single action. Added: cfe/trunk/test/Driver/header-module.cpp Modified: cfe/trunk/inclu

r342306 - [modules] Support use of -E on modules built from the command line.

Author: rsmith Date: Fri Sep 14 18:21:18 2018 New Revision: 342306 URL: http://llvm.org/viewvc/llvm-project?rev=342306&view=rev Log: [modules] Support use of -E on modules built from the command line. Modified: cfe/trunk/lib/Frontend/FrontendAction.cpp cfe/trunk/lib/Frontend/FrontendActio

r342304 - [modules] Frontend support for building a header module from a list of

Author: rsmith Date: Fri Sep 14 18:21:15 2018 New Revision: 342304 URL: http://llvm.org/viewvc/llvm-project?rev=342304&view=rev Log: [modules] Frontend support for building a header module from a list of headaer files. Added: cfe/trunk/test/Modules/Inputs/no-module-map/ cfe/trunk/test/Mod

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

rsmith added a comment. Looks good other than the warning, which I don't yet understand. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4683-4686 + "Member '%0' marked with 'exclude_from_explicit_instantiation' attribute is " + "not defined but an explicit templ

[PATCH] D52113: Generate unique identifiers for Decl objects

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. We're getting pretty good at it ^^ https://reviews.llvm.org/D52113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

rsmith accepted this revision. rsmith added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:340 +return; + StringRef Filename = File->getName(); + if (!FileMatchesDepCriteria(Filename.data(), FileType)) vsapsai wrote: > rsmith wrote: > >

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

vsapsai added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:300-304 StringRef Filename = FE->getName(); if (!FileMatchesDepCriteria(Filename.data(), FileType)) return; AddFilename(llvm::sys::path::remove_leading_dotslash(Filename)); --

[PATCH] D51910: [Modules] Add platform feature to requires clause

rsmith added inline comments. Comment at: docs/Modules.rst:476-477 + +*platform-environment* + A platform-environment variant (e.g. ``linux-gnueabi``, ``windows-msvc``) is available. What is the reason to allow these to be combined into a single feature name

[PATCH] D51910: [Modules] Add platform feature to requires clause

aprantl added inline comments. Comment at: lib/Basic/Module.cpp:101 + // variant (2), the simulator is hardcoded as part of the platform name. Both + // forms above should match "iossimulator" and "ios-simulator" features. + if (Target.getTriple().isOSDarwin() && PlatformEnv.e

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

rsmith added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:340 +return; + StringRef Filename = File->getName(); + if (!FileMatchesDepCriteria(Filename.data(), FileType)) Should we really be using the (arbitrary) name of the file from th

[PATCH] D51910: [Modules] Add platform feature to requires clause

aprantl added inline comments. Comment at: docs/Modules.rst:470 +*platform variant* + A specific os/platform variant (e.g. ``ios``, ``macos``, ``android``, ``win32``, ``linux``, etc) is available. aprantl wrote: > Does this work with platforms+environment com

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

rsmith added inline comments. Comment at: lib/Frontend/DependencyFile.cpp:325 +void DFGImpl::HasInclude(SourceLocation Loc, const FileEntry *File) { + if (!File) +return; vsapsai wrote: > rsmith wrote: > > Have you thought about whether we should add a depen

[PATCH] D51910: [Modules] Add platform feature to requires clause

bruno updated this revision to Diff 165612. bruno added a comment. Addressed Adrian's review. Added support to consider the environment and well the combination platform-environment. @aprantl also handled multiple variants of simulator combinations. https://reviews.llvm.org/D51910 Files: do

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: lib/Frontend/DependencyFile.cpp:325 +void DFGImpl::HasInclude(SourceLocation Loc, const FileEntry *File) { + if (!File) +return; rsmith wrote: > Have you thought about wheth

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

vsapsai marked 3 inline comments as done. vsapsai added inline comments. Comment at: include/clang/Lex/PPCallbacks.h:263 + /// \brief Callback invoked when a has_include directive is read. + virtual void HasInclude(SourceLocation Loc, const FileEntry *File) { + } -

[PATCH] D51808: [CUDA] Ignore uncallable functions when we check for usual deallocators.

rsmith added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551 if (Decl->isMain() || !Decl->isUserProvided() || -Decl->isUsualDeallocationFunction() || -Decl->isCopyAssignmentOperator() || Decl->isMoveAssignm

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

vsapsai updated this revision to Diff 165610. vsapsai added a comment. - Improve tests, fix -MMD, address comments. https://reviews.llvm.org/D30882 Files: clang/include/clang/Lex/PPCallbacks.h clang/lib/Frontend/DependencyFile.cpp clang/lib/Lex/PPMacroExpansion.cpp clang/test/Frontend/d

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

vsapsai commandeered this revision. vsapsai added a reviewer: pete. vsapsai added a comment. Taking over the change, I'll address the reviewers' comments. https://reviews.llvm.org/D30882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is definitely the right thing to do, thanks for finding it! I've got a long comment about how everything used to be simpler in the good old days :-) I'm itching to refactor a bit, bu

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 165604. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

MaskRay added inline comments. Comment at: test/Analysis/cstring-syntax.c:49 + strlcat(dest, "0123456789", badlen / 2); + strlcat(dest, "0123456789", badlen); // expected-warning {{The third argument allows to potentially copy more bytes than it should. Replace with the value

r342290 - test/Driver/output-file-cleanup.c: delete non-readable temporary file

Author: maskray Date: Fri Sep 14 14:36:35 2018 New Revision: 342290 URL: http://llvm.org/viewvc/llvm-project?rev=342290&view=rev Log: test/Driver/output-file-cleanup.c: delete non-readable temporary file %t-dir/2.c made tools (rsync, ripgrep, ...) sad (EACCES warning). Modified: cfe/trunk/te

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall added a comment. Addressed the comments I was sure about. A couple of open questions in SemaCodeComplete about the formatting of the completions, but want to know what you think. Comment at: lib/Sema/SemaCodeComplete.cpp:8046 + !EC && It != vfs::directory_ite

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall updated this revision to Diff 165593. sammccall marked 9 inline comments as done. sammccall added a comment. Unify common completion code from angled/quoted strings in Lexer. Handle #include paths with \ on windows (normalize them to /) Document why we picked particular extensions for he

Re: [clang-tools-extra] r342036 - Fix buildbots after r342027

Oh, I see. Thank you very much for fixing it! I had concerns about platform dependence, but I’ve seen seen some tests in libcxx which use `if […]` so I thought it should be alright (because there was no REQUIRES there). I can see now, that it is a Darwin test, my bad. Again, thank you very much

[PATCH] D51905: Front-end of the implementation of the interleaving algorithm

vlad.tsyrklevich added a comment. In https://reviews.llvm.org/D51905#1234308, @zhaomo wrote: > In https://reviews.llvm.org/D51905#1231383, @vlad.tsyrklevich wrote: > > > This change causes all compiler-rt cfi tests to be UNSUPPORTED for me > > locally, do you have any idea why that might be? The

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thank you for working on this! In https://reviews.llvm.org/D52120#1235480, @lebedev.ri wrote: > In https://reviews.llvm.org/D52120#1235479, @shuaiwang wrote: > > > @lebedev.ri could yo

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:199 +if (Append) + RemainingBufferLen -= 1; +if (RemainingBufferLen < ILRawVal) MaskRay wrote: > `RemainingBufferLen` is `uint64_t`. Can the

Re: [clang-tools-extra] r342036 - Fix buildbots after r342027

That construct does not work on Windows, where we don't use bash. We use the lit internal shell, which doesn't support 'if [ ...]'. I marked it REQUIRES: shell in r342282. On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: omtcyfz > Date:

[clang-tools-extra] r342282 - Mark index-tools.test as REQUIRES: shell so that it does not run with the internal lit shell which does not support "if"

Author: rnk Date: Fri Sep 14 13:51:07 2018 New Revision: 342282 URL: http://llvm.org/viewvc/llvm-project?rev=342282&view=rev Log: Mark index-tools.test as REQUIRES: shell so that it does not run with the internal lit shell which does not support "if" Modified: clang-tools-extra/trunk/test/cl

r342281 - Relax assumption about default method calling convention in new test

Author: rnk Date: Fri Sep 14 13:50:39 2018 New Revision: 342281 URL: http://llvm.org/viewvc/llvm-project?rev=342281&view=rev Log: Relax assumption about default method calling convention in new test Modified: cfe/trunk/test/CodeGenCXX/debug-info-lambda.cpp Modified: cfe/trunk/test/CodeGenCXX

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

MaskRay added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:164 + // - sizeof(dst) + if (Append && isSizeof(LenArg, DstArg)) +return true; george.karpenkov wrote: > george.karpenkov wrote: > > george.karpenkov wrote: > >

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 added a comment. ping @GorNishanov Repository: rC Clang https://reviews.llvm.org/D51741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

lebedev.ri added a comment. In https://reviews.llvm.org/D52120#1235479, @shuaiwang wrote: > @lebedev.ri could you help test whether this fully resolves PR38891? Thanks! That is what i'm trying to do here :) Still waiting for the build to finish... Repository: rC Clang https://reviews.llvm.

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

shuaiwang added a comment. @lebedev.ri could you help test whether this fully resolves PR38891? Thanks! Repository: rC Clang https://reviews.llvm.org/D52120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

shuaiwang created this revision. shuaiwang added reviewers: lebedev.ri, JonasToth. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin, szepet, xazax.hun. Herald added a reviewer: george.karpenkov. This is a follow up of https://reviews.llvm.org/D52008 and should make the

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342271: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer. (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.

r342271 - [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

Author: shuaiwang Date: Fri Sep 14 13:07:18 2018 New Revision: 342271 URL: http://llvm.org/viewvc/llvm-project?rev=342271&view=rev Log: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer. Summary: We used to treat an `Expr` mutated whenever it's passed as non-const reference ar

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, jdoerfert. getLoopID has different control flow for two cases: If there is a single loop latch and for any other number of loop latches (0 and more than one). The latter case should return the same result if there is a single

[clang-tools-extra] r342267 - [NFC][clangd] silence pedantic extra '; ' warning

Author: jonastoth Date: Fri Sep 14 12:42:37 2018 New Revision: 342267 URL: http://llvm.org/viewvc/llvm-project?rev=342267&view=rev Log: [NFC][clangd] silence pedantic extra ';' warning Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified: clang-tools-extra/trunk/

[PATCH] D51789: [clang] Add the no_extern_template attribute

ldionne updated this revision to Diff 165569. ldionne added a comment. Change no_extern_template to exclude_from_explicit_instantiation Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clan

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 165568. JonasToth added a comment. - fix actually use clang-analyses correctly Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381 +FunctionParmMutationAnalyzer::findMutation(const ParmVarDecl *Parm) { + const auto Memoized = Results.find(

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Soonish it might be able to do so ;) Am 14.09.2018 um 17:13 schrieb Dávid Bolvanský via Phabricator: > xbolva00 added a comment. > > Yeah, it would be super useful if Clang can add const to all places where > possible :) love this work, great! > > Repository: > >

[PATCH] D52117: Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata.

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, amusman, ABataev, tyler.nowicki. Meinersbur added a dependency: D52116: Introduce llvm.loop.parallel_accesses and llvm.access.group metadata.. Instead of generating llvm.mem.parallel_loop_access metadata, generate llvm.access

[PATCH] D52113: Generate unique identifiers for Decl objects

george.karpenkov created this revision. george.karpenkov added reviewers: NoQ, rsmith, aprantl. https://reviews.llvm.org/D52113 Files: clang/include/clang/AST/DeclBase.h clang/lib/AST/DeclBase.cpp Index: clang/lib/AST/DeclBase.cpp

[clang-tools-extra] r342261 - [clangd] Work around compiler macro expansion bugs(?) in completion tests

Author: sammccall Date: Fri Sep 14 11:49:16 2018 New Revision: 342261 URL: http://llvm.org/viewvc/llvm-project?rev=342261&view=rev Log: [clangd] Work around compiler macro expansion bugs(?) in completion tests Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified:

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

shuaiwang added a comment. In https://reviews.llvm.org/D52008#1234828, @JonasToth wrote: > The `std::move` as cast is a follow up patch? Yes I'll send a follow up patch. Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381 +FunctionParmMutationAnalyzer::findMutation(const P

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

shuaiwang updated this revision to Diff 165552. shuaiwang marked 8 inline comments as done. shuaiwang added a comment. Addressed review comments. Repository: rC Clang https://reviews.llvm.org/D52008 Files: include/clang/Analysis/Analyses/ExprMutationAnalyzer.h lib/Analysis/ExprMutationAn

[clang-tools-extra] r342252 - [modernize-use-transparent-functors] TypeLocs can be implicitly created, don't crash when encountering those.

Author: d0k Date: Fri Sep 14 11:05:30 2018 New Revision: 342252 URL: http://llvm.org/viewvc/llvm-project?rev=342252&view=rev Log: [modernize-use-transparent-functors] TypeLocs can be implicitly created, don't crash when encountering those. Modified: clang-tools-extra/trunk/clang-tidy/moderni

[PATCH] D51789: [clang] Add the no_extern_template attribute

ldionne added a comment. In https://reviews.llvm.org/D51789#1235113, @rsmith wrote: > In https://reviews.llvm.org/D51789#1235100, @ldionne wrote: > > > In https://reviews.llvm.org/D51789#1235096, @rsmith wrote: > > > > > OK, so the semantics of this attribute are "explicit instantiation > > > de

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

yaxunl added a comment. In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote: > Ping! Do you still plan to do this? :) Sorry I caught up in something else. Since there are some subsequent commits, it may take some efforts to revert it. Repository: rC Clang https://reviews.llvm.org

[PATCH] D51946: [analyzer] Remove PseudoConstantAnalysis

This revision was automatically updated to reflect the committed changes. Closed by commit rL342246: Remove PseudoConstantAnalysis (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51946 Files: cfe/trunk/include/cl

r342246 - Remove PseudoConstantAnalysis

Author: shuaiwang Date: Fri Sep 14 10:27:27 2018 New Revision: 342246 URL: http://llvm.org/viewvc/llvm-project?rev=342246&view=rev Log: Remove PseudoConstantAnalysis Summary: It's not used anywhere for years. The last usage is removed in https://reviews.llvm.org/rL198476 in 2014. Subscribers: m

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

george.karpenkov added a comment. This looks very useful! Repository: rC Clang https://reviews.llvm.org/D52008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51946: [analyzer] Remove PseudoConstantAnalysis

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Great, thanks! Seems that your code is a better version of this check. Repository: rC Clang https://reviews.llvm.org/D51946 __

[PATCH] D51789: [clang] Add the no_extern_template attribute

rsmith added a comment. In https://reviews.llvm.org/D51789#1235100, @ldionne wrote: > In https://reviews.llvm.org/D51789#1235096, @rsmith wrote: > > > OK, so the semantics of this attribute are "explicit instantiation > > declarations or definitions applied to the enclosing class do not apply to

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thanks! A substitution would probably need to be defined in a different file though. https://reviews.llvm.org/D52036 ___ cfe-

[PATCH] D51789: [clang] Add the no_extern_template attribute

ldionne added a comment. In https://reviews.llvm.org/D51789#1235096, @rsmith wrote: > In https://reviews.llvm.org/D51789#1234903, @ldionne wrote: > > > I think now's a good time to bikeshed the name of the attribute if you have > > other suggestions. > > > OK, so the semantics of this attribute

[PATCH] D51789: [clang] Add the no_extern_template attribute

rsmith added a comment. In https://reviews.llvm.org/D51789#1234903, @ldionne wrote: > I think now's a good time to bikeshed the name of the attribute if you have > other suggestions. OK, so the semantics of this attribute are "explicit instantiation declarations or definitions applied to the

[PATCH] D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D51411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

Anastasia added a comment. Ping! Do you still plan to do this? :) Repository: rC Clang https://reviews.llvm.org/D43783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3126 + } else { +templateParameters = nullptr;//llvm::DINodeArray().get(); + } JDevlieghere wrote: > What's the meaning of this comment? Hmm... That should be removed.

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

ioeric added a comment. In https://reviews.llvm.org/D52078#1234667, @ilya-biryukov wrote: > ~1% increase in memory usage seems totally fine. Actually surprised it's that > small. Tested on a larger file: it's ~5% for `ClangdServer.cpp`. I think it's still worth it for the speedup.

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

ioeric updated this revision to Diff 165517. ioeric added a comment. - Move macro collection to indexTopLevelDecls. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52078 Files: clangd/ClangdServer.cpp clangd/FindSymbols.cpp clangd/XRefs.cpp clangd/index/FileIndex.cpp c

r342240 - [clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit instantiation and PCH

Author: hans Date: Fri Sep 14 08:18:30 2018 New Revision: 342240 URL: http://llvm.org/viewvc/llvm-project?rev=342240&view=rev Log: [clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit instantiation and PCH The code in ASTContext::DeclMustBeEmitted was supposed to handle

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric updated this revision to Diff 165516. ioeric added a comment. - another cleanup... Repository: rC Clang https://reviews.llvm.org/D52098 Files: include/clang/Index/IndexingAction.h lib/Index/IndexingAction.cpp unittests/CMakeLists.txt unittests/Index/CMakeLists.txt unittests/

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

xbolva00 added a comment. Yeah, it would be super useful if Clang can add const to all places where possible :) love this work, great! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D52097: [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer - NFC

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D52097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric updated this revision to Diff 165514. ioeric added a comment. - remove debug message. Repository: rC Clang https://reviews.llvm.org/D52098 Files: include/clang/Index/IndexingAction.h lib/Index/IndexingAction.cpp unittests/CMakeLists.txt unittests/Index/CMakeLists.txt unittes

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, mgorny. Also added unit tests for the index library; lit+c-index-test is painful... Repository: rC Clang https://reviews.llvm.org/D52098 Files: include/clang/Index/IndexingAction.h

[PATCH] D52097: [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer - NFC

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: OpenMP, clang. Herald added subscribers: cfe-commits, jfb, guansong. Move declarations for `OMPClauseReader`, `OMPClauseWrit

[PATCH] D51789: [clang] Add the no_extern_template attribute

ldionne added a comment. I think now's a good time to bikeshed the name of the attribute if you have other suggestions. Repository: rC Clang https://reviews.llvm.org/D51789 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D51789: [WIP][clang] Add the no_extern_template attribute

ldionne updated this revision to Diff 165507. ldionne added a comment. Fix the tests and remove some warnings that I wasn't able to generate properly (to avoid false positives). Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

This revision was automatically updated to reflect the committed changes. Closed by commit rC342238: [clang] Make sure attributes on member classes are applied properly (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D51997?vs=165375&id=165502#toc Reposi

r342238 - [clang] Make sure attributes on member classes are applied properly

Author: ldionne Date: Fri Sep 14 07:07:16 2018 New Revision: 342238 URL: http://llvm.org/viewvc/llvm-project?rev=342238&view=rev Log: [clang] Make sure attributes on member classes are applied properly Summary: Attributes on member classes of class templates and member class templates of class te

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 165497. JonasToth added a comment. - update to ExprMutAnalyzer living in clang now Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCh

  1   2   >