r341778 - PR33222: Require the declared return type not the actual return type to

Author: rsmith Date: Sun Sep 9 23:35:32 2018 New Revision: 341778 URL: http://llvm.org/viewvc/llvm-project?rev=341778&view=rev Log: PR33222: Require the declared return type not the actual return type to match when checking for redeclaration of a function template. This properly handles differen

r341775 - Part of PR33222: defer enforcing return type mismatch for dependent

Author: rsmith Date: Sun Sep 9 22:32:13 2018 New Revision: 341775 URL: http://llvm.org/viewvc/llvm-project?rev=341775&view=rev Log: Part of PR33222: defer enforcing return type mismatch for dependent friend function declarations of class templates. Modified: cfe/trunk/include/clang/Sema/Sema

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

This revision was automatically updated to reflect the committed changes. Closed by commit rC341766: [OpenMP] Add support for nested 'declare target' directives (authored by kli, committed by ). Changed prior to commit: https://reviews.llvm.org/D51378?vs=164037&id=164596#toc Repository: rC C

r341766 - [OpenMP] Add support for nested 'declare target' directives

Author: kli Date: Sun Sep 9 19:07:09 2018 New Revision: 341766 URL: http://llvm.org/viewvc/llvm-project?rev=341766&view=rev Log: [OpenMP] Add support for nested 'declare target' directives Add the capability to nest multiple declare target directives - including header files within a declare ta

[PATCH] D51299: [python bindings] Expose template argument API for Type

jbcoe added a comment. I can commit this. Thanks for the great work! Repository: rC Clang https://reviews.llvm.org/D51299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

kbobyrev added a comment. In https://reviews.llvm.org/D51297#1225546, @ilya-biryukov wrote: > I would stamp this from my side, but concerns whether we should recommend > YCM's LSP-based completer instead are probably still there. > @sammccall, WDYT? Yes, I can see your point, but I think this

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/dexplorer/Dexplorer.cpp:39 + +// FIXME(kbobyrev): Make this an actual REPL: probably use LLVM Command Line +// library for parsing flags and arguments. ilya-biryukov wrote: > Maybe we could expo

[PATCH] D51299: [python bindings] Expose template argument API for Type

kjteske added a comment. Thanks for the review @jbcoe , could you commit this for me? Repository: rC Clang https://reviews.llvm.org/D51299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

a_sidorin added a comment. Hi Gabor, The change looks mostly fine but the difference with ASTReader approach disturbs me a bit. Comment at: lib/AST/ASTImporter.cpp:1441 + To->setInit(ToInit); + if (From->isInitKnownICE()) { +EvaluatedStmt *Eval = To->ensureEvaluatedStmt(

[PATCH] D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer

shuaiwang added a comment. Ping :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r341763 - [Sema] Make typo correction slightly more efficient

Author: maskray Date: Sun Sep 9 10:20:03 2018 New Revision: 341763 URL: http://llvm.org/viewvc/llvm-project?rev=341763&view=rev Log: [Sema] Make typo correction slightly more efficient edit_distance returns UpperBound+1 if the distance will exceed UpperBound. We can subtract 1 from UpperBound a

[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

hintonda added a comment. Sorry for the late comment... Are you amending an llvm commit or a clang commit? The reason I ask is that if I amend an llvm commit, I have to update around 78 targets (llvm + clang + libcxx + libcxxabi + libunwind), but if I amend a clang commit, I only have to upda

r341761 - Fix build bots after a mistake in r341760

Author: hamzasood Date: Sun Sep 9 06:12:53 2018 New Revision: 341761 URL: http://llvm.org/viewvc/llvm-project?rev=341761&view=rev Log: Fix build bots after a mistake in r341760 Modified: cfe/trunk/lib/Tooling/InterpolatingCompilationDatabase.cpp Modified: cfe/trunk/lib/Tooling/Interpolating

[PATCH] D51321: [Tooling] Improve handling of CL-style options

hamzasood added a comment. Thanks for the help with this. I reverted most of my changes (including the parameterised tests) before committing; I think I implemented all of your suggestions. Repository: rL LLVM https://reviews.llvm.org/D51321 ___

[PATCH] D51321: [Tooling] Improve handling of CL-style options

This revision was automatically updated to reflect the committed changes. Closed by commit rL341760: [Tooling] Improve handling of CL-style options (authored by hamzasood, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51321?vs=163098

r341760 - [Tooling] Improve handling of CL-style options

Author: hamzasood Date: Sun Sep 9 05:06:35 2018 New Revision: 341760 URL: http://llvm.org/viewvc/llvm-project?rev=341760&view=rev Log: [Tooling] Improve handling of CL-style options This patch fixes the handling of clang-cl options in InterpolatingCompilationDatabase. They were previously ignor