craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
Herald added subscribers: cfe-commits, kristina.
This is the clang side of https://reviews.llvm.org/D51769. The llvm intrinsics
now return two results instead of using an out parameter.
Repository:
rC Clang
ht
devnexen updated this revision to Diff 164355.
devnexen added a comment.
- Correcting misleading message and advising proper fix.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
takuto.ikuta marked 4 inline comments as done.
takuto.ikuta added inline comments.
Comment at: clang/include/clang/Basic/LangOptions.def:117
LANGOPT(Digraphs , 1, 0, "digraphs")
+LANGOPT(DllexportInlines , 1, 1, "If dllexport a class should dllexport
implicit inline m
takuto.ikuta updated this revision to Diff 164353.
takuto.ikuta edited the summary of this revision.
takuto.ikuta added a comment.
Herald added a subscriber: dschuff.
Make patch closer to Nico's original implementation, but warns local static
variable instead of detecting it.
In checkClassLevelDL
devnexen added inline comments.
Comment at: test/Analysis/cstring-syntax.c:49
+ strlcat(dest, "0123456789", badlen / 2);
+ strlcat(dest, "0123456789", badlen); // expected-warning {{The third
argument allows to potentially copy more bytes than it should. Replace with the
valu
michaelwu accepted this revision.
michaelwu added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D51281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341629: [Sema] Check that the destructor for each element of
class type is (authored by ahatanak, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45898
Files:
lib/Sema/SemaInit.cpp
Author: ahatanak
Date: Thu Sep 6 19:38:01 2018
New Revision: 341629
URL: http://llvm.org/viewvc/llvm-project?rev=341629&view=rev
Log:
[Sema] Check that the destructor for each element of class type is
accessible from the context where aggregate initialization occurs.
rdar://problem/38168772
Dif
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Comments always welcome!
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:363-364
+
+ // ImmutableList::getHead() isn't a const method,
NoQ added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:126-127
if (V.isUndef()) {
+assert(!FR->getDecl()->getType()->isReferenceType() &&
+ "References must be initialized!");
return addFieldToUninits
NoQ added a comment.
I'm generally fine with landing the patch as long as the overall direction is
chosen (and be moved towards) for how to safely identify the non-deterministic
iterators (my previous inline question). This has to be addressed before we
move out of alpha, but i believe we shoul
NoQ added inline comments.
Comment at: test/Analysis/cstring-syntax.c:49
+ strlcat(dest, "0123456789", badlen / 2);
+ strlcat(dest, "0123456789", badlen); // expected-warning {{The third
argument allows to potentially copy more bytes than it should. Replace with the
value 'ba
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341620: [analyzer] [NFC] Prefer passing around reference to
std::unique_ptr& (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341621: [analyzer] Add coverage information to plist output,
update tests (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.
NoQ added a comment.
Herald added a subscriber: Szelethus.
Dunno, i guess you can just commit it.
Comment at: lib/Sema/SemaStmtAsm.cpp:57
+ }
+Parent = Child;
+ }
Like father, like son :D
Repository:
rC Clang
https://reviews.llvm.org/D45416
__
Author: george.karpenkov
Date: Thu Sep 6 17:43:17 2018
New Revision: 341618
URL: http://llvm.org/viewvc/llvm-project?rev=341618&view=rev
Log:
[analyzer] Do not add invalid source location to the coverage information
Invalid source locations may arise from generated code.
Differential Revision:
Author: george.karpenkov
Date: Thu Sep 6 17:43:37 2018
New Revision: 341619
URL: http://llvm.org/viewvc/llvm-project?rev=341619&view=rev
Log:
[analyzer] Executed lines: store file IDs, not hashes.
Raw FileIDs are needed for the PlistDiagnostics to produce stable filenames.
Differential Revision
Author: george.karpenkov
Date: Thu Sep 6 17:43:55 2018
New Revision: 341620
URL: http://llvm.org/viewvc/llvm-project?rev=341620&view=rev
Log:
[analyzer] [NFC] Prefer passing around reference to std::unique_ptr&
When object is owned elsewhere
Differential Revision: https://reviews.llvm.org/D5166
Author: george.karpenkov
Date: Thu Sep 6 17:42:32 2018
New Revision: 341616
URL: http://llvm.org/viewvc/llvm-project?rev=341616&view=rev
Log:
[analyzer] Skip printing trivial nodes in exploded graph
A node is considered to be trivial if it only has one successor, one
predecessor, and a state equ
Author: george.karpenkov
Date: Thu Sep 6 17:42:53 2018
New Revision: 341617
URL: http://llvm.org/viewvc/llvm-project?rev=341617&view=rev
Log:
[analyzer] Push updating-the-executed-lines logic into the BugReporter.
So it can be reused across different consumers.
Differential Revision: https://re
Quuxplusone added a comment.
@EricWF ping?
Repository:
rCXX libc++
https://reviews.llvm.org/D47344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added a comment.
In https://reviews.llvm.org/D51189#1211910, @steven_wu wrote:
> I feel like this is a much tricky situation than just new and init. Following
> example is the same situation.
>
> __attribute__((objc_root_class))
> @interface NSObject
> - (void) foo;
> - (
erik.pilkington updated this revision to Diff 164316.
erik.pilkington marked 4 inline comments as done.
erik.pilkington added a comment.
Address @arphaman's review comments.
https://reviews.llvm.org/D51189
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/DeclObjC.h
clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341600: [analyzer] Dump a reproducible, deterministic ID of
program state to exploded… (authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
Author: george.karpenkov
Date: Thu Sep 6 16:08:27 2018
New Revision: 341603
URL: http://llvm.org/viewvc/llvm-project?rev=341603&view=rev
Log:
[analyzer] [NFC] Move dumping program point into a separate function
Differential Revision: https://reviews.llvm.org/D51666
Modified:
cfe/trunk/lib/S
Author: george.karpenkov
Date: Thu Sep 6 16:08:07 2018
New Revision: 341602
URL: http://llvm.org/viewvc/llvm-project?rev=341602&view=rev
Log:
[analyzer] Dump stable identifiers for exploded nodes
Differential Revision: https://reviews.llvm.org/D51667
Modified:
cfe/trunk/include/clang/Static
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341601: [analyzer] Remove traces of ubigraph visualization
(authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5165
Author: george.karpenkov
Date: Thu Sep 6 16:07:47 2018
New Revision: 341601
URL: http://llvm.org/viewvc/llvm-project?rev=341601&view=rev
Log:
[analyzer] Remove traces of ubigraph visualization
Ubigraph project has been dead since about 2008, and to the best of my
knowledge, no one was using it.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341599: Provide a method for generating deterministic IDs
for pointers allocated in… (authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51393?vs=164294&id=
Author: george.karpenkov
Date: Thu Sep 6 16:07:26 2018
New Revision: 341600
URL: http://llvm.org/viewvc/llvm-project?rev=341600&view=rev
Log:
[analyzer] Dump a reproducible, deterministic ID of program state to exploded
graph
Differential Revision: https://reviews.llvm.org/D51395
Modified:
kadircet added inline comments.
Comment at: test/Index/complete-block-property-assignment.m:71
+// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck
-check-prefix=CHECK-NO1 %s
+// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35)
ily
kadircet updated this revision to Diff 164307.
kadircet added a comment.
- Fix tests.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/CodeCompletion/function-overloads-inside-param.cpp
test/CodeCompletion/function-
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I'm happy with the code.
Comment at: llvm/include/llvm/Support/Allocator.h:298
+ if (P >= S && P < S + computeSlabSize(Idx))
+return InSlabIdx + static_cast(P - S);
+
dblaikie added a comment.
Just to clarify - the general philosophy (there are many cases of exceptions
due to complications in various areas) is that clang changes should have clang
tests (source code to IR), LLVM changes should have LLVM tests (IR to assembly
or object code+dwarf dump) & if de
george.karpenkov updated this revision to Diff 164294.
george.karpenkov added a comment.
More casts.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
===
george.karpenkov updated this revision to Diff 164292.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
===
--- llvm/include/llvm/Support/Allocator.h
+++ ll
george.karpenkov updated this revision to Diff 164291.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
===
--- llvm/include/llvm/Support/Allocator.h
+++ ll
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I very very much appreciate this.
https://reviews.llvm.org/D51395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
jfb added a comment.
In https://reviews.llvm.org/D51752#1226474, @MatzeB wrote:
> In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
>
> > - I assume the review lacks the changes on the llvm side?
>
>
> Oops missed the link to the llvm changes in the description... At least in
> theory y
MatzeB added a comment.
In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
> - I assume the review lacks the changes on the llvm side?
Oops missed the link to the llvm changes in the description... At least in
theory you should be able to make a review over all changes in parallel by
jfb added a comment.
In https://reviews.llvm.org/D51752#1226465, @jfb wrote:
> In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
>
> > - I'm not a good person to review clang changes.
> > - I assume the review lacks the changes on the llvm side?
> > - On the LLVM side this feels like som
jfb added a comment.
In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
> - I'm not a good person to review clang changes.
> - I assume the review lacks the changes on the llvm side?
> - On the LLVM side this feels like something for `Analysis/ValueTracking.h`
> in fact I already see `Va
MatzeB added a comment.
- I'm not a good person to review clang changes.
- I assume the review lacks the changes on the llvm side?
- On the LLVM side this feels like something for `Analysis/ValueTracking.h` in
fact I already see `Value *isBytewiseValue(Value *V);` there, maybe that is
good enoug
jfb created this revision.
Herald added subscribers: cfe-commits, dexonsmith.
This code was in CGDecl.cpp and really belongs to Constant. This will allow me
to use it in a subsequent patch.
LLVM part of this patch: https://reviews.llvm.org/D51751
Repository:
rC Clang
https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341583: Fix reported range of partial token replacement
(authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51192?vs=163447&id=164275#toc
Repository:
rCTE Clan
Author: steveire
Date: Thu Sep 6 13:16:34 2018
New Revision: 341583
URL: http://llvm.org/viewvc/llvm-project?rev=341583&view=rev
Log:
Fix reported range of partial token replacement
Summary: Fixes bug: 38678
Reviewers: klimek, rsmith
Subscribers: cfe-commits
Differential Revision: https://rev
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226341, @steveire wrote:
> Thanks.
>
> The `arc` tool already inserted `Differential Revision:` into my git commit,
> but that's not what I wonder about. I'm looking for something I can insert
> into my git commit so that the bu
steveire added a comment.
Thanks.
The `arc` tool already inserted `Differential Revision:` into my git commit,
but that's not what I wonder about. I'm looking for something I can insert into
my git commit so that the bug will automatically be closed when I commit (and
so that the bug will get
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D51192#1226326, @steveire wrote:
> As far as I know, no existing clang-tidy checks are affected. I discovered
> this while implementing a custom check
joerg added a comment.
Correct. The protected name is double underscore as both suffix and prefix.
https://reviews.llvm.org/D51683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steveire added a comment.
As far as I know, no existing clang-tidy checks are affected. I discovered this
while implementing a custom check. See
https://bugs.llvm.org/show_bug.cgi?id=38678
By the way, is there some keyword I should use in commit messages to link to
bugs properly?
Repository:
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226312, @steveire wrote:
> In https://reviews.llvm.org/D51192#1226282, @aaron.ballman wrote:
>
> > I'd probably pipe the diagnostic output to a temporary file that gets
> > FileChecked with strict whitespace to see if the underli
On 06/09/18 20:42, Roman Lebedev wrote:
You can specify the dependencies between the differentials in phabricator.
I didn't know that, thanks!
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
On Thu, Sep 6, 2018 at 10:05 PM, Stephen Kelly via cfe-commits
wrote:
>
> Yes, this was a prerequisite to https://reviews.llvm.org/D51259. For some
> reason the reviewer accepted that one, but not this one. I simply assumed
> that was a mistake and committed this one.
I'm not sure this is how the
steveire added a comment.
In https://reviews.llvm.org/D51192#1226282, @aaron.ballman wrote:
> In https://reviews.llvm.org/D51192#1226257, @steveire wrote:
>
> > How? This is 'private' code. I don't think it's worth changing that or
> > creating a test with a huge amount of infrastructure in or
kadircet updated this revision to Diff 164268.
kadircet added a comment.
- Formatting.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51747
Files:
clangd/ClangdServer.cpp
clangd/Diagnostics.cpp
unittests/clangd/ClangdUnitTests.cpp
Index: unittests/clangd/ClangdUnitTests
kadircet added inline comments.
Comment at: clangd/Diagnostics.cpp:299
+D.Severity =
+D.Category == "Deprecations" ? DiagnosticsEngine::Note : DiagLevel;
return D;
Couldn't find a better way to check for this one. Category types are coming
from
tks2103 updated this revision to Diff 164265.
tks2103 added a comment.
get NRVOCandidate to determine if we should try to move return var
Repository:
rC Clang
https://reviews.llvm.org/D51741
Files:
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutine-rvo.cpp
Index: test/SemaCXX/coroutine-
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226257, @steveire wrote:
> How? This is 'private' code. I don't think it's worth changing that or
> creating a test with a huge amount of infrastructure in order to test this
> indirectly.
This is changing the observable behav
Yes, this was a prerequisite to https://reviews.llvm.org/D51259. For
some reason the reviewer accepted that one, but not this one. I simply
assumed that was a mistake and committed this one.
Perhaps part of the problem is that I do one thing per commit, and that
confuses reviewers. Maybe I s
kadircet created this revision.
kadircet added reviewers: ioeric, sammccall, ilya-biryukov, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Adds deprecation warnings to diagnostics. Also lowers the severity from
warning to notes to not to annoy people that work on big co
kadircet added inline comments.
Comment at: unittests/clangd/SymbolCollectorTests.cpp:1020
+ const std::string Header = R"(
+void TestClangc() __attribute__((deprecated("", "")));
+void TestClangd();
No need for the optional parameters,
```
void TestCl
steveire added a comment.
How? This is 'private' code. I don't think it's worth changing that or creating
a test with a huge amount of infrastructure in order to test this indirectly.
Am I missing something?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341576: [clangd] Add "Deprecated" field to
Symbol and CodeCompletion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51724?vs=164259&id=164260#toc
Repository:
Author: ioeric
Date: Thu Sep 6 11:52:26 2018
New Revision: 341576
URL: http://llvm.org/viewvc/llvm-project?rev=341576&view=rev
Log:
[clangd] Add "Deprecated" field to Symbol and CodeCompletion.
Summary: Also set "deprecated" field in LSP CompletionItem.
Reviewers: sammccall, kadircet
Reviewed
ioeric updated this revision to Diff 164259.
ioeric added a comment.
- merged with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51724
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Protocol.cpp
clangd/Protocol.h
clangd/Quality.cpp
clangd
ioeric updated this revision to Diff 164258.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51724
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Protocol.cpp
clangd
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
Brilliant, I've wanted to do this for years, and I still have many improvements
to the LLVM/Clang cmake files on my todo list. Good to know others are
similarly motivated.
=
tks2103 added a comment.
also fails
https://github.com/llvm-mirror/clang/blob/master/test/SemaCXX/coroutines.cpp#L494
with `address of overloaded function 'g' does not match required type
''`
also fails
https://github.com/llvm-mirror/clang/blob/master/test/SemaCXX/coroutines.cpp#L505
with `ad
george.karpenkov updated this revision to Diff 164255.
george.karpenkov marked 2 inline comments as done.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
=
tks2103 added a comment.
currently changes the behavior for a few cases:
something like
void coro() {
co_return {4};
}
throws `illegal initializer type 'void'`
Repository:
rC Clang
https://reviews.llvm.org/D51741
___
cfe-commits mailin
Author: rnk
Date: Thu Sep 6 11:25:39 2018
New Revision: 341572
URL: http://llvm.org/viewvc/llvm-project?rev=341572&view=rev
Log:
Re-land r334417 "[MS] Use mangled names and comdats for string merging with
ASan"
The issue with -fprofile-generate was fixed and the dependent CL
relanded in r340232
erichkeane updated this revision to Diff 164251.
erichkeane marked 9 inline comments as done.
erichkeane added a comment.
fix aaron's comments.
https://reviews.llvm.org/D51650
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic
tks2103 created this revision.
tks2103 added reviewers: modocache, GorNishanov.
Herald added a subscriber: cfe-commits.
tks2103 edited the summary of this revision.
Addressing https://bugs.llvm.org/show_bug.cgi?id=37265.
Implements [class.copy]/33 of coroutines TS
When the criteria for elision o
Author: abataev
Date: Thu Sep 6 10:56:28 2018
New Revision: 341570
URL: http://llvm.org/viewvc/llvm-project?rev=341570&view=rev
Log:
[OPENMP] Fix PR38823: Do not emit vtable if it is not used in target
context.
If the explicit template instantiation definition defined outside of the
target conte
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Thank you for this! I have some cursory review comments, and possibly more
later.
Comment at: include/clang/Basic/AttrDocs.td:1600
+ let Content = [{
+Clang supports the GNU style ``__attribute__((target_c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341566: [Sema] Clean up some __builtin_*_chk diagnostics
(authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51697?vs=164087&i
Author: epilk
Date: Thu Sep 6 10:19:33 2018
New Revision: 341566
URL: http://llvm.org/viewvc/llvm-project?rev=341566&view=rev
Log:
[Sema] Clean up some __builtin_*_chk diagnostics
Namely, print the likely macro name when it's used, and include the actual
computed sizes in the diagnostic message,
jfb updated this revision to Diff 164235.
jfb marked 4 inline comments as done.
jfb added a comment.
- Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D51084
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/atomic-implicit-seq_cst.c
jfb added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10974
+ if (E->IgnoreParenImpCasts()->getType()->isAtomicType())
+return;
CheckImplicitConversion(S, E->IgnoreParenImpCasts(), S.Context.BoolTy, CC);
rjmccall wrote:
> Can you explain this o
Author: labath
Date: Thu Sep 6 10:01:45 2018
New Revision: 341564
URL: http://llvm.org/viewvc/llvm-project?rev=341564&view=rev
Log:
Re-commit "Enable DWARF accelerator tables by default when tuning for lldb
(-glldb => -gpubnames)""
This recommits r341472, which was reverted due to test failures
mgorny added a comment.
I don't have a strong opinion here.
Repository:
rC Clang
https://reviews.llvm.org/D51714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper added a comment.
Do you have commit access, or do you need someone to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D51510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Agree with Kadir's comments.
I'd just suggest reducing boilerplate a bit by taking some shortcuts.
Comment at: clangd/index/Index.h:167
+enum class SymbolFlag : uint8
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D51697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
kadircet added inline comments.
Comment at: clangd/index/Index.h:171
+ /// See also isIndexedForCodeCompletion().
+ IsIndexedForCodeCompletion = 1 << 0,
+ /// Indicates if the symbol is deprecated.
nit: rename to IndexedForCodeCompletion, since it is more of a
Author: sudofortune
Date: Thu Sep 6 09:29:40 2018
New Revision: 341560
URL: http://llvm.org/viewvc/llvm-project?rev=341560&view=rev
Log:
Reverting r 341390 because it is causing test failures on GreenDragon.
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/52810/
Modified:
tstellar added a comment.
In https://reviews.llvm.org/D51714#1225545, @mgorny wrote:
> Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for
> everyone who has LLVM configured.
Yes, it is dropped from the cache, is it a problem to having the warning fire
for people who
Author: rksimon
Date: Thu Sep 6 08:16:17 2018
New Revision: 341556
URL: http://llvm.org/viewvc/llvm-project?rev=341556&view=rev
Log:
Remove unnecessary semicolon to silence -Wpedantic warning. NFCI.
Modified:
cfe/trunk/lib/Sema/SemaExceptionSpec.cpp
Modified: cfe/trunk/lib/Sema/SemaExceptio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341553: [OpenCL] Relax diagnostics on OpenCL access
qualifiers (authored by asavonic, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51302?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341553: [OpenCL] Relax diagnostics on OpenCL access
qualifiers (authored by asavonic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51302
Files:
lib/Sema/SemaDeclAttr.cpp
lib/Sema
Author: asavonic
Date: Thu Sep 6 08:10:26 2018
New Revision: 341553
URL: http://llvm.org/viewvc/llvm-project?rev=341553&view=rev
Log:
[OpenCL] Relax diagnostics on OpenCL access qualifiers
Summary:
Emit warning for multiple access qualifiers if they do not conflict.
Patch by Alexey Bader
Revie
Author: omtcyfz
Date: Thu Sep 6 08:10:10 2018
New Revision: 341552
URL: http://llvm.org/viewvc/llvm-project?rev=341552&view=rev
Log:
[clangd] Fix Dex initialization
This patch sets URI schemes of Dex to SymbolCollector's default schemes
in case callers tried to pass empty list of schemes. This w
whisperity added a comment.
In https://reviews.llvm.org/D50488#1225064, @george.karpenkov wrote:
> Why explicitly skip C projects? We would not be able to match `std::X`
> functions anyway.
Why spend time constructing matchers and running on the AST when we are sure
that generating any resul
Author: ldionne
Date: Thu Sep 6 08:05:43 2018
New Revision: 341551
URL: http://llvm.org/viewvc/llvm-project?rev=341551&view=rev
Log:
[libc++] Add a link to the Release notes from the main libc++ documentation
Modified:
libcxx/trunk/docs/index.rst
Modified: libcxx/trunk/docs/index.rst
URL:
jgreenhalgh added inline comments.
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
- OS << "#define __ai static inline __attribute__((__always_inline__, "
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "
"__nodebug__))\n\n";
---
Author: ldionne
Date: Thu Sep 6 07:46:22 2018
New Revision: 341550
URL: http://llvm.org/viewvc/llvm-project?rev=341550&view=rev
Log:
[libcxx] Add ReleaseNotes.rst file for release notes
Added:
libcxx/trunk/docs/ReleaseNotes.rst
Added: libcxx/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org
rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.
Still needs a test.
https://reviews.llvm.org/D42370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
sidorovd updated this revision to Diff 164214.
sidorovd added a comment.
Reference to the Spec was added
https://reviews.llvm.org/D51722
Files:
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/block-array-capturing.cl
Index: test/SemaOpenCL/block-array-capturing.cl
==
Anastasia added inline comments.
Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27
+
+INTEL_SGAVC_TYPE(mce_payload_t, McePayload)
+INTEL_SGAVC_TYPE(ime_payload_t, ImePayload)
AlexeySachkov wrote:
> Anastasia wrote:
> > From the specification of this ext
1 - 100 of 171 matches
Mail list logo
