stephanemoore updated this revision to Diff 163656.
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
Updated with changes:
- Removed unit tests as other tests have been indicated to provide adequate
coverage.
- Added a comment explaining why only function definition
hokein added a comment.
Nice! looks mostly good to me.
Comment at: clang-tidy/google/FunctionNamingCheck.cpp:57
+ functionDecl(
+ isDefinition(),
+ unless(anyOf(isMain(), matchesName(validFunctionNameRegex(true)),
any reason why we restri
hokein updated this revision to Diff 163654.
hokein edited the summary of this revision.
hokein added a comment.
Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
Files:
clangd/XRefs.cpp
clangd/XRefs.h
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRe
elsteveogrande created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D51580
Files:
test/Modules/Inputs/lax-base-except/a.h
test/Modules/Inputs/lax-base-except/module.modulemap
test/Modules/lax-base-except.cpp
Index: test/Modules/la
thakis added a comment.
We don't match gcc's -Wextra behvior. We generally try to not put a ton of
stuff in Wextra that isn't in -Wall. (We also generally don't put a lot of
stuff in -Wall that isn't enabled by default.) So I don't think we want this.
https://reviews.llvm.org/D51545
___
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Comment at: unittests/AST/ASTImporterTest.cpp:3241
+ auto *ToD = Import(FromD, Lang_CXX11);
+ ASSERT_TRUE(ToD);
+ auto *ToInitExpr = cast(ToD)->g
stephanemoore marked an inline comment as done.
stephanemoore added inline comments.
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`google-objc-function-naming
+ ` check.
Eugene.Zelenko wrote:
> Please use alphabetical order.
Good catch. Fixed.
Repository
stephanemoore updated this revision to Diff 163647.
stephanemoore added a comment.
Fixed alphabetical ordering of clang-tidy improvements in release notes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/Functio
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:60
+- New :doc:`google-objc-function-naming
+ ` check.
Please use alphabetical order.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
___
labath created this revision.
labath added a reviewer: dblaikie.
DWARF v5 accelerator tables provide a considerable performance
improvement for lldb and will make the default -glldb behavior same on
all targets (right now we emit apple tables on apple targets, but these
are not controlled by -gpub
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341284: Fix Bug 38713: clang-format mishandles a short block
after "default:" in a… (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
JonasToth added a comment.
Commited for Owen in r341284.
Repository:
rC Clang
https://reviews.llvm.org/D51294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jonastoth
Date: Sun Sep 2 02:04:51 2018
New Revision: 341284
URL: http://llvm.org/viewvc/llvm-project?rev=341284&view=rev
Log:
Fix Bug 38713: clang-format mishandles a short block after "default:" in a
switch statement
Summary:
See https://bugs.llvm.org/show_bug.cgi?id=38713
Patch by O
13 matches
Mail list logo
