[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore updated this revision to Diff 163638. stephanemoore added a comment. Minor fixes: - Fixed header guard. - Removed unnecessary imports in header. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51575 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/Fun

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. §1 Description This check finds function names in function definitions in Objective-C files that do not follow the naming pattern described in the Google Objective-C Style Guide. Function names should

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek updated this revision to Diff 163636. phosek marked 4 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/linux-per-target-runtime-dir.c Index: clang/test/Driver/linux-per-target-runtime-dir.c =

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. The log message could give concrete examples. Comment at: clang/lib/Driver/Driver.cpp:4169 std::string Driver::GetFilePath(StringRef Name, const ToolChain &TC) const { -

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek updated this revision to Diff 163633. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/linux-per-target-runtime-dir.c Index: clang/test/Driver/linux-per-target-runtime-dir.c ==

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek updated this revision to Diff 163630. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp === --- clang/lib/Driver/Driver.cpp +++ clang/lib/Driver/D

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

phosek created this revision. phosek added a reviewer: beanz. Herald added a subscriber: cfe-commits. This is necessary to handle the multiarch runtime directories. Repository: rC Clang https://reviews.llvm.org/D51573 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha marked 2 inline comments as done. Wawha added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1307 + (Style.BraceWrapping.BeforeLambdaBody && Current.Next != nullptr && +Current.Next->is(TT_LambdaLSquare))); State.Stack.back().IsInsideObjCA

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 163624. https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c test/CodeGen/target-data.c tes

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

wzssyqa updated this revision to Diff 163622. wzssyqa added a comment. Remove unused MipsCpu. Repository: rC Clang https://reviews.llvm.org/D51464 Files: lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/

[PATCH] D51568: [modules] Add `-fdisable-module-directory` flag for relocatable modules

andrewjcg updated this revision to Diff 163621. andrewjcg added a comment. fix umbrella writing Repository: rC Clang https://reviews.llvm.org/D51568 Files: include/clang/Driver/CC1Options.td include/clang/Lex/HeaderSearchOptions.h lib/Frontend/CompilerInvocation.cpp lib/Serialization

[PATCH] D51568: [modules] Add `-fdisable-module-directory` flag for relocatable modules

andrewjcg added a comment. I'm not sure this is the best approach, but I wasn't sure of a better one (to support module files w/o absolute paths). Another approach I tried, was relativizing the other input files (from outside the module directory) using chains of `../` (e.g. `../../../../../ot

[PATCH] D51568: [modules] Add `-fdisable-module-directory` flag for relocatable modules

andrewjcg created this revision. Herald added a subscriber: cfe-commits. Currently, modules built using module map files embed the path to the directory that houses their inputs (e.g. headers and module map file) into the output module file. This path is embedded as an absolute path and the vario

[clang-tools-extra] r341273 - [clangd] Fix many typos. NFC

Author: maskray Date: Sat Sep 1 00:47:03 2018 New Revision: 341273 URL: http://llvm.org/viewvc/llvm-project?rev=341273&view=rev Log: [clangd] Fix many typos. NFC Modified: clang-tools-extra/trunk/clangd/Logger.h clang-tools-extra/trunk/clangd/index/FileIndex.h clang-tools-extra/trunk

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you please include more context to patches sent for review? https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/Driver/ToolChains/Linux.cpp:46 TargetTriple.getEnvironment(); + llvm::Triple::Su

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added a comment. Could you please include more context to patches sent for review? https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:109 + if (ABIName.empty() && (Triple.getEnvironment()