[PATCH] D50953: [clang-tidy] Handle sugared reference types in ExprMutationAnalyzer

shuaiwang created this revision. shuaiwang added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, Szelethus, a.sidorin, xazax.hun. Herald added a reviewer: george.karpenkov. This handles cases like this: typedef int& IntRef; void mutate(IntRef); void f() { int x;

r340145 - [Lex] Fix some inconsistent parameter names and duplicate comments. NFC

Author: maskray Date: Sun Aug 19 15:23:42 2018 New Revision: 340145 URL: http://llvm.org/viewvc/llvm-project?rev=340145&view=rev Log: [Lex] Fix some inconsistent parameter names and duplicate comments. NFC Modified: cfe/trunk/include/clang/Lex/DirectoryLookup.h cfe/trunk/include/clang/Lex

[PATCH] D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing

elsteveogrande planned changes to this revision. elsteveogrande marked an inline comment as done. elsteveogrande added a comment. This broke some tests. It fixes the test case added here under `test/Modules` but causes errors in `test/CodeGenCXX` and other dirs. Repository: rC Clang https:/

[PATCH] D50949: Handle lambdas in .pcm [de]serialization

elsteveogrande created this revision. elsteveogrande added a reviewer: rsmith. Herald added a subscriber: cfe-commits. - Drop a couple of asserts preventing this (in the merge function) - Merge all fields as usual - Ensure select fields match, for ODR checking - add previously-failing test to merg

[PATCH] D50948: Change how LambdaDefinitionData is stored

elsteveogrande created this revision. Herald added a subscriber: cfe-commits. Previously `LambdaDefinitionData` extended `DefinitionData` and either might have been used interchangably in a `CXXRecordDecl`'s `DefinitionData` field. However there are cases where `LambdaDefinitionData` ("LDD") are

[PATCH] D50947: make PendingFakeDefinitionData a set, not map of decl data -> enum

elsteveogrande created this revision. Herald added a subscriber: cfe-commits. Of the three enums, only two are used (Fake and FakeLoaded), and even when switching the mapped value to FakeLoaded, it's leading to an unexpected state anyway (i.e. there's no check for only Fake's in the map). Disca

r340142 - [CodeGen] add test file that should have been included with r340141

Author: spatel Date: Sun Aug 19 10:32:56 2018 New Revision: 340142 URL: http://llvm.org/viewvc/llvm-project?rev=340142&view=rev Log: [CodeGen] add test file that should have been included with r340141 Added: cfe/trunk/test/CodeGen/builtin-rotate.c Added: cfe/trunk/test/CodeGen/builtin-rotat

[PATCH] D50924: [CodeGen] add rotate builtins

spatel added a subscriber: lei. spatel added a comment. And the 3rd time is the charm... I have no explanation for why this works, but I removed the microsoft diffs, and now gcc doesn't crash. cc'ing @lei as owner of the bots that have this problem: http://lab.llvm.org:8011/builders/clang-ppc64be

[PATCH] D50924: [CodeGen] add rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL340141: [CodeGen] add rotate builtins that map to LLVM funnel shift (authored by spatel, committed by ). Changed prior to commit: https://reviews.llvm.org/D50924?vs=161398&id=161402#toc Repository:

r340141 - [CodeGen] add rotate builtins that map to LLVM funnel shift

Author: spatel Date: Sun Aug 19 09:50:30 2018 New Revision: 340141 URL: http://llvm.org/viewvc/llvm-project?rev=340141&view=rev Log: [CodeGen] add rotate builtins that map to LLVM funnel shift This is a partial retry of rL340137 (reverted at rL340138 because of gcc host compiler crashing) with 1

[PATCH] D49075: [NEON] Define fp16 vld and vst intrinsics conditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rC340140: [NEON] Define fp16 vld and vst intrinsics conditionally (authored by kosarev, committed by ). Repository: rC Clang https://reviews.llvm.org/D49075 Files: include/clang/Basic/arm_neon.td te

[PATCH] D49075: [NEON] Define fp16 vld and vst intrinsics conditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rL340140: [NEON] Define fp16 vld and vst intrinsics conditionally (authored by kosarev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49075?vs

r340140 - [NEON] Define fp16 vld and vst intrinsics conditionally

Author: kosarev Date: Sun Aug 19 09:30:57 2018 New Revision: 340140 URL: http://llvm.org/viewvc/llvm-project?rev=340140&view=rev Log: [NEON] Define fp16 vld and vst intrinsics conditionally This patch fixes definitions of vld and vst NEON intrinsics so that we only define them if half-precision a

[PATCH] D50924: [CodeGen] add rotate builtins

spatel reopened this revision. spatel added a comment. This revision is now accepted and ready to land. Reopening again because I reverted this again for the same reason at https://reviews.llvm.org/rL340138. Repository: rL LLVM https://reviews.llvm.org/D50924 _

[PATCH] D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing

elsteveogrande updated this revision to Diff 161399. elsteveogrande marked an inline comment as done. elsteveogrande added a comment. fix dopey copy-paste error. Tested again with `ninja check-clang-modules` Repository: rC Clang https://reviews.llvm.org/D50942 Files: lib/Sema/SemaExceptio

[PATCH] D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing

elsteveogrande marked an inline comment as done. elsteveogrande added inline comments. Comment at: lib/Sema/SemaExceptionSpec.cpp:915 + // lexically-surrounding class. + switch (New->getType()->castAs()->getExceptionSpecType()) { + case EST_Unparsed: vitaut w

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

kristina added a comment. Given the context (class an file name itself) and documentation around the function, I don't think in this particular case it improves readability or maintainability, the lifetime of the `HeaderMap` is (IMHO) fairly obvious from the const qualifier and from the documen

r340138 - revert r340137: [CodeGen] add rotate builtins

Author: spatel Date: Sun Aug 19 08:31:42 2018 New Revision: 340138 URL: http://llvm.org/viewvc/llvm-project?rev=340138&view=rev Log: revert r340137: [CodeGen] add rotate builtins At least a couple of bots (gcc host compiler on PPC only?) are showing the compiler dying while trying to compile. R

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

a_sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:4550 + // in the "From" context, but not in the "To" context. + for (auto *FromField : D->fields()) +Importer.Import(FromField); martong wrote: > martong wrote: > > a_sidorin w

r340137 - [CodeGen] add/fix rotate builtins that map to LLVM funnel shift (retry)

Author: spatel Date: Sun Aug 19 07:44:47 2018 New Revision: 340137 URL: http://llvm.org/viewvc/llvm-project?rev=340137&view=rev Log: [CodeGen] add/fix rotate builtins that map to LLVM funnel shift (retry) This is a retry of rL340135 (reverted at rL340136 because of gcc host compiler crashing) wi

[PATCH] D50924: [CodeGen] add rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL340137: [CodeGen] add/fix rotate builtins that map to LLVM funnel shift (retry) (authored by spatel, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing

vitaut added inline comments. Comment at: lib/Sema/SemaExceptionSpec.cpp:915 + // lexically-surrounding class. + switch (New->getType()->castAs()->getExceptionSpecType()) { + case EST_Unparsed: Did you mean `Old` here? Repository: rC Clang https://review

[PATCH] D50924: [CodeGen] add rotate builtins

spatel added a comment. In https://reviews.llvm.org/D50924#1205310, @spatel wrote: > Reopening because I reverted at https://reviews.llvm.org/rL340136. Not sure > yet what is causing the problem on those bots. The common trait for those failures appears to be that the host compiler is: gcc ver

[PATCH] D50924: [CodeGen] add rotate builtins

spatel reopened this revision. spatel added a comment. This revision is now accepted and ready to land. Reopening because I reverted at https://reviews.llvm.org/rL340136. Not sure yet what is causing the problem on those bots. Repository: rC Clang https://reviews.llvm.org/D50924 _

r340136 - revert r340135: [CodeGen] add rotate builtins

Author: spatel Date: Sun Aug 19 06:48:06 2018 New Revision: 340136 URL: http://llvm.org/viewvc/llvm-project?rev=340136&view=rev Log: revert r340135: [CodeGen] add rotate builtins At least a couple of bots (PPC only?) are showing the compiler dying while trying to compile: http://lab.llvm.org:801

[PATCH] D50932: [ASTImporter] Add test for C++ casts and fix broken const_cast importing.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thank you! Comment at: tools/clang-import-test/clang-import-test.cpp:197 Inv->getLangOpts()->DollarIdents = true; + Inv->getLangOpts()->RTTI = true; Inv->getCode

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D50737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D50924: [CodeGen] add rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC340135: [CodeGen] add rotate builtins (authored by spatel, committed by ). Herald added a subscriber: kristina. Repository: rC Clang https://reviews.llvm.org/D50924 Files: docs/LanguageExtensions.rs

r340135 - [CodeGen] add rotate builtins

Author: spatel Date: Sun Aug 19 06:12:40 2018 New Revision: 340135 URL: http://llvm.org/viewvc/llvm-project?rev=340135&view=rev Log: [CodeGen] add rotate builtins This exposes the LLVM funnel shift intrinsics as more familiar bit rotation functions in clang (when both halves of a funnel shift a

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

Quuxplusone added inline comments. Comment at: test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10 + +template requires bool(U()) +int B::A = int(U()); saar.raz wrote: > saar.raz wrote: > > Rakete wrote: > > > Quuxplusone wrote: