MaskRay created this revision.
MaskRay added reviewers: Eugene.Zelenko, dblaikie.
Herald added a subscriber: cfe-commits.
unique_ptr makes the ownership clearer than a raw pointer container.
Repository:
rC Clang
https://reviews.llvm.org/D50945
Files:
include/clang/Lex/HeaderMap.h
include
saar.raz added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
saar.raz wrote:
> Rakete wrote:
> > Quuxplusone wrote:
> > > saar.raz wrote:
> >
saar.raz added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
Rakete wrote:
> Quuxplusone wrote:
> > saar.raz wrote:
> > > Quuxplusone wrote:
Also, the diag text should probably say "pass '-stdlib=libc++' " not "pass
'-std=libc++' "?
On Sat, Aug 18, 2018 at 11:06 PM Nico Weber wrote:
> Should this maybe not be emitted when compiling e.g. .ii files
> (preprocessed output)? I just got this when I built a standalone .ii file
> with some
Should this maybe not be emitted when compiling e.g. .ii files
(preprocessed output)? I just got this when I built a standalone .ii file
with some bug repro after I deleted all -I and -isysroot flags and whatnot,
since they aren't needed for preprocessed files.
On Tue, Jun 19, 2018 at 6:52 PM Alex
elsteveogrande created this revision.
elsteveogrande added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
For `TagDecl`s, complete or incomplete, allow `setInvalidDecl` calls.
Other `assert`s are interfering but we'll deal with them separately.
https://bugs.llvm.org/show_bug.cgi?id=
elsteveogrande created this revision.
elsteveogrande added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
Before checking that the overriding definition of a method is not more lax than
the overridden one, ensure the exception spec is parsed, and also evaluated.
Test case by
Rakete added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
Quuxplusone wrote:
> saar.raz wrote:
> > Quuxplusone wrote:
> > > For my own edifi
Quuxplusone added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
saar.raz wrote:
> Quuxplusone wrote:
> > For my own edification, could you explai
atanasyan added a comment.
Could you add test cases to cover these changes?
Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:115
+ if (ABIName.empty() && (Triple.getEnvironment() == llvm::Triple::GNUABIN32))
+ABIName = "n32";
+
It looks like this change is
lebedev.ri added inline comments.
Comment at: clang-tidy/abseil/AutoMakeUniqueCheck.cpp:21
+void AutoMakeUniqueCheck::registerMatchers(MatchFinder* finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
zinovy.nis wrote:
> JonasToth wrote:
> > Please clang-format,
zinovy.nis added inline comments.
Comment at: clang-tidy/abseil/AutoMakeUniqueCheck.cpp:21
+void AutoMakeUniqueCheck::registerMatchers(MatchFinder* finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
JonasToth wrote:
> Please clang-format, `return` on next line.
zinovy.nis added a comment.
In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this
> should be just an alias to that check. Else, i think it would be b
malaperle added a comment.
In https://reviews.llvm.org/D50703#1205109, @kbobyrev wrote:
> In https://reviews.llvm.org/D50703#1205049, @malaperle wrote:
>
> > I hadn't marked it as done because without symbols in main files I found it
> > quite lacking.
>
>
> Ah, I see, thank you for spotting it!
elsteveogrande added a comment.
hi @vsk + @arphaman , it's been a while -- I brought this old diff up to date,
wondering if you could take a look again. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D42043
___
cfe-commits mailing list
c
JonasToth added inline comments.
Comment at: clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:85
+
+ // absl::StrSplit(..., "x") -> absl::StrSplit(..., 'x')
+ // absl::ByAnyChar("x") -> 'x'
Maybe you could make these comments into full sentences. I do think
saar.raz updated this revision to Diff 161372.
saar.raz added a comment.
- Address CR comments - add FoundDecl tracking, instantiationdependent
calculation, display non-constant expression diagnostic notes
Repository:
rC Clang
https://reviews.llvm.org/D41217
Files:
include/clang/AST/DeclT
JonasToth added a comment.
I see, thank you :)
Am 17.08.2018 um 18:55 schrieb Shuai Wang via Phabricator:
> shuaiwang added a comment.
>
> In https://reviews.llvm.org/D50883#1203690, @JonasToth wrote:
>
>> I am suprised that this does not automatically follow from the general
>> rules. At the
saar.raz added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
Quuxplusone wrote:
> For my own edification, could you explain whether, given
>
>
saar.raz added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:679-681
+ Diags.Report(Active->PointOfInstantiation,
+ diag::note_constraint_substitution_here)
+ << Active->InstantiationRange;
saar.raz wrote:
> rsm
saar.raz added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:679-681
+ Diags.Report(Active->PointOfInstantiation,
+ diag::note_constraint_substitution_here)
+ << Active->InstantiationRange;
rsmith wrote:
> Is th
kbobyrev added a comment.
In https://reviews.llvm.org/D50703#1205049, @malaperle wrote:
> I hadn't marked it as done because without symbols in main files I found it
> quite lacking.
Ah, I see, thank you for spotting it! I was under the impression that it's
feature-complete. Should I mark it
22 matches
Mail list logo
