rjmccall added a comment.
In https://reviews.llvm.org/D50616#1203446, @leonardchan wrote:
> In https://reviews.llvm.org/D50616#1202034, @ebevhan wrote:
>
> > I think I've mentioned this before, but I would like to discuss the
> > possibility of adding a target hook(s) for some of these operation
rjmccall added inline comments.
Comment at: test/CodeGenObjC/forward-declare-protocol-gnu.m:6
-Protocol *getProtocol(void)
-{
- return @protocol(P);
-}
+@interface I
+@end
arphaman wrote:
> rjmccall wrote:
> > Does this really not require a defin
mgrang updated this revision to Diff 161165.
mgrang edited the summary of this revision.
mgrang added a comment.
Added checks for more algorithms: stable_sort, is_sorted, partial_sort,
partition, stable_partition, nth_element.
https://reviews.llvm.org/D50488
Files:
include/clang/StaticAnalyz
shuaiwang created this revision.
shuaiwang added a reviewer: hokein.
Herald added subscribers: cfe-commits, Szelethus, a.sidorin, xazax.hun.
Herald added a reviewer: george.karpenkov.
For smart pointers like std::unique_ptr which uniquely owns the
underlying object, treat the mutation of the point
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D50882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: bcain
Date: Thu Aug 16 20:53:51 2018
New Revision: 339979
URL: http://llvm.org/viewvc/llvm-project?rev=339979&view=rev
Log:
[hexagon] restore -fuse-cxa-atexit by default
"-fno-use-cxa-atexit" was a default provided by the initial
commit offering hexagon support. This is no longer require
tejohnson created this revision.
tejohnson added a reviewer: pcc.
Herald added subscribers: dexonsmith, steven_wu, eraman, inglorion, mehdi_amini.
The number of threads used for ThinLTO backend parallelism was
dropped to the number of cores in r284618 to avoid oversubscribing
physical cores due to
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339979: [hexagon] restore -fuse-cxa-atexit by default
(authored by bcain, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D50816?vs=160928&id=16
Rakete requested changes to this revision.
Rakete added a comment.
This revision now requires changes to proceed.
Your patch breaks a lot of stuff in the test suite. For example:
void f() {
int A = 0;
(A++, A) = 1; // warning from this patch, but this is perfectly valid since
f
ahatanak updated this revision to Diff 161155.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Mark the block descriptor global variable as `unnamed_addr`.
Repository:
rC Clang
https://reviews.llvm.org/D50783
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
l
Hello everyone,
Below are some buildbot numbers for the last week of 8/05/2018 - 8/11/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the week of 7/29/2018 - 8/04/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
inglorion added inline comments.
Comment at: clang/lib/AST/MicrosoftMangle.cpp:389
+ if (FE) {
+llvm::MD5 Hasher;
+llvm::MD5::MD5Result Hash;
Instead of MD5, can we use xxhash (or whatever the fastest hash algorithm in
LLVM is these days)? I don't think
mgrang added a comment.
This was my first time using AST matchers so it took me a while to figure out
how exactly to get this right. clang-query helped a lot. Backspace seems to be
a problem with clang-query though.
https://reviews.llvm.org/D50488
___
mgrang updated this revision to Diff 161152.
mgrang added a comment.
Changed patch to use AST Matchers.
https://reviews.llvm.org/D50488
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-faster-strsplit-delimiter.rst:6
+
+This check triggers on calls to ``absl::StrSplit()`` or ``absl::MaxSplits()``
+where the delimiter is a single character string literal. The check will offer
---
Rakete added a comment.
It would be nice to be able to diagnose `X`:
template
struct Foo {
struct [[trivially_relocatable]] X { // no warning
X(X &&) = delete;
};
};
Foo f; // no warning
static_assert(!__is_trivially_relocatable(Foo::X)); // ok
But otherwise, you
zturner added subscribers: rnk, zturner.
zturner added a comment.
IIRC it’s `?A0xABCDABCD@` where the hex value is some kind of hash
https://reviews.llvm.org/D50877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
IIRC it’s `?A0xABCDABCD@` where the hex value is some kind of hash
On Thu, Aug 16, 2018 at 5:27 PM David Majnemer via Phabricator <
revi...@reviews.llvm.org> wrote:
> majnemer added a comment.
>
> How does MSVC handle this case? What mangled name does it generate?
>
>
> https://reviews.llvm.org/D5
majnemer added a comment.
How does MSVC handle this case? What mangled name does it generate?
https://reviews.llvm.org/D50877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
It appears that libcxx/include/CMakeLists.txt needs to be updated to include
`bit` file into the file set.
https://reviews.llvm.org/D50815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
rnk updated this revision to Diff 161148.
rnk added a comment.
- return to avoid bad notes
https://reviews.llvm.org/D50805
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/Sema/statements.c
Index: clang/test/Sema/statements.c
==
rnk created this revision.
rnk added reviewers: majnemer, inglorion, hans.
Herald added subscribers: dexonsmith, JDevlieghere, aprantl, mehdi_amini.
This is needed to avoid conflicts in mangled names for codeview types in
anonymous namespaces. In CodeView, types refer to each other typically
throu
vitalybuka reopened this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
Reverted r339971 as it breaks sanitizer bots
https://reviews.llvm.org/D50815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: vitalybuka
Date: Thu Aug 16 16:57:16 2018
New Revision: 339971
URL: http://llvm.org/viewvc/llvm-project?rev=339971&view=rev
Log:
Revert "Establish the header. NFC yet. Reviewed as
https://reviews.llvm.org/D50815";
Breaks build on sanitizer bots.
This reverts commit r339943.
Removed:
Author: hubert.reinterpretcast
Date: Thu Aug 16 16:56:54 2018
New Revision: 339969
URL: http://llvm.org/viewvc/llvm-project?rev=339969&view=rev
Log:
[libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback
Summary:
When a seed sequence would lead to having no non-zero significant bits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX339969: [libc++] Use correct rand.eng.mers all-zeroes seed
sequence fallback (authored by hubert.reinterpretcast, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50736?vs=160923&id=
Author: dblaikie
Date: Thu Aug 16 16:56:32 2018
New Revision: 339968
URL: http://llvm.org/viewvc/llvm-project?rev=339968&view=rev
Log:
Disable pubnames in NVPTX debug info using metadata
Added:
cfe/trunk/test/CodeGen/debug-nvptx.c
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified:
Author: juliehockett
Date: Thu Aug 16 16:50:51 2018
New Revision: 339966
URL: http://llvm.org/viewvc/llvm-project?rev=339966&view=rev
Log:
Revert "Implement a (simple) Markdown generator"
This reverts commit r339948, as it's breaking a few bots in ways that I
can't reproduce right now.
Removed:
mclow.lists added inline comments.
Comment at: include/bit:113
inline _LIBCPP_INLINE_VISIBILITY
unsigned __clz(unsigned __x) {
static_assert(sizeof(unsigned) == sizeof(unsigned long), "");
Missed this one. Should be `int`
https://reviews.llvm.org/D50876
mclow.lists created this revision.
mclow.lists added reviewers: ldionne, EricWF.
Still NFC here.
1. Take the 9 functions that each had an `#ifndef _LIBCPP_COMPILER_MSVC` ..
`#else` .. `endif` block in them and make just two blocks, each with 9
functions. Much easier to read, but makes for a ter
arphaman added a comment.
Sorry for the delay.
In https://reviews.llvm.org/D49462#1166032, @rjmccall wrote:
> Hmm. I think this is a reasonable change to make to the language. Have you
> investigated to see if this causes source-compatibility problems?
Yes, I tested this change on internal
arphaman updated this revision to Diff 161142.
arphaman marked 3 inline comments as done.
arphaman added a comment.
address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D49462
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
li
leonardchan added a comment.
In https://reviews.llvm.org/D50616#1202034, @ebevhan wrote:
> I think I've mentioned this before, but I would like to discuss the
> possibility of adding a target hook(s) for some of these operations
> (conversions, arithmetic when it comes). Precisely matching the
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:271-276
llvm::GlobalVariable *global =
-elements.finishAndCreateGlobal("__block_descriptor_tmp",
- CGM.getPointerAlign(),
- /*constant*/
Author: vedantk
Date: Thu Aug 16 16:19:50 2018
New Revision: 339964
URL: http://llvm.org/viewvc/llvm-project?rev=339964&view=rev
Log:
Relax a CHECK line to allow for dso_local
Fixes a bot failure:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11806
Modified:
rsmith added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:271-276
llvm::GlobalVariable *global =
-elements.finishAndCreateGlobal("__block_descriptor_tmp",
- CGM.getPointerAlign(),
- /*constant*/ t
rjmccall added a comment.
Okay.
Repository:
rC Clang
https://reviews.llvm.org/D50783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 161137.
ahatanak added a comment.
Try harder to shorten the names of block descriptor global variables.
The strings extracted from the names of the copy and dispose helpers are merged
whenever it is possible to do so. The block layout string doesn't include
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaInit.cpp:6927-6928
} else if (isa(L)) {
-Diag(DiagLoc, diag::warn_ret_addr_label) << DiagRange;
+if (LK == LK_Return)
+ Diag(DiagLoc, diag::warn_ret_addr_label) << DiagRange;
} els
rsmith added a comment.
In https://reviews.llvm.org/D50740#1203126, @arphaman wrote:
> In https://reviews.llvm.org/D50740#1202248, @jkorous wrote:
>
> > Hi Alex, nice work!
> >
> > I am just wondering if it would be beneficial to assert Loc and End are in
> > the same file. It might help to catc
mikerice added a comment.
In https://reviews.llvm.org/D50640#1203314, @thakis wrote:
> Thanks! Do you need someone to land this?
Feel free to commit it if you want. Otherwise I'll have my colleague take care
of it in the morning. Thanks!
https://reviews.llvm.org/D50640
_
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/27733
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/14670
On Thu, Aug 16, 2018 at 3:30 PM Vitaly Buka wrote:
> This brakes some bots
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/2
This brakes some bots
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/22441
/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/algorithm:648:10:
fatal error: 'bit' file not found
#include
^
1 error generated.
On Thu, Aug 16, 2018 at 2:36 PM M
arphaman updated this revision to Diff 161132.
arphaman marked an inline comment as done.
arphaman added a comment.
- Use lambda
- Work with spelling locs
Repository:
rC Clang
https://reviews.llvm.org/D50740
Files:
include/clang/Basic/SourceManager.h
lib/Basic/SourceManager.cpp
unittes
arphaman marked 2 inline comments as done.
arphaman added inline comments.
Comment at: lib/Basic/SourceManager.cpp:2035
+ "Passed invalid source location!");
+ assert(Start.isFileID() && End.isFileID() && Loc.isFileID() &&
+ "Passed non-file source location!");
-
hugoeg updated this revision to Diff 161130.
hugoeg added a comment.
added IsInAbseilFile Matcher
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
clang-tidy/abseil/NoInternalDepsChec
Author: vedantk
Date: Thu Aug 16 15:24:47 2018
New Revision: 339955
URL: http://llvm.org/viewvc/llvm-project?rev=339955&view=rev
Log:
[InstrProf] Use atomic profile counter updates for TSan
Thread sanitizer instrumentation fails to skip all loads and stores to
profile counters. This can happen if
thakis accepted this revision.
thakis added a comment.
Thanks! Do you need someone to land this?
https://reviews.llvm.org/D50640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added a comment.
@bruno: When we last discussed this my plan was to avoid the stat() in
lookupModuleFile() for files that were just added to the PCMCache by WriteAST()
entirely, but ModuleManager::Modules is a DenseMap and
lookupModuleFile() is the easiest way to create a new FileEntry.
Author: rsmith
Date: Thu Aug 16 15:04:36 2018
New Revision: 339952
URL: http://llvm.org/viewvc/llvm-project?rev=339952&view=rev
Log:
Factor Node creation out of the demangler. No functionality change intended.
(This is a port of llvm r339944 to libcxxabi.)
Modified:
libcxxabi/trunk/src/cxa_d
aprantl created this revision.
aprantl added reviewers: bruno, rsmith, teemperor.
Herald added a subscriber: llvm-commits.
Close FileEntries of cached files in ModuleManager::addModule().
While investigating why LLDB (which can build hundreds of clang
modules during one debug session) was getting
This revision was automatically updated to reflect the committed changes.
juliehockett marked an inline comment as done.
Closed by commit rCTE339948: Implement a (simple) Markdown generator (authored
by juliehockett, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43424?vs=15
Author: juliehockett
Date: Thu Aug 16 14:54:34 2018
New Revision: 339948
URL: http://llvm.org/viewvc/llvm-project?rev=339948&view=rev
Log:
Implement a (simple) Markdown generator
Implementing a simple Markdown generator from the emitted bitcode
summary of declarations. Very primitive at this poin
NoQ added inline comments.
Herald added subscribers: Szelethus, mikhail.ramalho.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1477-1530
+bool isPushBackCall(const FunctionDecl *Func) {
+ const auto *IdInfo = Func->getIdentifier();
+ if (!IdInfo)
+return false
mikerice added a comment.
In https://reviews.llvm.org/D50640#1201216, @thakis wrote:
> How does the gcc driver codepath handle this?
Interestingly I'd say. So the gcc PCH model uses -include pch.h to use a PCH.
In the driver, -include pch.h is handled by locating a matching pch file (say
pc
mikerice updated this revision to Diff 161116.
mikerice marked an inline comment as done.
mikerice added a comment.
Added a -verify test to ensure no warnings on successful PCH use.
https://reviews.llvm.org/D50640
Files:
lib/Driver/Driver.cpp
test/Driver/cl-pch.cpp
test/PCH/Inputs/pch-thr
NoQ created this revision.
NoQ added reviewers: dcoughlin, george.karpenkov.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, baloghadamsoftware, xazax.hun.
CFRetainReleaseChecker is a tiny checker that verifies that arguments of
CoreFoundation retain/release
mclow.lists closed this revision.
mclow.lists added a comment.
landed as revision 339943
https://reviews.llvm.org/D50815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Thu Aug 16 14:35:38 2018
New Revision: 339943
URL: http://llvm.org/viewvc/llvm-project?rev=339943&view=rev
Log:
Establish the header. NFC yet. Reviewed as https://reviews.llvm.org/D50815
Added:
libcxx/trunk/include/bit
Modified:
libcxx/trunk/include/algorithm
l
shuaiwang added a comment.
In https://reviews.llvm.org/D50619#1202135, @JonasToth wrote:
> @shuaiwang i tried to apply this and check the clang-tidy part again, but it
> does not compile (log attached).
> I update clang to master, did you add a matcher or something like this?
>
> F6950472: erro
Author: dblaikie
Date: Thu Aug 16 14:30:24 2018
New Revision: 339941
URL: http://llvm.org/viewvc/llvm-project?rev=339941&view=rev
Log:
Update for LLVM API change
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
http://llvm.org/viewvc/llvm-
JonasToth added inline comments.
Comment at: clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp:24
+
+ast_matchers::internal::Matcher
+constructExprWithArg(llvm::StringRef ClassName,
you dont need the `ast_matchers` namespace as there is a `using namespace
ast_m
arphaman added a comment.
In https://reviews.llvm.org/D50740#1202248, @jkorous wrote:
> Hi Alex, nice work!
>
> I am just wondering if it would be beneficial to assert Loc and End are in
> the same file. It might help to catch bugs.
I don't see the value in that unless I'm misunderstanding som
tra added a comment.
In https://reviews.llvm.org/D50845#1203031, @gtbercea wrote:
> In https://reviews.llvm.org/D50845#1202991, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D50845#1202965, @Hahnfeld wrote:
> >
> > > In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
> > >
> > > > As
JonasToth added inline comments.
Comment at: clang-tidy/abseil/AutoMakeUniqueCheck.cpp:21
+void AutoMakeUniqueCheck::registerMatchers(MatchFinder* finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
Please clang-format, `return` on next line.
JonasToth added a comment.
In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this
> should be just an alias to that check. Else, i think it would be be
deannagarcia created this revision.
deannagarcia added reviewers: hokein, alexfh.
deannagarcia added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
This check is an abseil specific check that checks for code using single
character string literals as delimiters and tran
Author: arsenm
Date: Thu Aug 16 13:19:47 2018
New Revision: 339934
URL: http://llvm.org/viewvc/llvm-project?rev=339934&view=rev
Log:
AMDGPU: Correct errors in device table
Modified:
cfe/trunk/lib/Basic/Targets/AMDGPU.h
Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.h
URL:
http://llvm.org/view
arsenm closed this revision.
arsenm added a comment.
r339934
https://reviews.llvm.org/D50843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk updated this revision to Diff 161098.
rnk added a comment.
- fix it right
https://reviews.llvm.org/D50805
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/Sema/statements.c
Index: clang/test/Sema/statements.c
===
--- clang/t
JonasToth added inline comments.
Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191
+void templated_thrower() { throw T{}(); }
+// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type
'int' is not derived from 'std::exception'
+
h
rnk updated this revision to Diff 161096.
rnk added a comment.
- keep the warning, suppress stmt expr case
https://reviews.llvm.org/D50805
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/Sema/statements.c
Index: clang/test/Sema/statements.c
==
Author: emmettneyman
Date: Thu Aug 16 13:13:40 2018
New Revision: 339933
URL: http://llvm.org/viewvc/llvm-project?rev=339933&view=rev
Log:
Update README and Dockerfile to include llvm-proto-fuzzer
Summary: Added commands to Dockerfile to build llvm-proto-fuzzer and the other
related tools. Also
vsapsai added a comment.
Have you checked that produced AST is of sufficient quality to be used?
Because, for example, for invalid code error recovery tries to keep going but
the end result isn't always good.
In the test you verify that you can ignore bogus includes. Is this the
real-world use
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339933: Update README and Dockerfile to include
llvm-proto-fuzzer (authored by emmettneyman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50829?vs=161093&id=161095#toc
Repository:
emmettneyman updated this revision to Diff 161093.
emmettneyman added a comment.
Rebased and ready to land
Repository:
rC Clang
https://reviews.llvm.org/D50829
Files:
clang/tools/clang-fuzzer/Dockerfile
clang/tools/clang-fuzzer/README.txt
Index: clang/tools/clang-fuzzer/README.txt
gtbercea added a comment.
In https://reviews.llvm.org/D50845#1202991, @hfinkel wrote:
> In https://reviews.llvm.org/D50845#1202965, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
> >
> > > As a result, we should really have a separate header that has those
> >
rnk added a comment.
Sounds good. I think, in the meantime, we all agree we can stop emitting this
warning in the statement expression case. I'll upload a patch for that.
Repository:
rC Clang
https://reviews.llvm.org/D50805
___
cfe-commits maili
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
lebedev.ri added reviewers: aaron.ballman, zinovy.nis.
lebedev.ri added a comment.
In https://reviews.llvm.org/D50852#1203009, @hugoeg wrote:
> In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
>
> > 1. Please always upload all patches with full context.
> > 2. There already is `mode
hugoeg added a comment.
In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:
> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this
> should be just an alias to that check. Else, i think it would be best
rsmith added a comment.
In https://reviews.llvm.org/D50805#1201910, @rnk wrote:
> I think the state machine use case is real, though, something like:
>
> void *f(void *startlabel) {
> common_work();
> goto *startlabel;
> state1:
> return &&state2;
> state2:
> return &&state3
gtbercea added a comment.
In https://reviews.llvm.org/D50845#1202973, @ABataev wrote:
> >> If I understand it correctly, the root cause of this exercise is that we
> >> want to compile for GPU using plain C. CUDA avoids this issue by
> >> separating device and host code via target attributes an
hfinkel added a comment.
In https://reviews.llvm.org/D50845#1202965, @Hahnfeld wrote:
> In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
>
> > As a result, we should really have a separate header that has those
> > actually-available functions. When targeting NVPTX, why don't we have
NoQ added a comment.
...and adding the aforementioned assertion for prvalues increases the number
of crashes on tests to 196. It seems that the analyzer assigns values of
improper loc-less very often, but then immediately overwrites them :/ I wonder
how much performance could be gained by fixi
ABataev added a comment.
>> If I understand it correctly, the root cause of this exercise is that we
>> want to compile for GPU using plain C. CUDA avoids this issue by separating
>> device and host code via target attributes and clang has few special cases
>> to ignore inline assembly errors i
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1202963, @hfinkel wrote:
> As a result, we should really have a separate header that has those
> actually-available functions. When targeting NVPTX, why don't we have the
> included math.h be CUDA's math.h? In the end, those are the f
hfinkel added a comment.
> Another option would be to implement some sort of attribute-based
> overloading. Then OpenMP can provide its own version of the device-side
> library function without clashing with system headers.
I'm thinking about what the desired behavior is here. So, if we have a
leonardchan added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:331
+ SourceLocation Loc);
+
/// Emit a conversion from the specified complex type to the specified
ebevhan wrote:
> What's the plan for the other conv
leonardchan updated this revision to Diff 161087.
leonardchan marked 6 inline comments as done.
leonardchan added a comment.
- Added separate case for conversions to a non-saturated type
Repository:
rC Clang
https://reviews.llvm.org/D50616
Files:
include/clang/AST/OperationKinds.def
incl
Hahnfeld added a comment.
In https://reviews.llvm.org/D50845#1202838, @tra wrote:
> In https://reviews.llvm.org/D50845#1202551, @ABataev wrote:
>
> > In https://reviews.llvm.org/D50845#1202550, @Hahnfeld wrote:
> >
> > > In https://reviews.llvm.org/D50845#1202540, @ABataev wrote:
> > >
> > > > Ma
NoQ added a comment.
> which is of course a bad thing to do because we should not bind `Loc`s to
> `prvalue` expressions
... of non-pointer type. On the other hand, binding `NonLoc`s to glvalue
expressions is always a bad thing to do; but, for the reference, adding this as
an assertion current
CaseyCarter created this revision.
CaseyCarter added reviewers: mclow.lists, EricWF.
Drive-by:
- Fix potential race between check and update of `throw_one` in operator new
- Fix latent bug in operator delete, which shouldn't decrement
`outstanding_new` when passed a null pointer
- Specifically c
emmettneyman updated this revision to Diff 161080.
emmettneyman added a comment.
Added to README
Repository:
rC Clang
https://reviews.llvm.org/D50829
Files:
clang/tools/clang-fuzzer/Dockerfile
clang/tools/clang-fuzzer/README.txt
Index: clang/tools/clang-fuzzer/README.txt
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339919: [ASTImporter] Add test for member pointer types.
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50792?vs=1608
Author: teemperor
Date: Thu Aug 16 11:22:21 2018
New Revision: 339919
URL: http://llvm.org/viewvc/llvm-project?rev=339919&view=rev
Log:
[ASTImporter] Add test for member pointer types.
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, martong, cfe-commits
Differential R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339918: [ASTImporter] Add test for importing
CompoundAssignOperators (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339917: [ASTImporter] Add test for DoStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50810?vs=160918&id=161075#to
1 - 100 of 250 matches
Mail list logo
