[PATCH] D50755: [Driver] -print-target-triple and -print-effective-triple options

phosek created this revision. phosek added reviewers: beanz, rnk. Herald added a subscriber: cfe-commits. These can be used to print Clang target and effective triple. Repository: rC Clang https://reviews.llvm.org/D50755 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Drive

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

emmettneyman updated this revision to Diff 160740. emmettneyman added a comment. Changed the multiloop protos to nested loop protos. All the protos have an inner loop and an outer loop. Repository: rC Clang https://reviews.llvm.org/D50670 Files: clang/tools/clang-fuzzer/cxx_loop_proto.pro

r339747 - Silence "unused variable" warning.

Author: rsmith Date: Tue Aug 14 18:06:30 2018 New Revision: 339747 URL: http://llvm.org/viewvc/llvm-project?rev=339747&view=rev Log: Silence "unused variable" warning. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngi

r339745 - [analyzer] Add support for constructors of arguments.

Author: dergachev Date: Tue Aug 14 17:33:55 2018 New Revision: 339745 URL: http://llvm.org/viewvc/llvm-project?rev=339745&view=rev Log: [analyzer] Add support for constructors of arguments. Once CFG-side support for argument construction contexts landed in r338436, the analyzer could make use of

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

This revision was automatically updated to reflect the committed changes. Closed by commit rL339743: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[libcxx] r339743 - [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

Author: ldionne Date: Tue Aug 14 17:30:03 2018 New Revision: 339743 URL: http://llvm.org/viewvc/llvm-project?rev=339743&view=rev Log: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions Summary: Since r338934, Clang emits an error when aligned allocation functions are used in c

[libcxx] r339742 - [libc++] Disable failing C11 feature tests for and

Author: ldionne Date: Tue Aug 14 17:18:01 2018 New Revision: 339742 URL: http://llvm.org/viewvc/llvm-project?rev=339742&view=rev Log: [libc++] Disable failing C11 feature tests for and Summary: Those tests are breaking the test bots. A Bugzilla has been filed to make sure those tests are re-ena

[PATCH] D50748: [libc++] Detect C11 features on non-Clang compilers

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX339741: [libc++] Detect C11 features on non-Clang compilers (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D50748?vs=160725&id=160727#toc Repository: rCXX l

[libcxx] r339741 - [libc++] Detect C11 features on non-Clang compilers

Author: ldionne Date: Tue Aug 14 17:16:41 2018 New Revision: 339741 URL: http://llvm.org/viewvc/llvm-project?rev=339741&view=rev Log: [libc++] Detect C11 features on non-Clang compilers Summary: The macros were inside `#if defined(_LIBCPP_COMPILER_CLANG)`, which means we would never detect C11 fe

[PATCH] D50748: [libc++] Detect C11 features on non-Clang compilers

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D50748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D50748: [libc++] Detect C11 features on non-Clang compilers

ldionne created this revision. ldionne added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof, krytarowski. The macros were inside `#if defined(_LIBCPP_COMPILER_CLANG)`, which means we would never detect C11 features on non-Clang

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. In https://reviews.llvm.org/D49890#1182556, @alexfh wrote: > Could you describe the specific problem you're solving and provide an > example? As mentioned by others, a test would be very welcome as well. Sorry for so much delay, @alexfh. I didn't see your comment. I

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert marked 4 inline comments as done. aaronpuchert added a comment. @aaron.ballman Maybe you can have a look again — this is much more elegant. I'm not sure why I didn't see this in the first place. Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:2765-2768 +

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert updated this revision to Diff 160719. aaronpuchert added a comment. Found a much simpler solution. After introducing a new virtual function HandleLock() in FactEntry, I just needed to change two lines in ThreadSafetyAnalyzer::addLock. Changes in BuildLockset::handleCall are no long

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. I don't have any other comments. Looks good to me. Repository: rCXX libc++ https://reviews.llvm.org/D50341 ___ cfe-commits mailing list cfe-

[clang-tools-extra] r339739 - [clangd] update the new test to check for diagnostic's category as well

Author: arphaman Date: Tue Aug 14 15:27:03 2018 New Revision: 339739 URL: http://llvm.org/viewvc/llvm-project?rev=339739&view=rev Log: [clangd] update the new test to check for diagnostic's category as well Modified: clang-tools-extra/trunk/test/clangd/fixits-embed-in-diagnostic.test Modifie

[PATCH] D32906: [Analyzer] Iterator Checker - Part 10: Support for iterators passed as parameter

NoQ requested changes to this revision. NoQ added a comment. This revision now requires changes to proceed. Herald added subscribers: Szelethus, mikhail.ramalho. Let's see if this is still necessary after https://reviews.llvm.org/D49443. Iterators will be constructed directly into the argument re

[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE339738: [clangd] add an extension field to LSP to transfer the diagnostic's category (authored by arphaman, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50571 Files:

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Szelethus. I think this patch is in good shape. In https://reviews.llvm.org/D32859#1187551, @baloghadamsoftware wrote: > I do not see which lines exactly you commented T

[clang-tools-extra] r339738 - [clangd] add an extension field to LSP to transfer the diagnostic's category

Author: arphaman Date: Tue Aug 14 15:21:40 2018 New Revision: 339738 URL: http://llvm.org/viewvc/llvm-project?rev=339738&view=rev Log: [clangd] add an extension field to LSP to transfer the diagnostic's category This patch adds a 'category' extension field to the LSP diagnostic that's sent by Cla

[clang-tools-extra] r339737 - [clangd] add missing test from r339454

Author: arphaman Date: Tue Aug 14 15:20:35 2018 New Revision: 339737 URL: http://llvm.org/viewvc/llvm-project?rev=339737&view=rev Log: [clangd] add missing test from r339454 I forgot to checkin the test for the fixits into SVN. Added: clang-tools-extra/trunk/test/clangd/fixits-embed-in-diagn

[PATCH] D50739: Clean up macros to detect underling C library functionality

ldionne added inline comments. Comment at: include/__config:433 -#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L +#if __ISO_C_VISIBLE >= 2011 # if defined(__FreeBSD__) ldionne wrote: > mclow.lists wrote: > > Should we be using `__ISO_C_VISIBLE` here, or

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like keys

NoQ added a comment. I guess one of the things the analyzer could find with path-sensitive analysis is direct comparison of non-aliasing pointers. Not only this is non-deterministic, but there's a related problem that comparison for equality would always yield false and is therefore useless. Ho

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Szelethus. Looks good. I guess we may have to tone down the heuristic about "all template functions" if we see it fail. @a.sidorin and @whisperity have some valid minor co

[PATCH] D50740: [SourceManager] isPointWithin: avoid using isBeforeInTranslationUnit, compare buffer offsets directly for lexical correctness

arphaman created this revision. arphaman added reviewers: jkorous, klimek, ioeric, vsapsai, ilya-biryukov. Herald added a subscriber: dexonsmith. The current implementation of `isPointWithin` uses `isBeforeInTranslationUnit` to check if a location is within a range. The problem is that `isPointWi

[PATCH] D50739: Clean up macros to detect underling C library functionality

ldionne added inline comments. Comment at: include/__config:433 -#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L +#if __ISO_C_VISIBLE >= 2011 # if defined(__FreeBSD__) mclow.lists wrote: > Should we be using `__ISO_C_VISIBLE` here, or `__STDC_VERSION__`

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Szelethus. Looks great, let's land this! https://reviews.llvm.org/D32747 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D50739: Clean up macros to detect underling C library functionality

mclow.lists added inline comments. Comment at: include/__config:433 -#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L +#if __ISO_C_VISIBLE >= 2011 # if defined(__FreeBSD__) Should we be using `__ISO_C_VISIBLE` here, or `__STDC_VERSION__`? I didn't change

[PATCH] D50739: Clean up macros to detect underling C library functionality

mclow.lists created this revision. mclow.lists added reviewers: ldionne, EricWF, dexonsmith. During the review of https://reviews.llvm.org/D50719, I said: > The presence/absence of C11 features in the underlying C library does not > depend on what version of the C++ language we're compiling with

r339731 - Remove obsolete comment

Author: steveire Date: Tue Aug 14 14:34:29 2018 New Revision: 339731 URL: http://llvm.org/viewvc/llvm-project?rev=339731&view=rev Log: Remove obsolete comment This related to the code as first checked in in r266292 ([ASTImporter] Implement some expression-related AST node import., 2016-04-14). M

[PATCH] D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer

shuaiwang updated this revision to Diff 160694. shuaiwang marked 2 inline comments as done. shuaiwang added a comment. Herald added a subscriber: Szelethus. - Fix a few cases overlooked previously - More test cases Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50619 Files: c

r339730 - Fix Stmt::ignoreImplicit

Author: steveire Date: Tue Aug 14 14:33:28 2018 New Revision: 339730 URL: http://llvm.org/viewvc/llvm-project?rev=339730&view=rev Log: Fix Stmt::ignoreImplicit Summary: A CXXBindTemporaryExpr can appear inside an ImplicitCastExpr, and was not ignored previously. Fixes the case reported in PR3732

[PATCH] D50666: Fix Stmt::ignoreImplicit

This revision was automatically updated to reflect the committed changes. Closed by commit rL339730: Fix Stmt::ignoreImplicit (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50666 Files: cfe/trunk/lib/AST/Stmt.cpp

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50737 Files: test/Import/cxx-noexcept-expr/Inputs/F.cpp test/Import/cxx-noexcept-expr/test.cpp Index: test/Import/cxx-noexcept-expr/test

[PATCH] D50738: Remove vestiges of configure buildsystem

steveire created this revision. Herald added subscribers: cfe-commits, mgorny. Remove also the condition to allow in-source builds when using MSVC_IDE. This may be vestigial and date from a time when llvm CMakeLists.txt had a similar condition. The llvm file does not have such a condition, so thi

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet added inline comments. Comment at: clangd/Cancellation.h:71 + +class TaskHandle { +public: ilya-biryukov wrote: > I wonder if we should make `TaskHandle` move-only? > > The reasoning is that is can be easily used from multiple threads (since it's > use

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

> On Aug 14, 2018, at 2:17 PM, Reid Kleckner wrote: > > After this, check-clang no longer worked, it emitted a fatal error because > USE_Z3_SOLVER was not in lit_config.params. I worked around it in r339728, > but you might want to double check it. Hm that’s strange, it works for me, and the

[PATCH] D21767: Fix instantiation of friend function templates

rjmccall added a comment. Oh, I see. The code currently tries to work with just the specialization and the pattern. To do the instantiation, we have to find template arguments for the context in which the pattern appears. For function temploids that aren't defined in a friend declaration, we

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

After this, check-clang no longer worked, it emitted a fatal error because USE_Z3_SOLVER was not in lit_config.params. I worked around it in r339728, but you might want to double check it. On Mon, Aug 13, 2018 at 4:13 PM George Karpenkov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Auth

r339728 - Fix lit fatal errors about requiring a USE_Z3_SOLVER param

Author: rnk Date: Tue Aug 14 14:15:57 2018 New Revision: 339728 URL: http://llvm.org/viewvc/llvm-project?rev=339728&view=rev Log: Fix lit fatal errors about requiring a USE_Z3_SOLVER param Modified: cfe/trunk/test/lit.site.cfg.py.in Modified: cfe/trunk/test/lit.site.cfg.py.in URL: http://ll

[PATCH] D50487: [CFG] [analyzer] Find argument constructors in CXXTemporaryObjectExprs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339727: [CFG] [analyzer] Find argument constructors in CXXTemporaryObjectExprs. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D50487: [CFG] [analyzer] Find argument constructors in CXXTemporaryObjectExprs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339727: [CFG] [analyzer] Find argument constructors in CXXTemporaryObjectExprs. (authored by dergachev, committed by ). Herald added a subscriber: Szelethus. Repository: rC Clang https://reviews.llvm.o

r339727 - [CFG] [analyzer] Find argument constructors in CXXTemporaryObjectExprs.

Author: dergachev Date: Tue Aug 14 14:10:46 2018 New Revision: 339727 URL: http://llvm.org/viewvc/llvm-project?rev=339727&view=rev Log: [CFG] [analyzer] Find argument constructors in CXXTemporaryObjectExprs. CXXTemporaryObjectExpr is a sub-class of CXXConstructExpr. If it has arguments that are s

r339726 - [analyzer] Add a test forgotten in r339088.

Author: dergachev Date: Tue Aug 14 14:06:30 2018 New Revision: 339726 URL: http://llvm.org/viewvc/llvm-project?rev=339726&view=rev Log: [analyzer] Add a test forgotten in r339088. Differential Revision: https://reviews.llvm.org/D50363 Added: cfe/trunk/test/Analysis/std-c-library-functions-in

[PATCH] D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: mclow.lists, EricWF, jasonliu. Herald added subscribers: ldionne, christof. When a seed sequence would lead to having no non-zero significant bits in the initial state of a `mersenne_twister_engine`, the fallbac

[PATCH] D50735: [ASTImporter] Add test for CXXScalarValueInit

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50735 Files: test/Import/cxx-scalar-value-init/Inputs/S.cpp test/Import/cxx-scalar-value-init/test.cpp Index: test/Import/cxx-scalar-val

[PATCH] D50733: [ASTImporter] Add test for ArrayInitLoopExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50733 Files: test/Import/array-init-loop-expr/Inputs/S.cpp test/Import/array-init-loop-expr/test.cpp Index: test/Import/array-init-loop-

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

ldionne updated this revision to Diff 160680. ldionne added a comment. Herald added a subscriber: mgorny. Add a way to change the default behavior of _LIBCPP_HIDE_FROM_ABI at build time. Also, rename the macro to _LIBCPP_ABI_HIDDEN_USE_INTERNAL_LINKAGE to align with other ABI-related macros. R

[PATCH] D50732: [ASTImporter] Add test for CXXDefaultInitExpr

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50732 Files: test/Import/cxx-default-init-expr/Inputs/S.cpp test/Import/cxx-default-init-expr/test.cpp Index: test/Import/cxx-default-in

[PATCH] D50678: [InlineAsm] Update the min-legal-vector-width function attribute based on inputs and outputs to inline assembly

This revision was automatically updated to reflect the committed changes. Closed by commit rC339721: [InlineAsm] Update the min-legal-vector-width function attribute based on… (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D50678 Files: lib/CodeGen/CGStm

r339721 - [InlineAsm] Update the min-legal-vector-width function attribute based on inputs and outputs to inline assembly

Author: ctopper Date: Tue Aug 14 13:21:05 2018 New Revision: 339721 URL: http://llvm.org/viewvc/llvm-project?rev=339721&view=rev Log: [InlineAsm] Update the min-legal-vector-width function attribute based on inputs and outputs to inline assembly Summary: Another piece of my ongoing to work for p

[PATCH] D50731: [ASTImporter] Add test for ExprWithCleanups

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50731 Files: test/Import/expr-with-cleanups/Inputs/S.cpp test/Import/expr-with-cleanups/test.cpp Index: test/Import/expr-with-cleanups/t

[PATCH] D50724: SafeStack: Disable Darwin support

This revision was automatically updated to reflect the committed changes. Closed by commit rL339720: SafeStack: Disable Darwin support (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50724 Files: cfe/trunk

r339720 - SafeStack: Disable Darwin support

Author: vlad.tsyrklevich Date: Tue Aug 14 12:50:41 2018 New Revision: 339720 URL: http://llvm.org/viewvc/llvm-project?rev=339720&view=rev Log: SafeStack: Disable Darwin support Summary: Darwin support does not appear to be used as evidenced by the fact that the runtime has never supported non-tri

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. A few more minor nits to be cleared up, but otherwise LGTM. You should wait for @rsmith to sign off before committing in case he has further comments, however.

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

morehouse added a comment. Another option would be to allow simple control flow within the loop itself. Repository: rC Clang https://reviews.llvm.org/D50670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

morehouse added a comment. In https://reviews.llvm.org/D50670#1199556, @emmettneyman wrote: > Should I switch my focus to nested loops instead? I think nested loops will > increase coverage. Yes, I'd recommend doing that. Repository: rC Clang https://reviews.llvm.org/D50670 ___

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Hi, this should have been fixed by https://reviews.llvm.org/rC339709 > On Aug 14, 2018, at 12:16 PM, Galina Kistanova wrote: > > Hello George, > > This commit broke few of our builders: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ub

[PATCH] D50214: Add inherited attributes before parsed attributes.

aaron.ballman added inline comments. Comment at: lib/AST/DeclBase.cpp:854-859 + auto I = Attrs.begin(), E = Attrs.end(); + for (; I != E; ++I) { +if (!(*I)->isInherited()) + break; + } + Attrs.insert(I, A); Meinersbur wrote: > aaron.ballman wrote: >

[PATCH] D50724: SafeStack: Disable Darwin support

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

ldionne added a comment. In https://reviews.llvm.org/D50341#1198863, @ldionne wrote: > In https://reviews.llvm.org/D50341#1198339, @vsapsai wrote: > > > What about defining a feature for unsupported configurations? I've tried > > > > if '__cpp_aligned_new' not in macros or \ > > intMa

Re: r339629 - [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Hello George, This commit broke few of our builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/34845 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/19056 http://lab.llvm.org:8011/builders/clang-lld-x86_64-2stage

[PATCH] D50535: Fix selective formatting of ObjC scope

acoomans added a comment. @jolesiak let me know what you think Repository: rC Clang https://reviews.llvm.org/D50535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

george.karpenkov added a comment. @baloghadamsoftware @xazax.hun we've had very promising results with using Z3 for refutation so far, almost at no cost, see Mikhail's recent email on cfe-dev (and sometimes at a negative cost!). Do you still not want to try it first? False negatives could be add

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x updated this revision to Diff 160660. cdavis5x added a comment. - Get rid of DISPATCHER_CONTEXT def for ARM. We only support ARM on Win8+ anyway. Repository: rUNW libunwind https://reviews.llvm.org/D50564 Files: include/__libunwind_config.h src/AddressSpace.hpp src/CMakeLists

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

george.karpenkov added a comment. Should be fixed now. Repository: rC Clang https://reviews.llvm.org/D50594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Should be fixed now. > On Aug 14, 2018, at 1:10 AM, Thomas Preud'homme via Phabricator > wrote: > > thopre added a comment. > > Hi George, > > This commit seems to be causing some testsuite regression on Armv8 (both > Aarch64 and ARM) architectures: > http://lab.llvm.org:8011/builders/clang-

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Should be fixed. > On Aug 14, 2018, at 10:32 AM, George Karpenkov via cfe-commits > wrote: > > Yes, investigating. Will rollback if not fixed in a few hours. > >> On Aug 14, 2018, at 3:17 AM, Yvan Roux via Phabricator >> wrote: >> >> yroux added a comment. >> >> Notice that the affected bo

r339709 - [analyzer] Fix bots by removing new check-clang-analyzer commands from CHECK-ALL

Author: george.karpenkov Date: Tue Aug 14 11:55:34 2018 New Revision: 339709 URL: http://llvm.org/viewvc/llvm-project?rev=339709&view=rev Log: [analyzer] Fix bots by removing new check-clang-analyzer commands from CHECK-ALL Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMa

[PATCH] D50618: Refactor Darwin driver to refer to runtimes by component

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D50618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

emmettneyman added a comment. No, it doesn't actually. I thought it would try to combine the separate loops into one block of vectorized instructions but after looking at the coverage of multiple loops vs single loop, they cover exactly the same parts of the Loop Vectorizer. Should I switch my

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 160652. kadircet marked 8 inline comments as done. kadircet added a comment. - Resolve discussions. - Get rid of CancellationHandler class. - Change error class name. - Improve documentation. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. I will clean this up as part of https://bugs.llvm.org/show_bug.cgi?id=38495 Repository: rCXX libc++ https://reviews.llvm.org/D50719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. thinking about this more, I think this the wrong long-term direction. The presence/absence of C11 features in the underlying C library does not depend on what version of the C++ language we're compiling with. The tests that use `TEXT_HAS_C11_XXX` should be updated to

r339704 - [OPENMP] Fix processing of declare target construct.

Author: abataev Date: Tue Aug 14 11:31:20 2018 New Revision: 339704 URL: http://llvm.org/viewvc/llvm-project?rev=339704&view=rev Log: [OPENMP] Fix processing of declare target construct. The attribute marked as inheritable since OpenMP 5.0 supports it + additional fixes to support new functionali

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX339702: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D50719?vs=160616&id=160648#toc Repository:

[PATCH] D50727: [clangd] Fetch documentation from the Index during signature help

ilya-biryukov updated this revision to Diff 160647. ilya-biryukov added a comment. - run clang-format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50727 Files: clangd/ClangdServer.cpp clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/index/Index.cpp clangd/index/

[libcxx] r339702 - [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

Author: ldionne Date: Tue Aug 14 11:16:56 2018 New Revision: 339702 URL: http://llvm.org/viewvc/llvm-project?rev=339702&view=rev Log: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES Summary: The macro was not defined in C++11 mode when it should have been, at least according to how _LI

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D48896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50726: [clangd] Show function documentation in sigHelp

ilya-biryukov added a comment. There's a test for the new behavior in https://reviews.llvm.org/D50726 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D50727: [clangd] Fetch documentation from the Index during signature help

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, kadircet. Herald added subscribers: arphaman, mgrang, jkorous, MaskRay. Sema can only be used for documentation in the current file, other doc comments should be fetched from the index. Repository: rCTE Clang T

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne marked an inline comment as done. ldionne added a comment. Ok, I'm pushing with JF's suggested change (use `TEST_STD_VER >= 11` instead of `__cplusplus >= 201103L`). Let's cross fingers that this is going to unbreak the testers -- like I said it fixed my Docker container. Repository:

[PATCH] D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/TargetInfo.cpp:72 +// For 64-bit Android, alignment is 8 bytes for allocations <= 8 bytes. +NewAlign = (Triple.isArch64Bit() || Triple.

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone updated this revision to Diff 160642. Quuxplusone marked an inline comment as done. Quuxplusone added a comment. Rebased, and ping! Repository: rC Clang https://reviews.llvm.org/D50119 Files: docs/LanguageExtensions.rst include/clang/AST/DeclCXX.h include/clang/AST/Type.h

[PATCH] D50715: [AST] Store the OwnedTagDecl as a trailing object in ElaboratedType.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D50715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne added a comment. In https://reviews.llvm.org/D50719#1199427, @mclow.lists wrote: > I have pissed in this area, too - See > https://bugs.llvm.org/show_bug.cgi?id=38495 and the proposed resolution here: > https://bugs.llvm.org/attachment.cgi?id=20692 > How about I just make this change a

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. In https://reviews.llvm.org/D50719#1199450, @dexonsmith wrote: > If the bots are red from a previous commit I think it would be better for > Louis to commit this separately. I'm ok with that. Repository: rCXX libc++ https://reviews.llvm.org/D50719 _

[PATCH] D50630: [AST] Update/correct the static_asserts for the bit-fields in Type

rjmccall added a comment. Sure, that seems like a reasonable optimization. Repository: rC Clang https://reviews.llvm.org/D50630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

dexonsmith accepted this revision. dexonsmith added a comment. In https://reviews.llvm.org/D50719#1199427, @mclow.lists wrote: > I have pissed in this area, too - See > https://bugs.llvm.org/show_bug.cgi?id=38495 and the proposed resolution here: > https://bugs.llvm.org/attachment.cgi?id=20692

[PATCH] D50726: [clangd] Show function documentation in sigHelp

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, kadircet. Herald added subscribers: arphaman, jkorous, MaskRay. Previously, clangd was trying to show documentation for the active parameter instead, which is wrong per LSP specification. Moreover, the code path t

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

mclow.lists added a comment. I have pissed in this area, too - See https://bugs.llvm.org/show_bug.cgi?id=38495 and the proposed resolution here: https://bugs.llvm.org/attachment.cgi?id=20692 How about I just make this change as part of that fix? Repository: rCXX libc++ https://reviews.llvm.

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1886 case BuiltinType::ObjCId: -mangleArtificalTagType(TTK_Struct, "objc_object"); +mangleArtificalTagType(TTK_Struct, ".objc_object"); break; DHowett-MSFT wrote: > I'm intere

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. ...And it turns out Phab marked the comments as done when I uploaded the new change. I didn't know it would do that. That's useful to know. Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-commits mail

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. Marked some comments as done. (Phab won't let me post an empty comment, so...) Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x updated this revision to Diff 160638. cdavis5x marked 3 inline comments as done. cdavis5x edited the summary of this revision. cdavis5x added a comment. - Update checks for DISPATCHER_CONTEXT definition. - Add link to KJK::Hyperion's articles on SEH. Repository: rUNW libunwind https:

[PATCH] D50641: [clangd][test] Fix exit messages in tests

jkorous added a comment. I can see the value of getting more information in case of unexpected test behaviour but I still don't really like to have separate codepath for testing purposes. Anyway, it's not a big deal and it looks like you guys are all in agreement about this. I created a patch

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. From `__ISO_C_VISIBLE >= 2011` it looks like this tries to test C11 features regardless of the C++ version. That's probably fine, but we're walking this line where only C++17 really guarantees C11 s

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet added inline comments. Comment at: clangd/Cancellation.cpp:17 +namespace { +static Key>> CancellationTokenKey; +} // namespace ilya-biryukov wrote: > Having a `shared_ptr` key in the Context can cause data races (e.g. if we > copy it concurrently from m

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 160636. kadircet marked 4 inline comments as done. kadircet added a comment. - Get rid of getCancellationError. - Add replyError helper. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50502 Files: clangd/CMakeLists.txt clangd/Cancellat

[libcxx] r339697 - [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

Author: mstorsjo Date: Tue Aug 14 10:33:10 2018 New Revision: 339697 URL: http://llvm.org/viewvc/llvm-project?rev=339697&view=rev Log: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option This option should be available if LIBCXX_ENABLE_SHARED is enabled, not LIBCXX_ENABLE_STATIC.

  1   2   3   >