[PATCH] D50055: Update the coding standard about NFC changes and whitespace

chandlerc added inline comments. Comment at: docs/CodingStandards.rst:514-516 +line of code. Some common editors will automatically remove trailing whitespace +when saving a file which causes unrelated changes to appear in diffs and +commits. Meinersbur wrote: >

[PATCH] D50055: Update the coding standard about NFC changes and whitespace

Meinersbur added inline comments. Comment at: docs/CodingStandards.rst:514-516 +line of code. Some common editors will automatically remove trailing whitespace +when saving a file which causes unrelated changes to appear in diffs and +commits. Just to note that t

r338962 - Use Optional instead of unique_ptr; NFC

Author: gbiv Date: Sat Aug 4 18:37:07 2018 New Revision: 338962 URL: http://llvm.org/viewvc/llvm-project?rev=338962&view=rev Log: Use Optional instead of unique_ptr; NFC Looks like the only reason we use a unique_ptr here is so that we can conditionally construct a LogicalErrorHandler. It's a sm

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

phosek added a comment. In https://reviews.llvm.org/D49355#1188520, @aaronpuchert wrote: > Could you explain what annotations like `LOCK_UNLOCK` are useful for? What do > they check? The annotation should certainly not be necessary. > > Shouldn't you just use `REQUIRES(!...)` or `EXCLUDES(...)`?

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1036 +return; + // That's it. We can't rule out any more cases with the data we have. + rsmith wrote: > rsmith wrote: > > lebedev.ri wrote: > > > rsmith wrote: > > > > I don't like th

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri updated this revision to Diff 159187. lebedev.ri marked 11 inline comments as done. lebedev.ri added a comment. Address most of @rsmith review notes. Repository: rC Clang https://reviews.llvm.org/D50250 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanitizer.rst include

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

malaperle added a comment. Both check-clang and check-clang-tools pass successfully for me on Windows with the patch. Repository: rC Clang https://reviews.llvm.org/D48903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro

IdrissRio updated this revision to Diff 159179. IdrissRio added a comment. Thank you @alexfh. You where right. This update is more general. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49800 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp test/clang-tidy/modernize-r

[PATCH] D50261: [AST] Remove unnecessary indirections in DeclarationNameTable

bricci added a comment. I did both a clean build and an incremental build with and without this patch and was not able to see any meaningful difference in the build time. Suspiciously the build time *with* the patch in both cases is a little less (~0.1% ) than without the patch but this is well

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

aaronpuchert added a comment. Could you explain what annotations like `LOCK_UNLOCK` are useful for? What do they check? The annotation should certainly not be necessary. Shouldn't you just use `REQUIRES(!...)` or `EXCLUDES(...)`? If a function locks and unlocks a mutex, I don't see a reason to

[PATCH] D50294: [Driver] Use -gdwarf-3 by default for FreeBSD

MaskRay created this revision. MaskRay added reviewers: brad, emaste, khng300. Herald added subscribers: cfe-commits, JDevlieghere, aprantl. The imported binutils in base supports DWARF 3. Repository: rC Clang https://reviews.llvm.org/D50294 Files: lib/Driver/ToolChains/FreeBSD.h test/Co

[PATCH] D50055: Update the coding standard about NFC changes and whitespace

chandlerc accepted this revision. chandlerc added a comment. This looks really good to me and seems like a nice clarification of historical practice. =D Thanks so much for driving an actual documentation update for folks that simply would never know about these practices otherwise, I think it w

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware added a comment. https://reviews.llvm.org/D32747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits