yvvan added a comment.
I'm mostly fine with your set of patches. Let me double check and we can get it
in.
https://reviews.llvm.org/D49063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:2582
/// yet; if a cleanup is required for the variable itself, that needs
/// to be done externally.
+void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr,
ahatanak wrote:
>
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:2582
/// yet; if a cleanup is required for the variable itself, that needs
/// to be done externally.
+void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr,
rjmccall wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338006: [CMake] Don't generate linker script only when
shared library isn't statically… (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
Author: phosek
Date: Wed Jul 25 22:10:24 2018
New Revision: 338006
URL: http://llvm.org/viewvc/llvm-project?rev=338006&view=rev
Log:
[CMake] Don't generate linker script only when shared library isn't statically
linked
Since r337668, we support statically linking dependencies only to shared
or s
Author: ericwf
Date: Wed Jul 25 22:08:30 2018
New Revision: 338005
URL: http://llvm.org/viewvc/llvm-project?rev=338005&view=rev
Log:
Copy LLVM CMake configuration for CMake Policy CMP0068
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc
mstorsjo accepted this revision.
mstorsjo added a comment.
LGTM. Should the same tweak also be done for arm/thumb?
Repository:
rC Clang
https://reviews.llvm.org/D49770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
phosek created this revision.
phosek added reviewers: EricWF, ldionne, mclow.lists.
Herald added subscribers: cfe-commits, christof, mgorny.
Since r337668, we support statically linking dependencies only to shared
or static library. However, that change hasn't updated the check whether
to generate
Author: ericwf
Date: Wed Jul 25 21:02:06 2018
New Revision: 338002
URL: http://llvm.org/viewvc/llvm-project?rev=338002&view=rev
Log:
Be more consistent about which bool value means an error occurred
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/
Author: ericwf
Date: Wed Jul 25 20:57:26 2018
New Revision: 338001
URL: http://llvm.org/viewvc/llvm-project?rev=338001&view=rev
Log:
Cleanup the last_write_time internals
Modified:
libcxx/trunk/src/experimental/filesystem/filesystem_common.h
libcxx/trunk/src/experimental/filesystem/operat
malaperle created this revision.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
That way, as soon as the "initialize" is received by the server, it can start
parsing/indexing with a valid compilation database and not have to wait for a
an initial 'didCha
Author: ericwf
Date: Wed Jul 25 20:42:25 2018
New Revision: 338000
URL: http://llvm.org/viewvc/llvm-project?rev=338000&view=rev
Log:
Correct comment about stat truncating st_mtimespec to seconds
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_wr
Author: ericwf
Date: Wed Jul 25 20:36:37 2018
New Revision: 337999
URL: http://llvm.org/viewvc/llvm-project?rev=337999&view=rev
Log:
Fix attribute placement WRT extern C
Modified:
libcxx/trunk/src/experimental/filesystem/int128_builtins.cpp
Modified: libcxx/trunk/src/experimental/filesystem/
Thank you for the clarification.
On Wed, Jul 25, 2018 at 9:16 PM James Y Knight wrote:
> As is the case on most modern platforms, the ability to store a high-res
> file timestamp is dependent on the filesystem the file is stored on.
>
> The HFS+ filesystem (used by default before macOS 10.13) st
Author: ericwf
Date: Wed Jul 25 20:28:48 2018
New Revision: 337998
URL: http://llvm.org/viewvc/llvm-project?rev=337998&view=rev
Log:
Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds.
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_wri
As is the case on most modern platforms, the ability to store a high-res
file timestamp is dependent on the filesystem the file is stored on.
The HFS+ filesystem (used by default before macOS 10.13) stores timestamps
at a 1-second granularity, and APFS (now the default) at a 1 nanosecond
granulari
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D49718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
NoQ updated this revision to Diff 157416.
NoQ marked 4 inline comments as done.
NoQ added a comment.
Address comments by editing comments.
https://reviews.llvm.org/D49715
Files:
include/clang/Analysis/ConstructionContext.h
include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
includ
NoQ added a comment.
The "Assuming..." diagnostic piece isn't the same as "Taking true/false branch"
diagnostic piece. The former indicates that a constraint is added. The latter
indicate how the path flows between program points.
The absence of "Assuming..." indicates that Z3 didn't need to ma
mikhail.ramalho added a comment.
> Uhm, dunno, plist/FileCheck tests are annoying. What i usually do to make
> sense out of them is update the tested output with the actual output and look
> at git diff. From that it's usually obvious what exactly happened (warnings
> added, warnings removed, w
Author: ericwf
Date: Wed Jul 25 18:10:50 2018
New Revision: 337991
URL: http://llvm.org/viewvc/llvm-project?rev=337991&view=rev
Log:
Add print statements to help debugging
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
Modi
NoQ added a comment.
Sorry, i'm still lagging with my reviews because there are a lot of them and i
have to balance it with doing actual work. I'll hopefully get to this soon.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:681-689
+Optional OtherObj
vsapsai added a comment.
In https://reviews.llvm.org/D49119#1176047, @ahatanak wrote:
> In https://reviews.llvm.org/D49119#1164285, @vsapsai wrote:
>
> > Also I had a few ideas for tests when the warning isn't required and it is
> > absent. But I'm not sure they are actually valuable. If you are
NoQ added inline comments.
Comment at: test/Analysis/cxx-uninitialized-object-ptr-ref.cpp:290
struct IntDynTypedVoidPointerTest1 {
- void *vptr; // expected-note{{uninitialized pointee 'this->vptr'}}
+ void *vptr; // expected-note{{uninitialized pointee 'this->static_cast(vptr
NoQ added a comment.
In https://reviews.llvm.org/D49536#1176128, @mikhail.ramalho wrote:
> I getting the following error when analyzing
> `test/Analysis/plist-macros.cpp`, usign z3 as constraint manager
> (`-analyzer-constraints=z3 -DANALYZER_CM_Z3`):
>
> /home/mgadelha/llvm/tools/clang/test/
mikhail.ramalho added a comment.
I getting the following error when analyzing `test/Analysis/plist-macros.cpp`,
usign z3 as constraint manager (`-analyzer-constraints=z3 -DANALYZER_CM_Z3`):
/home/mgadelha/llvm/tools/clang/test/Analysis/plist-macros.cpp:640:16: error:
CHECK-NEXT: expected stri
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX337990: [libc++] Add hack to allow ubsan to work w/o
compiler-rt (__muloti4 is… (authored by EricWF, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D49828
Files:
src/experimental
leonardchan added a comment.
@aaron.ballman @rsmith Any more feedback on this patch?
Repository:
rC Clang
https://reviews.llvm.org/D49511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: ericwf
Date: Wed Jul 25 17:34:50 2018
New Revision: 337990
URL: http://llvm.org/viewvc/llvm-project?rev=337990&view=rev
Log:
[libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is
undefined)
Summary:
Using int128_t with UBSAN causes link errors unless compiler-rt is provi
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:605
+ if (Pos && !Pos->isValid()) {
+// If I do not put a tag here, some invalidation tests will fail
+static CheckerProgramPointTag Tag("InvalidatedIteratorChecker",
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Bit of a hack, but I'm ok with it.
Repository:
rCXX libc++
https://reviews.llvm.org/D49828
___
cfe-commits mailing list
cfe-commits@lists.
Author: arphaman
Date: Wed Jul 25 16:59:54 2018
New Revision: 337984
URL: http://llvm.org/viewvc/llvm-project?rev=337984&view=rev
Log:
[libc++] Follow-up to r337968: use an explicit cast as suggested by Eric
Modified:
libcxx/trunk/src/experimental/filesystem/filesystem_common.h
Modified: lib
EricWF created this revision.
EricWF added reviewers: mclow.lists, ldionne, rsmith, jyknight, echristo.
Herald added a subscriber: dberris.
Using __int128_t with UBSAN causes link errors unless compiler-rt is providing
the runtime library.
Specifically ubsan generates calls to __muloti4 but libgc
ssijaric updated this revision to Diff 157394.
ssijaric added a comment.
Updated to address Martin's observation. Verified that small structs with
default copy constructors and non-trivial destructors are passed in registers
on ARM64 Windows.
Repository:
rC Clang
https://reviews.llvm.org/D
ahatanak updated this revision to Diff 157398.
ahatanak added a comment.
Add a test case for an interface conforming to a non-escaping protocol.
In https://reviews.llvm.org/D49119#1164285, @vsapsai wrote:
> Also I had a few ideas for tests when the warning isn't required and it is
> absent. But
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yep, that'll do, thanks! Sorry for not keeping up with all the incoming reviews.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:536
if (!SR.isLiveRegion(Cont.firs
ahatanak updated this revision to Diff 157395.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Document the meaning of enterByrefCleanup's parameters.
Repository:
rC Clang
https://reviews.llvm.org/D49718
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGDecl.cpp
lib/Co
mgrang updated this revision to Diff 157391.
mgrang added a comment.
Rebased patch and fixed unit test on Windows.
https://reviews.llvm.org/D48862
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Linux.cpp
test/Driver/Inputs/openembedded_aarch64_linux_tree/usr/include/c++/6.3.0
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:159
+ std::unique_ptr(RTDyldMM));
+ builder.setOptLevel(OLvl);
+ builder.setTargetOptions(InitTargetOptionsFromCodeGenFlags());
emmettneyman wrote:
> moreh
NoQ requested review of this revision.
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1300
+ Loc::isLocType(S->getRHS()->getType())) {
+SVal V = SVB.makeSymbolVal(S);
+Cached[S] =
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
Satisfies a review comment in https://reviews.llvm.org/D49749.
Repository:
rC Clang
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337982: [CMake] Don't use LIBCXXABI_ENABLE_STATIC
option before its declared (authored by sbc, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D498
Author: sbc
Date: Wed Jul 25 16:13:00 2018
New Revision: 337982
URL: http://llvm.org/viewvc/llvm-project?rev=337982&view=rev
Log:
[CMake] Don't use LIBCXXABI_ENABLE_STATIC option before its declared
Summary:
rL337867 introduced two new cmake_dependent_option options:
- LIBCXXABI_INSTALL_STATIC_LI
emmettneyman updated this revision to Diff 157388.
emmettneyman added a comment.
Fixed some things, made code cleaner
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp
clang/tools/clang-fuzzer/handle-llvm/CMakeLis
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:89
+ Builder.Inliner = createFunctionInliningPass(OptLevel, SizeLevel, false);
+ Builder.LoopVectorize = true;
+ Builder.populateFunctionPassManager(FPM);
more
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D49825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
sbc100 added a comment.
https://reviews.llvm.org/D49825 seems to fix it.
Repository:
rCXX libc++
https://reviews.llvm.org/D49573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbc100 created this revision.
Herald added subscribers: cfe-commits, ldionne, christof, aheejin, mgorny.
https://reviews.llvm.org/rL337867 introduced two new cmake_dependent_option
options:
- LIBCXXABI_INSTALL_STATIC_LIBRARY
- LIBCXXABI_INSTALL_SHARED_LIBRARY
They depend on LIBCXXABI_ENABLE_STA
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337979: [CMake] Don't install c++abi headers in
standalone libc++ build (authored by phosek, committed by ).
Herald added
Author: phosek
Date: Wed Jul 25 15:57:39 2018
New Revision: 337979
URL: http://llvm.org/viewvc/llvm-project?rev=337979&view=rev
Log:
[CMake] Don't install c++abi headers in standalone libc++ build
This is a refinement on r337833. Previously we were installing two
copies of c++abi headers in libc+
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:2582
/// yet; if a cleanup is required for the variable itself, that needs
/// to be done externally.
+void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr,
Please document t
phosek added a comment.
In https://reviews.llvm.org/D42019#1162644, @mcgrathr wrote:
> Is this still live? Should it be different after all the multiarch stuff?
I'm about to revive this and was pondering if maybe we should generalize this
to all targets now that the multiarch runtime bit has l
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yup, tests for temporaries are great to have as well.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2475-2477
// Check if we are returning freed memory.
if (Sym)
Author: rtrieu
Date: Wed Jul 25 15:52:05 2018
New Revision: 337978
URL: http://llvm.org/viewvc/llvm-project?rev=337978&view=rev
Log:
[ODRHash] Support hashing enums.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/include/clang/Basic/Diagno
devnexen updated this revision to Diff 157381.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
NoQ added a comment.
Devin has recently pointed out that we might have as well reordered CFG
elements to have return statement kick in after automatic destructors, so that
callbacks were called in a different order. I don't see any problems with that
solution, but let's stick to the current sol
sbc100 added a comment.
FYI, this broke the WebAssembly waterfall, where the library is no longer being
installed: https://wasm-stat.us/builders/linux/builds/34191
There is probably an easy fix, but I thought I'd post here for the record.
Repository:
rCXX libc++
https://reviews.llvm.org/D49
ahatanak added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 157380.
ahatanak added a comment.
Set the BLOCK_FIELD_IS_WEAK bit of the flag passed to the call to
enterByrefCleanup in EmitAutoVarCleanups and fix test case
test/CodeGenObjC/blocks.m.
Repository:
rC Clang
https://reviews.llvm.org/D49718
Files:
lib
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains/Darwin.cpp:2027
+ isAlignedAllocationUnavailable())
CC1Args.push_back("-faligned-alloc-unavailable");
}
Quux
efriedma added a comment.
Herald added a subscriber: jfb.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D45712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jul 25 15:21:47 2018
New Revision: 337976
URL: http://llvm.org/viewvc/llvm-project?rev=337976&view=rev
Log:
Work around GCC bug in constexpr function
Modified:
libcxx/trunk/test/libcxx/experimental/filesystem/convert_file_time.sh.cpp
Modified:
libcxx/trunk/test/libc
juliehockett added a comment.
ping
https://reviews.llvm.org/D48341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jul 25 15:07:36 2018
New Revision: 337974
URL: http://llvm.org/viewvc/llvm-project?rev=337974&view=rev
Log:
Fix GCC build in C++14 w/o c++14 constexpr
Modified:
libcxx/trunk/src/experimental/filesystem/filesystem_common.h
Modified: libcxx/trunk/src/experimental/files
rnkovacs updated this revision to Diff 157375.
rnkovacs retitled this revision from "[analyzer][WIP] Detect pointers escaped
after return statement execution in MallocChecker" to "[analyzer] Detect
pointers escaped after return statement execution in MallocChecker".
rnkovacs edited the summary of
Author: ericwf
Date: Wed Jul 25 14:58:37 2018
New Revision: 337971
URL: http://llvm.org/viewvc/llvm-project?rev=337971&view=rev
Log:
Remove test which shouldn't have been committed
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.
aaronpuchert added a comment.
No problem. Thanks for the review! Would be nice if you or @aaron.ballman could
commit this, as I don't have commit access.
Repository:
rC Clang
https://reviews.llvm.org/D49355
___
cfe-commits mailing list
cfe-commi
Author: ericwf
Date: Wed Jul 25 14:53:43 2018
New Revision: 337970
URL: http://llvm.org/viewvc/llvm-project?rev=337970&view=rev
Log:
Fix failing test under C++14
Modified:
libcxx/trunk/src/experimental/filesystem/filesystem_common.h
Modified: libcxx/trunk/src/experimental/filesystem/filesyst
ahatanak updated this revision to Diff 157373.
ahatanak added a comment.
Check if destructors are accessible from InitListChecker's constructor. Add
test cases for designated initializer and brace elision.
Repository:
rC Clang
https://reviews.llvm.org/D45898
Files:
lib/Sema/SemaInit.cpp
Author: arphaman
Date: Wed Jul 25 14:50:44 2018
New Revision: 337968
URL: http://llvm.org/viewvc/llvm-project?rev=337968&view=rev
Log:
[libc++] Follow-up to r337960: specify lambda's return type to avoid
-Wc++11-narrowing warning on Darwin
The internal CI produced the following diagnostic:
error:
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:979-1003
+bool ScalarExprEmitter::IsTopCastPartOfExplictCast() {
+ assert(!CastExprStack.empty());
+ // Walk the current stack of CastExprs in reverse order.
+ // That is, the current CastExpr, which is
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
This has too much duplication with respect to your previous patch, and even
Phabricator highlights it in yellow.
Repository:
rC Clang
https://reviews.llvm.org
rsmith added a comment.
I've not done a full review, but the approach here looks good, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D49729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
delesley accepted this revision.
delesley added a comment.
This revision is now accepted and ready to land.
Looks good to me. Thanks for the patch, and my apologies for the slow
response. (I'm on a different project now, so I'm afraid thread safety doesn't
always get the attention from me that
ssijaric added a comment.
Yes, it looks like the comment for the thumb case is applicable here as well.
VC++ on ARM64 passes small structs with a destructor and a default copy
constructor in a register, while clang passes them on the stack. I will
probably address this in a separate patch.
EricWF closed this revision.
EricWF added a comment.
r337962.
Thanks.
Repository:
rCXX libc++
https://reviews.llvm.org/D49813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jul 25 14:01:45 2018
New Revision: 337962
URL: http://llvm.org/viewvc/llvm-project?rev=337962&view=rev
Log:
Make compile with gcc 4.8.5
Patch by Victor Zverovich.
This fixes an error when compiling `` with gcc 4.8.5:
```
.../libcxx/src/experimental/filesystem/filesyste
vitaut added a comment.
@EricWF could you or someone else commit this as I don't have commit access?
Thanks.
Repository:
rCXX libc++
https://reviews.llvm.org/D49813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX337960: [libc++] Use __int128_t to represent
file_time_type. (authored by EricWF, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D49774
Files:
include/experimental/filesystem
s
Author: ericwf
Date: Wed Jul 25 13:51:49 2018
New Revision: 337960
URL: http://llvm.org/viewvc/llvm-project?rev=337960&view=rev
Log:
[libc++] Use __int128_t to represent file_time_type.
Summary:
The ``file_time_type`` time point is used to represent the write times for
files.
Its job is to act a
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm going to go ahead and commit this now. We can address concerns about the
future C++20 spec in follow up commits.
https://reviews.llvm.org/D49774
___
erik.pilkington added a comment.
Hi Balaji,
I reduced your testcase a bit more, this looks like the can be a crash on
valid. Can you use the more minimal version in the testcase?
template
struct e {
e(a) {}
};
e c(0);
Also: you should add cfe-commits as a subscriber when creatin
echristo added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:933-938
+ if (TC.supportsDebugInfoOption(A)) {
+Action();
+return true;
+ }
+ reportUnsupportedDebugInfoOption(A, Args, D, TC.getTriple());
+ return false;
I'd probably simpli
EricWF updated this revision to Diff 157349.
EricWF added a comment.
Update with misc cleanups.
https://reviews.llvm.org/D49774
Files:
include/experimental/filesystem
src/chrono.cpp
src/experimental/filesystem/filesystem_common.h
src/experimental/filesystem/operations.cpp
src/include/
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Urg. That's an old compiler. But this looks OK to me.
Repository:
rCXX libc++
https://reviews.llvm.org/D49813
___
cfe-commits mailing list
cfe
kcc added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:114
+Partial,// Sign the return address of functions that spill LR
+All // Sign the return address of all functions
+ };
what's the purpose of signing LR i
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yet another great catch!
I guess you could write a test with `debug.AnalysisOrder` (by making its
`checkEndFunction` callback (that you'll have to define) print different things
depending on the re
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp:44
+
+ PassRegistry &Registry = *llvm::PassRegistry::getPassRegistry();
+ initializeCore(Registry);
Unnecessary `llvm::`
Comment a
Author: abataev
Date: Wed Jul 25 13:03:01 2018
New Revision: 337957
URL: http://llvm.org/viewvc/llvm-project?rev=337957&view=rev
Log:
[OPENMP] ThreadId in serialized parallel regions is 0.
The first argument for the parallel outlined functions, called as
serialized parallel regions, should be a p
simark added a comment.
Thanks, that's simple and efficient. I'll update
https://reviews.llvm.org/D49267 (to call `reparseOpenFiles` once again) once
this is merged.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49783
___
cfe-co
EricWF added a comment.
In https://reviews.llvm.org/D49774#1175679, @BillyONeal wrote:
> In https://reviews.llvm.org/D49774#1175650, @ldionne wrote:
>
> > In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
> >
> > > In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> > >
BillyONeal added a comment.
In https://reviews.llvm.org/D49774#1175650, @ldionne wrote:
> In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
>
> > In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> >
> > > Another problem (that Eric and I discussed last night) is that f
NoQ accepted this revision.
NoQ added a comment.
Looks great!
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:192
- if (Call.isCalled(CStrFn) || Call.isCalled(DataFn)) {
-SVal RawPtr = Call.getReturnValue();
-if (SymbolRef Sym = RawPtr.getAsSymbol(/*I
mclow.lists added a comment.
In https://reviews.llvm.org/D49774#1175650, @ldionne wrote:
> In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
>
> > In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> >
> > > Another problem (that Eric and I discussed last night) is that
rnkovacs added a comment.
I'm not sure how to test this.
I'll need it in https://reviews.llvm.org/D49361 when I update it to use the
changed `checkEndFunction()` callback, and that will kind of test this too.
Repository:
rC Clang
https://reviews.llvm.org/D49811
___
ldionne added a comment.
In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
> In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
>
> > Another problem (that Eric and I discussed last night) is that filesystem
> > is part of C++17, and `file_clock` is C++20. So we need a
Author: ldionne
Date: Wed Jul 25 12:40:01 2018
New Revision: 337955
URL: http://llvm.org/viewvc/llvm-project?rev=337955&view=rev
Log:
[libc++] Factor duplicate code into function templates
Summary:
The exact same code was replicated 11 times for implementing the basic_istream
input operators (tho
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX337955: [libc++] Factor duplicate code into function
templates (authored by ldionne, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49808?vs=157316&id=157340#toc
Repository:
rCX
Author: mramalho
Date: Wed Jul 25 12:34:48 2018
New Revision: 337954
URL: http://llvm.org/viewvc/llvm-project?rev=337954&view=rev
Log:
[analyzer] Update SMT API documentation and methods
Summary:
Update the documentation of all the classes introduced with the new generic SMT
API, most of them we
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D48753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 247 matches
Mail list logo
