lebedev.ri added a comment.
In https://reviews.llvm.org/D49348#1164579, @anemet wrote:
> LGTM, thanks!
Thank you for the review.
(I'll watch the bots, obviously)
Repository:
rC Clang
https://reviews.llvm.org/D49348
___
cfe-commits mailing list
Author: ericwf
Date: Mon Jul 16 22:48:48 2018
New Revision: 337235
URL: http://llvm.org/viewvc/llvm-project?rev=337235&view=rev
Log:
Address "always inline function is not always inlinable" warning with GCC.
When an always_inline function is used prior to the functions definition,
the compiler ma
jtbandes marked an inline comment as done.
jtbandes added a comment.
Ping again 😇
Repository:
rL LLVM
https://reviews.llvm.org/D48266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337232: [Driver] Add -fno-digraphs (authored by jtbandes,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48266?vs=155116&id=155809#toc
Repos
anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D49348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: dergachev
Date: Mon Jul 16 18:39:25 2018
New Revision: 337231
URL: http://llvm.org/viewvc/llvm-project?rev=337231&view=rev
Log:
[analyzer] Fix size_t in tests.
Should fix a buildbot. No functional change intended.
Modified:
cfe/trunk/test/Analysis/pr37802.cpp
Modified: cfe/trunk/t
ahatanak added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
It is really nice to see this checker take shape! Some drive by diagnostic
comments in line.
Comment at: test/Analysis/dangling-internal-buffer.cpp:175
std::string s;
- {
-c = s.c_str();
- }
- consume(c); // no-warning
+ c = s.c_str(); //
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337229: [CFG] [analyzer] Allow elidable copies to have more
than one arguments. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
Author: dergachev
Date: Mon Jul 16 17:57:57 2018
New Revision: 337229
URL: http://llvm.org/viewvc/llvm-project?rev=337229&view=rev
Log:
[CFG] [analyzer] Allow elidable copies to have more than one arguments.
Copy-constructors and move-constructors may have default arguments. It is
incorrect to as
Quuxplusone added inline comments.
Comment at: include/vector:298
+__copy_construct_forward(_Alloc& __a, _Iter __begin1, _Iter __end1,
+ _Ptr& __begin2, _CopyViaMemcpy)
+{
vsapsai wrote:
> Why does this function use `_CopyViaMemcpy` and no
Quuxplusone updated this revision to Diff 155796.
Quuxplusone marked 4 inline comments as done.
Quuxplusone added a comment.
Address @vsapsai's review comments.
Repository:
rCXX libc++
https://reviews.llvm.org/D49317
Files:
include/memory
include/vector
test/libcxx/containers/sequences
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337228: [analyzer] pr37802: Fix symbolic-pointer-to-boolean
casts during load. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
Author: dergachev
Date: Mon Jul 16 17:42:35 2018
New Revision: 337228
URL: http://llvm.org/viewvc/llvm-project?rev=337228&view=rev
Log:
[analyzer] pr37802: Fix symbolic-pointer-to-boolean casts during load.
The canonical representation of pointer &SymRegion{$x} casted to boolean is
"$x != 0", not
dblaikie accepted this revision.
dblaikie added a comment.
Looks good, Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D49265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337227: [analyzer] Assert that nonloc::SymbolVal always
wraps a non-Loc-type symbol. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48205
Files:
include/clang
Author: dergachev
Date: Mon Jul 16 17:22:27 2018
New Revision: 337227
URL: http://llvm.org/viewvc/llvm-project?rev=337227&view=rev
Log:
[analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol.
In the current SVal hierarchy there are multiple ways of representing certain
values
vsapsai added a comment.
My review is incomplete, especially I cannot say with confidence if the
proposed change is entirely free from unintended consequences that might break
code not covered by the test suite. So other reviewers are welcome to chime in.
Comment at: include/
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good with one cleanup.
Comment at: lib/Frontend/CompilerInvocation.cpp:2177-2178
+ if (const Arg *A = Args.getLastArg(OPT_fdigraphs, OPT_fno_digraphs))
+Opts.Dig
kubamracek added a comment.
This looks great to me, but someone else should review this as well.
https://reviews.llvm.org/D15225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Hmm, the destructor-specific message was pretty good, can we keep it? It should
be possible to print a different message depending on the program point within
`N`.
https://reviews.llvm.org/D49360
___
cfe-commits mailing list
c
Author: rsmith
Date: Mon Jul 16 17:11:41 2018
New Revision: 337226
URL: http://llvm.org/viewvc/llvm-project?rev=337226&view=rev
Log:
Restructure checking for, and warning on, lifetime extension.
This change implements C++ DR1696, which makes initialization of a
reference member of a class from a
Quuxplusone updated this revision to Diff 155791.
Quuxplusone added a comment.
Implement similar cosmetic cleanup to https://reviews.llvm.org/D47111, but for
the pool resources this time.
I think the argument for keeping do_allocate and do_deallocate in the .cpp file
is stronger for these guys t
smeenai added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.getTriple().isWindowsMSVCEnv
george.karpenkov updated this revision to Diff 155785.
george.karpenkov edited the summary of this revision.
george.karpenkov edited reviewers, added: delcypher; removed: bob.wilson,
glider, t.p.northover, samsonov, beanz.
george.karpenkov added a comment.
Attempt #2: reduced version of this patc
lichray marked 2 inline comments as done.
lichray added inline comments.
Comment at: include/charconv:244
+static _LIBCPP_INLINE_VISIBILITY char const*
+read(char const* __p, char const* __ep, type& __a, type& __b)
+{
Quuxplusone wrote:
> mclow.lists
jtbandes added a comment.
Ping again 😇
Repository:
rC Clang
https://reviews.llvm.org/D48266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lichray updated this revision to Diff 155780.
lichray added a comment.
Uglify all the names
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
Files:
include/CMakeLists.txt
include/charconv
include/module.modulemap
src/charconv.cpp
test/libcxx/double_include.sh.cpp
test/std/
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D48786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D49235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
a_sidorin added inline comments.
Comment at: lib/AST/ASTImporter.cpp:6741
+
+ auto *Ctor = dyn_cast(Importer.Import(
+ E->getConstructor()));
balazske wrote:
> a_sidorin wrote:
> > cast_or_null?
> dyn_cast_or_null: Import may return nullptr, but if not, the
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Thank you Gabor!
Repository:
rC Clang
https://reviews.llvm.org/D49296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
simark updated this revision to Diff 155773.
simark added a comment.
Add tests for both == and !=.
I need to rebuild ~800 files (because I pulled llvm/clang), so I did not
actually test it, but I'll do so before pushing tomorrow, of course.
Repository:
rC Clang
https://reviews.llvm.org/D4926
rnkovacs added a comment.
In https://reviews.llvm.org/D49360#1163113, @NoQ wrote:
> Also we rarely commit to adding a test for every single supported API
> function; bonus points for that, but usually 2-3 functions from a series of
> similar functions is enough :)
Um, okay, noted for next tim
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
Thank you for this explanation, it sounds reasonable. Ithink it should be
placed into the commit message or into the comment somewhere.
Repository:
rC Clang
https://review
rnkovacs updated this revision to Diff 155770.
rnkovacs marked an inline comment as done.
rnkovacs edited the summary of this revision.
rnkovacs added a comment.
Added standard quote, marking the section about non-member functions that may
also invalidate the buffer as a TODO.
Also changed the no
NoQ added a comment.
Herald added a subscriber: mikhail.ramalho.
Just noticed: `getRuntimeDefinition()` has a lot of overrides in `CallEvent`
sub-classes, and there paths that don't defer to
`AnyFunctionCall::getRuntimeDefinition()`, eg., `
CXXInstanceCall::getRuntimeDefinition()` => `if (MD->i
simark added a comment.
In https://reviews.llvm.org/D49265#1164227, @dblaikie wrote:
> In theory you'd need separate tests for op== and op!= returning false
> (currently all the tests would pass if both implementations returned true in
> all cases), but not the biggest deal.
Good point, I'll
asmith added a reviewer: aleksandr.urakov.
asmith added a comment.
Adding Aleksandr
Repository:
rC Clang
https://reviews.llvm.org/D45124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
vsapsai added a comment.
Overall looks good to me. Maybe add a test when a protocol is declared for an
interface, not for a category. Something like
__attribute__((objc_root_class))
@interface C4
-(void) m0:(int*) p; // expected-warning {{parameter of overriding method
should be annotate
rupprecht added a comment.
Thanks Eli, I'll see how hard it is to remove those calls to logb/logbf (those
seem to be the only ones causing link errors) and revert this change if that's
possible.
Repository:
rC Clang
https://reviews.llvm.org/D49330
juliehockett added inline comments.
Comment at: clang-tools-extra/test/clang-doc/yaml-module.cpp:14
+// CHECK-A: ---
+// CHECK-A-NEXT: USR:
'{{[0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9
erichkeane created this revision.
erichkeane added reviewers: majnemer, rjmccall.
I discovered that function pointers inside a RecordType that had
its type-determination done in a function whose signature matched
said function pointer resulted in the function pointer type being
emitted empty. Thi
jyknight added a comment.
In https://reviews.llvm.org/D47894#1158811, @manojgupta wrote:
> @efriedma @jyknight Does the change match your expectations where warnings
> are still generated but codeGen does not emit nonnull attribute?
Yes, this seems sensible IMO.
Comment at:
Quuxplusone added inline comments.
Comment at: include/charconv:244
+static _LIBCPP_INLINE_VISIBILITY char const*
+read(char const* __p, char const* __ep, type& __a, type& __b)
+{
mclow.lists wrote:
> lichray wrote:
> > mclow.lists wrote:
> > > Same c
erichkeane added a comment.
Bump! Would love to have someone take a look!
https://reviews.llvm.org/D47474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
In theory you'd need separate tests for op== and op!= returning false
(currently all the tests would pass if both implementations returned true in
all cases), but not the biggest deal.
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337215: [analyzer] Make checkEndFunction() give access to
the return statement. (authored by rkovacs, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: rkovacs
Date: Mon Jul 16 13:47:45 2018
New Revision: 337215
URL: http://llvm.org/viewvc/llvm-project?rev=337215&view=rev
Log:
[analyzer] Make checkEndFunction() give access to the return statement.
Differential Revision: https://reviews.llvm.org/D49387
Modified:
cfe/trunk/include/cla
jkorous marked an inline comment as done.
jkorous added a comment.
Hi Sam, no worries! Thanks for making time to take a look! I am going to rebase
all my patches on top of JSON library moved to llvm/Support and process your
comments.
Comment at: clangd/xpc/CMakeLists.txt:1
+s
Author: george.karpenkov
Date: Mon Jul 16 13:42:37 2018
New Revision: 337214
URL: http://llvm.org/viewvc/llvm-project?rev=337214&view=rev
Log:
[ASTMatchers] Quickfix for tests.
Modified:
cfe/trunk/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Modified: cfe/trunk/unittests/ASTMatchers/AS
simark updated this revision to Diff 155753.
simark added a comment.
- Add test
- Make operator== a function instead of method
- Add operator!= (so I can use EXPECT_NE in the test, and because it may be
useful in general)
Repository:
rC Clang
https://reviews.llvm.org/D49265
Files:
include
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337213: [analyzer] Bugfix for an overly eager suppression
for null pointer return from… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
ht
Author: george.karpenkov
Date: Mon Jul 16 13:33:25 2018
New Revision: 337213
URL: http://llvm.org/viewvc/llvm-project?rev=337213&view=rev
Log:
[analyzer] Bugfix for an overly eager suppression for null pointer return from
macros.
Only suppress those cases where the null which came from the macro
Author: george.karpenkov
Date: Mon Jul 16 13:32:57 2018
New Revision: 337212
URL: http://llvm.org/viewvc/llvm-project?rev=337212&view=rev
Log:
[analyzer] Fix GCDAntipatternChecker to only fire when the semaphore is
initialized to zero
Initializing a semaphore with a different constant most likel
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337212: [analyzer] Fix GCDAntipatternChecker to only fire
when the semaphore is… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337211: [analyzer] Provide a symmetric method for generating
a PathDiagnosticLocation… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
htt
Author: george.karpenkov
Date: Mon Jul 16 13:32:32 2018
New Revision: 337211
URL: http://llvm.org/viewvc/llvm-project?rev=337211&view=rev
Log:
[analyzer] Provide a symmetric method for generating a PathDiagnosticLocation
from Decl
Differential Revision: https://reviews.llvm.org/D49166
Modified:
mclow.lists added inline comments.
Comment at: include/charconv:244
+static _LIBCPP_INLINE_VISIBILITY char const*
+read(char const* __p, char const* __ep, type& __a, type& __b)
+{
lichray wrote:
> mclow.lists wrote:
> > Same comment as above about `re
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337209: [ASTMatchers] Introduce Objective-C matchers
`hasReceiver` and… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.ll
Author: george.karpenkov
Date: Mon Jul 16 13:22:12 2018
New Revision: 337209
URL: http://llvm.org/viewvc/llvm-project?rev=337209&view=rev
Log:
[ASTMatchers] Introduce Objective-C matchers `hasReceiver` and
`isInstanceMessage` for ObjCMessageExpr
Differential Revision: https://reviews.llvm.org/D4
zturner added inline comments.
Comment at: lib/Driver/ToolChains/MSVC.cpp:467-468
if (Linker.equals_lower("link")) {
+if (!TC.FoundMSVCInstall())
+ C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found);
+
It looks like it's possible for this warnin
Author: abataev
Date: Mon Jul 16 13:05:25 2018
New Revision: 337207
URL: http://llvm.org/viewvc/llvm-project?rev=337207&view=rev
Log:
[OPENMP] Fix checks for declare target link entries.
If the declare target link entries are created but not used, the
compiler will produce an error message. Patch
Author: ericwf
Date: Mon Jul 16 13:01:59 2018
New Revision: 337205
URL: http://llvm.org/viewvc/llvm-project?rev=337205&view=rev
Log:
Fix PR38160 - init_priority attribute not supported by GCC on Apple.
This patch guards the use of __attribute__((init_priority(101)))
within memory_resource.cpp whe
thakis created this revision.
thakis added a reviewer: zturner.
Wmsvc-not-found was added in r297851 to help diagnose why link.exe can't be
executed. However, it's emitted even when using -fuse-ld=lld, and in cross
builds there's no way to get rid of the warning other than disabling it.
Instead
STL_MSFT added inline comments.
Comment at: test/std/containers/views/span.comparison/op.eq.pass.cpp:23
+#include
+#include
+
The comparison tests appear to be unnecessarily including ``.
Comment at: test/std/containers/views/span.cons/assign
efriedma added a comment.
Probably compiler-rt should be fixed so it doesn't need libm, rather than
fixing clang to add -lm. (All the functions it currently uses can be
implemented with simple bit manipulation.)
Repository:
rC Clang
https://reviews.llvm.org/D49330
__
thakis added a comment.
And finally (sorry about all the mails), this should probably be mentioned in
the release notes (docs/ReleaseNotes.rst in the clang repo) since it's a
notable new feature :-)
Repository:
rC Clang
https://reviews.llvm.org/D46652
aheejin updated this revision to Diff 155738.
aheejin added a comment.
- test fix
Repository:
rC Clang
https://reviews.llvm.org/D49396
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/CodeGen/builtins-wasm.c
===
thakis added a comment.
Also, were you planning on also adding support for the (filename-less version
of) hdrstop pragma? After this change, that should probably be fairly
straightforward.
Repository:
rC Clang
https://reviews.llvm.org/D46652
__
aheejin created this revision.
aheejin added a reviewer: dschuff.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100.
Add support for atomic.wait / atomic.wake builtins based on the Wasm
thread proposal.
Repository:
rC Clang
https://reviews.llvm.org/D49396
Files:
incl
thakis added a comment.
Sorry about missing this. Looks great, thanks for doing this. This was a pretty
big omission, glad to see it's done now :-)
I always imagined we might reuse the precompiled preamble stuff
(Lexer::ComputePreamble() etc), but it's pretty clear as-is.
Repository:
rC Cla
simark added a comment.
In https://reviews.llvm.org/D49265#1163740, @dblaikie wrote:
> Any chance this can/should be unit tested? (also, in general (though might
> not matter in this instance), symmetric operators like == should be
> implemented as non-members (though they can still be friends
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:501
- void _registerForBeginFunction(CheckEndFunctionFunc checkfn);
+ void _registerForBegin
sammccall added a comment.
Hi Jan,
Thanks for putting this together, and apologies - this is one of the places
where we don't have nice abstractions/layering, so adding XPC was harder than
it should be.
As I mentioned on the other review, I think maybe this patch isn't invasive
enough, we cou
sammccall created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
Ideas about abstracting JSON transport away to allow XPC and improve layering.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49389
Files:
clangd/ClangdLSPServer.c
jordan_rose added inline comments.
Comment at: test/Sema/conditional-expr.c:20
vp = 0 ? (double *)0 : (void *)0;
- ip = 0 ? (double *)0 : (void *)0; // expected-warning {{incompatible pointer
types assigning to 'int *' from 'double *'}}
+ ip = 0 ? (double *)0 : (void *)0; /
[ Moving discussion from https://reviews.llvm.org/D49386 to the relevant
comment on cfe-commits, CC'ing Hal who commented on the original issue ]
Is this change really a good idea? It always requires libatomic for all
OpenMP applications, even if there is no 'omp atomic' directive or all
of th
ahatanak added inline comments.
Comment at: test/Sema/conditional-expr.c:20
vp = 0 ? (double *)0 : (void *)0;
- ip = 0 ? (double *)0 : (void *)0; // expected-warning {{incompatible pointer
types assigning to 'int *' from 'double *'}}
+ ip = 0 ? (double *)0 : (void *)0; // e
Author: abataev
Date: Mon Jul 16 11:12:18 2018
New Revision: 337196
URL: http://llvm.org/viewvc/llvm-project?rev=337196&view=rev
Log:
[OPENMP] Fix syntactic errors in error messages.
Fixed spelling of the offloading error messages.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/
IdrissRio updated this revision to Diff 155715.
IdrissRio added a comment.
Fixed the formatting error with clang-format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49356
Files:
clang-tidy/modernize/UseEqualsDefaultCheck.cpp
test/clang-tidy/modernize-use-equals-default-co
mgrang added a comment.
Ping 2 for reviews please.
https://reviews.llvm.org/D48862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
Repository:
rC Clang
https://reviews.llvm.org/D49387
Files:
include/clang/StaticAnalyzer/Core/Che
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:674
+ const LocationContext *LC = Context.getLocationContext();
+ while ((LC = LC->getParent())) {
+
Szelethus wrote:
> NoQ wrote:
> > george.karpenkov wrote
mclow.lists added inline comments.
Comment at: include/charconv:372
+
+auto __len = __last - __p;
+if (__value != 0 || !__len)
mclow.lists wrote:
> Are you missing an edge case here? What happens if `__last == __first &&
> __value == 0`?
>
Nevermind. Ap
rnkovacs added a comment.
In https://reviews.llvm.org/D49058#1159533, @george.karpenkov wrote:
> @rnkovacs Do you have evaluation statistics handy for this checker? How many
> bugs it finds, on which projects? How many of those are real bugs?
In its present form, it does not produce many repor
Author: abataev
Date: Mon Jul 16 09:49:20 2018
New Revision: 337191
URL: http://llvm.org/viewvc/llvm-project?rev=337191&view=rev
Log:
[OPENMP, NVPTX] Globalize only captured variables.
Sometimes we can try to globalize non-variable declarations, which may
lead to compiler crash.
Modified:
cf
Any chance this can/should be unit tested? (also, in general (though might
not matter in this instance), symmetric operators like == should be
implemented as non-members (though they can still be friends and if they
are, can be defined inline in the class definition as a member could be),
so any im
dblaikie added a comment.
Any chance this can/should be unit tested? (also, in general (though might
not matter in this instance), symmetric operators like == should be
implemented as non-members (though they can still be friends and if they
are, can be defined inline in the class definition as a
lichray added inline comments.
Comment at: include/charconv:244
+static _LIBCPP_INLINE_VISIBILITY char const*
+read(char const* __p, char const* __ep, type& __a, type& __b)
+{
mclow.lists wrote:
> Same comment as above about `read` and `inner_product`
mclow.lists added inline comments.
Comment at: include/charconv:359
+auto __gen_digit = [](_Tp __c) {
+return "0123456789abcdefghijklmnopqrstuvwxyz"[__c];
+};
Thinking some more - did this used to do more? Because I don't see why having a
lambda
mclow.lists added inline comments.
Comment at: include/charconv:244
+static _LIBCPP_INLINE_VISIBILITY char const*
+read(char const* __p, char const* __ep, type& __a, type& __b)
+{
Same comment as above about `read` and `inner_product` - they need to b
ldionne added a subscriber: mclow.lists.
ldionne added inline comments.
Comment at: include/type_traits:595
-template
-struct __and_<_B0, _B1> : conditional<_B0::value, _B1, _B0>::type {};
-
It is not impossible that this was a compile-time optimization for the
mclow.lists added inline comments.
Comment at: include/charconv:372
+
+auto __len = __last - __p;
+if (__value != 0 || !__len)
Are you missing an edge case here? What happens if `__last == __first &&
__value == 0`?
Comment at: test/su
mclow.lists added a comment.
Need to add an entry to `include/CMakeLists.txt` as well.
https://reviews.llvm.org/D49338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tejohnson
Date: Mon Jul 16 08:30:36 2018
New Revision: 337185
URL: http://llvm.org/viewvc/llvm-project?rev=337185&view=rev
Log:
Restore "[ThinLTO] Ensure we always select the same function copy to import"
This reverts commit r337082, restoring r337051, since the LLVM side
patch has been r
martong updated this revision to Diff 155678.
martong added a comment.
RecordDecl* -> RecordDecl *
Repository:
rC Clang
https://reviews.llvm.org/D49296
Files:
lib/AST/ASTStructuralEquivalence.cpp
unittests/AST/ASTImporterTest.cpp
unittests/AST/StructuralEquivalenceTest.cpp
Index: unit
kosarev created this revision.
kosarev added reviewers: SjoerdMeijer, jgreenhalgh, rengolin.
kosarev added a project: clang.
Herald added a reviewer: javed.absar.
https://reviews.llvm.org/D49376
Files:
include/clang/Basic/arm_neon.td
test/Sema/arm-no-fp16.c
Index: test/Sema/arm-no-fp16.c
==
kosarev created this revision.
kosarev added reviewers: SjoerdMeijer, jgreenhalgh, rengolin.
kosarev added a project: clang.
Herald added a reviewer: javed.absar.
https://reviews.llvm.org/D49375
Files:
include/clang/Basic/arm_neon.td
test/Sema/arm-no-fp16.c
Index: test/Sema/arm-no-fp16.c
==
Author: balazske
Date: Mon Jul 16 07:05:18 2018
New Revision: 337172
URL: http://llvm.org/viewvc/llvm-project?rev=337172&view=rev
Log:
[ASTImporter] Changed constant int to unsigned int in test code.
Modified:
cfe/trunk/unittests/AST/ASTImporterTest.cpp
Modified: cfe/trunk/unittests/AST/ASTI
1 - 100 of 125 matches
Mail list logo
