[PATCH] D49296: [ASTImporter] Fix import of unnamed structs

a_sidorin added a comment. Hi Gabor, The change is OK but I have some questions regarding tests. Comment at: unittests/AST/ASTImporterTest.cpp:2495 + FirstDeclMatcher().match(ToTU, fieldDecl(hasName("entry1"))); + auto getRecordDecl = [](FieldDecl *FD) { +auto *ET = c

[PATCH] D49300: [ASTImporter] Fix poisonous structural equivalence cache

a_sidorin added a comment. Hi Gabor, Could you provide some tests for the issue? Repository: rC Clang https://reviews.llvm.org/D49300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D49293: [ASTImporter] Add support for import of CXXInheritedCtorInitExpr.

a_sidorin added a comment. Adding new nodes is always welcome. Comment at: lib/AST/ASTImporter.cpp:6741 + + auto *Ctor = dyn_cast(Importer.Import( + E->getConstructor())); cast_or_null? Repository: rC Clang https://reviews.llvm.org/D49293

[PATCH] D49245: [ASTImporter] Import implicit methods of existing class.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM. Just some stylish nits. To resolve this issue, I used `Sema::DeclareImplicit...` methods. But I like this approach much more because it doesn't allows to forget different kinds of

[PATCH] D49235: [ASTImporter] Import described template (if any) of function.

a_sidorin added a comment. Hello Balasz, This looks mostly good but I have a question inline. Comment at: lib/AST/ASTImporter.cpp:2715 +if (auto *ToFT = dyn_cast(Importer.Import(FromFT))) + ToFunction->setDescribedFunctionTemplate(ToFT); +else The

[PATCH] D49345: [CMake] Use correct variable as header install prefix

This revision was automatically updated to reflect the committed changes. Closed by commit rL337118: [CMake] Use correct variable as header install prefix (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49345?vs=15

[libcxx] r337118 - [CMake] Use correct variable as header install prefix

Author: phosek Date: Sat Jul 14 21:09:35 2018 New Revision: 337118 URL: http://llvm.org/viewvc/llvm-project?rev=337118&view=rev Log: [CMake] Use correct variable as header install prefix This variable is already set in CMakeLists.txt but it wasn't used which means that the headers get installed i

[PATCH] D49345: [CMake] Use correct variable as header install prefix

phosek added a comment. Thank you! Repository: rCXX libc++ https://reviews.llvm.org/D49345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49345: [CMake] Use correct variable as header install prefix

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Seems like an obvious enough fix, so I'm jumping in to LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D49345 ___ cfe-commits mailing

[PATCH] D48287: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn

yaxunl updated this revision to Diff 155580. yaxunl added a comment. Replace LangOpts.CUDADeviceFlushDenormalsToZero with CodeGenOpts.FlushDenorm. https://reviews.llvm.org/D48287 Files: include/clang/Basic/LangOptions.def lib/CodeGen/CGCall.cpp lib/CodeGen/CodeGenModule.cpp lib/Frontend

[PATCH] D49345: [CMake] Use correct variable as header install prefix

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, beanz. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. This variable is already set in CMakeLists.txt but it wasn't used which means that the headers get installed into a wrong location when the per target

r337117 - [CMake] Use libc++ and compiler-rt for sanitizers

Author: phosek Date: Sat Jul 14 20:11:43 2018 New Revision: 337117 URL: http://llvm.org/viewvc/llvm-project?rev=337117&view=rev Log: [CMake] Use libc++ and compiler-rt for sanitizers When building runtimes for Linux as part of Fuchsia toolchain, use libc++ and compiler-rt for sanitizers. Differe

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

MaskRay added a comment. Herald added a subscriber: ldionne. Ping :) Repository: rCXX libc++ https://reviews.llvm.org/D45805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt

bricci updated this revision to Diff 155564. bricci added a comment. wrong diff Repository: rC Clang https://reviews.llvm.org/D48873 Files: include/clang/AST/StmtCXX.h lib/AST/StmtCXX.cpp Index: lib/AST/StmtCXX.cpp === ---

[PATCH] D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt

bricci updated this revision to Diff 155563. bricci retitled this revision from "[AST] Use llvm::TrailingObjects in clang::CXXTryStmt" to "[AST] Use llvm::TrailingObjects in CXXTryStmt". bricci edited the summary of this revision. bricci added reviewers: arphaman, bkramer. bricci added a comment.

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. In https://reviews.llvm.org/D45444#1162715, @JonasToth wrote: > Time :/ Is this available as a public Git branch somewhere, or is downloading the diff the preferred way to interact with this code? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45

[PATCH] D48981: Add caching when looking up coroutine_traits

This revision was automatically updated to reflect the committed changes. Closed by commit rL337103: Add caching when looking up coroutine_traits (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48981 Files: cfe/t

r337103 - Add caching when looking up coroutine_traits

Author: modocache Date: Sat Jul 14 11:21:44 2018 New Revision: 337103 URL: http://llvm.org/viewvc/llvm-project?rev=337103&view=rev Log: Add caching when looking up coroutine_traits Summary: Currently clang looks up the coroutine_traits ClassTemplateDecl everytime it looks up the promise type. Thi

[PATCH] D48981: Add caching when looking up coroutine_traits

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Yup, LGTM! I'll land this now. Repository: rC Clang https://reviews.llvm.org/D48981 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D37057: [clang] Require address space to be specified when creating functions (3/3)

dylanmckay abandoned this revision. dylanmckay added a comment. Superseded by https://reviews.llvm.org/D47541 Repository: rC Clang https://reviews.llvm.org/D37057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Time :/ Am 14.07.2018 um 16:34 schrieb Roman Lebedev via Phabricator: > lebedev.ri added a comment. > > Ping, i guess :) > Anything needed to get this going? > > Repository: > > rCTE Clang Tools Extra > > https://reviews.llvm.org/D45444 Repository: rCTE Clan

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

lebedev.ri added a comment. Ping, i guess :) Anything needed to get this going? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[clang-tools-extra] r337091 - [clang-tidy] Force exceptions to be enabled in test

Author: d0k Date: Sat Jul 14 03:48:06 2018 New Revision: 337091 URL: http://llvm.org/viewvc/llvm-project?rev=337091&view=rev Log: [clang-tidy] Force exceptions to be enabled in test For targets that have them off by default. Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-exceptio

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

mcgrathr added a comment. Is this still live? Should it be different after all the multiarch stuff? Repository: rC Clang https://reviews.llvm.org/D42019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman