jolesiak added a comment.
Herald added a subscriber: acoomans.
I think we should reconsider applying this change, at least for a very common
"#import ".
Repository:
rC Clang
https://reviews.llvm.org/D44634
___
cfe-commits mailing list
cfe-commit
jolesiak closed this revision.
jolesiak added a comment.
This change was submitted (for some reason (probably some rebase operations) it
was not automatically connected to the commit):
https://reviews.llvm.org/rC336521, https://reviews.llvm.org/rL336521.
Repository:
rC Clang
https://reviews.
jolesiak closed this revision.
jolesiak added a comment.
This change was submitted (for some reason (probably some rebase operations) it
was not automatically connected to the commit):
https://reviews.llvm.org/rC336520, https://reviews.llvm.org/rL336520
Repository:
rC Clang
https://reviews.l
smeenai added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.getTriple().isWindowsMSVCEnv
0x8000- updated this revision to Diff 154921.
0x8000- added a comment.
Herald added a subscriber: mgrang.
Incorporate review comments. Add support for floating point detection.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/readability/CMakeLis
Author: george.karpenkov
Date: Tue Jul 10 19:01:18 2018
New Revision: 336756
URL: http://llvm.org/viewvc/llvm-project?rev=336756&view=rev
Log:
[analyzer] Fix bots by changing the analyzer-config tests.
To be investigated.
Modified:
cfe/trunk/test/Analysis/analyzer-config.c
cfe/trunk/test
Author: george.karpenkov
Date: Tue Jul 10 18:58:08 2018
New Revision: 336755
URL: http://llvm.org/viewvc/llvm-project?rev=336755&view=rev
Log:
[analyzer] Partial revert of https://reviews.llvm.org/D49050
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp
Modified: cfe
0x8000- marked 7 inline comments as done.
0x8000- added inline comments.
Comment at: docs/clang-tidy/checks/readability-magic-numbers.rst:11
+
+ double circleArea = 3.1415926535 * radius * radius;
+
Eugene.Zelenko wrote:
> JonasToth wrote:
> > This exam
Author: george.karpenkov
Date: Tue Jul 10 18:23:27 2018
New Revision: 336753
URL: http://llvm.org/viewvc/llvm-project?rev=336753&view=rev
Log:
[analyzer] Pass through all arguments from the registerChecker() to the checker
constructor
A lot of checkers could be cleaned up in a similar way
Diffe
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336753: [analyzer] Pass through all arguments from the
registerChecker() to the checker… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
http
Author: modocache
Date: Tue Jul 10 18:00:53 2018
New Revision: 336750
URL: http://llvm.org/viewvc/llvm-project?rev=336750&view=rev
Log:
[SemaCXX] Remove comment from coroutines test, NFC
Summary:
The file name was accidentally included when the test file was added.
Test Plan: check-clang
Modif
EricWF added a reviewer: ldionne.
EricWF added a subscriber: ldionne.
EricWF added a comment.
Adding @ldionne as an observer, since he's knee-deep in the visibility mess
right now.
After re-evaluating, I think I was being overly cautious the last time I looked
at this. I think this patch should
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:11103
+ if (const auto *DeclRef = dyn_cast(LHSExpr))
+checkNullConstantToNonNull(DeclRef->getType(), RHS.get());
jordan_rose wrote:
> This could come later, but what about struct members or
vsapsai updated this revision to Diff 154912.
vsapsai added a comment.
- In C++03 call allocator's `destroy` when available.
- Rename `_Args` as it's not a variadic template pack.
https://reviews.llvm.org/D48753
Files:
libcxx/include/memory
libcxx/test/std/containers/sequences/vector/vecto
ahatanak updated this revision to Diff 154908.
ahatanak marked 3 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D22391
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
in
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336748: Remove qualtype qualifier in coroutine error to
prevent assert in debug (authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49099?vs=154692&id=154910#toc
Author: modocache
Date: Tue Jul 10 17:45:48 2018
New Revision: 336748
URL: http://llvm.org/viewvc/llvm-project?rev=336748&view=rev
Log:
Remove qualtype qualifier in coroutine error to prevent assert in debug
Summary:
A forward-declared coroutine_traits should trip an error; we need
a complete typ
Author: rsmith
Date: Tue Jul 10 17:34:54 2018
New Revision: 336747
URL: http://llvm.org/viewvc/llvm-project?rev=336747&view=rev
Log:
[docs] List correct default for -ftemplate-depth; also add missing
documentation for -fconstexpr-steps.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/
NoQ added inline comments.
Comment at: lib/Analysis/ConstructionContext.cpp:186
+isa(TopLayer->getTriggerStmt())) {
+ return create(
+ C, cast(TopLayer->getTriggerStmt()), TopLayer->getIndex(),
Should assert that we only have one layer.
Re
Author: rsmith
Date: Tue Jul 10 17:29:05 2018
New Revision: 336746
URL: http://llvm.org/viewvc/llvm-project?rev=336746&view=rev
Log:
PR38095: Allow constant-folding of loads through bitcasted pointers if
the bitcast only changed cvr-qualifications within the pointer type.
Modified:
cfe/trunk/
Author: rsmith
Date: Tue Jul 10 17:19:19 2018
New Revision: 336745
URL: http://llvm.org/viewvc/llvm-project?rev=336745&view=rev
Log:
DR330: look through array types when forming the cv-decomposition of a type.
This allows more qualification conversions, eg. conversion from
'int *(*)[]' -> 'con
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:318
- Value *EmitScalarConversion(Value *Src, QualType SrcTy, QualType DstTy,
+ Value *EmitScalarConversion(Value *Src, QualType SrcType, QualType DstType,
SourceLocation
vsk added a comment.
Thanks for working on this!
Comment at: docs/ReleaseNotes.rst:277
+ behaviour. But they are not *always* intentional, and are somewhat hard to
+ track down.
Could you mention whether the group is enabled by -fsanitize=undefined?
=
lebedev.ri updated this revision to Diff 154877.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
@vsk thank you for taking a look!
Addressed the trivial part of nits.
Repository:
rC Clang
https://reviews.llvm.org/D48958
Files:
docs/ReleaseNotes.rst
docs/Undefine
alexshap added a comment.
I'm kind of interested in this fixit, but one thought which i have - probably
it should be more conservative (i.e. fix captures by reference, integral types,
etc) (since the code might rely on side-effects of copy-ctors/move-ctors or
extend the lifetime of an object),
Author: ctopper
Date: Tue Jul 10 16:28:05 2018
New Revision: 336740
URL: http://llvm.org/viewvc/llvm-project?rev=336740&view=rev
Log:
[X86] Also fix the test for _mm512_mullo_epi64 to test the intrinsic instead of
a copy of the intrinsic implementation.
This had the same issue I just fixed in r3
0x8000- added inline comments.
Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:42
+
+const auto &Parents = Result.Context->getParents(*MatchedDecl);
+for (const auto &Parent : Parents) {
Eugene.Zelenko wrote:
> Please don't use auto where typ
Author: ctopper
Date: Tue Jul 10 16:13:01 2018
New Revision: 336739
URL: http://llvm.org/viewvc/llvm-project?rev=336739&view=rev
Log:
[X86] Fix the test for _mm512_mullox_epi64 to test the intrinsic instead of a
copy of the intrinsic implementation.
Modified:
cfe/trunk/test/CodeGen/avx512f-b
Author: rsmith
Date: Tue Jul 10 16:04:35 2018
New Revision: 336738
URL: http://llvm.org/viewvc/llvm-project?rev=336738&view=rev
Log:
Fix determination of whether a reinterpret_cast casts away constness.
The "casts away constness" check doesn't care at all how the different
layers of the source an
This revision was automatically updated to reflect the committed changes.
shuaiwang marked an inline comment as done.
Closed by commit rL336737: Use ExprMutationAnalyzer in
performance-for-range-copy (authored by shuaiwang, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL
Author: shuaiwang
Date: Tue Jul 10 15:51:06 2018
New Revision: 336737
URL: http://llvm.org/viewvc/llvm-project?rev=336737&view=rev
Log:
Use ExprMutationAnalyzer in performance-for-range-copy
Summary:
This gives better coverage to the check as ExprMutationAnalyzer is more
accurate comparing to isO
vsapsai added a comment.
In https://reviews.llvm.org/D48753#1157907, @Quuxplusone wrote:
> In https://reviews.llvm.org/D48753#1157695, @EricWF wrote:
>
> > Why are we doing this?
> >
> > I can't find the language in the C++03 specification that requires us to
> > call an allocators `construct` m
manojgupta updated this revision to Diff 154895.
manojgupta added a comment.
Do not generate calls with "nonnull" attribute with
"-fno-delete-null-pointer-checks".
The warnings are still generated when nullptr is passed to a function with
nonnull
attribute.
Repository:
rC Clang
https://revi
yaxunl updated this revision to Diff 154894.
yaxunl marked an inline comment as done.
yaxunl added a comment.
clean up function prefix.
https://reviews.llvm.org/D49083
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/device-stub.cu
===
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov.
juliehockett added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
Bug 36150 found a segfault on mac when a CXXRecordDecl has no IdentifierInfo,
this fixes it.
https://rev
rsmith accepted this revision.
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:4000-4004
+ ExpressionEvaluationContextRecord::ExpressionKind Type =
ExpressionEvaluationContextRecord::EK_Other);
enum ReuseLambdaContextDecl_t { ReuseLambdaContextDecl };
rsmith added a comment.
Thanks!
Comment at: lib/Parse/ParseExprCXX.cpp:2956
+const Token Next = GetLookAheadToken(2);
+const auto GetAfter = [this] { return GetLookAheadToken(3); };
+
I don't think this lambda is useful: since you're not caching the res
Rakete updated this revision to Diff 154882.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D36357
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseExprCXX.cpp
test/Parser/cxx0x-lambda-expressions.cpp
test/SemaCXX/new-delete-0x.cpp
shuaiwang marked an inline comment as done.
shuaiwang added inline comments.
Comment at: test/clang-tidy/performance-for-range-copy.cpp:120
+struct Point {
+ ~Point() {}
JonasToth wrote:
> I feel that `const` methods should be added as a test as well.
const me
kjcamann added a comment.
I have recently benchmarked this (platform was RHEL 7 and Haswell), and the
libc++ version has about twice the latency of a pthread_rwlock for both classes
of locking. libc++ is also about twice the latency of the libstdc++
implementation, because it is just a lightwei
Rakete updated this revision to Diff 154880.
Rakete added a comment.
Rebased + friendly ping
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.cpp
Author: erichkeane
Date: Tue Jul 10 14:07:50 2018
New Revision: 336729
URL: http://llvm.org/viewvc/llvm-project?rev=336729&view=rev
Log:
[NFC] Switch CodeGenFunction to use value init instead of member init lists
The member init list for the sole constructor for CodeGenFunction
has gotten out of
Eugene.Zelenko added a comment.
It's highly likely that this part of coding guidelines.
Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:42
+
+const auto &Parents = Result.Context->getParents(*MatchedDecl);
+for (const auto &Parent : Parents) {
Quuxplusone added a comment.
In https://reviews.llvm.org/D48753#1157695, @EricWF wrote:
> Why are we doing this?
>
> I can't find the language in the C++03 specification that requires us to call
> an allocators `construct` method if it's present.
I think it's being proposed under "quality of i
Rakete updated this revision to Diff 154875.
Rakete added a comment.
Rebased + friendly ping :)
https://reviews.llvm.org/D39679
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/references.cpp
Index: test/SemaCXX/references.cpp
==
Sorry everyone, I didn't police my subversion directory correctly. I noticed
when I got the email that the 'commit' list was too large! Reverted in 336727.
-Original Message-
From: Erich Keane via cfe-commits [mailto:cfe-commits@lists.llvm.org]
Sent: Tuesday, July 10, 2018 1:47 PM
To:
Author: erichkeane
Date: Tue Jul 10 13:51:41 2018
New Revision: 336727
URL: http://llvm.org/viewvc/llvm-project?rev=336727&view=rev
Log:
Revert -r336726, which included more files than intended.
Modified:
cfe/trunk/include/clang/AST/ASTContext.h
cfe/trunk/include/clang/AST/RecursiveASTVis
vsapsai added a comment.
In https://reviews.llvm.org/D48753#1157695, @EricWF wrote:
> Why are we doing this?
>
> I can't find the language in the C++03 specification that requires us to call
> an allocators `construct` method if it's present.
The main reason I've ended up doing this because I
Author: erichkeane
Date: Tue Jul 10 13:46:46 2018
New Revision: 336726
URL: http://llvm.org/viewvc/llvm-project?rev=336726&view=rev
Log:
[NFC] Switch CodeGenFunction to use value init instead of member init lists
The member init list for the sole constructor for CodeGenFunction
has gotten out of
simark added a comment.
Herald added a subscriber: omtcyfz.
I took a look at `SymbolCollector`'s `toURI`, and I am not sure what to get
from it. It seems like a lot of it could be replaced with a call to
`FileSystem::getRealPath`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/
lebedev.ri updated this revision to Diff 154863.
lebedev.ri added a comment.
- Check that sanitizer is actually enabled before doing the AST upwalk. I
didn't measure, but it would be logical for this to be better.
Repository:
rC Clang
https://reviews.llvm.org/D48958
Files:
docs/ReleaseNot
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336717: Patch to fix pragma metadata for do-while loops
(authored by bjope, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48721?vs=154244&id
Author: bjope
Date: Tue Jul 10 12:55:02 2018
New Revision: 336717
URL: http://llvm.org/viewvc/llvm-project?rev=336717&view=rev
Log:
Patch to fix pragma metadata for do-while loops
Summary:
Make sure that loop metadata only is put on the backedge
when expanding a do-while loop.
Previously we added
Author: eugenis
Date: Tue Jul 10 12:49:07 2018
New Revision: 336716
URL: http://llvm.org/viewvc/llvm-project?rev=336716&view=rev
Log:
Revert r336590 "[libclang] evalute compound statement cursors before trying to
evaluate"
New memory leaks in
LibclangParseTest_EvaluateChildExpression_Test::TestB
Author: eugenis
Date: Tue Jul 10 12:48:53 2018
New Revision: 336715
URL: http://llvm.org/viewvc/llvm-project?rev=336715&view=rev
Log:
Revert r336591 "[libclang] NFC, simplify clang_Cursor_Evaluate"
This change is blocking r336590 which is being reverted due to memory leaks.
Modified:
cfe/tru
Reverting...
On Mon, Jul 9, 2018 at 8:18 PM, Vlad Tsyrklevich wrote:
> The ASan bot is failing with a LeakSanitizer failure that appears related to
> one of your libclang changes:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/6282/steps/check-clang%20asan/logs/stdio
bjope added a comment.
In https://reviews.llvm.org/D48721#1157571, @deepak2427 wrote:
> @Bjorn, Thanks for reviewing and accepting the patch.
>
> Could you please advise on the next steps?
> Would someone else commit this on my behalf or should I request for commit
> access?
>
> Thanks,
> Deep
Author: phosek
Date: Tue Jul 10 12:13:33 2018
New Revision: 336713
URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev
Log:
[CMake] Set per-runtime library directory suffix in runtimes build
Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal
variable used by the runtime
Author: phosek
Date: Tue Jul 10 12:13:33 2018
New Revision: 336713
URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev
Log:
[CMake] Set per-runtime library directory suffix in runtimes build
Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal
variable used by the runtime
Author: phosek
Date: Tue Jul 10 12:13:33 2018
New Revision: 336713
URL: http://llvm.org/viewvc/llvm-project?rev=336713&view=rev
Log:
[CMake] Set per-runtime library directory suffix in runtimes build
Do not use LLVM_RUNTIMES_LIBDIR_SUFFIX variable which is an internal
variable used by the runtime
ABataev created this revision.
ABataev added a reviewer: echristo.
Herald added subscribers: JDevlieghere, aprantl.
Some targets support only default set of the debug options and do not
support additional debug options, like NVPTX target. Patch introduced
virtual function supportsNonDefaultDebugOp
NoQ edited subscribers, added: NoQ; removed: dergachev.a.
NoQ added inline comments.
Comment at: test/Analysis/nullability_nullonly.mm:103
void testObjCARCExplicitZeroInitialization() {
- TestObject * _Nonnull explicitlyZeroInitialized = nil; // expected-warning
{{nil assigned
NoQ accepted this revision.
NoQ added a comment.
Looks great, thanks!
https://reviews.llvm.org/D49057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Why are we doing this?
I can't find the language in the C++03 specification that requires us to call
an allocators `construct` method if it's present.
https://reviews.llvm.org/D48753
___
cfe-commits mailing list
cfe-commits
CaseyCarter added a comment.
In https://reviews.llvm.org/D49118#1157438, @mclow.lists wrote:
> > I've conservatively hidden everything behind _LIBCPP_STD_VER > 17,
> > although it could be made available in C++11 mode with some edits.
>
> If we have a use for this in pre c++2a code, the libc++
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336710: Fix a typo/regression in r335495. (authored by jhb,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49143?vs=154840&id=154845#toc
Repository:
rC Clang
https://reviews.llvm
Author: jhb
Date: Tue Jul 10 10:44:08 2018
New Revision: 336710
URL: http://llvm.org/viewvc/llvm-project?rev=336710&view=rev
Log:
Fix a typo/regression in r335495.
Use getTriple.isMIPS64() to detect 64-bit MIPS ABIs in
FreeBSD::getSupportedSanitizers() instead of getTriple.isMIPS32().
Reviewed B
Author: ldionne
Date: Tue Jul 10 10:38:30 2018
New Revision: 336709
URL: http://llvm.org/viewvc/llvm-project?rev=336709&view=rev
Log:
[libc++] Declare noop_coroutine() with _LIBCPP_INLINE_VISIBILITY
Summary:
It was defined with the right visibility, but declared without any visibility.
This funct
lichray marked an inline comment as done.
lichray added inline comments.
Comment at: include/charconv:89
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+enum class _LIBCPP_ENUM_VIS chars_format
lichray wrote:
> mclow.lists wrote:
> > Quuxplusone wrote:
> > > lichray wrote:
> > >
lichray updated this revision to Diff 154842.
lichray added a comment.
Dropping C++11 support.
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
Files:
include/CMakeLists.txt
include/charconv
include/module.modulemap
src/charconv.cpp
test/libcxx/double_include.sh.cpp
test/s
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D49143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
bsdjhb updated this revision to Diff 154840.
bsdjhb added a comment.
Add tests.
Repository:
rC Clang
https://reviews.llvm.org/D49143
Files:
lib/Driver/ToolChains/FreeBSD.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
=
simark updated this revision to Diff 154835.
simark added a comment.
Bump SmallString size from 32 to 256
Repository:
rC Clang
https://reviews.llvm.org/D48903
Files:
lib/Basic/FileManager.cpp
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
unittests/Driver/T
EricWF added a comment.
I'm working on this! I'll be taking what is hopefully a final pass at the tests
today.
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
jordan_rose added a subscriber: dergachev.a.
jordan_rose added a comment.
Sorry for the delay. I think this is mostly good, but I do still have a concern
about the diagnostics change.
Comment at: lib/Sema/SemaExpr.cpp:7117
+if (E && S.checkNonNullExpr(E))
+ return Nul
simark marked an inline comment as done.
simark added a comment.
In https://reviews.llvm.org/D48903#1157330, @ilya-biryukov wrote:
> LGTM if that does not introduce any regressions in clang and clang-tools.
Thanks. I have seen no failures in `check-clang` and `check-clang-tools`, so I
will pu
erik.pilkington added a reviewer: ldionne.
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:662
+def note_suspicious_sizeof_memset_silence : Note<
+ "%select{parenthesize the third argument|cast the second argument to 'int'}0
to silence">;
+
Quuxplusone
erik.pilkington updated this revision to Diff 154833.
erik.pilkington added a comment.
Address @Quuxplusone comments.
https://reviews.llvm.org/D49112
Files:
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaChecking.cpp
cla
yaxunl added a comment.
In https://reviews.llvm.org/D49083#1157568, @tra wrote:
> > HIP generates one fat binary for all devices after linking. However, for
> > each compilation
> > unit a ctor function is emitted which register the same fat binary.
> > Measures need to be taken to make sure
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
deepak2427 marked an inline comment as done.
deepak2427 added a comment.
@Bjorn, Thanks for reviewing and accepting the patch.
Could you please advise on the next steps?
Would someone else commit this on my behalf or should I request for commit
access?
Thanks,
Deepak Panickal
https://reviews.
tra added a comment.
> HIP generates one fat binary for all devices after linking. However, for each
> compilation
> unit a ctor function is emitted which register the same fat binary.
> Measures need to be taken to make sure the fat binary is only registered
> once.
Are you saying that for
bsdjhb added a comment.
AFAICT, I don't see a way to ask clang "which sanitizers are supported by this
target". Hmm, the CHECK-SANL-MIPS test in tests/Driver/fsanitize.c seems like
the closest match.
Repository:
rC Clang
https://reviews.llvm.org/D49143
__
mgrang added a comment.
Ping for reviews, please.
https://reviews.llvm.org/D48862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D48721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
atanasyan added a comment.
It would be nice to have a test for this regression.
Repository:
rC Clang
https://reviews.llvm.org/D49143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
bsdjhb created this revision.
bsdjhb added a reviewer: arichardson.
Herald added subscribers: atanasyan, krytarowski, sdardis, emaste.
Use getTriple.isMIPS64() to detect 64-bit MIPS ABIs in
FreeBSD::getSupportedSanitizers() instead of getTriple.isMIPS32().
Repository:
rC Clang
https://reviews
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric, mgorny.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49142
Files:
clangd/CMakeLists.txt
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clan
lichray marked an inline comment as done.
lichray added inline comments.
Comment at: include/charconv:234
+to_chars(char* __first, char* __last, _Tp __value, int __base)
+-> to_chars_result
+{
mclow.lists wrote:
> lichray wrote:
> > mclow.lists wrote:
> > > W
mclow.lists added a comment.
> I've conservatively hidden everything behind _LIBCPP_STD_VER > 17, although
> it could be made available in C++11 mode with some edits.
If we have a use for this in pre c++2a code, the libc++ convention would be to
implement `__common_reference` that works most
lichray updated this revision to Diff 154816.
lichray added a comment.
Less trailing return types
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
Files:
include/CMakeLists.txt
include/charconv
include/module.modulemap
src/charconv.cpp
test/libcxx/double_include.sh.cpp
tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336685: Support -fdebug-prefix-map for assembler source
(pass to cc1as). This (authored by probinson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48989?vs=154669&id=154811#toc
R
Author: probinson
Date: Tue Jul 10 08:15:24 2018
New Revision: 336685
URL: http://llvm.org/viewvc/llvm-project?rev=336685&view=rev
Log:
Support -fdebug-prefix-map for assembler source (pass to cc1as). This
is useful to omit the debug compilation dir when compiling assembly
files with -g. Part of
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: arsenm
Date: Tue Jul 10 07:47:31 2018
New Revision: 336681
URL: http://llvm.org/viewvc/llvm-project?rev=336681&view=rev
Log:
AMDGPU: Try to fix test again
Modified:
cfe/trunk/test/CodeGen/backend-unsupported-error.ll
Modified: cfe/trunk/test/CodeGen/backend-unsupported-error.ll
URL:
lichray marked 3 inline comments as done.
lichray added inline comments.
Comment at: include/charconv:89
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+enum class _LIBCPP_ENUM_VIS chars_format
mclow.lists wrote:
> Quuxplusone wrote:
> > lichray wrote:
> > > mclow.lists wrote:
>
lichray updated this revision to Diff 154804.
lichray marked an inline comment as done.
lichray added a comment.
Respond to the 2nd round review
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
Files:
include/CMakeLists.txt
include/charconv
include/module.modulemap
src/charcon
avt77 updated this revision to Diff 154802.
avt77 added a comment.
I fixed all issues raised by efriedma: GlobalDecl(FD), function body, class
names, etc. Many tnx for your help.
https://reviews.llvm.org/D47196
Files:
include/clang/Frontend/Utils.h
lib/CodeGen/CodeGenAction.cpp
lib/CodeG
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM if that does not introduce any regressions in clang and clang-tools.
Comment at: lib/Basic/VirtualFileSystem.cpp:770
+if (I != E) {
+ SmallString<
1 - 100 of 135 matches
Mail list logo
