Author: ctopper
Date: Fri Jun 29 23:05:17 2018
New Revision: 336042
URL: http://llvm.org/viewvc/llvm-project?rev=336042&view=rev
Log:
[X86] Correct the width of mask arguments in intrinsic headers and tests.
All of these found by grepping through IR from the builtin tests for extra
trunc and zex
malaperle updated this revision to Diff 153612.
malaperle added a comment.
Add comment about AutoTypeLoc work-around.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48159
Files:
clangd/XRefs.cpp
unittests/clangd/TestTU.cpp
unittests/clangd/TestTU.h
unittests/clangd/XRef
mclow.lists added a comment.
I want to point out that this code (not -necessarily- this patch, but where it
lives) needs to be rewritten.
There is no prohibition on users specializing `allocator_traits` for their
allocators, and yet libc++'s vector depends on the existence of
`allocator_traits
malaperle updated this revision to Diff 153611.
malaperle added a comment.
Fix handling of externs, definition vs declaration and call more common code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/
Author: tstellar
Date: Fri Jun 29 20:50:10 2018
New Revision: 336039
URL: http://llvm.org/viewvc/llvm-project?rev=336039&view=rev
Log:
Driver: Add an explicit target to testcase from r336037
Modified:
cfe/trunk/test/Driver/linux-ld.c
Modified: cfe/trunk/test/Driver/linux-ld.c
URL:
http://ll
Author: tstellar
Date: Fri Jun 29 19:55:54 2018
New Revision: 336037
URL: http://llvm.org/viewvc/llvm-project?rev=336037&view=rev
Log:
Driver: Don't mix system tools with devtoolset tools on RHEL
Summary:
On RHEL, devtoolset provides a more up-to-date toolchain than the base
install, and we want
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336037: Driver: Don't mix system tools with devtoolset
tools on RHEL (authored by tstellar, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D34
enyquist added a comment.
@klimek having gotten that out of the way, I do occasionally drink too much and
have sudden urges to re-implement things from scratch. Close it if you need to,
since I can't commit to anything, but it it happens to be still open on one
of those nights, who knows, m
MTC added a comment.
kindly ping!
Repository:
rC Clang
https://reviews.llvm.org/D48027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ctopper
Date: Fri Jun 29 18:32:14 2018
New Revision: 336036
URL: http://llvm.org/viewvc/llvm-project?rev=336036&view=rev
Log:
[X86] Remove masking from the avx512 rotate builtins. Use a select builtin
instead.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/lib/
Author: smeenai
Date: Fri Jun 29 18:25:47 2018
New Revision: 336034
URL: http://llvm.org/viewvc/llvm-project?rev=336034&view=rev
Log:
[libc++abi] Look for __config instead of vector
vector is a generic C++ header, whereas __config is libc++-specific, so
we can look for it instead to guarantee we'
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336032: [libc++abi] Limit libc++ header search to specified
paths (authored by smeenai, committed by ).
Herald added a sub
Author: smeenai
Date: Fri Jun 29 18:04:50 2018
New Revision: 336032
URL: http://llvm.org/viewvc/llvm-project?rev=336032&view=rev
Log:
[libc++abi] Limit libc++ header search to specified paths
Right now, when libc++abi is locating libc++ headers, it specifies
several search locations, but it also
smeenai added a comment.
In https://reviews.llvm.org/D48694#1148718, @EricWF wrote:
> > For whether it makes sense to search for includes in the system path, that
> > boils down to @ldionne's question of whether building libc++abi against a
> > system-installed libc++ is supported. I actually d
EricWF added a comment.
> For whether it makes sense to search for includes in the system path, that
> boils down to @ldionne's question of whether building libc++abi against a
> system-installed libc++ is supported. I actually don't know the answer to
> that myself ... @dexonsmith and @EricW
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336031: Add protocol redefinition to the current
scope/context (authored by bruno, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47297?vs=14
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336031: Add protocol redefinition to the current
scope/context (authored by bruno, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47297
Files:
lib/Sema/SemaDeclObjC.cpp
test/Modules
Author: bruno
Date: Fri Jun 29 17:49:27 2018
New Revision: 336031
URL: http://llvm.org/viewvc/llvm-project?rev=336031&view=rev
Log:
Add protocol redefinition to the current scope/context
Not doing so causes the AST writter to assert since the decl in question
never gets emitted. This is fine when
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336029: [CUDA] Add tests to ensure that std::min/max can be
called from __host__… (authored by jlebar, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D48037
Files:
test-suite/trunk/Ext
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336030: [CUDA] Add tests that, in C++14 mode, min/max are
constexpr. (authored by jlebar, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D48152
Files:
test-suite/trunk/External/CUDA/al
smeenai added a comment.
In https://reviews.llvm.org/D48694#1146232, @EricWF wrote:
> LGTM, but I'm a bit confused. You seem to argue that no system places C++
> headers on the default search paths, but also that it would be a problem if
> such a system did.
> Why wouldn't the conclusion be tr
anniecherk updated this revision to Diff 153597.
anniecherk added a comment.
Herald added a subscriber: eraman.
- addressed Julie's comments
- updated logic to consider both access specifier & linkage
- added tests for each type of linkage
https://reviews.llvm.org/D48395
Files:
clang-tools-ex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336026: [CUDA] Make __host__/__device__ min/max overloads
constexpr in C++14. (authored by jlebar, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
Author: jlebar
Date: Fri Jun 29 15:28:09 2018
New Revision: 336026
URL: http://llvm.org/viewvc/llvm-project?rev=336026&view=rev
Log:
[CUDA] Make __host__/__device__ min/max overloads constexpr in C++14.
Summary: Tests in a separate change to the test-suite.
Reviewers: rsmith, tra
Subscribers: l
Author: jlebar
Date: Fri Jun 29 15:27:56 2018
New Revision: 336025
URL: http://llvm.org/viewvc/llvm-project?rev=336025&view=rev
Log:
[CUDA] Make min/max shims host+device.
Summary:
Fixes PR37753: min/max can't be called from __host__ __device__
functions in C++14 mode.
Testcase in a separate tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336025: [CUDA] Make min/max shims host+device. (authored by
jlebar, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48036?vs=150790&id=153593#
jlebar added a comment.
> Looks right to me (other than the missing constexpr in C++14 onwards). Though
> this is subtle enough that I suspect the only way to know for sure is to try
> it.
Thanks a lot, Richard. FTR the missing constexpr is in
https://reviews.llvm.org/D48151.
https://review
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks right to me (other than the missing `constexpr` in C++14 onwards). Though
this is subtle enough that I suspect the only way to know for sure is to try it.
https://reviews.llvm.org/D4803
Author: george.karpenkov
Date: Fri Jun 29 15:05:13 2018
New Revision: 336022
URL: http://llvm.org/viewvc/llvm-project?rev=336022&view=rev
Log:
[analyzer] [tests] Fix 80 column violation in SATestBuild.py
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified: cfe/trunk/utils/analyzer/SAT
Author: george.karpenkov
Date: Fri Jun 29 15:05:32 2018
New Revision: 336023
URL: http://llvm.org/viewvc/llvm-project?rev=336023&view=rev
Log:
[analyzer] [tests] Allow the tested project to specify it's own analyzer wrapper
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified: cfe/trun
ivanlozano created this revision.
ivanlozano added reviewers: srhines, eugenis, peter.smith, echristo.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, kristof.beyls.
This implements execute-only support for AArch64 targets, similar to the ARM
execute-only support.
R
Author: rsmith
Date: Fri Jun 29 14:58:50 2018
New Revision: 336021
URL: http://llvm.org/viewvc/llvm-project?rev=336021&view=rev
Log:
PR33924: merge local declarations that have linkage of some kind within
merged function definitions; also merge functions with deduced return
types.
This seems like
Author: dblaikie
Date: Fri Jun 29 14:58:24 2018
New Revision: 336020
URL: http://llvm.org/viewvc/llvm-project?rev=336020&view=rev
Log:
Spurious commit just to help Richard, because git is weird.
Modified:
cfe/trunk/test/Modules/codegen.test
Modified: cfe/trunk/test/Modules/codegen.test
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT336019: [profile] Add llvm_gcov_flush to be called outside
a shared library (authored by chh, committed by ).
Herald added a subscriber: Sanitizers.
Repository:
rCRT Compiler Runtime
https://reviews.
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D45454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
chh updated this revision to Diff 153576.
chh marked an inline comment as done.
https://reviews.llvm.org/D45454
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
Index: test/profile/Inputs/instrprof-dlopen-dlclose-main.c
=
srhines added a comment.
LGTM. Thanks for making the checking more clear. This should help bridge the
gap for now, so that we can resume getting per-library profile data in Android.
https://reviews.llvm.org/D45454
___
cfe-commits mailing list
cfe-c
chh added inline comments.
Comment at: test/profile/Inputs/instrprof-dlopen-dlclose-main.c:20
+ void (*gcov_flush)() = (void (*)())dlsym(f1_handle, "__gcov_flush");
+ if (gcov_flush != NULL) {
+fprintf(stderr, "__gcov_flush should not be visible in func.shared'\n");
---
chh updated this revision to Diff 153573.
chh added a comment.
check dlerror() where it shouldn't be NULL
https://reviews.llvm.org/D45454
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
Index: test/profile/Inputs/instrprof-dlopen-dlclose-main.c
=
davidxl added inline comments.
Comment at: lib/profile/GCDAProfiling.c:546
+// find and call. In that case, it dumps profile data of a .so file.
+// If it is called directly inside a .so file, the unified copy of
+// llvm_gcov_flush might dump data of other .so file or the main m
chh updated this revision to Diff 153569.
chh marked an inline comment as done.
chh added a comment.
Added calls to dlerror() before other dl* functions.
https://reviews.llvm.org/D45454
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
Index: test/prof
Author: rsmith
Date: Fri Jun 29 13:46:25 2018
New Revision: 336016
URL: http://llvm.org/viewvc/llvm-project?rev=336016&view=rev
Log:
[modules] Emit the type of the TypeSourceInfo for a DeclaratorDecl (but
not the corresponding location information) earlier.
We need the type as written in order to
Should be fixed in r336013. Thanks for pointing this out.
On Fri, 29 Jun 2018 at 11:24, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Richard,
>
> This commit broke tests at one of our builders:
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-chec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336014: Introduce a separate preprocessor macro,
_LIBUNWIND_USE_DLADDR, for directly… (authored by rupprecht, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://review
Author: rupprecht
Date: Fri Jun 29 13:41:50 2018
New Revision: 336014
URL: http://llvm.org/viewvc/llvm-project?rev=336014&view=rev
Log:
Introduce a separate preprocessor macro, _LIBUNWIND_USE_DLADDR, for directly
controlling a dependency on dladdr(). This will allow us to use libunwind
without a
Author: rsmith
Date: Fri Jun 29 13:41:23 2018
New Revision: 336013
URL: http://llvm.org/viewvc/llvm-project?rev=336013&view=rev
Log:
Specify an explicit underlying type for this enum to fix Windows
buildbots.
On Windows targets, enums always get an underlying type of 'int', even
if they have wide
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: echristo
Date: Fri Jun 29 13:27:40 2018
New Revision: 336012
URL: http://llvm.org/viewvc/llvm-project?rev=336012&view=rev
Log:
Revert "Revert "Support for multiarch runtimes layout""
This reverts commit r336005 that was accidentally committed.
Modified:
libunwind/trunk/CMakeLists.txt
malaperle added inline comments.
Comment at: clangd/FindSymbols.cpp:181
+/// Finds document symbols in the main file of the AST.
+class DocumentSymbolsConsumer : public index::IndexDataConsumer {
+ ASTContext &AST;
sammccall wrote:
> I guess the alternative here
rsmith added a comment.
Hmm, so this will mean that we can have internal linkage declarations marked
`Used` for which there is no definition, and we need to not warn on that.
I think it might be better to avoid marking things used in this case (even
though they're still technically odr-used).
erik.pilkington added a comment.
Herald added a subscriber: dexonsmith.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D48322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton accepted this revision.
benhamilton added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/ContinuationIndenter.cpp:1411
+ // line).
+ if (Current.MatchingParen && Current.MatchingParen->Previous) {
+const FormatToken &Cur
rupprecht created this revision.
Herald added subscribers: cfe-commits, christof, mgorny.
Repository:
rUNW libunwind
https://reviews.llvm.org/D48787
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeL
marco-c added a comment.
OK! Sounds good to me to keep it hidden until
https://reviews.llvm.org/D48538 is done (I'm going to try to finish it
soon).
Il 29/06/2018 19:34, David Li via Phabricator ha scritto:
> davidxl added a comment.
>
> With the current gcov_flush implementation in LLVM, makin
OK! Sounds good to me to keep it hidden until
https://reviews.llvm.org/D48538 is done (I'm going to try to finish it
soon).
Il 29/06/2018 19:34, David Li via Phabricator ha scritto:
> davidxl added a comment.
>
> With the current gcov_flush implementation in LLVM, making gcov_flush's
> visibilit
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
Nice improvement!
Repository:
rC Clang
https://reviews.llvm.org/D48719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: dim
Date: Fri Jun 29 12:18:17 2018
New Revision: 336008
URL: http://llvm.org/viewvc/llvm-project?rev=336008&view=rev
Log:
Request init/fini array on FreeBSD 12 and later
Summary:
It seems a bad idea to change the default in the middle of a release
branch due to possible changes in global
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336008: Request init/fini array on FreeBSD 12 and later
(authored by dim, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D24867?vs=72282&id=15
vsapsai created this revision.
vsapsai added reviewers: bruno, rsmith.
Herald added a subscriber: dexonsmith.
Fixes a problem when we have multiple inclusion cycles and try to
enumerate all possible ways to reach the max inclusion depth.
rdar://problem/38871876
https://reviews.llvm.org/D48786
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336006: Add a blank line to docs/README.txt test commit
access (authored by rupprecht, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48785
File
Author: rupprecht
Date: Fri Jun 29 12:05:21 2018
New Revision: 336006
URL: http://llvm.org/viewvc/llvm-project?rev=336006&view=rev
Log:
Add a blank line to docs/README.txt test commit access
Subscribers: christof, cfe-commits
Differential Revision: https://reviews.llvm.org/D48785
Modified:
Author: rupprecht
Date: Fri Jun 29 12:05:20 2018
New Revision: 336005
URL: http://llvm.org/viewvc/llvm-project?rev=336005&view=rev
Log:
Revert "Support for multiarch runtimes layout"
This reverts commit 0c7cea3c0c6338b99e30c13201365a3dd4edc6f4.
Modified:
libunwind/trunk/CMakeLists.txt
Modif
Author: brad
Date: Fri Jun 29 12:03:03 2018
New Revision: 336004
URL: http://llvm.org/viewvc/llvm-project?rev=336004&view=rev
Log:
[mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.
Reviewers: atanasyan
Differential Revision: https://reviews.llvm.org/D48515
Modified:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336004: [mips][ias] Enable IAS by default for OpenBSD /
FreeBSD mips64/mips64el. (authored by brad, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48515?vs=152580&id=153550#toc
Repo
rupprecht created this revision.
Herald added subscribers: cfe-commits, christof.
Repository:
rUNW libunwind
https://reviews.llvm.org/D48785
Files:
docs/README.txt
Index: docs/README.txt
===
--- docs/README.txt
+++ docs/README
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5305
+
+ if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) {
+S.Diag(D->getLocation(), diag::warn_riscv_interrupt_attribute) << 0;
apazos wrote:
> aaron.ballman wrote:
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks for explaining! LGTM
Repository:
rC Clang
https://reviews.llvm.org/D47297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
chh added a comment.
Marco, latest patch does not change __gcov_flush, which is also hidden in
libgcov.
Android coverage test programs have depended on an earlier compiler-rt that did
not hide __gcov_flush.
If that's the only use case broken by recent change of compiler-rt, which hide
__gcov_fl
bruno added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:1208
+// serialize something meaningful.
+if (getLangOpts().Modules)
+ PushOnScopeChains(PDecl, TUScope);
arphaman wrote:
> Is this a problem only for modules or does this show up in
dblaikie added a subscriber: paulsemel.
dblaikie added a comment.
Yeah, doesn't look like this code handles a value crossing the boundary of
the size of the bitfield type (it's reading only the low bit).
I suspect looking at the code that generates bitfield accesses would be
useful - and/or maybe
Yeah, doesn't look like this code handles a value crossing the boundary of
the size of the bitfield type (it's reading only the low bit).
I suspect looking at the code that generates bitfield accesses would be
useful - and/or maybe actually calling into that very code, rather than
reimplementing i
davidxl added a comment.
With the current gcov_flush implementation in LLVM, making gcov_flush's
visibility to be default will simply lead to wrong behavior. GCC libgcov's
implementation is more elaborate -- it allows gcov_flush to dump gcda data for
all dynamic objects while making sure gcov
Hello Richard,
This commit broke tests at one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10599
Failing Tests (1):
Clang :: CXX/conv/conv.prom/p5.cpp
Please have a look?
Thanks
Galina
On Thu, Jun 28, 2018 at 2:17 PM, Richard Smith via c
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336002: [analyzer] Replace the vector of ConstraintSets by a
single ConstraintSet and a… (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://revi
Author: mramalho
Date: Fri Jun 29 11:11:43 2018
New Revision: 336002
URL: http://llvm.org/viewvc/llvm-project?rev=336002&view=rev
Log:
[analyzer] Replace the vector of ConstraintSets by a single ConstraintSet and a
function to merge ConstraintSets
Now, instead of adding the constraints when they
Author: paquette
Date: Fri Jun 29 11:06:10 2018
New Revision: 336001
URL: http://llvm.org/viewvc/llvm-project?rev=336001&view=rev
Log:
[MachineOutliner] Make -mno-outline use -enable-machine-outliner=never
This updates -mno-outline so that it passes -enable-machine-outliner=never
instead of nothi
marco-c added a comment.
Why keeping a __gcov_flush which is incompatible with GCC and previous versions
of LLVM and adding a __llvm_gcov_flush which is compatible? I feel the other
way around (or even just having an unhidden "__gcov_flush" and not introducing
"__llvm_gcov_flush") would be mor
apazos updated this revision to Diff 153544.
https://reviews.llvm.org/D48412
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
test/Sema/riscv-interrupt-attr.c
test/Sema/
apazos added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5305
+
+ if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) {
+S.Diag(D->getLocation(), diag::warn_riscv_interrupt_attribute) << 0;
aaron.ballman wrote:
> I would have assumed
srhines added a comment.
Thanks for picking this up again and updating the change to add
llvm_gcov_flush().
Comment at: test/profile/Inputs/instrprof-dlopen-dlclose-main.c:20
+ void (*gcov_flush)() = (void (*)())dlsym(f1_handle, "__gcov_flush");
+ if (gcov_flush != NULL) {
+
thakis added a comment.
For your convenience: https://godbolt.org/g/KXxbKb
https://reviews.llvm.org/D48781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis created this revision.
thakis added a reviewer: majnemer.
MSVC limits char16_t and char32_t string literal names to 32 bytes of character
data, not to 32 characters. wchar_t string literal names on the other hand can
get up to 64 bytes of character data.
https://reviews.llvm.org/D48781
chh updated this revision to Diff 153532.
chh retitled this revision from "Make __gcov_flush visible outside a shared
library" to "Add llvm_gcov_flush to be called outside a shared library".
chh edited the summary of this revision.
chh added a comment.
Now keep __gcov_flush hidden as libgcov; add
NoQ added a comment.
That's right. You only need to mark "atomic" symbols (`SymbolData`) as live,
and expressions that contain them would automatically become live. So i think
you should just iterate through a `symbol_iterator` and mark all `SymbolData`
symbols you encounter as live.
Is this a
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:1208
+// serialize something meaningful.
+if (getLangOpts().Modules)
+ PushOnScopeChains(PDecl, TUScope);
Is this a problem only for modules or does this show up in PCHs too? What
RKSimon added a comment.
Please can you create a llvm side parallel patch that updates the relevant
fast-isel tests
Comment at: clang/lib/Headers/avx512vlbwintrin.h:1501
+ (__v8qi){0, 0, 0, 0, 0, 0, 0, 0}, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 14, 15);
}
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335993: [Fixed Point Arithmetic] Rename `-fsame-fbits` flag
(authored by leonardchan, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48727
Files:
include/clang/Basic/LangOptions.def
Author: leonardchan
Date: Fri Jun 29 10:08:19 2018
New Revision: 335993
URL: http://llvm.org/viewvc/llvm-project?rev=335993&view=rev
Log:
[Fixed Point Arithmetic] Rename `-fsame-fbits` flag
- Rename the `-fsame-fbits` flag to `-fpadding-on-unsigned-fixed-point`
- Move the flag from a driver optio
bruno added a comment.
Herald added a subscriber: dexonsmith.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D47297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
paulsemel updated this revision to Diff 153511.
paulsemel added a comment.
Fixed version problem. Now building.
Repository:
rC Clang
https://reviews.llvm.org/D47953
Files:
lib/CodeGen/CGBuiltin.cpp
Index: lib/CodeGen/CGBuiltin.cpp
=
paulsemel added a comment.
In https://reviews.llvm.org/D47953#1143044, @dblaikie wrote:
> This doesn't seem to build for me - so hard to debug/probe it:
>
> llvm/src/tools/clang/lib/CodeGen/CGBuiltin.cpp:1264:65: error: no viable
> conversion from 'clang::QualType' to 'llvm::Type *'
>
> CGF.CG
mike.dvoretsky added inline comments.
Comment at: clang/lib/Headers/avx512vlbwintrin.h:1501
+ (__v8qi){0, 0, 0, 0, 0, 0, 0, 0}, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11,
+ 12, 13, 14, 15);
}
RKSimon wrote:
> Are we happy with using illegal types like this?
sammccall updated this revision to Diff 153504.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Address review comments. Most notably: limit the up-traversals from some
sources.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48441
Files:
clangd/CMakeLi
martong added a comment.
I realized that, this patch brakes 3 lldb tests ATM:
- `TestTopLevelExprs.py`. If https://reviews.llvm.org/D48722 was merged then
this test would not be broken.
- `TestPersistentTypes.py` If https://reviews.llvm.org/D48773 was merged then
this test would not be broken.
deepak2427 added a comment.
Do I need to add specific reviewers?
Repository:
rC Clang
https://reviews.llvm.org/D48721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335983: [clang-format/ObjC] Fix NS_SWIFT_NAME(foo(bar:baz:))
after ObjC method decl (authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://review
Author: benhamilton
Date: Fri Jun 29 08:26:37 2018
New Revision: 335983
URL: http://llvm.org/viewvc/llvm-project?rev=335983&view=rev
Log:
[clang-format/ObjC] Fix NS_SWIFT_NAME(foo(bar:baz:)) after ObjC method decl
Summary:
In D44638, I partially fixed `NS_SWIFT_NAME(foo(bar:baz:))`-style
annotati
martong created this revision.
martong added reviewers: a.sidorin, balazske, r.stahl.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Currently, anonymous types are merged into the same redecl chain even if they
are structurally inequivalent. This results that global objects are not
impor
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE335980: [clangd] codeComplete returns more structured
completion items, LSP. NFC. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48762?vs=153493&id=153495#t
Author: sammccall
Date: Fri Jun 29 07:47:57 2018
New Revision: 335980
URL: http://llvm.org/viewvc/llvm-project?rev=335980&view=rev
Log:
[clangd] codeComplete returns more structured completion items, LSP. NFC.
Summary:
LSP has some presentational fields with limited semantics (e.g. 'detail') and
1 - 100 of 136 matches
Mail list logo
