Higuoxing updated this revision to Diff 151605.
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
===
--- test/Sema/parentheses.c
+++ test/Sema/parentheses.c
@@ -
Higuoxing updated this revision to Diff 151604.
Higuoxing added a comment.
Ping, thanks
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
===
--- test/Sema/pare
Higuoxing updated this revision to Diff 151599.
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
===
--- test/Sema/parentheses.c
+++ test/Sema/parentheses.c
@@
Author: yaxunl
Date: Fri Jun 15 18:20:52 2018
New Revision: 334879
URL: http://llvm.org/viewvc/llvm-project?rev=334879&view=rev
Log:
Call CreateTempAllocaWithoutCast for ActiveFlag
This is partial re-commit of r332982.
Modified:
cfe/trunk/lib/CodeGen/CGCleanup.cpp
Modified: cfe/trunk/lib/Co
JDevlieghere updated this revision to Diff 151596.
JDevlieghere marked 3 inline comments as done.
JDevlieghere added a comment.
- Feedback Adrian
https://reviews.llvm.org/D48241
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
clang/test/CodeGenObjC/debug-info-cate
rsmith added inline comments.
Comment at: include/clang/AST/SourceLocExprScope.h:39
+//static_assert(foo() == __LINE__);
+return OldVal == nullptr || isa(DefaultExpr) ||
+ !OldVal->isInSameContext(EvalContext);
Do we want the `isa` check her
aprantl added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4250
+
+ SmallVector EltTys;
+ EltTys.append(InterfaceDecl->getElements().begin(),
```
auto &Elements = InterfaceDecl->getElements();
EltTys.append(Elements.begin(), Elements.e
dlj added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2900-2904
+AST_POLYMORPHIC_MATCHER_P_OVERLOAD(
+hasType,
+AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, ValueDecl),
+internal::Matcher, InnerMatcher, 1) {
+ QualType QT = internal::get
dlj updated this revision to Diff 151593.
dlj marked 3 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D48242
Files:
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersNodeTest.cpp
Index: unitt
JDevlieghere updated this revision to Diff 151591.
JDevlieghere added a comment.
- Use type cache &
- Simplify method cache struct
- Add custom test that verifies category methods are emitted
https://reviews.llvm.org/D48241
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugI
klimek added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2904
+internal::Matcher, InnerMatcher, 1) {
+ QualType QT = internal::getUnderlyingType(Node);
+ if (!QT.isNull())
In which cases can getUnderlyingType return a null type?
R
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor nits.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2900-2904
+AST_POLYMORPHIC_MATCHER_P_OVERLOAD(
+hasType,
+AST_POLYM
JDevlieghere added a comment.
In https://reviews.llvm.org/D48241#1134240, @dblaikie wrote:
> Not sure I should get too involved in this discussion, knowing so little
> about Objective C - but if it seems sensible, could you provide some examples
> (just in comments/description in this code revi
NoQ updated this revision to Diff 151584.
NoQ added a comment.
Whoops, that was an old patch.
https://reviews.llvm.org/D48249
Files:
lib/Analysis/CFG.cpp
lib/Analysis/ConstructionContext.cpp
test/Analysis/cfg-rich-constructors.cpp
test/Analysis/cfg-rich-constructors.mm
test/Analysis/t
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
This is similar to https://reviews.llvm.org/D45650. Constructors of
pass-by-value arguments aren't simi
aprantl added a comment.
> could you provide some examples (just in comments/description in this code
> review) of what the DWARF used to look like and what it looks like after this
> change?
Thus far an Objective-C interface is a DW_TAG_structure_type that only has
variables and properties as
Author: maskray
Date: Fri Jun 15 16:11:18 2018
New Revision: 334870
URL: http://llvm.org/viewvc/llvm-project?rev=334870&view=rev
Log:
[docs] -fsanitize=cfi only allowed with -fvisibility=
Modified:
cfe/trunk/docs/SanitizerStats.rst
Modified: cfe/trunk/docs/SanitizerStats.rst
URL:
http://llv
JDevlieghere updated this revision to Diff 151580.
JDevlieghere marked 5 inline comments as done.
JDevlieghere added a comment.
CR feedback
https://reviews.llvm.org/D48241
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
clang/test/CodeGenObjC/debug-info-synthesis.
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1623
+ const CXXRecordDecl *SourceClassDecl =
+ E->getType().getTypePtr()->getPointeeCXXRecordDecl();
+ const CXXRecordDecl *DstClassDecl = DestTy->getPointeeCXXRecordDecl();
---
Prazek marked an inline comment as done.
Prazek added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1624
+ E->getType().getTypePtr()->getPointeeCXXRecordDecl();
+ const CXXRecordDecl *DstClassDecl = DestTy->getPointeeCXXRecordDecl();
+
Prazek added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1633
+ bool DstMayNotBeDynamic =
+ !DstClassDecl || DstClassDecl->mayBeNotDynamicClass();
+ if (SourceMayBeNotDynamic && DstMayBeDynamic) {
rjmccall wrote:
> If you ma
Prazek updated this revision to Diff 151575.
Prazek added a comment.
Refactor
Repository:
rL LLVM
https://reviews.llvm.org/D47299
Files:
clang/include/clang/AST/DeclCXX.h
clang/include/clang/AST/Type.h
clang/lib/AST/Type.cpp
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScal
Prazek marked 5 inline comments as done.
Prazek added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1623
+ const CXXRecordDecl *SourceClassDecl =
+ E->getType().getTypePtr()->getPointeeCXXRecordDecl();
+ const CXXRecordDecl *DstClassDecl = Des
aprantl added a comment.
Thanks! Is there also a companion patch for LLVM that disables the objc
accelerator table?
Note that this is not a 100% replacement of the apple_objc accelerator table,
since the apple_objc table also lists all methods defined in categories of that
interface. Is the id
Author: tkrupa
Date: Fri Jun 15 11:05:59 2018
New Revision: 334850
URL: http://llvm.org/viewvc/llvm-project?rev=334850&view=rev
Log:
[X86] Lowering sqrt intrinsics to native IR
Reviewers: craig.topper, spatel, RKSimon, igorb, uriel.k
Reviewed By: craig.topper
Subscribers: tkrupa, cfe-commits
D
Author: yhs
Date: Fri Jun 15 08:53:31 2018
New Revision: 334839
URL: http://llvm.org/viewvc/llvm-project?rev=334839&view=rev
Log:
bpf: recognize target specific option -mattr=dwarfris in clang
The following is the usage example with clang:
bash-4.2$ clang -target bpf -O2 -g -c -Xclang -target-f
dblaikie added a comment.
Not sure I should get too involved in this discussion, knowing so little about
Objective C - but if it seems sensible, could you provide some examples (just
in comments/description in this code review) of what the DWARF used to look
like and what it looks like after th
dlj created this revision.
dlj added a reviewer: klimek.
dlj added a project: clang.
This allows matchers like:
friendDecl(hasType(cxxRecordDecl(...)))
friendDecl(hasType(asString(...)))
It seems that hasType is probably the most reasonable narrowing matcher to
overload, since it is already
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, dexonsmith, dblaikie, labath.
As brought up during the discussion of the DWARF5 accelerator tables,
there is currently no way to associate Objective-C methods with the
interface they belong to, other than the .apple_objc ac
efriedma added a comment.
Can you give an example of what the output looks like?
Please don't define multiple different classes with the same name SortClassName.
It seems like you've scattered the "start" and "stop" calls all over the place;
can you put the start and stop calls in the same plac
mgorny added a comment.
Gentle ping.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D47819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Gentle ping.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D47817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ accepted this revision.
NoQ added a comment.
Ok, let's land this one and see how it goes! I'm looking forward to seeing the
follow-up patches.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:359-372
+ // Checking bases.
+ const auto *CXXRD = dyn_ca
NoQ added a comment.
I still don't think i fully understand your concern? Could you provide an
example and point out what exactly goes wrong?
https://reviews.llvm.org/D35110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
NoQ added a comment.
> In the iterator checkers we do not know anything about the rearranged
> expressions, it has no access to the sum/difference, the whole purpose of
> your proposal was to put in into the infrastructure.
It wasn't. The purpose was merely to move (de-duplicate) the code that
jlebar added a comment.
In https://reviews.llvm.org/D48151#1133954, @rsmith wrote:
> LGTM
Thank you for the review, Richard.
Will check this in once the whole stack is ready -- just need
https://reviews.llvm.org/D48036.
https://reviews.llvm.org/D48151
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D48208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: bruno
Date: Fri Jun 15 13:13:28 2018
New Revision: 334859
URL: http://llvm.org/viewvc/llvm-project?rev=334859&view=rev
Log:
[Modules] Improve .Private fix-its to handle 'explicit' and 'framework'
When in the context of suggestion the fix-it from .Private to _Private
for private modules, t
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
The canonical way to represent the result of casting `&SymRegion{$x}` to `bool`
is `($x != 0)`, not `$x
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
NoQ added inline comments.
Comment at: test/Analysis/inlining/inline-defensive-checks.cpp:93
+S *conjure();
+S *get_conjured(S _) {
+ S *s = conjure();
george.karpenkov wrote:
> what is the argument doing?
Causing cleanups (:
Repository:
rC Clang
https://re
RKSimon added a comment.
LGTM as well
Repository:
rL LLVM
https://reviews.llvm.org/D41168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334850: [X86] Lowering sqrt intrinsics to native IR
(authored by tkrupa, committed by ).
Herald added a subscriber: llvm-c
Author: ctopper
Date: Fri Jun 15 10:40:37 2018
New Revision: 334847
URL: http://llvm.org/viewvc/llvm-project?rev=334847&view=rev
Log:
[X86] __builtin_ia32_prord512_mask, __builtin_ia32_prorq512_mask,
__builtin_ia32_shufpd should only accept an ICE constant.
The rotates also need to check for the
dexonsmith added reviewers: arphaman, ahatanak.
dexonsmith added subscribers: arphaman, ahatanak.
dexonsmith added a comment.
In https://reviews.llvm.org/D47687#1133222, @Higuoxing wrote:
> I think I am almost there.
>
> Here, In my sight
>
> #define foo(op0, op1, x, y, z) ( (void)(x op0 y op1
gerazo updated this revision to Diff 151533.
gerazo added a comment.
Updated to not conflict with and use the stuff implemented in
https://reviews.llvm.org/D47445 (so became a bit smaller)
Now, it is ready for a review. Enjoy!
https://reviews.llvm.org/D47946
Files:
lib/AST/ASTImporter.cpp
Author: ctopper
Date: Fri Jun 15 10:03:32 2018
New Revision: 334846
URL: http://llvm.org/viewvc/llvm-project?rev=334846&view=rev
Log:
[X86] The immediate argument to getmantpd*_mask should be an ICE and it should
only be 4 bits wide.
We already checked this for the scalar version, but missed the
george.karpenkov added inline comments.
Comment at: test/Analysis/inlining/inline-defensive-checks.cpp:93
+S *conjure();
+S *get_conjured(S _) {
+ S *s = conjure();
what is the argument doing?
Repository:
rC Clang
https://reviews.llvm.org/D48204
george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241
if (const llvm::APSInt *I =
- SVB.getKnownValue(State, nonloc::Symb
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D47630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
thakis created this revision.
thakis added a reviewer: chandlerc.
The test makes %t.fake a symlink to %t.real by running `ln -sf %t.real
%t.fake`. If %t.fake already is a symlink to %t.real when this runs (e.g. if
the test has run before), then this effectively becomes `ln -sf %t.real
%t.real`,
Author: yaxunl
Date: Fri Jun 15 08:33:22 2018
New Revision: 334837
URL: http://llvm.org/viewvc/llvm-project?rev=334837&view=rev
Log:
[NFC] Add CreateMemTempWithoutCast and CreateTempAllocaWithoutCast
This is partial re-commit of r332982
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trun
jlebar added a comment.
@rsmith friendly ping on this review.
https://reviews.llvm.org/D48151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
@rsmith friendly ping on this one.
https://reviews.llvm.org/D48036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smcgro updated this revision to Diff 151512.
https://reviews.llvm.org/D48188
Files:
lib/Basic/Targets/SPIR.h
test/CodeGen/spir-half-type.cpp
Index: test/CodeGen/spir-half-type.cpp
===
--- /dev/null
+++ test/CodeGen/spir-half-typ
smcgro added a comment.
Thanks for the feedback @SjoerdMeijer I've updated the commit message and
responded to the comments
Comment at: lib/Basic/Targets/SPIR.h:50
UseAddrSpaceMapMangling = true;
+HasLegalHalfType = true;
// Define available target features
-
Author: zinovy.nis
Date: Fri Jun 15 06:35:40 2018
New Revision: 334829
URL: http://llvm.org/viewvc/llvm-project?rev=334829&view=rev
Log:
[clang-tidy] This patch is a fix for D45405 where spaces were mistakenly
considered as a part of a type name. So length("int *") was 5 instead of 3 with
Remove
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334829: [clang-tidy] This patch is a fix for D45405 where
spaces were mistakenly… (authored by zinovy.nis, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45927?vs=146677&id=151500#
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE334828: [clangd] UI for completion items that would
trigger include insertion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48163?vs=151498&id=151499#toc
Re
Author: ioeric
Date: Fri Jun 15 06:34:18 2018
New Revision: 334828
URL: http://llvm.org/viewvc/llvm-project?rev=334828&view=rev
Log:
[clangd] UI for completion items that would trigger include insertion.
Summary:
For completion items that would trigger include insertions (i.e. index symbols
that
ioeric updated this revision to Diff 151498.
ioeric added a comment.
- clang-format again...
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48163
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd/Headers.h
test/clangd/completion-snippets.t
atanasyan accepted this revision.
atanasyan added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Driver/Options.td:2214
HelpText<"Disable SVR4-style position-independent code (Mips only)">;
+def mno_crc : Flag<["-"], "mno-crc">, Gro
ioeric added inline comments.
Comment at: clangd/CodeComplete.h:63
- // Populated internally by clangd, do not set.
+ /// Populated internally by clangd, do not set.
/// If `Index` is set, it is used to augment the code completion
sammccall wrote:
> if you
ioeric updated this revision to Diff 151497.
ioeric added a comment.
- fix typo and clang-format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48163
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd/Headers.h
test/clangd/completion-snippe
ioeric updated this revision to Diff 151496.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48163
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd
sdardis added inline comments.
Comment at: include/clang/Driver/Options.td:2214
HelpText<"Disable SVR4-style position-independent code (Mips only)">;
+def mno_crc : Flag<["-"], "mno-crc">, Group,
+ HelpText<"Disallow use of CRC instructions (Mips only)">;
ata
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:313
+I.label =
+(InsertingInclude ? Opts.IncludeInsertionIndicator : " ") + I.label;
I.scoreInfo = Scores;
sammccall wrote:
> string(IncludeInsertionIndicator.size(), ' ')?
oops
atanasyan added inline comments.
Comment at: include/clang/Driver/Options.td:2214
HelpText<"Disable SVR4-style position-independent code (Mips only)">;
+def mno_crc : Flag<["-"], "mno-crc">, Group,
+ HelpText<"Disallow use of CRC instructions (Mips only)">;
D
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:301
+ } else if (!IncludePath->empty()) {
+if (auto Edit = Includes.insert(*IncludePath)) {
+
erichkeane added a comment.
Just a quick bump, I know most of you are still recovering from the Switzerland
trip, but hopefully the others will have some time.
https://reviews.llvm.org/D47474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: sammccall
Date: Fri Jun 15 05:39:21 2018
New Revision: 334824
URL: http://llvm.org/viewvc/llvm-project?rev=334824&view=rev
Log:
[clangd] context key constructor is constexpr. NFC
Modified:
clang-tools-extra/trunk/clangd/Context.h
Modified: clang-tools-extra/trunk/clangd/Context.h
URL
ioeric added a comment.
Thanks for the review!
Comment at: clangd/CodeComplete.cpp:187
+ // Whether or not this candidate is in a completion where index is allowed.
+ // This can affect how items are built (e.g. indent label to align with
visual
+ // indicator in index resu
ioeric updated this revision to Diff 151492.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Addressed review comments.
- Merged with orgin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48163
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE334822: [clangd] Add option to fold overloads into a
single completion item. (authored by sammccall, committed by ).
Changed prior to commit:
https://review
Author: sammccall
Date: Fri Jun 15 04:06:29 2018
New Revision: 334822
URL: http://llvm.org/viewvc/llvm-project?rev=334822&view=rev
Log:
[clangd] Add option to fold overloads into a single completion item.
Summary:
Adds a CodeCompleteOption to folds together compatible function/method overloads
in
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. (and a question on why we want to special-case the members)
Comment at: clangd/CodeComplete.cpp:245
+// Methods are simply grouped by name.
+
Author: lukegeeson
Date: Fri Jun 15 03:10:45 2018
New Revision: 334820
URL: http://llvm.org/viewvc/llvm-project?rev=334820&view=rev
Log:
[AArch64] Reverted rC334696 with Clang VCVTA test fix
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGen/aarch64-v8.2a-neon-intrinsic
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric.
Comments from namespaces that clangd produces are too noisy and often
not useful.
Namespaces have too many redecls and we don't have a good way of
determining which
sammccall updated this revision to Diff 151476.
sammccall marked an inline comment as done.
sammccall added a comment.
Review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47957
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/tool/ClangdMain.cpp
un
sammccall marked 4 inline comments as done.
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:245
+// Methods are simply grouped by name.
+return hash_combine('M', IndexResult->Name);
+ case index::SymbolKind::Function:
ily
SjoerdMeijer added a comment.
I know very little about SPIR, and Initially didn't understand this:
> The SPIR target currently allows for half precision floating point types to
> use the LLVM intrinsic functions to convert to floats and doubles. This is
> illegal in SPIR as the only intrinsic a
Author: hokein
Date: Fri Jun 15 02:32:36 2018
New Revision: 334812
URL: http://llvm.org/viewvc/llvm-project?rev=334812&view=rev
Log:
[clangd] Fix buildbot error.
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp
URL:
http://l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334810: [clangd] Boost completion score according to file
proximity. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47935
F
Author: ioeric
Date: Fri Jun 15 01:58:12 2018
New Revision: 334810
URL: http://llvm.org/viewvc/llvm-project?rev=334810&view=rev
Log:
[clangd] Boost completion score according to file proximity.
Summary:
Also move unittest: URI scheme to TestFS so that it can be shared by
different tests.
Reviewe
ioeric added a comment.
Thanks for the review!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 151469.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- addressed review comments and rebase.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
ioeric added inline comments.
Comment at: unittests/clangd/FileIndexTests.cpp:99
+class TestURIScheme : public URIScheme {
+public:
sammccall wrote:
> This can use the shared unittest: scheme from the followup patch, right?
>
> Add a fixme or lift that into th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334809: [clangd] Customizable URI schemes for dynamic index.
(authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47931
Files:
Author: ioeric
Date: Fri Jun 15 01:55:00 2018
New Revision: 334809
URL: http://llvm.org/viewvc/llvm-project?rev=334809&view=rev
Log:
[clangd] Customizable URI schemes for dynamic index.
Summary:
This allows dynamic index to have consistent URI schemes with the
static index which can have customiz
ioeric updated this revision to Diff 151467.
ioeric marked an inline comment as done.
ioeric added a comment.
- Pulled unittest URI refactoring from https://reviews.llvm.org/D47935
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47931
Files:
clangd/ClangdServer.cpp
clangd/Cl
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/clangd/FileIndexTests.cpp:99
+class TestURIScheme : public URIScheme {
+public:
This can use the shared unittest: scheme fr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334807: [clangd] Do not report comments that only have
special chars. (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4817
Author: ibiryukov
Date: Fri Jun 15 01:31:17 2018
New Revision: 334807
URL: http://llvm.org/viewvc/llvm-project?rev=334807&view=rev
Log:
[clangd] Do not report comments that only have special chars.
Summary:
Like the following:
// ---
// ===
// ***
It does not cover all the case
ilya-biryukov added a comment.
Overall LG. It would be nice to mention somewhere that we since we bundle
overloads client-side we might run into weird side-effects (e.g. return less
completion items than the specified limit) in case the index returns too many
non-bundled.
Co
ilya-biryukov added a comment.
Oh, sorry, I forgot to submit the comments yesterday :-(
Comment at: clangd/CodeComplete.cpp:245
+// Methods are simply grouped by name.
+return hash_combine('M', IndexResult->Name);
+ case index::SymbolKind::Function:
---
mike.dvoretsky abandoned this revision.
mike.dvoretsky added a comment.
Abandoning this due to https://reviews.llvm.org/D48067 being accepted instead.
https://reviews.llvm.org/D45202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks! Just nits
Comment at: clangd/Quality.cpp:304
OS << formatv("\tForbidden: {0}\n", S.Forbidden);
- OS << formatv("\tProximity: {0}\n", S.ProximityScore);
+ O
Higuoxing added a comment.
Ping
https://reviews.llvm.org/D47687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Higuoxing updated this revision to Diff 151460.
Higuoxing added a comment.
I think I am almost there.
Here, In my sight
#define foo(op0, op1, x, y, z) ( (void)(x op0 y op1 z) )
is un-actionable, because `x op0 y op1 z` are from different arguments of
function-like macro, so, we will not chec
99 matches
Mail list logo
