lebedev.ri added a comment.
Please always upload all patches with the full context (`-U9`)
Comment at: tools/clang-format/clang-format-diff.py:1
-#!/usr/bin/env python
+#!/usr/bin/env python3
#
Why do you need to *switch* the default?
What's wrong with [at
malaperle created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
This allows hovering on keywords that refer to deduced types.
This should cover most useful cases. Not covered:
- auto template parameters: Since this can be instantiated with many typ
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:32
check::PostCall> {
- CallDescription CStrFn;
+ const llvm::SmallVector CStrFnFamily = {
+{"std::basic_string::c_str"
Higuoxing updated this revision to Diff 151290.
Higuoxing added a comment.
Ping, well, I think I understand `@dexonsmith`'s idea.
`Actionable` macro argument is just like something like this
#define foo(x) ( (void)(x) )
when we using it by
foo(a && b || c);
we could add parentheses for it
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334684: [analyzer] Re-enable C++17-specific RVO construction
contexts. (authored by dergachev, committed by ).
Herald added a subscriber: mikhail.ramalho.
Repository:
rC Clang
https://reviews.llvm.org/
Author: dergachev
Date: Wed Jun 13 18:59:35 2018
New Revision: 334684
URL: http://llvm.org/viewvc/llvm-project?rev=334684&view=rev
Log:
[analyzer] Re-enable C++17-specific RVO construction contexts.
Not contexts themselves, but rather support for them in the analyzer.
Such construction contexts
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334683: [analyzer] Re-enable C++17-specific variable and
member construction contexts. (authored by dergachev, committed by ).
Herald added a subscriber: mikhail.ramalho.
Repository:
rC Clang
https://r
Author: dergachev
Date: Wed Jun 13 18:54:21 2018
New Revision: 334683
URL: http://llvm.org/viewvc/llvm-project?rev=334683&view=rev
Log:
[analyzer] Re-enable C++17-specific variable and member construction contexts.
Not contexts themselves, but rather support for them in the analyzer.
Such constr
stephanemoore added a comment.
Are additional approvals needed to land this? I pinged jolesiak earlier this
week asking if he had any comments but have not heard back yet.
(also, once necessary approvals have been granted can I request help from
someone to land it for me? 😇)
Repository:
rC
Author: dergachev
Date: Wed Jun 13 18:40:49 2018
New Revision: 334682
URL: http://llvm.org/viewvc/llvm-project?rev=334682&view=rev
Log:
[analyzer] Track class member initializer constructors path-sensitively.
The reasoning behind this change is similar to the previous commit, r334681.
Because mem
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334682: [analyzer] Track class member initializer
constructors path-sensitively. (authored by dergachev, committed by ).
Herald added a subscriber: mikhail.ramalho.
Repository:
rC Clang
https://reviews
Author: dergachev
Date: Wed Jun 13 18:32:46 2018
New Revision: 334681
URL: http://llvm.org/viewvc/llvm-project?rev=334681&view=rev
Log:
[analyzer] pr37270: Track constructor target region, even if just a variable.
The very idea of construction context implies that first the object is
constructed,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334681: [analyzer] pr37270: Track constructor target region,
even if just a variable. (authored by dergachev, committed by ).
Herald added subscribers: llvm-commits, mikhail.ramalho.
Changed prior to comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334678: [analyzer] NFC: Merge code for finding and tracking
construction target. (authored by dergachev, committed by ).
Herald added a subscriber: mikhail.ramalho.
Repository:
rC Clang
https://reviews
Author: dergachev
Date: Wed Jun 13 18:20:12 2018
New Revision: 334678
URL: http://llvm.org/viewvc/llvm-project?rev=334678&view=rev
Log:
[analyzer] NFC: Merge code for finding and tracking construction target.
When analyzing C++ code, a common operation in the analyzer is to discover
target region
pcc updated this revision to Diff 151282.
pcc added a comment.
- Add some additional driver tests
https://reviews.llvm.org/D48155
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/Driver/ToolChains/Cl
pcc created this revision.
pcc added reviewers: echristo, Bigcheese, rsmith.
By default, we emit an address-significance table on all ELF
targets when the integrated assembler is enabled. The emission of an
address-significance table can be controlled with the -faddrsig and
-fno-addrsig flags.
De
NoQ added a comment.
> P.S. It seems that one of my currently-on-review patches has introduced a
> performance regression, i'm investigating it.
Never mind, that was an old version of the patch, i.e. i accidentally fixed
that regression before uploading the patch to phabricator.
https://revie
NoQ updated this revision to Diff 151279.
NoQ added a comment.
I added an option to disable copy elision on CFG side in
https://reviews.llvm.org/D47616. The analyzer makes use of it automagically:
elided constructors are replaced with temporary constructors in the CFG and the
old behavior is re
NoQ updated this revision to Diff 151277.
NoQ added a comment.
Add a flag to disable copy elision. It's convenient to have such flag in the
CFG because this way all clients will be able to transparently handle it. When
the option is turned off, elided construction contexts will be replaced with
NoQ added inline comments.
Comment at: include/clang/Analysis/ConstructionContext.h:351
+
+ explicit SimpleTemporaryObjectConstructionContext(
+ const CXXBindTemporaryExpr *BTE, const MaterializeTemporaryExpr *MTE)
MTC wrote:
> MTC wrote:
> > `explicit` use
NoQ updated this revision to Diff 151278.
NoQ added a comment.
Herald added a subscriber: mikhail.ramalho.
Rebase.
https://reviews.llvm.org/D47667
Files:
lib/Analysis/ConstructionContext.cpp
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
test/Analysis/auto-obj-dtors-cfg-output.cpp
test/Analy
Author: rsmith
Date: Wed Jun 13 17:40:20 2018
New Revision: 334677
URL: http://llvm.org/viewvc/llvm-project?rev=334677&view=rev
Log:
P0096R5, P0941R2: Update to match latest feature test macro specification.
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor.cpp
cfe/trunk/test/Lexer/cxx-fe
NoQ updated this revision to Diff 151276.
NoQ marked an inline comment as done.
NoQ added a comment.
Herald added a subscriber: mikhail.ramalho.
Fxd.
https://reviews.llvm.org/D47658
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
test/Analysis/lifetime-extension.cpp
test/Analysis/tempora
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:234
+ SVal V = UnknownVal();
+ if (MTE) {
+if (MTE->getStorageDuration() != SD_FullExpression) {
MTC wrote:
> An unrelated question. I want to know, what considerat
Author: stl_msft
Date: Wed Jun 13 17:12:14 2018
New Revision: 334675
URL: http://llvm.org/viewvc/llvm-project?rev=334675&view=rev
Log:
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
MSVC's STL removed _SCL_SECURE_NO_WARNINGS.
MSVC's STL implemented feature-test macros.
Modified:
libc
Author: stl_msft
Date: Wed Jun 13 17:12:20 2018
New Revision: 334676
URL: http://llvm.org/viewvc/llvm-project?rev=334676&view=rev
Log:
[libcxx] [test] Strip trailing whitespace. NFC.
Modified:
libcxx/trunk/test/std/containers/container.adaptors/priority.queue/priqueue.cons/deduct.fail.cpp
Author: rsmith
Date: Wed Jun 13 17:05:28 2018
New Revision: 334674
URL: http://llvm.org/viewvc/llvm-project?rev=334674&view=rev
Log:
[www] Update cxx_status page for Rapperswil motions.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/view
Author: pcc
Date: Wed Jun 13 17:03:41 2018
New Revision: 334673
URL: http://llvm.org/viewvc/llvm-project?rev=334673&view=rev
Log:
Driver: De-duplicate some code. NFCI.
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
http://llvm.or
pcc updated this revision to Diff 151272.
pcc added a comment.
- Add some more documentation to ControlFlowIntegrity.rst
https://reviews.llvm.org/D47567
Files:
clang/docs/ControlFlowIntegrity.rst
clang/docs/LTOVisibility.rst
clang/include/clang/Basic/Sanitizers.def
clang/lib/CodeGen/CGC
Author: pcc
Date: Wed Jun 13 16:21:02 2018
New Revision: 334671
URL: http://llvm.org/viewvc/llvm-project?rev=334671&view=rev
Log:
docs: Add a missing LTO visibility reference.
Modified:
cfe/trunk/docs/ControlFlowIntegrity.rst
Modified: cfe/trunk/docs/ControlFlowIntegrity.rst
URL:
http://llv
Author: pcc
Date: Wed Jun 13 16:18:26 2018
New Revision: 334669
URL: http://llvm.org/viewvc/llvm-project?rev=334669&view=rev
Log:
docs: Correct some misstatements in the control flow integrity docs.
These were true at one point but haven't been true for a long time.
Modified:
cfe/trunk/docs/
morehouse added a comment.
In https://reviews.llvm.org/D48106#1131625, @emmettneyman wrote:
> I wanted to implement the proto_to_llvm converter before the fuzz target.
The fuzz target should make testing your converter way easier. I'd recommend
adding it to this patch so that you're less like
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:32
check::PostCall> {
- CallDescription CStrFn;
+ const llvm::SmallVector CStrFnFamily = {
+{"std::basic_string::c_str"
MarcoFalke updated this revision to Diff 151260.
MarcoFalke edited the summary of this revision.
https://reviews.llvm.org/D48098
Files:
tools/clang-format/clang-format-diff.py
Index: tools/clang-format/clang-format-diff.py
===
--
NoQ added a comment.
For now the tests that i proposed may in fact accidentally work because as far
as i understand you're updating the "variable contains a value returned by
operator new" flag when you encounter assignment operators. The real problems
will arise when the order of the assignmen
NoQ added a comment.
Thanks for adding me!
Hmm, i think a matcher-based solution would be pretty limited. This is
definitely your typical all-path data-flow problem because you want to make
sure that you're looking at the //last// assignment to the variable.
For example:
int *m = new int;
MarcoFalke added a comment.
> why is this switch necessary?
It is not necessary, but would be nice if the script run on python3 as well (as
opposed to only python2, which is going to be deprecated
https://pythonclock.org/)
> what's expected to be supported with it?
I'd assume python2.7 (w
vitalybuka added a comment.
Is this stale?
Repository:
rC Clang
https://reviews.llvm.org/D42043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
In https://reviews.llvm.org/D48036#1131279, @tra wrote:
> Ack.
Patches sent (see dependency chain in phab).
https://reviews.llvm.org/D48036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
jlebar created this revision.
jlebar added reviewers: rsmith, tra.
Herald added a subscriber: llvm-commits.
Repository:
rT test-suite
https://reviews.llvm.org/D48152
Files:
External/CUDA/algorithm.cu
Index: External/CUDA/algorithm.cu
jlebar created this revision.
jlebar added reviewers: rsmith, tra.
Herald added a subscriber: sanjoy.
Tests in a separate change to the test-suite.
https://reviews.llvm.org/D48151
Files:
clang/lib/Headers/cuda_wrappers/algorithm
Index: clang/lib/Headers/cuda_wrappers/algorithm
=
Meinersbur marked 4 inline comments as done.
Meinersbur added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:710-711
Out << "Ua9enable_ifI";
// FIXME: specific_attr_iterator iterates in reverse order. Fix that and
use
// it here.
+for (AttrVec::const_i
rnk added a comment.
In https://reviews.llvm.org/D38680#1123018, @joerg wrote:
> After a careful review of newer GCC / libgcc and the assembler annotations
> from LLVM, I have come to the following conclusions:
>
> (1) The semantics have been somewhat changed by GCC in recent years. There is
>
craig.topper added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D47401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spatel added a comment.
In https://reviews.llvm.org/D48134#1131626, @rsmith wrote:
> Can we mark these as `argmemonly`?
I wasn't aware of that one, but it sounds accurate for nan() and friends:
argmemonly
This attribute indicates that the only memory accesses inside function are
loads a
shuaiwang added a comment.
In https://reviews.llvm.org/D45679#1131115, @aaron.ballman wrote:
> I had to revert due to failing tests. The revert was done in r334606 and this
> is an example of a failing bot:
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/31
shuaiwang updated this revision to Diff 151245.
shuaiwang added a comment.
Add include for std::isspace() (thanks aaron.ballman!)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
Files:
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/ExprMutationAnalyzer.cpp
clang-t
lebedev.ri added a comment.
In https://reviews.llvm.org/D48134#1131626, @rsmith wrote:
> Can we mark these as `argmemonly`?
Header comment in `include/clang/Basic/Builtins.def` does not list that as a
possibility.
Repository:
rL LLVM
https://reviews.llvm.org/D48134
shuaiwang updated this revision to Diff 151244.
shuaiwang added a comment.
Don't include in unit tests, should fix the test failures.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
Files:
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/ExprMutationAnalyzer.cpp
cla
Author: erichkeane
Date: Wed Jun 13 13:47:12 2018
New Revision: 334652
URL: http://llvm.org/viewvc/llvm-project?rev=334652&view=rev
Log:
Simplify test from r334650
No reason to have the 'bool' as an intermediary value,
simply use the fact that curley braces enforce eval order.
Modified:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334650: Implement constexpr __builtin_*_overflow (authored
by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48040?vs=151151&id=1
Author: erichkeane
Date: Wed Jun 13 13:43:27 2018
New Revision: 334650
URL: http://llvm.org/viewvc/llvm-project?rev=334650&view=rev
Log:
Implement constexpr __builtin_*_overflow
As requested here:https://bugs.llvm.org/show_bug.cgi?id=37633
permit the __builtin_*_overflow builtins in constexpr fun
emmettneyman updated this revision to Diff 151240.
emmettneyman added a comment.
- removed typo in emitted llvm insn
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loo
rsmith added a comment.
Can we mark these as `argmemonly`?
Repository:
rL LLVM
https://reviews.llvm.org/D48134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
emmettneyman added a comment.
In https://reviews.llvm.org/D48106#1130581, @morehouse wrote:
> Where is the fuzz target?
I wanted to implement the proto_to_llvm converter before the fuzz target.
Repository:
rC Clang
https://reviews.llvm.org/D48106
emmettneyman updated this revision to Diff 151239.
emmettneyman added a comment.
- refactored loop_proto_to_llvm.cpp
Repository:
rC Clang
https://reviews.llvm.org/D48106
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loo
efriedma added a comment.
Oh, sorry, I mixed up the two values. I meant that you should add a couple
testcases to ensure the stored value is correct on overflow.
https://reviews.llvm.org/D48040
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334639: [COFF] Add ARM64 intrinsics: __yield, __wfe, __wfi,
__sev, __sevl (authored by mgrang, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
Author: mgrang
Date: Wed Jun 13 11:49:35 2018
New Revision: 334639
URL: http://llvm.org/viewvc/llvm-project?rev=334639&view=rev
Log:
[COFF] Add ARM64 intrinsics: __yield, __wfe, __wfi, __sev, __sevl
Summary: These intrinsics result in hint instructions. They are provided here
for MSVC ARM64 comp
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
erichkeane added a comment.
I believe my tests DO validate the return value correctly, don't they? It uses
a sentinel, but the ternary should check that return value, right?
Or is there an obvious thing I'm missing?
https://reviews.llvm.org/D48040
__
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
I'd like to see a couple of testcases ensuring the return value is correct on
overflow (we had a problem with that for __builtin_mul_overflow in the past).
Otherwise LGTM.
https://review
Author: george.karpenkov
Date: Wed Jun 13 11:32:19 2018
New Revision: 334636
URL: http://llvm.org/viewvc/llvm-project?rev=334636&view=rev
Log:
[analyzer] Fix offset overflow check in MemRegion
rdar://39593879
https://bugs.llvm.org/show_bug.cgi?id=37142
Differential Revision: https://reviews.llvm
Meinersbur updated this revision to Diff 151209.
Meinersbur added a comment.
- Remove obsolete comment
- Refactor getOrderedEnableIfAttrs
Repository:
rC Clang
https://reviews.llvm.org/D48100
Files:
include/clang/Sema/AttributeList.h
lib/AST/ItaniumMangle.cpp
lib/Parse/ParseDecl.cpp
l
ormris added a comment.
Thanks @george.karpenkov . I was wondering why it didn't close automatically.
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
spatel added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10107-10112
+case 0x0b: // FALSE_OQ
+case 0x1b: // FALSE_OS
+ return llvm::Constant::getNullValue(ConvertType(E->getType()));
+case 0x0f: // TRUE_UQ
+case 0x1f: // TRUE_US
+ return llvm:
george.karpenkov added a comment.
> This change has been committed, so I'm closing this review.
@ormris The process which should be followed here is to add a line (exactly)
"Differential Revision: https://reviews.llvm.org/D47044"; to the bottom of your
commit message, so that the phabricator ca
GBuella updated this revision to Diff 151203.
GBuella edited the summary of this revision.
GBuella added a comment.
Ignoring signaling behviour - and rounding mode with it.
Also lowering `__builtin_ia32_cmpsd` and `__builtin_ia32_cmpss`.
https://reviews.llvm.org/D45616
Files:
lib/CodeGen/CGBu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334628: [CodeGen] make nan builtins pure rather than const
(PR37778) (authored by spatel, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4813
Author: spatel
Date: Wed Jun 13 10:54:52 2018
New Revision: 334628
URL: http://llvm.org/viewvc/llvm-project?rev=334628&view=rev
Log:
[CodeGen] make nan builtins pure rather than const (PR37778)
https://bugs.llvm.org/show_bug.cgi?id=37778
...shows a miscompile resulting from marking nan builtins a
leonardchan added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:89
+ // corresponding unsaturated types.
+ unsigned char ShortAccumFBits, ShortAccumIBits;
+ unsigned char AccumFBits, AccumIBits;
ebevhan wrote:
> leonardchan wrote:
> > ebevhan w
craig.topper added a comment.
FWIW, I found a cfe-dev thread about adding HLE support
http://lists.llvm.org/pipermail/cfe-dev/2013-February/028031.html And a bunch
of dead patches in phabricator https://reviews.llvm.org/people/revisions/110/
I also spoke to Andi Kleen here at Intel to make sure
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Makes sense.
https://reviews.llvm.org/D48134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
GBuella added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10090-10100
+// _CMP_TRUE_UQ, _CMP_TRUE_US produce -1,-1... vector
+// on any input and _CMP_FALSE_OQ, _CMP_FALSE_OS produce 0, 0...
+if (CC == 0xf || CC == 0xb || CC == 0x1b || CC == 0x1f) {
+
Author: tstellar
Date: Wed Jun 13 09:57:18 2018
New Revision: 334621
URL: http://llvm.org/viewvc/llvm-project?rev=334621&view=rev
Log:
Merging r323390:
r323390 | ericwf | 2018-01-24 16:02:48 -0800 (Wed, 24 Jan 2018) | 9 line
ormris closed this revision.
ormris added a comment.
This change has been committed, so I'm closing this review.
https://reviews.llvm.org/rC334554
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@list
tra added a comment.
Ack.
https://reviews.llvm.org/D48036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spatel created this revision.
spatel added reviewers: gfalcon, lebedev.ri.
Herald added a subscriber: mcrosier.
https://bugs.llvm.org/show_bug.cgi?id=37778
...shows a miscompile resulting from marking nan builtins as 'const'.
The nan libcalls/builtins take a pointer argument:
http://www.cplusplus
jlebar added a comment.
> Last comment in the bug pointed out that those overloads should be constexpr
> in c++14. Maybe in a separate patch, though.
Yeah, would prefer to do it in a separate patch. It's possible that having
constexpr min/max in C++14 mode *without a C++14 standard library* wi
Author: d0k
Date: Wed Jun 13 09:45:12 2018
New Revision: 334619
URL: http://llvm.org/viewvc/llvm-project?rev=334619&view=rev
Log:
[Basic] Fix -Wreorder warning
Just use field initializers that don't suffer from this problem
Modified:
cfe/trunk/lib/Basic/Targets/PPC.h
Modified: cfe/trunk/lib
baloghadamsoftware added a comment.
Herald added a subscriber: mikhail.ramalho.
Any idea how to proceed?
https://reviews.llvm.org/D35110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rkirsling added a comment.
I'll need someone to commit. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:32
check::PostCall> {
- CallDescription CStrFn;
+ const llvm::SmallVector CStrFnFamily = {
+{"std::basic_string::
mgrang created this revision.
mgrang added reviewers: mstorsjo, compnerd.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
These intrinsics result in hint instructions. They are provided here for MSVC
ARM64 compatibility.
Repository:
rC Clang
https://revi
leonardchan added inline comments.
Comment at: test/Frontend/fixed_point_bit_widths.c:44
+
+// CHECK-NEXT: @size_SsF = dso_local global i{{[0-9]+}} 2
+// CHECK-NEXT: @size_SF = dso_local global i{{[0-9]+}} 4
ebevhan wrote:
> Wait; should these dso_local be `{{
leonardchan updated this revision to Diff 151184.
leonardchan marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D46911
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/Type.h
include/clang/Basic/DiagnosticSemaKinds
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334613: [PowerPC] The __float128 type should only be
available on Power9 (authored by stefanp, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D480
Author: stefanp
Date: Wed Jun 13 09:05:05 2018
New Revision: 334613
URL: http://llvm.org/viewvc/llvm-project?rev=334613&view=rev
Log:
[PowerPC] The __float128 type should only be available on Power9
Diasble the use of the type __float128 for PPC machines older
than Power9.
The use of -mfloat128
Author: morehouse
Date: Wed Jun 13 09:00:39 2018
New Revision: 334612
URL: http://llvm.org/viewvc/llvm-project?rev=334612&view=rev
Log:
[libclang] Make c-index-test.c ISO C90 compliant.
Fixes a build bot breakage caused by r334593.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modif
ebevhan added inline comments.
Comment at: lib/AST/ExprConstant.cpp:9437
+ }
+ return Success(-Value, E);
+}
This looks very suspect to me as well... This might not respect padding on
types whose sign bit is not the MSB, such as _Fract. The same go
aaron.ballman reopened this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I had to revert due to failing tests. The revert was done in r334606 and this
is an example of a failing bot:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubu
ioeric updated this revision to Diff 151172.
ioeric added a comment.
- Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47935
Files:
clangd/CodeComplete.cpp
clangd/FindSymbols.cpp
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
unittests
Author: aaronballman
Date: Wed Jun 13 08:02:34 2018
New Revision: 334606
URL: http://llvm.org/viewvc/llvm-project?rev=334606&view=rev
Log:
Reverting r334604 due to failing tests.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/31500
Removed:
clang-tools-ex
ioeric added a comment.
In https://reviews.llvm.org/D47935#1129987, @sammccall wrote:
> Sorry for the delay on this change. There's a bunch of complexity in this
> problem that I haven't seen how to slice through:
>
> 1. the signals needed seem like a weird fit for the Symbol*Signals structs
>
ioeric updated this revision to Diff 151169.
ioeric added a comment.
- Introduced a one-per-query structure for relevance signals; use
multiplication for proximity; simplify tests a bit; separate index and sema
proximity scores.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D4
takuto.ikuta added a comment.
Thank you!
https://reviews.llvm.org/D47578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MTC updated this revision to Diff 151166.
MTC added a comment.
- Use `hasName` matcher to match the qualified name.
- Use the full name, like `std::basic_string::c_str` instead of `c_str`
to match the `c_str` method in `DanglingInternalBufferChecker.cpp`.
Repository:
rC Clang
https://revie
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r334604 with one minor change -- I added an include for
to the unit test so that `std::isspace()` would compile properly on all
platforms.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
Author: aaronballman
Date: Wed Jun 13 07:41:42 2018
New Revision: 334604
URL: http://llvm.org/viewvc/llvm-project?rev=334604&view=rev
Log:
Add a new class to analyze whether an expression is mutated within a statement.
ExprMutationAnalyzer is a generally useful helper that can be used in differen
1 - 100 of 147 matches
Mail list logo
