r332213 - [X86] Use select instrution and fpextend in the implementation of _mm512_mask_cvtps_pd and _mm512_maskz_cvtps_pd.

Author: ctopper Date: Sun May 13 21:57:46 2018 New Revision: 332213 URL: http://llvm.org/viewvc/llvm-project?rev=332213&view=rev Log: [X86] Use select instrution and fpextend in the implementation of _mm512_mask_cvtps_pd and _mm512_maskz_cvtps_pd. Modified: cfe/trunk/lib/Headers/avx512fintri

r332210 - [X86] Use __builtin_convertvector to implement _mm512_cvtps_pd.

Author: ctopper Date: Sun May 13 21:05:06 2018 New Revision: 332210 URL: http://llvm.org/viewvc/llvm-project?rev=332210&view=rev Log: [X86] Use __builtin_convertvector to implement _mm512_cvtps_pd. If we're using default rounding mode we can let __builtin_convertvector to generate an fpextend. T

[PATCH] D46742: [X86] Use __builtin_convertvector to replace some of the avx512 truncate builtins.

craig.topper added a comment. Yeah the others will need codegen work. So I'm starting with the easy cases. Repository: rC Clang https://reviews.llvm.org/D46742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

kito-cheng added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:130 + // which may override the defaults. + handleTargetFeaturesGroup(Args, Features, options::OPT_m_riscv_Features_Group); } This part should move to the begin of the functio

r332203 - [X86] Emit better code for _mm_cvtu32_sd, _mm_cvtu64_sd, _mm_cvtu32_ss, and _mm_cvtu64_ss.

Author: ctopper Date: Sun May 13 16:03:30 2018 New Revision: 332203 URL: http://llvm.org/viewvc/llvm-project?rev=332203&view=rev Log: [X86] Emit better code for _mm_cvtu32_sd, _mm_cvtu64_sd, _mm_cvtu32_ss, and _mm_cvtu64_ss. We can use direct C code for these that will use uitofp and inserteleme

[PATCH] D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions.

shuaiwang updated this revision to Diff 146532. shuaiwang marked 3 inline comments as done. shuaiwang added a comment. Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45702 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/Readabi

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

shuaiwang updated this revision to Diff 146531. shuaiwang marked 3 inline comments as done. shuaiwang added a comment. Handle unevaluated expressions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45679 Files: clang-tidy/utils/CMakeLists.txt clang-tidy/utils/ExprMutationAn

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

rsmith added inline comments. Comment at: lib/Sema/SemaType.cpp:7604-7608 + // When instantiating a class template and reaching an atomic type, the check + // for type completeness should occur on the underlying type and not the + // atomic type itself (which is always incompl

[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:566-567 -def Alias : Attr { +// We do not support alias attribute on Apple platform, so we exclude the platform. +def Alias : Attr, TargetSpecificAttr { let Spellings = [GCC<"alias">]; Is

[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

aaron.ballman added a comment. Thank you for working on this patch -- be sure to add tests that ensure the attribute is properly prohibited on the expected targets. Comment at: include/clang/Basic/Attr.td:299-300 list ObjectFormats; + // It indicates that a certain attribu

[PATCH] D46639: [CodeComplete] Provide completion in decls even for incomplete types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D46639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D45093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few minor nits to be fixed. Comment at: clang-tidy/readability/SimplifySubscriptExprCheck.cpp:53-54 + const auto *Call = Result.Nodes.getNodeAs("ca

[PATCH] D45835: Add new driver mode for dumping compiler options

lebedev.ri added inline comments. Comment at: lib/Frontend/FrontendActions.cpp:779 + { +std::string Str; +#define FEATURE(Name, Predicate) \ aaron.ballman wrote: > lebedev.ri wrote: > > This is likely to do an a

[PATCH] D45835: Add new driver mode for dumping compiler options

aaron.ballman added inline comments. Comment at: lib/Frontend/FrontendActions.cpp:779 + { +std::string Str; +#define FEATURE(Name, Predicate) \ lebedev.ri wrote: > This is likely to do an allocation for each fea

[PATCH] D45835: Add new driver mode for dumping compiler options

aaron.ballman updated this revision to Diff 146529. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. https://reviews.llvm.org/D45835 Files: include/clang/Basic/Features.def include/clang/Driver/CC1Options.td include/clang/Fro

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: test/SemaCXX/atomic-type.cpp:5 template struct atomic { - _Atomic(T) value; + _Atomic(T) value; // expected-error {{field has incomplete type '_Atomic(user::inner)'}} --

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman updated this revision to Diff 146524. aaron.ballman added a comment. Look through atomic types when checking type completeness during template instantiation. https://reviews.llvm.org/D46112 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Type.cpp lib/Sema/SemaChec

[PATCH] D46807: Rename test_memory_resource.hpp -> test_experimental_memory_resource.hpp. NFC.

Quuxplusone created this revision. Quuxplusone added reviewers: EricWF, mclow.lists. Herald added subscribers: cfe-commits, christof. This makes room for a new "test_memory_resource.hpp", very similar to the old one, but testing the C++17 header instead of the experimental header. Repository:

[PATCH] D46806: Remove unused code from __functional_base. NFC.

Quuxplusone created this revision. Quuxplusone added a reviewer: EricWF. Herald added a subscriber: cfe-commits. `__user_alloc_construct_impl` is used by , but this `__user_alloc_construct` is never used. Repository: rCXX libc++ https://reviews.llvm.org/D46806 Files: include/__functional_

[PATCH] D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions.

shuaiwang updated this revision to Diff 146514. shuaiwang marked 10 inline comments as done. shuaiwang added a comment. Rename to readability-simplify-subscript-expr and addressed other comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45702 Files: clang-tidy/readabili

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice updated this revision to Diff 146513. mikerice added a comment. Added warning when macro is defined when skipping. Also fixed skipping so directives are completely ignored expect for #include and #define. https://reviews.llvm.org/D46652 Files: include/clang/Basic/DiagnosticLexKinds

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

mikerice added a comment. Thanks for taking a look at the patch. I added a warning as suggested. I also fixed skipping so it ignores all directives except #include and now #define. Repository: rC Clang https://reviews.llvm.org/D46652 ___ cfe-co

[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

lebedev.ri added a comment. 1. Please always upload all patches with full context. 2. tests? Repository: rC Clang https://reviews.llvm.org/D46805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

HLJ2009 created this revision. HLJ2009 added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. I tested the alias attribute on my own Apple laptop (Target: x86_64-apple-darwin17.5.0). First, I use __has_attribute to test that the alias is usable or not. The test code is as follo

[PATCH] D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages.

EricWF updated this revision to Diff 146508. EricWF marked an inline comment as done. EricWF added a comment. Misc cleanups. - proof read and correct documentation. https://reviews.llvm.org/D46740 Files: docs/InternalsManual.rst include/clang/Basic/Diagnostic.td include/clang/Basic/Diagn

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL332193: Added atomic_fetch_min, max, umin, umax intrinsics to clang. (authored by delena, committed by ). Changed prior to commit: https://reviews.llvm.org/D46386?vs=146462&id=146502#toc Repository:

r332193 - Added atomic_fetch_min, max, umin, umax intrinsics to clang.

Author: delena Date: Sun May 13 00:45:58 2018 New Revision: 332193 URL: http://llvm.org/viewvc/llvm-project?rev=332193&view=rev Log: Added atomic_fetch_min, max, umin, umax intrinsics to clang. These intrinsics work exactly as all other atomic_fetch_* intrinsics and allow to create *atomicrmw* w