This revision was automatically updated to reflect the committed changes.
Closed by commit rC331740: [x86] Introduce the pconfig intrinsic (authored by
GBuella, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46431
Files:
include/clang/Driver/Options.td
lib/Basic/Targets/X8
Author: gbuella
Date: Mon May 7 23:49:41 2018
New Revision: 331740
URL: http://llvm.org/viewvc/llvm-project?rev=331740&view=rev
Log:
[x86] Introduce the pconfig intrinsic
Reviewers: craig.topper, zvi
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D46431
Added:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331740: [x86] Introduce the pconfig intrinsic (authored by
GBuella, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46431?vs=145207&id=145634#
nik added a comment.
OK, the issue with the test dependencies I've had is resolved by
https://reviews.llvm.org/D46514
https://reviews.llvm.org/D46050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
jfb requested changes to this revision.
jfb added a comment.
This revision now requires changes to proceed.
Given http://wg21.link/p0418 I think this requires an update. I don't think the
old behavior is worth supporting in older `-std=` versions, unless we're
worried that it would make code les
jfb added a comment.
Herald added subscribers: christof, aheejin.
In https://reviews.llvm.org/D23041#632708, @EricWF wrote:
> Have you filed a bug against GCC regarding its current behavior?
>
> Also it seems like a bad idea to add `-fabi-version=6`, since it selects an
> older ABI version and n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331717: [CMake] Pass additional CMake flags in Fuchsia cache
files (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45997?
Author: phosek
Date: Mon May 7 19:47:13 2018
New Revision: 331717
URL: http://llvm.org/viewvc/llvm-project?rev=331717&view=rev
Log:
[CMake] Pass additional CMake flags in Fuchsia cache files
This allows passing additional CMake flags to builtins and runtimes
build through Fuchsia cache files.
D
Author: ericwf
Date: Mon May 7 19:28:47 2018
New Revision: 331713
URL: http://llvm.org/viewvc/llvm-project?rev=331713&view=rev
Log:
[C++2a] operator<=>: Fix incorrect use of Twine.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
URL:
http://llvm.or
Author: ericwf
Date: Mon May 7 17:52:19 2018
New Revision: 331707
URL: http://llvm.org/viewvc/llvm-project?rev=331707&view=rev
Log:
[C++2a] Implement operator<=>: Address bugs and post-commit review comments
after r331677.
This patch addresses some mostly trivial post-commit review comments rec
Author: rtrieu
Date: Mon May 7 17:29:21 2018
New Revision: 331706
URL: http://llvm.org/viewvc/llvm-project?rev=331706&view=rev
Log:
Move test input file into same directory as test. NFC
Added:
cfe/trunk/test/Frontend/Inputs/resource_dir_with_cfi_blacklist/
cfe/trunk/test/Frontend/Inputs
Hello everyone,
Below are some buildbot numbers for the week of 4/22/2018 - 4/28/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
Hello everyone,
Below are some buildbot numbers for the last week of 4/29/2018 - 5/5/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Author: ericwf
Date: Mon May 7 16:15:34 2018
New Revision: 331697
URL: http://llvm.org/viewvc/llvm-project?rev=331697&view=rev
Log:
Fix failing codegen test on non-x86_64 platforms
Modified:
cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp
Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp
UR
Author: rsmith
Date: Mon May 7 15:23:38 2018
New Revision: 331692
URL: http://llvm.org/viewvc/llvm-project?rev=331692&view=rev
Log:
PR37352: mangle numbering for decomposition declarations.
In order to match our mangling scheme, use a different set of numbers for
decomposition declarations, and
Author: erichkeane
Date: Mon May 7 15:01:06 2018
New Revision: 331688
URL: http://llvm.org/viewvc/llvm-project?rev=331688&view=rev
Log:
[NFC] Move 2 variable initialization from Ctor to member initializers.
In response to dblaikie's suggestion on r331536, replace the two enum
typed variable init
craig.topper added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:2271
+static bool hasRequiredFeature(StringRef Feature,
+ llvm::StringMap& CallerFeatureMap,
+ std::string &Missing) {
'&'
arichardson accepted this revision.
arichardson added a comment.
I recently made this change for the CHERI clang fork and as far as I can tell
everything works fine.
https://reviews.llvm.org/D24867
___
cfe-commits mailing list
cfe-commits@lists.llv
On Mon, May 7, 2018 at 12:57 PM Keane, Erich wrote:
> I don’t believe the member initialization for bitfields (of which all the
> ‘0’ values are) happened until C++17, right?
>
Ah, fair point - I hadn't looked at the types, just what was visible in the
patch. (& I don't especially know/recall wh
Author: ctopper
Date: Mon May 7 14:47:13 2018
New Revision: 331683
URL: http://llvm.org/viewvc/llvm-project?rev=331683&view=rev
Log:
[X86] Use target feature defines in tests instead of defining our own flag on
the command line. NFCI
Modified:
cfe/trunk/test/CodeGen/gfni-builtins.c
cfe/
Author: ctopper
Date: Mon May 7 14:47:11 2018
New Revision: 331682
URL: http://llvm.org/viewvc/llvm-project?rev=331682&view=rev
Log:
[X86] Make _mm256_gf2p8mul_epi8 require avx features since its 256 bits.
Without this we throw an error on the header file instead of the user code when
the right
Author: pcc
Date: Mon May 7 14:40:53 2018
New Revision: 331681
URL: http://llvm.org/viewvc/llvm-project?rev=331681&view=rev
Log:
Relax a FileCheck pattern to make it pass on Windows.
Should fix Windows bot failure:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fas
bob.wilson added a comment.
Previous review (for the swift-llvm GitHub repo):
https://github.com/apple/swift-clang/pull/167
Repository:
rC Clang
https://reviews.llvm.org/D46550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
rjmccall added a comment.
Thanks, the comments help a lot.
Comment at: lib/CodeGen/CGObjCGNU.cpp:439
+ ArrayRef IvarOffsets,
+ ArrayRef IvarAlign,
+ ArrayRef IvarOwnership);
the
bob.wilson created this revision.
bob.wilson added a reviewer: aschwaighofer.
Herald added subscribers: kbarton, nemanjai, mcrosier.
This adds basic support for the Swift calling convention with PPC64 targets.
Patch provided by Atul Sowani in bug report #37223
Repository:
rC Clang
https://rev
juliehockett updated this revision to Diff 145547.
juliehockett marked 9 inline comments as done.
juliehockett edited the summary of this revision.
juliehockett added a comment.
Sorry for the delay in updating this -- check now restricts includes to a
whitelist, rather than a blacklist, and only
juliehockett added inline comments.
Comment at: clang-tidy/fuchsia/RestrictIncludesCheck.cpp:75
+for (const auto &Include : FileDirectives) {
+ auto D = Check.diag(Include.Loc, "restricted include found");
+
aaron.ballman wrote:
> I believe this check wi
rsmith added inline comments.
Comment at: include/clang/AST/ASTContext.h:1983
+ /// \brief Types and expressions required to build C++2a three-way
comparisons
+ /// using operator<=>, including the values return by builtin <=>
operators.
+ ComparisonCategories CompCategori
jdenny added a comment.
In https://reviews.llvm.org/D45093#1090292, @rsmith wrote:
> If you want to force a particular printing policy to be used for
> `-ast-print`, I think it would be better to change the `print` call in
> `lib/Frontend/ASTConsumers.cpp` to pass your desired printing policy,
jfb added a comment.
In https://reviews.llvm.org/D42933#1090286, @smeenai wrote:
> Note that the alignment matters in addition to the size.
Sure, but AFAICT from `./lib/Basic/Targets/*` the alignment is also specified
properly, is it not?
> The pattern I've seen internally is people using `%z
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331674: [CFI] Force LLVM to die if the implicit blacklist
files cannot be found. (authored by pcc, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46403
Files:
lib/Driver/SanitizerArg
Author: pcc
Date: Mon May 7 13:54:05 2018
New Revision: 331674
URL: http://llvm.org/viewvc/llvm-project?rev=331674&view=rev
Log:
[CFI] Force LLVM to die if the implicit blacklist files cannot be found.
Currently LLVM CFI tries to use an implicit blacklist file, currently
in /usr/lib64/clang//sha
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331673: Correct warning on Float->Integer conversions.
(authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46535?vs=145536&id=145542#toc
Repository:
rC Clang
Author: erichkeane
Date: Mon May 7 13:52:56 2018
New Revision: 331673
URL: http://llvm.org/viewvc/llvm-project?rev=331673&view=rev
Log:
Correct warning on Float->Integer conversions.
As identified and briefly discussed here:
https://bugs.llvm.org/show_bug.cgi?id=37305
Converting a floating poin
pcc accepted this revision.
pcc added a comment.
LGTM
https://reviews.llvm.org/D46403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cmtice updated this revision to Diff 145540.
cmtice added a comment.
Make cfi_blacklist.txt be an empty file.
https://reviews.llvm.org/D46403
Files:
lib/Driver/SanitizerArgs.cpp
test/Driver/Inputs/resource_dir_with_cfi_blacklist/share/cfi_blacklist.txt
test/Driver/fsanitize-blacklist.c
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D46535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
cmtice updated this revision to Diff 145537.
cmtice added a comment.
Make -resource-dir point to correct directory, in test case; move
cfi_blacklist.txt file to 'share' subdirectory in test resource dir.
https://reviews.llvm.org/D46403
Files:
lib/Driver/SanitizerArgs.cpp
test/Driver/Inputs
erichkeane updated this revision to Diff 145536.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Aaron's comments :)
https://reviews.llvm.org/D46535
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaCXX/coroutines.cpp
test/Sema
aaron.ballman edited reviewers, added: probinson; removed: void.
aaron.ballman added a subscriber: probinson.
aaron.ballman added a comment.
Adding in @probinson as he originally added the `optnone` attribute. Paul, do
you recall why you opted (haha, pun totally intended) to implement `optnone`
erichkeane marked 2 inline comments as done.
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:9440-9441
+diag::warn_impcast_literal_float_to_integer_out_of_range);
+ if (IntegerValue.isUnsigned() &&
+ (IntegerValue.isMaxValue() ||
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331666: [Driver] Use -fuse-line-directives by default in
MSVC mode (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4652
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331666: [Driver] Use -fuse-line-directives by default in
MSVC mode (authored by mstorsjo, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46520?vs=145446&id=145528#toc
Repository:
Author: mstorsjo
Date: Mon May 7 13:26:09 2018
New Revision: 331666
URL: http://llvm.org/viewvc/llvm-project?rev=331666&view=rev
Log:
[Driver] Use -fuse-line-directives by default in MSVC mode
Don't use the GNU extension form of line markers in MSVC mode.
Differential Revision: https://reviews.
rsmith added a comment.
If you want to force a particular printing policy to be used for `-ast-print`,
I think it would be better to change the `print` call in
`lib/Frontend/ASTConsumers.cpp` to pass your desired printing policy, rather
than changing other components to prevent them from changi
pcc added inline comments.
Comment at: test/Frontend/dependency-gen.c:24
// RUN: echo "fun:foo" > %t.blacklist
-// RUN: %clang -MD -MF - %s -fsyntax-only -fsanitize=cfi-vcall -flto
-fvisibility=hidden -fsanitize-blacklist=%t.blacklist -I ./ | FileCheck
-check-prefix=CHECK-SEVE
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:9432
if (IsLiteral) {
+// Conversion of a floating point value to a non-bool integer where the
+// integral part cannot be represented by the integer type is undefined.
floating
cmtice added a comment.
I'm not sure if I have commit access or not; Peter was working with me on
trying to commit the change.
https://reviews.llvm.org/D46403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
smeenai added a comment.
Note that the alignment matters in addition to the size.
The pattern I've seen internally is people using `%zd` for NSInteger and `%tu`
for NSUInteger, since until clang 6 neither of those were format-checked at all.
I'd be fine with adding an option to relax the printf
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/RedundantDataCallCheck.cpp:45
+ anyOf(TypesMatcher, pointerType(pointee(TypesMatcher)),
+ callee(namedDecl(hasName("data"
+ .bind("call",
---
vsk added a comment.
Do you have commit access? If not I'd be happy to land this for you.
Comment at:
test/Driver/Inputs/resource_dir_with_cfi_blacklist/cfi_blacklist.txt:19
+# in order to call std::allocator_traits::construct.
+fun:_ZNSt23_Sp_counted_ptr_inplace*
cmtice updated this revision to Diff 145524.
cmtice added a comment.
Fix test failure that my previous changes caused.
https://reviews.llvm.org/D46403
Files:
lib/Driver/SanitizerArgs.cpp
test/Driver/Inputs/resource_dir_with_cfi_blacklist/cfi_blacklist.txt
test/Driver/fsanitize-blacklist.c
brooks accepted this revision.
brooks added a comment.
I do think we should make this change, but don't have a strong opinion on the
timing. If we do it for 12 and not 13 then we should probably try to get it
into a 6.0.2.
https://reviews.llvm.org/D24867
___
jfb added a comment.
Herald added a reviewer: javed.absar.
I was just looking at this, and I think @arphaman's patch is pretty much the
right approach (with 2 suggested fixes below).
I don't think the code we're currently warning on is broken: a user code has
`NSInteger` with `%zd` or `NSUInteg
I don’t believe the member initialization for bitfields (of which all the ‘0’
values are) happened until C++17, right? I could definitely member initialize
the two enum fields though.
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Monday, May 7, 2018 12:03 PM
To: Keane, Erich
Cc: cfe-co
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Fine, that works.
https://reviews.llvm.org/D45476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
manojgupta added inline comments.
Comment at: include/clang/Basic/Attr.td:1494
+def NoStackProtector : InheritableAttr {
+ let Spellings = [GCC<"no_stack_protector">];
+ let Subjects = SubjectList<[Function]>;
aaron.ballman wrote:
> This is not a GCC attribute,
rkirsling added a comment.
Any further commentary? :)
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jdenny added a comment.
In https://reviews.llvm.org/D45093#1087652, @aaron.ballman wrote:
> This approach generally looks good to me, but I'd like @rsmith's opinion on
> whether we should be trying to make -ast-print have good source fidelity or
> not. I was under the impression we wanted -ast-
manojgupta updated this revision to Diff 145514.
manojgupta added a comment.
Added docs, Sema test case for the attribute.
Repository:
rC Clang
https://reviews.llvm.org/D46300
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CodeGenModule.cpp
lib/Sema/Se
Perhaps this should use non-static data member initializers instead?
On Fri, May 4, 2018 at 9:23 AM Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Fri May 4 09:19:53 2018
> New Revision: 331536
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331536
Author: marshall
Date: Mon May 7 11:59:04 2018
New Revision: 331661
URL: http://llvm.org/viewvc/llvm-project?rev=331661&view=rev
Log:
Status updates for Rapperswil
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/
dim added a comment.
Brooks, I can commit this if you prefer. Maybe it can go into 6.0.2 still...
https://reviews.llvm.org/D24867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella created this revision.
GBuella added reviewers: craig.topper, echristo, dblaikie.
Herald added a subscriber: cfe-commits.
When requirement imposed by __target__ attributes on functions
are not satisfied, prefer printing those requirements, which
are explicitly mentioned in the attributes.
It looks like this commit has introduced an assertion failure. See
https://bugs.llvm.org/show_bug.cgi?id=37357.
On Fri, May 4, 2018 at 10:56 PM Artem Dergachev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dergachev
> Date: Fri May 4 13:52:39 2018
> New Revision: 331556
>
> URL:
GBuella created this revision.
GBuella added a reviewer: craig.topper.
Herald added subscribers: cfe-commits, mgorny.
Repository:
rC Clang
https://reviews.llvm.org/D46540
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
include/clang/Driver/Options.td
l
EricWF added inline comments.
Comment at: lib/AST/ExprConstant.cpp:8829
+ return EvaluateComparisonBinaryOperator(Info, E, OnSuccess, [&]() {
+return ExprEvaluatorBaseTy::VisitBinaryOperator(E);
+ });
rsmith wrote:
> EricWF wrote:
> > rsmith wrote:
> > > It
shuaiwang added inline comments.
Comment at: clang-tidy/readability/RedundantDataCallCheck.cpp:45
+ anyOf(TypesMatcher, pointerType(pointee(TypesMatcher)),
+ callee(namedDecl(hasName("data"
+ .bind("call",
aa
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprAgg.cpp:964
+RHS = CGF.EmitAnyExpr(E->getRHS()).getAggregatePointer();
+break;
+ case TEK_Complex:
EricWF wrote:
> EricWF wrote:
> > rjmccall wrote:
> > > It looks like we don't actually suppo
Author: abataev
Date: Mon May 7 10:38:13 2018
New Revision: 331654
URL: http://llvm.org/viewvc/llvm-project?rev=331654&view=rev
Log:
[OPENMP, NVPTX] Small test fix, NFC.
Modified:
cfe/trunk/test/OpenMP/nvptx_parallel_codegen.cpp
Modified: cfe/trunk/test/OpenMP/nvptx_parallel_codegen.cpp
URL
juliehockett added inline comments.
Comment at: clang-doc/Representation.cpp:53
+ move(Namespace, std::move(Other.Namespace));
+ extend(Description, std::move(Other.Description));
+ return true;
sammccall wrote:
> is plain concatenation of comments what you wa
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1403
+ if (auto *IL = dyn_cast_or_null(Init)) {
+if (InitTy->isConstantArrayType()) {
+ for (auto I : IL->inits())
sepavloff wrote:
> rjmccall wrote:
> > Do you actually care if
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D46471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: abataev
Date: Mon May 7 10:23:05 2018
New Revision: 331652
URL: http://llvm.org/viewvc/llvm-project?rev=331652&view=rev
Log:
[OPENMP, NVPTX] Codegen for critical construct.
Added correct codegen for the critical construct on NVPTX devices.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRun
a.sidorin added a comment.
Sorry, two more nits.
Comment at: include/clang/AST/ASTImporter.h:137
+///
+/// \returns the equivalent attribute in the "to" context, or NULL if an
+/// error occurred.
nullptr
Comment at: lib/AST/ASTIm
a.sidorin added a comment.
Hi Rafael! Please find my comments inline.
Comment at: lib/AST/ASTImporter.cpp:2650
+ for (const auto *A : D->attrs())
+ToIndirectField->addAttr(Importer.Import(const_cast(A)));
Could we just remove 'const' qualifier from `A` t
erichkeane abandoned this revision.
erichkeane added a comment.
Did Review-after-commit, in retrospect this is a pretty tiny change.
https://reviews.llvm.org/D42664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: erichkeane
Date: Mon May 7 10:05:20 2018
New Revision: 331651
URL: http://llvm.org/viewvc/llvm-project?rev=331651&view=rev
Log:
Fix explicit template parameter reporting for narrowing conversions
I found that explicit template parameters that caused a
narrowing integer conversion resulte
erichkeane created this revision.
erichkeane added reviewers: aaron.ballman, spatel, RKSimon.
As identified and briefly discussed here:
https://bugs.llvm.org/show_bug.cgi?id=37305
Converting a floating point number to an integer type when
the integral part is out of the range of the integer type
r.stahl updated this revision to Diff 145486.
r.stahl edited the summary of this revision.
r.stahl added a comment.
full patch with test
https://reviews.llvm.org/D46115
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
test/Import/attr/Inputs/S.cpp
test/Import/attr/test.cpp
Author: jgalenson
Date: Mon May 7 09:23:46 2018
New Revision: 331644
URL: http://llvm.org/viewvc/llvm-project?rev=331644&view=rev
Log:
[docs] Fix typos in the Clang User's Manual.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/
yaxunl updated this revision to Diff 145480.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Rename variables used for CUDA only.
https://reviews.llvm.org/D46472
Files:
include/clang/Driver/Options.td
lib/CodeGen/CGCUDANV.cpp
lib/Driver/ToolChains/CommonArgs.cpp
lib/Dri
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:909
+
+auto QualScore = Quality.evaluate(), RelScore = Relevance.evaluate();
+CompletionItemScores Scores;
ilya-biryukov wrote:
> NIT: Maybe use `float` here instead of auto? Would remov
sammccall updated this revision to Diff 145478.
sammccall marked 9 inline comments as done.
sammccall added a comment.
Address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46524
Files:
clang-move/ClangMove.cpp
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagno
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:317
+ if (GpuBinaryFileName.empty() && !IsHIP)
return nullptr;
rjmccall wrote:
> Is this filename string only used for CUDA? If so, please rename
yaxunl updated this revision to Diff 145472.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Updated comments.
https://reviews.llvm.org/D46471
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Compilation.cpp
lib/Driver/ToolChains/Clang.cpp
Index: l
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/Compilation.cpp:201
+ // not compiled again if there are already failures. It is OK to abort the
+ // CUDA pipeline on errors.
+ if (A->isOffloading(Action::OFK_Cuda) || A->isOffloadi
yaxunl added a comment.
Only halfn type requires cl_khr_fp16. These functions do not use halfn type,
therefore cl_khr_fp16 is not required.
Repository:
rC Clang
https://reviews.llvm.org/D46501
___
cfe-commits mailing list
cfe-commits@lists.llvm.
sammccall added a comment.
I'm concerned about the scope of this patch - it does too many things and
touches too many files for me to feel comfortable that I understand it well
enough to review.
Is it possible to split it up? (You mention 6 distinct things in the
description).
Have tried to fo
Author: abeserminji
Date: Mon May 7 07:30:49 2018
New Revision: 331640
URL: http://llvm.org/viewvc/llvm-project?rev=331640&view=rev
Log:
[mips] Improve handling of -fno-[pic/PIC] option
In order to disable PIC and to match GCC behaviour, -mno-abicalls
option is neccessary. When -fno-[pic/PIC] is
Author: abataev
Date: Mon May 7 07:50:05 2018
New Revision: 331642
URL: http://llvm.org/viewvc/llvm-project?rev=331642&view=rev
Log:
[OPENMP, NVPTX] Added support for L2 parallelism.
Added initial codegen for level 2, 3 etc. parallelism. Currently, all
the second, the third etc. parallel regions
ilya-biryukov added a comment.
The change makes both testing and scoring code better.
Even though those are largely independent changes, perfectly happy to review
them together.
I mostly have NITs here, overall the changes LG.
Comment at: clangd/CodeComplete.cpp:36
+#define
mstorsjo added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4218
// -fno-use-line-directives is default.
if (Args.hasFlag(options::OPT_fuse_line_directives,
hans wrote:
> The comment needs an update I think.
Thanks, will change into "-fno-
Author: abeserminji
Date: Mon May 7 07:19:54 2018
New Revision: 331636
URL: http://llvm.org/viewvc/llvm-project?rev=331636&view=rev
Log:
[mips] Improve handling of -fno-[pic/PIC] option
In order to disable PIC and to match GCC behaviour, -mno-abicalls
option is neccessary. When -fno-[pic/PIC] is
Author: abeserminji
Date: Mon May 7 07:28:42 2018
New Revision: 331639
URL: http://llvm.org/viewvc/llvm-project?rev=331639&view=rev
Log:
Revert "[mips] Improve handling of -fno-[pic/PIC] option"
This reverts commit r331636. Forgot to add the test case.
Modified:
cfe/trunk/include/clang/Bas
Author: marshall
Date: Mon May 7 07:21:52 2018
New Revision: 331638
URL: http://llvm.org/viewvc/llvm-project?rev=331638&view=rev
Log:
Update for Rapperswil
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331636: [mips] Improve handling of -fno-[pic/PIC] option
(authored by abeserminji, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44684?vs=145460&id=145462#toc
Repository:
rL LLVM
abeserminji updated this revision to Diff 145460.
abeserminji marked 4 inline comments as done.
abeserminji added a comment.
Comments resolved.
https://reviews.llvm.org/D44684
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Driver/ToolChains/Com
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgrang, jkorous, MaskRay, ioeric,
mgorny, klimek.
Code completion scoring was embedded in CodeComplete.cpp, which is bad:
- awkward to test. The mechanisms (extracting info from ind
lebedev.ri added inline comments.
Comment at: test/clang-tidy/bugprone-exception-escape.cpp:178
+void indirect_implicit() noexcept {
+ // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: function 'indirect_implicit'
throws
+ implicit_int_thrower();
baloghadamsoftware
1 - 100 of 120 matches
Mail list logo
