incertia updated this revision to Diff 141477.
incertia added a comment.
Pulled the check outside of the case statement.
https://reviews.llvm.org/D45401
Files:
lib/Sema/SemaExpr.cpp
lib/Sema/SemaExprCXX.cpp
Index: lib/Sema/SemaExprCXX.cpp
==
incertia created this revision.
incertia added reviewers: rjmccall, rsmith.
incertia added a project: clang.
Herald added a subscriber: cfe-commits.
To my understanding, the contents of a condition will always be implicitly
casted to an rvalue before evaluation. Thus, moving the check to
Perform
Author: ericwf
Date: Fri Apr 6 21:28:11 2018
New Revision: 329484
URL: http://llvm.org/viewvc/llvm-project?rev=329484&view=rev
Log:
Use void() to create a void expression type
Modified:
libcxx/trunk/include/compare
Modified: libcxx/trunk/include/compare
URL:
http://llvm.org/viewvc/llvm-pro
Author: nico
Date: Fri Apr 6 21:25:01 2018
New Revision: 329481
URL: http://llvm.org/viewvc/llvm-project?rev=329481&view=rev
Log:
Sort source lists in lib/StaticAnalyzer.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/CMakeLists.txt
cfe/trunk/lib/StaticAnalyzer/Frontend/CMakeLists.txt
Modi
rjmccall added a comment.
If that's the problem, then I think the right design is for CallArg to include
an optional cleanup reference for a cleanup that can be deactivated at the
instant of the call (we should assert that this exists for parameters that are
destroyed in the callee), and then f
rjmccall added a comment.
Just a couple minor requests; if you accept them, feel free to commit.
Comment at: include/clang/AST/Decl.h:3556
+/// indirectly. This value is used only in C++.
+APK_CannotPassInRegs,
+
I think it's probably worth spelling out
Author: nico
Date: Fri Apr 6 20:29:47 2018
New Revision: 329477
URL: http://llvm.org/viewvc/llvm-project?rev=329477&view=rev
Log:
Make CodeGen depend just once on clangAnalysis.
Modified:
cfe/trunk/lib/CodeGen/CMakeLists.txt
Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt
URL:
http://llvm.o
rjmccall added a comment.
This looks okay to me, but I think it would better if someone with more
expertise in the design of the driver and frontend code could review this.
Comment at: lib/Driver/Driver.cpp:2267
+if ((IA->getType() != types::TY_CUDA) &&
+IA
Hi Yuka,
sorry about the late review comment on this. I just happened to see that
this lets Driver's Option.inc depend on StaticAnalyzer/Checker's
Checker.inc. However, Driver does not depend on StaticAnalyzer/Checker. In
practice, it works ok because of all tablegen targets being collected
into c
Hi Zinovy,
The PS4 Windows bot is still failing to compile this file after your latest
change. Can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/16316
FAILED:
tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/clangTidyBugproneMo
vsapsai added inline comments.
Comment at: test/SemaCXX/overloaded-builtin-operators.cpp:95-99
// C++ [over.built]p3
long l1 = lr--;
+ // C++ [over.built]p4
+ float f1 = fr--;
Looks like p3 for `lr--` is a typo because p3 is about `++` while p4 is about
ahatanak updated this revision to Diff 141471.
ahatanak added a comment.
Replace flags CanPassInRegisters and CannotPassInRegisters with a 2-bit enum in
RecordDecl.
Repository:
rC Clang
https://reviews.llvm.org/D45384
Files:
include/clang/AST/Decl.h
include/clang/AST/Type.h
lib/AST/De
Author: nico
Date: Fri Apr 6 18:34:36 2018
New Revision: 329476
URL: http://llvm.org/viewvc/llvm-project?rev=329476&view=rev
Log:
Remove another unnecessary -I flag passed to clang-tblgen.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Checkers/CMakeLists.txt
cfe/trunk/include/clang/St
Author: ericwf
Date: Fri Apr 6 18:28:54 2018
New Revision: 329474
URL: http://llvm.org/viewvc/llvm-project?rev=329474&view=rev
Log:
Work around missing braces in init warning
Modified:
libcxx/trunk/include/compare
Modified: libcxx/trunk/include/compare
URL:
http://llvm.org/viewvc/llvm-proj
dpayne added a comment.
Hi
Bumping this commit. I do not have commit access so I cannot merge myself, if
you have the time could you merge this commit?
Repository:
rC Clang
https://reviews.llvm.org/D43957
___
cfe-commits mailing list
cfe-commit
Author: rsmith
Date: Fri Apr 6 17:28:32 2018
New Revision: 329467
URL: http://llvm.org/viewvc/llvm-project?rev=329467&view=rev
Log:
Generalize test for 32-bit targets.
Modified:
cfe/trunk/test/CodeGenCXX/tail-padding.cpp
Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp
URL:
http://llvm
Eugene.Zelenko added a comment.
If this is Apple guideline, check name should reflect this. I think will be
good idea to have general check for Apple naming conventions instead of
separate checks for specific situations like //objc-ivar-declaration// and
//objc-property-declaration//.
==
Author: arphaman
Date: Fri Apr 6 17:03:27 2018
New Revision: 329465
URL: http://llvm.org/viewvc/llvm-project?rev=329465&view=rev
Log:
Recommit r329442: Generate Libclang invocation reproducers using a new
-cc1gen-reproducer driver option
The recommit fixes:
- An MSAN failure (CCPrintOptions wasn
MaskRay added a comment.
There is no unittest but I have verified with a C++ language server on Arch
Linux. Without using this function, cquery/ccls will not be able to index
system header files because of excessive .. in the path returned by
clang_getFileName.
Repository:
rC Clang
https:/
Author: nico
Date: Fri Apr 6 16:36:50 2018
New Revision: 329464
URL: http://llvm.org/viewvc/llvm-project?rev=329464&view=rev
Log:
Remove two unnecessary -I flags passed to clang-tblgen.
Modified:
cfe/trunk/include/clang/Basic/CMakeLists.txt
Modified: cfe/trunk/include/clang/Basic/CMakeLists
rjmccall added a comment.
In https://reviews.llvm.org/D45384#1060369, @ahatanak wrote:
> Yes. I intended it as a property that propagates to classes that contain or
> derive from the type.
>
> Would it make it less confusing if I merged CXXRecordDecl::CanPassInRegisters
> and RecordDecl::Cannot
DHowett-MSFT updated this revision to Diff 141450.
DHowett-MSFT added a comment.
Added a test per @rjmccall's suggestion. I chose to test this by emitting
assembly because the llvm ir is significantly harder to pick apart for the true
_size_ of the protocol.
Repository:
rC Clang
https://rev
DHowett-MSFT added a comment.
Thanks! I don't have the means to check this in myself.
Repository:
rC Clang
https://reviews.llvm.org/D44646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
ahatanak added a comment.
In https://reviews.llvm.org/D45382#1060163, @rjmccall wrote:
> Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup
> arguments. Do we just not have the necessary logic to disable the cleanup in
> the caller?
It seems that it would be OK if ther
vsapsai updated this revision to Diff 141448.
vsapsai added a comment.
- Add a comment.
https://reviews.llvm.org/D9
Files:
clang/lib/Parse/ParseDecl.cpp
clang/test/Parser/cxx-decl.cpp
Index: clang/test/Parser/cxx-decl.cpp
===
vlad.tsyrklevich accepted this revision.
vlad.tsyrklevich added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/docs/XRayExample.rst:196
+``-fxray-attr-list=`` flag to clang. You can have multiple files, each defining
+different sets of attribut
Wizard updated this revision to Diff 141444.
Wizard added a comment.
fix doc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/IvarDeclarationCheck.cpp
clang-tidy/objc/IvarDeclarationCheck.h
clang-tidy/objc/ObjCTi
Wizard created this revision.
Herald added subscribers: cfe-commits, mgorny, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/IvarDeclarationCheck.cpp
clang-tidy/objc/IvarDeclarationCheck.h
clang-tidy/objc/
vsapsai added inline comments.
Comment at: clang/lib/Parse/ParseDecl.cpp:3076
DS.SetRangeEnd(Tok.getAnnotationEndLoc());
ConsumeAnnotationToken(); // The typename
}
rsmith wrote:
> vsapsai wrote:
> > Here we potentially can leave annotati
phosek updated this revision to Diff 141442.
phosek marked an inline comment as done.
Repository:
rCXX libc++
https://reviews.llvm.org/D44773
Files:
libcxx/NOTES.TXT
libcxx/cmake/Modules/HandleLibCXXABI.cmake
libcxx/include/CMakeLists.txt
libcxx/lib/CMakeLists.txt
Index: libcxx/lib/CM
ahatanak added a comment.
Yes. I intended it as a property that propagates to classes that contain or
derive from the type.
Would it make it less confusing if I merged CXXRecordDecl::CanPassInRegisters
and RecordDecl::CannotPassInRegisters into a single enum? For example, the enum
could have t
timshen updated this revision to Diff 141436.
timshen marked an inline comment as done.
timshen added a comment.
Update file comments copy-paste error.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/module.module
Author: jvesely
Date: Fri Apr 6 15:00:00 2018
New Revision: 329462
URL: http://llvm.org/viewvc/llvm-project?rev=329462&view=rev
Log:
select: simplify implementation and fix fp16
Fix half precision implementation
Vector ?: operator should behave exactly as select
Passes CTS on carrizo
Signed-off
BillyONeal updated this revision to Diff 141433.
BillyONeal retitled this revision from "[libcxx] [test] Remove non-portable
assertions from filebuf's seekoff.pass.cpp test" to "[libcxx] [test] Remove
non-portable assertions from filebuf tests".
BillyONeal edited the summary of this revision.
Bil
efriedma added a comment.
How could this patch possibly affect vprintf?
Repository:
rC Clang
https://reviews.llvm.org/D45383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri Apr 6 14:37:23 2018
New Revision: 329460
URL: http://llvm.org/viewvc/llvm-project?rev=329460&view=rev
Log:
Implement P0768r1: Library support for the Spaceship Operator.
this patch adds the header and implements all of it
except for [comp.alg].
As I understand it, the
rjmccall added a comment.
In https://reviews.llvm.org/D45384#1060192, @ahatanak wrote:
> In https://reviews.llvm.org/D45384#1060164, @rjmccall wrote:
>
> > Well, but I think CanPassInRegisters==false in the base class does always
> > mean CanPassInRegisters==false in the subclass.
>
>
> I think
erichkeane added a comment.
In https://reviews.llvm.org/D45383#1060275, @efriedma wrote:
> By "builtins" I meant specifically the stuff that that user code isn't
> allowed to declare, like __builtin_*, since they often have weird/incomplete
> signatures.
Unfortunately, the problem shows in vp
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Yes, this is fine.
Repository:
rC Clang
https://reviews.llvm.org/D44616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
efriedma added a comment.
By "builtins" I meant specifically the stuff that that user code isn't allowed
to declare, like __builtin_*, since they often have weird/incomplete signatures.
Repository:
rC Clang
https://reviews.llvm.org/D45383
___
cf
Author: zinovy.nis
Date: Fri Apr 6 14:00:18 2018
New Revision: 329454
URL: http://llvm.org/viewvc/llvm-project?rev=329454&view=rev
Log:
[clang-tidy] One more fix compilation for ParentVirtualCallCheck.cpp: find_if
predicate
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtua
Author: zinovy.nis
Date: Fri Apr 6 13:39:23 2018
New Revision: 329452
URL: http://llvm.org/viewvc/llvm-project?rev=329452&view=rev
Log:
[clang-tidy] Fix compilation for ParentVirtualCallCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/ParentVirtualCallCheck.cpp
Modified: cla
erichkeane added a comment.
One big issue with just disallowing redecls of builtins is we have is that a
number of these are actually expected to be in the system headers/libraries
(such as vprintf). A ton of the math.h functions are also builtins.
Repository:
rC Clang
https://reviews.llvm
yaxunl added a comment.
In https://reviews.llvm.org/D45387#1060194, @tra wrote:
> You may want to mention in the commit log that this is a partial unroll of
> r329232 / https://reviews.llvm.org/D45277.
Will do. Thanks.
https://reviews.llvm.org/D45387
__
Author: rsmith
Date: Fri Apr 6 13:06:02 2018
New Revision: 329449
URL: http://llvm.org/viewvc/llvm-project?rev=329449&view=rev
Log:
Don't assume constructors return void.
Should fix ARM buildbot.
Modified:
cfe/trunk/test/CodeGenCXX/tail-padding.cpp
Modified: cfe/trunk/test/CodeGenCXX/tail-
erichkeane added a comment.
In https://reviews.llvm.org/D45383#1060104, @efriedma wrote:
> Rather than adding weird hacks to merging, can we just reject any attempt to
> redeclare a builtin?
I don't believe we can. I think things often re-declare them, particularly
when it comes to va_end.
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE329448: [clang-tidy] Check if grand-..parent's
virtual method was called instead of… (authored by zinovy.nis, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44295?vs=141199&id=1414
Author: zinovy.nis
Date: Fri Apr 6 13:02:50 2018
New Revision: 329448
URL: http://llvm.org/viewvc/llvm-project?rev=329448&view=rev
Log:
[clang-tidy] Check if grand-..parent's virtual method was called instead of
overridden parent's.
class A {...int virtual foo() {...}...};
class B: public A {
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
You may want to mention in the commit log that this is a partial unroll of
r329232 / https://reviews.llvm.org/D45277.
https://reviews.llvm.org/D45387
ahatanak added a comment.
In https://reviews.llvm.org/D45384#1060164, @rjmccall wrote:
> Well, but I think CanPassInRegisters==false in the base class does always
> mean CanPassInRegisters==false in the subclass.
I think there are cases that is not true. If I compile the following code, S0
(b
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: nhaehnle, jholewinski.
amdgcn targets only support HIP, which does not define `__CUDA_ARCH__`.
`__HIP_DEVICE_COMPILE__` depends on HIP language mode, therefore it needs to be
added
in a different patch.
refer
Author: arphaman
Date: Fri Apr 6 12:45:29 2018
New Revision: 329447
URL: http://llvm.org/viewvc/llvm-project?rev=329447&view=rev
Log:
Revert r329442 "Generate Libclang invocation reproducers using a new
-cc1gen-reproducer driver option"
The tests are failing on some bots
Removed:
cfe/trunk/
rjmccall added a comment.
Well, but I think CanPassInRegisters==false in the base class does always mean
CanPassInRegisters==false in the subclass.
Repository:
rC Clang
https://reviews.llvm.org/D45384
___
cfe-commits mailing list
cfe-commits@lis
Thanks, I see the problem.
On Fri, 6 Apr 2018, 11:56 via cfe-commits,
wrote:
> Hi Richard,
>
> I don't know if you are aware, but the test you added in this commit,
> tail-padding.cpp is currently failing on one of the ARM bots. Can you take
> a look?
>
>
> http://lab.llvm.org:8011/builders/clan
rjmccall added a comment.
Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup
arguments. Do we just not have the necessary logic to disable the cleanup in
the caller?
Repository:
rC Clang
https://reviews.llvm.org/D45382
_
Author: george.karpenkov
Date: Fri Apr 6 12:14:05 2018
New Revision: 329445
URL: http://llvm.org/viewvc/llvm-project?rev=329445&view=rev
Log:
Revert "[analyzer] Remove an unused variable"
This reverts commit 2fa3e3edc4ed6547cc4ce46a8c79d1891a5b3b36.
Removed the wrong variable.
Modified:
cf
Author: george.karpenkov
Date: Fri Apr 6 12:03:43 2018
New Revision: 329444
URL: http://llvm.org/viewvc/llvm-project?rev=329444&view=rev
Log:
[analyzer] Remove an unused variable
Modified:
cfe/trunk/lib/Analysis/LiveVariables.cpp
Modified: cfe/trunk/lib/Analysis/LiveVariables.cpp
URL:
http
ahatanak created this revision.
ahatanak added reviewers: rjmccall, rsmith.
This patch fixes a bug in r328731 that caused structs with `__weak` fields to
be passed in registers. This happens when a struct doesn't have a `__weak`
field but one of its subobjects does. To fix this, I added flag
CX
Hi Richard,
I don't know if you are aware, but the test you added in this commit,
tail-padding.cpp is currently failing on one of the ARM bots. Can you take a
look?
http://lab.llvm.org:8011/builders/clang-cmake-armv7-selfhost-neon/builds/178
TEST 'Clang :: CodeGenCXX/tail-
efriedma added a comment.
Rather than adding weird hacks to merging, can we just reject any attempt to
redeclare a builtin?
Repository:
rC Clang
https://reviews.llvm.org/D45383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
efriedma added a comment.
> I take it we still have test cases for the arm <-> thumb transition?
"-mthumb" and "-marm" are handled in the driver by rewriting the triple.
Repository:
rC Clang
https://reviews.llvm.org/D45240
___
cfe-commits mailin
bsdjhb added a comment.
Ping @sdardis @compnerd
Repository:
rUNW libunwind
https://reviews.llvm.org/D41968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma updated this revision to Diff 141393.
efriedma added a comment.
Add a bunch of tests for various arm arches. Make sure we do something
reasonable when we can't figure out any arch at all.
Repository:
rC Clang
https://reviews.llvm.org/D45240
Files:
lib/Basic/Targets/ARM.cpp
tes
erichkeane created this revision.
erichkeane added reviewers: efriedma, eli.friedman, compnerd, rsmith.
erichkeane added a project: clang.
As reported here: https://bugs.llvm.org/show_bug.cgi?id=37033
Any usage of a builtin function that uses a va_list by reference
will cause an assertion when red
Author: arphaman
Date: Fri Apr 6 11:30:14 2018
New Revision: 329442
URL: http://llvm.org/viewvc/llvm-project?rev=329442&view=rev
Log:
Generate Libclang invocation reproducers using a new -cc1gen-reproducer
driver option
This commit is a follow up to the previous work that recorded Libclang
invo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329442: Generate Libclang invocation reproducers using a new
-cc1gen-reproducer (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
ahatanak created this revision.
ahatanak added reviewers: rjmccall, rsmith.
Herald added a subscriber: kristof.beyls.
This patch fixes a bug where a struct with an ObjC `__weak` field gets
destructed after it has already been destructed. This bug was introduced in
r328731, which made changes to
GBuella added inline comments.
Comment at: lib/Headers/waitpkgintrin.h:41
+static __inline__ void __DEFAULT_FN_ATTRS
+_umwait (__SIZE_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER)
+{
craig.topper wrote:
> Why does the intrinsic take size_t but then its truncated
yaxunl added inline comments.
Comment at: lib/Basic/Targets.cpp:161
+case CudaArch::GFX902:
+ return "320";
+case CudaArch::UNKNOWN:
tra wrote:
> yaxunl wrote:
> > tra wrote:
> > > yaxunl wrote:
> > > > tra wrote:
> > > > > yaxunl wrote:
> > > > > >
fhahn accepted this revision.
fhahn added a comment.
Thanks for updating it to use the stuff from TargetParser.
LGTM, with tests for the cases @joerg mentiond.
Comment at: lib/Basic/Targets/ARM.cpp:345
// get default FPU features
+ llvm::ARM::ArchKind Arch = llvm::ARM::par
tra added inline comments.
Comment at: lib/Basic/Targets.cpp:161
+case CudaArch::GFX902:
+ return "320";
+case CudaArch::UNKNOWN:
yaxunl wrote:
> tra wrote:
> > yaxunl wrote:
> > > tra wrote:
> > > > yaxunl wrote:
> > > > > tra wrote:
> > > > > > Unl
void added a comment.
Hallo! I was wondering what the status of this patch was. :-)
https://reviews.llvm.org/D38479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: asmith
Date: Thu Apr 5 13:27:50 2018
New Revision: 329340
URL: http://llvm.org/viewvc/llvm-project?rev=329340&view=rev
Log:
[cmake] Remove duplicate command line options from build
CMAKE_CXX_FLAGS and CMAKE_C_FLAGS are added twice to the command line.
This causes the command line options
Author: dor1s
Date: Wed Apr 4 12:47:25 2018
New Revision: 329223
URL: http://llvm.org/viewvc/llvm-project?rev=329223&view=rev
Log:
Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960
Summary:
In https://reviews.llvm.org/D44960, file status check is executed every
time a real
Author: shiva
Date: Thu Apr 5 05:54:00 2018
New Revision: 329278
URL: http://llvm.org/viewvc/llvm-project?rev=329278&view=rev
Log:
[PATCH] [RISCV] Extend getTargetDefines for RISCVTargetInfo
Summary:
This patch extend getTargetDefines and implement handleTargetFeatures
and hasFeature. and define
> the targets where you would want to use this can't run the libcxx
testsuite anyway (because they don't have an operating system to run the
test programs under).
I used to run libcxx tests for an arm baremetal toolchain I was building
via semihosted QEMU. It was awkward and slow (especially for
yaxunl added inline comments.
Comment at: lib/Basic/Targets.cpp:161
+case CudaArch::GFX902:
+ return "320";
+case CudaArch::UNKNOWN:
tra wrote:
> yaxunl wrote:
> > tra wrote:
> > > yaxunl wrote:
> > > > tra wrote:
> > > > > Unless you're planning to
Author: jvesely
Date: Fri Apr 6 10:43:08 2018
New Revision: 329433
URL: http://llvm.org/viewvc/llvm-project?rev=329433&view=rev
Log:
fmod: Port from amd_builtins
Uses only denormal path for fp32.
Passes CTS on carrizo and turks.
v2: whitespace fix
Signed-off-by: Jan Vesely
Reviewer: Aaron Wat
rjmccall added inline comments.
Comment at: include/clang/AST/NonTrivialCStructTypeVisitor.h:30
+if (asDerived().getContext().getAsArrayType(FT))
+ return asDerived().visitArray(DK, FT, std::forward(Args)...);
+
ahatanak wrote:
> rjmccall wrote:
> > Shou
Author: gbiv
Date: Fri Apr 6 10:22:36 2018
New Revision: 329428
URL: http://llvm.org/viewvc/llvm-project?rev=329428&view=rev
Log:
[clang-tidy] Sort includes; NFC
Modified:
clang-tools-extra/trunk/clang-tidy/android/AndroidTidyModule.cpp
Modified: clang-tools-extra/trunk/clang-tidy/android/A
tra added inline comments.
Comment at: lib/Basic/Targets.cpp:161
+case CudaArch::GFX902:
+ return "320";
+case CudaArch::UNKNOWN:
yaxunl wrote:
> tra wrote:
> > yaxunl wrote:
> > > tra wrote:
> > > > Unless you're planning to guarantee 1:1 match to f
Author: yaxunl
Date: Fri Apr 6 09:43:42 2018
New Revision: 329420
URL: http://llvm.org/viewvc/llvm-project?rev=329420&view=rev
Log:
[HIP] define __CUDA_ARCH_=1 for amdgcn targets
Differential Revision: https://reviews.llvm.org/D45277
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/
craig.topper accepted this revision.
craig.topper added a comment.
LGTM
Comment at: lib/Headers/waitpkgintrin.h:41
+static __inline__ void __DEFAULT_FN_ATTRS
+_umwait (__SIZE_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER)
+{
Why does the intrinsic take size_t b
Author: abataev
Date: Fri Apr 6 09:03:36 2018
New Revision: 329411
URL: http://llvm.org/viewvc/llvm-project?rev=329411&view=rev
Log:
[OPENMP, NVPTX] Fix codegen for the teams reduction.
Added NUW flags for all the add|mul|sub operations + replaced sdiv by udiv
as we operate on unsigned values on
krasimir created this revision.
krasimir added a reviewer: djasper.
Herald added subscribers: cfe-commits, klimek.
This implements an alternative to r327861, namely preserving empty lines before
namespace endings.
Repository:
rC Clang
https://reviews.llvm.org/D45373
Files:
lib/Format/Name
bader added inline comments.
Comment at: include/clang/Frontend/LangStandards.def:167
+LANGSTANDARD_ALIAS_DEPR(opencl22, "CL2.2")
+LANGSTANDARD_ALIAS_DEPR(opencl22, "clc++")
+LANGSTANDARD_ALIAS_DEPR(opencl22, "CLC++")
OpenCL C++ 1.0 specification defines only 'c+
Sure, will update.
Thanks,
Manoj
On Fri, Apr 6, 2018 at 4:56 AM Nico Weber wrote:
> This should probably get a release notes entry. Can you write one?
>
> On Thu, Apr 5, 2018 at 11:29 AM, Manoj Gupta via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: manojgupta
>> Date: Thu Apr
alexfh added a comment.
Feel free to send the rest of the fixes as a separate patch.
Repository:
rL LLVM
https://reviews.llvm.org/D44188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
zinovy.nis added a comment.
Alexander, thanks for your patience and comments :-)
https://reviews.llvm.org/D44295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D44295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
yaxunl added inline comments.
Comment at: lib/Basic/Targets.cpp:161
+case CudaArch::GFX902:
+ return "320";
+case CudaArch::UNKNOWN:
tra wrote:
> yaxunl wrote:
> > tra wrote:
> > > Unless you're planning to guarantee 1:1 match to functionality provid
yaxunl added a comment.
LGTM. Thank!
https://reviews.llvm.org/D45363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
Thanks!
I've looked through all the fixes. Most of them look reasonable. I've reverted
a few files where I found something suspicious or outright wrong and will
commit the rest of the patch after I ensure the tests pass.
These files couldn'
Author: kparzysz
Date: Fri Apr 6 06:51:48 2018
New Revision: 329394
URL: http://llvm.org/viewvc/llvm-project?rev=329394&view=rev
Log:
[Hexagon] Remove default values from lambda parameters
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http
Wawha added a comment.
I'm not working on a public project with a public style guide, so not sure it
will fit all the requirement inside. But perhaps the request of Rian for
bareflank (https://bugs.llvm.org//show_bug.cgi?id=32151#c4) could help to fit
the needs.
The current patch do not exactl
jroelofs added a subscriber: efriedma.
jroelofs added a comment.
> the targets where you would want to use this can't run the libcxx
testsuite anyway (because they don't have an operating system to run the
test programs under).
I used to run libcxx tests for an arm baremetal toolchain I was bu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329391: Allow the creation of human-friendly ASTDumper to
arbitrary output stream (authored by alexfh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
Author: alexfh
Date: Fri Apr 6 06:01:12 2018
New Revision: 329391
URL: http://llvm.org/viewvc/llvm-project?rev=329391&view=rev
Log:
Allow the creation of human-friendly ASTDumper to arbitrary output stream
Summary:
`ASTPrinter` allows setting the ouput to any O-Stream, but that printer creates
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. I'll commit the patch for you.
Repository:
rC Clang
https://reviews.llvm.org/D45096
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
szepet updated this revision to Diff 141322.
szepet marked 4 inline comments as done.
szepet added a comment.
Addressed comments and readded the lost fixes.
https://reviews.llvm.org/D40937
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugp
1 - 100 of 124 matches
Mail list logo
