Re: [clang-tools-extra] r328270 - [clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework"

Hi Julie If I compile without asserts this patch gives me ../tools/clang/tools/extra/clang-doc/BitcodeWriter.cpp:260:15: error: unused variable 'BlockIdName' [-Werror,-Wunused-variable] const auto &BlockIdName = BlockIdNameMap[BID]; ^ 1 error generated. Regards, Mikael On 03/

[libcxx] r328476 - Implement filesystem::perm_options specified in NB comments.

Author: ericwf Date: Sun Mar 25 23:23:55 2018 New Revision: 328476 URL: http://llvm.org/viewvc/llvm-project?rev=328476&view=rev Log: Implement filesystem::perm_options specified in NB comments. The NB comments for filesystem changed permissions and added a new enum `perm_options` which control ho

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta updated this revision to Diff 139759. manojgupta added a comment. 1. Added test case to verify register names are not renamed in unsupported cases. 2. Updated formatting. Repository: rC Clang https://reviews.llvm.org/D44815 Files: lib/Basic/Targets/AArch64.cpp test/CodeGen/aa

[PATCH] D21767: Fix instantiation of friend function templates

sepavloff updated this revision to Diff 139758. sepavloff added a comment. Rebased patch Repository: rC Clang https://reviews.llvm.org/D21767 Files: include/clang/AST/ASTLambda.h include/clang/AST/Decl.h include/clang/Sema/Sema.h lib/AST/Decl.cpp lib/Sema/SemaTemplateInstantiate.cp

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

Quuxplusone added inline comments. Comment at: lib/Sema/SemaExpr.cpp:12087 + case BO_AndAssign: + case BO_OrAssign: +DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, /*IsBuiltin=*/false); I understand why `x &= x` and `x |= x` are mathematically special for the

r328447 - Remove reference to stale (2009) python version.

Author: yrnkrn Date: Sun Mar 25 06:12:05 2018 New Revision: 328447 URL: http://llvm.org/viewvc/llvm-project?rev=328447&view=rev Log: Remove reference to stale (2009) python version. Modified: cfe/trunk/www/hacking.html Modified: cfe/trunk/www/hacking.html URL: http://llvm.org/viewvc/llvm-p

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mno-relax flag to disable it

shiva0217 created this revision. shiva0217 added reviewers: asb, apazos. Herald added subscribers: cfe-commits, kito-cheng, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. Default enable linker relaxation and add -mno-relax flag to disable it. Repository: rC Clang https://r

[libcxxabi] r328464 - [demangler] Use a back-patching scheme to resolve forward references.

Author: epilk Date: Sun Mar 25 15:50:33 2018 New Revision: 328464 URL: http://llvm.org/viewvc/llvm-project?rev=328464&view=rev Log: [demangler] Use a back-patching scheme to resolve forward references. Strictly in a conversion operator's type, a refers to a that is further ahead in the mangled

[libcxxabi] r328463 - [demangler] Tweak how parameter pack sizes are determined.

Author: epilk Date: Sun Mar 25 15:49:57 2018 New Revision: 328463 URL: http://llvm.org/viewvc/llvm-project?rev=328463&view=rev Log: [demangler] Tweak how parameter pack sizes are determined. Rather than eagerly propagating up parameter pack sizes in Node ctors, find the parameter pack size during

[libcxxabi] r328462 - [demangler] Support for clang's enable_if attribute.

Author: epilk Date: Sun Mar 25 15:49:16 2018 New Revision: 328462 URL: http://llvm.org/viewvc/llvm-project?rev=328462&view=rev Log: [demangler] Support for clang's enable_if attribute. Fixes PR33569. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.c

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri created this revision. lebedev.ri added reviewers: aaron.ballman, rsmith, rtrieu, nikola, chandlerc, rjmccall. This has just bit me, so i though it would be nice to avoid that next time :) Motivational case: https://godbolt.org/g/cq9UNk Basically, it's likely to happen if you don't

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle created this revision. Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple, mgrang, ilya-biryukov, mgorny, klimek. This is a basic implementation of the "workspace/symbol" request which is used to find symbols by a string query. Since this is similar to code completion

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth added a comment. I checked several codebases and implemented a little helper script to see which kind of macros exist. Then I added some filter regex as configuration and tried again, here are the results: For https://github.com/nlohmann/json which is a very high quality codebase, the

[PATCH] D44878: libFuzzer OpenBSD support

devnexen created this revision. devnexen added reviewers: brad, thakis. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp ===

[PATCH] D44661: [libcxx] optimize reduce(), hmin(), hmax() by reordering the operations.

lichray added inline comments. Comment at: libcxx/include/experimental/simd:2196 +typename _SimdType::value_type>::type +__hmax(const _SimdType& __v) { auto __acc = __v[0]; These conditions are too long, consider ``` __hmax_impl(const _

[PATCH] D44661: [libcxx] optimize reduce(), hmin(), hmax() by reordering the operations.

lichray added inline comments. Comment at: libcxx/include/experimental/simd:2096 +template +std::array::size() / 2, _Abi>>, 2> +__deinterleave(const simd<_Tp, _Abi>& __v) { Too long. Consider a traits? https://reviews.llvm.org/D44661 __

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

lichray accepted this revision. lichray added a comment. This revision is now accepted and ready to land. Something `std::byte` couldn't help lol Repository: rCXX libc++ https://reviews.llvm.org/D44823 ___ cfe-commits mailing list cfe-commits@lis