Woops. I misread the name of the test. I just committed a fix. Thanks for
the heads up.
/Eric
On Sat, Mar 24, 2018 at 4:44 PM, Francois Pichet
wrote:
> You didn't update allocator.members\construct.pass.cpp in your patch.
>
>
> On Sat, Mar 24, 2018 at 6:41 PM, Eric Fiselier wrote:
>
>> Still?
Author: ericwf
Date: Sat Mar 24 20:00:42 2018
New Revision: 328445
URL: http://llvm.org/viewvc/llvm-project?rev=328445&view=rev
Log:
avoid new/delete ellision in construct.pass.cpp
Modified:
libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/construct.pass.cpp
Modifi
You didn't update allocator.members\construct.pass.cpp in your patch.
On Sat, Mar 24, 2018 at 6:41 PM, Eric Fiselier wrote:
> Still?
>
> I would of hoped this patch fixed it.
>
> Could you provide the test output?
>
> /Eric
>
> On Sat, Mar 24, 2018 at 4:39 PM, Francois Pichet
> wrote:
>
>> Hi,
Still?
I would of hoped this patch fixed it.
Could you provide the test output?
/Eric
On Sat, Mar 24, 2018 at 4:39 PM, Francois Pichet
wrote:
> Hi,
>
> I am seeing failure on this test too.
> test\std\utilities\memory\default.allocator\allocator.member
> s\construct.pass.cpp
>
> For the s
Hi,
I am seeing failure on this test too.
test\std\utilities\memory\default.allocator\allocator.
members\construct.pass.cpp
For the same reason : new optimized away.
On Thu, Mar 22, 2018 at 5:28 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date:
v.g.vassilev abandoned this revision.
v.g.vassilev added a comment.
Ok, that's great! Sorry for the delay and thanks for landing a similar patch.
Btw, we should probably find a more terse way to test the ODRHash, eg. with
unittests.
Repository:
rC Clang
https://reviews.llvm.org/D43696
__
lebedev.ri added a comment.
It's good to finally have the initial block firmly landed, congratulations.
Trying to review this...
Some initial thoughts.
Comment at: clang-doc/BitcodeReader.cpp:27
+ assert(Record[0] == 20);
+ for (int I = 0, E = Record[0]; I < E; ++I)
+Fie
hintonda abandoned this revision.
hintonda added a comment.
Not needed for llvm+clang builds.
Repository:
rC Clang
https://reviews.llvm.org/D42490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
JonasToth added inline comments.
Comment at: test/clang-tidy/readability-function-size.cpp:207-212
+void variables_8() {
+ int a, b;
+ struct A {
+A(int c, int d);
+ };
+}
lebedev.ri wrote:
> aaron.ballman wrote:
> > lebedev.ri wrote:
> > > aaron.ballman w
lebedev.ri added inline comments.
Comment at: test/clang-tidy/readability-function-size.cpp:207-212
+void variables_8() {
+ int a, b;
+ struct A {
+A(int c, int d);
+ };
+}
aaron.ballman wrote:
> lebedev.ri wrote:
> > aaron.ballman wrote:
> > > JonasToth w
lebedev.ri updated this revision to Diff 139711.
lebedev.ri marked 15 inline comments as done.
lebedev.ri added a comment.
- Rebased ontop of master
- Fixed links in documentation
- Improved test coverage
- No longer count variables declared in nested `class`es.
- No longer count variables declare
spatel accepted this revision.
spatel added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:13108-13110
// We make "fma" on GNU or Windows const because we know it does not set
// errno in those environments even though it could set errno based on the
// C stand
JonasToth updated this revision to Diff 139707.
JonasToth added a comment.
- Merge branch 'master' into check_macros_usage
- [Doc] update to new doc style
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppc
JonasToth updated this revision to Diff 139706.
JonasToth added a comment.
- update to trunk
- [Doc] update to new doc style
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40854
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuideline
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328418: [clang-tidy] Enable Python 3 support for
add_new_check.py (authored by jbcoe, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.org/D4
Author: jbcoe
Date: Sat Mar 24 03:49:17 2018
New Revision: 328418
URL: http://llvm.org/viewvc/llvm-project?rev=328418&view=rev
Log:
[clang-tidy] Enable Python 3 support for add_new_check.py
Summary: In Python 3, filters are lazily evaluated and strings are not bytes.
Reviewers: ilya-biryukov
Re
lichray updated this revision to Diff 139704.
lichray added a comment.
Use less traits
Repository:
rCXX libc++
https://reviews.llvm.org/D44865
Files:
include/variant
test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp
test/std/utilities/variant/variant.variant/variant.
lichray created this revision.
lichray added reviewers: EricWF, mpark, mclow.lists.
Herald added a subscriber: christof.
"Boolshit shall not prevail," LEWG says.
References:
http://wg21.link/P0608R1
Repository:
rCXX libc++
https://reviews.llvm.org/D44865
Files:
include/variant
test/std
18 matches
Mail list logo
