yvvan added a comment.
I feel quite ok about this patch.
Can you please add unit-tests?
Repository:
rC Clang
https://reviews.llvm.org/D42895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Wizard updated this revision to Diff 132938.
Wizard added a comment.
resolve conflict in doc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42947
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
test/clang-tidy/objc-property-declaration.m
Index: test/clang-tidy/objc-pr
Wizard created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42947
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
docs/clang-tidy/checks/objc-property-declaration.rst
test/clang-tidy/objc-property-declarati
brucem created this revision.
Herald added a reviewer: EricWF.
This was picked up via clang-tidy's readability-misleading-indentation
check.
Repository:
rCXX libc++
https://reviews.llvm.org/D42945
Files:
include/__string
include/algorithm
Index: include/algorithm
==
Author: marshall
Date: Mon Feb 5 19:24:21 2018
New Revision: 324312
URL: http://llvm.org/viewvc/llvm-project?rev=324312&view=rev
Log:
No, really this time mark 3034 as 'Patch Ready'
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http:
Author: marshall
Date: Mon Feb 5 19:23:16 2018
New Revision: 324310
URL: http://llvm.org/viewvc/llvm-project?rev=324310&view=rev
Log:
Mark issue 3034 as 'Patch Ready'
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/view
Sorry about that guys, I was AFK most of the day today.
Thanks for cleaning up my mess.
On Feb 5, 2018 7:08 PM, "Nirav Davé" wrote:
> I reverted r324182, r324185, and r324192 in r324309. Things should be
> unstuck now.
>
> -Nirav
>
> On Mon, Feb 5, 2018 at 9:06 PM, Nirav Davé wrote:
>
>> It
I reverted r324182, r324185, and r324192 in r324309. Things should be
unstuck now.
-Nirav
On Mon, Feb 5, 2018 at 9:06 PM, Nirav Davé wrote:
> It looks like we need to revert 324182 and 324194. I'll revert on I
> reverify on trunk.
>
>
___
cfe-commits
Author: niravd
Date: Mon Feb 5 19:03:37 2018
New Revision: 324309
URL: http://llvm.org/viewvc/llvm-project?rev=324309&view=rev
Log:
Revert "[libc++] Fix PR35491 - std::array of zero-size doesn't work with
non-default constructible types."
Revert "Fix initialization of array with GCC."
Revert "Ma
Author: rtrieu
Date: Mon Feb 5 18:58:21 2018
New Revision: 324308
URL: http://llvm.org/viewvc/llvm-project?rev=324308&view=rev
Log:
Fix crash on invalid.
Don't call a method when the pointer is null.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/test/SemaCXX/lambda-expressions.cpp
sammccall added a comment.
This does seem to get at least the simple cases right:
ID: 0EF8AF4D08B11EBF3FFB8004CE702991B15F
Name:SymbolsFromYAML
Scope: 'clang::clangd::'
SymInfo:
Kind:Function
Lang:C
Canonica
It looks like we need to revert 324182 and 324194. I'll revert on I
reverify on trunk.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall created this revision.
sammccall added reviewers: ioeric, hokein.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
(This isn't done! Needs new tests, and some random cleanups should be split out.
Looking for some early feedback.)
Within a TU:
- as now, colle
Author: marshall
Date: Mon Feb 5 17:59:28 2018
New Revision: 324307
URL: http://llvm.org/viewvc/llvm-project?rev=324307&view=rev
Log:
More patches ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-projec
NoQ planned changes to this revision.
NoQ added a comment.
Destructor for the returned temporary is still evaluated conservatively:
class C {
public:
int &x, &y;
C(int &_x, int &_y) : x(_x), y(_y) { ++x; }
C(const C &c) : x(c.x), y(c.y) { ++x; }
~C() { ++y; }
};
C make(
rsmith added a comment.
The Itanium C++ ABI specifies a convention of using the source-level syntax in
the mangling of vendor extensions. This gives a fairly natural naming
convention for such extensions. That would suggest that the identifier to use
here is `__swiftcall__`, not `__swift_cc` /
alekseyshl added a comment.
Rainer, check https://reviews.llvm.org/rC324302 out, you probably want to add
test cases for Solaris to test/Driver/sanitizer-ld.c too.
Repository:
rC Clang
https://reviews.llvm.org/D40903
___
cfe-commits mailing list
vsapsai updated this revision to Diff 132917.
vsapsai added a comment.
- Improve tests: check when function argument is a function call itself.
https://reviews.llvm.org/D42938
Files:
clang/lib/Sema/SemaChecking.cpp
clang/test/Sema/integer-overflow.c
clang/test/SemaCXX/integer-overflow.cpp
Author: alekseyshl
Date: Mon Feb 5 16:50:18 2018
New Revision: 324302
URL: http://llvm.org/viewvc/llvm-project?rev=324302&view=rev
Log:
Fix test/Driver/sanitizer-ld.c broken by D40903
Differential revision: https://reviews.llvm.org/D40903
Modified:
cfe/trunk/test/Driver/sanitizer-ld.c
Modi
NoQ added inline comments.
Comment at: include/clang/Analysis/CFG.h:153
+
+ ConstructionContext() = default;
+ ConstructionContext(CXXConstructExpr *Constructor, Stmt *Trigger)
xazax.hun wrote:
> Maybe I am getting this wrong, but I think in this case the membe
vsapsai created this revision.
vsapsai added reviewers: ahatanak, nicholas, rsmith.
Herald added a subscriber: jkorous-apple.
Objective-C properties aren't handled on purpose as they require
different approach.
rdar://problem/35539384
https://reviews.llvm.org/D42938
Files:
clang/lib/Sema/Sem
NoQ updated this revision to Diff 132908.
NoQ marked an inline comment as done.
NoQ added a comment.
Fix uninitialized variables.
https://reviews.llvm.org/D42672
Files:
include/clang/Analysis/AnalysisDeclContext.h
include/clang/Analysis/CFG.h
include/clang/StaticAnalyzer/Core/AnalyzerOpti
Author: alekseyshl
Date: Mon Feb 5 15:59:13 2018
New Revision: 324296
URL: http://llvm.org/viewvc/llvm-project?rev=324296&view=rev
Log:
[Sanitizers] Basic Solaris sanitizer support (PR 33274)
Summary:
This patch (on top of https://reviews.llvm.org/D35755) provides the clang side
necessary
to en
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324296: [Sanitizers] Basic Solaris sanitizer support (PR
33274) (authored by alekseyshl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D40903
Files:
include/clang/Driver/ToolChain.h
smeenai added subscribers: compnerd, smeenai.
smeenai added a comment.
This seems ... suboptimal. It breaks existing code in the sense that their code
was already broken, and the compiler is just diagnosing it correctly now. Note
that Apple themselves recommend casting and using a proper printf
arphaman updated this revision to Diff 132901.
arphaman marked 4 inline comments as done.
arphaman added a comment.
Herald added a subscriber: jkorous-apple.
Address review comments and fix the inverted check case.
https://reviews.llvm.org/D42561
Files:
lib/Sema/SemaChecking.cpp
test/Sema/c
Author: marshall
Date: Mon Feb 5 15:50:49 2018
New Revision: 324292
URL: http://llvm.org/viewvc/llvm-project?rev=324292&view=rev
Log:
Add issues in 'Review'
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pr
Author: marshall
Date: Mon Feb 5 15:43:34 2018
New Revision: 324290
URL: http://llvm.org/viewvc/llvm-project?rev=324290&view=rev
Log:
Remove ; use instead. See
https://libcxx.llvm.org/TS_deprecation.html
Removed:
libcxx/trunk/test/std/experimental/string.view/
Modified:
libcxx/trunk/in
Author: pcc
Date: Mon Feb 5 15:09:13 2018
New Revision: 324286
URL: http://llvm.org/viewvc/llvm-project?rev=324286&view=rev
Log:
IRGen: Move vtable load after argument evaluation.
This change reduces the live range of the loaded function pointer,
resulting in a slight code size decrease (~10KB i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324286: IRGen: Move vtable load after argument evaluation.
(authored by pcc, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42725?vs=132094&i
benhamilton added a comment.
@stephanemoore: It appears all warnings are enabled by default unless they are
in class `DefaultIgnore`:
https://github.com/llvm-mirror/clang/blob/6de2efd1953adaa9a190b2cdfbe7b5c15f6d6efe/include/clang/Basic/Diagnostic.td#L105
This diagnostic is not in `DefaultIgnor
arphaman created this revision.
arphaman added reviewers: ahatanak, vsapsai.
Herald added subscribers: jkorous-apple, kristof.beyls, aemerson.
The -Wformat recently started warning for the following code because of the
added support for analysis for the '%zi' specifier.
NSInteger i = NSInteger
sammccall added a comment.
This looks OK so far, where is it going? It doesn't make sense to put URIs in
if we only ever use `file:`.
I guess others will be produced by some kind of extension point on
SymbolCollector. That will specify URI schemes we should try, allow you to
replace the whole `
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324282: [demangler] Refactor the type parser (authored by
epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41889?vs=132747&id=132891#toc
Author: epilk
Date: Mon Feb 5 14:41:20 2018
New Revision: 324282
URL: http://llvm.org/viewvc/llvm-project?rev=324282&view=rev
Log:
[demangler] Refactor the type parser
Differential revision: https://reviews.llvm.org/D41889
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
Modified: libcxxabi/
sammccall added a subscriber: bkramer.
sammccall added a comment.
In https://reviews.llvm.org/D41102#998180, @thakis wrote:
> This should be in clang-tools-extra next to clang-tidy, clang-include-fixer,
> clangd etc, not in the main compiler repo, right?
I agree. I see there was earlier discus
sammccall added a comment.
Very nice! Thanks for adding the docs to TUScheduler implementation, makes a
big difference.
Rest is almost all readability/comment bits. Substantive stuff is:
- getUsedBytes() looks racy
- I'm not sure we're choosing the right preamble
My understanding is the thread
ro added a comment.
ping^2
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro added a comment.
ping^4
Repository:
rC Clang
https://reviews.llvm.org/D41241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro added a comment.
Could anyone please commit this for me?
Thanks.
Rainer
Repository:
rC Clang
https://reviews.llvm.org/D40903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro added a comment.
Could anyone please commit this for me?
Thanks.
Rainer
Repository:
rC Clang
https://reviews.llvm.org/D41242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
stephanemoore added a comment.
The summary states that -Wobjc-string-concatenation is enabled by default? I
looked through `include/clang/Basic/DiagnosticGroups.td` and did not see
evidence that `ObjCStringConcatenation` is under `All`. Am I missing something?
Is -Wobjc-string-concatenation ena
gregrodgers added a comment.
Here my replys to the inline comments. Everything should be fixed in the next
revision.
Comment at: include/clang/Basic/Cuda.h:79
COMPUTE_72,
+ COMPUTE_GCN,
};
t-tye wrote:
> Suggest using amdgcn which matches the architectu
Author: d0k
Date: Mon Feb 5 14:10:39 2018
New Revision: 324277
URL: http://llvm.org/viewvc/llvm-project?rev=324277&view=rev
Log:
[clangd] Add a cstring include for strerror.
Apparently this doesn't get included transitively on some systems.
Modified:
clang-tools-extra/trunk/clangd/Context.c
bogner added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:3269-3274
+ const bool IsAssertBuild =
#ifdef NDEBUG
- CmdArgs.push_back("-disable-llvm-verifier");
- // Discard LLVM value names in -asserts builds.
- CmdArgs.push_back("-discard-value-names");
+
NoQ added a comment.
Oh, i see what you did here. I thought you're evaluating the argument, but
you're evaluating the whole builtin function call. In this case you don't need
the else-branch: `EvaluateAsInt` will always succeed. Moreover, you can merge
your code with the `BI__builtin_object_siz
benhamilton added a comment.
Ping ping!
Repository:
rC Clang
https://reviews.llvm.org/D42704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
This should be in clang-tools-extra next to clang-tidy, clang-include-fixer,
clangd etc, not in the main compiler repo, right?
https://reviews.llvm.org/D41102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
jakehehrlich added a comment.
Additional note: This diff is a diff from your last commit not the full diff
relative to origin/master which is what should be up here.
Comment at: tools/clang-doc/ClangDoc.cpp:34
-bool ClangDocVisitor::VisitNamespaceDecl(const NamespaceDecl *D)
https://bugs.llvm.org/show_bug.cgi?id=36241
On Mon, Feb 5, 2018 at 10:20 AM Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This broke the Chromium build, see
> https://bugs.chromium.org/p/chromium/issues/detail?id=809050#c2
>
> I see there were a lot of changes landed aroun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324269: Add support for attribute 'trivial_abi'.
(authored by ahatanak, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41039?vs=129397&id=132
This revision was automatically updated to reflect the committed changes.
ahatanak marked 2 inline comments as done.
Closed by commit rC324269: Add support for attribute 'trivial_abi'.
(authored by ahatanak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41039?vs=129397&id=1
Author: ahatanak
Date: Mon Feb 5 12:23:22 2018
New Revision: 324269
URL: http://llvm.org/viewvc/llvm-project?rev=324269&view=rev
Log:
Add support for attribute 'trivial_abi'.
The 'trivial_abi' attribute can be applied to a C++ class, struct, or
union. It makes special functions of the annotated
vitalybuka updated this revision to Diff 132876.
vitalybuka marked 3 inline comments as done.
vitalybuka added a comment.
empty file test
https://reviews.llvm.org/D42680
Files:
clang/include/clang/CodeGen/BackendUtil.h
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/CodeGen/CodeGenAction.cpp
devnexen updated this revision to Diff 132873.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
espindola created this revision.
espindola added reviewers: sfertile, rnk.
I found this while looking at the ppc failures caused by the dso_local change.
The issue was that the patch would produce the wrong answer for
available_externally. Having ForDefinition_t available in places where the co
Hahnfeld planned changes to this revision.
Hahnfeld added a comment.
I didn't write tests for this yet, but I wanted to get some early feedback on
this and show what I have in mind.
Comment at: lib/CodeGen/CGCUDANV.cpp:330-331
// the GPU side.
for (const std::string &Gpu
Hahnfeld created this revision.
Hahnfeld added reviewers: jlebar, tra, hfinkel.
Herald added a subscriber: cfe-commits.
According to the CUDA Programming Guide this is prohibited in
whole program compilation mode. This makes sense because external
references cannot be satisfied in that mode anyway
Hahnfeld created this revision.
Hahnfeld added reviewers: jlebar, tra, hfinkel.
Herald added a subscriber: cfe-commits.
nvcc generates a unique registration function for each object file
that contains relocatable device code. Unique names are achieved
with a module id that is also reflected in the
Hahnfeld created this revision.
Hahnfeld added reviewers: jlebar, tra.
Herald added a subscriber: cfe-commits.
Hahnfeld added a dependency: D42920: [CUDA] Fix test cuda-external-tools.cu.
Hahnfeld added a reviewer: hfinkel.
As a first step, pass '-c/--compile-only' to ptxas so that it
doesn't comp
Hahnfeld created this revision.
Hahnfeld added reviewers: jlebar, tra.
Herald added a subscriber: cfe-commits.
Hahnfeld added a dependent revision: D42921: [CUDA] Add option to generate
relocatable device code.
This didn't verify the CHECK prefix before!
Repository:
rC Clang
https://reviews.
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
Instead of content-length, we delimit messages with ---.
This also removes the need for (most) dos-formatted test files.
Repository:
rCTE Clang Tool
juliehockett created this revision.
juliehockett added reviewers: aaron.ballman, alexfh, hokein.
Herald added a subscriber: xazax.hun.
Updating fuchsia-multiple-inheritance to not crash when a record inherits a
template.
Fixes PR36052.
https://reviews.llvm.org/D42918
Files:
clang-tidy/fuchs
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D41834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added inline comments.
Comment at: lib/Basic/Targets/AMDGPU.h:85
return TT.getEnvironmentName() == "amdgiz" ||
+ TT.getOS() == llvm::Triple::CUDA ||
TT.getEnvironmentName() == "amdgizcl";
t-tye wrote:
> We still want to use the a
t-tye added inline comments.
Comment at: include/clang/Basic/Cuda.h:49-57
+ GFX700,
+ GFX701,
+ GFX800,
+ GFX801,
+ GFX802,
+ GFX803,
+ GFX810,
Should complete list of processors for the amdgcn architecture be included? See
https://llvm.org/docs/AMDGPUUsa
Author: hahnfeld
Date: Mon Feb 5 10:19:40 2018
New Revision: 324259
URL: http://llvm.org/viewvc/llvm-project?rev=324259&view=rev
Log:
[Options] Make --cuda-path-ignore-env a Flag, NFCI.
This option doesn't take an argument!
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/
majnemer added a comment.
docs/LanguageExtensions.html should be updated to mention that we support this
extension on all ELF targets.
Repository:
rC Clang
https://reviews.llvm.org/D42758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
dblaikie added a comment.
Seems plausible - maybe walking the scopes to count the range-for loops would
produce a better number, but would be slower. :/ Dunno.
Comment at: lib/Sema/SemaStmt.cpp:2346
+// Assume the variables are nested in the inner scope (loop body).
+c
a.sidorin added a comment.
Hi David! The patch looks almost OK.
Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:65
+ *BT, "Both PROT_WRITE and PROT_EXEC flags are set. This can "
+ "lead to exploitable memory regions, which could be overw
compnerd updated this revision to Diff 132853.
compnerd added a comment.
clang-format missed line, simplify some checks
Repository:
rC Clang
https://reviews.llvm.org/D42758
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
lib/Parse/ParsePragma.cpp
test/CodeGen/elf-lin
ioeric created this revision.
ioeric added reviewers: hokein, sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42915
Files:
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/Merge.c
devnexen added a comment.
Correcting last typos in unit test.
Repository:
rC Clang
https://reviews.llvm.org/D42645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 132850.
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecC
erichkeane added a comment.
This seems pretty OK to me. I'd like to see @probinson s PS4 discussion bottom
out, but I don't see any reason to hold this up otherwise.
We definitely should leave the format as #pragma comment(keyword, "message"),
since there is significant prior art here.
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added subscribers: jkorous-apple, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42913
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: u
Typz updated this revision to Diff 132838.
Typz added a comment.
rebase
https://reviews.llvm.org/D37813
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Format/NamespaceEndCommentsFixer.cpp
lib/Format/TokenAnnota
Typz updated this revision to Diff 132837.
Typz added a comment.
Use StatementMacro detection to improve brace type detection heuristics (in
UnwrappedLineParser::calculateBraceTypes).
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/Fo
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:302
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
simark wrote:
> ilya-biryukov wrote:
> > simark wrote:
> > > simark wrote:
> > >
Author: mzeren-vmw
Date: Mon Feb 5 07:59:00 2018
New Revision: 324246
URL: http://llvm.org/viewvc/llvm-project?rev=324246&view=rev
Log:
[clang-format] Re-land: Fixup #include guard indents after parseFile()
Summary:
When a preprocessor indent closes after the last line of normal code we do not
c
I'll try to come up with a fix, thanks for spotting that.
On Sat, Feb 3, 2018 at 2:24 AM Eric Fiselier wrote:
> This causes some stray diagnostics to be emitted in certian cases where a
> base class is already invalid:
>
> Reproducer:
> https://gist.github.com/EricWF/588a361030edeaebbbc1155b834
devnexen updated this revision to Diff 132829.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
This broke the Chromium build, see
https://bugs.chromium.org/p/chromium/issues/detail?id=809050#c2
I see there were a lot of changes landed around the same time, so I'm
not sure what to revert here exactly.
On Sun, Feb 4, 2018 at 2:03 AM, Eric Fiselier via cfe-commits
wrote:
> Author: ericwf
> D
kosarev added a comment.
Hal, will you please take a look?
Repository:
rL LLVM
https://reviews.llvm.org/D42366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 132826.
Repository:
rC Clang
https://reviews.llvm.org/D42645
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp
test/Analysis/mmap-writeexec.c
I
devnexen added a comment.
Your remarks make sense. Ok will update the general "tone" accordingly.
Repository:
rC Clang
https://reviews.llvm.org/D42645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
jroelofs added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:399
+ def MmapWriteExecChecker : Checker<"MmapWriteExec">,
+HelpText<"Check if mmap() call is not both writable and executable">,
+DescFile<"MmapWriteExecChecker.cpp">;
chill updated this revision to Diff 132822.
chill added a comment.
Changes since last revision:
- Add/update test to check that each enumerator belongs to the right enumeration
https://reviews.llvm.org/D42736
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-enum.cpp
test/CodeGe
tejohnson added a comment.
This looks ok to me, assuming it produces the empty output file as I expect it
should. Please wait for pcc to take a look as well.
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:959
+if (!Bm)
+ return {};
Expected> MOrErr =
---
ilya-biryukov updated this revision to Diff 132821.
ilya-biryukov marked 13 inline comments as done.
ilya-biryukov added a comment.
- Removed ASTWorker files, moved all the code to TUScheduler.cpp
- Renamed setDone to stop
- Added a comment to TUScheduler.cpp
- Addressed other review comments
Re
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clangd/ASTWorker.cpp:1
+//===--- ASTWorker.cpp
*-C++-*-===//
+//
sammccall wrote:
> This file could really use some high-
Author: mzeren-vmw
Date: Mon Feb 5 06:47:04 2018
New Revision: 324239
URL: http://llvm.org/viewvc/llvm-project?rev=324239&view=rev
Log:
Revert "[clang-format] Fixup #include guard indents after parseFile()"
This reverts r324238 | mzeren-vmw | 2018-02-05 06:35:54 -0800 (Mon, 05 Feb
2018) | 35 li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324238: [clang-format] Fixup #include guard indents after
parseFile() (authored by mzeren-vmw, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
Author: mzeren-vmw
Date: Mon Feb 5 06:35:54 2018
New Revision: 324238
URL: http://llvm.org/viewvc/llvm-project?rev=324238&view=rev
Log:
[clang-format] Fixup #include guard indents after parseFile()
Summary:
When a preprocessor indent closes after the last line of normal code we do not
correctly
Author: hokein
Date: Mon Feb 5 05:23:48 2018
New Revision: 324235
URL: http://llvm.org/viewvc/llvm-project?rev=324235&view=rev
Log:
[clang-tidy] Fix incorrect code indention in the doc.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/objc-property-declaration.rst
Modified:
clang-t
sammccall added inline comments.
Comment at: clangd/ClangdServer.cpp:418
+ } else {
+auto U = URI::parse(HeaderUri);
+if (!U)
Pull out a function to compute ToInclude from a uri/abspath?
Comment at: clangd/ClangdServer.cpp:425
+
+a
Author: hokein
Date: Mon Feb 5 05:04:41 2018
New Revision: 324233
URL: http://llvm.org/viewvc/llvm-project?rev=324233&view=rev
Log:
[clang-tidy] tweak "misc-definitions-in-headers" doc, NFC.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-definitions-in-headers.rst
Modified:
ilya-biryukov updated this revision to Diff 132803.
ilya-biryukov added a comment.
- Changed interface of ASTWorker so that it runs the processing loop itself.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42573
Files:
clangd/ASTWorker.cpp
clangd/ASTWorker.h
clangd/CMake
sammccall added a comment.
Really coming together!
Comment at: clangd/ASTWorker.cpp:1
+//===--- ASTWorker.cpp
*-C++-*-===//
+//
This file could really use some high-level comments about the scheduling
strategy, thro
jolesiak created this revision.
Herald added subscribers: cfe-commits, klimek.
jolesiak added reviewers: krasimir, benhamilton.
A test commit.
Repository:
rC Clang
https://reviews.llvm.org/D42901
Files:
lib/Format/ContinuationIndenter.h
Index: lib/Format/ContinuationIndenter.h
==
1 - 100 of 108 matches
Mail list logo
