[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#997062, @NoQ wrote: > This failed on the buildbots (for example > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - > committer gets notified of those), so i reverted it for now as r324167. > > I guess the reason is

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132728. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132727. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. This failed on the buildbots (for example http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - committer gets notified of those), so i reverted it for now as r324167. I guess the reason is that buildbots have different triples, and even though you check the

r324167 - Revert r324166 "[analyzer] Add a checker for mmap()...".

Author: dergachev Date: Fri Feb 2 19:57:32 2018 New Revision: 324167 URL: http://llvm.org/viewvc/llvm-project?rev=324167&view=rev Log: Revert r324166 "[analyzer] Add a checker for mmap()...". Due to Buildbot failures - most likely that's because target triples were not specified in the tests, ev

[PATCH] D42875: [analyzer] Add construction context for ReturnStmt.

NoQ updated this revision to Diff 132720. NoQ added a comment. Add a test in which we return a variable. https://reviews.llvm.org/D42875 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp test/Analysis/temp-obj-dtors-cfg-output.cpp Index: test/Analysis/temp-obj-dtors-cfg

[PATCH] D42645: New simple Checker for mmap calls

This revision was automatically updated to reflect the committed changes. Closed by commit rC324166: [analyzer] Add a checker for mmap()s which are both writable and executable. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D42645?vs=132715&id=132719#

r324166 - [analyzer] Add a checker for mmap()s which are both writable and executable.

Author: dergachev Date: Fri Feb 2 18:33:42 2018 New Revision: 324166 URL: http://llvm.org/viewvc/llvm-project?rev=324166&view=rev Log: [analyzer] Add a checker for mmap()s which are both writable and executable. This is a security check which is disabled by default but will be enabled whenever t

[PATCH] D42876: [analyzer] Support returning objects by value.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. NoQ added dependencies: D42875: [analyzer] Add construction context for ReturnStmt., D42779: [analyzer] NFC: Make sure we don't ever inline th

[PATCH] D42645: New simple Checker for mmap calls

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fantastic, thanks! I'll commit. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132715. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[libcxx] r324165 - Work around GCC constexpr initialization bug

Author: ericwf Date: Fri Feb 2 17:48:21 2018 New Revision: 324165 URL: http://llvm.org/viewvc/llvm-project?rev=324165&view=rev Log: Work around GCC constexpr initialization bug Modified: libcxx/trunk/test/std/algorithms/alg.sorting/alg.lex.comparison/lexicographical_compare_comp.pass.cpp M

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. Wonderful! Could you also add a `// no-warning` kind of test, i.e. when the respective flags are not set, no warning is emitted? Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@l

[libcxx] r324164 - Work around Clang bug introduced in r324062

Author: ericwf Date: Fri Feb 2 17:45:35 2018 New Revision: 324164 URL: http://llvm.org/viewvc/llvm-project?rev=324164&view=rev Log: Work around Clang bug introduced in r324062 When Clang encounters an already invalid class declaration, it can emit incorrect diagnostics about the exception specif

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

> On Jan 31, 2018, at 9:15 AM, Akira Hatanaka wrote: > > > >> On Jan 30, 2018, at 4:32 PM, Saleem Abdulrasool > > wrote: >> >> Thanks for the note here. I’ll try to take a look at that, but, yes, the >> frontend change itself is correct. I’ve seen many, many

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#996668, @NoQ wrote: > All right, so the code looks good now, but in order to commit this, we also > need tests. We've got those automatic tests of ours in `test/Analysis/` that > feed small code snippets into the analyzer and verify t

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132713. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42875: [analyzer] Add construction context for ReturnStmt.

NoQ created this revision. NoQ added reviewers: rsmith, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This one's new, the analyzer didn't enjoy this before. This patch adds construction context for `ReturnStmt`, which means that we'd

Re: r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

This causes some stray diagnostics to be emitted in certian cases where a base class is already invalid: Reproducer: https://gist.github.com/EricWF/588a361030edeaebbbc1155b8347cab0 On Fri, Feb 2, 2018 at 1:40 AM, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryu

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

dblaikie accepted this revision. dblaikie added a comment. Few things that could tidy up the tests a bit, but otherwise looks good :) Comment at: test/CodeGen/debug-info-enum.cpp:6-10 +// CHECK: !DICompositeType(tag: DW_TAG_enumeration_type, name: "E0" +// CHECK-SAME: flags: DI

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324163: [hwasan] Add a paragraph on stack instrumentation. (authored by eugenis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42874?vs=1327

r324163 - [hwasan] Add a paragraph on stack instrumentation.

Author: eugenis Date: Fri Feb 2 17:06:21 2018 New Revision: 324163 URL: http://llvm.org/viewvc/llvm-project?rev=324163&view=rev Log: [hwasan] Add a paragraph on stack instrumentation. Reviewers: kcc Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D42874 Modified:

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM++ https://reviews.llvm.org/D42874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D42874: [hwasan] Add a paragraph on stack instrumentation.

eugenis created this revision. eugenis added a reviewer: kcc. https://reviews.llvm.org/D42874 Files: clang/docs/HardwareAssistedAddressSanitizerDesign.rst Index: clang/docs/HardwareAssistedAddressSanitizerDesign.rst === --- clang

[PATCH] D42721: [analyzer] NFC: Use construction contexts for finding the target region for the construction.

NoQ updated this revision to Diff 132707. NoQ added a comment. Rebase. https://reviews.llvm.org/D42721 Files: include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Index: lib/StaticAnalyzer/Core/ExprEngineCXX.c

[PATCH] D42404: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

NoQ added a comment. Woohoo even better. Repository: rC Clang https://reviews.llvm.org/D42404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42404: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rC324161: [analyzer] Do not infer nullability inside function-like macros, even when… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://r

r324161 - [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL

Author: george.karpenkov Date: Fri Feb 2 16:55:21 2018 New Revision: 324161 URL: http://llvm.org/viewvc/llvm-project?rev=324161&view=rev Log: [analyzer] Do not infer nullability inside function-like macros, even when macro is explicitly returning NULL We already suppress such reports for inline

r324160 - Fix crash when trying to pack-expand a GNU statement expression.

Author: rsmith Date: Fri Feb 2 16:44:57 2018 New Revision: 324160 URL: http://llvm.org/viewvc/llvm-project?rev=324160&view=rev Log: Fix crash when trying to pack-expand a GNU statement expression. We could in principle support such pack expansion, using techniques similar to what we do for pack

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka added a comment. PTAL https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 132702. vitalybuka marked an inline comment as done. vitalybuka added a comment. comment https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/

[PATCH] D42680: [ThinLTO] Ignore -fthinlto-index= for non-ThinLTO files

vitalybuka updated this revision to Diff 132701. vitalybuka added a comment. skip full LTO objects https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_backend.ll

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42719: [CFG] [analyzer] Add construction context when constructor is wrapped into ExprWithCleanups.

NoQ updated this revision to Diff 132699. NoQ added a comment. Rebase. Add direct tests, though one was already there since https://reviews.llvm.org/D42699 as a fixme. https://reviews.llvm.org/D42719 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp test/Analysis/temp-

[PATCH] D41039: Add support for attribute "trivial_abi"

rsmith accepted this revision. rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:2240-2241 + enum TrivialityKind { +TK_NoTrivialABI, // The triviality of a method unaffected by "trivial_abi". +TK_TrivialABI // The triviality of a method affected by "tri

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); erichkeane wrote: > compnerd wrote: > > erichkeane wrote: > > > rsmith wro

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. @sdardis Can you confirm if the existing N64 bits work fine for you or if the tests crash similarly? https://reviews.llvm.org/D39074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); compnerd wrote: > erichkeane wrote: > > rsmith wrote: > > > erichkeane w

[libcxx] r324153 - Fix has_unique_object_representation after Clang commit r324134.

Author: ericwf Date: Fri Feb 2 14:39:59 2018 New Revision: 324153 URL: http://llvm.org/viewvc/llvm-project?rev=324153&view=rev Log: Fix has_unique_object_representation after Clang commit r324134. Clang previously reported an empty union as having a unique object representation. This was incorre

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1061 +if (Ty->getAs()->getCallConv() == CC_Swift) + for (const char *NS : {"__swift_cc", "__Swift"}) +mangleSourceName(NS); rsmith wrote: > Do we really need both of these qu

r324151 - Add missing direct-init / parameter-declaration-clause disambiguation when

Author: rsmith Date: Fri Feb 2 14:24:54 2018 New Revision: 324151 URL: http://llvm.org/viewvc/llvm-project?rev=324151&view=rev Log: Add missing direct-init / parameter-declaration-clause disambiguation when parsing a trailing-return-type of a (function pointer) variable declaration. Modified:

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132685. NoQ added a comment. Rename the method, add comments. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h include/clang/StaticAnalyz

r324142 - More documentation cleanup for Decl.h.

Author: jdennett Date: Fri Feb 2 13:38:22 2018 New Revision: 324142 URL: http://llvm.org/viewvc/llvm-project?rev=324142&view=rev Log: More documentation cleanup for Decl.h. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

aemerson added a comment. @Hans if you're happy with this could you commit to the branch? Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:653 + // triggered by the given trigger. + void VisitForConstructionContext(Stmt *Trigger, Stmt *Child); + dcoughlin wrote: > I find the name of this method very confusing. It sounds like you are > vi

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

Yeah, I'll write stuff up for them. On Fri, Feb 2, 2018 at 3:06 AM Hans Wennborg wrote: > Thanks! I've merged them to 6.0 as below and they will be part of rc2, > scheduled for next week. > > Chandler, do you want to write release notes for this? > > On Thu, Feb 1, 2018 at 8:09 PM, Chandler Carr

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me, although as I noted inline I think both the name and the comment for VisitForConstructionContext() are confusing. If you can be more precise I think it would help

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. All right, so the code looks good now, but in order to commit this, we also need tests. We've got those automatic tests of ours in `test/Analysis/` that feed small code snippets into the analyzer and verify that it does (or doesn't) emit warnings in certain cases, so you'd

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324134: Make __has_unique_object_representations reject empty union types. (authored by EricWF, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42863 Files: lib/AST/ASTContext.cpp te

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Yep, LGTM, thanks! https://reviews.llvm.org/D42863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

benhamilton created this revision. benhamilton added reviewers: stephanemoore, jolesiak, djasper. Herald added subscribers: cfe-commits, klimek. benhamilton edited the summary of this revision. benhamilton edited the summary of this revision. In r236412, @djasper added a comment: // FIXME: We l

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton marked 2 inline comments as done. benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(to

r324134 - Make __has_unique_object_representations reject empty union types.

Author: ericwf Date: Fri Feb 2 12:30:39 2018 New Revision: 324134 URL: http://llvm.org/viewvc/llvm-project?rev=324134&view=rev Log: Make __has_unique_object_representations reject empty union types. Summary: Clang incorrectly reports empty unions as having a unique object representation. Howeve

[PATCH] D42863: Make __has_unique_object_representations reject empty union types.

EricWF created this revision. EricWF added reviewers: erichkeane, rsmith, aaron.ballman, majnemer. Clang incorrectly reports empty unions as having a unique object representation. However, this is not correct since `sizeof(EmptyUnion) == 1` AKA it has 8 bits of padding. Therefore it should be tr

r324133 - Documentation cleanup, no functional change.

Author: jdennett Date: Fri Feb 2 12:22:29 2018 New Revision: 324133 URL: http://llvm.org/viewvc/llvm-project?rev=324133&view=rev Log: Documentation cleanup, no functional change. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/

r324132 - [clang-proto-to-cxx] Accept protobufs with missing fields.

Author: morehouse Date: Fri Feb 2 12:22:20 2018 New Revision: 324132 URL: http://llvm.org/viewvc/llvm-project?rev=324132&view=rev Log: [clang-proto-to-cxx] Accept protobufs with missing fields. libprotobuf-mutator accepts protobufs with missing fields, which means clang-proto-fuzzer does as well

[PATCH] D42014: Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

stephanemoore abandoned this revision. stephanemoore added a comment. After talking with Ben I think I will abandon this and we'll focus on separating Objective-C protocol list formatting out of BinPackParameters. https://reviews.llvm.org/D42014 __

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

This revision was automatically updated to reflect the committed changes. Closed by commit rC324131: [clang-format] New format param ObjCBinPackProtocolList (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42650?vs=132187&id=132650#toc Repository:

r324131 - [clang-format] New format param ObjCBinPackProtocolList

Author: benhamilton Date: Fri Feb 2 12:15:14 2018 New Revision: 324131 URL: http://llvm.org/viewvc/llvm-project?rev=324131&view=rev Log: [clang-format] New format param ObjCBinPackProtocolList Summary: This is an alternative approach to D42014 after some investigation by stephanemoore@ and mysel

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); rsmith wrote: > erichkeane wrote: > > When I implemented regcall, it was

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

rjmccall added a comment. No, really, in CreateBuiltinArraySubscriptExpr and LookupMemberExpr, in the clauses where they handle vector types, you just need to propagate qualifiers from the base type like is done in BuildFieldReferenceExpr. There's even a FIXME about it in the former. https:/

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

rsmith added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1061 +if (Ty->getAs()->getCallConv() == CC_Swift) + for (const char *NS : {"__swift_cc", "__Swift"}) +mangleSourceName(NS); Do we really need both of these qualifiers? This see

[PATCH] D42829: Emit label names according to -discard-value-names.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324127: Emit label names according to -discard-value-names. (authored by EricWF, committed by ). Repository: rC Clang https://reviews.llvm.org/D42829 Files: lib/CodeGen/CodeGenFunction.h test/Cod

r324127 - Emit label names according to -discard-value-names.

Author: ericwf Date: Fri Feb 2 11:58:34 2018 New Revision: 324127 URL: http://llvm.org/viewvc/llvm-project?rev=324127&view=rev Log: Emit label names according to -discard-value-names. Summary: Previously, Clang only emitted label names in assert builds. However there is a CC1 option -discard-va

[PATCH] D42829: Emit label names according to -discard-value-names.

EricWF updated this revision to Diff 132648. EricWF marked an inline comment as done. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D42829 Files: lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/discard-name-values.cpp Index: test/CodeGenCXX/discard-name-values.

[PATCH] D42829: Emit label names according to -discard-value-names.

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: test/CodeGenCXX/discard-name-values.cpp:7 -// CHECK: ret i32 %bar -// DISCARDVALUE: ret i32 %0 +extern "C" void branch(); + aaron.ballman wrote: > Indentation is a bit off here.

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

aemerson created this revision. aemerson added reviewers: hans, qcolombet. Add note for the new -fexperimental-isel flag. Repository: rC Clang https://reviews.llvm.org/D42860 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ===

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:3899 + if (auto *CE = const_cast(NE->getConstructExpr())) +CurrentConstructionContext = {/*Constructor=*/CE, /*Trigger=*/NE}; + NoQ wrote: > dcoughlin wrote: > > Is it possible that there is already

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132637. NoQ added a comment. Whoops! Actually use the new function with the assertion. Also disable creating construction contexts when the flag is off. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analy

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

erichkeane added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:1717 +Out << '8'; +for (const char *NS : {"__swift_cc", "__Swift"}) + mangleSourceName(NS); When I implemented regcall, it was brought up that this was likely a bad

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd marked 2 inline comments as done. compnerd added a comment. @probinson it would be pretty cool if we could get the PS4 environment to share the same linker options implementation. What other options do you guys need for this to be a viable approach? Repository: rC Clang https://re

r324114 - [analyzer] [tests] Fix crash in SATestBuild.py

Author: george.karpenkov Date: Fri Feb 2 10:27:14 2018 New Revision: 324114 URL: http://llvm.org/viewvc/llvm-project?rev=324114&view=rev Log: [analyzer] [tests] Fix crash in SATestBuild.py Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified: cfe/trunk/utils/analyzer/CmpRuns.py URL: http

[PATCH] D42857: testing phabricator email reply

ioeric created this revision. Herald added subscribers: cfe-commits, klimek. ioeric removed rCTE Clang Tools Extra as the repository for this revision. ioeric removed subscribers: klimek, cfe-commits. ioeric added a comment. top Comment Comment at: change-namespace/ChangeNamesp

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324113: [Tooling] Returns non-zero status code when files are skipped. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42361

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324113: [Tooling] Returns non-zero status code when files are skipped. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D42361?vs=132624&id=132626#toc Repository:

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

ioeric updated this revision to Diff 132624. ioeric added a comment. removed FIXME Repository: rC Clang https://reviews.llvm.org/D42361 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp Index: lib/Tooling/Tooling.cpp

r324113 - [Tooling] Returns non-zero status code when files are skipped.

Author: ioeric Date: Fri Feb 2 10:19:22 2018 New Revision: 324113 URL: http://llvm.org/viewvc/llvm-project?rev=324113&view=rev Log: [Tooling] Returns non-zero status code when files are skipped. Reviewers: hokein, bkramer Reviewed By: bkramer Subscribers: bkramer, klimek, cfe-commits Differen

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

sammccall added a comment. TL;DR: - I think we can expose fewer types/abstractions in the header mapping, and put it all in one header. If we want some functionality to be global-index only, we should make it an option to the symbolcollector, not stash the logic somewhere else I think. - regex

[PATCH] D41887: [libcxxabi][demangler] Clean up and llvm-ify the expression parser

This revision was automatically updated to reflect the committed changes. Closed by commit rL324111: [demangler] Clean up the expression parser (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41887?vs=132279&id=1326

r324108 - Revert "Start setting dso_local in clang."

Author: rafael Date: Fri Feb 2 09:29:22 2018 New Revision: 324108 URL: http://llvm.org/viewvc/llvm-project?rev=324108&view=rev Log: Revert "Start setting dso_local in clang." This reverts commit r324107. I will have to test it on OS X. Removed: cfe/trunk/test/CodeGen/dso-local-executable.c

[PATCH] D41318: Start setting dso_local in clang

espindola closed this revision. espindola added a comment. r324107 https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324107 - Start setting dso_local in clang.

Author: rafael Date: Fri Feb 2 09:17:39 2018 New Revision: 324107 URL: http://llvm.org/viewvc/llvm-project?rev=324107&view=rev Log: Start setting dso_local in clang. This starts adding dso_local to clang. The hope is to eventually have TargetMachine::shouldAssumeDsoLocal go away. My objective f

[clang-tools-extra] r324105 - [clangd] Fix ExternC test broken by r324081

Author: sammccall Date: Fri Feb 2 09:01:36 2018 New Revision: 324105 URL: http://llvm.org/viewvc/llvm-project?rev=324105&view=rev Log: [clangd] Fix ExternC test broken by r324081 Modified: clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp Modified: clang-tools-extra/trunk/un

[PATCH] D42361: [Tooling] Returns non-zero status code when files are skipped.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Removing FIXME seems right to me. Repository: rC Clang https://reviews.llvm.org/D42361 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

avt77 updated this revision to Diff 132607. avt77 added a comment. I re-implemented the patch. Now it works properly with const methods in CXX classes. https://reviews.llvm.org/D42530 Files: lib/AST/ExprClassification.cpp lib/Sema/SemaExpr.cpp test/Sema/assign.c test/Sema/typedef-retai

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

rjmccall added a comment. If you just want a better diagnostic, there's quite a bit of machinery already set up to give more specific errors about why such-and-such l-value isn't modifiable. There may even be vector-specific diagnostics for that already, just triggered from the wrong place in

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( ilya-biryukov wrote: > simark wrote: > > simark wrote: > > > ilya-biryukov wrote: > > >

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket == tok::l_pa

[PATCH] D40956: [AMDGPU] Switch to the new addr space mapping by default for clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL324102: [AMDGPU] Switch to the new addr space mapping by default (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D40956?vs

r324102 - [AMDGPU] Switch to the new addr space mapping by default

Author: yaxunl Date: Fri Feb 2 08:08:24 2018 New Revision: 324102 URL: http://llvm.org/viewvc/llvm-project?rev=324102&view=rev Log: [AMDGPU] Switch to the new addr space mapping by default This requires corresponding llvm change. Differential Revision: https://reviews.llvm.org/D40956 Modified:

[PATCH] D41318: Start setting dso_local in clang

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

koldaniel updated this revision to Diff 132595. https://reviews.llvm.org/D40787 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.h docs/ReleaseNotes

[PATCH] D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

This revision was automatically updated to reflect the committed changes. Closed by commit rL324098: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

r324098 - [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

Author: erichkeane Date: Fri Feb 2 07:53:35 2018 New Revision: 324098 URL: http://llvm.org/viewvc/llvm-project?rev=324098&view=rev Log: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen When trying to track down a different bug, we discovered that calling __builtin_va_arg on a ve

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132592. massberg marked an inline comment as done. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidy

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill marked 3 inline comments as done. chill added inline comments. Comment at: test/CodeGen/debug-info-enum.cpp:2 +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +enum class E0 : signed char { + A0 = -128, dblaikie wrote: > Could y

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

This revision was automatically updated to reflect the committed changes. Closed by commit rL324097: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value… (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://re

[clang-tools-extra] r324097 - [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

Author: benhamilton Date: Fri Feb 2 07:34:33 2018 New Revision: 324097 URL: http://llvm.org/viewvc/llvm-project?rev=324097&view=rev Log: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param Summary: The following Objective-C code currently incorrectly triggers cl

  1   2   >