[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

This revision was automatically updated to reflect the committed changes. Closed by commit rL323179: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

omalyshe accepted this revision. omalyshe added a comment. LGTM https://reviews.llvm.org/D42352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld updated this revision to Diff 131004. Hahnfeld marked 3 inline comments as done. Hahnfeld added a comment. Fix `macOS`. https://reviews.llvm.org/D42352 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === ---

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

omalyshe added inline comments. Comment at: docs/ReleaseNotes.rst:226 +- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface (OMPT) + on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you observe + a measurable performance impact on one

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld added inline comments. Comment at: docs/ReleaseNotes.rst:226 +- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface (OMPT) + on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you observe + a measurable performance impact on one

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

wmi added a comment. Thanks for the size evaluation. I regarded the change as a natural and limited extension to the current fine-grain bitfield access mode, so I feel ok with the change. Hal, what do you think? https://reviews.llvm.org/D39053 ___

[PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks! Maybe the assertion message could be clearer about why this is a problem though? ("binds to a temporary whose lifetime has ended" maybe?) https://reviews.llvm.org/D41977

[PATCH] D42408: [clang-format] Align preprocessor comments with #

mzeren-vmw created this revision. mzeren-vmw added reviewers: krasimir, klimek, djasper. r312125, which introduced preprocessor indentation, shipped with a known issue where "indentation of comments immediately before indented preprocessor lines is toggled on each run". For example these two forms

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

omalyshe added inline comments. Comment at: docs/ReleaseNotes.rst:226 +- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface (OMPT) + on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. If you observe + a measurable performance impact on one

r323177 - [NFC] fix trivial typos in comments

Author: inouehrs Date: Mon Jan 22 21:50:06 2018 New Revision: 323177 URL: http://llvm.org/viewvc/llvm-project?rev=323177&view=rev Log: [NFC] fix trivial typos in comments "the the" -> "the" Modified: cfe/trunk/include/clang/Basic/AddressSpaces.h cfe/trunk/include/clang/CodeGen/ConstantI

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

phosek added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152 + llvm::sys::path::append(P, normalizeTriple(Triple)); + return P.str(); +} mcgrathr wrote: > The GCC behavior (if --with-sysroot is given to configure) is > tooldir/sys-root, not

[libcxx] r323171 - [cmake] Always respect existing CMAKE_REQUIRED_FLAGS when adding additional ones.

Author: dhinton Date: Mon Jan 22 19:30:23 2018 New Revision: 323171 URL: http://llvm.org/viewvc/llvm-project?rev=323171&view=rev Log: [cmake] Always respect existing CMAKE_REQUIRED_FLAGS when adding additional ones. * Previously part of https://reviews.llvm.org/D41622. Modified: libcxx/trun

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

vsapsai added inline comments. Comment at: Parse/ParseTemplate.cpp:492 + // Is there just a typo in the input code? ('typedef' instead of 'typename') + if (Tok.is(tok::kw_typedef)) { +Diag(Tok.getLocation(), diag::err_expected_template_parameter); How does

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323170: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t*… (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[libcxx] r323170 - libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

Author: pcc Date: Mon Jan 22 18:07:27 2018 New Revision: 323170 URL: http://llvm.org/viewvc/llvm-project?rev=323170&view=rev Log: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows. This is an MSVC standard library extension. It seems like a reasona

[libcxx] r323169 - libcxx: Move Windows threading support into a .cpp file.

Author: pcc Date: Mon Jan 22 17:59:43 2018 New Revision: 323169 URL: http://llvm.org/viewvc/llvm-project?rev=323169&view=rev Log: libcxx: Move Windows threading support into a .cpp file. This allows us to avoid polluting the namespace of users of with the definitions in windows.h. Differential

[PATCH] D35472: Implement P0463R1: "Endian just Endian"

mclow.lists updated this revision to Diff 130991. mclow.lists added a comment. Update macro checks. https://reviews.llvm.org/D35472 Files: include/type_traits test/std/utilities/meta/meta.type.synop/endian.pass.cpp Index: test/std/utilities/meta/meta.type.synop/endian.pass.cpp ===

[PATCH] D42154: Don't generate inline atomics for i386/i486

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Well, my point is that the example in the linked bug is asking for 486 code-generation, which is apparently unsupported by LLVM. Anyway, it's not a good reason to hold up this patch, since

r323167 - NewPM: Improve/fix GCOV - which needs to run early in the pass pipeline.

Author: dblaikie Date: Mon Jan 22 17:25:24 2018 New Revision: 323167 URL: http://llvm.org/viewvc/llvm-project?rev=323167&view=rev Log: NewPM: Improve/fix GCOV - which needs to run early in the pass pipeline. Using a new extension point in the new PM, register GCOV at the start of the pipeline rat

[PATCH] D42036: [clang-format] Keep comments aligned to macros

mzeren-vmw added a comment. In https://reviews.llvm.org/D42036#984401, @djasper wrote: > To me, aligning with the define seems fundamentally wrong. we definitely have code that does that internally. It can also be seen in the wild e.g.: https://github.com/boostorg/config/blob/develop/include/b

[PATCH] D42319: [CUDA] CUDA has no device-side library builtins.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Got it, thanks for the explanation. https://reviews.llvm.org/D42319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D42376: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1579 (Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")"))) { + unsigned UnbreakableTailLength = (State.NextToken && canBreak(State)) +

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap updated this revision to Diff 130979. Repository: rL LLVM https://reviews.llvm.org/D42396 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c === --- test/Analysis/

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie added a comment. In https://reviews.llvm.org/D42354#984067, @STL_MSFT wrote: > Seems reasonable to me. Thanks Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

NoQ added a comment. Hmm, the original code seems quite quick-and-dirty. It, indeed, tries to blindly dereference something that's accidentally "some pointer". Could you change the type check to consider AST types instead, i.e. check that `(*I)->getType()` is a double-pointer type? And then pas

[PATCH] D42036: [clang-format] Keep comments aligned to macros

djasper added a comment. While I agree that there is probably a bug to fix, I don't (yet) agree with what is proposed in this patch. I think a comment in between preprocessor directives should always either: - Be considered part of the code in between the #-lines - Be considered to be commentin

[libcxx] r323160 - Update cxx2a status

Author: marshall Date: Mon Jan 22 15:17:20 2018 New Revision: 323160 URL: http://llvm.org/viewvc/llvm-project?rev=323160&view=rev Log: Update cxx2a status Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.org/viewvc/llvm-project/libcx

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton updated this revision to Diff 130970. benhamilton added a comment. - Support AssumeFileName with stdin. Repository: rC Clang https://reviews.llvm.org/D42395 Files: test/Format/dump-config-cxx.h test/Format/dump-config-objc.h test/Format/lit.local.cfg tools/clang-format/Cl

[libcxx] r323159 - Last batch of P0202 constexpr additions: includes/set_intersection/exchange

Author: marshall Date: Mon Jan 22 15:10:40 2018 New Revision: 323159 URL: http://llvm.org/viewvc/llvm-project?rev=323159&view=rev Log: Last batch of P0202 constexpr additions: includes/set_intersection/exchange Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/utility lib

[PATCH] D42319: [CUDA] CUDA has no device-side library builtins.

tra added a comment. In https://reviews.llvm.org/D42319#983377, @jlebar wrote: > How does this affect e.g. calling memcpy()? There isn't a standard library > implementation of this on nvptx, but we do want calls to memcpy() to be > lowered to llvm.memcpy so that they can be optimized. We imp

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap updated this revision to Diff 130967. alexshap added a comment. indents Repository: rL LLVM https://reviews.llvm.org/D42396 Files: lib/StaticAnalyzer/Core/PathDiagnostic.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c ==

[PATCH] D42273: Add hasTrailingReturn AST matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rC323158: Add hasTrailingReturn AST matcher (authored by juliehockett, committed by ). Repository: rC Clang https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/AST

r323158 - Add hasTrailingReturn AST matcher

Author: juliehockett Date: Mon Jan 22 14:45:23 2018 New Revision: 323158 URL: http://llvm.org/viewvc/llvm-project?rev=323158&view=rev Log: Add hasTrailingReturn AST matcher Adds AST matcher for a FunctionDecl that has a trailing return type. Differential Revision: https://reviews.llvm.org/D42273

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap created this revision. alexshap added reviewers: NoQ, dcoughlin. Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun. Do not attempt to get the pointee of void* while generating a bug report (otherwise it will trigger an assert inside RegionStoreManager::getBinding asse

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

This revision was automatically updated to reflect the committed changes. Closed by commit rC323157: [ASTMatchers] [NFC] Fix code examples (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42213?vs=130922&id=130965#toc Repository: rC Clang https://revi

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

This revision was automatically updated to reflect the committed changes. Closed by commit rC323156: Reland "[CodeGen] Fix crash when a function taking transparent union is… (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41311?vs=130038&id=130964#toc R

r323156 - Reland "[CodeGen] Fix crash when a function taking transparent union is redeclared."

Author: vsapsai Date: Mon Jan 22 14:29:24 2018 New Revision: 323156 URL: http://llvm.org/viewvc/llvm-project?rev=323156&view=rev Log: Reland "[CodeGen] Fix crash when a function taking transparent union is redeclared." When a function taking transparent union is declared as taking one of union m

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing.

xazax.hun added a comment. In https://reviews.llvm.org/D42335#983878, @a.sidorin wrote: > Hello Peter, > > Thank you for the patch! It is almost LGTM, just a few minor questions inline. > Am I understand correctly that it is partially based on > https://github.com/haoNoQ/clang/blob/summary-ipa-

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing.

xazax.hun updated this revision to Diff 130961. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Address review comments. https://reviews.llvm.org/D42335 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp ==

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton created this revision. benhamilton added reviewers: jolesiak, krasimir. Herald added a subscriber: cfe-commits. `clang-format -dump-config path/to/file.h` never passed anything for the Code parameter to clang::format::getStyle(). This meant the logic to guess Objective-C from the cont

r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injec

Author: chandlerc Date: Mon Jan 22 14:05:25 2018 New Revision: 323155 URL: http://llvm.org/viewvc/llvm-project?rev=323155&view=rev Log: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2

[libcxx] r323152 - Another batch of P0202 constepr algirithms. remove/remove_if/remove_copy/remove_copy_if/reverse_copy, and tests (commented out) for rotate_copy, because that depends on std::copy

Author: marshall Date: Mon Jan 22 13:43:04 2018 New Revision: 323152 URL: http://llvm.org/viewvc/llvm-project?rev=323152&view=rev Log: Another batch of P0202 constepr algirithms. remove/remove_if/remove_copy/remove_copy_if/reverse_copy, and tests (commented out) for rotate_copy, because that dep

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

JonasToth added a comment. The guideline authors will focus on mixing integer length and integer signdness. > Thank you for the suggestion! Per our editor's discussion, we agree with "If > one then mixes integer lengths and signedness in calculations confusion on > what happens might occur" and

[clang-tools-extra] r323149 - [clangd] Drop ~destructor completions - rarely helpful and work inconsistently

Author: sammccall Date: Mon Jan 22 13:05:00 2018 New Revision: 323149 URL: http://llvm.org/viewvc/llvm-project?rev=323149&view=rev Log: [clangd] Drop ~destructor completions - rarely helpful and work inconsistently Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp clang-tools-extr

r323148 - [CodeComplete] Omit templated constructors from member list too.

Author: sammccall Date: Mon Jan 22 12:44:47 2018 New Revision: 323148 URL: http://llvm.org/viewvc/llvm-project?rev=323148&view=rev Log: [CodeComplete] Omit templated constructors from member list too. Also avoid printing a 'void' return type for constructor expressions. Modified: cfe/trunk/l

[libcxx] r323147 - Still more P0202 constexpr-ifying. This batch is: for_each/for_each_n/lexicographical_compare

Author: marshall Date: Mon Jan 22 12:44:33 2018 New Revision: 323147 URL: http://llvm.org/viewvc/llvm-project?rev=323147&view=rev Log: Still more P0202 constexpr-ifying. This batch is: for_each/for_each_n/lexicographical_compare Modified: libcxx/trunk/include/algorithm libcxx/trunk/test

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL323146: [analyzer] Protect against dereferencing a null pointer (authored by alexshap, committed by ). Changed prior to commit: https://reviews.llvm.org/D42388?vs=130935&id=130946#toc Repository: rL

r323146 - [analyzer] Protect against dereferencing a null pointer

Author: alexshap Date: Mon Jan 22 12:18:42 2018 New Revision: 323146 URL: http://llvm.org/viewvc/llvm-project?rev=323146&view=rev Log: [analyzer] Protect against dereferencing a null pointer The check (inside StackHintGeneratorForSymbol::getMessage) if (!N) return getMessageForSymbolNotFound(

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp:45 + + if ((C = Result.Nodes.getNodeAs("call_expr"))) { +BeginLoc = C->getLocStart(); Can remove spurious parens. Comment at: docs/clang-t

[PATCH] D42273: Add hasTrailingReturn AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D42273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Do you need me to commit on your behalf? Repository: rC Clang https://reviews.llvm.org/D42213 ___ cfe-commits m

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

alexshap added a comment. no, i have not seen any crashes related to this particular case, but i've been working on a fix for a separate issue (a bit more involved) (not far from here) (I will send a diff for review soon) and decided to clean it up as well. Repository: rL LLVM https://revi

[PATCH] D41623: [cmake] [libcxxabi] Fix find_path() problems when cross compiling

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL323145: [cmake] [libcxxabi] Fix find_path() problems when cross compiling (authored by dhinton, committed by ). Herald a

[libcxxabi] r323145 - [cmake] [libcxxabi] Fix find_path() problems when cross compiling

Author: dhinton Date: Mon Jan 22 11:41:05 2018 New Revision: 323145 URL: http://llvm.org/viewvc/llvm-project?rev=323145&view=rev Log: [cmake] [libcxxabi] Fix find_path() problems when cross compiling When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake recommends setting CMAKE_FIND_ROOT_PATH_

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

NoQ accepted this revision. NoQ added a reviewer: george.karpenkov. NoQ added a comment. This revision is now accepted and ready to land. Neat. I wonder if you've actually found it by running the analyzer :) Did it crash or just made sense to fix, i.e. should there be tests? Repository: rL LL

[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

alexshap created this revision. alexshap added reviewers: NoQ, dcoughlin. Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun. The check (inside StackHintGeneratorForSymbol::getMessage) if (!N) return getMessageForSymbolNotFound() is moved to the beginning of the functio

[PATCH] D41622: [cmake] [libcxx] Fix find_path() problems when cross compiling.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323143: [cmake] [libcxx] Fix find_path() problems when cross compiling. (authored by dhinton, committed by ). Herald added

[libcxx] r323143 - [cmake] [libcxx] Fix find_path() problems when cross compiling.

Author: dhinton Date: Mon Jan 22 11:26:38 2018 New Revision: 323143 URL: http://llvm.org/viewvc/llvm-project?rev=323143&view=rev Log: [cmake] [libcxx] Fix find_path() problems when cross compiling. When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake recommends setting CMAKE_FIND_ROOT_PATH_MO

[PATCH] D41621: [cmake] [libunwind] Fix find_path() problems when cross compiling

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL323141: [cmake] [libunwind] Fix find_path() problems when cross compiling (authored by dhinton, committed by ). Herald a

[libunwind] r323141 - [cmake] [libunwind] Fix find_path() problems when cross compiling

Author: dhinton Date: Mon Jan 22 11:15:06 2018 New Revision: 323141 URL: http://llvm.org/viewvc/llvm-project?rev=323141&view=rev Log: [cmake] [libunwind] Fix find_path() problems when cross compiling When CMAKE_SYSROOT or CMAKE_FIND_ROOT_PATH is set, cmake recommends setting CMAKE_FIND_ROOT_PATH_

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Thanks for working on this! Comment at: src/cxa_demangle.cpp:260-261 + +#if 0 + void dump() const { +char *Buffer = static_cast(std::malloc(1024)); ---

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

STL_MSFT added a comment. Seems reasonable to me. Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42073: [clangd] Use accessible scopes to query indexes for global code completion.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.cpp:868 +} +log(Ctx, "Query scopes: ["); +for (auto &R : Req.Scopes) hokein wrote: > sammccall wrote: >

[libcxx] r323137 - Add (commented out) constexpr tests for copy/copy_backwards/copy_if/copy_n. These will be enabled when that part of P0202 is implemented. NFC at this time.

Author: marshall Date: Mon Jan 22 10:38:18 2018 New Revision: 323137 URL: http://llvm.org/viewvc/llvm-project?rev=323137&view=rev Log: Add (commented out) constexpr tests for copy/copy_backwards/copy_if/copy_n. These will be enabled when that part of P0202 is implemented. NFC at this time. Modi

[PATCH] D42371: Issue local statics in correct DWARF lexical scope

probinson added subscribers: cfe-commits, probinson. probinson added a comment. +cfe-commits See also the LLVM change in https://reviews.llvm.org/D42369 and Clang change in https://reviews.llvm.org/D42370. https://reviews.llvm.org/D42371 ___ cfe-co

[PATCH] D42370: Issue local statics in correct DWARF lexical scope

probinson added subscribers: cfe-commits, probinson. probinson added a comment. +cfe-commits See also the LLVM change in https://reviews.llvm.org/D42369 and a debuginfo-tests test in https://reviews.llvm.org/D42371. https://reviews.llvm.org/D42370

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington added a comment. Ping! Repository: rCXXA libc++abi https://reviews.llvm.org/D41885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130922. MaskRay added a comment. Regenerate HTML docs $ cd docs/tools # yes, cd $ ./dump_ast_matchers.py Repository: rC Clang https://reviews.llvm.org/D42213 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h Index: in

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

vsk added a reviewer: arphaman. vsk added a comment. In https://reviews.llvm.org/D42043#981409, @elsteveogrande wrote: > Fixes, but first, a question for reviewers: > > Looking at the description of `clang_disposeString`: > > /** >* \brief Free the given string. >*/ > CINDEX_LINKAGE v

[PATCH] D41039: Add support for attribute "trivial_abi"

ahatanak added a comment. Yes, please document this in itanium-cxx-abi. Thanks! https://reviews.llvm.org/D41039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

mclow.lists added inline comments. Comment at: include/algorithm:2511 +difference_type __len1, __len2; +__len1 = __middle - __first; +__len2 = __last - __middle; These iterator calculations only work for random access iterators. Does this actually wor

[PATCH] D42154: Don't generate inline atomics for i386/i486

wmi added a comment. In https://reviews.llvm.org/D42154#983840, @rjmccall wrote: > In https://reviews.llvm.org/D42154#977991, @wmi wrote: > > > In https://reviews.llvm.org/D42154#977975, @efriedma wrote: > > > > > The LLVM backend currently assumes every CPU is Pentium-compatible. If > > > we'r

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

aprantl added a comment. If we take https://reviews.llvm.org/D42350, taking this is fairly obvious, though it could use a testcase. Repository: rC Clang https://reviews.llvm.org/D42351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks for adding the test! LGTM, will submit it shortly. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL323133: [CodeComplete] Fix completion in the middle of idents in macro calls (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.or

r323133 - [CodeComplete] Fix completion in the middle of idents in macro calls

Author: ibiryukov Date: Mon Jan 22 09:18:28 2018 New Revision: 323133 URL: http://llvm.org/viewvc/llvm-project?rev=323133&view=rev Log: [CodeComplete] Fix completion in the middle of idents in macro calls Summary: This patch removes IdentifierInfo from completion token after remembering the ident

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

sammccall added a comment. Herald added a subscriber: ioeric. So, I simultaneously think this is basically ready to land, and I want substantial changes :-) This is much better already than what we have, and where I think we can further improve the design, this is a natural point on the way. M

[PATCH] D42036: [clang-format] Keep comments aligned to macros

krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1725 + NextNonComment.Type == LT_ImportStatement) && + NextNonComment.Level > 0 && !Comment.InPPDirective) +return NextNonComment.First->Next && Why are we checking `NextNonC

[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenTBAA.h:67 /* BaseType= */ nullptr, /* AccessType= */ nullptr, - /* Offset= */ 0, /* Size= */ 0); + /* Offset= */ 0, /* Size= */ UINT64_MAX);

[PATCH] D42318: [ARM] Pass _Float16 as int or float

SjoerdMeijer added a comment. Thanks for reviewing! We are trying to achieve correct AAPCS parameter passing: "If the argument is a Half-precision Floating Point Type its size is set to 4 bytes as if it had been copied to the least significant bits of a 32-bit register and the remaining bits

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett updated this revision to Diff 130908. juliehockett added a comment. Adding test case -- thank you for the advice! https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rjmccall added a comment. This is definitely something that the personality function should handle. If we want to do heroic things in the absence of personality function support, we can, but the code should at least be written to be conditional on personality support. If we can rev the person

[PATCH] D42360: [6.0.0 Release] Release notes for configuration files in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL323132: [6.0.0 Release] Release notes for configuration files in clang (authored by sepavloff, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D423

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

koldaniel updated this revision to Diff 130905. https://reviews.llvm.org/D40787 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.cpp clang-tidy/modernize/UseUncaughtExceptionsCheck.h docs/ReleaseNotes

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing.

a.sidorin added a comment. Hello Peter, Thank you for the patch! It is almost LGTM, just a few minor questions inline. Am I understand correctly that it is partially based on https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp? Also, FYI: you can use ASTMerge and clang

[PATCH] D42318: [ARM] Pass _Float16 as int or float

samparker added a comment. Hi Sjoerd, Seems sensible to me to treat these two types the same way, though I must admit having different half types confuses me... So a few questions for my understanding: - What issue are you trying to workaround? -What would the ideal solution be? - Why do we

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

rjmccall added a comment. Thank you. Maybe there should be an overload of EmitAggregateCopy that takes LValues? A lot of these cases start with an LValue on at least one side, and there are already some convenience functions to turn an Address into a naturally-typed LValue. https://reviews.

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld added inline comments. Comment at: docs/ReleaseNotes.rst:230 + applications, please rebuild the runtime library with `-DLIBOMP_OMPT_SUPPORT=OFF` + and file a bug at `LLVM's Bugzilla

[PATCH] D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Hahnfeld updated this revision to Diff 130900. Hahnfeld marked 2 inline comments as done. Hahnfeld added a comment. Address review comments. https://reviews.llvm.org/D42352 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

[PATCH] D42154: Don't generate inline atomics for i386/i486

rjmccall added a comment. In https://reviews.llvm.org/D42154#977991, @wmi wrote: > In https://reviews.llvm.org/D42154#977975, @efriedma wrote: > > > The LLVM backend currently assumes every CPU is Pentium-compatible. If > > we're going to change that in clang, we should probably fix the backend

[PATCH] D41039: Add support for attribute "trivial_abi"

rjmccall accepted this revision. rjmccall added a comment. Looks great to me! Thanks for taking this on, it's a pretty major improvement for users. Would you like to create an issue with itanium-cxx-abi to document this, or do you want me to handle that? https://reviews.llvm.org/D41039 __

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323130: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42261?vs=130661&id=130899#

[PATCH] D42261: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rL323130: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D41311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir abandoned this revision. krasimir added a comment. Superseded by https://reviews.llvm.org/D42376 Repository: rC Clang https://reviews.llvm.org/D42372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D42372: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir added a comment. Thanks! I created https://reviews.llvm.org/D42376 which does the same in a much simpler way! Repository: rC Clang https://reviews.llvm.org/D42372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[clang-tools-extra] r323130 - [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms

Author: benhamilton Date: Mon Jan 22 07:45:25 2018 New Revision: 323130 URL: http://llvm.org/viewvc/llvm-project?rev=323130&view=rev Log: [clang-tidy objc-property-declaration] New option IncludeDefaultAcronyms Summary: The existing option objc-property-declaration.Acronyms replaces the built-in

[PATCH] D42376: [clang-format] Ignore UnbreakableTailLength sometimes during breaking

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D42376 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestTextProto.cpp Index: uni

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} aaron.ballman wrote: > rjmccall wrote: > > aaron.ballman wrote: > > > rjmccall wrote: > > > > aaron.ballman wrote: > > > > > rjmccall wrote: > > > > > > I

[PATCH] D42349: [DOCS] Mention OpenMP Tools Interface in runtime library

Hahnfeld added a comment. In https://reviews.llvm.org/D42349#983611, @hans wrote: > In https://reviews.llvm.org/D42349#983180, @Hahnfeld wrote: > > > @hans I'd also like to merge this to `release_60` because the support > > landed before the branching. Is this ok? > > > Sounds good to me. Go ahe

  1   2   >