r322452 - Reland "[Driver] Update default sanitizer blacklist location"

Author: phosek Date: Sat Jan 13 19:43:17 2018 New Revision: 322452 URL: http://llvm.org/viewvc/llvm-project?rev=322452&view=rev Log: Reland "[Driver] Update default sanitizer blacklist location" This is related to moving the sanitizer blacklists to share/ subdirectory. Differential Revision: htt

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

martell accepted this revision. martell added a comment. Given that https://reviews.llvm.org/rL322380 has been merged this seems good to me. https://reviews.llvm.org/D41809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r322448 - [clang-format] [NFC] Remove comment

Author: mzeren-vmw Date: Sat Jan 13 14:52:34 2018 New Revision: 322448 URL: http://llvm.org/viewvc/llvm-project?rev=322448&view=rev Log: [clang-format] [NFC] Remove comment Remove inaccurate comment that came in with r312125. Modified: cfe/trunk/unittests/Format/FormatTest.cpp Modified: cf

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

r322447 - [docs] Use monospace for PCH option flags

Author: modocache Date: Sat Jan 13 10:34:07 2018 New Revision: 322447 URL: http://llvm.org/viewvc/llvm-project?rev=322447&view=rev Log: [docs] Use monospace for PCH option flags Summary: Use monospace for option flags in the PCH section, instead of the italics that were being used previously. I

[PATCH] D42005: [docs] Use monospace for PCH option flags

modocache added a comment. Great, thanks for the review, @aaron.ballman! Repository: rC Clang https://reviews.llvm.org/D42005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42005: [docs] Use monospace for PCH option flags

This revision was automatically updated to reflect the committed changes. Closed by commit rC322447: [docs] Use monospace for PCH option flags (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42005?vs=129675&id=129768#toc Repository: rC Clang https:

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

modocache added a comment. Thanks, @v.g.vassilev! Repository: rL LLVM https://reviews.llvm.org/D42001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

This revision was automatically updated to reflect the committed changes. Closed by commit rL322445: [Driver] Add "did you mean?" suggestions to -cc1as (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42001 Files:

r322445 - [Driver] Add "did you mean?" suggestions to -cc1as

Author: modocache Date: Sat Jan 13 09:09:11 2018 New Revision: 322445 URL: http://llvm.org/viewvc/llvm-project?rev=322445&view=rev Log: [Driver] Add "did you mean?" suggestions to -cc1as Summary: In https://reviews.llvm.org/D41733, the driver was modified such that, when a user provided a mispell

r322435 - Fix test/Driver/riscv32-toolchain.c for builds setting CLANG_DEFAULT_LINKER

Author: asb Date: Sat Jan 13 01:21:11 2018 New Revision: 322435 URL: http://llvm.org/viewvc/llvm-project?rev=322435&view=rev Log: Fix test/Driver/riscv32-toolchain.c for builds setting CLANG_DEFAULT_LINKER Petr Hosek reported an external buildbot was failing on riscv32-toolchain.c, seemingly as

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} rjmccall wrote: > aaron.ballman wrote: > > rjmccall wrote: > > > aaron.ballman wrote: > > > > rjmccall wrote: > > > > > I have no objection to allowi

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. I can adapt it to the style guide if it is decided that it should be added. https://reviews.llvm.org/D41976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r322443 - [clangd] Fix uninitialized-read found by asan

Author: sammccall Date: Sat Jan 13 08:46:26 2018 New Revision: 322443 URL: http://llvm.org/viewvc/llvm-project?rev=322443&view=rev Log: [clangd] Fix uninitialized-read found by asan Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp clang-tools-extra/trunk/unittests/clangd/FuzzyMatch

[PATCH] D41921: [Parse] Forward brace locations to TypeConstructExpr

aaron.ballman added a comment. On the whole, this approach looks reasonable to me. Just a few minor nits for clarity. Comment at: lib/Sema/SemaExprCXX.cpp:1286-1293 +if (ListInitialization) + // FIXME: CXXUnresolvedConstructExpr does not model list-initialization +

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

lebedev.ri added a comment. In https://reviews.llvm.org/D41976#975659, @tvanslyke wrote: > Here are the results: > > Comparing old-copymove.json to new-copymove.json > BenchmarkTime CPU Time Old > Time New CPU Old CPU New > > -

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/CMakeLists.txt:6 FuchsiaTidyModule.cpp + ThreadLocalCheck.cpp OverloadedOperatorCheck.cpp Please keep this list in alphabetical order. Comment at: clang-tidy/fuchsia/Thr

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:21 +AST_MATCHER(GotoStmt, isForwardJumping) { + return Node.getLocStart() < Node.getLabel()->getLocStart(); +} lebedev.ri wro

[PATCH] D42005: [docs] Use monospace for PCH option flags

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D42005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. I'll add that the reason I felt compelled to submit this change was because perf was saying most of my program, that only ever moved strings, was spending a majority of it's time in string::reserve() calls. If for no other reason, I think it's confusing for people to

[PATCH] D41998: [clang-tidy] Expand readability-redundant-smartptr-get to understand implicit converions to bool in more contexts.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor formatting nit, LGTM! Comment at: clang-tidy/readability/RedundantSmartptrGetCheck.cpp:21 namespace { + internal::Matcher callToGet(const i

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

aaron.ballman added a comment. In https://reviews.llvm.org/D41648#969418, @JonasToth wrote: > > Yes, and I'm saying that the guidelines aren't useful for real code bases > > because they restrict more than is reasonable. So while I think the check > > is largely implementing what the guidelines

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. Here are the results: Comparing old-copymove.json to new-copymove.json BenchmarkTime CPU Time Old Time New CPU Old CPU New -

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

aaron.ballman added inline comments. Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:210 + // test that the check is disabled inside GNU statement expressions + ({ std::async(increment, 42); }); + auto StmtExprRetval = ({ std::async(increment, 42); }); ---

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

mclow.lists added a comment. Can you share your benchmark results, please? https://reviews.llvm.org/D41976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41815: [clang-tidy] implement check for goto

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:20 + +AST_MATCHER(GotoStmt, isForwardJumping) { + JonasToth wrote: > lebedev.ri wrote: > > JonasToth wrote: > > > lebedev.ri wrote: > > > > It would be nice to have i

r322438 - [Sema] Fix crash for type-dependent base classes

Author: jkorous Date: Sat Jan 13 07:24:16 2018 New Revision: 322438 URL: http://llvm.org/viewvc/llvm-project?rev=322438&view=rev Log: [Sema] Fix crash for type-dependent base classes Added: cfe/trunk/test/SemaCXX/base-class-ambiguity-check.cpp Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp

[PATCH] D41815: [clang-tidy] implement check for goto

lebedev.ri added inline comments. Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:21 +AST_MATCHER(GotoStmt, isForwardJumping) { + return Node.getLocStart() < Node.getLabel()->getLocStart(); +} JonasToth wrote: > lebedev.ri wrote: > > Hm, on a second

[PATCH] D42016: [X86] Implement old kunpck intrinsics using vector ops on vXi1 instead of integer shift/and/or

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. I agree keeping them as vector types makes more sense, assuming the vXi1 handling and bitcasts to/from integer types are up to snuff. https://reviews.llvm.org/D42016

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

ro created this revision. ro added reviewers: fedor.sergeev, tstellar, jyknight. This patch is meant to address the last outstanding review comment on the already approved (but not yet commited) https://reviews.llvm.org/D35755, namely making the handling of the RHEL devtoolsets Linux-specific.

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:21 +AST_MATCHER(GotoStmt, isForwardJumping) { + return Node.getLocStart() < Node.getLabel()->getLocStart(); +} lebedev.ri wrote: > Hm, on a second thought, i think this

[PATCH] D41815: [clang-tidy] implement check for goto

JonasToth updated this revision to Diff 129760. JonasToth added a comment. - add edgecase test from roman Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41815 Files: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp clang-tidy/cppcoreguidelines/AvoidGotoCheck.h clang-tidy/c

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. I believe there's nothing more left for me here. Is the patch ok now? Thanks. Rainer Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro added a comment. ping^2 Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro added a comment. Thanks. Could you please commit this for me? Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

> -Original Message- > From: Szabolcs Nagy via Phabricator [mailto:revi...@reviews.llvm.org] > Sent: Friday, January 12, 2018 3:18 PM > > nsz added a comment. > > > it is not clear to me from the original bug report what "fedora 27 workloads" > break because of the lack of _Float128

Re: r322350 - [ODRHash] Don't hash friend functions.

Could we pull this into release_60? It resolves an issue in r321395. On Fri, Jan 12, 2018 at 1:43 PM Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Thu Jan 11 20:42:27 2018 > New Revision: 322350 > > URL: http://llvm.org/viewvc/llvm-project?rev=322350&

[PATCH] D39903: [libclang] Allow pretty printing declarations

jbcoe added inline comments. Comment at: tools/c-index-test/c-index-test.c:93 +enum CXPrintingPolicyProperty property; + } mappings[] = { + {"CINDEXTEST_PRINTINGPOLICY_INDENTATION", CXPrintingPolicy_Indentation}, I'm not sure that joining the struct def

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun added a comment. In https://reviews.llvm.org/D41655#974725, @JonasToth wrote: > High Integrity C++ has the rule `17.5.1 Do not ignore the result of > std::remove, std::remove_if or std::unique`. Do we want to add those to the > preconfigured list? To me these sound like reasonable add

[PATCH] D40023: [RISCV] Implement ABI lowering

asb added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:8913 + } + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); +} efriedma wrote: > asb wrote: > > efriedma wrote: > > > The spec says "Aggregates larger than 2✕XLEN bits are passed by reference

[PATCH] D39963: [RISCV] Add initial RISC-V target and driver support

asb added a comment. Hi Petr, thanks for the report. This should be addressed in https://reviews.llvm.org/rL322435. Repository: rC Clang https://reviews.llvm.org/D39963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or