lebedev.ri added inline comments.
Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:21
+AST_MATCHER(GotoStmt, isForwardJumping) {
+ return Node.getLocStart() < Node.getLabel()->getLocStart();
+}
Hm, on a second thought, i think this will have false-pos
Author: rsmith
Date: Fri Jan 12 21:05:45 2018
New Revision: 322431
URL: http://llvm.org/viewvc/llvm-project?rev=322431&view=rev
Log:
DR126: partially implement the const-correct rules for exception handler
matching.
While here, fix up the myriad other ways in which Sema's two "can this handler
c
Seems to be working now.
Thank you!
On Thu, Jan 11, 2018 at 9:46 PM, Richard Trieu wrote:
> Hi Vedant and Eric,
>
> Please retry after r322350. I suspect an interaction between templates
> and friend functions is causing this issue. This revision disables hashing
> for friend functions for no
Author: asb
Date: Fri Jan 12 12:08:16 2018
New Revision: 322396
URL: http://llvm.org/viewvc/llvm-project?rev=322396&view=rev
Log:
Refactor handling of signext/zeroext in ABIArgInfo
As @rjmccall suggested in D40023, we can get rid of
ABIInfo::shouldSignExtUnsignedType (used to handle cases like t
EricWF updated this revision to Diff 129746.
EricWF added a comment.
- Introduce `SourceLocExprScope.h` to help reduce code duplication.
- Merge with upstream.
https://reviews.llvm.org/D37035
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include
stephanemoore added a comment.
I am still working to verify that this change represents actual consensus. I
will hold off on adding reviewers until then.
https://reviews.llvm.org/D42014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
EricWF updated this revision to Diff 129744.
EricWF added a comment.
- Address @rsmith's comments by removing the fallback implementation of the
diagnostics.
https://reviews.llvm.org/D41977
Files:
include/tuple
test/libcxx/utilities/tuple/tuple.tuple/diagnose_reference_binding.fail.cpp
t
dcoughlin added a comment.
The diagnostic text looks to me, but I do have a comment about the nested 'if'
inline.
Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:150
+SB.getKnownValue(state, C.getSVal(B->getRHS()));
+if ((unsigned) RHS->getZE
EricWF added a comment.
In https://reviews.llvm.org/D41977#975403, @rsmith wrote:
> This will still diagnose valid and reasonable programs, such as:
>
> struct ConvertToRef { operator int&(); };
> std::tuple t = {ConvertToRef()};
>
>
> ... on compilers that don't provide the trait. You could
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for fixing this.
Repository:
rC Clang
https://reviews.llvm.org/D42015
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Thanks for adding these! This looks good to me. Do you have commit access, or
do you need someone to commit this?
Repository:
rC Clang
https://reviews.llvm.org/D41881
EricWF updated this revision to Diff 129742.
EricWF added a comment.
- Improve diagnostic handling.
https://reviews.llvm.org/D40218
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecki
EricWF updated this revision to Diff 129740.
EricWF marked an inline comment as done.
EricWF added a comment.
- Address inline comments about missing diagnostics for void pointers and
function pointers.
- Address inline comments about only enabling when `-fstrict-vtable-pointers`
is specified, a
EricWF marked 2 inline comments as done.
EricWF added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1674
+Value *Ptr = EmitScalarExpr(E->getArg(0));
+Ptr = Builder.CreateInvariantGroupBarrier(Ptr);
+return RValue::get(Ptr);
rsmith wrote:
> It
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D41797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks great. It is nice to have this fixed and cleaned up!
Comment at: lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cpp:95
+ llvm::errs() << "PreCall";
+
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM as well.
https://reviews.llvm.org/D41266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcgrathr added inline comments.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152
+ llvm::sys::path::append(P, normalizeTriple(Triple));
+ return P.str();
+}
The GCC behavior (if --with-sysroot is given to configure) is tooldir/sys-root,
not tooldir itself.
dcoughlin accepted this revision.
dcoughlin added a comment.
This looks good to me, as well.
https://reviews.llvm.org/D41250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM with the TODO and the test case I requested inline.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:487
+if (const MemRegion *MR = I.second.getAsRegion())
+
Author: echristo
Date: Fri Jan 12 16:46:47 2018
New Revision: 322427
URL: http://llvm.org/viewvc/llvm-project?rev=322427&view=rev
Log:
Remove unused addIfPresent function.
Modified:
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
URL:
http://llvm.org/viewvc
phosek added a comment.
Herald added a subscriber: niosHD.
This has broken our toolchain build, the log is here:
https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8957686819564148864%2F%2B%2Fsteps%2Fcheck_clang%2F0%2Fstdout.
The failure is:
**
GorNishanov added a comment.
In https://reviews.llvm.org/D41820#974116, @EricWF wrote:
> Is this behavior specified somewhere? Or are we simply adding an extension to
> Clang? If so I would really prefer to add my `co_promise` solution (but I
> need to write a paper in favor of it first).
Bef
rsmith added a comment.
This will still diagnose valid and reasonable programs, such as:
struct ConvertToRef { operator int&(); };
std::tuple t = {ConvertToRef()};
... on compilers that don't provide the trait. You could maybe try to work
around that by checking to see if the type has a mem
rsmith added inline comments.
Comment at: include/tuple:185-186
+// Allow "int&&" to bind to 'int const&'
+|| (is_rvalue_reference<_Tp>::value && is_const<_RawHp>::value &&
+is_same<_RawHp, const _RawTp>::value)
>;
It would b
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added a subscriber: cfe-commits.
When sysroot isn't explicitly set, try to use the default location which is
/../
Repository:
rC Clang
https://reviews.llvm.org/D42019
Files:
lib/Driver/ToolChains/Fuchsia.cpp
Index:
krytarowski created this revision.
krytarowski added reviewers: joerg, vitalybuka, dvyukov.
krytarowski added a project: Sanitizers.
Herald added a subscriber: llvm-commits.
kvm - kernel memory interface
This set of functions is defined in the libkvm library.
The kvm(3) functions are used in pro
NoQ created this revision.
NoQ added reviewers: dcoughlin, george.karpenkov.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
`RetainCountChecker` appears to be using `MemRegion::getString()` to present
the region to the user, which is equivalent to `MemRegion->dump()` and as
stephanemoore updated this revision to Diff 129718.
stephanemoore added a comment.
Sorted the Objective-C configuration for consistency.
https://reviews.llvm.org/D42014
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
stephanemoore created this revision.
Herald added subscribers: cfe-commits, klimek.
Defaulting BinPackArguments and BinPackParameters to false is a better
representation of Google Objective-C style.
Repository:
rC Clang
https://reviews.llvm.org/D42014
Files:
lib/Format/Format.cpp
Index:
Author: rtrieu
Date: Fri Jan 12 15:13:33 2018
New Revision: 322420
URL: http://llvm.org/viewvc/llvm-project?rev=322420&view=rev
Log:
Try to suppress Windows testing again.
Modified:
cfe/trunk/test/Modules/odr_hash-Friend.cpp
Modified: cfe/trunk/test/Modules/odr_hash-Friend.cpp
URL:
http://l
lichray updated this revision to Diff 129714.
lichray added a comment.
src/support/itoa/itoa.cpp in previous diffs were copyrighted by Tencent, now
LLVM, contributed by the same author.
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
Files:
.gitignore
include/charconv
include/
Author: dyung
Date: Fri Jan 12 14:32:01 2018
New Revision: 322417
URL: http://llvm.org/viewvc/llvm-project?rev=322417&view=rev
Log:
Fix test on Windows that was added in r322382.
The test was using "%clang++" which on Windows became "clang.exe++". Use
%clangxx instead.
Reviewed by Paul Robinson
Author: rsmith
Date: Fri Jan 12 14:21:33 2018
New Revision: 322414
URL: http://llvm.org/viewvc/llvm-project?rev=322414&view=rev
Log:
When rebuilding an InitListExpr, don't give it a type.
InitListExprs without types (well, with type 'void') represent not-yet-analyzed
initializer lists; InitListEx
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums
(authored by probinson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42011?vs=129703&id=129708#toc
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322413: [DWARFv5] Have -gdwarf-5 generate MD5 checksums
(authored by probinson, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42011?vs=12970
Author: probinson
Date: Fri Jan 12 14:19:03 2018
New Revision: 322413
URL: http://llvm.org/viewvc/llvm-project?rev=322413&view=rev
Log:
[DWARFv5] Have -gdwarf-5 generate MD5 checksums
Differential Revision: https://reviews.llvm.org/D42011
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
c
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D41935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322410: [analyzer] Don't flag strcpy of string literals
into sufficiently large buffers. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
Author: dergachev
Date: Fri Jan 12 14:12:11 2018
New Revision: 322410
URL: http://llvm.org/viewvc/llvm-project?rev=322410&view=rev
Log:
[analyzer] Don't flag strcpy of string literals into sufficiently large buffers.
In the security package, we have a simple syntactic check that warns about
strcp
probinson created this revision.
probinson added reviewers: dblaikie, aprantl.
probinson added a project: debug-info.
Herald added subscribers: cfe-commits, JDevlieghere.
Under `-gdwarf-5` generate MD5 checksums of source files to emit to the DWARF
v5 line table.
This consumes 16 bytes per sourc
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
r322406
Repository:
rC Clang
https://reviews.llvm.org/D40569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: rjmccall
Date: Fri Jan 12 14:07:01 2018
New Revision: 322406
URL: http://llvm.org/viewvc/llvm-project?rev=322406&view=rev
Log:
Allocate and access NormalCleanupDest with the natural alignment of i32.
This alignment can be less than 4 on certain embedded targets, which may
not even be able
Author: rtrieu
Date: Fri Jan 12 13:49:20 2018
New Revision: 322405
URL: http://llvm.org/viewvc/llvm-project?rev=322405&view=rev
Log:
Disable test for Windows to fix Windows buildbots.
Modified:
cfe/trunk/test/Modules/odr_hash-Friend.cpp
Modified: cfe/trunk/test/Modules/odr_hash-Friend.cpp
UR
ckennelly marked 2 inline comments as done.
ckennelly added a comment.
In https://reviews.llvm.org/D41746#973941, @EricWF wrote:
> This LGTM minus nits.
>
> Is there a LWG issue or paper that specifies this change? or is it just a
> general bug fix?
This is just a general bug fix.
=
eric_niebler added a comment.
> Is this behavior specified somewhere? Or are we simply adding an extension to
> Clang?
It is not specified anywhere //yet// but Gor has promised a paper for
Jacksonville.
> If so I would really prefer to add my co_promise solution (but I need to
> write a paper
ckennelly updated this revision to Diff 129698.
Repository:
rCXX libc++
https://reviews.llvm.org/D41746
Files:
include/memory
test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp
Index: test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp
JonasToth added inline comments.
Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:47
+"^::std::launder$|"
+"^::std::unique_ptr<.*>::release$|"
+"^::std::.*::allocate$|"
efriedma accepted this revision.
efriedma added a comment.
LGTM
Not sure if anyone's mentioned it yet, but there's a C ABI testing tool in
clang/utils/ABITest/ which you'll probably want to try at some point.
Comment at: lib/CodeGen/TargetInfo.cpp:8913
+ }
+ return getNatur
vsk added reviewers: EricWF, mclow.lists, hiraditya.
vsk added a comment.
Adding some folks who may be interested.
https://reviews.llvm.org/D41976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM, but you should wait for Eli's sign-off, too.
https://reviews.llvm.org/D40023
___
cfe-commits mailing list
cfe-commits@lists.ll
sdardis added a comment.
I just checked both my qemu copy and on my mips64 machine and it seems to be a
a copy / paste error. Reposting here directly from my machines:
MIPS64:
diff --git a/test/libunwind/test/config.py b/test/libunwind/test/config.py
index 2a0c828..a8952c3 100644
--- a/t
JonasToth updated this revision to Diff 129693.
JonasToth added a comment.
rebase to 7.0.0
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40854
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppco
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/cppcoreguidelines-avoid-goto.rst:6-7
+
+The usage of ``goto`` has been discouraged for a long time and is diagnosed
+with this check.
+
JonasToth wrote:
> aaron.ballman wrote:
> > This doesn
JonasToth updated this revision to Diff 129691.
JonasToth added a comment.
- minor issues fixed
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/
JonasToth updated this revision to Diff 129690.
JonasToth marked 3 inline comments as done.
JonasToth added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguideli
bsdjhb added a comment.
In https://reviews.llvm.org/D39074#974913, @sdardis wrote:
> This was libunwind's test suite:
>
> Compiled test failed unexpectedly!
>
> Testing Time: 0.53s
>
> Failing Tests (1):
> libunwind :: libunwind_02.pass.cp
tvanslyke updated this revision to Diff 129685.
tvanslyke added a comment.
I went ahead and just pulled it out to a small inline member function and added
it to __copy_assign_alloc(). Removed some other redundancies.
https://reviews.llvm.org/D41976
Files:
string
Index: string
JonasToth updated this revision to Diff 129686.
JonasToth added a comment.
- get up to date to 7.0
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40737
Files:
clang-tidy/hicpp/CMakeLists.txt
clang-tidy/hicpp/HICPPTidyModule.cpp
clang-tidy/hicpp/MultiwayPathsCoveredCheck.c
JonasToth added a comment.
@sbenza and/or @klimek did you have time to address the stackoverflow caused
from the ASTMatchers?
I forgot to add the link to the original break:
http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/5470/consoleFull#17462642768254eaf0-7326-4999-85b0-388101f2d
JonasToth updated this revision to Diff 129684.
JonasToth added a comment.
- simplified the code and merged diagnostics
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41815
Files:
clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp
clang-tidy/cppcoreguidelines/AvoidGotoCheck.h
asb updated this revision to Diff 129683.
asb marked 8 inline comments as done.
asb added a comment.
Rebase after ABIArgInfo signext/zeroext refactoring
https://reviews.llvm.org/D41999 / https://reviews.llvm.org/rL322396. We no
longer need to modify CGCall.cpp for unsigned 32-bit return values t
JonasToth marked 5 inline comments as done.
JonasToth added inline comments.
Comment at: docs/ReleaseNotes.rst:63
+
+ The usage of ``goto`` has been discouraged for a long time and is diagnosed
+ with this check.
Eugene.Zelenko wrote:
> I think will be good ide
nsz added a comment.
In https://reviews.llvm.org/D40673#973638, @efriedma wrote:
> > as this patch is committed clang is broken (cannot use glibc headers)
>
> This patch was supposed to *fix* compatibility with the glibc headers. If it
> doesn't, we should clearly revert it... but we need to fi
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1148
+DK_objc_weak_lifetime,
+DK_c_struct_strong_field
};
ahatanak wrote:
> rjmccall wrote:
> > I don't think you want to refer to the fact that the C struct specifically
> > contain
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322396: Refactor handling of signext/zeroext in ABIArgInfo
(authored by asb, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41999
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:517
+if (const auto *Array = dyn_cast(
+DeclRef->getDecl()->getType().getTypePtr())) {
+ unsigned long long ArraySize = Array->getSize().getLimitedValue();
leanil marked 2 inline comments as done.
leanil added a comment.
In https://reviews.llvm.org/D41384#973851, @NoQ wrote:
> Do you have commit access or should someone else commit it for you?
I don't have, please commit it.
Comment at: lib/StaticAnalyzer/Checkers/CheckSecurity
JonasToth updated this revision to Diff 129677.
JonasToth marked 8 inline comments as done.
JonasToth added a comment.
- address review comments
- add better documentation with code examples
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41815
Files:
clang-tidy/cppcoreguideli
leanil updated this revision to Diff 129676.
leanil marked an inline comment as done.
leanil added a comment.
Measure array size in bytes instead of elements.
https://reviews.llvm.org/D41384
Files:
lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp
test/Analysis/security-syntax-checks.
sdardis added a comment.
Um, I now appear to be getting different results for running under QEMU doing
it the proper way. I was previously rebuilding the failing test by hand and
running under qemu. I don't believe I changed anything important, I'll have to
take a longer look.
If you define an
modocache created this revision.
modocache added reviewers: sepavloff, aaron.ballman.
Use monospace for option flags in the PCH section, instead of the
italics that were being used previously.
I believe these used to be links, for which single backticks would
have been appropriate, but since they
Hans, I am nominating this change to be merged into 6.0.0 release branch.
Thanks,
Volodymyr
> On Jan 12, 2018, at 10:54, Volodymyr Sapsai via cfe-commits
> wrote:
>
> Author: vsapsai
> Date: Fri Jan 12 10:54:35 2018
> New Revision: 322390
>
> URL: http://llvm.org/viewvc/llvm-project?rev=32239
Author: abataev
Date: Fri Jan 12 11:39:11 2018
New Revision: 322393
URL: http://llvm.org/viewvc/llvm-project?rev=322393&view=rev
Log:
[OPENMP] Replace calls of getAssociatedStmt().
getAssociatedStmt() returns the outermost captured statement for the
OpenMP directive. It may return incorrect regio
modocache created this revision.
modocache added reviewers: sepavloff, bkramer, phosek.
There are only two valid integrated Clang driver tools: `-cc1` and
`-cc1as`. If a user asks for an unknown tool, such as `-cc1asphalt`,
an error message is displayed to indicate that there is no such tool,
but
JonasToth marked 3 inline comments as done.
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:20
+
+AST_MATCHER(GotoStmt, isForwardJumping) {
+
lebedev.ri wrote:
> JonasToth wrote:
> > lebedev.ri wrote:
> > > It would be
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322390: [Lex] Avoid out-of-bounds dereference in
LexAngledStringLiteral. (authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41423?vs=129379&id=129666#toc
Repositor
Author: vsapsai
Date: Fri Jan 12 10:54:35 2018
New Revision: 322390
URL: http://llvm.org/viewvc/llvm-project?rev=322390&view=rev
Log:
[Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.
Fix makes the loop in LexAngledStringLiteral more like the loops in
LexStringLiteral, LexCharConst
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D42001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
sdardis added a comment.
This was libunwind's test suite:
Compiled test failed unexpectedly!
Testing Time: 0.53s
Failing Tests (1):
libunwind :: libunwind_02.pass.cpp
Expected Passes: 3
Unexpected Failures: 1
The hacky pat
bsdjhb added a comment.
To be clear, are you getting the failure running libunwind's test suite or your
own test? I've managed to get libunwind to cross-compile for me using GCC
6.3.0 on FreeBSD for O32, N32, and N64, but only to build the library, not the
tests. I've been running a simple C+
ahatanak added inline comments.
Comment at: include/clang/AST/Type.h:1148
+DK_objc_weak_lifetime,
+DK_c_struct_strong_field
};
rjmccall wrote:
> I don't think you want to refer to the fact that the C struct specifically
> contains a __strong field her
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322387: [clangd] Code completion uses Sema for NS-level
things in the current file. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
Author: sammccall
Date: Fri Jan 12 10:30:08 2018
New Revision: 322387
URL: http://llvm.org/viewvc/llvm-project?rev=322387&view=rev
Log:
[clangd] Code completion uses Sema for NS-level things in the current file.
Summary:
To stay fast, it avoids deserializing anything outside the current file, by
modocache created this revision.
modocache added reviewers: v.g.vassilev, bruno.
In https://reviews.llvm.org/D41733, the driver was modified such that,
when a user provided a mispelled option such as `-hel`, it would
suggest a valid option with a nearby edit distance: "did you mean
'-help'?".
Add
krytarowski added a comment.
Looks good, please improve the description of the commit (and not your
authorship that will be preserved in the commit message).
Once accepted by another developer, I can commit it for you.
https://reviews.llvm.org/D41809
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1937
+RetAttrs.addAttribute(llvm::Attribute::ZExt);
+}
// FALL THROUGH
asb wrote:
> rjmccall wrote:
> > asb wrote:
> > > rjmccall wrote:
> > > > I feel like a better design would
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, that looks great. I appreciate you doing this.
Repository:
rC Clang
https://reviews.llvm.org/D41999
___
cfe-commits mailing list
asb added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1937
+RetAttrs.addAttribute(llvm::Attribute::ZExt);
+}
// FALL THROUGH
rjmccall wrote:
> asb wrote:
> > rjmccall wrote:
> > > I feel like a better design would be to record whether to
asb created this revision.
asb added a reviewer: rjmccall.
Herald added subscribers: cfe-commits, arichardson.
As @rjmccall suggested in https://reviews.llvm.org/D40023, we can get rid of
ABIInfo::shouldSignExtUnsignedType (used to handle cases like the Mips calling
convention where 32-bit integ
sammccall added a comment.
In https://reviews.llvm.org/D41996#974751, @hokein wrote:
> nice, LGTM.
>
> By `r322377`, I think you mean `r322371`.
Done.
> We also need to set `CollectorOpts.IndexMainFiles` to `false` in
> `FileIndex.cpp::indexAST` -- we don't need dynamic index to catch the sy
tra added a comment.
@arphaman: ping.
https://reviews.llvm.org/D41788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322382: [WebAssembly] Support -stdlib=libc++ switch
(authored by sbc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41937?vs=129572&id=129649#toc
Repository:
rC Clang
https://re
Author: sbc
Date: Fri Jan 12 09:54:49 2018
New Revision: 322382
URL: http://llvm.org/viewvc/llvm-project?rev=322382&view=rev
Log:
[WebAssembly] Support -stdlib=libc++ switch
Referenced implementation from Fuchsia and Darwin Toolchain.
Still only support CST_Libcxx. Now checks that the argument
i
sbenza created this revision.
sbenza added a reviewer: hokein.
Herald added subscribers: cfe-commits, xazax.hun, klimek.
Expand readability-redundant-smartptr-get to understand implicit converions to
bool in more contexts.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41998
F
juliehockett updated this revision to Diff 129647.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41963
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/ThreadLocalC
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:3529
+ /// Basic properties of non-trivial C structs.
+ bool HasStrongObjCPointer : 1;
+
Is it interesting to track all the individual reasons that a struct is
non-trivial at the struct level
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
nice, LGTM.
By `r322377`, I think you mean `r322371`.
We also need to set `CollectorOpts.IndexMainFiles` to `false` in
`FileIndex.cpp::indexAST` -- we don't need dynamic index to catch the s
JonasToth added a comment.
High Integrity C++ has the rule `17.5.1 Do not ignore the result of
std::remove, std::remove_if or std::unique`. Do we want to add those to the
preconfigured list?
https://reviews.llvm.org/D41655
___
cfe-commits mailing
devnexen added a comment.
In https://reviews.llvm.org/D41809#969475, @kimgr wrote:
> Typo in the commit title: buzzer :)
Changed ... just to follow-up the now accepted change of this one
https://reviews.llvm.org/D41642
https://reviews.llvm.org/D41809
__
1 - 100 of 148 matches
Mail list logo
