xgsa updated this revision to Diff 128893.
xgsa added a comment.
Fixed showing the check in -list-checks.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41326
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer
Hah, we all missed this during review.
From: cfe-commits on behalf of Saleem
Abdulrasool via cfe-commits
Reply-To: Saleem Abdulrasool
Date: Saturday, January 6, 2018 at 10:48 AM
To: "cfe-commits@lists.llvm.org"
Subject: [libcxx] r321937 - Correct mistake in pragma usage for Windows
Author: c
Author: rsmith
Date: Sun Jan 7 14:25:55 2018
New Revision: 321977
URL: http://llvm.org/viewvc/llvm-project?rev=321977&view=rev
Log:
Remove bogus check for template specialization from self-comparison warning.
The important check is that we're not within a template *instantiation*, which
we check
Author: rsmith
Date: Sun Jan 7 14:18:05 2018
New Revision: 321976
URL: http://llvm.org/viewvc/llvm-project?rev=321976&view=rev
Log:
Fix a couple of wrong self-comparison diagnostics.
Check whether we are comparing the same entity, not merely the same
declaration, and don't assume that weak decla
Author: rsmith
Date: Sun Jan 7 14:03:44 2018
New Revision: 321973
URL: http://llvm.org/viewvc/llvm-project?rev=321973&view=rev
Log:
Add tests for three-way self- and array comparison.
Modified:
cfe/trunk/test/SemaCXX/compare-cxx2a.cpp
Modified: cfe/trunk/test/SemaCXX/compare-cxx2a.cpp
URL:
Author: rsmith
Date: Sun Jan 7 13:57:48 2018
New Revision: 321972
URL: http://llvm.org/viewvc/llvm-project?rev=321972&view=rev
Log:
Factor out common tautological comparison code from scalar and vector compare
checking.
In passing, improve vector compare diagnostic to match scalar compare
diag
kimgr requested changes to this revision.
kimgr added a comment.
This revision now requires changes to proceed.
Typo in the commit title: buzzer :)
Repository:
rC Clang
https://reviews.llvm.org/D41809
___
cfe-commits mailing list
cfe-commits@list
khuttun updated this revision to Diff 128879.
khuttun added a comment.
Fix review comments
https://reviews.llvm.org/D41655
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/UnusedReturnValueCheck.cpp
clang-tidy/bugprone/UnusedReturn
khuttun marked 2 inline comments as done.
khuttun added inline comments.
Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:163
+
+void noWarning() {
+ auto AsyncRetval1 = std::async(increment, 42);
aaron.ballman wrote:
> Sorry, I just realized that we
devnexen created this revision.
Herald added subscribers: cfe-commits, emaste.
Repository:
rC Clang
https://reviews.llvm.org/D41809
Files:
lib/Driver/ToolChains/FreeBSD.cpp
Index: lib/Driver/ToolChains/FreeBSD.cpp
===
--- lib/
It seems the test is missing?
On Sun, Jan 7, 2018 at 8:39 PM, Marshall Clow via cfe-commits
wrote:
> Author: marshall
> Date: Sun Jan 7 09:39:57 2018
> New Revision: 321966
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321966&view=rev
> Log:
> Mark the transparent version set::count() as cons
Author: marshall
Date: Sun Jan 7 09:39:57 2018
New Revision: 321966
URL: http://llvm.org/viewvc/llvm-project?rev=321966&view=rev
Log:
Mark the transparent version set::count() as const. Thanks to Ivan Matek for
the bug report.
Modified:
libcxx/trunk/include/set
Modified: libcxx/trunk/inclu
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX321963: Add pre-C++11 is_constructible wrappers for 3
arguments (authored by dim, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41805?vs=128860&id=128873#toc
Repository:
rCXX l
Author: dim
Date: Sun Jan 7 08:45:11 2018
New Revision: 321963
URL: http://llvm.org/viewvc/llvm-project?rev=321963&view=rev
Log:
Add pre-C++11 is_constructible wrappers for 3 arguments
Summary:
After rL319736 for D28253 (which fixes PR28929), gcc cannot compile ``
anymore in pre-C+11 modes, com
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: tstellar.
Herald added a subscriber: mgorny.
As we are only doing X.0.Z releases (not using the minor version), there is no
need to keep -X.Y in the version.
So, instead, I propose the following:
Instead of having clang-7.0
JonasToth added a comment.
> Yes, and I'm saying that the guidelines aren't useful for real code bases
> because they restrict more than is reasonable. So while I think the check is
> largely implementing what the guidelines recommend, I think that some of
> these scenarios should be brought ba
JonasToth updated this revision to Diff 128870.
JonasToth added a comment.
- rebase after release of 6.0
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40854
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
cl
JonasToth updated this revision to Diff 128869.
JonasToth added a comment.
- rebase after release for 6.0
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
c
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D41507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: d0k
Date: Sun Jan 7 01:11:16 2018
New Revision: 321960
URL: http://llvm.org/viewvc/llvm-project?rev=321960&view=rev
Log:
Remove outdated doxygen comment [-Wdocumentation]
No functionality change.
Modified:
cfe/trunk/include/clang/Lex/ModuleMap.h
Modified: cfe/trunk/include/clang/Le
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCXX libc++
https://reviews.llvm.org/D41805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
21 matches
Mail list logo
