Author: faisalv
Date: Sun Dec 31 18:49:17 2017
New Revision: 321616
URL: http://llvm.org/viewvc/llvm-project?rev=321616&view=rev
Log:
Revert r321614 and r321615
- the enum changes to TypeSpecifierType are breaking some tests - and will
require a more careful integration.
Sorry about rushing th
Author: faisalv
Date: Sun Dec 31 18:35:43 2017
New Revision: 321615
URL: http://llvm.org/viewvc/llvm-project?rev=321615&view=rev
Log:
Add scope specifiers to updated scoped-enums (that I somehow missed in r321614)
Modified:
cfe/trunk/lib/AST/TypeLoc.cpp
cfe/trunk/lib/Serialization/ASTWrit
Author: faisalv
Date: Sun Dec 31 18:19:52 2017
New Revision: 321614
URL: http://llvm.org/viewvc/llvm-project?rev=321614&view=rev
Log:
[NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType
into scoped enums.
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/tr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321609: [Sema] Improve diagnostics for const- and
ref-qualified member functions (authored by jtbandes, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41646
Files:
cfe/trunk/include/c
aaron.ballman added a comment.
In https://reviews.llvm.org/D41648#965437, @JonasToth wrote:
> In https://reviews.llvm.org/D41648#965432, @aaron.ballman wrote:
>
> > I think this check is going to be extraordinarily chatty. For instance,
> > macros are often used to hide compiler details in signa
JonasToth added a comment.
In https://reviews.llvm.org/D41648#965432, @aaron.ballman wrote:
> I think this check is going to be extraordinarily chatty. For instance,
> macros are often used to hide compiler details in signatures, such as use of
> attributes. This construct cannot be replaced wi
Author: jtbandes
Date: Sat Dec 30 21:13:03 2017
New Revision: 321593
URL: http://llvm.org/viewvc/llvm-project?rev=321593&view=rev
Log:
Reverted 321592: [Sema] Improve diagnostics for const- and ref-qualified member
functions
A few tests need to be fixed
Modified:
cfe/trunk/include/clang/Ba
Author: jtbandes
Date: Sat Dec 30 20:49:39 2017
New Revision: 321592
URL: http://llvm.org/viewvc/llvm-project?rev=321592&view=rev
Log:
[Sema] Improve diagnostics for const- and ref-qualified member functions
Summary:
Adjust wording for const-qualification mismatch to be a little more clear.
Also
aaron.ballman added a comment.
I think this check is going to be extraordinarily chatty. For instance, macros
are often used to hide compiler details in signatures, such as use of
attributes. This construct cannot be replaced with anything else because the
macro isn't defining an object or valu
JonasToth updated this revision to Diff 128373.
JonasToth added a comment.
- remove unneeded includes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang
JonasToth updated this revision to Diff 128372.
JonasToth added a comment.
- merge with local repos
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41648
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-t
JonasToth created this revision.
JonasToth added reviewers: aaron.ballman, hokein, alexfh.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai,
klimek.
In short macros are discouraged by multiple rules (and sometimes reference
randomly).
This check allows only headerguard
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Btw, if you get the LG on a patch but the patch breaks bots on commit,
you generally don't need to do another round of review unless you need to
highlight significant chan
13 matches
Mail list logo
