sepavloff added a comment.
Is it correct to emit error in this case?
According to the Standard 10.5p1 "All function types, function names with
external linkage, and variable names with external linkage have a language
linkage". So templates do not have a language linkage.
The next paragraph, wh
faisalv added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7029
+ }
+
// C++ [temp.expl.spec]p2:
What do you think about factoring this out into a separate function that is
then called both from here and CheckTemplateDeclScope (since it is exactly
krytarowski added a comment.
Ping?
Repository:
rL LLVM
https://reviews.llvm.org/D41054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D41258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: d0k
Date: Sun Dec 17 15:52:45 2017
New Revision: 320954
URL: http://llvm.org/viewvc/llvm-project?rev=320954&view=rev
Log:
Refactor overridden methods iteration to avoid double lookups.
Convert most uses to range-for loops. No functionality change intended.
Modified:
cfe/trunk/include
faisalv requested changes to this revision.
faisalv added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Sema/SemaTemplate.cpp:3899
+ // constraint expressions right now.
+ return Template->getConstraintExpr();
+}
saar.raz wrote
saar.raz added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:3899
+ // constraint expressions right now.
+ return Template->getConstraintExpr();
+}
faisalv wrote:
> I don't think we want to just return the constraint expr? I think we would
> need to c
faisalv accepted this revision.
faisalv added a comment.
This revision is now accepted and ready to land.
Otherwise, I think this looks good enough to commit.
Do you have commit access? If not, let me know when you're ready for me to
commit it on your behalf ...
Thank you for fixing this!
==
faisalv added a comment.
Thanks for working on this! :)
Comment at: include/clang/AST/DeclTemplate.h:3035
+ SourceRange getSourceRange() const override LLVM_READONLY {
+return SourceRange(getLocation(), getLocation());
+ }
why not just fix it now?
retur
a.sidorin updated this revision to Diff 127283.
a.sidorin added a comment.
Fixed sanity check.
Repository:
rC Clang
https://reviews.llvm.org/D38694
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
=
Author: a.sidorin
Date: Sun Dec 17 06:16:17 2017
New Revision: 320942
URL: http://llvm.org/viewvc/llvm-project?rev=320942&view=rev
Log:
[ASTImporter] Support importing FunctionTemplateDecl and
CXXDependentScopeMemberExpr
* Also introduces ImportTemplateArgumentListInfo facility (A. Sidorin)
Pat
oren_ben_simhon added a comment.
-mibt is currently in discussions with other compilers, any change will be
uploaded to a different review.
If you have more comments i will appreciate it.
Repository:
rL LLVM
https://reviews.llvm.org/D40478
___
c
saar.raz added inline comments.
Comment at: lib/Parse/ParseExpr.cpp:223
ExprResult Parser::ParseConstraintExpression() {
- // FIXME: this may erroneously consume a function-body as the braced
- // initializer list of a compound literal
- //
- // FIXME: this may erroneously c
xgsa added a comment.
In https://reviews.llvm.org/D41326#957749, @JVApen wrote:
> I'm missing some documentation to understand the corner cases. How does this
> check behave with suppressed warnings for checks which ain't currently
> checked. (Using -no-... on a code base or suppressing the war
JVApen added a comment.
I'm missing some documentation to understand the corner cases. How does this
check behave with suppressed warnings for checks which ain't currently checked.
(Using -no-... on a code base or suppressing the warnings via the pragmas)
https://reviews.llvm.org/D41326
___
xgsa updated this revision to Diff 127268.
xgsa added a comment.
Review comments applied.
https://reviews.llvm.org/D41326
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/nolint-usage.cpp
test/clang-tid
xgsa added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:339
std::unique_ptr OptionsProvider)
: DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
+ Profile(nullptr),
xgsa wrote:
> Eugene.Zelenko wrote:
> >
xgsa updated this revision to Diff 127267.
xgsa added a comment.
Review comments were applied.
https://reviews.llvm.org/D41326
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/nolint-usage.cpp
test/clan
18 matches
Mail list logo
