[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb added inline comments. Comment at: test/Driver/riscv-gnutools.c:6 +// RUN: %clang -target riscv64-unknown-elf -fno-integrated-as %s -### \ +// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP64 %s + s/MABI-ILP64/MABI-LP64 https://reviews.llvm.org/D41271

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb edited subscribers, added: cfe-commits; removed: llvm-commits. asb added a comment. Removing llvm-commits and adding cfe-commits. Thanks Ana. This looks good to me. We probably should have a default march, but I don't know what it should be. If most clang targets default to a Linux-capable

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

bob.wilson added a comment. I'm concerned here about the check for the names as written vs. the canonical names. @compnerd pointed out one specific case with armv7, and I see that you've got special handling for "darwin", but I think there are more. What about "arm64" vs. the canonical "aarch64

[PATCH] D41223: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

lichray added inline comments. Comment at: include/array:135 + _LIBCPP_INLINE_VISIBILITY + static void __swap(_StorageT& __lhs, _StorageT& __rhs) { +std::swap_ranges(__lhs, __lhs + _Size, __rhs); Just asking: no compiler is dumb enough to not inline this en

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

rjmccall added inline comments. Comment at: lib/Sema/SemaExprObjC.cpp:1357 +(ReceiverType->isObjCClassOrClassKindOfType() || + ReceiverType->isObjCQualifiedClassType()) && +Receiver->isObjCSelfExpr() && getLangOpts().ObjCAutoRefCount) { Wh

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

phosek added a comment. In https://reviews.llvm.org/D41103#955540, @vitalybuka wrote: > Can you please add some details about why someone wants to customize LIBXX > here? > Or even better attach a patch which uses this. I plan on using it from https://reviews.llvm.org/D37631 where I currently

[PATCH] D41261: [libcxxabi][demangler] Special case demangling for pass_object_size attribute

erik.pilkington updated this revision to Diff 127067. erik.pilkington added a comment. Add a testcase with pass_object_size[0-3]. https://reviews.llvm.org/D41261 Files: src/cxa_demangle.cpp test/test_demangle.pass.cpp Index: test/test_demangle.pass.cpp

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

malaperle accepted this revision. malaperle added a comment. Looks good to me. But this is not really my area :) Repository: rC Clang https://reviews.llvm.org/D39375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: clangd/ClangdServer.cpp:454 + +IncludeReferenceMap IRM = std::move(AST->takeIRM()); +Result = clangd::findDefinitions(*AST, Pos, Logge

[PATCH] D24933: Enable configuration files in clang

hintonda added inline comments. Comment at: include/clang/Config/config.h.cmake:40 +#cmakedefine CLANG_CONFIG_FILE_SYSTEM_DIR ${CLANG_CONFIG_FILE_SYSTEM_DIR} +#cmakedefine CLANG_CONFIG_FILE_USER_DIR ${CLANG_CONFIG_FILE_USER_DIR} + These need to be in quotes since

[PATCH] D41077: [analyser] different.CallArgsOrder checker implementation

anna resigned from this revision. anna added a comment. Perhaps added me incorrectly as reviewer? Repository: rC Clang https://reviews.llvm.org/D41077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D40594: [InstCombine] miscompile of __builtin_fmod

hfinkel added a comment. In https://reviews.llvm.org/D40594#940571, @spatel wrote: > Added a blurb to the LangRef with https://reviews.llvm.org/rL319437, so I > think we can abandon this patch. Sounds good. https://reviews.llvm.org/D40594 ___ cf

Re: r320750 - Fix many -Wsign-compare and -Wtautological-constant-compare warnings.

Hello Zachary, It looks like this commit added an error to one of our builders: http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/3735 . . . FAILED: /usr/local/gcc-7.1/bin/g++-7.1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMI

[PATCH] D41266: [analyzer] With c++-allocator-inlining, fix memory space for operator new pointers.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Default global `operator new()`, like `malloc()`, should return heap pointers, which in the analyzer are represented by `SymbolicRegion`s wit

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDocReporter.h:35 + +struct StringPair { + std::string Key; JDevlieghere wrote: > Do you still need this? Yes, it's used to serialize the map to yaml. https://reviews.llvm.org/D41102 __

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from some documentation nits, LGTM! Comment at: docs/clang-tidy/checks/fuchsia-virtual-inheritance.rst:6 + +Warns if classes are defined or created with v

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 127053. juliehockett marked 8 inline comments as done. https://reviews.llvm.org/D41102 Files: tools/CMakeLists.txt tools/clang-doc/CMakeLists.txt tools/clang-doc/ClangDoc.cpp tools/clang-doc/ClangDoc.h tools/clang-doc/ClangDocReporter.cpp too

[PATCH] D24933: Enable configuration files in clang

hfinkel added inline comments. Comment at: lib/Driver/Driver.cpp:641 + +static std::string getAbsolutePath(StringRef P) { + if (P.empty()) Use llvm::sys::fs::make_absolute instead of this. https://reviews.llvm.org/D24933

[PATCH] D40299: [Complex] Don't use __div?c3 when building with fast-math.

hfinkel added inline comments. Comment at: lib/CodeGen/CGExprComplex.cpp:773 // supported imaginary types in addition to complex types. -if (RHSi) { +if (RHSi && !FMF.isFast()) { BinOpInfo LibCallOp = Op; fhahn wrote: > Would the following str

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

NoQ added a comment. Herald added a subscriber: rnkovacs. In https://reviews.llvm.org/D35109#943558, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D35109#937763, @NoQ wrote: > > > For the type extension approach, somebody simply needs to do the math and > > prove that it works soundly

[PATCH] D32906: [Analyzer] Iterator Checker - Part 10: Support for iterators passed as parameter

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added subscribers: a.sidorin, rnkovacs, szepet. I really hope that i'd be able to do something about pass-by-copy in C++, because there's a lot of mess there. I approve this trick unless i act

[PATCH] D32905: [Analyzer] Iterator Checker - Part 9: Evaluation of std::find-like calls

NoQ added inline comments. Herald added subscribers: a.sidorin, rnkovacs, szepet. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1584-1588 + auto stateFound = state->BindExpr(CE, LCtx, RetVal); + auto stateNotFound = state->BindExpr(CE, LCtx, SecondParam); + + C.a

[PATCH] D32904: [Analyzer] Iterator Checker - Part 8: Support for assign, clear, insert, emplace and erase operations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added subscribers: a.sidorin, rnkovacs, szepet. This looks clear to me. https://reviews.llvm.org/D32904 ___ cfe-commits mailing list cfe-commits

[PATCH] D32902: [Analyzer] Iterator Checker - Part 7: Support for push and pop operations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added subscribers: a.sidorin, rnkovacs, szepet. This looks clear to me. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1449-1464 +const CXXRecordDecl *getCXXRec

[PATCH] D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added subscribers: a.sidorin, rnkovacs, szepet. This looks clear to me. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:554-555 + + verifyMatch(C, State->getSVa

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

NoQ added inline comments. Herald added subscribers: a.sidorin, rnkovacs, szepet. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1489-1511 +SymbolRef replaceSymbol(SymbolManager &SymMgr, SymbolRef OrigExpr, +SymbolRef OldExpr, SymbolRef NewSym

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

NoQ added inline comments. Herald added subscribers: a.sidorin, rnkovacs, szepet. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:340-358 +const auto *Templ = Func->getPrimaryTemplate(); +if (!Templ) + return; + +const auto *TParams = Templ->getTempla

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

NoQ added inline comments. Herald added subscribers: a.sidorin, rnkovacs, szepet. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:605 + if (Pos && !Pos->isValid()) { +// If I do not put a tag here, some invalidation tests will fail +static CheckerProgramPoint

[PATCH] D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

NoQ added a comment. Herald added subscribers: a.sidorin, rnkovacs, szepet. This patch would be in a good shape once we settle the rearrangement stuff. I had a look at all follow-up patches and identified other, hopefully smaller, places where i have overall design concerns; otherwise, the rest

[PATCH] D41261: [libcxxabi][demangler] Special case demangling for pass_object_size attribute

george.burgess.iv added a comment. Thanks for working on this! Unfortunately, I've never touched demanglers before, so I don't think I can LGTM this patch. > This attribute is mangled as if it was meant to match the > production. Yup, definitely a mistake. Apologies. :) C

[PATCH] D40451: [OpenMP] Add function attribute for triggering shared memory lowering in the LLVM backend

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:937 if (!CapturedVars.empty()) { + // There's somehting to share, add the attribute + CGF.CurFn->addFnA

r320766 - Remove duplicate python libclang changes from r320748

Author: arphaman Date: Thu Dec 14 15:40:42 2017 New Revision: 320766 URL: http://llvm.org/viewvc/llvm-project?rev=320766&view=rev Log: Remove duplicate python libclang changes from r320748 Modified: cfe/trunk/bindings/python/clang/cindex.py cfe/trunk/bindings/python/tests/cindex/test_curs

[PATCH] D36952: [libclang] Add support for checking abstractness of records

arphaman added a comment. Fixed in r320766. Sorry about that! Repository: rL LLVM https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36952: [libclang] Add support for checking abstractness of records

arphaman added a comment. In https://reviews.llvm.org/D36952#955937, @jklaehn wrote: > Thanks! However, compared to diff 126298 > (https://reviews.llvm.org/differential/diff/126298/), there seems to be > duplication in the committed change (maybe some artifacts due to > rebasing/merging?). Sho

r320765 - Correct UnaryTransformTypeLoc to properly initialize.

Author: erichkeane Date: Thu Dec 14 15:37:08 2017 New Revision: 320765 URL: http://llvm.org/viewvc/llvm-project?rev=320765&view=rev Log: Correct UnaryTransformTypeLoc to properly initialize. The initializeLocal function of UnaryTransformTypeLoc missed the UnderlyingTInfo member. This caused a nu

[PATCH] D40901: Refactor lazy loading of template specializations. NFC

v.g.vassilev closed this revision. v.g.vassilev added a comment. Thanks! Landed in r320763. https://reviews.llvm.org/D40901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r320763 - D40901: Refactor lazy loading of template specializations. NFC

Author: vvassilev Date: Thu Dec 14 15:30:18 2017 New Revision: 320763 URL: http://llvm.org/viewvc/llvm-project?rev=320763&view=rev Log: D40901: Refactor lazy loading of template specializations. NFC Modified: cfe/trunk/include/clang/AST/DeclTemplate.h cfe/trunk/lib/AST/DeclTemplate.cpp M

[PATCH] D41261: [libcxxabi][demangler] Special case demangling for pass_object_size attribute

erik.pilkington created this revision. erik.pilkington added reviewers: EricWF, george.burgess.iv. This patch adds demangling for pass_object_size attribute (https://clang.llvm.org/docs/AttributeReference.html#pass-object-size). This attribute applies to function parameters. This attribute is ma

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett marked 3 inline comments as done. juliehockett added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed [fuchsia-virt

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

juliehockett updated this revision to Diff 127033. juliehockett added a comment. Updating checker to only warn on declarations. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/VirtualInheritanceCheck.cpp

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn added a comment. Thanks! However, compared to diff 126298 (https://reviews.llvm.org/differential/diff/126298/), there seems to be duplication in the committed change (maybe some artifacts due to rebasing/merging?). Should I submit a follow-up patch to fix this? Comme

[PATCH] D40809: [WIP] [analyzer] Dump counterexample traces as C programs

george.karpenkov added a comment. @dcoughlin my current iteration creates a `PathDiagnosticConsumer` which outputs HTML with this report. I think that makes much more sense (as essentially this is a way of visualizing the error path). https://reviews.llvm.org/D40809

[PATCH] D40809: [WIP] [analyzer] Dump counterexample traces as C programs

NoQ added a comment. In https://reviews.llvm.org/D40809#955929, @dcoughlin wrote: > As it stands, this is a debugging tool not a way to communicate error paths > to end users. (I think that, too, would be very helpful but I'd like to see > this as a debugging aid first.) The workflow for debugg

[PATCH] D40809: [WIP] [analyzer] Dump counterexample traces as C programs

dcoughlin added a comment. In https://reviews.llvm.org/D40809#954890, @NoQ wrote: > In https://reviews.llvm.org/D40809#954858, @dcoughlin wrote: > > > One possibility is to turn this into a debug checker similar to > > debug.ViewExplodedGraph. That checker registers for a checkEndAnalysis() > >

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

hfinkel added inline comments. Comment at: lib/Frontend/VerifyDiagnosticConsumer.cpp:398 +// DToken is foo-bar-warning, but foo is the only -verify prefix). +if (Prefixes.end() == std::find(Prefixes.begin(), Prefixes.end(), DToken)) + continue; > Con

[PATCH] D41080: Don't trigger -Wuser-defined-literals for system headers

This revision was automatically updated to reflect the committed changes. Closed by commit rC320755: Don't trigger -Wuser-defined-literals for system headers (authored by dim, committed by ). Changed prior to commit: https://reviews.llvm.org/D41080?vs=126436&id=127029#toc Repository: rC Clan

r320755 - Don't trigger -Wuser-defined-literals for system headers

Author: dim Date: Thu Dec 14 14:32:24 2017 New Revision: 320755 URL: http://llvm.org/viewvc/llvm-project?rev=320755&view=rev Log: Don't trigger -Wuser-defined-literals for system headers Summary: In D41064, I proposed adding `#pragma clang diagnostic ignored "-Wuser-defined-literals"` to some of

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC320753: [ThreadSafetyAnalysis] Fix isCapabilityExpr (authored by kongyi, committed by ). Repository: rC Clang https://reviews.llvm.org/D41224 Files: lib/Sema/SemaDeclAttr.cpp test/Sema/attr-capabi

[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

aaron.ballman closed this revision. aaron.ballman added a comment. Committed (with additional comments on deviating attributes) in r320752. https://reviews.llvm.org/D40625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

arphaman added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D36790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r320752 - Harmonize GNU- and C++-style attribute spellings.

Author: aaronballman Date: Thu Dec 14 14:17:09 2017 New Revision: 320752 URL: http://llvm.org/viewvc/llvm-project?rev=320752&view=rev Log: Harmonize GNU- and C++-style attribute spellings. Most attributes will now use the Clang<"name"> construct to provide both __attribute__((name)) and [[clang:

[PATCH] D41259: [debuginfo] Remove temporary FIXME.

This revision was automatically updated to reflect the committed changes. Closed by commit rC320751: [debuginfo] Remove temporary FIXME. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41259?vs=127019&id=127025#toc Repository: rC Clang https://review

r320751 - [debuginfo] Remove temporary FIXME.

Author: dhinton Date: Thu Dec 14 14:12:46 2017 New Revision: 320751 URL: http://llvm.org/viewvc/llvm-project?rev=320751&view=rev Log: [debuginfo] Remove temporary FIXME. Summary: Now that r320495, "[debuginfo-tests] Support moving debuginfo-tests to llvm/projects," has landed, remove temporary FI

r320750 - Fix many -Wsign-compare and -Wtautological-constant-compare warnings.

Author: zturner Date: Thu Dec 14 14:07:03 2017 New Revision: 320750 URL: http://llvm.org/viewvc/llvm-project?rev=320750&view=rev Log: Fix many -Wsign-compare and -Wtautological-constant-compare warnings. Most of the -Wsign-compare warnings are due to the fact that enums are signed by default in t

[PATCH] D41259: [debuginfo] Remove temporary FIXME.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I suppose this is fine, please check on the green dragon builders after committing to make sure there's no unexpected fallout. Repository: rC Clang https://reviews.llvm.org/D41259 ___

r320748 - [libclang] Add support for checking abstractness of records

Author: arphaman Date: Thu Dec 14 14:01:50 2017 New Revision: 320748 URL: http://llvm.org/viewvc/llvm-project?rev=320748&view=rev Log: [libclang] Add support for checking abstractness of records This patch allows checking whether a C++ record declaration is abstract through libclang and clang.cin

[PATCH] D36952: [libclang] Add support for checking abstractness of records

This revision was automatically updated to reflect the committed changes. Closed by commit rL320748: [libclang] Add support for checking abstractness of records (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D36952?vs=126298&id=127021#toc Repository:

[PATCH] D41259: [debuginfo] Remove temporary FIXME.

hintonda created this revision. hintonda added reviewers: zturner, aprantl. Herald added a subscriber: JDevlieghere. Now that r320495, "[debuginfo-tests] Support moving debuginfo-tests to llvm/projects," has landed, remove temporary FIXME that supported the old mechanism. Repository: rC Clang

[PATCH] D40929: Unblock Swift Calling Convention Mangling on Windows

rnk added a comment. @compnerd's suggestion is still a decent one: https://reviews.llvm.org/D31372 Which, I think is just adding something wacky like `@swiftcc@__Swift@@` which would demangle as `__Swift::swiftcc` if the demangler expected an NNS there. Of course, it doesn't, so it won't demang

r320747 - Revert "[ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style"

Author: benhamilton Date: Thu Dec 14 13:44:11 2017 New Revision: 320747 URL: http://llvm.org/viewvc/llvm-project?rev=320747&view=rev Log: Revert "[ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style" This reverts commit 37e69667f748e1458b46483b7c1b8f9ba33eec44. We're

[PATCH] D41258: [analyzer] trackNullOrUndefValue: deduplicate path pieces for each node.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This addresses the regression in https://reviews.llvm.org/D41254 in `inlining/path-notes.cpp` by adding a new straightforward mechanism that

[PATCH] D40925: Add option -fkeep-static-consts

rnk added a comment. This isn't sufficient, GlobalDCE will remove the internal constant. It's also unlikely that the constant will survive `--gc-sections / -fdata-sections`. A better solution would be to add a new attribute (`__attribute__((nondiscardable))`? too close to `nodiscard`?) that add

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

krytarowski added a comment. In particular, this issue has been detected with dtls_test.c (MSan test), but it is valid to every program checking dlerror(). I've pluged more missing symbols through https://reviews.llvm.org/D41053, there are still few but I'm now busy with teaching sanitizers abo

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

eugenis added a comment. Yes, I support adding -lutil - sorry I was not clear about that. By dlerror() errors, do you mean the warnings about missing interceptors that appear with verbosity=1 (non-fatal), or something else? Repository: rL LLVM https://reviews.llvm.org/D41054

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

krytarowski added a comment. `-lutil` is just the same case as `-lrt` or `-lm` here. The potential problem with with autoconf and similar is the design problem, not NetBSD linking here with -lutil. Without this -lutil, every sanitizer with interceptors will generate spurious dlerror() errors f

[clang-tools-extra] r320743 - [clangd] Put all #includes in one block in clangd source files. NFC

Author: ioeric Date: Thu Dec 14 13:22:03 2017 New Revision: 320743 URL: http://llvm.org/viewvc/llvm-project?rev=320743&view=rev Log: [clangd] Put all #includes in one block in clangd source files. NFC Clang-format categorizes and sorts #includes with style. It doesn't make sense to manually manag

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

eugenis added a comment. One problem with interceptors is that any sanitized binary looks (to a configure-like script) as if it implements forkpty. But an attempt to use forkpty without actually linking -lutil will fail at runtime, because interceptors are just wrappers. Repository: rL LLVM

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

krytarowski added a comment. In https://reviews.llvm.org/D41054#955755, @joerg wrote: > I'm not really a fan of linking libutil into all binaries. Why is this code > using forkpty in first place and not posix_openpt/grantpt? pid_t forkpty(int *amaster, char *name, struct termios *term, s

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait to commit for a few days in case @delesley has any concerns. Repository: rC Clang https://reviews.llvm.org/D41224 __

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

joerg added a comment. I'm not really a fan of linking libutil into all binaries. Why is this code using forkpty in first place and not posix_openpt/grantpt? Repository: rL LLVM https://reviews.llvm.org/D41054 ___ cfe-commits mailing list cfe-co

[PATCH] D40478: Added Instrument Control Flow Flag

oren_ben_simhon updated this revision to Diff 127008. oren_ben_simhon added a comment. Implemented all comments posted until 12/14 (Thanks Peter) Repository: rL LLVM https://reviews.llvm.org/D40478 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/Cod

[PATCH] D39994: Loosen MSVC 2017 path requirements

dmajor added a comment. > Anyway, I'm just venting. If rnk@ wants to lgtm this, I'm fine. @rnk, any objection to this patch? https://reviews.llvm.org/D39994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D36952: [libclang] Add support for checking abstractness of records

arphaman added a comment. Sure, I'll do it today. https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane updated this revision to Diff 127005. erichkeane added a comment. Fix error message per @aaron.ballman s suggestion. https://reviews.llvm.org/D40819 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/Targ

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

On Thu, Dec 14, 2017 at 2:21 AM Anton via Phabricator < revi...@reviews.llvm.org> wrote: > xgsa added a comment. > > In https://reviews.llvm.org/D39622#954585, @probinson wrote: > > > Philosophically, mangled names and DWARF information serve different > purposes, and I don't think you will find o

[PATCH] D41253: [analyzer] WIP: trackNullOrUndefValue: track last store to symbolic pointers.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. `bugreporter::trackNullOrUndefValue()` checker API function extends a bug report with a recursive family of bug report visitors (`Ret

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333 +def err_multiversion_duplicate : Error< + "multiversion function duplicate declarations require identical target " + "attributes">; aaron.ballman wrote: > instead of

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

kongyi added a comment. In https://reviews.llvm.org/D41224#955213, @lebedev.ri wrote: > Hi. > I don't want to hijack the thread, but is PR32954 > likely unrelated to this fix, > and the problem (if it is a bug) is likely elsewhere? Should be unre

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added inline comments. Comment at: clangd/index/Index.h:134 + virtual bool + fuzzyFind(Context &Ctx, const FuzzyFindRequest &Req, +std::function Callback) const = 0; ioeric wrote: > malaperle wrote: > > I think a more generic std::function

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333-9335 + "multiversion function would have identical mangling to a previous " + "definition. Duplicate declarations must have identical target attribute " + "values">; -

Re: r320734 - [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like

Sorry, I forgot to add the tests in SVN. I committed them in 320735 On 14 December 2017 at 11:22, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Thu Dec 14 11:22:02 2017 > New Revision: 320734 > > URL: http://llvm.org/viewvc/llvm-project?rev=320734&vie

r320735 - Commit missing tests for r320734

Author: arphaman Date: Thu Dec 14 11:22:41 2017 New Revision: 320735 URL: http://llvm.org/viewvc/llvm-project?rev=320735&view=rev Log: Commit missing tests for r320734 Added: cfe/trunk/test/Preprocessor/is_target.c cfe/trunk/test/Preprocessor/is_target_arm.c cfe/trunk/test/Preprocesso

r320734 - [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like

Author: arphaman Date: Thu Dec 14 11:22:02 2017 New Revision: 320734 URL: http://llvm.org/viewvc/llvm-project?rev=320734&view=rev Log: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros This patch implements the __is_target_arch, __is_target_vendor, __i

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

This revision was automatically updated to reflect the committed changes. Closed by commit rC320734: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D41087?vs=126856&id=1270

Re: Status of CET support? (Re: [PATCH] D40224:...)

On Thu, Dec 14, 2017 at 2:39 AM, Pavel Chupin wrote: > Hi Kostya, > Long time no see. :) > Yey!! Thanks for the update! --kcc > I would estimate that everything (glibc, kernel, loader, simulator) > should be available approx. February 2018 as soon as implementation > finished and tested on ou

[PATCH] D41250: [analyzer] Model implied cast around operator new().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. C++ overridable `operator new()` has the following prototype: void *operator new(size_t size, user-defined arguments...); The retu

[PATCH] D41032: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC320730: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41032?vs=126641&id=126997#toc Repository:

r320730 - [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

Author: rnk Date: Thu Dec 14 11:00:21 2017 New Revision: 320730 URL: http://llvm.org/viewvc/llvm-project?rev=320730&view=rev Log: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic Summary: InterlockedCompareExchange128 is a bit more complicated than the other InterlockedCompareExc

r320721 - In an ARC lambda-to-block conversion thunk, reclaim the return value of

Author: rjmccall Date: Thu Dec 14 10:21:14 2017 New Revision: 320721 URL: http://llvm.org/viewvc/llvm-project?rev=320721&view=rev Log: In an ARC lambda-to-block conversion thunk, reclaim the return value of the lambda so that we don't over-release it. Patch by Dan Zimmerman! Added: cfe/trunk

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer

rjmccall closed this revision. rjmccall added a comment. Sure, r320721. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41248: [libcxx] Suppress unused warning on apple.

hintonda created this revision. hintonda added a reviewer: EricWF. This warning is already suppressed on non-apple platforms, so this change just suppresses it on apple as well. Repository: rCXX libc++ https://reviews.llvm.org/D41248 Files: src/experimental/filesystem/operations.cpp Inde

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

vitalybuka added a comment. Can you please add some details about why someone wants to customize LIBXX here? Or even better attach a patch which uses this. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D41103 ___ cfe-commits mailing

[PATCH] D40651: Implement most of P0451 - Constexpr for std::complex

mclow.lists updated this revision to Diff 126986. mclow.lists added a comment. More context in the diff, and removed some tabs. Also commented out the constexpr tests for divide, since they fail at the moment. https://reviews.llvm.org/D40651 Files: include/complex test/std/numerics/complex

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

Nebiroth updated this revision to Diff 126984. Nebiroth marked an inline comment as done. Nebiroth added a comment. Minor code cleanup Repository: rC Clang https://reviews.llvm.org/D39375 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/PrecompiledPreamble.cpp Index: li

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth updated this revision to Diff 126980. Nebiroth marked 5 inline comments as done. Nebiroth added a comment. Removed test file Added mutex lock when changing CDB Minor code cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp

r320717 - [OPENMP] Add codegen for target data constructs with `nowait` clause.

Author: abataev Date: Thu Dec 14 09:00:17 2017 New Revision: 320717 URL: http://llvm.org/viewvc/llvm-project?rev=320717&view=rev Log: [OPENMP] Add codegen for target data constructs with `nowait` clause. Added codegen for the `nowait` clause in target data constructs. Modified: cfe/trunk/lib

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

aaron.ballman added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed [fuchsia-virtual-inheritance] + // CHECK-NEXT: D(int valu

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r320713. https://reviews.llvm.org/D40671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41195: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

This revision was automatically updated to reflect the committed changes. Closed by commit rC320714: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41195?vs=126969&id=1

r320714 - [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

Author: benhamilton Date: Thu Dec 14 08:17:38 2017 New Revision: 320714 URL: http://llvm.org/viewvc/llvm-project?rev=320714&view=rev Log: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style Summary: If we write the following code, it goes over 100 columns, so we need

  1   2   >