aheejin added a comment.
Thank you for confirming and reverting!
Repository:
rL LLVM
https://reviews.llvm.org/D39455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mattd added a comment.
Thanks for the comments Eli! I agree, it makes sense to flag certain
expressions to be type dependent at the earliest time of compilation. Clang
already does this, as the Value/Type dependence is established upon Expr
construction from MemberExpr construction.
As we ha
Author: hfinkel
Date: Sat Dec 2 19:10:13 2017
New Revision: 319629
URL: http://llvm.org/viewvc/llvm-project?rev=319629&view=rev
Log:
Revert "[CodeGen] Add initial support for union members in TBAA"
This reverts commit r319413. See PR35503.
We can't use "union member" as the access type here lik
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319623: [WebAssembly] Pass through --undefined to Wasm LLD
(authored by sbc).
Repository:
rC Clang
https://reviews.llvm.org/D40739
Files:
lib/Driver/ToolChains/WebAssembly.cpp
Index: lib/Driver/To
Author: sbc
Date: Sat Dec 2 15:11:13 2017
New Revision: 319623
URL: http://llvm.org/viewvc/llvm-project?rev=319623&view=rev
Log:
[WebAssembly] Pass through --undefined to Wasm LLD
This is a follow-on to D40724 (Wasm entrypoint changes #1,
add `--undefined` argument to LLD).
Patch by Nicholas Wi
sbc100 added a comment.
Sure I'll land this now.
Repository:
rC Clang
https://reviews.llvm.org/D40739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: phst
Date: Sat Dec 2 13:18:14 2017
New Revision: 319621
URL: http://llvm.org/viewvc/llvm-project?rev=319621&view=rev
Log:
Fix assume-filename handling in clang-format.el
Summary:
When 'buffer-file-name' is nil 'call-process-region' returned a segmentation
fault error.
This was a proble
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319621: Fix assume-filename handling in clang-format.el
(authored by phst).
Changed prior to commit:
https://reviews.llvm.org/D37903?vs=124242&id=125274#toc
Repository:
rC Clang
https://reviews.llvm
hfinkel added a comment.
In https://reviews.llvm.org/D39455#943182, @aheejin wrote:
> Once you confirm the bug, could you possibly revert the patch?
I agree. We should revert this. The relevant part of the test case is:
short *q;
p->u.vec[i] = 0;
q = &p->u.vec[16];
*q = 1;
return p->
aheejin added a comment.
Once you confirm the bug, could you possibly revert the patch?
Repository:
rL LLVM
https://reviews.llvm.org/D39455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
sabel83 marked 2 inline comments as done.
sabel83 added a comment.
I have extended the context as suggested.
https://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
sabel83 updated this revision to Diff 125272.
sabel83 marked an inline comment as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
Author: spatel
Date: Sat Dec 2 09:52:00 2017
New Revision: 319619
URL: http://llvm.org/viewvc/llvm-project?rev=319619&view=rev
Log:
[CodeGen] fix mapping from fmod calls to frem instruction
Similar to D40044 and discussed in D40594.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trun
Author: spatel
Date: Sat Dec 2 08:29:34 2017
New Revision: 319618
URL: http://llvm.org/viewvc/llvm-project?rev=319618&view=rev
Log:
[CodeGen] remove stale comment; NFC
The libm functions with LLVM intrinsic twins were moved above this blob with:
https://reviews.llvm.org/rL319593
Modified:
JonasToth added a comment.
I am happy with everything now. But one of the reviewers must accept.
https://reviews.llvm.org/D40671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added inline comments.
Comment at: test/clang-tidy/nolintnextline.cpp:23
+
+// NOLINTNEXTLINE without-brackets-skip-all, another-check
+class C5 { C5(int i); };
xgsa wrote:
> JonasToth wrote:
> > Ian confused now. The NOLINTNEXTLINE with incorrect paren
rwols updated this revision to Diff 125267.
rwols added a comment.
Herald added a subscriber: klimek.
- Merge with upstream revision 319613
- Fix FixItHints not getting applied correctly in all cases. The problem is
that clang::CharSourceRange can either be a TokenRange or a CharRange. In the
ca
xgsa added inline comments.
Comment at: test/clang-tidy/nolintnextline.cpp:23
+
+// NOLINTNEXTLINE without-brackets-skip-all, another-check
+class C5 { C5(int i); };
JonasToth wrote:
> Ian confused now. The NOLINTNEXTLINE with incorrect parents should not
> sile
JonasToth added a comment.
Its good that you added code examples to the clang-tidy documentation page. I
think that feature was not documented well before.
Comment at: test/clang-tidy/nolintnextline.cpp:23
+
+// NOLINTNEXTLINE without-brackets-skip-all, another-check
+class C5
ncw added a comment.
I'm glad to be involved in a small way. Our company uses Emscripten in one of
our products, and some of our employees were early contributors to Emscripten
years ago, when they were trying to get C++ working. Now I've been allowed to
spend a few weeks "investigating" Wasm,
xgsa updated this revision to Diff 125258.
xgsa added a comment.
Release note item was reworded
https://reviews.llvm.org/D40671
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/nolint.cpp
test/clang-tidy/nolintnextline.c
lebedev.ri added inline comments.
Comment at: docs/ReleaseNotes.rst:259
+- The ``NOLINT`` and ``NOLINTNEXTLINE`` suppression comments were extended to
support the list of checks
+ to disable in parentheses.
This reads strange, maybe it can be reworded somehow
22 matches
Mail list logo
