This revision was automatically updated to reflect the committed changes.
Closed by commit rL319148: run-clang-tidy: Use check_call instead of
check_output (authored by kfunk).
Repository:
rL LLVM
https://reviews.llvm.org/D37482
Files:
clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.
Author: kfunk
Date: Mon Nov 27 23:17:01 2017
New Revision: 319148
URL: http://llvm.org/viewvc/llvm-project?rev=319148&view=rev
Log:
run-clang-tidy: Use check_call instead of check_output
Summary:
Streamlines the output under Python 3.x.
Before:
```
b'Enabled checks:\nclang-analyzer-apiModeli
kfunk planned changes to this revision.
kfunk added a comment.
Marking this Diff properly -- it needs more work.
https://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
twoh updated this revision to Diff 124515.
twoh added a comment.
Thanks @jkorous-apple for your comments. I modified the type for the variables
and replaced unnecessary inserts and erases with updates.
https://reviews.llvm.org/D39279
Files:
include/clang/Lex/Lexer.h
lib/Lex/Lexer.cpp
tes
Author: mstorsjo
Date: Mon Nov 27 21:47:24 2017
New Revision: 319145
URL: http://llvm.org/viewvc/llvm-project?rev=319145&view=rev
Log:
[test] Fix a typo in a test comment. NFC.
Modified:
cfe/trunk/test/CodeGenCXX/dllexport.cpp
Modified: cfe/trunk/test/CodeGenCXX/dllexport.cpp
URL:
http://ll
rjmccall added a comment.
In Swift's IRGen, we have an option controlling whether to emit meaningful
value names. That option can be set directly from the command line, but it
defaults to whether we're emitting IR assembly (i.e. .ll, not .bc), which means
that the clients most interested in ge
Hello everyone,
Below are some buildbot numbers for the last week of 11/19/2017 -
11/25/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the week of 11/12/2017 - 11/18/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:2238-2240
+ // All other pointers are unique.
+ if (Ty->isPointerType() || Ty->isMemberPointerType())
+return true;
erichkeane wrote:
> rsmith wrote:
> > This is not correct: member pointer re
Author: djg
Date: Mon Nov 27 17:13:45 2017
New Revision: 319129
URL: http://llvm.org/viewvc/llvm-project?rev=319129&view=rev
Log:
[WebAssembly] Add options for using the nontrapping-fptoint feature.
This adds ways to control use of WebAssembly's new nontrapping-fptoint
feature.
Modified:
cfe
Author: ahatanak
Date: Mon Nov 27 16:36:29 2017
New Revision: 319123
URL: http://llvm.org/viewvc/llvm-project?rev=319123&view=rev
Log:
Insert padding before the __cxa_exception header to ensure the thrown
object is sufficiently aligned.
r303175 annotated field unwindHeader of __cxa_exception with
erichkeane updated this revision to Diff 124490.
erichkeane marked an inline comment as done.
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
lib/AST/Type.cpp
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/type-traits.cpp
I
erichkeane marked 10 inline comments as done.
erichkeane added a comment.
Patch incoming, I think I got everything. I'll do the error on array of
aligned items in a separate patch, hopefully tomorrow AM.
Comment at: lib/AST/ASTContext.cpp:2183-2184
+ for (const auto *Field :
tra added a comment.
In https://reviews.llvm.org/D40275#933253, @tra wrote:
> @rjmccall : are you OK with this approach? If VLA is not supported by the
> target, CUDA is handled as a special case so it can emit deferred diag,
> OpenMP reports an error only if shouldDiagnoseTargetSupportFromOpen
Hi,
I see these patches for the CET support in LLVM -- great!
Could you please also tell us
* what's the status of the Linux Kernel and Glibc support for CET?
* how we can start evaluating the hardware feature (simulators, etc)?
Thanks!
--kcc
On Sun, Nov 26, 2017 at 4:35 AM, Phabricator vi
Author: rnk
Date: Mon Nov 27 15:42:20 2017
New Revision: 319116
URL: http://llvm.org/viewvc/llvm-project?rev=319116&view=rev
Log:
[clang-cl] Alias /Wall to -Weverything
cl interprets this option to mean enable every supported warning, which
is what Clang's -Weverything flag does.
Modified:
c
Wizard updated this revision to Diff 124486.
Wizard added a comment.
new line for doc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNserrorInitCheck.cpp
clang-tidy/objc/AvoidNserrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/
Wizard created this revision.
Herald added subscribers: cfe-commits, mgorny, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNserrorInitCheck.cpp
clang-tidy/objc/AvoidNserrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/obj
tra requested changes to this revision.
tra added a comment.
This revision now requires changes to proceed.
I'm reluctant to add a distribution-specific search path unconditionally.
We do have Distro.IsDebian()
https://github.com/llvm-mirror/clang/blob/9f9177d3ef72580ca29e8844327f63d7aa1908af/in
arphaman created this revision.
This patch extends libclang by allowing it to record parsing operations to a
temporary JSON file. The file is deleted after parsing succeeds. When a crash
happens during parsing, the file is preserved and the client will be able to
use it to generate a reproducer
bcain added a comment.
I think some of the `XFAIL: availability` may be wrong here. I'd submit a
patch, but it's not clear to me what the appropriate fix is.
Comment at: libcxx/trunk/utils/libcxx/test/config.py:400
+if self.use_system_cxx_lib or self.with_availability
Author: aaronballman
Date: Mon Nov 27 14:59:33 2017
New Revision: 319111
URL: http://llvm.org/viewvc/llvm-project?rev=319111&view=rev
Log:
Add an option to misc-move-const-arg to not diagnose on trivially copyable
types.
Patch by Oleg Smolsky
Added:
clang-tools-extra/trunk/test/clang-tidy/
nathawes added a comment.
Thanks for the feedback @malaperle!
Comment at: include/indexstore/IndexStoreCXX.h:84
+
+ std::pair getLineCol() {
+unsigned line, col;
malaperle wrote:
> From what I understand, this returns the beginning of the occurrence. It
>
Author: marshall
Date: Mon Nov 27 14:27:22 2017
New Revision: 319106
URL: http://llvm.org/viewvc/llvm-project?rev=319106&view=rev
Log:
Fix problems with r'890 when building on machines where sizeof(size_t) !=
sizeof(unsigned long long) and C++03
Modified:
libcxx/trunk/include/bitset
lib
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:2129-2130
+bool isStructEmpty(QualType Ty) {
+ assert(Ty.getTypePtr()->isStructureOrClassType() &&
+ "Must be struct or class");
+ const RecordDecl *RD = Ty.getTypePtr()->getAs()->getDecl();
--
efriedma added inline comments.
Comment at: test/Driver/arm-mfpu.c:301
+// RUN: | FileCheck --check-prefix=CHECK-SOFT-ABI-FP %s
+// R-UN: %clang -target armv4-linux-gnueabi -mfloat-abi=soft -mfpu=none %s
-### -c 2>&1 \
+// R-UN: | FileCheck --check-prefix=CHECK-SOFT-ABI-FP %
Author: wizard
Date: Mon Nov 27 13:30:10 2017
New Revision: 319098
URL: http://llvm.org/viewvc/llvm-project?rev=319098&view=rev
Log:
add new check to find OSSpinlock usage
Summary:
This check finds the use of methods related to OSSpinlock in Objective-C code,
which should be deprecated due to li
mcrosier added a comment.
In https://reviews.llvm.org/D40476#936372, @pirama wrote:
> Thanks for the review. Now let's just hope the windows bots stay happy :)
Actually, I just checked and it looks like falkor and saphira were both added
as of a few weeks ago. I'll revert this part of the pa
Author: djg
Date: Mon Nov 27 13:39:16 2017
New Revision: 319101
URL: http://llvm.org/viewvc/llvm-project?rev=319101&view=rev
Log:
[WebAssemby] Enable "-mthread-model single" by default, for now.
The WebAssembly standard does not yet have threads, and while it's in the
process of being standardize
aprantl added a comment.
In https://reviews.llvm.org/D24998#932061, @torarnv wrote:
> This seems to have hit a recent Xcode toolchain (Xcode 9.1 ?).
>
> Xcode now complains that "[app name] was compiled with optimization -
> stepping may behave oddly; variables may not be available.", when launc
malaperle added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:246
+
+ C.reply(json::ary(Highlights->Value));
+}
I get a test failure here because there is an assertion that the Expected<>
needs to be checked. I can't really think of any failure case r
Nebiroth updated this revision to Diff 124458.
Nebiroth marked 3 inline comments as done.
Nebiroth added a comment.
Minor code cleanup
Fixed highlights sometimes obtaining one too many characters inside range
Updated test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
Fil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319098: add new check to find OSSpinlock usage (authored by
Wizard).
Repository:
rL LLVM
https://reviews.llvm.org/D40325
Files:
clang-tools-extra/trunk/clang-tidy/objc/AvoidSpinlockCheck.cpp
clang
Wizard updated this revision to Diff 124456.
Wizard added a comment.
Herald added a subscriber: klimek.
fix conflict
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40325
Files:
clang-tidy/objc/AvoidSpinlockCheck.cpp
clang-tidy/objc/AvoidSpinlockCheck.h
clang-tidy/objc/CMa
rnk added a comment.
It's not clear to me that this abbreviation functionality should live in
Support. Clang probably wants enough control over this (assuming we're doing
it) that the logic should live in clang.
I also think we might want to try solving this a completely different way: just
do
lebedev.ri added a comment.
In https://reviews.llvm.org/D39462#936566, @bcain wrote:
> I'd like to understand/resurrect this change, so I'll try to summarize.
> Please correct this as appropriate:
>
> 1. We got here because libc++ has code that triggers a warning for some
> targets (those whos
benhamilton added inline comments.
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
Wizard wrote:
> benhamilton wrote:
> > Not sure why you declared (and defined?) this one but not the other
bcain added a comment.
I'd like to understand/resurrect this change, so I'll try to summarize. Please
correct this as appropriate:
1. We got here because libc++ has code that triggers a warning for some targets
(those whose `int` and `long` have the same size).
2. This change would "move" the
malaperle requested changes to this revision.
malaperle added a comment.
This revision now requires changes to proceed.
I tested the patch and it works quite well! I think those are the last comments
from me. Sorry, I should have bundled them together a bit more :(
Comment at:
Wizard updated this revision to Diff 124448.
Wizard added a comment.
fix test
https://reviews.llvm.org/D40325
Files:
clang-tidy/objc/AvoidSpinlockCheck.cpp
clang-tidy/objc/AvoidSpinlockCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
docs/ReleaseNotes.rst
do
Wizard marked an inline comment as done.
Wizard added inline comments.
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
benhamilton wrote:
> Not sure why you declared (and defined?) this one
Author: marshall
Date: Mon Nov 27 12:47:54 2017
New Revision: 319091
URL: http://llvm.org/viewvc/llvm-project?rev=319091&view=rev
Log:
Revert commit removing allocator support from packaged_task. Will investigate
further
Added:
libcxx/trunk/test/std/thread/futures/futures.task/futures.task.
Author: phosek
Date: Mon Nov 27 12:29:13 2017
New Revision: 319088
URL: http://llvm.org/viewvc/llvm-project?rev=319088&view=rev
Log:
[CMake][Fuchsia] Disable terminfo database in Fuchsia toolchain
It's used to determine whether terminal supports colors, but within LLVM
it's only used in handful o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319088: [CMake][Fuchsia] Disable terminfo database in
Fuchsia toolchain (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40329?vs=123875&id=124441#toc
Repository:
rL LLVM
htt
phosek created this revision.
Herald added subscribers: mgorny, dberris.
Don't link tests against libgcc when compiler-rt is being used.
Repository:
rL LLVM
https://reviews.llvm.org/D40513
Files:
test/CMakeLists.txt
test/lit.site.cfg.in
utils/libcxx/test/target_info.py
Index: utils/l
benhamilton added a comment.
Thanks, looks good. Just one question about the test.
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
Not sure why you declared (and defined?) this one but no
ahatanak added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:954
if (DstTy->isFloatingPointTy()) {
- if (!CGF.getContext().getLangOpts().HalfArgsAndReturns)
+ if (CGF.getContext().getTargetInfo().useFP16ConversionIntrinsics())
return Builder.Cr
Wizard updated this revision to Diff 124434.
Wizard marked 5 inline comments as done.
Wizard added a comment.
fix doc
https://reviews.llvm.org/D40325
Files:
clang-tidy/objc/AvoidSpinlockCheck.cpp
clang-tidy/objc/AvoidSpinlockCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTid
bruno added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:954
if (DstTy->isFloatingPointTy()) {
- if (!CGF.getContext().getLangOpts().HalfArgsAndReturns)
+ if (CGF.getContext().getTargetInfo().useFP16ConversionIntrinsics())
return Builder.Creat
Author: marshall
Date: Mon Nov 27 11:43:28 2017
New Revision: 319080
URL: http://llvm.org/viewvc/llvm-project?rev=319080&view=rev
Log:
Implement LWG#2921 and LWG#2976 - removing allocator support from packaged_task.
Removed:
libcxx/trunk/test/std/thread/futures/futures.task/futures.task.memb
ABataev updated this revision to Diff 124430.
ABataev added a comment.
Added codegen for `distribute parallel for simd` construct.
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
Author: abataev
Date: Mon Nov 27 11:38:52 2017
New Revision: 319078
URL: http://llvm.org/viewvc/llvm-project?rev=319078&view=rev
Log:
[OPENMP] Codegen for `distribute parallel for simd` directive.
Added proper codegen for `distribute parallel for simd` directive.
Modified:
cfe/trunk/lib/Basi
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D40329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
benhamilton accepted this revision.
benhamilton added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tidy/objc/AvoidSpinlockCheck.cpp:31-32
+ diag(MatchedExpr->getLocStart(),
+ "deprecated usage of OSSpinlock; Please use other locks or
Wizard marked 4 inline comments as done.
Wizard added inline comments.
Comment at: clang-tidy/objc/CMakeLists.txt:4
add_clang_library(clangTidyObjCModule
+ AvoidSpinlockCheck.cpp
ForbiddenSubclassingCheck.cpp
benhamilton wrote:
> IMHO this is really a check
Wizard updated this revision to Diff 124427.
Wizard added a comment.
address comments
https://reviews.llvm.org/D40325
Files:
clang-tidy/objc/AvoidSpinlockCheck.cpp
clang-tidy/objc/AvoidSpinlockCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/objc/ObjCTidyModule.cpp
docs/ReleaseNotes.
pirama added a comment.
Thanks for the review. Now let's just hope the windows bots stay happy :)
Repository:
rL LLVM
https://reviews.llvm.org/D40476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319077: Switch CPU names not recognized by GNU assembler
(authored by pirama).
Repository:
rL LLVM
https://reviews.llvm.org/D40476
Files:
cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
cfe/trunk/test/Dri
Author: pirama
Date: Mon Nov 27 11:18:39 2017
New Revision: 319077
URL: http://llvm.org/viewvc/llvm-project?rev=319077&view=rev
Log:
Switch CPU names not recognized by GNU assembler
Summary:
Switch CPU names not recognized by GNU assembler to a close CPU that it
does recognize. In this patch, kr
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D40257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
phosek added a comment.
Can you please take a look at this one as well (this one is Clang, the other
one was LLVM)?
Repository:
rL LLVM
https://reviews.llvm.org/D40257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: marshall
Date: Mon Nov 27 11:03:30 2017
New Revision: 319074
URL: http://llvm.org/viewvc/llvm-project?rev=319074&view=rev
Log:
Fix PR#35438 - bitset constructor does not zero unused bits
Modified:
libcxx/trunk/include/bitset
libcxx/trunk/test/std/utilities/template.bitset/bitset.
jakehehrlich updated this revision to Diff 124422.
jakehehrlich added a comment.
This test was failing on windows machines. I'm hoping this change (adding
"_cc1" to "%clang") will resolve this because %clang_cc1 shouldn't behave any
differently on windows.
Repository:
rC Clang
https://revie
juliehockett updated this revision to Diff 124421.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Updating docs
https://reviews.llvm.org/D40108
Files:
clang-tidy/CMakeLists.txt
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/DefaultArgumentsCheck.cpp
c
pirama updated this revision to Diff 124417.
pirama added a comment.
Normalize falkor and saphira as well.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
==
Nebiroth marked 12 inline comments as done.
Nebiroth added inline comments.
Comment at: test/clangd/did-change-configuration.test:33
+
+{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///compile_commands.json","languageId":"json","version":1
malcolm.parsons added a comment.
In https://reviews.llvm.org/D40505#936170, @lebedev.ri wrote:
> How about also matching on call to functions with no-return attribute?
Great idea!
But I'll keep this patch for just the throw bugfix.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.o
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-default-arguments.rst:6
+
+Warns if a function is declared or called with default arguments.
+
Please synchronize with text in Release Notes.
https://reviews.llvm.org/D40108
___
mcrosier added a comment.
Am I correct in assuming this is going to be a problem for Falkor and Saphira
as well? If so, can you add solutions for those as well? Cortex-a57 should be
good enough for those targets as well.
https://reviews.llvm.org/D40476
pirama updated this revision to Diff 124415.
pirama added a comment.
Sink 'Arg *' declaration.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
--- /d
srhines added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:661
Arg *A;
-if ((A = Args.getLastArg(options::OPT_mcpu_EQ)) &&
-StringRef(A->getValue()).equals_lower("krait"))
- CmdArgs.push_back("-mcpu=cortex-a15");
-else
- Args.AddLastAr
sepavloff created this revision.
Herald added a subscriber: JDevlieghere.
If a source file extensively uses templates, resulting LLVM IR may have
types with huge names. It may occur if a record type is defined in a class.
In this case its type name contains all declaration contexts and, if a
decla
Author: alexfh
Date: Mon Nov 27 09:59:26 2017
New Revision: 319062
URL: http://llvm.org/viewvc/llvm-project?rev=319062&view=rev
Log:
[clang-tidy] Rename qualified references to check class + support inconsistent
names
Modified:
clang-tools-extra/trunk/clang-tidy/rename_check.py
Modified: cl
pirama updated this revision to Diff 124412.
pirama added a comment.
Add missing space.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
--- /dev/null
lebedev.ri added a comment.
How about also matching on call to functions with no-return attribute?
i.e.
[[noreturn]] my_die();
void do_stuff();
void fn(int x) {
if(!x)
my_die();
else // <- since `my_die()` will never return, `else` is not really needed.
do_stuff();
alexfh created this revision.
Herald added subscribers: xazax.hun, mgorny.
rename_check.py misc-move-const-arg performance-move-const-arg
rename_check.py misc-noexcept-move-constructor
performance-noexcept-move-constructor
https://reviews.llvm.org/D40507
Files:
clang-tidy/hicpp/HICPPTidyModu
pirama updated this revision to Diff 124410.
pirama added a comment.
Address review comments.
https://reviews.llvm.org/D40476
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/as-mcpu.c
Index: test/Driver/as-mcpu.c
===
--- /de
Hahnfeld added a comment.
In that case I don't see a way to be "clever", so we have to add the static
candidate. I'll let @tra or @jlebar have a final look.
https://reviews.llvm.org/D40453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
benhamilton added inline comments.
Comment at: clang-tidy/objc/AvoidSpinlockCheck.cpp:22-24
+ if (!getLangOpts().ObjC1 && !getLangOpts().ObjC2) {
+return;
+ }
Why? `OSSpinLock()` calls should also be avoided in C++.
I think you should remove this.
=
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D40280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D40258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
beanz added a comment.
@phosek, I would love to see compiler-rt fully refactored so that we target one
triple at a time always. I'd also love to see the clang driver refactored so
that the code to resolve paths to runtime libraries was shared so we follow the
same conventions across all driver
sylvestre.ledru added a comment.
Debian packages don't update the PATH and we are aiming at providing packages
working out of the box.
In general, yeah, we have to do that for every distros... :/
https://reviews.llvm.org/D40453
___
cfe-commits mai
malcolm.parsons created this revision.
Herald added subscribers: cfe-commits, xazax.hun, klimek.
The readability-else-after-return check was not warning about
an else after a throw of an exception that had arguments that needed
to be cleaned up.
Repository:
rCTE Clang Tools Extra
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319058: [analyzer] pr34766: Fix a crash on explicit
std::initializer_list constructor. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D39803?vs=122094&id=124406#toc
Reposito
Author: dergachev
Date: Mon Nov 27 09:37:09 2017
New Revision: 319058
URL: http://llvm.org/viewvc/llvm-project?rev=319058&view=rev
Log:
[analyzer] pr34766: Fix a crash on explicit std::initializer_list constructor.
We didn't support the following syntax:
(std::initializer_list){12}
which sudd
NoQ added a comment.
Sorry, i wanted to quickly look at why this thing is lvalue, but this didn't
seem to be happening, so i guess i'd just commit for now.
Repository:
rL LLVM
https://reviews.llvm.org/D39800
___
cfe-commits mailing list
cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319055: [analyzer] pr34404: Fix a crash on modeling pointers
to indirect members. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D39800?vs=122087&id=124404#toc
Repository:
Author: dergachev
Date: Mon Nov 27 09:31:16 2017
New Revision: 319055
URL: http://llvm.org/viewvc/llvm-project?rev=319055&view=rev
Log:
[analyzer] pr34404: Fix a crash on modeling pointers to indirect members.
We were crashing whenever a C++ pointer-to-member was taken, that was pointing
to a mem
srhines added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:660
+// of a cpu flag.
+Arg *A = Args.getLastArg(options::OPT_mcpu_EQ);
+if (A) {
Is it better to sink A into the if condition again?
Comment at: test/Driver/a
Author: benhamilton
Date: Mon Nov 27 09:21:24 2017
New Revision: 319052
URL: http://llvm.org/viewvc/llvm-project?rev=319052&view=rev
Log:
[clang] Set up .arcconfig to point to new Diffusion C repository
Summary:
We want to automatically copy cfe-commits@ on review requests
to the clang repository
inspirer added inline comments.
Comment at: clangd/FuzzyMatch.cpp:254
+ // Penalty: matching inside a segment (and previous char wasn't matched).
+ if (WordRole[W] == Tail && P && !Matched[P - 1][W - 1])
+S -= 3;
You need a third boolean dimension in your D
benhamilton created this revision.
Herald added a subscriber: cfe-commits.
We want to automatically copy the appropriate mailing list
for review requests to the libc++abi repository.
For context, see the proposal and discussion here:
http://lists.llvm.org/pipermail/cfe-dev/2017-November/056032.h
juliehockett updated this revision to Diff 124397.
juliehockett marked 7 inline comments as done.
juliehockett added a comment.
Added new tests and updated wording in warning.
https://reviews.llvm.org/D40108
Files:
clang-tidy/CMakeLists.txt
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuc
benhamilton created this revision.
Herald added a subscriber: cfe-commits.
We want to automatically copy the appropriate mailing list
for review requests to the libc++ repository.
For context, see the proposal and discussion here:
http://lists.llvm.org/pipermail/cfe-dev/2017-November/056032.html
Author: abataev
Date: Mon Nov 27 08:54:08 2017
New Revision: 319046
URL: http://llvm.org/viewvc/llvm-project?rev=319046&view=rev
Log:
[OPENMP] Improve handling of cancel directives in target-based
constructs, NFC.
Improved handling of cancel|cancellation point directives inside
target-based for d
Nebiroth updated this revision to Diff 124391.
Nebiroth marked an inline comment as done.
Nebiroth added a comment.
Herald added a subscriber: klimek.
Removed temporary test file
Updated test to account for read-access symbol verification
Repository:
rCTE Clang Tools Extra
https://reviews.llv
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM, but as noted inline you should update the new llvm_unreachable() to have
a more descriptive error message.
Do you have commit access or do you need someone to commit this for you?
Comment at: lib/StaticAnalyze
Author: marshall
Date: Mon Nov 27 08:17:19 2017
New Revision: 319042
URL: http://llvm.org/viewvc/llvm-project?rev=319042&view=rev
Log:
Fix failure on C++03 bots
Modified:
libcxx/trunk/include/ostream
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.special/io.fail.cpp
li
benhamilton created this revision.
We want to automatically copy cfe-commits@ on review requests
to the clang repository.
Similar to https://reviews.llvm.org/D40179, I set up a new Diffusion repository
with callsign
"C" for clang:
https://reviews.llvm.org/source/clang/
This explicitly updates
1 - 100 of 156 matches
Mail list logo
