[PATCH] D40381: Parse concept definition

2017-11-25 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: include/clang/Sema/Sema.h:6194 +SourceLocation TemplateLoc, +const TemplateArgumentListInfo *TemplateArgs); + changyu wrote: > hubert.reinter

[libcxx] r318992 - More of P0600; marking allocation routines as [[nodiscard]]

2017-11-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Nov 25 18:55:38 2017 New Revision: 318992 URL: http://llvm.org/viewvc/llvm-project?rev=318992&view=rev Log: More of P0600; marking allocation routines as [[nodiscard]] Added: libcxx/trunk/test/std/utilities/allocator.adaptor/allocator.adaptor.members/allocate_size.

[PATCH] D40381: Parse concept definition

2017-11-25 Thread changyu via Phabricator via cfe-commits
changyu added inline comments. Comment at: include/clang/Sema/Sema.h:6194 +SourceLocation TemplateLoc, +const TemplateArgumentListInfo *TemplateArgs); + hubert.reinterpretcast wrote: > Indentation is

[PATCH] D40381: Parse concept definition

2017-11-25 Thread changyu via Phabricator via cfe-commits
changyu updated this revision to Diff 124268. changyu marked 2 inline comments as done. https://reviews.llvm.org/D40381 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/DeclNodes.td include/clang/Basic/DiagnosticSemaKinds.td include/cla

[libcxx] r318990 - Fix copy/paste bug in test where we were putting a '3' into a vector. NFC.

2017-11-25 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Nov 25 16:39:59 2017 New Revision: 318990 URL: http://llvm.org/viewvc/llvm-project?rev=318990&view=rev Log: Fix copy/paste bug in test where we were putting a '3' into a vector. NFC. Modified: libcxx/trunk/test/std/containers/sequences/vector.bool/size.pass.cpp Mod

[PATCH] D40381: Parse concept definition

2017-11-25 Thread changyu via Phabricator via cfe-commits
changyu planned changes to this revision. changyu marked 22 inline comments as done. changyu added inline comments. Comment at: lib/Parse/ParseTemplate.cpp:374 + + ExprResult ConstraintExpr = ParseConstraintExpression(); + saar.raz wrote: > Add a check to ParseC

Re: [clang-tools-extra] r318840 - [FindAllSymbols] Cache regexes, creating them is expensive

2017-11-25 Thread Krzysztof Parzyszek via cfe-commits
After upgrading my FreeBSD to the latest -STABLE this no longer fails. -Krzysztof PS. And system clang was upgraded to 5.0.0. Nice! On 11/25/2017 11:20 AM, Dimitry Andric wrote: Yeah, in the past libc++ broke its own ABI with http://llvm.org/viewvc/llvm-project?view=revision&revision=194536,

[libcxx] r318989 - Fix installation of cxxabi.h through libc++.

2017-11-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Nov 25 15:39:17 2017 New Revision: 318989 URL: http://llvm.org/viewvc/llvm-project?rev=318989&view=rev Log: Fix installation of cxxabi.h through libc++. Previously, the install command for the cxxabi headers specified the wrong component, and therefore they were not being

r318985 - [X86] Use separate builtins for fma4 scalar intrinsics. Use negations to remove some of the scalar fma3 builtins.

2017-11-25 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Nov 25 11:32:12 2017 New Revision: 318985 URL: http://llvm.org/viewvc/llvm-project?rev=318985&view=rev Log: [X86] Use separate builtins for fma4 scalar intrinsics. Use negations to remove some of the scalar fma3 builtins. fma4 instructions zero the upper bits of the xmm

Re: [clang-tools-extra] r318840 - [FindAllSymbols] Cache regexes, creating them is expensive

2017-11-25 Thread Dimitry Andric via cfe-commits
Yeah, in the past libc++ broke its own ABI with http://llvm.org/viewvc/llvm-project?view=revision&revision=194536, which is why we had to add the _LIBCPP_TRIVIAL_PAIR_COPY_CTOR hack to our own libc++ __config, in https://svnweb.freebsd.org/base?view=revision&revision=261801. (Afterwards, in ht

r318979 - [analyzer] Teach RetainCountChecker about CoreMedia APIs

2017-11-25 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Sat Nov 25 06:57:42 2017 New Revision: 318979 URL: http://llvm.org/viewvc/llvm-project?rev=318979&view=rev Log: [analyzer] Teach RetainCountChecker about CoreMedia APIs Teach the retain-count checker that CoreMedia reference types use CoreFoundation-style reference countin

[PATCH] D39913: [ObjC] warn about availability attributes missing from a method's declaration when they're specified for a method's definition

2017-11-25 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2921 +def warn_availability_on_implementation_not_interface : Warning< + "method declarati

r318976 - clang-format: [JS] do not collapse short classes.

2017-11-25 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sat Nov 25 01:35:33 2017 New Revision: 318976 URL: http://llvm.org/viewvc/llvm-project?rev=318976&view=rev Log: clang-format: [JS] do not collapse short classes. Summary: clang-format does not collapse short records, interfaces, unions, etc., but fails to do so if the record

r318975 - clang-format: [JS] handle semis in generic types.

2017-11-25 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sat Nov 25 01:33:47 2017 New Revision: 318975 URL: http://llvm.org/viewvc/llvm-project?rev=318975&view=rev Log: clang-format: [JS] handle semis in generic types. Summary: TypeScript generic type arguments can contain object (literal) types, which in turn can contain semicolo

[PATCH] D40424: clang-format: [JS] handle semis in generic types.

2017-11-25 Thread Martin Probst via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318975: clang-format: [JS] handle semis in generic types. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D40424 Files: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/u

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

2017-11-25 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. Reported here: http://bugs.debian.org/882505 Patch by Andreas Beckmann https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === ---

r318974 - clang-format: [JS] handle `for` as object label.

2017-11-25 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sat Nov 25 01:24:33 2017 New Revision: 318974 URL: http://llvm.org/viewvc/llvm-project?rev=318974&view=rev Log: clang-format: [JS] handle `for` as object label. Summary: Previously, clang-format would fail formatting `{for: 1}`. Reviewers: djasper Subscribers: klimek Diff

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

2017-11-25 Thread Henry Wong via Phabricator via cfe-commits
MTC updated this revision to Diff 124248. MTC marked an inline comment as done. MTC added a comment. 1.Use the `getAs<>` in the `if` condition. 2.Add an "Unexpected ProgramPoint" assertion to make this patch more complete. https://reviews.llvm.org/D37187 Files: lib/StaticAnalyzer/Core/PathDia

[PATCH] D40410: clang-format: [JS] disable ASI on decorators.

2017-11-25 Thread Martin Probst via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318973: clang-format: [JS] disable ASI on decorators. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D40410 Files: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/unitt

r318973 - clang-format: [JS] disable ASI on decorators.

2017-11-25 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sat Nov 25 01:19:42 2017 New Revision: 318973 URL: http://llvm.org/viewvc/llvm-project?rev=318973&view=rev Log: clang-format: [JS] disable ASI on decorators. Summary: Automatic Semicolon Insertion in clang-format tries to guess if a line wrap should insert an implicit semico

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

2017-11-25 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[clang-tools-extra] r318972 - [clang-tidy] Fix link error (http://llvm.org/PR35417).

2017-11-25 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Sat Nov 25 00:52:42 2017 New Revision: 318972 URL: http://llvm.org/viewvc/llvm-project?rev=318972&view=rev Log: [clang-tidy] Fix link error (http://llvm.org/PR35417). Modified: clang-tools-extra/trunk/clang-tidy/hicpp/CMakeLists.txt Modified: clang-tools-extra/trunk/clan

[clang-tools-extra] r318971 - [clang-tidy] Actually fix header guard handling in scripts

2017-11-25 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Sat Nov 25 00:49:04 2017 New Revision: 318971 URL: http://llvm.org/viewvc/llvm-project?rev=318971&view=rev Log: [clang-tidy] Actually fix header guard handling in scripts Modified: clang-tools-extra/trunk/clang-tidy/add_new_check.py clang-tools-extra/trunk/clang-tidy/

[PATCH] D39913: [ObjC] warn about availability attributes missing from a method's declaration when they're specified for a method's definition

2017-11-25 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak accepted this revision. ahatanak added a comment. LGTM Comment at: lib/Sema/SemaDeclAttr.cpp:2295 + MissingIntroduced = + MissingIntroduced ? Decl->getIntroduced().empty() : false; + MissingDeprecated = I feel like using "if" is easi