BillyONeal created this revision.
STL reviewed my [[nodiscard]] changes and suggested a ton more places. These
are the associated test changes in libcxx.
https://reviews.llvm.org/D39080
Files:
test/std/algorithms/alg.nonmodifying/alg.search/search_n.pass.cpp
test/std/algorithms/alg.nonmodi
tmsriram created this revision.
New clang option -fno-plt which avoids the PLT and lazy binding while making
external calls.
GCC supports -fno-plt,
https://gcc.gnu.org/ml/gcc-patches/2015-05/msg1.html. This patch adds this
to clang which marks all externally defined functions with the "nol
sgundapa abandoned this revision.
sgundapa added a comment.
This patch is already merged in a different commit
Repository:
rL LLVM
https://reviews.llvm.org/D39071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
erichkeane updated this revision to Diff 119535.
erichkeane added a comment.
Added function-pointer test.
https://reviews.llvm.org/D39075
Files:
lib/AST/Expr.cpp
test/CXX/dcl.dcl/dcl.attr/dcl.attr.nodiscard/p2.cpp
Index: lib/AST/Expr.cpp
===
erichkeane added inline comments.
Comment at: lib/Parse/ParseExpr.cpp:719
/// '__is_union'
+/// '__has_unique_object_representations' [MS]
///
STL_MSFT wrote:
> Should this be marked as MS if it's cross-vendor?
Ah, right :)
erichkeane added inline comments.
Comment at: lib/AST/Expr.cpp:2302
+ cast(DRE->getDecl())->hasLocalStorage()) &&
+!isa(CE->getSubExpr()->IgnoreParens())) {
return CE->getSubExpr()->isUnusedResultAWarning(WarnE, Loc,
aaron.ball
Author: rsmith
Date: Wed Oct 18 15:45:01 2017
New Revision: 316136
URL: http://llvm.org/viewvc/llvm-project?rev=316136&view=rev
Log:
Don't suppress instantiation of definitions for variables subject to explicit
instantiation declarations if they are usable from constant expressions.
We are permit
erichkeane updated this revision to Diff 119533.
erichkeane marked 3 inline comments as done.
https://reviews.llvm.org/D39064
Files:
include/clang/AST/Type.h
include/clang/Basic/TokenKinds.def
include/clang/Basic/TypeTraits.h
lib/AST/Type.cpp
lib/Parse/ParseExpr.cpp
lib/Sema/SemaExprC
aaron.ballman added inline comments.
Comment at: lib/AST/Expr.cpp:2302
+ cast(DRE->getDecl())->hasLocalStorage()) &&
+!isa(CE->getSubExpr()->IgnoreParens())) {
return CE->getSubExpr()->isUnusedResultAWarning(WarnE, Loc,
Does th
STL_MSFT added a comment.
Looks good to me modulo comments.
Comment at: lib/Parse/ParseExpr.cpp:719
/// '__is_union'
+/// '__has_unique_object_representations' [MS]
///
Should this be marked as MS if it's cross-vendor?
Author: erichkeane
Date: Wed Oct 18 15:17:16 2017
New Revision: 316132
URL: http://llvm.org/viewvc/llvm-project?rev=316132&view=rev
Log:
Fix capitalization of parameter
The .cpp file has this properly capitalized, but
the header does not. Simply fixed it.
Modified:
cfe/trunk/include/clang/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316130: [clang-format] Sort whole block of using
declarations while partially formatting (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D39024
Files:
cfe/trunk/lib/Format/Using
Author: krasimir
Date: Wed Oct 18 15:13:25 2017
New Revision: 316130
URL: http://llvm.org/viewvc/llvm-project?rev=316130&view=rev
Log:
[clang-format] Sort whole block of using declarations while partially formatting
Summary:
This patch enables sorting the full block of using declarations when
som
erichkeane created this revision.
As reported here https://bugs.llvm.org/show_bug.cgi?id=34988
[[nodiscard]] warnings were not being suppressed for
volatile-ref return values.
https://reviews.llvm.org/D39075
Files:
lib/AST/Expr.cpp
test/CXX/dcl.dcl/dcl.attr/dcl.attr.nodiscard/p2.cpp
Inde
bsdjhb created this revision.
Herald added subscribers: JDevlieghere, arichardson, aprantl.
N32 uses the same register context as N64. However, N32 requires one
change to properly fetch addresses from registers stored in memory.
Since N32 is an ILP32 platform, getP() only fetches the first 32-bit
Author: d0k
Date: Wed Oct 18 14:43:42 2017
New Revision: 316127
URL: http://llvm.org/viewvc/llvm-project?rev=316127&view=rev
Log:
[Driver] Fix use after free in Hexagon toolchain code.
No functionality change intended.
Modified:
cfe/trunk/lib/Driver/ToolChains/Hexagon.cpp
Modified: cfe/trun
sgundapa created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D39071
Files:
lib/Driver/ToolChains/Hexagon.cpp
Index: lib/Driver/ToolChains/Hexagon.cpp
===
--- lib/Driver/ToolChains/Hexagon.cpp
+++ lib/Driver/Too
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG.
https://reviews.llvm.org/D39024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
yaxunl created this revision.
Builder save/restores insertion pointer when emitting addr space cast
for alloca, but does not save/restore debug loc, which causes verifier
failure for certain call instructions.
This patch fixes that.
https://reviews.llvm.org/D39069
Files:
lib/CodeGen/CGExpr.c
sammccall added a comment.
Hi Alex! I'm working on clangd, but am pretty new to the project, so forgive
some naive questions.
I'm a bit unclear at a high level what the new abstractions in this patch add,
in terms of wiring refactorings up to clangd and other tools.
My understanding is: we have
Author: marshall
Date: Wed Oct 18 13:40:57 2017
New Revision: 316125
URL: http://llvm.org/viewvc/llvm-project?rev=316125&view=rev
Log:
Fix a think-o in the design of the stable_XXX sort tests; only shows up for
test cases > 255 elements
Modified:
libcxx/trunk/fuzzing/fuzzing.cpp
Modified: l
arphaman added inline comments.
Comment at: include/clang/Tooling/StandaloneExecution.h:1
+//===--- Execution.h - Standalone clang action execution. -*- C++
---*-===//
+//
StandaloneExecution.h?
https://reviews.llvm.org/D34272
__
krasimir updated this revision to Diff 119518.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D39024
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format/UsingDeclarationsSorterTest.cpp
Index: unittests/Format/UsingDeclarationsSorterTest.cpp
===
timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
This should unblock PR24411.
https://reviews.llvm.org/D39066
Files:
libcxx/include/regex
libcxx/test/std/re/re.grammar/excessive_brace_count.pass.cpp
Index: libcxx/test/std/re/re.grammar/exc
alexfh added a comment.
Zachary, do you plan to commit this? I'd also suggest adding a regression test.
Thanks!
https://reviews.llvm.org/D38549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: arphaman
Date: Wed Oct 18 11:51:48 2017
New Revision: 316105
URL: http://llvm.org/viewvc/llvm-project?rev=316105&view=rev
Log:
[refactor] Add a doc comment to the test function in the selection
unittest.
As suggested by Haojian Wu!
Modified:
cfe/trunk/unittests/Tooling/ASTSelectionTe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316104: [refactor] selection: new CodeRangeASTSelection
represents a set of selected (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D38835?vs=119197&id=119514#toc
Repository:
Author: arphaman
Date: Wed Oct 18 11:48:58 2017
New Revision: 316104
URL: http://llvm.org/viewvc/llvm-project?rev=316104&view=rev
Log:
[refactor] selection: new CodeRangeASTSelection represents a set of selected
consecutive statements
This commit adds a CodeRangeASTSelection value to the refactor
Author: morehouse
Date: Wed Oct 18 11:38:04 2017
New Revision: 316103
URL: http://llvm.org/viewvc/llvm-project?rev=316103&view=rev
Log:
[clang-proto-fuzzer] Use ToT protobuf-mutator.
Modified:
cfe/trunk/cmake/modules/ProtobufMutator.cmake
Modified: cfe/trunk/cmake/modules/ProtobufMutator.cma
djasper added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:79
const SourceManager &SourceMgr, tooling::Replacements *Fixes) {
- SmallVector SortedUsingDeclarations(
- UsingDeclarations->begin(), UsingDeclarations->end());
- std::stable_sort(Sort
arphaman added inline comments.
Comment at: unittests/Tooling/ASTSelectionTest.cpp:688
+ Source, {2, 2}, None,
+ [](SourceRange SelectionRange, Optional Node) {
+EXPECT_TRUE(Node);
hokein wrote:
> arphaman wrote:
> > hokein wrote:
> > > I'm a bi
erichkeane created this revision.
A helper builtin to facilitate implementing the
std::has_unique_object_representations type trait.
Requested here: https://bugs.llvm.org/show_bug.cgi?id=34942
Also already exists in GCC and MSVC.
https://reviews.llvm.org/D39064
Files:
include/clang/AST/Type.
Thank you!
On Wed, Oct 18, 2017 at 7:38 AM, Aaron Ballman
wrote:
> Thanks for pointing the breakage out -- it should be fixed with r316075.
>
> ~Aaron
>
> On Wed, Oct 18, 2017 at 7:50 AM, Aaron Ballman
> wrote:
> > I'll take a look, thank you for pointing it out (and sorry for the
> trouble)!
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316102: [Hexagon] Handling of new HVX flags and
target-features (authored by sgundapa).
Changed prior to commit:
https://reviews.llvm.org/D38852?vs=118802&id=119507#toc
Repository:
rL LLVM
https://r
Author: sgundapa
Date: Wed Oct 18 11:10:13 2017
New Revision: 316102
URL: http://llvm.org/viewvc/llvm-project?rev=316102&view=rev
Log:
[Hexagon] Handling of new HVX flags and target-features
This patch has the following changes
A new flag "-mhvx-length={64B|128B}" is introduced to specify the len
erichkeane added a comment.
@rsmith and @rnk just a quick bump! I'd like to get your thoughts on the SEMA
changes here.
Thanks!
-Erich
https://reviews.llvm.org/D38596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
ioeric updated this revision to Diff 119502.
ioeric added a comment.
- Move unique_ptr result.
https://reviews.llvm.org/D39042
Files:
include/clang/Tooling/CommonOptionsParser.h
lib/Tooling/CommonOptionsParser.cpp
Index: lib/Tooling/CommonOptionsParser.cpp
=
GorNishanov added a comment.
@rsmith , here is a fix for the funny diagnostics you mentioned.
https://reviews.llvm.org/D37115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello Douglas,
Sure, I'm on it. Thanks for reporting and sorry for the troubles.
On 18/10/17 20:24, Yung, Douglas wrote:
Hi Ivan,
This change caused a compiler crash in one of our tests. I have put the details
in PR34992, can you take a look?
Douglas Yung
-Original Message-
From:
george.burgess.iv updated this revision to Diff 119499.
george.burgess.iv marked 2 inline comments as done.
george.burgess.iv added a comment.
Addressed feedback. Thanks!
After looking around and internalizing a little bit of how backends in LLVM
work, the path forward I have in mind is to basic
george.burgess.iv added a comment.
> However, the tests cover floating point, but they don't cover vector calls
> (arm_neon.h).
`#include ` gives me ~12,000 errors, presumably because there are
so many functions that take vectors/floats defined in it. The hope was that
calling `bar` and `foo`
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Hi Ivan,
This change caused a compiler crash in one of our tests. I have put the details
in PR34992, can you take a look?
Douglas Yung
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Ivan A. Kosarev via cfe-commits
> Sent: Tuesday, Oct
Author: aaronballman
Date: Wed Oct 18 09:59:27 2017
New Revision: 316096
URL: http://llvm.org/viewvc/llvm-project?rev=316096&view=rev
Log:
Enable support for the [[maybe_unused]] attribute from WG14 N2053 when enabling
double square bracket attributes in C code.
Added:
cfe/trunk/test/Sema/c2
mclow.lists closed this revision.
mclow.lists added a comment.
Landed as revision 316095.
https://reviews.llvm.org/D37955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Wed Oct 18 09:49:22 2017
New Revision: 316095
URL: http://llvm.org/viewvc/llvm-project?rev=316095&view=rev
Log:
Fix regex bug with ^\W. Thanks to Tim Shen for the patch. Reviewed as
https://reviews.llvm.org/D37955
Added:
libcxx/trunk/test/std/re/re.alg/re.alg.search/i
Author: jonastoth
Date: Wed Oct 18 09:40:19 2017
New Revision: 316094
URL: http://llvm.org/viewvc/llvm-project?rev=316094&view=rev
Log:
[clang-tidy] Fix 32bit platform MSVC
The previous fix only worked for 64bit MSVC, this one should fix all different
architectures.
Modified:
clang-tools-ex
Author: jonastoth
Date: Wed Oct 18 09:28:06 2017
New Revision: 316093
URL: http://llvm.org/viewvc/llvm-project?rev=316093&view=rev
Log:
[clang-tidy] Fix buildbot for msvc
The testcase defined `FILE` as `unsigned long`, but MSVC expect `unsigned long
long`.
Modified:
clang-tools-extra/trunk
Carrot added a comment.
ping
https://reviews.llvm.org/D38820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jonastoth
Date: Wed Oct 18 09:14:15 2017
New Revision: 316092
URL: http://llvm.org/viewvc/llvm-project?rev=316092&view=rev
Log:
[clang-tidy] introduce legacy resource functions to
'cppcoreguidelines-owning-memory'
Summary:
This patch introduces support for legacy C-style resource functio
Author: hokein
Date: Wed Oct 18 08:56:39 2017
New Revision: 316090
URL: http://llvm.org/viewvc/llvm-project?rev=316090&view=rev
Log:
Support Objective-C/C++ source files in check_clang_tidy.py
check_clang_tidy.py currently only handles C and C++ source files.
This extends the logic to also handl
jlebar added a comment.
> The first question that comes to mind is what is the link between data layout
> and name mangling conventions?
I pulled up http://llvm.org/doxygen/classllvm_1_1DataLayout.html and searched
for "mangling" -- presumably this is what they were referring to. We also
don'
gtbercea added a comment.
In https://reviews.llvm.org/D39005#900226, @jlebar wrote:
> > I'd be interested to get the ball rolling in regard to coming up with a fix
> > for this. I see some suggestions in past patches. Some help/clarification
> > would be much appreciated.
>
> Happy to help, but
sgundapa added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D38852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:58
+ /// Returns the editor command that's was bound to this rule.
+ virtual const EditorCommand *getEditorCommand() { return nullptr; }
};
arphaman wrote:
> io
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some minor nits, LGTM!
Comment at: test/SemaCXX/constant-expression-cxx11.cpp:1924
+
+
+ struct HasUnnamedBitfield {
Can remove the
Author: aaronballman
Date: Wed Oct 18 07:48:33 2017
New Revision: 316086
URL: http://llvm.org/viewvc/llvm-project?rev=316086&view=rev
Log:
Silencing a redefinition warning that was not germane to the test.
Modified:
cfe/trunk/test/Sema/c2x-fallthrough.c
Modified: cfe/trunk/test/Sema/c2x-fall
Thanks for pointing the breakage out -- it should be fixed with r316075.
~Aaron
On Wed, Oct 18, 2017 at 7:50 AM, Aaron Ballman wrote:
> I'll take a look, thank you for pointing it out (and sorry for the trouble)!
>
> ~Aaron
>
> On Tue, Oct 17, 2017 at 9:56 PM, Galina Kistanova
> wrote:
>> Hell
Author: aaronballman
Date: Wed Oct 18 07:33:27 2017
New Revision: 316083
URL: http://llvm.org/viewvc/llvm-project?rev=316083&view=rev
Log:
Enable support for the [[fallthrough]] attribute from WG14 N2052 when enabling
double square bracket attributes in C code.
Added:
cfe/trunk/test/Sema/c2x
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:58
+ /// Returns the editor command that's was bound to this rule.
+ virtual const EditorCommand *getEditorCommand() { return nullptr; }
};
ioeric wrote:
> I'
JonasToth added inline comments.
Comment at: docs/RefactoringActionTutorial.rst:90
+Let's call it something like ``FlattenIfStatements.cpp``. Don't forget to add
+it to the ``CMakeLists.txt`` file that's located in the
+``lib/Tooling/Refactoring`` directory.
Will
arphaman added a comment.
I think that the clangd editor plugin will have to be modified as well, but I
haven't looked into that yet.
Repository:
rL LLVM
https://reviews.llvm.org/D39057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
arphaman created this revision.
arphaman added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
This WIP patch provides a sample implementation of an integration of Clang's
refactoring actions from libToolingRefactor into clangd.
In terms of protocol support, the patch adds:
- S
arphaman created this revision.
Herald added subscribers: mgorny, klimek.
This patch adds an editor client that can do things like:
- find a list of available refactoring editor commands in a particular range.
- perform a particular refactoring editor command in a particular range.
This editor c
spetrovic created this revision.
Herald added subscribers: arichardson, sdardis.
This patch provides that bitfields are splitted even in case when current field
is not legal integer type. For Example,
struct S3 {
unsigned long a1:28;
unsigned long a2:4;
unsigned long a3:12;
};
struct S4
arphaman added a comment.
I think this patch should be split into a number of smaller patches to help the
review process.
Things like `tools/IndexStore`, `DirectoryWatcher` and other components that
are not directly needed right now should definitely be in their own patches.
It would be nice to
barancsuk added inline comments.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:510
+// E.g.: from (X == 5) && (X == 5) retrieves 5 and 5
+static void retrieveConstExprFromBothSides(const BinaryOperator *&BinOp,
+ BinaryOperator
barancsuk updated this revision to Diff 119452.
barancsuk marked 8 inline comments as done.
barancsuk added a comment.
Herald added a subscriber: whisperity.
Address review comments.
https://reviews.llvm.org/D38688
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tidy/misc/Redundan
hokein added a comment.
Awesome, thanks for the very well-illustrated tutorial!
Comment at: docs/RefactoringActionTutorial.rst:7
+
+ This tutorial talks about a work-in-progress library in Clang.
+ Some of the described features might not be available yet in trunk, but
shoul
danielmarjamaki created this revision.
Herald added a subscriber: szepet.
Example code:
void test3_simplified_offset(int x, unsigned long long y) {
int buf[100];
if (x < 0)
x = 0;
for (int i = y - x; i > 0 && i < 100; i++)
buf[i] = 0; // no-warning
}
Without this patc
ioeric added a comment.
Code looks good in general. I see there are a bunch of major features missing;
it might make sense to print a warning or document the major missing features
in the high-level API.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRuleRequ
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D39048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good from my side. You might want @klimek to take a look before
committing.
Comment at: include/clang/Tooling/CommonOptionsParser.h:90
- ///
- /// This constructor e
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D38922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
baloghadamsoftware created this revision.
When dumping SymIntExpr or IntSymExpr signed numbers are dumped as unsigned,
thus their two's complement is displayed. This small patch fixes this.
https://reviews.llvm.org/D39048
Files:
lib/StaticAnalyzer/Core/SymbolManager.cpp
test/Analysis/expr-
ioeric updated this revision to Diff 119465.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Address review comments.
https://reviews.llvm.org/D39042
Files:
include/clang/Tooling/CommonOptionsParser.h
lib/Tooling/CommonOptionsParser.cpp
Index: lib/Tooling/CommonOptionsPa
ioeric added inline comments.
Comment at: include/clang/Tooling/CommonOptionsParser.h:115
+
+ static llvm::Error init(int &argc, const char **argv,
+ llvm::cl::OptionCategory &Category,
hokein wrote:
> We can get rid of the `static` here
On Wed, Oct 18, 2017 at 12:00:51AM -, Saleem Abdulrasool via cfe-commits
wrote:
> Author: compnerd
> Date: Tue Oct 17 17:00:50 2017
> New Revision: 316046
>
> URL: http://llvm.org/viewvc/llvm-project?rev=316046&view=rev
> Log:
> Basic: fix __{,U}INTPTR_TYPE__ on ARM
>
> Darwin and OpenBSD ar
Author: aaronballman
Date: Wed Oct 18 05:11:58 2017
New Revision: 316075
URL: http://llvm.org/viewvc/llvm-project?rev=316075&view=rev
Log:
Silence -Wimplicit-fallthrough warnings with the generated code; NFC.
Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/trunk/utils/T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316074: [clang-rename] Rename alias. (authored by hokein).
Repository:
rL LLVM
https://reviews.llvm.org/D39043
Files:
cfe/trunk/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp
cfe/trunk/unittests/R
Author: hokein
Date: Wed Oct 18 05:10:11 2017
New Revision: 316074
URL: http://llvm.org/viewvc/llvm-project?rev=316074&view=rev
Log:
[clang-rename] Rename alias.
Summary:
* Support rename alias.
* Add unittests for renaming alias.
* Don't generate fixes for the SourceLocations that are invalid or
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D39043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
hokein added inline comments.
Comment at: include/clang/Tooling/CommonOptionsParser.h:95
+ static llvm::Expected>
+ create(int &argc, const char **argv, llvm::cl::OptionCategory &Category,
worth some documentation?
Comment at: include/clang
I'll take a look, thank you for pointing it out (and sorry for the trouble)!
~Aaron
On Tue, Oct 17, 2017 at 9:56 PM, Galina Kistanova wrote:
> Hello Aaron,
>
> This commit broke one our builders:
>
> http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/2272
>
> . . .
> FAILED: /usr/loca
xazax.hun updated this revision to Diff 119458.
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
- Update the scan-build part to work correctly with the accepted version of
libCrossTU
https://reviews.llvm.org/D30691
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptio
hokein created this revision.
Herald added subscribers: mgorny, klimek.
- Support rename alias.
- Add unittests for renaming alias.
- Don't generate fixes for the SourceLocations that are invalid or in temporary
buffer, otherwise crash would be happened when generating AtomicChanges.
https://re
ioeric added inline comments.
Comment at: include/clang/Tooling/CommonOptionsParser.h:90
///
- /// This constructor exits program in case of error.
+ /// If \p ExitOnError is set (default), This constructor exits program in
case
+ /// of error; otherwise, this sets the err
ioeric updated this revision to Diff 119449.
ioeric marked 7 inline comments as done.
ioeric added a comment.
- Address review comments.
https://reviews.llvm.org/D34272
Files:
include/clang/Tooling/CommonOptionsParser.h
include/clang/Tooling/Execution.h
include/clang/Tooling/StandaloneExe
chapuni added a comment.
@krasimir, I concluded it is trivial and committed it with the URL to close
this.
Feel free to revert if you had any matters.
Repository:
rL LLVM
https://reviews.llvm.org/D35541
___
cfe-commits mailing list
cfe-commits@l
ioeric updated this revision to Diff 119447.
ioeric added a comment.
- Add a factory method for creating CommonOptionsParser.
- Minor cleanup in CommonOptionsParser.
- Revert CommonOptionsParser changes.
- Merge branch 'option' into arcpatch-D34272
https://reviews.llvm.org/D34272
Files:
inclu
ioeric created this revision.
This returns error instead of exiting the program in case of error.
https://reviews.llvm.org/D39042
Files:
include/clang/Tooling/CommonOptionsParser.h
lib/Tooling/CommonOptionsParser.cpp
Index: lib/Tooling/CommonOptionsParser.cpp
==
Author: xazax
Date: Wed Oct 18 02:25:18 2017
New Revision: 316069
URL: http://llvm.org/viewvc/llvm-project?rev=316069&view=rev
Log:
[ASTImporter] Import SubStmt of CaseStmt
Patch by: Rafael Stahl!
Differential Revision: https://reviews.llvm.org/D38943
Modified:
cfe/trunk/lib/AST/ASTImporter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316069: [ASTImporter] Import SubStmt of CaseStmt (authored
by xazax).
Changed prior to commit:
https://reviews.llvm.org/D38943?vs=119162&id=119444#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
JonasToth updated this revision to Diff 119440.
JonasToth marked an inline comment as done.
JonasToth added a comment.
- address review comments
https://reviews.llvm.org/D37808
Files:
clang-tidy/hicpp/CMakeLists.txt
clang-tidy/hicpp/HICPPTidyModule.cpp
clang-tidy/hicpp/MultiwayPathsCovere
JonasToth marked 4 inline comments as done.
JonasToth added inline comments.
Comment at: clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp:98
+ // hold.
+ const std::size_t BitCount = [&T, &Context]() {
+if (T->isIntegralType(Context))
JDevlieghere wrote:
> Un
Author: hokein
Date: Wed Oct 18 00:48:40 2017
New Revision: 316066
URL: http://llvm.org/viewvc/llvm-project?rev=316066&view=rev
Log:
New -assume-filename=param to check_clang_tidy.py (like clang-format)
Summary:
Currently, check_clang_tidy.py includes logic to select default
clang flags based on
96 matches
Mail list logo
