hfinkel added a comment.
In https://reviews.llvm.org/D37624#885295, @choikwa wrote:
> In https://reviews.llvm.org/D37624#885290, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D37624#885288, @choikwa wrote:
> >
> > > - add comment to CPP test to explain usage
> >
> >
> > Thanks. Please also ad
choikwa added a comment.
In https://reviews.llvm.org/D37624#885290, @hfinkel wrote:
> In https://reviews.llvm.org/D37624#885288, @choikwa wrote:
>
> > - add comment to CPP test to explain usage
>
>
> Thanks. Please also add some tests showing matching overloaded functions,
> functions with templ
majnemer added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:455
+for (const auto &FileMatch : PathSearch) {
+ if(FunctionDeclPath.find(FileMatch) != std::string::npos) {
+return false;
Space after if.
Comment at
choikwa updated this revision to Diff 117269.
choikwa added a comment.
- add more CPP tests: func overload, template special
https://reviews.llvm.org/D37624
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/Code
hfinkel added a comment.
In https://reviews.llvm.org/D37624#885288, @choikwa wrote:
> - add comment to CPP test to explain usage
Thanks. Please also add some tests showing matching overloaded functions,
functions with template parameters, etc.
Do we need to strip whitespace before trying to m
choikwa updated this revision to Diff 117268.
choikwa added a comment.
- add comment to CPP test to explain usage
https://reviews.llvm.org/D37624
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CodeGenFunction
hfinkel added inline comments.
Comment at: test/CodeGenCXX/instrument-functions.cpp:8
+// RUN: %clang -S -emit-llvm -o - %s -finstrument-functions
-finstrument-functions-exclude-function-list=test3 | FileCheck %s
--check-prefix=NOFUNC
+// RUN: %clang -S -emit-llvm -o - %s -fins
choikwa updated this revision to Diff 117267.
choikwa added a comment.
- - Address formating feedback, remove redundant inline
https://reviews.llvm.org/D37624
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/Co
majnemer added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:463
+
+ // Skip demangling if decl is extern "C"
+ if (ActualFuncDecl && !ActualFuncDecl->isExternC()) {
Is this comment still correct?
Comment at: lib/CodeGen/CodeGe
Author: caseycarter
Date: Sat Sep 30 16:15:22 2017
New Revision: 314608
URL: http://llvm.org/viewvc/llvm-project?rev=314608&view=rev
Log:
[test] Allow other implementations to strengthen noexcept on deque's move
constructor
Modified:
libcxx/trunk/test/std/containers/sequences/deque/deque.co
Author: davide
Date: Sat Sep 30 14:49:15 2017
New Revision: 314605
URL: http://llvm.org/viewvc/llvm-project?rev=314605&view=rev
Log:
[Analysis] Remove unused makeLvalueToRValue variant.
Modified:
cfe/trunk/lib/Analysis/BodyFarm.cpp
Modified: cfe/trunk/lib/Analysis/BodyFarm.cpp
URL:
http://l
choikwa updated this revision to Diff 117264.
choikwa added a comment.
Addressing Hal's feedback
https://reviews.llvm.org/D37624
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGe
rwols added inline comments.
Comment at: clangd/Protocol.h:458
+///
+/// A parameter can have a label and a doc-comment.
+struct ParameterInformation {
@malaperle I copied the sentences from the protocol markdown file over
[here](https://github.com/Microsoft/lan
rwols marked 2 inline comments as done.
rwols added a comment.
I see now I have accidentally removed that new sortText logic during the merge
from upstream, let me fix that.
https://reviews.llvm.org/D38048
___
cfe-commits mailing list
cfe-commits@l
Author: faisalv
Date: Sat Sep 30 12:34:27 2017
New Revision: 314600
URL: http://llvm.org/viewvc/llvm-project?rev=314600&view=rev
Log:
[NFC] Add assertion that we assume a valid macro argument index.
Modified:
cfe/trunk/lib/Lex/MacroArgs.cpp
Modified: cfe/trunk/lib/Lex/MacroArgs.cpp
URL:
htt
rwols marked 4 inline comments as done.
rwols added a comment.
There were some failing tests, probably because we use an extra digit for the
`sortText` property now. I haven't touched those tests.
Comment at: clangd/ClangdUnit.cpp:610
+ParameterInformation Info;
+
rwols updated this revision to Diff 117261.
rwols added a comment.
- Updated to latest upstream revision.
- Fix optional/default parameter handling: each default parameter now has its
own label (thanks, ilya!).
- Remove the templated "invokeClangAction" function and use polymorphism with
CodeCom
Author: faisalv
Date: Sat Sep 30 07:36:00 2017
New Revision: 314595
URL: http://llvm.org/viewvc/llvm-project?rev=314595&view=rev
Log:
[NFC] Sync function call with changes to interface made in r314593.
Modified:
clang-tools-extra/trunk/modularize/PreprocessorTracker.cpp
Modified: clang-tools
Author: faisalv
Date: Sat Sep 30 06:58:38 2017
New Revision: 314593
URL: http://llvm.org/viewvc/llvm-project?rev=314593&view=rev
Log:
[NFC] Remove superfluous parameter
- MacroArgs already knows the maximum number of arguments that can be supplied
to the macro. No need to pass MacroInfo (infor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314587: [clangd] simplify ClangdLSPServer by
private-inheriting callback interfaces. NFC (authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D38414
Files:
clang-tools-extra/trunk/c
Author: sammccall
Date: Sat Sep 30 03:08:52 2017
New Revision: 314587
URL: http://llvm.org/viewvc/llvm-project?rev=314587&view=rev
Log:
[clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC
Summary:
There doesn't seem to be any real separation between the current three
sammccall updated this revision to Diff 117256.
sammccall added a comment.
- Address review comments
https://reviews.llvm.org/D38414
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
Index: clangd/ClangdLSPServer.h
==
chapuni added a comment.
Appeased in https://reviews.llvm.org/rL314586. I don't think my tweak would be
right, though.
See;
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/6726
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/5135
Author: chapuni
Date: Sat Sep 30 02:16:41 2017
New Revision: 314586
URL: http://llvm.org/viewvc/llvm-project?rev=314586&view=rev
Log:
clang/test/SemaCXX/ms-iunknown-template-function.cpp: Appease for targeting
*-win32.
This expects the warning;
File clang/test/SemaCXX/ms-iunknown-template-fun
mgorny created this revision.
Herald added a subscriber: dberris.
Make it possible to control building profile runtime separately from
other options. Before r313549, the profile runtime building was
controlled along with sanitizers. However, since that commit it is built
unconditionally which resu
25 matches
Mail list logo
