Author: sbc
Date: Thu Sep 14 14:29:25 2017
New Revision: 313299
URL: http://llvm.org/viewvc/llvm-project?rev=313299&view=rev
Log:
[WebAssembly] Remove invliad lld arguments
These arguments don't (not yet at least) make sense for
the wasm lld port.
Subscribers: jfb, dschuff, jgravelle-google, ahe
Author: sbc
Date: Thu Sep 14 15:36:44 2017
New Revision: 313307
URL: http://llvm.org/viewvc/llvm-project?rev=313307&view=rev
Log:
[WebAssembly] Fix wasm-toolchain.c tests
Summary: This test should have been updated in r313299
Subscribers: jfb, dschuff, jgravelle-google, aheejin
Differential Rev
compnerd created this revision.
compnerd added a project: clang.
Herald added subscribers: fedor.sergeev, javed.absar.
Move the logic for determining the `wchar_t` type information into the
driver. Rather than passing the single bit of information of
`-fshort-wchar` indicate to the frontend the d
Author: smeenai
Date: Thu Sep 14 23:19:31 2017
New Revision: 313345
URL: http://llvm.org/viewvc/llvm-project?rev=313345&view=rev
Log:
[libc++] Remove unnecessary struct tag
It causes warnings about mismatched tags, and it's not needed.
Modified:
libcxx/trunk/include/typeinfo
Modified: libcx
compnerd closed this revision.
compnerd added a comment.
SVN r313344
https://reviews.llvm.org/D28212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Thu Sep 14 22:42:39 2017
New Revision: 313344
URL: http://llvm.org/viewvc/llvm-project?rev=313344&view=rev
Log:
typeinfo: provide a partial implementation for Win32
The RTTI structure is different on Windows when building under MS ABI.
Update the definition to reflect this.
compnerd marked 4 inline comments as done.
compnerd added a comment.
Also added `_NOEXCEPT` to `__compare`.
https://reviews.llvm.org/D28212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
smeenai added inline comments.
Comment at: include/typeinfo:100
+int __compare(const struct type_info &__rhs);
+#endif // _LIBCPP_ABI_MICROSOFT
+
Drop the `struct`; it causes compilation errors.
This needs to be marked `const`.
Comment at:
Author: zturner
Date: Thu Sep 14 19:56:40 2017
New Revision: 313335
URL: http://llvm.org/viewvc/llvm-project?rev=313335&view=rev
Log:
Revert "[lit] Force site configs to run before source-tree configs"
This patch is still breaking several multi-stage compiler-rt bots.
I already know what the fix
Author: zturner
Date: Thu Sep 14 19:56:40 2017
New Revision: 313335
URL: http://llvm.org/viewvc/llvm-project?rev=313335&view=rev
Log:
Revert "[lit] Force site configs to run before source-tree configs"
This patch is still breaking several multi-stage compiler-rt bots.
I already know what the fix
EricWF updated this revision to Diff 115349.
EricWF added a comment.
- Improve test.
https://reviews.llvm.org/D37035
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/Stmt.h
include/clang
EricWF updated this revision to Diff 115342.
EricWF marked 8 inline comments as done.
EricWF added a comment.
- Cleanup and address the inline comments I added earlier.
https://reviews.llvm.org/D37035
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
rsmith added a comment.
dlj and I discussed this offline somewhat, and dlj made the interesting point
that using ADL *at all* within the implementation of the standard library
brings with it the risk that your implementation will not function correctly if
a user-declared operator could be at le
vsapsai added a comment.
I don't like name `SavePendingDelayedStateRAII` as too vague. Hope you'll be
able to suggest something better or I'll have better ideas later.
https://reviews.llvm.org/D37881
___
cfe-commits mailing list
cfe-commits@lists.l
vsapsai created this revision.
Sema::InstantiateClass should check only exception specs added during
class instantiation and ignore already present delayed specs. This fixes
a case where we instantiate a class before parsing member initializers,
check exceptions for a different class and fail to f
vsapsai marked an inline comment as done.
vsapsai added inline comments.
Comment at: clang/test/Sema/enum.c:128
+// PR28903
+struct PR28903 { // expected-warning {{empty struct is a GNU extension}}
+ enum {
rnk wrote:
> This is a simpler test case that fixes the
vsapsai updated this revision to Diff 115333.
vsapsai added a comment.
- Remove extraneous diagnostics in test case per Reid Kleckner feedback.
https://reviews.llvm.org/D37089
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaDecl.cpp
clang/test/Sema/enum.c
clan
dlj added a comment.
In https://reviews.llvm.org/D37538#871515, @EricWF wrote:
> @dlj I went ahead and committed the fixes to `std::allocator_traits` in
> r313324, because I think we agree those are bugs, and I didn't want this
> discussion to hold up that fix. I hope you don't mind.
Nope, no
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D37308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@dlj I went ahead and committed the fixes to `std::allocator_traits` in
r313324, because I think we agree those are bugs, and I didn't want this
discussion to hold up that fix. I hope you don't mind.
https://reviews.llvm.org/D37538
___
Author: ericwf
Date: Thu Sep 14 17:31:38 2017
New Revision: 313324
URL: http://llvm.org/viewvc/llvm-project?rev=313324&view=rev
Log:
Fix accidental ADL in std::allocator_traits meta-programming.
There were a number of cases where __double_underscore functions,
for example __has_construct_test, we
compnerd updated this revision to Diff 115326.
https://reviews.llvm.org/D28212
Files:
include/typeinfo
src/support/runtime/exception_msvc.ipp
src/typeinfo.cpp
Index: src/typeinfo.cpp
===
--- src/typeinfo.cpp
+++ src/typeinfo.c
compnerd commandeered this revision.
compnerd edited reviewers, added: smeenai; removed: compnerd.
compnerd added inline comments.
Comment at: include/typeinfo:100
+
+ static const char *__name(const struct type_info::__data *__data);
+ static size_t __hash(const struct type_in
vsapsai added a comment.
Thanks for the review.
Repository:
rL LLVM
https://reviews.llvm.org/D37322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313323: [Sema] Correct typos in LHS, RHS before building a
binop expression. (authored by vsapsai).
Changed prior to commit:
https://reviews.llvm.org/D37322?vs=113348&id=115323#toc
Repository:
rL LLV
Author: vsapsai
Date: Thu Sep 14 17:08:37 2017
New Revision: 313323
URL: http://llvm.org/viewvc/llvm-project?rev=313323&view=rev
Log:
[Sema] Correct typos in LHS, RHS before building a binop expression.
Specifically, typo correction should be done before dispatching between
different kinds of bin
EricWF added inline comments.
Comment at: include/deque:1167-1168
allocator_type& __a = __alloc();
-for (iterator __i = begin(), __e = end(); __i != __e; ++__i)
-__alloc_traits::destroy(__a, _VSTD::addressof(*__i));
+for (iterator __i = begin(), __e = end();
Author: dgregor
Date: Thu Sep 14 16:58:18 2017
New Revision: 313320
URL: http://llvm.org/viewvc/llvm-project?rev=313320&view=rev
Log:
Fix reStructuredText warning.
Modified:
cfe/trunk/docs/Modules.rst
Modified: cfe/trunk/docs/Modules.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/do
Author: morehouse
Date: Thu Sep 14 16:53:56 2017
New Revision: 313319
URL: http://llvm.org/viewvc/llvm-project?rev=313319&view=rev
Log:
[MSan] Specify use-after-dtor default value in header.
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp
URL
smeenai added a comment.
Filed https://bugs.llvm.org/show_bug.cgi?id=34614 about the silent attribute
ignoring.
https://reviews.llvm.org/D35388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: dgregor
Date: Thu Sep 14 16:40:51 2017
New Revision: 313318
URL: http://llvm.org/viewvc/llvm-project?rev=313318&view=rev
Log:
Minor cleanups to address feedback from Bruno. NFC
Modified:
cfe/trunk/docs/Modules.rst
cfe/trunk/lib/Serialization/ASTWriter.cpp
Modified: cfe/trunk/docs
Author: dgregor
Date: Thu Sep 14 16:38:42 2017
New Revision: 313315
URL: http://llvm.org/viewvc/llvm-project?rev=313315&view=rev
Log:
Diagnostic specific failed condition in a static_assert.
When a static_assert fails, dig out a specific condition to diagnose,
using the same logic that we use to
Author: dgregor
Date: Thu Sep 14 16:38:44 2017
New Revision: 313317
URL: http://llvm.org/viewvc/llvm-project?rev=313317&view=rev
Log:
Add /System/Library/PrivateFrameworks as a header search path.
Addresses rdar://problem/34438708.
Modified:
cfe/trunk/lib/Frontend/InitHeaderSearch.cpp
Modif
Author: dgregor
Date: Thu Sep 14 16:38:44 2017
New Revision: 313316
URL: http://llvm.org/viewvc/llvm-project?rev=313316&view=rev
Log:
[Module map] Introduce a private module re-export directive.
Introduce a new "export_as" directive for top-level modules, which
indicates that the current module i
smeenai added a comment.
Good point. It looks like clang actually ignores the attributes in that case as
well; it just doesn't warn you about it :D
Take a look at https://godbolt.org/g/CJTD6c to see what I mean. Note the
`.hidden c::f()` in both the gcc and clang outputs.
https://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313314: [MSan] Add flag to disable use-after-dtor. (authored
by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D37867?vs=115295&id=115317#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: morehouse
Date: Thu Sep 14 16:14:37 2017
New Revision: 313314
URL: http://llvm.org/viewvc/llvm-project?rev=313314&view=rev
Log:
[MSan] Add flag to disable use-after-dtor.
Summary: Flag is -fno-sanitize-use-after-dtor.
Reviewers: vitalybuka, eugenis, kcc
Reviewed By: vitalybuka, eugenis
morehouse added a comment.
In https://reviews.llvm.org/D37860#871368, @eugenis wrote:
> Looking at __sanitizer_dtor_callback implementation, this change will add a
> (fast) stack unwind in every destructor. In extreme cases (like a tight loop
> doing string operations) it could be bad for perfo
morehouse updated this revision to Diff 115312.
morehouse edited the summary of this revision.
morehouse added a comment.
- Move the new flag to https://reviews.llvm.org/D37867
- Address Vitaly's comments.
https://reviews.llvm.org/D37860
Files:
clang/lib/Driver/SanitizerArgs.cpp
clang/test/
ahatanak updated this revision to Diff 115304.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index: test/Sema/fp16vec-sema.c
===
eugenis added a comment.
Looking at __sanitizer_dtor_callback implementation, this change will add a
(fast) stack unwind in every destructor. In extreme cases (like a tight loop
doing string operations) it could be bad for performance. I've seen ~15% AFAIR.
https://reviews.llvm.org/D37860
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313307: [WebAssembly] Fix wasm-toolchain.c tests (authored
by sbc).
Repository:
rL LLVM
https://reviews.llvm.org/D37873
Files:
cfe/trunk/test/Driver/wasm-toolchain.c
Index: cfe/trunk/test/Driver/w
pirama added a comment.
@bruno Any suggestion on how to update test/Headers/float-darwin,c* so make it
check the include_next? I am unable to find the darwin-specific float.h inside
an XCode installation directory.
- Oops, my earlier comment had the wrong test name
https://reviews.llvm.org/D
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/SanitizerArgs.cpp:494
+ options::OPT_fno_sanitize_memory_use_after_dtor,
+ false);
NeedP
eugenis accepted this revision.
eugenis added a comment.
Oh right, I was looking at https://reviews.llvm.org/D37860.
https://reviews.llvm.org/D37867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
vitalybuka added a comment.
In https://reviews.llvm.org/D37867#871353, @eugenis wrote:
> Have you looked at performance?
Not the answer to your question, but this patch just adds negative flag without
changing defaults.
https://reviews.llvm.org/D37867
_
Author: ericwf
Date: Thu Sep 14 15:37:34 2017
New Revision: 313308
URL: http://llvm.org/viewvc/llvm-project?rev=313308&view=rev
Log:
Fix ASAN build with older compiler-rt versions.
compiler-rt recently added the __asan_handle_no_return() function that libc++abi
needs to use, however older version
eugenis added a comment.
Have you looked at performance?
https://reviews.llvm.org/D37867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
In https://reviews.llvm.org/D37871#871325, @eugenis wrote:
> This function was added to the header recently, but it has been provided by
> ASan runtime library since the beginning. Why not simply declare it in
> libc++abi?
I didn't know that. I'll come up with a separa
eugenis added a comment.
This function was added to the header recently, but it has been provided by
ASan runtime library since the beginning. Why not simply declare it in
libc++abi?
https://reviews.llvm.org/D37871
___
cfe-commits mailing list
cfe
Author: ericwf
Date: Thu Sep 14 15:19:28 2017
New Revision: 313304
URL: http://llvm.org/viewvc/llvm-project?rev=313304&view=rev
Log:
[libc++abi] Fix ASAN build with older compiler-rt versions.
Summary:
compiler-rt recently added the `__asan_handle_no_return()` function that
libc++abi needs to us
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D37872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Looks good to me; sorry for the delay.
https://reviews.llvm.org/D37089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
mclow.lists added a comment.
This looks fine to me (along with https://reviews.llvm.org/D37872)
https://reviews.llvm.org/D37871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF created this revision.
Herald added a subscriber: dberris.
compiler-rt recently added the `__asan_handle_no_return()` function that
libc++abi needs to use, however older versions of compiler-rt don't provide
this interface and that breaks the libc++abi build.
This patch attempts to fix t
EricWF created this revision.
Libc++abi attempts to use the newly added `__asan_handle_no_return()` when
built under ASAN. Unfortunately older versions of compiler-rt do not provide
this symbol, and so libc++abi needs a way to detect if `asan_interface.h`
actually provides the function.
This p
morehouse updated this revision to Diff 115295.
morehouse added a comment.
- Use hasFlag() in CompilerInvocation.cpp as well.
https://reviews.llvm.org/D37867
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/SanitizerArgs.cpp
clang/lib/Frontend/CompilerInvocation.cpp
clang/t
Author: zturner
Date: Thu Sep 14 14:30:27 2017
New Revision: 313300
URL: http://llvm.org/viewvc/llvm-project?rev=313300&view=rev
Log:
Fix 2 stage build on some apple bots.
The recent lit refactor changed the location of the lit script
run by check targets from /utils/lit/lit.py to
/llvm-lit.py.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313299: [WebAssembly] Remove invliad lld arguments (authored
by sbc).
Repository:
rL LLVM
https://reviews.llvm.org/D36595
Files:
cfe/trunk/lib/Driver/ToolChains/WebAssembly.cpp
Index: cfe/trunk/li
morehouse created this revision.
Flag is -fno-sanitize-use-after-dtor.
https://reviews.llvm.org/D37867
Files:
clang/include/clang/Driver/Options.td
clang/lib/Driver/SanitizerArgs.cpp
clang/lib/Frontend/CompilerInvocation.cpp
clang/test/Driver/fsanitize.c
Index: clang/test/Driver/fsani
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Woops. didn't mean to reject.
https://reviews.llvm.org/D28212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
- List Item
In https://reviews.llvm.org/D28212#871034, @smeenai wrote:
> @compnerd, @EricWF and I discussed this a bit on IRC yesterday.
>
> In this particular case, however, I don
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
I see. It looks like there is an ambiguity between 'new_anotation' and
'new_annotations' that can't be resolved in ActOnMemberAccessExpr because they
have the same distance from 'new_annot
aaron.ballman updated this revision to Diff 115279.
aaron.ballman added a comment.
Updated based on review feedback.
- Rename CAttributes to DoubleSquareBracketAttributes
- Added Objective-C test cases to demonstrate no regressed behavior (based on a
use-case pointed out during review)
- Fixed r
erichkeane created this revision.
The two examples in the test would both cause a compiler assert when attempting
to calculate
the exception specifier for the default constructor for the template classes.
The problem was
that dependents of this function expect that Field->getInClassInitializer
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D36471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D30295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka added inline comments.
Comment at: compiler-rt/test/msan/use-after-dtor.cc:13
#include
#include
morehouse wrote:
> vitalybuka wrote:
> > Probably we need one test which check that we stop detecting bugs with
> > -fno-sanitize-memory-track-origin
morehouse added inline comments.
Comment at: clang/include/clang/Driver/Options.td:854
HelpText<"Enable use-after-destroy
detection in MemorySanitizer">;
+def fno_sanitize_memory_use_after_dtor : Flag<["-"],
"fno-sanitize-memory-use-after-d
vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/Driver/fsanitize.c:175
-// RUN: %clang -target x86_64-linux-gnu -fsanitize=memory
-fsanitize-memory-use-after-dtor -pie %s -##
vitalybuka added inline comments.
Comment at: clang/include/clang/Driver/Options.td:854
HelpText<"Enable use-after-destroy
detection in MemorySanitizer">;
+def fno_sanitize_memory_use_after_dtor : Flag<["-"],
"fno-sanitize-memory-use-after-
erichkeane updated this revision to Diff 115272.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Fixed for @rnk s comments.
https://reviews.llvm.org/D37308
Files:
include/clang/AST/DeclCXX.h
lib/AST/DeclCXX.cpp
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/ms-iunknown-i
smeenai added a comment.
@compnerd, @EricWF and I discussed this a bit on IRC yesterday.
My motivation here is that I'm using libc++ with other headers that clash badly
with the vcruntime headers, which prevents me from using libc++'s
`_LIBCPP_ABI_MICROSOFT` support. Reducing libc++'s dependenc
Author: dyung
Date: Thu Sep 14 12:51:26 2017
New Revision: 313290
URL: http://llvm.org/viewvc/llvm-project?rev=313290&view=rev
Log:
Fix refactoring missed in previous commit r313270 which resulted in an
undefined variable being used.
Modified:
clang-tools-extra/trunk/test/Unit/lit.cfg
Modif
zibi created this revision.
Herald added subscribers: kbarton, nemanjai.
When #pragma clang assume_nonnull begin || end is present in the source it is
completely gone from pre-processed output when compiled with -E or -P. This
patch make sure the pragma is preserved. I included 1 test case which
erichkeane marked 4 inline comments as done.
erichkeane added a comment.
Thanks for the quick response! New patch coming soon.
Comment at: lib/AST/DeclCXX.cpp:1478
+
+ // No interface-like types can have a user declared constructor, destructor,
+ // friends, VBases, conersi
cameron314 added inline comments.
Comment at: include/clang/Lex/Lexer.h:52
+ /// a BOM is present at the start of the file.
+ unsigned StartOffset;
+ /// \brief Size of the preamble in bytes.
ilya-biryukov wrote:
> cameron314 wrote:
> > ilya-biryukov wrote:
>
andrew.w.kaylor updated this revision to Diff 115262.
andrew.w.kaylor added a comment.
-Changed GNU idiom from extension to warning.
-Updated to ToT.
https://reviews.llvm.org/D37042
Files:
include/clang/AST/Expr.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaK
morehouse created this revision.
Enable the compile-time flag -fsanitize-memory-use-after-dtor by
default. Note that the run-time option MSAN_OPTIONS=poison_in_dtor=1
still needs to be enabled for destructors to be poisoned.
https://reviews.llvm.org/D37860
Files:
clang/include/clang/Driver/Op
smeenai added a comment.
This depends on https://reviews.llvm.org/D37859 for the `SOURCE_DIR` parameter
to `llvm_check_source_file_list`.
https://reviews.llvm.org/D31363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
smeenai updated this revision to Diff 115259.
smeenai added a comment.
Herald added a subscriber: fedor.sergeev.
Address comments
https://reviews.llvm.org/D31363
Files:
benchmarks/CMakeLists.txt
lib/CMakeLists.txt
Index: lib/CMakeLists.txt
=
rnk added inline comments.
Comment at: lib/AST/DeclCXX.cpp:1474
+bool CXXRecordDecl::isInterfaceLike() const {
+ // All __interfaces are inheritently interface like.
+ if (isInterface())
nit: use "interface-like" for consistency with the comments below
==
smeenai added a comment.
@mclow.lists, any final verdict here? I ended up doing this differently for my
internal use case, so if you think this isn't generally useful, I'm happy to
abandon.
https://reviews.llvm.org/D36713
___
cfe-commits mailing l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313284: [libc++] Prevent stale site configuration headers
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D36720?vs=111096&id=115250#toc
Repository:
rL LLVM
https://reviews.
Author: smeenai
Date: Thu Sep 14 11:23:43 2017
New Revision: 313284
URL: http://llvm.org/viewvc/llvm-project?rev=313284&view=rev
Log:
[libc++] Prevent stale site configuration headers
If we define cmake macros that require a site config, and then undefine
all such macros, a stale site config head
smeenai added inline comments.
Comment at: CMakeLists.txt:633
+ if (EXISTS "${site_config_path}")
+file(REMOVE "${site_config_path}")
+ endif()
EricWF wrote:
> Maybe print a warning or a message here? While it seems useful to
> re-configure and remove the
arphaman created this revision.
This patch adds initial support for refactoring options. One can now use
optional and required `std::string` options.
The options are implemented in the following manner:
- A base interface `RefactoringOption` declares methods that describe the
option's name, de
frutiger created this revision.
Some API calls accept 'NULL' instead of a char array (e.g. the second
argument to 'clang_ParseTranslationUnit'). For Python 3 compatibility,
all strings are passed through 'c_interop_string' which expects to
receive only 'bytes' or 'str' objects. This change exten
frutiger added a comment.
@compnerd if nothing else remains here, I would also appreciate it if you could
merge this. Thanks!
https://reviews.llvm.org/D37573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
frutiger updated this revision to Diff 115246.
frutiger added a comment.
Rebased on top of the latest master.
https://reviews.llvm.org/D37573
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_linkage.py
Index: bindings/python/tests/cindex/test_linkage.py
===
The bot is unhappy:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7880/steps/build%20libcxx%2Fasan/logs/stdio
1/6] Building CXX object
projects/libcxxabi/src/CMakeFiles/cxxabi_objects.dir/cxa_exception.cpp.o
FAILED: projects/libcxxabi/src/CMakeFiles/cxxabi_objects.dir/cxa_ex
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:957
-return Builder.CreateBitCast(Addr, ConvertType(E->getType()));
+return Builder.CreatePointerBitCastOrAddrSpaceCast(
+Addr, ConvertType(E->getType()));
yaxunl wr
Prazek marked 3 inline comments as done.
Prazek added a comment.
Thanks for help. I checked and docs build and looks legit. Sorry that it took
so long.
Repository:
rL LLVM
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@
Author: prazek
Date: Thu Sep 14 10:33:08 2017
New Revision: 313278
URL: http://llvm.org/viewvc/llvm-project?rev=313278&view=rev
Log:
Enable __declspec(selectany) on any platform
Summary:
This feature was disabled probably by mistake in rL300562
This fixes bug https://bugs.llvm.org/show_bug.cgi?id
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313278: Enable __declspec(selectany) on any platform
(authored by Prazek).
Repository:
rL LLVM
https://reviews.llvm.org/D33852
Files:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/
Prazek updated this revision to Diff 115243.
Prazek marked 8 inline comments as done.
Prazek added a comment.
Fixed links
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index
Sorry, I have no particular insight. My commit was reapplied verbatim shortly
after that and the tests passed, so I’m not sure if there’s any relation.
> On Sep 13, 2017, at 4:16 AM, Tsafrir, Yael wrote:
>
> Hello Galina,
>
> I tried to re-create the issue but with no success. I ran the test
PriMee updated this revision to Diff 115240.
PriMee added a comment.
Thank you for noticing! Done.
https://reviews.llvm.org/D37845
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineFormatter.cpp
lib/Format/UnwrappedLine
Author: zturner
Date: Thu Sep 14 09:47:58 2017
New Revision: 313270
URL: http://llvm.org/viewvc/llvm-project?rev=313270&view=rev
Log:
[lit] Force site configs to be run before source-tree configs
This patch simplifies LLVM's lit infrastructure by enforcing an ordering
that a site config is always
1 - 100 of 137 matches
Mail list logo
