Hi Rafael,
could you write slightly more extensive commit messages? This really
doesn't say anything..
Thank you,
Daniel
On Fri, Sep 8, 2017 at 2:01 AM, Rafael Espindola via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rafael
> Date: Thu Sep 7 17:01:26 2017
> New Revision: 312766
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM. Do you have commit access?
https://reviews.llvm.org/D37599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
vsk updated this revision to Diff 114303.
vsk edited the summary of this revision.
vsk added a comment.
Address review feedback:
- Enable this change on all platforms.
- Bump the function signature version.
- Store the indirect RTTI pointer as an IntPtrTy. This saves a "ptrtoint"
instruction. Tr
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D37310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
wmi updated this revision to Diff 114300.
wmi added a comment.
Address John's comment.
Repository:
rL LLVM
https://reviews.llvm.org/D37310
Files:
lib/CodeGen/CGAtomic.cpp
test/CodeGenCXX/atomic-align.cpp
Index: test/CodeGenCXX/atomic-align.cpp
==
zturner added a comment.
@inglorion : Since we're already in this code anyway, should we at least do due
diligence and check the basics, even if only manually? As in, at least we
should check in MSVC if any of those other types of examples that I came up
with present a problem. Otherwise we'r
inglorion updated this revision to Diff 114299.
inglorion added a comment.
removed compound statement; that was only in there to double check that the
debugger stops on the first child statement, but that's true with or without
this change
https://reviews.llvm.org/D37529
Files:
clang/lib/Co
inglorion added a comment.
@zturner: I am still thinking about your comment about other cases to test. My
concern is that there are very many possible combinations.
I'm actually not too concerned about not exactly matching cl's behavior in
every single case. The difference in behavior here is u
Author: pcc
Date: Thu Sep 7 17:50:50 2017
New Revision: 312770
URL: http://llvm.org/viewvc/llvm-project?rev=312770&view=rev
Log:
COFF: Implement ThinLTO cache and cache pruning support.
Differential Revision: https://reviews.llvm.org/D37607
Modified:
cfe/trunk/docs/ThinLTO.rst
Modified: cf
Author: rafael
Date: Thu Sep 7 17:33:39 2017
New Revision: 312769
URL: http://llvm.org/viewvc/llvm-project?rev=312769&view=rev
Log:
Update for PrintHelpMessage not calling exit.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
clang-tools-extra/trunk/modularize/Modular
inglorion updated this revision to Diff 114292.
inglorion added a comment.
Following conversation with @rnk, I managed to whittle this down to a very
small change that seems to do what we need. Step into specific works and single
stepping through the program behaves similarly whether compiled wi
vsk added a comment.
Thanks for your comments!
Comment at: lib/CodeGen/CodeGenFunction.cpp:434
+llvm::Constant *Addr) {
+ if (!CGM.getTriple().isOSDarwin())
+return Addr;
pcc wrote:
> I think you can just do this
Author: rafael
Date: Thu Sep 7 17:01:26 2017
New Revision: 312766
URL: http://llvm.org/viewvc/llvm-project?rev=312766&view=rev
Log:
Update for llvm change.
Modified:
cfe/trunk/tools/clang-format/ClangFormat.cpp
cfe/trunk/tools/clang-offload-bundler/ClangOffloadBundler.cpp
Modified: cfe/
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me, thanks!
When you commit this, could you please double-check that the tests are still
running on the green dragon builders? I'll also keep an eye on them.
https:
probinson added a comment.
The new file goes in the debuginfo-tests directory. It's a separate project so
that's probably not obvious from the diff.
https://reviews.llvm.org/D37604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
probinson created this revision.
This requires the host triple to match the default target triple, in order to
run debuginfo-tests.
It's possible this is too restrictive, but offhand it seems like a reasonable
starting point.
https://reviews.llvm.org/D37604
Files:
lit.local.cfg
Index: lit
pcc added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:463
+ auto *PCRelAsInt =
+ Builder.CreatePtrToInt(EncodedAddr, IntPtrTy, "encoded_addr.int");
+ auto *FuncAsInt = Builder.CreatePtrToInt(F, IntPtrTy, "func_addr.int");
pcc wrote:
> Mayb
pcc added a comment.
Thanks. Once we apply this fix to other platforms this would seem to fix
PR17633.
We may also want to change the ubsan function signature in order to avoid bad
pointer reads in case of version mismatches.
Comment at: lib/CodeGen/CodeGenFunction.cpp:434
+
kzhuravl created this revision.
Herald added subscribers: ilya-biryukov, wdng.
Otherwise it breaks our internal windows builders:
StmtDataCollectors.inc: error C2220: warning treated as error - no 'object'
file generated
StmtDataCollectors.inc: warning C4335: Mac file format detected: please
vsk created this revision.
Depends on https://reviews.llvm.org/D37597
https://reviews.llvm.org/D37598
Files:
docs/UndefinedBehaviorSanitizer.rst
lib/Driver/ToolChains/Darwin.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
==
vsk created this revision.
This change will make it possible to use -fsanitize=function on Darwin and
possibly on other platforms. It fixes an issue with the way RTTI is stored into
function prologue data.
On Darwin, addresses stored in prologue data can't require run-time fixups and
must be PC-r
On 7 September 2017 at 13:36, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Richard,
>
> This commit broke one of our builders:
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensiv
> e-checks-win/builds/4705
>
> Failing Tests (1):
> Clang :: CXX/module
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312750: [Sema] -Wtautological-compare: handle comparison of
unsigned with 0S. (authored by lebedevri).
Changed prior to commit:
https://reviews.llvm.org/D37565?vs=114260&id=114265#toc
Repository:
rL
Author: lebedevri
Date: Thu Sep 7 15:14:25 2017
New Revision: 312750
URL: http://llvm.org/viewvc/llvm-project?rev=312750&view=rev
Log:
[Sema] -Wtautological-compare: handle comparison of unsigned with 0S.
Summary:
This is a first half(?) of a fix for the following bug:
https://bugs.llvm.org/show
Author: rsmith
Date: Thu Sep 7 15:07:52 2017
New Revision: 312749
URL: http://llvm.org/viewvc/llvm-project?rev=312749&view=rev
Log:
Add target triple to improve the happiness of MSVC buildbots.
Modified:
cfe/trunk/test/CXX/modules-ts/basic/basic.link/p3.cppm
Modified: cfe/trunk/test/CXX/mod
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: docs/ReleaseNotes.rst:79
+- ``-Wtautological-compare`` now warns about comparison of signed integer and
+ ``0U`` constant when appropriate.
+
-
jroelofs closed this revision.
jroelofs added a comment.
r312748
https://reviews.llvm.org/D37496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jroelofs
Date: Thu Sep 7 15:01:25 2017
New Revision: 312748
URL: http://llvm.org/viewvc/llvm-project?rev=312748&view=rev
Log:
Fix validation of the -mthread-model flag in the Clang driver
The ToolChain class validates the -mthread-model flag in the constructor which
doesn't work correctl
lebedev.ri updated this revision to Diff 114260.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Address review notes.
Repository:
rL LLVM
https://reviews.llvm.org/D37565
Files:
docs/ReleaseNotes.rst
lib/Sema/SemaChecking.cpp
test/Sema/compare.c
test/Sema/out
frutiger updated this revision to Diff 114256.
frutiger added a comment.
Exports 'TLSKind' in the '__all__' array.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_tls_kind.py
include/clang-c/Index.h
tools/libclang/CIndex.cpp
too
frutiger updated this revision to Diff 114257.
frutiger added a comment.
Export 'LinkageKind' in '__all__'. Use consistent quotes in test drivers.
https://reviews.llvm.org/D37573
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_linkage.py
Index: bindings/python/te
rjmccall added a comment.
Great, thanks. Just a few tweaks.
Comment at: docs/ReleaseNotes.rst:76
+ ``0`` constant was adjusted to warn regardless of whether the constant is
+ signed or unsigned.
+
"now warns when comparing an unsigned integer and 0 regardles
lebedev.ri updated this revision to Diff 114249.
lebedev.ri marked 4 inline comments as done.
lebedev.ri added a comment.
Address review notes.
Repository:
rL LLVM
https://reviews.llvm.org/D37565
Files:
docs/ReleaseNotes.rst
lib/Sema/SemaChecking.cpp
test/Sema/compare.c
test/Sema/out
Hello Richard,
This commit broke one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/4705
Failing Tests (1):
Clang :: CXX/modules-ts/basic/basic.link/p3.cppm
Please have a look?
Thanks
Galina
On Wed, Sep 6, 2017 at 10:29 PM, Richard Smith v
Author: rsmith
Date: Thu Sep 7 13:22:00 2017
New Revision: 312743
URL: http://llvm.org/viewvc/llvm-project?rev=312743&view=rev
Log:
Add IDNS_Tag to C++ declarations that conflict with tag declarations.
Fixes some accepts-invalids with tags and other declarations declared in the
same scope.
Adde
rwols updated this revision to Diff 114242.
rwols added a comment.
Change command-line option back to "-enable-snippets", disable snippets by
default. This is a temporary solution and we should instead inspect the
"initialize" request from the client to check wether the client supports
snippets
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312742: [OpenCL] Add half load and store builtins (authored
by jvesely).
Changed prior to commit:
https://reviews.llvm.org/D37231?vs=113624&id=114240#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: jvesely
Date: Thu Sep 7 12:39:10 2017
New Revision: 312742
URL: http://llvm.org/viewvc/llvm-project?rev=312742&view=rev
Log:
[OpenCL] Add half load and store builtins
This enables load/stores of half type, without half being a legal type.
Differential Revision: https://reviews.llvm.org/
yaxunl added a comment.
In https://reviews.llvm.org/D37568#863735, @b-sumner wrote:
> The assembler accepts v[N] in addition to vN. I'm not sure if that is needed
> here.
Then we'd better also allow that in constraints to avoid confusion of users.
https://reviews.llvm.org/D37568
b-sumner added a comment.
The assembler accepts v[N] in addition to vN. I'm not sure if that is needed
here.
https://reviews.llvm.org/D37568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
cameron314 updated this revision to Diff 114228.
cameron314 added a comment.
Here's an updated patch. The code required to make it work is much simpler when
the BOM is simply ignored :-)
https://reviews.llvm.org/D37491
Files:
include/clang/Frontend/PrecompiledPreamble.h
include/clang/Lex/L
yaxunl added a comment.
In https://reviews.llvm.org/D36410#863579, @Anastasia wrote:
> In https://reviews.llvm.org/D36410#863508, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D36410#863426, @Anastasia wrote:
> >
> > > In https://reviews.llvm.org/D36410#863409, @yaxunl wrote:
> > >
> > > > LGT
lebedev.ri planned changes to this revision.
lebedev.ri added inline comments.
Comment at: test/Sema/outof-range-constant-compare.c:41
+if (a < 0xUL)
+return 0;
+if (a <= 0xUL)
rjmccall wrote:
> Hmm. I think this s
efriedma added a comment.
If you want to follow what we do for x86-64 on ARM, you should be doing this in
the driver, not codegen (grep for IsUnwindTablesDefault).
https://reviews.llvm.org/D31140
___
cfe-commits mailing list
cfe-commits@lists.llvm.
rjmccall added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8589
+ Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
+ Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
+
lebedev.ri wrote:
> rjmccall wrote:
> > Do you still need these? I'm always antsy a
lebedev.ri added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8879
+ if (IsComparisonConstant)
return AnalyzeImpConvsInComparison(S, E);
rjmccall wrote:
> lebedev.ri wrote:
> > rjmccall wrote:
> > > Part of the purpose of checking for signed c
rjmccall added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8879
+ if (IsComparisonConstant)
return AnalyzeImpConvsInComparison(S, E);
lebedev.ri wrote:
> rjmccall wrote:
> > Part of the purpose of checking for signed comparisons up here is to
yaxunl updated this revision to Diff 114223.
yaxunl marked 3 inline comments as done.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Revised by Matt's comments.
https://reviews.llvm.org/D37568
Files:
lib/Basic/Targets/AMDGPU.h
test/CodeGenOpenCL/amdgcn-inline-asm.cl
t
lebedev.ri added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8592
+ bool BadR = !RType->isIntegerType() || RType->isSignedIntegerType() ||
+ RHS->isKnownToHaveBooleanValue();
+
rjmccall wrote:
> Please extract a function which computes th
lebedev.ri updated this revision to Diff 114221.
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.
Address review notes.
Repository:
rL LLVM
https://reviews.llvm.org/D37565
Files:
docs/ReleaseNotes.rst
lib/Sema/SemaChecking.cpp
test/Sema/outof-range-constant-comp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312736: [CUDA] When compilation fails, print the compilation
mode. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D37548?vs=114112&id=114222#toc
Repository:
rL LLVM
https://
Author: jlebar
Date: Thu Sep 7 11:37:16 2017
New Revision: 312736
URL: http://llvm.org/viewvc/llvm-project?rev=312736&view=rev
Log:
[CUDA] When compilation fails, print the compilation mode.
Summary:
That is, instead of "1 error generated", we now say "1 error generated
when compiling for sm_35"
schroedersi added a comment.
Hello Richard, what do you think about the printing context changes? Are they
what you expected?
https://reviews.llvm.org/D30946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312734: [CUDA] Added rudimentary support for CUDA-9 and
sm_70. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D37576?vs=114206&id=114216#toc
Repository:
rL LLVM
https://reviews
Author: tra
Date: Thu Sep 7 11:14:32 2017
New Revision: 312734
URL: http://llvm.org/viewvc/llvm-project?rev=312734&view=rev
Log:
[CUDA] Added rudimentary support for CUDA-9 and sm_70.
For now CUDA-9 is not included in the list of CUDA versions clang
searches for, so the path to CUDA-9 must be ex
yaxunl added inline comments.
Comment at: test/Sema/inline-asm-validate-amdgpu.cl:38
+__asm("v_add_f32_e32 v1, v2, v3" : "=v1"(ci) : "v2"(ai), "v3"(bi) : ); ///
expected-error {{invalid output constraint '=v1' in asm}}
+__asm("v_add_f32_e32 v1, v2, v3" : "=v1:2"(ci) : "v
frutiger created this revision.
Introduce the 'TLS Kind' property of variable declarations through
libclang. Additionally, provide a Python accessor for it, and test that
functionality.
https://reviews.llvm.org/D37577
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test
itessier added a comment.
Do you mind submitting this CL? I don't have access to SVN.
https://reviews.llvm.org/D37496
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Looks great.
https://reviews.llvm.org/D37576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tra updated this revision to Diff 114206.
tra added a comment.
Added tests for sm_70 support.
https://reviews.llvm.org/D37576
Files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Basic/Targets/NVPTX.cpp
clang/lib/Driver/ToolChains/Cuda.cpp
clang/lib/Headers/__cla
Rakete updated this revision to Diff 114204.
Rakete added a comment.
Good idea! Updated diff :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseStmt.cp
Anastasia added a comment.
In https://reviews.llvm.org/D36410#863508, @yaxunl wrote:
> In https://reviews.llvm.org/D36410#863426, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D36410#863409, @yaxunl wrote:
> >
> > > LGTM as a temporary measure until we have a solution for properly
> > > em
erichkeane added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:2377
+/// \brief Tests if the __interface base is public.
+static bool IsBasePublicInterface(const CXXRecordDecl *RD,
+ AccessSpecifier spec) {
This function i
tra created this revision.
Herald added subscribers: hiraditya, sanjoy, jholewinski.
For now CUDA-9 is not included in the list of CUDA versions clang
searches for, so the path to CUDA-9 must be explicitly passed
via --cuda-path=.
On LLVM side NVPTX added sm_70 GPU type which bumps required
PTX v
zahiraam updated this revision to Diff 114201.
zahiraam added a comment.
Just upload a new patch. Please review.
https://reviews.llvm.org/D37308
Files:
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/ms-uuid.cpp
Index: test/SemaCXX/ms-uuid.cpp
===
arsenm added inline comments.
Comment at: test/Sema/inline-asm-validate-amdgpu.cl:38
+__asm("v_add_f32_e32 v1, v2, v3" : "=v1"(ci) : "v2"(ai), "v3"(bi) : ); ///
expected-error {{invalid output constraint '=v1' in asm}}
+__asm("v_add_f32_e32 v1, v2, v3" : "=v1:2"(ci) : "v
Nebiroth updated this revision to Diff 114199.
Nebiroth marked 7 inline comments as done.
Nebiroth added a comment.
Modified CompileCommandsDir to only look in the specified path if the value is
set.
Moved CompileCommandsDir field to DirectoryBasedGlobalCompilationDatabase class.
Minor refactorin
rjmccall added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8592
+ bool BadR = !RType->isIntegerType() || RType->isSignedIntegerType() ||
+ RHS->isKnownToHaveBooleanValue();
+
Please extract a function which computes this for an Expr* and
arsenm added inline comments.
Comment at: test/Sema/inline-asm-validate-amdgpu.cl:38
+__asm("v_add_f32_e32 v1, v2, v3" : "=v1"(ci) : "v2"(ai), "v3"(bi) : ); ///
expected-error {{invalid output constraint '=v1' in asm}}
+__asm("v_add_f32_e32 v1, v2, v3" : "=v1:2"(ci) : "v
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312728: [OpenCL] Handle taking an address of block captures.
(authored by stulova).
Changed prior to commit:
https://reviews.llvm.org/D36410?vs=110015&id=114197#toc
Repository:
rL LLVM
https://revie
Author: stulova
Date: Thu Sep 7 10:00:33 2017
New Revision: 312728
URL: http://llvm.org/viewvc/llvm-project?rev=312728&view=rev
Log:
[OpenCL] Handle taking an address of block captures.
Block captures can have different physical locations
in memory segments depending on the use case (as a functi
craig.topper added a comment.
You need to remove the bultins from include/clang/Basic/BuiltinsX86.def too.
https://reviews.llvm.org/D37562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
JonasToth added a comment.
ping
https://reviews.llvm.org/D36354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya added a comment.
Ping!
https://reviews.llvm.org/D36423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Nice.
https://reviews.llvm.org/D37548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
yaxunl added a comment.
In https://reviews.llvm.org/D36410#863426, @Anastasia wrote:
> In https://reviews.llvm.org/D36410#863409, @yaxunl wrote:
>
> > LGTM as a temporary measure until we have a solution for properly emitting
> > blocks as enqueued kernel.
>
>
> Should I start discussion with Kh
hintonda accepted this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D35533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
commit cc52d367ede0f3f306014d0418e18772e0c49dec
Author: Masud Rahman
Date: Thu Sep 7 11:39:19 2017 -0400
[bindings] add Cursor.linkage
Add Python bindings for the 'clang_getCursorLinkage', and tests to
validate the functionality.
diff --git a/bindings/python/clang/cindex.py
b/bind
szepet created this revision.
Herald added subscribers: baloghadamsoftware, whisperity, JDevlieghere.
There is a reported bug on the checker not handling the some APSInt values
correctly: https://bugs.llvm.org/show_bug.cgi?id=34400
This patch fixes it, however, it shows a false positive. (Added
Anastasia added a comment.
In https://reviews.llvm.org/D36410#863409, @yaxunl wrote:
> LGTM as a temporary measure until we have a solution for properly emitting
> blocks as enqueued kernel.
Should I start discussion with Khronos on that? What would our preference be -
implicitly `generic` AS
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
Yes, sorry overlooked that. :) LGTM! Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D37231
___
cfe-commits mailing list
cfe-commit
Anastasia added inline comments.
Comment at: include/clang/AST/Type.h:332
+ bool getImplicitAddressSpaceFlag() const { return Mask & IMask; }
+ void setImplicitAddressSpaceFlag(bool Value) {
Could we add a bit of comment somewhere explaining why we added impl
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM as a temporary measure until we have a solution for properly emitting
blocks as enqueued kernel.
https://reviews.llvm.org/D36410
___
cfe-co
mibintc added a comment.
Another ping. Is it possible to approve this modification, or alternatively,
let me know that it won't be approved indefinitely? I understand that it's a
controversial change. Thanks!
https://reviews.llvm.org/D34158
___
curdeius abandoned this revision.
curdeius added a comment.
Superseded by https://reviews.llvm.org/rL312125.
https://reviews.llvm.org/D31334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: mkurdej
Date: Thu Sep 7 07:28:32 2017
New Revision: 312723
URL: http://llvm.org/viewvc/llvm-project?rev=312723&view=rev
Log:
[clang-format] Add support for C++17 structured bindings.
Summary:
Before:
```
auto[a, b] = f();
```
After:
```
auto [a, b] = f();
```
or, if SpacesInSqua
yaxunl created this revision.
Herald added subscribers: eraman, t-tye, tpr, dstuttard, nhaehnle, wdng,
kzhuravl.
Currently AMDGPU inline asm only allow "v" and "s" as register names in
constraints.
This patch allows the following register names in constraints: (n, m is
unsigned integer, n < m)
djasper accepted this revision.
djasper added a comment.
Submitted as r312721. Thank you.
https://reviews.llvm.org/D37513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Thu Sep 7 06:45:41 2017
New Revision: 312721
URL: http://llvm.org/viewvc/llvm-project?rev=312721&view=rev
Log:
[clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine
The current description of AllowAllParametersOfDeclarationOnNextLine in
the Clang-Fo
lebedev.ri updated this revision to Diff 114172.
lebedev.ri added a comment.
Added ReleaseNotes.rst note
Repository:
rL LLVM
https://reviews.llvm.org/D37565
Files:
docs/ReleaseNotes.rst
lib/Sema/SemaChecking.cpp
test/Sema/outof-range-constant-compare.c
Index: test/Sema/outof-range-con
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Sorry for the delay.
https://reviews.llvm.org/D37132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
cameron314 added a comment.
> Maybe there's a third option option to remove the BOM from the buffer before
> passing it to clang?
> Could you elaborate on your use-case a little more? Is there no way to
> consistently always pass buffers either with or without BOM?
> Out of two options you men
cameron314 added a comment.
Looking at the way remapped buffers are handled, I just remembered that they
must exist on the file system (at the very least, in a directory that exists)
or the remapping is not taken into account. So that pretty much rules out the
other approach, I think.
https:/
PriMee created this revision.
Herald added a subscriber: JDevlieghere.
Bug: https://bugs.llvm.org/show_bug.cgi?id=34450
**Problem:**
Clang-tidy check misc-unused-parameters omits parameter default value what
results in its complete removal. Compilation errors might occur after
clang-tidy fix.
lebedev.ri created this revision.
lebedev.ri added a project: clang.
This is a first half(?) of a fix for the following bug:
https://bugs.llvm.org/show_bug.cgi?id=34147 (gcc -Wtype-limits)
GCC's -Wtype-limits does warn on comparison of unsigned value
with signed zero (as in, with 0), but clang on
LuMa added a comment.
I cannot commit the patch myself.
https://reviews.llvm.org/D37513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LuMa updated this revision to Diff 114161.
https://reviews.llvm.org/D37513
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
===
--- include/clang/Format/Format.h
+++ inc
sgilles added a comment.
Sure, if it still applies. I'm just a user and have no write access. Looks
like I patched this locally and then forgot all about it.
https://reviews.llvm.org/D28148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
minseong.kim updated this revision to Diff 114160.
minseong.kim marked 3 inline comments as done.
minseong.kim added a comment.
Re-uploading the patch, removing debug messages accidentally included in the
patch.
https://reviews.llvm.org/D35533
Files:
lib/Basic/CMakeLists.txt
Index: lib/Bas
Author: sylvestre
Date: Thu Sep 7 05:09:14 2017
New Revision: 312717
URL: http://llvm.org/viewvc/llvm-project?rev=312717&view=rev
Log:
Add an usage example of BreakBeforeBraces
Reviewers: djasper
Reviewed By: djasper
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm
1 - 100 of 124 matches
Mail list logo
