r312220 - [modules] Add ability to specify module name to module file mapping (reapply)

Author: borisk Date: Wed Aug 30 23:26:43 2017 New Revision: 312220 URL: http://llvm.org/viewvc/llvm-project?rev=312220&view=rev Log: [modules] Add ability to specify module name to module file mapping (reapply) Extend the -fmodule-file option to support the [=] value format. If the name is omitte

r312217 - Fix path regex in test to match on Windows

Author: borisk Date: Wed Aug 30 23:18:08 2017 New Revision: 312217 URL: http://llvm.org/viewvc/llvm-project?rev=312217&view=rev Log: Fix path regex in test to match on Windows Modified: cfe/trunk/test/CXX/modules-ts/basic/basic.link/module-declaration.cpp Modified: cfe/trunk/test/CXX/modules

r312218 - Remove accidental newline.

Author: nico Date: Wed Aug 30 23:18:26 2017 New Revision: 312218 URL: http://llvm.org/viewvc/llvm-project?rev=312218&view=rev Log: Remove accidental newline. Modified: cfe/trunk/test/SemaCXX/destructor.cpp Modified: cfe/trunk/test/SemaCXX/destructor.cpp URL: http://llvm.org/viewvc/llvm-proj

[PATCH] D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers.

thakis closed this revision. thakis added a comment. 312216, thanks! https://reviews.llvm.org/D37324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r312216 - Suppress -Wdelete-non-virtual-dtor warnings about classes defined in system headers.

Author: nico Date: Wed Aug 30 23:17:08 2017 New Revision: 312216 URL: http://llvm.org/viewvc/llvm-project?rev=312216&view=rev Log: Suppress -Wdelete-non-virtual-dtor warnings about classes defined in system headers. r312167 made it so that we emit Wdelete-non-virtual-dtor from delete statements

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek updated this revision to Diff 113359. Prazek added a comment. - docs fixes https://reviews.llvm.org/D33852 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td test/Sema/attr-selectany.c test/SemaCXX/attr-selectany.cpp Index: test/SemaCXX/attr-selectany.cpp ==

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek updated this revision to Diff 113357. Prazek added a comment. - docs fixes https://reviews.llvm.org/D33852 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td test/Sema/attr-selectany.c test/SemaCXX/attr-selectany.cpp Index: test/SemaCXX/attr-selectany.cpp ==

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

mstorsjo added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2990-2993 + bool IsMinGW = + CGM.getContext().getTargetInfo().getTriple().getEnvironment() == + llvm::Triple::GNU && + CGM.getContext().getTargetInfo().getTriple().isOSWi

[PATCH] D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Lgtm https://reviews.llvm.org/D37324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

dcoughlin added a comment. Maxim, thanks for commandeering the patch. I apologize for the long delay reviewing! I really like the approach of retrying without scopes enabled when we hit a construct we can't handle yet. This will make is possible to turn the feature on by default (and get it ru

[PATCH] D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers.

thakis created this revision. r312167 made it so that we emit Wdelete-non-virtual-dtor from `delete` statements that are in system headers (e.g. std::unique_ptr). That works great on Linux and macOS, but on Windows there are non-final classes that are defined in system headers that have virtual

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

compnerd added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2990-2993 + bool IsMinGW = + CGM.getContext().getTargetInfo().getTriple().getEnvironment() == + llvm::Triple::GNU && + CGM.getContext().getTargetInfo().getTriple().isOSWi

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

MTC marked an inline comment as done. MTC added a comment. Hi peter, Thank you very much for your help. > - I think the current display information is ambiguous. If I did not know the > code then I would not understand what this stands for. (That is just my > opinon.) I think Artem's "Content

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. In https://reviews.llvm.org/D36806#856070, @lhames wrote: > I've added an optional ErrMsg argument to cantFail in r312066 - you can now > use this to preserve your explanatory text. Thank you for adding this! I updated the CL to make use of it. https://reviews.llvm.o

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines updated this revision to Diff 113351. srhines added a comment. Switch to using ErrMsg in cantFail(). https://reviews.llvm.org/D36806 Files: lib/Tooling/Core/Replacement.cpp Index: lib/Tooling/Core/Replacement.cpp === --

[PATCH] D37322: [Sema] Correct typos in LHS, RHS before building a binop expression.

vsapsai created this revision. Specifically, typo correction should be done before dispatching between different kinds of binary operations like pseudo-object assignment, overloaded binary operation, etc. Without this change we hit an assertion Assertion failed: (!LHSExpr->hasPlaceholderType(B

RE: r312181 - Fix tests for ARM targets

Sorry about that, thanks for fixing it up for me! Douglas Yung > -Original Message- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent: Wednesday, August 30, 2017 16:28 > To: Yung, Douglas > Cc: cfe-commits > Subject: Re: r312181 - Fix tests for

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor updated this revision to Diff 113343. andrew.w.kaylor added a comment. Fixed value-dependent argument in isNullPointerConstant checks. Added check for C++ zero offset in subtraction. Added value-dependent test cases. https://reviews.llvm.org/D37042 Files: include/clang/AST/Exp

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov updated this revision to Diff 113340. https://reviews.llvm.org/D37312 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td === --- include/clang/Basic/AttrDocs

Re: r312181 - Fix tests for ARM targets

I fixed them some more in r312193 :-) See e.g. here for the sample breakage: http://bb.pgr.jp/builders/test-clang-i686-linux-RA/builds/6961/steps/test_clang/logs/Clang%20%3A%3A%20CodeGen__profile-sample-accurate.c On Wed, Aug 30, 2017 at 3:30 PM, Douglas Yung via cfe-commits wrote: > Author: dyu

r312193 - Fix the test fix from r312181

Author: hans Date: Wed Aug 30 16:26:38 2017 New Revision: 312193 URL: http://llvm.org/viewvc/llvm-project?rev=312193&view=rev Log: Fix the test fix from r312181 Modified: cfe/trunk/test/CodeGen/profile-sample-accurate.c cfe/trunk/test/CodeGen/thinlto-emit-llvm.c cfe/trunk/test/Integra

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rsmith added inline comments. Comment at: lib/AST/Expr.cpp:1857 + if (!PExp->IgnoreParenCasts() + ->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull)) +return false; andrew.w.kaylor wrote: > rsmith wrote: > > If we get here with a value-dep

r312191 - [cxx_status] Update to describe current status a bit better.

Author: rsmith Date: Wed Aug 30 16:10:31 2017 New Revision: 312191 URL: http://llvm.org/viewvc/llvm-project?rev=312191&view=rev Log: [cxx_status] Update to describe current status a bit better. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.

r312186 - [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet.

Author: d0k Date: Wed Aug 30 15:51:50 2017 New Revision: 312186 URL: http://llvm.org/viewvc/llvm-project?rev=312186&view=rev Log: [Sema] Make SpecialMemberDecl a PointerIntPair so we can stash it in a SmallPtrSet. We have enough spare bits in the alignment of CXXRecordDecl. No functionality chan

[PATCH] D37156: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL312185: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D37156?vs=113177&id=113329#toc Repository: rL L

r312185 - [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer

Author: morehouse Date: Wed Aug 30 15:49:31 2017 New Revision: 312185 URL: http://llvm.org/viewvc/llvm-project?rev=312185&view=rev Log: [SanitizeCoverage] Enable stack-depth coverage for -fsanitize=fuzzer Summary: - Don't sanitize __sancov_lowest_stack. - Don't instrument leaf functions. - Add Co

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added inline comments. Comment at: lib/AST/Expr.cpp:1857 + if (!PExp->IgnoreParenCasts() + ->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull)) +return false; rsmith wrote: > If we get here with a value-dependent expression,

r312181 - Fix tests for ARM targets

Author: dyung Date: Wed Aug 30 15:30:08 2017 New Revision: 312181 URL: http://llvm.org/viewvc/llvm-project?rev=312181&view=rev Log: Fix tests for ARM targets Tests fail on ARM targets due to ABI name between define and void. Added reg ex to skip. Patch by Glenn Howe (and expanded on by Douglas

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8808 +Context.getTypeSize(pointerType) == +Context.getTypeSize(IExp->getType())) + IsGNUIdiom = true; efriedma wrote: > andrew.w.kaylor wrote: > > efriedma wrote: > > > rs

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

rsmith added inline comments. Comment at: lib/AST/Expr.cpp:1857 + if (!PExp->IgnoreParenCasts() + ->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull)) +return false; If we get here with a value-dependent expression, we should treat it as n

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Reduced in r312175. -- adrian > On Aug 28, 2017, at 4:47 PM, David Blaikie wrote: > > *nod* Thanks - let me know if you have trouble simplifying or explaining it & > I'll see if fresh eyes help :) > > On Mon, Aug 28, 2017 at 4:46 PM Adrian Prantl wrote: > It's possible that this testcase ca

r312175 - Test-case golfing.

Author: adrian Date: Wed Aug 30 14:31:16 2017 New Revision: 312175 URL: http://llvm.org/viewvc/llvm-project?rev=312175&view=rev Log: Test-case golfing. Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp URL: http://llvm.org/

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

erichkeane added a comment. Aaron should have final say, but I've included my 2 cents. Comment at: include/clang/Basic/AttrDocs.td:2816 + +Note that x86_64 ABI forces 16-byte stack alignment at the caller side. Taking +it into account 'force_align_arg_pointer' is not needed at

[PATCH] D37312: Add documentation for force_align_arg_pointer function attribute

anatol.pomozov added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2809 + let Content = [{ +Use this attribute to force stack alignment. + Feel free to reword the documentation (English is not my native language). Let me know if something is not

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor updated this revision to Diff 113311. andrew.w.kaylor added a comment. Refactored the GNU idiom check to be shared by Sema and CodeGen. Refined the checks so that nullptr+0 doesn't warn in C++. Added the zero offset qualification in the warning produced with C++. https://reviews

Re: [PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

On 28 August 2017 at 17:00, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Aug 28, 2017 at 7:40 PM, Richard Smith - zygoloid via Phabricator > via cfe-commits wrote: > >> rsmith added inline comments. >> >> >> >> Comment at: test/SemaCXX/destructor.cpp:

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL312173: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64 (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D36272?vs=113166&id=113312#toc Repository: r

r312173 - [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

Author: erichkeane Date: Wed Aug 30 14:17:40 2017 New Revision: 312173 URL: http://llvm.org/viewvc/llvm-project?rev=312173&view=rev Log: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64 This attribute is useful in OS development when we jump from 32 to 64 bit code and expect

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

mstorsjo added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2994 + CGM.getContext().getTargetInfo().getTriple().isOSWindows(); + // MinGW always uses LinkOnceODRLinkage for type info. + if (RD->isDynamicClass() && !IsMinGW) mstors

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

mstorsjo added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2994 + CGM.getContext().getTargetInfo().getTriple().isOSWindows(); + // MinGW always uses LinkOnceODRLinkage for type info. + if (RD->isDynamicClass() && !IsMinGW) Thanks

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

szepet added a reviewer: szepet. szepet edited subscribers, added: cfe-commits; removed: szepet. szepet added a comment. Hello MTC, Thanks for working on this! I planned to add a change like this in D36690 but it worths an individual patch (did not know it was

[PATCH] D37310: [Atomic] Merge alignment information from Decl and from Type when emit atomic expression.

wmi created this revision. Herald added a subscriber: sanjoy. This is to fix PR34347. EmitAtomicExpr will only use alignment information from Type, instead of Decl, so when the declaration of an atomic variable is marked to have the alignment equal as its size, EmitAtomicExpr don't know about i

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D37206: [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW

mstorsjo updated this revision to Diff 113309. mstorsjo added a comment. The previous diff lacked the extra context around the diff - fixed. https://reviews.llvm.org/D37206 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-mingw64.cpp Index: test/CodeGenCXX/rtti-mingw64.cpp ==

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. In https://reviews.llvm.org/D36272#857010, @anatol.pomozov wrote: > I have no commit permissions (this is my first patch to LLVM project). > Ideally if someone of you merge it. If not then I'll ask a friend of mine who > works on clang sanitizers to merge it. I'll

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. I have no commit permissions (this is my first patch to LLVM project). Ideally if someone of you merge it. If not then I'll ask a friend of mine who works on clang sanitizers to merge it. https://reviews.llvm.org/D36272 ___

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman added a comment. In https://reviews.llvm.org/D36272#857005, @anatol.pomozov wrote: > Hi Aaron. Thank you very much for reviewing this patch. > > I'll be glad to add documentation for 'force_align_arg_pointer' attribute and > upload another patch. But before doing it I would like to

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Current patch is ready. Guessing you do not have commit rights? https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Hi Aaron. Thank you very much for reviewing this patch. I'll be glad to add documentation for 'force_align_arg_pointer' attribute and upload another patch. But before doing it I would like to finish work on the current patch and make its forward progress toward r

[PATCH] D37235: Let -Wdelete-non-virtual-dtor fire in system headers too.

thakis closed this revision. thakis added a comment. Thanks, landed in r312167. dblaikie: I believe the test can't be much simpler -- the pragma is file-based and having the main TU be marked as system header would be fairly different from what happens in real life even if it worked. https://

r312167 - Let -Wdelete-non-virtual-dtor fire in system headers too.

Author: nico Date: Wed Aug 30 13:25:22 2017 New Revision: 312167 URL: http://llvm.org/viewvc/llvm-project?rev=312167&view=rev Log: Let -Wdelete-non-virtual-dtor fire in system headers too. Makes the warning useful again in a std::unique_ptr world, PR28460. Also make the warning not fire in uneva

[PATCH] D37308: Interface class with uuid base record

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:2403-2406 +static bool IsBasePublicInterface(const CXXRecordDecl *RD, + AccessSpecifier spec) { + return RD->isInterface() && spec == AS_public; +} I'm not

[clang-tools-extra] r312166 - [cppcoreguidelines] Don't rely on SmallPtrSet iteration order.

Author: d0k Date: Wed Aug 30 13:18:40 2017 New Revision: 312166 URL: http://llvm.org/viewvc/llvm-project?rev=312166&view=rev Log: [cppcoreguidelines] Don't rely on SmallPtrSet iteration order. The fixit emission breaks if the iteration order changes and also missed to emit fixits for some edge ca

[PATCH] D37308: Interface class with uuid base record

erichkeane added a comment. 1- You need to do your diff with -U9 so that we get the full context of the file. 2- Better explain the issue in the description 3 SemaDeclCXX.cpp changes look like they need clang-format run on them. https://reviews.llvm.org/D37308 _

[PATCH] D37308: Interface class with uuid base record

zahiraam created this revision. Added support for interface inheriting from a uuid base record. https://reviews.llvm.org/D37308 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/ms-uuid.cpp Index: test/SemaCXX/ms-uuid.cpp === ---

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

On 30 August 2017 at 11:52, Boris Kolpackov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Victor Leschuk writes: > > > Hello Boris, looks like this revision broke tests on our win10 builder: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ > 64-scei-ps4-windows10pro-fast/builds/

[PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation

erichkeane updated this revision to Diff 113297. erichkeane added a comment. Woops, messed up my rebase! https://reviews.llvm.org/D36707 Files: lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CodeGenFunction.h Index: lib/CodeGen/CodeGenFunction.h =

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

Victor Leschuk writes: > Hello Boris, looks like this revision broke tests on our win10 builder: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760 > > Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp > > I had to revert this revisio

[PATCH] D36410: [OpenCL] Handle taking address of block captures

bader added a comment. In https://reviews.llvm.org/D36410#856716, @yaxunl wrote: > The captured variable is still passed by value. The address taking is on the > duplicate of the captured variable, not on the original variable. In this case address of captured variables should point to the pri

[PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation

erichkeane updated this revision to Diff 113291. erichkeane added a comment. This revision is now accepted and ready to land. I figured out that combining the CpuSupports items via an array is a REALLY useful function for dispatch. I've got most of gcc's target implemented, so I believe that th

r312149 - docs: typo fix

Author: hans Date: Wed Aug 30 11:35:44 2017 New Revision: 312149 URL: http://llvm.org/viewvc/llvm-project?rev=312149&view=rev Log: docs: typo fix Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/Relea

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

rjmccall added a comment. In https://reviews.llvm.org/D33826#856652, @lebedev.ri wrote: > In https://reviews.llvm.org/D33826#856619, @Eugene.Zelenko wrote: > > > In https://reviews.llvm.org/D33826#856610, @lebedev.ri wrote: > > > > > Any status update here? :) > > > I generally do see a benefit

r312148 - Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression

Author: adrian Date: Wed Aug 30 11:22:23 2017 New Revision: 312148 URL: http://llvm.org/viewvc/llvm-project?rev=312148&view=rev Log: Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression Modified: cfe/trunk/test/CodeGen/2009-10-20-GlobalDebug.c cfe/trunk/test/CodeGen/debug-

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman accepted this revision. aaron.ballman added a comment. In https://reviews.llvm.org/D36272#856857, @erichkeane wrote: > In https://reviews.llvm.org/D36272#856849, @anatol.pomozov wrote: > > > > if we corrected the attribute spelling to be GCC instead of GNU and added > > > some docu

[PATCH] D33852: Enable __declspec(selectany) on linux

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:2477 let Spellings = [Declspec<"selectany">, GCC<"selectany">]; let Documentation = [Undocumented]; } Prazek wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > Since we'

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek added inline comments. Comment at: include/clang/Basic/Attr.td:2477 let Spellings = [Declspec<"selectany">, GCC<"selectany">]; let Documentation = [Undocumented]; } aaron.ballman wrote: > aaron.ballman wrote: > > Since we're drastically modifying wh

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. In https://reviews.llvm.org/D36272#856849, @anatol.pomozov wrote: > > if we corrected the attribute spelling to be GCC instead of GNU and added > > some documentation to the attribute > > These are great suggestions! But I think it makes more sense to have a > separa

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. > As I said, as long as BOTH windows versions have the same issue, I think _I_ > am OK with it. The tests fail at windows the same way. The only difference - "attribute is not supported at 64bit" compiler warning is gone with my change. > if we corrected the att

[clang-tools-extra] r312141 - [clang-tidy] fix buildbot

Author: jonastoth Date: Wed Aug 30 10:21:41 2017 New Revision: 312141 URL: http://llvm.org/viewvc/llvm-project?rev=312141&view=rev Log: [clang-tidy] fix buildbot Use `signed char` instead of `char`. Modified: clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp Modified: clang-t

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#856821, @benlangmuir wrote: > In https://reviews.llvm.org/D34512#856301, @xazax.hun wrote: > > > In https://reviews.llvm.org/D34512#856184, @dcoughlin wrote: > > > > > In either case, the important scenario I think we should support is

[PATCH] D34512: Add preliminary Cross Translation Unit support library

benlangmuir added a comment. In https://reviews.llvm.org/D34512#856301, @xazax.hun wrote: > In https://reviews.llvm.org/D34512#856184, @dcoughlin wrote: > > > In either case, the important scenario I think we should support is > > choosing at a call site to a C function the most likely definitio

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

On 30 August 2017 at 18:29, Jonas Toth wrote: > Hi Diana, > > i will investigate this issue. Can i see from somewhere, what email my > buildbot uses? I actually don't know if you can check anywhere, but in principle it should be the same address that the commit email came from (i.e. this one, tha

[clang-tools-extra] r312137 - clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to add explicit triple.

Author: chapuni Date: Wed Aug 30 09:34:51 2017 New Revision: 312137 URL: http://llvm.org/viewvc/llvm-project?rev=312137&view=rev Log: clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise.cpp: Appease *-win32 to add explicit triple. Modified: clang-tools-extra/trunk/test/clang-tidy/hicpp-si

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hi Diana, i will investigate this issue. Can i see from somewhere, what email my buildbot uses? To fix the break I created a new Patch https://reviews.llvm.org/D37301 What is the right thing now, wait for review or just commit it and that review would occur on the commit? Thank you for you

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

On Wed, Aug 30, 2017 at 12:16 PM, Jonas Toth via cfe-commits wrote: > Hello Diana, > > you are right, i did not commit anything earlier, I am really new to the > process, these were my first commits. > > I am sorry that i broke the bots, i thought i would get an automatic mail, > when they find a

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hi Jonas, Usually the buildbots send emails when you're in the commit range. I'm surprised that you haven't received anything. Are you sure you don't have some mail filters that are catching them and sending them somewhere unexpected? In any case, you can see a live-but-slow buildbot status here:

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hello Diana, you are right, i did not commit anything earlier, I am really new to the process, these were my first commits. I am sorry that i broke the bots, i thought i would get an automatic mail, when they find a problem and i was in the commit range. Is there anything automated to find o

r312135 - [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

Author: ctopper Date: Wed Aug 30 09:15:12 2017 New Revision: 312135 URL: http://llvm.org/viewvc/llvm-project?rev=312135&view=rev Log: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins This patch implements the broadcastf32x2/broadcasti32x

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL312135: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using… (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D37287?vs=113199&id=113275#toc Repository: rL LLVM

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hi Jonas, I haven't seen any commit from you (*) fixing the buildbot failures caused by your previous commit (r312122). This has been keeping several bots red for quite a while: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/10590 http://lab.llvm.org:8011/builders/clang-x86-windows

[clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Author: jonastoth Date: Wed Aug 30 08:59:01 2017 New Revision: 312134 URL: http://llvm.org/viewvc/llvm-project?rev=312134&view=rev Log: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better Summary: This patch is a followup to the first revision D36583, that had problems wi

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 113271. hamzasood added a comment. Herald added a subscriber: klimek. Implemented pretty printing and recursive AST visiting (both with appropriate unit tests). The pretty printing implementation includes fixing a few printing bugs (which I needed fixed t

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D37060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added a comment. language in the docuementation improved https://reviews.llvm.org/D36354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman added a comment. In https://reviews.llvm.org/D36272#856722, @erichkeane wrote: > In https://reviews.llvm.org/D36272#856040, @anatol.pomozov wrote: > > > Hi Eric, thank you for your reply. Both these triples are currently broken, > > with my change and without. > > > > The attribute

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 113272. JonasToth marked 5 inline comments as done. JonasToth added a comment. - fix typos and bad language https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

boris created this revision. Add the -fmodule-file-map=[=] option which can be used to specify a file that contains module name to precompiled modules files mapping, similar to -fmodule-file==. The can be used to only consider certain lines which can be useful if we want to store the mapping i

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst:11 +The relevant sections in the `C++ Core Guidelines `_ are I.11, C.33, R.3 and GSL.Views +The

r312133 - Avoid 'size_t' typedef in the unittest ObjC code

Author: arphaman Date: Wed Aug 30 08:37:30 2017 New Revision: 312133 URL: http://llvm.org/viewvc/llvm-project?rev=312133&view=rev Log: Avoid 'size_t' typedef in the unittest ObjC code This should fix http://bb.pgr.jp/builders/test-clang-msc-x64-on-i686-linux-RA Modified: cfe/trunk/unittests/

[PATCH] D37182: [libcxx] Special visibility macros for the experimental library

mclow.lists added a comment. The reason for building the filesystem library as a statically linked lib (instead of dynamic) is that for quite a while it was changing significantly. Having people link statically means that we can make changes w/o worrying (as much) about people using the librar

r312132 - Recommit r312127: [refactor] AST selection tree should contain syntactic

Author: arphaman Date: Wed Aug 30 08:28:01 2017 New Revision: 312132 URL: http://llvm.org/viewvc/llvm-project?rev=312132&view=rev Log: Recommit r312127: [refactor] AST selection tree should contain syntactic form of PseudoObjectExpr The new commit adjusts unittest test code compilation options so

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113269. JonasToth marked an inline comment as done. JonasToth added a comment. - adjusted expected diagnostics - adjust diagnostics and remove private inheritance cases https://reviews.llvm.org/D37060 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D36272#856040, @anatol.pomozov wrote: > Hi Eric, thank you for your reply. Both these triples are currently broken, > with my change and without. > > The at

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:39 + /// Handles the source replacements that are produced by a refactoring action. + virtual void handle(AtomicChanges SourceReplacements) = 0; +}; ioeri

[PATCH] D36410: [OpenCL] Handle taking address of block captures

yaxunl added a comment. In https://reviews.llvm.org/D36410#855358, @bader wrote: > In https://reviews.llvm.org/D36410#855282, @Anastasia wrote: > > > Ok, I will update it to be implicitly generic then. Just to be sure, @bader > > do you agree on this too? > > > > > > An alternative approached co

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman added subscribers: sbenza, klimek. aaron.ballman added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:9 +class deep_hierarchy : public derived_exception {}; class non_derived_exception {}; JonasToth wrote: > aaron.ball

r312131 - Revert r312127 as the ObjC unittest code fails to compile on Linux

Author: arphaman Date: Wed Aug 30 08:11:45 2017 New Revision: 312131 URL: http://llvm.org/viewvc/llvm-project?rev=312131&view=rev Log: Revert r312127 as the ObjC unittest code fails to compile on Linux Modified: cfe/trunk/lib/Tooling/Refactoring/ASTSelection.cpp cfe/trunk/unittests/Toolin

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:9 +class deep_hierarchy : public derived_exception {}; class non_derived_exception {}; aaron.ballman wrote: > JonasToth wrote

r312127 - [refactor] AST selection tree should contain syntactic form

Author: arphaman Date: Wed Aug 30 08:00:27 2017 New Revision: 312127 URL: http://llvm.org/viewvc/llvm-project?rev=312127&view=rev Log: [refactor] AST selection tree should contain syntactic form of PseudoObjectExpr The AST selection finder now constructs a selection tree that contains only the sy

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 113265. JonasToth added a comment. - adjusted the diagnostic for member variables https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguide

  1   2   >