[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

barancsuk marked 3 inline comments as done. barancsuk added inline comments. Comment at: test/clang-tidy/readability-static-accessed-through-instance.cpp:55 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member accessed through + // instance [readability-static-accessed-

Re: r310694 - Implement latest feature test macro recommendations, P0096R4.

Hi Hans, this should go onto the Clang 5 branch. Thanks! On 10 August 2017 at 20:39, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 10 20:39:40 2017 > New Revision: 310694 > > URL: http://llvm.org/viewvc/llvm-project?rev=310694&view=rev > Log:

r310694 - Implement latest feature test macro recommendations, P0096R4.

Author: rsmith Date: Thu Aug 10 20:39:40 2017 New Revision: 310694 URL: http://llvm.org/viewvc/llvm-project?rev=310694&view=rev Log: Implement latest feature test macro recommendations, P0096R4. Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp cfe/trunk/test/Lexer/cxx-features.cpp

r310693 - Update cxx_status to mention the upcoming Clang 5 release.

Author: rsmith Date: Thu Aug 10 20:16:11 2017 New Revision: 310693 URL: http://llvm.org/viewvc/llvm-project?rev=310693&view=rev Log: Update cxx_status to mention the upcoming Clang 5 release. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.or

r310692 - PR33850: Update cxx_dr_status for Clang 5 branch.

Author: rsmith Date: Thu Aug 10 20:14:20 2017 New Revision: 310692 URL: http://llvm.org/viewvc/llvm-project?rev=310692&view=rev Log: PR33850: Update cxx_dr_status for Clang 5 branch. Modified: cfe/trunk/test/CXX/drs/dr20xx.cpp cfe/trunk/test/CXX/drs/dr4xx.cpp cfe/trunk/www/cxx_dr_stat

Re: r310691 - PR33489: A function-style cast to a deduced class template specialization type is type-dependent if it can't be resolved due to a type-dependent argument.

Hi Hans, this fixes a bug you wanted to treat as a 5.0 release blocker, so should be ported to the branch :) On 10 August 2017 at 19:04, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 10 19:04:19 2017 > New Revision: 310691 > > URL: http://llvm

r310691 - PR33489: A function-style cast to a deduced class template specialization type is type-dependent if it can't be resolved due to a type-dependent argument.

Author: rsmith Date: Thu Aug 10 19:04:19 2017 New Revision: 310691 URL: http://llvm.org/viewvc/llvm-project?rev=310691&view=rev Log: PR33489: A function-style cast to a deduced class template specialization type is type-dependent if it can't be resolved due to a type-dependent argument. Modified

[libcxxabi] r310684 - Creating release candidate rc2 from release_500 branch

Author: hans Date: Thu Aug 10 18:56:53 2017 New Revision: 310684 URL: http://llvm.org/viewvc/llvm-project?rev=310684&view=rev Log: Creating release candidate rc2 from release_500 branch Added: libcxxabi/tags/RELEASE_500/rc2/ - copied from r310683, libcxxabi/branches/release_50/ ___

[libunwind] r310690 - Creating release candidate rc2 from release_500 branch

Author: hans Date: Thu Aug 10 18:57:00 2017 New Revision: 310690 URL: http://llvm.org/viewvc/llvm-project?rev=310690&view=rev Log: Creating release candidate rc2 from release_500 branch Added: libunwind/tags/RELEASE_500/rc2/ (props changed) - copied from r310689, libunwind/branches/re

[libcxx] r310683 - Creating release candidate rc2 from release_500 branch

Author: hans Date: Thu Aug 10 18:56:52 2017 New Revision: 310683 URL: http://llvm.org/viewvc/llvm-project?rev=310683&view=rev Log: Creating release candidate rc2 from release_500 branch Added: libcxx/tags/RELEASE_500/rc2/ (props changed) - copied from r310682, libcxx/branches/release_

Re: r310006 - [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions.

r310677. On Thu, Aug 10, 2017 at 5:30 PM, Akira Hatanaka wrote: > Can we merge this one to 5.0 too? > >> On Aug 3, 2017, at 4:55 PM, Akira Hatanaka via cfe-commits >> wrote: >> >> Author: ahatanak >> Date: Thu Aug 3 16:55:42 2017 >> New Revision: 310006 >> >> URL: http://llvm.org/viewvc/llvm-p

Re: r309607 - [Driver] Allow users to silence the warning that is issued when the

r310676. On Thu, Aug 10, 2017 at 5:28 PM, Akira Hatanaka wrote: > Forgot to mention there are three other patches that are needed to fix the > bug introduced in r309607 (r309633, r309636 and r309640). > > > On Aug 10, 2017, at 5:25 PM, Akira Hatanaka via cfe-commits > wrote: > > Can we merge thi

Re: r309607 - [Driver] Allow users to silence the warning that is issued when the

r310675. On Thu, Aug 10, 2017 at 5:25 PM, Akira Hatanaka wrote: > Can we merge this to 5.0? > >> On Jul 31, 2017, at 12:16 PM, Akira Hatanaka via cfe-commits >> wrote: >> >> Author: ahatanak >> Date: Mon Jul 31 12:16:40 2017 >> New Revision: 309607 >> >> URL: http://llvm.org/viewvc/llvm-project

[PATCH] D36423: [libc++] Introsort based sorting function

bcraig added a comment. If you want the performance improvements in the BM_sort_std_worst_quick cases preserved, you really need to port the benchmark from Aditya's repo into the libcxx benchmark code base. Otherwise, the next person that comes along to improve std::sort performance may very w

Re: r309569 - Fix -Wshadow false positives with function-local classes.

r310674. Thanks! On Thu, Aug 10, 2017 at 4:52 PM, Richard Smith wrote: > Seems reasonable to me. > > On 10 August 2017 at 14:28, Hans Wennborg via cfe-commits > wrote: >> >> Should we merge this to 5.0? >> >> On Mon, Jul 31, 2017 at 8:21 AM, Alexander Kornienko via cfe-commits >> wrote: >> > Au

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

rjmccall added inline comments. Comment at: test/FixIt/fixit-cxx0x.cpp:57 (void)[&, &i, &i]{}; // expected-error 2{{'&' cannot precede a capture when the capture default is '&'}} - (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be explicitly captured}}

Re: r310006 - [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions.

Can we merge this one to 5.0 too? > On Aug 3, 2017, at 4:55 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Thu Aug 3 16:55:42 2017 > New Revision: 310006 > > URL: http://llvm.org/viewvc/llvm-project?rev=310006&view=rev > Log: > [Driver][Darwin] Pass -munwind-table wh

Re: r309607 - [Driver] Allow users to silence the warning that is issued when the

Forgot to mention there are three other patches that are needed to fix the bug introduced in r309607 (r309633, r309636 and r309640). > On Aug 10, 2017, at 5:25 PM, Akira Hatanaka via cfe-commits > wrote: > > Can we merge this to 5.0? > >> On Jul 31, 2017, at 12:16 PM, Akira Hatanaka via cfe-c

Re: r309607 - [Driver] Allow users to silence the warning that is issued when the

Can we merge this to 5.0? > On Jul 31, 2017, at 12:16 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Mon Jul 31 12:16:40 2017 > New Revision: 309607 > > URL: http://llvm.org/viewvc/llvm-project?rev=309607&view=rev > Log: > [Driver] Allow users to silence the warning t

[PATCH] D35362: [clang-tidy] Add a close-on-exec check on accept() in Android module.

yawanng updated this revision to Diff 110659. https://reviews.llvm.org/D35362 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecAcceptCheck.cpp clang-tidy/android/CloexecAcceptCheck.h docs/ReleaseNotes.rst docs/clang-tidy/check

[PATCH] D36541: [CMake] Include LLVMFuzzer in Fuchsia toolchain

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D36541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

r310672 - [Sema][ObjC] Fix spurious -Wcast-qual warnings.

Author: ahatanak Date: Thu Aug 10 17:06:49 2017 New Revision: 310672 URL: http://llvm.org/viewvc/llvm-project?rev=310672&view=rev Log: [Sema][ObjC] Fix spurious -Wcast-qual warnings. We do not meaningfully track object const-ness of Objective-C object types. Silence the -Wcast-qual warning that i

[PATCH] D35363: [clang-tidy] Add a close-on-exec check on accept4() in Android module.

yawanng updated this revision to Diff 110655. https://reviews.llvm.org/D35363 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecAccept4Check.cpp clang-tidy/android/CloexecAccept4Check.h docs/ReleaseNotes.rst docs/clang-tidy/che

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This also looks good to me. Repository: rL LLVM https://reviews.llvm.org/D36349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

nemanjai added a comment. Some buildbots use the distro gcc (looks like 5.4) and at least one uses gcc 7.1. I use gcc 6.2. I think that with the addition of https://reviews.llvm.org/D36555, the empty source file warnings should go away. However, I imagine that the warnings about atomics will st

[PATCH] D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module.

yawanng updated this revision to Diff 110654. https://reviews.llvm.org/D35364 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/android/CloexecDupCheck.cpp clang-tidy/andro

Re: r309569 - Fix -Wshadow false positives with function-local classes.

Seems reasonable to me. On 10 August 2017 at 14:28, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Should we merge this to 5.0? > > On Mon, Jul 31, 2017 at 8:21 AM, Alexander Kornienko via cfe-commits > wrote: > > Author: alexfh > > Date: Mon Jul 31 08:21:26 2017 > > New Re

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

rsmith added a comment. In https://reviews.llvm.org/D35941#823524, @alexfh wrote: > IIUC, most cases where -Wshadow warnings are issued is when a declaration > from an enclosing scope would be accessible if there was no declaration that > shadows it. In this case the the local variable of a fun

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

nemanjai added a comment. Thank you for doing this. These were causing warnings with some compilers when built on PowerPC because the sources were just empty (macro-guarded). Not compiling them at all is a much cleaner solution. LGTM but I am far from an authority on this part of the code so I'l

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

yawanng updated this revision to Diff 110652. https://reviews.llvm.org/D35365 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecEpollCreate1Check.cpp clang-tidy/android/CloexecEpollCreate1Check.h docs/ReleaseNotes.rst docs/clan

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

yawanng updated this revision to Diff 110650. https://reviews.llvm.org/D35367 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecEpollCreateCheck.cpp clang-tidy/android/CloexecEpollCreateCheck.h docs/ReleaseNotes.rst docs/clang-

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:9372 if (!isa(Target)) { - if (S.SourceMgr.isInSystemMacro(CC)) + if (S.SourceMgr.isInSystemMacro(CC) || Target->isBooleanType()) return; Do we really want to have d

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

yawanng updated this revision to Diff 110649. https://reviews.llvm.org/D35368 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInit1Check.cpp clang-tidy/android/CloexecInotifyInit1Check.h docs/ReleaseNotes.rst docs/clan

Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

Sorry, I meant bin/clang -Wthread-safety-attributes -Wthread-safety-analysis /tmp/tc.cpp -std=c++17 -c -o/dev/null (had -Wthread-safety-attributes twice in the email) George On Thu, Aug 10, 2017 at 4:08 PM, George Burgess IV wrote: > Hello! > > It looks like this is causing buildbot failures r

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

yawanng updated this revision to Diff 110646. https://reviews.llvm.org/D35370 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInitCheck.cpp clang-tidy/android/CloexecInotifyInitCheck.h docs/ReleaseNotes.rst docs/clang-

Re: r310436 - [AST] Move visibility computations into a class; NFC

Okay, apparently release_capability doesn't work how I assumed, so it looks like this may be a bug in r310403. Pinged that thread. On Thu, Aug 10, 2017 at 3:24 PM, George Burgess IV wrote: > Following up, > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4070/console > no long

Re: r310403 - Thread Safety Analysis: warn on nonsensical attributes.

Hello! It looks like this is causing buildbot failures related to libc++'s lock_guard and scoped_lock: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4070/consoleFull Here's a reduced test-case (from libc++'s __mutex_base): struct __attribute__((capability("mutex"))) mutex {

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng added a comment. https://reviews.llvm.org/rL310669 is the latest and complete version. It fixes an issue in windows platform. https://reviews.llvm.org/D35372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

wmi added a comment. I limit the bitfield separation in the last update to only happen at the beginning of a run so no bitfield combine will be blocked. I think I need to explain more about why I change the direction and start to work on the problem in frontend. Keeping the information by gener

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

wmi updated this revision to Diff 110641. wmi added a comment. Don't separate bitfield in the middle of a run because it is possible to hinder bitfields accesses combine. Only separate bitfield at the beginning of a run. Repository: rL LLVM https://reviews.llvm.org/D36562 Files: lib/CodeG

Re: r310436 - [AST] Move visibility computations into a class; NFC

Following up, http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4070/console no longer shows ubsan failures. Looks like the attempt to fix Driver/openmp-offload.c is in r310580 (the linked build was r310538). The libc++ test failures all seem to be a result of -Werror clang emit

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

yawanng updated this revision to Diff 110640. yawanng added a comment. Show full context. https://reviews.llvm.org/D35743 Files: lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp Index: unittests/Format/For

[clang-tools-extra] r310669 - [clang-tidy] Fix for buildbot.

Author: yawanng Date: Thu Aug 10 15:09:22 2017 New Revision: 310669 URL: http://llvm.org/viewvc/llvm-project?rev=310669&view=rev Log: [clang-tidy] Fix for buildbot. Summary: Fix an issue for windows. Differential Revision: https://reviews.llvm.org/D35372 Added: clang-tools-extra/trunk/clang

Re: r309569 - Fix -Wshadow false positives with function-local classes.

Should we merge this to 5.0? On Mon, Jul 31, 2017 at 8:21 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Mon Jul 31 08:21:26 2017 > New Revision: 309569 > > URL: http://llvm.org/viewvc/llvm-project?rev=309569&view=rev > Log: > Fix -Wshadow false positives with function-lo

Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

I think on Linux overload resolution was selecting 'DiagnosticBuilder&operator<<(DiagnosticBuilder&DB,int)' for you, which is probably not right anyway. I didn't find any tests for this diagnostic, so I couldn't fix it, and ended up reverting the change in r310661. On Thu, Aug 10, 2017 at 12:15 PM

[clang-tools-extra] r310661 - Revert "[clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module."

Author: rnk Date: Thu Aug 10 14:21:15 2017 New Revision: 310661 URL: http://llvm.org/viewvc/llvm-project?rev=310661&view=rev Log: Revert "[clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module." This reverts commit r310630. The new code broke on Windows

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

hamzasood added inline comments. Comment at: test/FixIt/fixit-cxx0x.cpp:57 (void)[&, &i, &i]{}; // expected-error 2{{'&' cannot precede a capture when the capture default is '&'}} - (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be explicitly captured}}

Re: r310576 - [Lexer] Finding beginning of token with escaped new line

On 10 August 2017 at 03:06, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Thu Aug 10 03:06:16 2017 > New Revision: 310576 > > URL: http://llvm.org/viewvc/llvm-project?rev=310576&view=rev > Log: > [Lexer] Finding beginning of token with escaped ne

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

rjmccall added inline comments. Comment at: test/FixIt/fixit-cxx0x.cpp:57 (void)[&, &i, &i]{}; // expected-error 2{{'&' cannot precede a capture when the capture default is '&'}} - (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be explicitly captured}}

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

jyknight added a comment. In https://reviews.llvm.org/D34158#838454, @mibintc wrote: > This patch is responding to @jyknight 's concern about preprocessed input. > The patch as it stands doesn't have this issue. I added 2 test cases, one > using option -x cpp-output, and another for a source fi

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

+klimek@ who contributed the first version of clang-fuzzer. We now have clang-proto-fuzzer (see tools/clang/tools/clang-fuzzer/README.txt) which shares code with clang-fuzzer, but which also depends on various packages (protobufs, in particular). clang-proto-fuzzer is off by default (requires a cma

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Sounds good to me. > > Richard, what do you think? > > On Thu, Aug 10, 2017 at 9:38 AM, Bruno Cardoso Lopes > wrote: > > Hi Hans, can we please get this merged into 5.0? > > > > Thanks, > > > > On Thu

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

hamzasood added inline comments. Comment at: test/FixIt/fixit-cxx0x.cpp:57 (void)[&, &i, &i]{}; // expected-error 2{{'&' cannot precede a capture when the capture default is '&'}} - (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be explicitly captured}}

[PATCH] D35449: [X86] Implement __builtin_cpu_is

This revision was automatically updated to reflect the committed changes. Closed by commit rL310657: [X86] Implement __builtin_cpu_is (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D35449?vs=106751&id=110629#toc Repository: rL LLVM https://reviews.llvm.org/D35449

r310657 - [X86] Implement __builtin_cpu_is

Author: ctopper Date: Thu Aug 10 13:28:30 2017 New Revision: 310657 URL: http://llvm.org/viewvc/llvm-project?rev=310657&view=rev Log: [X86] Implement __builtin_cpu_is This patch adds support for __builtin_cpu_is. I've tried to match the strings supported to the latest version of gcc. Differenti

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 110627. mibintc added a comment. This patch is responding to @jyknight 's concern about preprocessed input. The patch as it stands doesn't have this issue. I added 2 test cases, one using option -x cpp-output, and another for a source file suffixed with .i

[PATCH] D36572: Implemented P0409R2 - Allow lambda capture [=, this]

rjmccall added inline comments. Comment at: test/FixIt/fixit-cxx0x.cpp:57 (void)[&, &i, &i]{}; // expected-error 2{{'&' cannot precede a capture when the capture default is '&'}} - (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be explicitly captured}}

[PATCH] D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, more publicity means that more shells will make use of it. https://reviews.llvm.org/D36567 ___ cfe-commits mailing list cfe-commits@l

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

On Thu, Aug 10, 2017 at 3:13 PM, Kostya Serebryany wrote: > > > On Thu, Aug 10, 2017 at 12:01 PM, Nico Weber wrote: > >> On Thu, Aug 10, 2017 at 2:04 PM, Kostya Serebryany >> wrote: >> >>> >>> >>> On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber via cfe-commits < >>> cfe-commits@lists.llvm.org> wro

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

mzolotukhin added a comment. FWIW, I strongly support the idea of adding more detailed timers into the frontend. Thanks for working on it! I probably won't be very helpful in reviewing this code, but I'd appreciate if you CC me in the future patches. Thanks, Michael https://reviews.llvm.org/D

Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

Yes. Sorry for the broken. But it works well in my Linux machine. Maybe I should revert it first. Thanks, Yan Wang On Thu, Aug 10, 2017 at 12:07 PM, Nico Weber wrote: > Not sure if you've seen it, this broke the Windows build: > http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/ > builds/5

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

On Thu, Aug 10, 2017 at 12:01 PM, Nico Weber wrote: > On Thu, Aug 10, 2017 at 2:04 PM, Kostya Serebryany wrote: > >> >> >> On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> I really believe this has way too many deps to live in the clang

Re: [clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

Not sure if you've seen it, this broke the Windows build: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/5880/steps/build%20stage%201/logs/stdio FAILED: C:\PROGRA~2\MICROS~3.0\VC\bin\amd64\cl.exe /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_N

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:14024 + + if (OldFT->hasExtParameterInfos()) +for (unsigned I = 0, E = OldFT->getNumParams(); I != E; ++I) ahatanak wrote: > rjmccall wrote: > > I think we generally encourage the uses of b

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

On Thu, Aug 10, 2017 at 2:04 PM, Kostya Serebryany wrote: > > > On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I really believe this has way too many deps to live in the clang repro, >> as said on the review already. >> > > I don't have a

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 110617. JonasToth added a comment. [Misc] remove unneccessary stuff https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/OwningMe

r310649 - Enable bunch of sanitizers on NetBSD/X86 and X86_64

Author: kamil Date: Thu Aug 10 11:53:52 2017 New Revision: 310649 URL: http://llvm.org/viewvc/llvm-project?rev=310649&view=rev Log: Enable bunch of sanitizers on NetBSD/X86 and X86_64 Summary: Enable more sanitizers: - i386 and amd64: * SanitizerKind::Vptr; * SanitizerKind::Leak; * SanitizerK

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2700 + if (FD->getParamDecl(I)->hasAttr()) +Out << "U8noescape"; } rjmccall wrote: > This is not the right place to do this: > > * It needs to be mangled in function types, n

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

ahatanak updated this revision to Diff 110612. ahatanak marked 6 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D32210 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/Di

[clang-tools-extra] r310643 - [clang-tidy] Fix a buildbot.

Author: yawanng Date: Thu Aug 10 11:19:40 2017 New Revision: 310643 URL: http://llvm.org/viewvc/llvm-project?rev=310643&view=rev Log: [clang-tidy] Fix a buildbot. Fix format in ReleaseNotes.rst. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I really believe this has way too many deps to live in the clang repro, as > said on the review already. > I don't have a very strong opinion here and would be happy to move if I see more support f

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

+ Kostya The project isn't built by default, so the dependencies aren't needed unless you build the fuzzer specifically. On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber wrote: > I really believe this has way too many deps to live in the clang repro, as > said on the review already. Maybe this coul

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838305, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#838219, @gtbercea wrote: > > > In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > > > > > The failures were very widespread, e.g. there's a linux buildbot that

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

I really believe this has way too many deps to live in the clang repro, as said on the review already. Maybe this could live in clang-extra instead? On Aug 8, 2017 4:15 PM, "Matt Morehouse via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: morehouse > Date: Tue Aug 8 13:15:04 2017 >

r310640 - Disabling openmp-offload.c on linux until it is stabilized on all local configurations.

Author: alekseyshl Date: Thu Aug 10 10:55:01 2017 New Revision: 310640 URL: http://llvm.org/viewvc/llvm-project?rev=310640&view=rev Log: Disabling openmp-offload.c on linux until it is stabilized on all local configurations. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/tru

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838219, @gtbercea wrote: > In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > > > The failures were very widespread, e.g. there's a linux buildbot that was > > red until the revert: http://bb.pgr.jp/builders/test-clang-i68

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

joerg added a comment. In https://reviews.llvm.org/D34158#837444, @jyknight wrote: > Now, the "/tmp/foo-XXX.sh" also has a line labeled "Driver args: " with the > original command-line on it. If I understand correctly, you then like to take > this > simpler Driver command-line, and edit it man

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

joerg added a comment. In https://reviews.llvm.org/D34158#837281, @hfinkel wrote: > In https://reviews.llvm.org/D34158#837130, @joerg wrote: > > > In https://reviews.llvm.org/D34158#836026, @jyknight wrote: > > > > > In https://reviews.llvm.org/D34158#827178, @joerg wrote: > > > > > > > (2) It ad

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

Sounds good to me. Richard, what do you think? On Thu, Aug 10, 2017 at 9:38 AM, Bruno Cardoso Lopes wrote: > Hi Hans, can we please get this merged into 5.0? > > Thanks, > > On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits > wrote: >> Author: bruno >> Date: Thu Aug 10 08:16

[PATCH] D36185: [clang-diff] Fix similarity computation

arphaman added inline comments. Comment at: tools/clang-diff/ClangDiff.cpp:436 +else if (StopAfter != "bottomup") { + llvm::errs() << "Error: Invalid argument for -stop-after"; + return 1; Add a newline to the string as well. https://reviews.llvm.

[PATCH] D36184: [clang-diff] Filter AST nodes

johannes added inline comments. Comment at: test/Tooling/clang-diff-ast.cpp:68 +// nodes from other files are excluded +// CHECK-NOT {{.}} +#include "clang-diff-ast.cpp" arphaman wrote: > 1) Missing ':' > 2) What exactly does this regex accomplish? Right now it w

[PATCH] D36184: [clang-diff] Filter AST nodes

arphaman added inline comments. Comment at: test/Tooling/clang-diff-ast.cpp:68 +// nodes from other files are excluded +// CHECK-NOT {{.}} +#include "clang-diff-ast.cpp" 1) Missing ':' 2) What exactly does this regex accomplish? Right now it will match any chara

[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

johannes updated this revision to Diff 110608. johannes added a comment. initialize Node::Shift https://reviews.llvm.org/D36179 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-basic.cp

[clang-tools-extra] r310630 - [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

Author: yawanng Date: Thu Aug 10 10:18:10 2017 New Revision: 310630 URL: http://llvm.org/viewvc/llvm-project?rev=310630&view=rev Log: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module. Summary: 1. Refactor the structure of the code by adding a base

[PATCH] D36183: [clang-diff] Simplify mapping

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 110606. yawanng marked 3 inline comments as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/andr

[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:40 NodeId Parent, LeftMostDescendant, RightMostDescendant; - int Depth, Height; + int Depth, Height, Shift; ast_type_traits::DynTypedNode ASTNode; Looks like `Shift` isn't

[PATCH] D36531: [Parse] Document Parser::SkipFunctionBodies

This revision was automatically updated to reflect the committed changes. Closed by commit rL310627: [Parse] Document Parser::SkipFunctionBodies (authored by modocache). Repository: rL LLVM https://reviews.llvm.org/D36531 Files: cfe/trunk/include/clang/Parse/Parser.h Index: cfe/trunk/incl

r310627 - [Parse] Document Parser::SkipFunctionBodies

Author: modocache Date: Thu Aug 10 10:02:04 2017 New Revision: 310627 URL: http://llvm.org/viewvc/llvm-project?rev=310627&view=rev Log: [Parse] Document Parser::SkipFunctionBodies Reviewers: erikjv, doug.gregor Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D36531 Mod

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#838185, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > > > First of all, I apologize if I've upset you with my previous post. I am > > actively working on understanding what is causing these issues.

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann updated this revision to Diff 110602. euhlmann edited the summary of this revision. euhlmann added a comment. The patch now uses `PPBranchLevel` to track indent level. It allows `PPBranchLevel` to go back down to -1. The existing `PPBranchLevel >= 0` checks appear to prevent indexing in

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp:483-498 +void MagentaHandleChecker::checkPreStmt(const ReturnStmt *RS, +CheckerContext &Ctx) const { + ProgramStateRef State = Ctx.getState(); +

[PATCH] D36584: Implemented P0704R1 - Fixing const-qualified pointers to members

hamzasood created this revision. This patch provides an implementation for P0704R1 . I also made it work pre-C++2a as an extension (with a warning) since that's how Clang seems to deal with small additions like this. Hopefully someone more knowledgable on the matter ca

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. I've traced the output across all the reverted commits: F5233517: testFailures.md Note that after r310549 the last 9 RUN lines started failing because of the same crash: clang version 6.0.0 (http://llvm.org/git/llvm.git 00708415

[PATCH] D36563: Add a getName accessor for ModuleMacros

bob.wilson added a comment. Committed in r310622 https://reviews.llvm.org/D36563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310622 - Add a getName accessor for ModuleMacros.

Author: bwilson Date: Thu Aug 10 09:42:46 2017 New Revision: 310622 URL: http://llvm.org/viewvc/llvm-project?rev=310622&view=rev Log: Add a getName accessor for ModuleMacros. Swift would like to be able to access the name of a ModuleMacro. There was some discussion of this in https://github.com/a

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

Hi Hans, can we please get this merged into 5.0? Thanks, On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Thu Aug 10 08:16:24 2017 > New Revision: 310605 > > URL: http://llvm.org/viewvc/llvm-project?rev=310605&view=rev > Log: > [Modules] Preven

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > The failures were very widespread, e.g. there's a linux buildbot that was red > until the revert: http://bb.pgr.jp/builders/test-clang-i686-linux-RA. If you > have access to a linux machine you should be abl

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

jtbandes added a comment. @gtbercea Hi, I just saw your comment on my gist. (Unfortunately github does not send email notifications about gist comments; commenting here is probably better.) If you have Docker installed, it should be easy to get whatever output you like — just change the Dockerf

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310618: Fixed a race condition in PrecompiledPreamble. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D36529 Files: cfe/trunk/lib/Frontend/PrecompiledPreamble.cpp Index: cfe

  1   2   >