[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

atanasyan added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5979-5981 +if (S.Context.getTargetInfo().getABI() != "o32") + S.Diag(Attr.getLoc(), diag::err_attribute_supported_by_o32) + << Attr.getName() << D->getLocation(); aaron.ballm

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Out of curiosity: how did you detect this? Can we use the same approach for writing tests? https://reviews.llvm.org/D36259 ___ cfe-commits mailing

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

weimingz added a comment. I tried to address it via checking pre-defined macros: https://reviews.llvm.org/D31573 As long as the macros are defined correctly by clang, we don't need to worry about the specific target machine. How do you think about it? Repository: rL LLVM https://reviews.llv

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rjmccall added inline comments. Comment at: lib/CodeGen/CGCXXABI.cpp:43 if (RD->hasNonTrivialDestructor()) return false; v.g.vassilev wrote: > rjmccall wrote: > > Does canPassInRegisters() not subsume all of these earlier checks? > No, if I remove them

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added a comment. The patch generally looks good, but if you need to handle non-constant scopes, you should submit a new patch to address that. Comment at: lib/CodeGen/CGAtomic.cpp:896 +return V; + auto DestAS = getContext().getTargetAddressSpace(LangAS::o

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

yaxunl created this revision. OpenCL spec v2.0 s6.13.6: gentype select (gentype a, gentype b, igentype c) gentype select (gentype a, gentype b, ugentype c) igentype and ugentype must have the same number of elements and bits as gentype. https://reviews.llvm.org/D36259 Files: lib/Headers/op

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

phosek updated this revision to Diff 109485. Repository: rL LLVM https://reviews.llvm.org/D35820 Files: include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp Index: lib/Driver/ToolChain.cpp === --

[libcxx] r309920 - Fix libcxx build with glibc 2.26+ by removing xlocale.h include.

Author: ericwf Date: Wed Aug 2 21:28:10 2017 New Revision: 309920 URL: http://llvm.org/viewvc/llvm-project?rev=309920&view=rev Log: Fix libcxx build with glibc 2.26+ by removing xlocale.h include. Patch by Khem Raj. Reviewed as D35697. Also see PR33729. Modified: libcxx/trunk/include/__loc

Buildmaster restart

Hello everyone, LLVM buildmaster will be updated and restarted approximately at 08:00 AM PDT 4th August. -- Best Regards, Victor Leschuk | Software Engineer |Access Softek ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

t-tye added inline comments. Comment at: include/clang/Basic/SyncScope.h:23 +enum class SyncScope { + OpenCLWorkItem = 0, + OpenCLWorkGroup = 1, The OpenCL workitem scope is only used for image fences and does not apply to atomic operations so not sure that it

[libcxx] r309917 - Add system header pragma to BSD locale fallback headers.

Author: ericwf Date: Wed Aug 2 19:50:43 2017 New Revision: 309917 URL: http://llvm.org/viewvc/llvm-project?rev=309917&view=rev Log: Add system header pragma to BSD locale fallback headers. This prevent leaking warnings to the user about use of C++11 extensions in C++03. Modified: libcxx/tru

r309912 - Update for llvm change.

Author: rafael Date: Wed Aug 2 19:16:28 2017 New Revision: 309912 URL: http://llvm.org/viewvc/llvm-project?rev=309912&view=rev Log: Update for llvm change. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL: http://llvm.org/viewvc/llvm-proje

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek accepted this revision. phosek added a comment. LGTM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36252: [diagtool] Add ability to get name from id

hintonda updated this revision to Diff 109472. hintonda added a comment. - Use cat|xargs which should work on window -- used in other tests. https://reviews.llvm.org/D36252 Files: test/Misc/find-diagnostic-id.c tools/diagtool/FindDiagnosticID.cpp Index: tools/diagtool/FindDiagnosticID.cpp

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rL LLVM https://reviews.llvm.org/D36250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D36253: [Sema] Add a comment on an identified bug on default arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309908: [Sema] Add a comment on an identified bug on default arguments. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D36253?vs=109461&id=109464#toc Repository: rL LLVM ht

r309908 - [Sema] Add a comment on an identified bug on default arguments.

Author: timshen Date: Wed Aug 2 17:18:11 2017 New Revision: 309908 URL: http://llvm.org/viewvc/llvm-project?rev=309908&view=rev Log: [Sema] Add a comment on an identified bug on default arguments. Summary: The mis-compile is triggered by internal code, but I haven't reduced it to a small piece

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

mcgrathr created this revision. The .gnu_hash format is superior, and all versions of the Fuchsia dynamic linker support it. Repository: rL LLVM https://reviews.llvm.org/D36254 Files: lib/Driver/ToolChains/Fuchsia.cpp Index: lib/Driver/ToolChains/Fuchsia.cpp =

[PATCH] D36253: [Sema] Add a comment on an identified bug on default arguments.

timshen created this revision. Herald added a subscriber: sanjoy. The mis-compile is triggered by internal code, but I haven't reduced it to a small piece of code. Add a FIXME here, since a decent fix doesn't seem to be trivial. The decent fix can be changing Decl::Init to PointerUnion, and mak

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This patch will suppress handle leak warnings if the path of a bug reported by MagentaHandleChecker will reach a no return function or will reach the end of main function. As these two scenarios mean program crash and the leaked

[PATCH] D35863: Use the allocator's pointers for deallocation in `std::list`

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. First, this patch would need tests before continuing, Could you please them? The list tests live under `test/std/containers/sequences/list`. Let me know if you have any questions or

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

efriedma created this revision. The code after a noreturn call doesn't execute. The pattern in the testcase is pretty common in LLVM (a switch with a default case that calls llvm_unreachable). Repository: rL LLVM https://reviews.llvm.org/D36250 Files: lib/CodeGen/CoverageMappingGen.cpp

r309901 - [coverage] Make smaller regions for the first case of a switch.

Author: efriedma Date: Wed Aug 2 16:22:50 2017 New Revision: 309901 URL: http://llvm.org/viewvc/llvm-project?rev=309901&view=rev Log: [coverage] Make smaller regions for the first case of a switch. We never overwrite the end location of a region, so we would end up with an overly large region wh

[PATCH] D34801: [coverage] Make smaller regions for the first case of a switch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309901: [coverage] Make smaller regions for the first case of a switch. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D34801?vs=104581&id=109456#toc Repository: rL LLVM h

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

saugustine created this revision. These tests assume intel-80 bit floats, as noted in their comments. Rather than having each target discover the incompatibility and disable them ad-hoc, mark them as requiring x86. Repository: rL LLVM https://reviews.llvm.org/D36249 Files: compiler-rt/te

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Hmm. So the documentation is wrong, but not "fully wrong". If you simply try applying this patch and compiling with GCC you'll still encounter a bunch of instances of `warning: type

Re: r308996 - [coroutines] Add serialization/deserialization of coroutines

On 31 July 2017 at 09:11, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Richard, Gor asked for this to be merged to 5.0. What do you think? Sounds good to me. On Tue, Jul 25, 2017 at 11:01 AM, Gor Nishanov via cfe-commits > wrote: > > Author: gornishanov > > Date: Tue Ju

[PATCH] D34212: docs: Document binary compatibility issue due to bug in gcc

tstellar updated this revision to Diff 109438. tstellar added a comment. Add links to index.rst and UsersManual.rst, and fix link to bug. https://reviews.llvm.org/D34212 Files: docs/BinaryCompatibilityWithOtherCompilers.rst docs/UsersManual.rst docs/index.rst Index: docs/index.rst =

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar added a comment. Ping.u1 https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r309881 - Rename a couple variables to eliminate a shadow warning. No functionality change

Instead of creating two variables, wouldn't it be better to just remove the second definition and clear m_ec? You don't need to use both error codes side by side, as the second usage of m_ec occurs after the first one is finished. So you could remove the second definition and call clear() on it, to

r309888 - Remove unused diagnostic. NFC.

Author: d0k Date: Wed Aug 2 14:16:50 2017 New Revision: 309888 URL: http://llvm.org/viewvc/llvm-project?rev=309888&view=rev Log: Remove unused diagnostic. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td URL

[PATCH] D36186: [clang-diff] Improve and test getNodeValue

johannes added inline comments. Comment at: test/Tooling/clang-diff-ast.cpp:32 + +// CHECK: TypedefDecl: nat;unsigned int;( +typedef unsigned nat; klimek wrote: > For my curiosity: why are there semicolons here? Is the format documented > somewhere? To avoid col

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added inline comments. Comment at: lib/CodeGen/CGCXXABI.cpp:43 if (RD->hasNonTrivialDestructor()) return false; rjmccall wrote: > Does canPassInRegisters() not subsume all of these earlier checks? No, if I remove them here I get a lot of te

[PATCH] D36185: [clang-diff] Fix similarity computation

johannes added inline comments. Comment at: test/Tooling/clang-diff-bottomup.cpp:3 +// RUN: %clang_cc1 -E %s > %t.dst.cpp -DDEST +// RUN: clang-diff -m -no-compilation-database -s=0 %t.src.cpp %t.dst.cpp | FileCheck %s +// klimek wrote: > Instead of using -no-co

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr updated this revision to Diff 109428. mcgrathr added a comment. Added tests. https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c =

[PATCH] D36184: [clang-diff] Filter AST nodes

johannes added a comment. In https://reviews.llvm.org/D36184#828866, @klimek wrote: > Why? Also, missing tests. implicit nodes are noisy / they generally don't add information; I guess one could also keep them. I excluded nodes outside of the main file are because the visualisation only work

[PATCH] D34512: Add preliminary Cross Translation Unit support library

rsmith added a comment. Organizationally, this seems fine. Carry on :) Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:229-231 +def err_fnmap_parsing : Error< + "error parsing CrossTU index file: '%0' line: %1 'USR filename' format " + "expected">;

[PATCH] D36177: [clang-diff] Add commandline arguments.

johannes added a comment. In https://reviews.llvm.org/D36177#828909, @arphaman wrote: > There should be a test that ensures that `stop-after` works and `extra-arg`s > are correctly passed to the compiler. `stop-after` is not tested yet. It is also broken in this patch, I will move it to a lat

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

johannes added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96 : TreeImpl(llvm::make_unique(this, Node, AST)) {} + SyntaxTree(const SyntaxTree &Tree) = delete; ~SyntaxTree(); arphaman wrote: > johannes wrote: > > arphaman wrote:

[PATCH] D36186: [clang-diff] Improve and test getNodeValue

johannes updated this revision to Diff 109426. johannes added a comment. renamse, NFC https://reviews.llvm.org/D36186 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-dif

[PATCH] D36186: [clang-diff] Improve and test getNodeValue

johannes updated this revision to Diff 109425. johannes added a comment. NFC renames https://reviews.llvm.org/D36186 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff

[PATCH] D36185: [clang-diff] Fix similarity computation

johannes updated this revision to Diff 109424. johannes added a comment. add test for Options.MaxSize https://reviews.llvm.org/D36185 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-bottomup.cpp test/Tooling/clang-diff-opt.cpp tes

[PATCH] D36184: [clang-diff] Filter AST nodes

johannes updated this revision to Diff 109423. johannes added a comment. tests https://reviews.llvm.org/D36184 Files: lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-ast.cpp Index: test/Tooling/clang-diff-ast.cpp === -

[PATCH] D36183: [clang-diff] Simplify mapping

johannes updated this revision to Diff 109422. johannes edited the summary of this revision. johannes added a comment. - https://reviews.llvm.org/D36183 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooli

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, but let's confirm with Richard before we change behavior. https://reviews.llvm.org/D36238 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D36182: [clang-diff] Add HTML side-by-side diff output

johannes updated this revision to Diff 109421. johannes added a comment. - https://reviews.llvm.org/D36182 Files: test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-html.py tools/clang-diff/CMakeLists.txt tools/clang-diff/ClangDiff.c

[PATCH] D36180: [clang-diff] Add option to dump the AST, one node per line

johannes updated this revision to Diff 109419. johannes added a comment. Herald added a subscriber: klimek. add a test https://reviews.llvm.org/D36180 Files: test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-json.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.

[PATCH] D36181: [clang-diff] Make printing of matches optional

johannes updated this revision to Diff 109420. johannes added a comment. rename to -dump-matches, add a test https://reviews.llvm.org/D36181 Files: test/Tooling/clang-diff-args.sh test/Tooling/clang-diff-basic.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

r309873 - [UBSan] Provide default blacklist filename for UBSan

Author: shenhan Date: Wed Aug 2 12:53:38 2017 New Revision: 309873 URL: http://llvm.org/viewvc/llvm-project?rev=309873&view=rev Log: [UBSan] Provide default blacklist filename for UBSan Summary: This is to provide a default blacklist filename for UBSan. While UBSan is turned on, it's better tha

[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

johannes updated this revision to Diff 109417. johannes added a comment. remove unused SubtreeIterator https://reviews.llvm.org/D36179 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-b

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes updated this revision to Diff 109416. johannes added a comment. getSourceRangeOffsets, test https://reviews.llvm.org/D36178 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-json.cpp tools/clang-diff/ClangDiff.cpp Index: too

[PATCH] D36177: [clang-diff] Add commandline arguments.

johannes updated this revision to Diff 109415. johannes added a comment. add some test, replace -no-compilation-database with -- https://reviews.llvm.org/D36177 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-args.sh test/Tooling/cl

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

thakis added a comment. We just noticed that if you call __builtin_available() for the first time after activating your app's sandbox, the function will fail: SandboxViolation: crdmg(15489) deny file-read-data /System/Library/CoreServices/SystemVersion.plist Violation: deny file-read-data

r309885 - Update for llvm change.

Author: rafael Date: Wed Aug 2 13:32:35 2017 New Revision: 309885 URL: http://llvm.org/viewvc/llvm-project?rev=309885&view=rev Log: Update for llvm change. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

johannes updated this revision to Diff 109414. johannes added a comment. move most functional changes to other commits move constructor for Syntaxtree https://reviews.llvm.org/D36176 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 109406. yaxunl marked 29 inline comments as done. yaxunl added a comment. Revised by reviewers' comments. https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/Basic/Builtins.def include/clang/Basic

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

thakis created this revision. This helps some tools that do things based on the output's extension. For example, we got reports from users on Windows that have a tool that scan a build output dir (but skip .obj files). The tool would keep the "foo.obj-12345" file open, and then when clang tried

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

jmgao updated this revision to Diff 109412. jmgao added a comment. Fix commit messages. https://reviews.llvm.org/D36237 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp test/Sema/attr-capabilities.c

[libcxx] r309881 - Rename a couple variables to eliminate a shadow warning. No functionality change

Author: marshall Date: Wed Aug 2 13:29:26 2017 New Revision: 309881 URL: http://llvm.org/viewvc/llvm-project?rev=309881&view=rev Log: Rename a couple variables to eliminate a shadow warning. No functionality change Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified:

[PATCH] D36237: Reland "Thread Safety Analysis: fix assert_capability.", add warnings

jmgao updated this revision to Diff 109411. jmgao added a comment. Remove accidental trailing backslash. https://reviews.llvm.org/D36237 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp test/Sema/attr

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:383 + Current.Previous->is(tok::hash) && State.FirstIndent > 0) { +// subtract 1 so indent lines up with non-preprocessor code +Spaces += State.FirstIndent; djasper wrote

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek added a comment. One more thing, would it be possible add a test case to `test/Driver/fuchsia.c` covering this? Repository: rL LLVM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r309852 - [docs] Remove accidental unindent to appease the sphinx bot

Author: vedantk Date: Wed Aug 2 11:24:12 2017 New Revision: 309852 URL: http://llvm.org/viewvc/llvm-project?rev=309852&view=rev Log: [docs] Remove accidental unindent to appease the sphinx bot Bot failure: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/12043/steps/docs-clang-html/log

[libcxx] r309851 - Fix shadowing warning

Author: marshall Date: Wed Aug 2 11:21:34 2017 New Revision: 309851 URL: http://llvm.org/viewvc/llvm-project?rev=309851&view=rev Log: Fix shadowing warning Modified: libcxx/trunk/test/std/input.output/string.streams/stringstream.cons/string.pass.cpp Modified: libcxx/trunk/test/std/input.o

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

This revision was automatically updated to reflect the committed changes. Closed by commit rL309846: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't… (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D36112?vs=108988&id=109385#toc Repository: rL

r309846 - [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

Author: vedantk Date: Wed Aug 2 11:10:31 2017 New Revision: 309846 URL: http://llvm.org/viewvc/llvm-project?rev=309846&view=rev Log: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I di

Re: r305903 - Function with unparsed body is a definition

At first thank you for the nice test case. This crash is not caused by r305903. The root cause is that instantiation of f is triggered when parse of f is not finished yet. This is the case just addressed by that change. The instantiation is requested by the code (https://github.com/llvm-mirro r/cl

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

vsk marked an inline comment as done. vsk added a comment. In https://reviews.llvm.org/D36112#828891, @arphaman wrote: > That makes sense. It's kinda weird not to report the `null`, but I guess it > makes sense if the `null` sanitiser is off. It is kinda weird, but any such diagnostic would fi

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

bruno added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:136 +if (ThreadPointer == ReadTPMode::Invalid && +!StringRef(A->getValue()).empty()) { + D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args); What happens if you pa

Re: r309523 - Also pass -pie back to the linker when linking on OpenBSD.

Merged to 5.0 in r309844. On Sun, Jul 30, 2017 at 2:14 PM, Brad Smith via cfe-commits wrote: > Author: brad > Date: Sun Jul 30 14:13:59 2017 > New Revision: 309523 > > URL: http://llvm.org/viewvc/llvm-project?rev=309523&view=rev > Log: > Also pass -pie back to the linker when linking on OpenBSD.

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

aaron.ballman added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1511 + StringRef Suff64 = "/64"; + // Solaris uses platform-specific suffixes instead of /64 + if (TargetTriple.getOS() == llvm::Triple::Solaris) { Add a period at the end of the co

[libcxx] r309838 - Fix PR33727: std::basic_stringbuf only works with DefaultConstructible allocators. Thanks to Jonathan Wakely for the report and suggested fix

Author: marshall Date: Wed Aug 2 10:31:09 2017 New Revision: 309838 URL: http://llvm.org/viewvc/llvm-project?rev=309838&view=rev Log: Fix PR33727: std::basic_stringbuf only works with DefaultConstructible allocators. Thanks to Jonathan Wakely for the report and suggested fix Modified: libcx

[PATCH] D36230: [X86][Asm] Allow negative immediate to appear before bracketed expression

coby created this revision. Herald added a subscriber: eraman. Currently, only non-negative immediate is allowed prior to a brac expression (memory reference). MASM / GAS does not have any problem cope with the left side of the real line, so we should be able to as well. llvm: https://reviews.l

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33672#827513, @xazax.hun wrote: > Even though it is not undefined behavior in C, it can still cause surprising > behavior for the users. I think maybe putting it into the optin package > instead of cplusplus is better. What do you thin

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

aaron.ballman added inline comments. Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 + memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()), + varDecl(hasStaticStorageDuration(, +

[PATCH] D36044: [OpenCL] -cl-ext option can overwrite OpenCL features imported from a module

Anastasia added inline comments. Comment at: include/clang/Basic/OpenCLOptions.h:132 - void disableAll() { + void enableAll(bool On = true) { for (llvm::StringMap::iterator I = OptMap.begin(), May be the name could be `setAll` since it's doing both enabl

[PATCH] D36200: [Sema] Improve some -Wunguarded-availability diagnostic messages

arphaman added a comment. Right, sorry, I didn't realize that code was moved. https://reviews.llvm.org/D36200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36200: [Sema] Improve some -Wunguarded-availability diagnostic messages

erik.pilkington added a comment. In https://reviews.llvm.org/D36200#829104, @arphaman wrote: > This needs a test for the fixits as well, see test/FixIt/fixit-availability* Why? This patch doesn't change the behavior of the fixits, so there isn't any new behavior to test. https://reviews.llvm

[PATCH] D33676: Place implictly declared functions at block scope

chill added a comment. Thanks for the review, I'll wait a few days. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 109366. chill added a comment. Updated with only whitespace changes after formating each changed line with clang-format. https://reviews.llvm.org/D33676 Files: include/clang/Sema/Scope.h lib/Parse/ParseCXXInlineMethods.cpp lib/Parse/ParseDecl.cpp lib

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov added a comment. Also tested by temporarily replacing `getRealFileSystem()` body with `return createThreadFriendlyRealFS();` and running `check-all`, all tests passed. To be more specific, there was one crash in clang-format, as there is a piece of code that uses raw pointer from `

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov created this revision. Allows to have multiple instances of RealFileSystem that have different working directories. https://reviews.llvm.org/D36226 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index

[PATCH] D33676: Place implictly declared functions at block scope

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks reasonable to me, once it's been formatted. Let's give @rsmith a few days to comment before committing, though. https://reviews.llvm.org/D33676 ___

Re: [PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

Should clang warn if you request static libc++ on fuchsia? It now silently ignores the flag, right? On Aug 1, 2017 9:18 PM, "Petr Hosek via Phabricator via cfe-commits" < cfe-commits@lists.llvm.org> wrote: This revision was automatically updated to reflect the committed changes. Closed by commit

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

thakis added a comment. Awesome, thanks! Maybe mention the PR# for this in the commit message. https://reviews.llvm.org/D36191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Lab is down

Buildbot is up and running. Sorry for the delay. On 08/02/2017 06:31 PM, Victor Leschuk wrote: > Hello all, buildbot is currently down due to hardware failure. We are > currently working on it. Sorry for the inconvenience. > -- Best Regards, Victor _

Re: Lab is down

There is power outage in the area where the servers are located. They say the power will be restored at 10:45 AM PDT, I'd estimate buildbot online time about ~12:00. On 08/02/2017 06:31 PM, Victor Leschuk wrote: > Hello all, buildbot is currently down due to hardware failure. We are > currently w

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. @Nebiroth I think it's OK to put this on hold until we make the "semantic" hover and figure out how to have both. From our perspective, this is going beyond parity of what we had before but it's seems like the right thing to do. https://reviews.llvm.org/D35894 ___

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. In https://reviews.llvm.org/D35894#829109, @ilya-biryukov wrote: > > I think all of those would be great. Our objective is to bring basic but > > correct features that will put us close to parity with Eclipse CDT, so that > > our users can transition. In CDT only the

Lab is down

Hello all, buildbot is currently down due to hardware failure. We are currently working on it. Sorry for the inconvenience. -- Best Regards, Victor ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522 // to be re-used for method bodies as well. - ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope); + ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope| +

[PATCH] D31814: Add option to add command-line options and version info to output file

christof commandeered this revision. christof added a reviewer: salari01. christof added a comment. Herald added a subscriber: aheejin. With the ok of the author, I'll try to get some movement on this work again. https://reviews.llvm.org/D31814 ___

[libclc] r309820 - configure.py: Make python3 friendly

Author: jvesely Date: Wed Aug 2 08:00:59 2017 New Revision: 309820 URL: http://llvm.org/viewvc/llvm-project?rev=309820&view=rev Log: configure.py: Make python3 friendly mostly prints and exceptions. Few behavioral changes are documented in the text Generated Makefile is identical between python2

[PATCH] D35894: [clangd] Code hover for Clangd

ilya-biryukov added a comment. > I think all of those would be great. Our objective is to bring basic but > correct features that will put us close to parity with Eclipse CDT, so that > our users can transition. In CDT only the "raw" source is shown, similar to > this patch (except in CDT it at

[PATCH] D36200: [Sema] Improve some -Wunguarded-availability diagnostic messages

arphaman added a comment. This needs a test for the fixits as well, see test/FixIt/fixit-availability* https://reviews.llvm.org/D36200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309815 - Define _GNU_SOURCE for RTEMS c++

Author: waltl Date: Wed Aug 2 07:36:52 2017 New Revision: 309815 URL: http://llvm.org/viewvc/llvm-project?rev=309815&view=rev Log: Define _GNU_SOURCE for RTEMS c++ Summary: This is required by the libc++ locale support. Reviewers: jyknight Subscribers: fedor.sergeev Differential Revision: htt

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

hintonda added a comment. In https://reviews.llvm.org/D36083#827745, @arphaman wrote: > Makes sense. I'll see if I can get somewhere with the regex idea. Btw, I created a quick prototype with sed and found that the diag strings aren't unique -- which isn't surprising since there's no requireme

[PATCH] D33676: Place implictly declared functions at block scope

aaron.ballman added inline comments. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522 // to be re-used for method bodies as well. - ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope); + ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope| +

r309813 - [rename] NFC, extract symbol canonicalization logic into function

Author: arphaman Date: Wed Aug 2 07:15:27 2017 New Revision: 309813 URL: http://llvm.org/viewvc/llvm-project?rev=309813&view=rev Log: [rename] NFC, extract symbol canonicalization logic into function This function will be used by the clang-refactor's rename actions Modified: cfe/trunk/inclu

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. In https://reviews.llvm.org/D35894#828702, @ilya-biryukov wrote: > I just wanted to take a step back and discuss what we want to get from code > hover in the first place. > > I would expect a typical code hover to be a bit more involved and include: > > - "kind" of a s

  1   2   >