smeenai created this revision.
Under Windows Itanium, we need to export virtual and non-virtual thunks
if the functions being thunked are exported. These thunks would
previously inherit their dllexport attribute from the declaration, but
r298330 changed declarations to not have dllexport attribute
Author: smeenai
Date: Mon Jul 3 18:02:19 2017
New Revision: 307052
URL: http://llvm.org/viewvc/llvm-project?rev=307052&view=rev
Log:
[CodeGen] Check key function for typeinfo import
If the imported class does not have a key function, we should emit its
typeinfo locally instead of attempting to i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307051: [Sema] Make BreakContinueFinder handle nested loops.
(authored by efriedma).
Changed prior to commit:
https://reviews.llvm.org/D34568?vs=103761&id=105128#toc
Repository:
rL LLVM
https://revi
Author: efriedma
Date: Mon Jul 3 17:52:24 2017
New Revision: 307051
URL: http://llvm.org/viewvc/llvm-project?rev=307051&view=rev
Log:
[Sema] Make BreakContinueFinder handle nested loops.
We don't care about break or continue statements that aren't
associated with the current loop, so make sure t
dcoughlin added a comment.
This looks good! You will need to add tests though. I would suggest adding them
to "test/Analysis/retain-release-inline.m"
Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:1898
+bool
+isAnnotatedToSkipDiagnostics(const LocationContext *
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/Driver.cpp:1236
+// We want to show cc1-only options only when clang is invoked as "clang
-cc1".
+// When clang is invoked as "c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307045: [clang] Implement -Wcast-qual for C++ (authored by
lebedevri).
Changed prior to commit:
https://reviews.llvm.org/D33102?vs=105103&id=105108#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: lebedevri
Date: Mon Jul 3 10:59:22 2017
New Revision: 307045
URL: http://llvm.org/viewvc/llvm-project?rev=307045&view=rev
Log:
[clang] Implement -Wcast-qual for C++
Summary:
This way, the behavior of that warning flag
more closely resembles that of GCC.
Do note that there is at least on
johannes added a comment.
In https://reviews.llvm.org/D34329#798377, @arphaman wrote:
> @johannes
> Are you planning to work on integration with the `StmtDataCollector` in this
> patch or would you prefer to follow-up with additional patches?
Later would be better
https://reviews.llvm.org/
lebedev.ri updated this revision to Diff 105103.
lebedev.ri added a comment.
Rebased before commit.
Repository:
rL LLVM
https://reviews.llvm.org/D33102
Files:
docs/ReleaseNotes.rst
lib/Sema/SemaCast.cpp
test/Sema/warn-cast-qual.c
test/SemaCXX/warn-cast-qual.cpp
Index: test/SemaCXX/w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307040: [clang-tidy] Resolve
cppcoreguidelines-pro-type-member-init false positive (authored by
JDevlieghere).
Changed prior to commit:
https://reviews.llvm.org/D34932?vs=105023&id=105102#toc
Reposito
Author: jdevlieghere
Date: Mon Jul 3 09:46:46 2017
New Revision: 307040
URL: http://llvm.org/viewvc/llvm-project?rev=307040&view=rev
Log:
[clang-tidy] Resolve cppcoreguidelines-pro-type-member-init false positive
Summary: https://bugs.llvm.org/show_bug.cgi?id=33557
Reviewers: Eugene.Zelenko, al
arphaman added a comment.
@johannes
Are you planning to work on integration with the `StmtDataCollector` in this
patch or would you prefer to follow-up with additional patches?
https://reviews.llvm.org/D34329
___
cfe-commits mailing list
cfe-commi
jordan_rose requested changes to this revision.
jordan_rose added a comment.
This revision now requires changes to proceed.
If I'm remembering correctly from when I set this up, this isn't just about
detecting which version control system you're using; it's about finding a file
//that will chang
joey added a comment.
In https://reviews.llvm.org/D34948#798332, @bader wrote:
> LGTM.
> Do you have another built-in in mind which can use this diagnostic message?
> If so, it would make sense to re-use it in the same patch.
This is split off from https://reviews.llvm.org/D33945, which I wil
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Do you have another built-in in mind which can use this diagnostic message?
If so, it would make sense to re-use it in the same patch.
https://reviews.llvm.org/D34948
__
modocache created this revision.
Herald added a subscriber: mgorny.
When searching for Git version control information, libBasic's CMake
checks for the path '.git/logs/HEAD'. However, when LLVM is included as
a Git submodule, this path does not exist. Instead, it contains a '.git'
file with the fo
arphaman updated this revision to Diff 105084.
arphaman added a comment.
Small fixup.
Repository:
rL LLVM
https://reviews.llvm.org/D34949
Files:
include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h
include/clang/Tooling/Refactoring/Rename/USRFinder.h
include/clang/module.modulema
Author: mprobst
Date: Mon Jul 3 08:31:28 2017
New Revision: 307034
URL: http://llvm.org/viewvc/llvm-project?rev=307034&view=rev
Log:
Revert "clang-format: [JS] space between pseudo keywords and template literals."
This reverts commit 71d3b5cd916106005ef23467e3f6c7fbca7bc499.
Modified:
cfe/t
arphaman added a comment.
This is meant to be NFC btw.
Repository:
rL LLVM
https://reviews.llvm.org/D34949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
- Use single `RecursiveSymbolVisitor` class for both `USRLocFindingASTVisitor`
and `NamedDeclOccurrenceFindingVisitor` to avoid duplicate visiting code.
- Traverse nested name specifier locs in the new class and remove the separate
matching step.
- New class `Name
vladimir.plyashkun updated this revision to Diff 105078.
vladimir.plyashkun added a comment.
Herald added a subscriber: JDevlieghere.
- fixed `No newline at end of file` problem
- provided test-case to check that diagnostics with no fixes will be applied
correctly
Repository:
rL LLVM
https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307029: [clang-format] Support text proto messages (authored
by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D34441
Files:
cfe/trunk/include/clang/Format/Format.h
cfe/trunk/lib/Format/C
Author: krasimir
Date: Mon Jul 3 08:05:14 2017
New Revision: 307029
URL: http://llvm.org/viewvc/llvm-project?rev=307029&view=rev
Log:
[clang-format] Support text proto messages
Summary: This patch adds support for textual protocol buffer messages.
Reviewers: djasper
Reviewed By: djasper
Subsc
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D34932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:452
if (Ctor) {
+if(Ctor->isImplicit())
+ return;
---
joey created this revision.
Herald added subscribers: Anastasia, yaxunl.
Refactor err_opencl_enqueue_kernel_expected_type so that other builtins can use
the same diagnostic.
https://reviews.llvm.org/D34948
Files:
Sema/SemaChecking.cpp
SemaOpenCL/cl20-device-side-enqueue.cl
clang/Basic/Di
Author: ibiryukov
Date: Mon Jul 3 07:46:03 2017
New Revision: 307025
URL: http://llvm.org/viewvc/llvm-project?rev=307025&view=rev
Log:
[clangd] Add -ffreestanding on VFS tests.
Summary:
They don't provide proper gcc installations and may fail on implicit
include.
Reviewers: klimek, krasimir, b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307025: [clangd] Add -ffreestanding on VFS tests. (authored
by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D34936
Files:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
Index
lebedev.ri added a comment.
Will land this shortly..
Repository:
rL LLVM
https://reviews.llvm.org/D33102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malhar1995 created this revision.
As part of my Google Summer of Code project, I am working on adding support for
Integer Set Library (ISL) annotations to the current RetainCountChecker.
Hence, to begin with, Dr. Devin Coughlin gave me a task to suppress reference
counting diagnostics for all IS
This revision was automatically updated to reflect the committed changes.
arphaman marked an inline comment as done.
Closed by commit rL307014: Add a fixit for -Wobjc-protocol-property-synthesis
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D34886?vs=104859&id=105069
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:107
+ if (Style.Language == FormatStyle::LK_TextProto) {
+State.Stack.back().AvoidBinPacking = true;
djasper wrote:
> Do we need to set this explicitly here? Is it not enough t
johannes updated this revision to Diff 105059.
johannes edited the summary of this revision.
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
karies added a comment.
Two comments:
- I think the part `Val.getBitWidth() == 64` likely needs rewording, although I
don't know how
- I can show the motivation, not sure whether that qualifies as a test case:
$ echo 'template struct S{}; S<(unsigned long long)-1> s
= 42;' | clang++ -fsynta
xazax.hun updated this revision to Diff 105053.
xazax.hun added a comment.
- Patch scan-build instead of using custom scripts
- Rebase patch based on the proposed LibTooling CTU code
https://reviews.llvm.org/D30691
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/Sta
krasimir updated this revision to Diff 105044.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D34441
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/FormatT
ilya-biryukov added a comment.
Implicit `stdc-predef.h` include is not yet there, but will appear after
https://reviews.llvm.org/D34158 has landed.
https://reviews.llvm.org/D34936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: include/clang/Sema/Sema.h:3351
+ ObjCInterfaceDecl *IDecl, SourceRange
AtEnd);
+ void DefaultSynthesizeProperties(Scope *S, Decl *D, SourceRange AtEnd);
--
yvvan updated this revision to Diff 105045.
yvvan added a comment.
Add tests, append tests with default values. Move all default value handling to
GetDefaultValueString
https://reviews.llvm.org/D33644
Files:
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/functions.cpp
test/Index/code-
ilya-biryukov added a comment.
Here's a patch to fix ClangdTests: https://reviews.llvm.org/D34936
We should probably land it before your patch to avoid ClangdTests failures
between those llvm and clang-tools-extra revisions.
Repository:
rL LLVM
https://reviews.llvm.org/D34158
Hahnfeld added a comment.
In https://reviews.llvm.org/D34158#797170, @mibintc wrote:
> The other test that fails is my own new test! It fails because I don't know
> how to set it up so the test thinks it has a gcc toolchain with version >
> 4.8. I tried using gcc-toolchain set to various other
malhar1995 updated this revision to Diff 105043.
Repository:
rL LLVM
https://reviews.llvm.org/D34937
Files:
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
Index: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
===
--- li
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D34936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
ilya-biryukov created this revision.
They don't provide proper gcc installations and may fail on implicit
include.
https://reviews.llvm.org/D34936
Files:
unittests/clangd/ClangdTests.cpp
Index: unittests/clangd/ClangdTests.cpp
===
arphaman abandoned this revision.
arphaman added a comment.
Abandoning. The current behaviour makes sense. Thanks for the responses!
Repository:
rL LLVM
https://reviews.llvm.org/D34810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: mprobst
Date: Mon Jul 3 07:29:13 2017
New Revision: 307023
URL: http://llvm.org/viewvc/llvm-project?rev=307023&view=rev
Log:
clang-format: [JS] space between pseudo keywords and template literals.
Summary:
Before:
yield`foo`;
After:
yield `foo`;
Reviewers: djasper
Subscribers:
Author: arphaman
Date: Mon Jul 3 03:34:46 2017
New Revision: 307016
URL: http://llvm.org/viewvc/llvm-project?rev=307016&view=rev
Log:
[index] Remove 'implicit' role for message sends in implicit ObjC
property references
rdar://32375673
Modified:
cfe/trunk/lib/Index/IndexBody.cpp
cfe/tru
Author: arphaman
Date: Mon Jul 3 03:12:24 2017
New Revision: 307014
URL: http://llvm.org/viewvc/llvm-project?rev=307014&view=rev
Log:
Add a fixit for -Wobjc-protocol-property-synthesis
rdar://32132756
Differential Revision: https://reviews.llvm.org/D34886
Added:
cfe/trunk/test/FixIt/fixit-
Author: inouehrs
Date: Mon Jul 3 01:49:44 2017
New Revision: 307007
URL: http://llvm.org/viewvc/llvm-project?rev=307007&view=rev
Log:
fix trivial typos in comments; NFC
Modified:
cfe/trunk/bindings/python/clang/cindex.py
cfe/trunk/lib/CodeGen/CGBlocks.cpp
cfe/trunk/lib/CodeGen/CGCall
50 matches
Mail list logo
