[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache created this revision. Herald added a subscriber: fhahn. Depends on https://reviews.llvm.org/D34867. Add a Clang frontend option to enable optimization remark hotness thresholds, which were added to LLVM in https://reviews.llvm.org/D34867. This prevents diagnostics that do not meet a mi

[PATCH] D34865: [ORE] Use LLVM's "diagnostics hotness" spelling

modocache created this revision. Depends on https://reviews.llvm.org/D34864. To unify Clang and LLVM's spelling of "diagnostic[s] hotness", use the new "diagnostics hotness" spelling in LLVM, which was added in https://reviews.llvm.org/D34864. https://reviews.llvm.org/D34865 Files: lib/CodeG

r306790 - Add -no-canonical-prefixes to the test line so that we can handle different build modes.

Author: echristo Date: Thu Jun 29 23:03:47 2017 New Revision: 306790 URL: http://llvm.org/viewvc/llvm-project?rev=306790&view=rev Log: Add -no-canonical-prefixes to the test line so that we can handle different build modes. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trun

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Can you please double check the type of `long double` as well? Comment at: lib/Basic/Targets.cpp:6583 + +// This is an LLP64 paltform. +// int:4, long:4, long lon

r306789 - fix trivial typos, NFC

Author: inouehrs Date: Thu Jun 29 22:40:31 2017 New Revision: 306789 URL: http://llvm.org/viewvc/llvm-project?rev=306789&view=rev Log: fix trivial typos, NFC Modified: cfe/trunk/include/clang/Lex/PTHLexer.h cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Parse/ParseDeclCXX.cpp

[PATCH] D34529: [Driver] Check that the iOS deployment target is iOS 10 or earlier if the target is 32-bit

bob.wilson added a comment. The proposed error message does not provide any information about why the version is invalid. That could be confusing. Your comment in the code is more clear: "iOS 10 is the maximum deployment target for 32-bit targets". Can you say something like that in the error m

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

This revision was automatically updated to reflect the committed changes. Closed by commit rL306786: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's (authored by chandlerc). Repository: rL LLVM https://reviews.llvm.org/D34846 Files: cfe/trunk/include/clang/Driver/CC1

r306786 - Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's

Author: chandlerc Date: Thu Jun 29 22:13:31 2017 New Revision: 306786 URL: http://llvm.org/viewvc/llvm-project?rev=306786&view=rev Log: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

alexshap added inline comments. Comment at: tools/extra/clang-rename/tool/ClangRename.cpp:167 FindingAction.getUSRList(); const std::vector &PrevNames = FindingAction.getUSRSpellings(); if (PrintName) { 1. nit: this line caught my eye (not directly r

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

mgrang created this revision. Iteration of the unordered Ivars causes objc-modern-metadata-visibility.mm (uncovered by reverse iterating SmallPtrSet). https://reviews.llvm.org/D34860 Files: lib/Frontend/Rewrite/RewriteModernObjC.cpp test/Rewriter/objc-modern-metadata-visibility2.mm Index

r306783 - Remove test commit.

Author: dhinton Date: Thu Jun 29 20:03:28 2017 New Revision: 306783 URL: http://llvm.org/viewvc/llvm-project?rev=306783&view=rev Log: Remove test commit. Modified: cfe/trunk/README.txt Modified: cfe/trunk/README.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/README.txt?rev=306783&r1

r306782 - Test Commit

Author: dhinton Date: Thu Jun 29 19:57:34 2017 New Revision: 306782 URL: http://llvm.org/viewvc/llvm-project?rev=306782&view=rev Log: Test Commit Modified: cfe/trunk/README.txt Modified: cfe/trunk/README.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/README.txt?rev=306782&r1=306781&

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64

mgrang created this revision. Herald added subscribers: kristof.beyls, aemerson. COFF ARM64 is LLP64 platform. So int is 4 bytes, long is 4 bytes and long long is 8 bytes. https://reviews.llvm.org/D34859 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

r306775 - [WebAssembly] Add throw/rethrow builtins for exception handling

Author: aheejin Date: Thu Jun 29 17:44:01 2017 New Revision: 306775 URL: http://llvm.org/viewvc/llvm-project?rev=306775&view=rev Log: [WebAssembly] Add throw/rethrow builtins for exception handling Summary: Add new builtins for throw/rethrow instructions. This follows exception handling handling

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Per discussion on IRC, a follow-up patch from @nbjoerg will add the flag back with it just producing a warning that the flag has been removed and has no effect. While the usage of the dr

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

dlj created this revision. dlj added projects: lld, clang. Herald added subscribers: mehdi_amini, sanjoy. The GoogleTest lit format accepts two parameters to its constructor: a subdirectory to find test binaries, and a required suffix for the test filenames. Typically, the config should look lik

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

This revision was automatically updated to reflect the committed changes. Closed by commit rL306770: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34850 Files: cfe/trunk/lib/CodeGen/CGVTables.cpp cfe/trunk/test/CodeGenCXX/wind

r306770 - [CodeGen] Propagate dllexport to thunks

Author: smeenai Date: Thu Jun 29 17:07:54 2017 New Revision: 306770 URL: http://llvm.org/viewvc/llvm-project?rev=306770&view=rev Log: [CodeGen] Propagate dllexport to thunks Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

smeenai created this revision. Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These thunks would previously inherit their dllexport attribute from the declaration, but r298330 changed declarations to not have dllexport attribute

[PATCH] D34425: Unified ARM logic for computing target ABI.

echristo added a comment. I've committed this for you as: M lib/Driver/ToolChains/Clang.cpp M test/CodeGen/arm-v8.1a-neon-intrinsics.c M test/CodeGen/named_reg_global.c M test/CodeGen/neon-immediate-ubsan.c M test/CodeGen/xray-attribut

r306769 - Unified logic for computing target ABI in backend and front end by moving this common code to Support/TargetParser.

Author: echristo Date: Thu Jun 29 17:03:56 2017 New Revision: 306769 URL: http://llvm.org/viewvc/llvm-project?rev=306769&view=rev Log: Unified logic for computing target ABI in backend and front end by moving this common code to Support/TargetParser. Modeled Triple::GNU after front end code (aap

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc requested review of this revision. chandlerc added a comment. In https://reviews.llvm.org/D34846#796102, @rsmith wrote: > Removing a `-cc1` flag is OK: we explicitly tell people that the `-cc1` > interface is subject to change without notice. What do you think about this now that it

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar created this revision. On RHEL, devtoolset provides a more up-to-date toolchain than the base install, and we want to make sure all the tools use are from the same toolchain. https://reviews.llvm.org/D34848 Files: lib/Driver/ToolChains/Linux.cpp Index: lib/Driver/ToolChains/Linux.c

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc updated this revision to Diff 104775. chandlerc added a comment. Remove the rest of the flag handling that I missed the first time grepping through... https://reviews.llvm.org/D34846 Files: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Fronten

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

hfinkel added a comment. In https://reviews.llvm.org/D34846#796102, @rsmith wrote: > Removing a `-cc1` flag is OK: we explicitly tell people that the `-cc1` > interface is subject to change without notice. I'm assuming we can remove the regular flag as well. They'll just get an "unused argume

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

hfinkel accepted this revision. hfinkel added a comment. LGTM, but you need to get the: def fslp_vectorize_aggressive : Flag<["-"], "fslp-vectorize-aggressive">, Group, HelpText<"Enable the BB vectorization passes">; def fno_slp_vectorize_aggressive : Flag<["-"], "fno-slp-vectorize-aggr

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Removing a `-cc1` flag is OK: we explicitly tell people that the `-cc1` interface is subject to change without notice. https://reviews.llvm.org/D34846 _

r306764 - [PM] Add support for sample PGO in the new pass manager (clang-side)

Author: dehao Date: Thu Jun 29 16:33:13 2017 New Revision: 306764 URL: http://llvm.org/viewvc/llvm-project?rev=306764&view=rev Log: [PM] Add support for sample PGO in the new pass manager (clang-side) Summary: This implements the clang bits of https://reviews.llvm.org/D34720, and add correspondi

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc created this revision. Herald added subscribers: mcrosier, sanjoy, rengolin. Given the long time for which this path has been unused, off by default, and unnecessary this completely removes the flags. If users are deeply concerned about the commandline compatibility, they can be added ba

r306760 - Teach ASTReader how to read only the Preprocessor state from an AST file, not the ASTContext state.

Author: rsmith Date: Thu Jun 29 16:23:46 2017 New Revision: 306760 URL: http://llvm.org/viewvc/llvm-project?rev=306760&view=rev Log: Teach ASTReader how to read only the Preprocessor state from an AST file, not the ASTContext state. We use this when running a preprocessor-only action on an AST f

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306759: [clang-format] Switch to case-insensitive header matching and use it to (authored by chandlerc). Repository: rL LLVM https://reviews.llvm.org/D33932 Files: cfe/trunk/include/clang/Format/For

r306759 - [clang-format] Switch to case-insensitive header matching and use it to

Author: chandlerc Date: Thu Jun 29 16:20:54 2017 New Revision: 306759 URL: http://llvm.org/viewvc/llvm-project?rev=306759&view=rev Log: [clang-format] Switch to case-insensitive header matching and use it to improve support for LLVM-style include sorting. This really is a collection of improvemen

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

chandlerc accepted this revision. chandlerc added a comment. LGTM too, but no need to wait for me to land this. =D https://reviews.llvm.org/D34721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

Sorry, email misfire... On Thu, Jun 29, 2017 at 4:15 PM Chandler Carruth via Phabricator via llvm-commits wrote: > chandlerc added a comment. > > Already said LGTM, please go ahead and submit. If tehre are further > requsets, we can always amke follow-up changes. > > > Repository: > rL LLVM >

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added a comment. Already said LGTM, please go ahead and submit. If tehre are further requsets, we can always amke follow-up changes. Repository: rL LLVM https://reviews.llvm.org/D34728 ___ cfe-commits mailing list cfe-commits@lists.llv

r306757 - [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

Author: timshen Date: Thu Jun 29 16:10:13 2017 New Revision: 306757 URL: http://llvm.org/viewvc/llvm-project?rev=306757&view=rev Log: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information. Differential Revision: https://reviews.llvm.org/D34790 Added: cfe/trunk/test/C

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306757: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D34790?vs=104766&id=104768#toc Repositor

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306756: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D34728?vs=104551&id=104767#toc Repository: rL LLVM https://r

r306756 - [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

Author: timshen Date: Thu Jun 29 16:08:38 2017 New Revision: 306756 URL: http://llvm.org/viewvc/llvm-project?rev=306756&view=rev Log: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline. Previously it doesn't actually invoke the designated new PM builder functions. This patch moves NameAnonG

[libcxx] r306755 - [lit/libcxx] Fix a remaining reference to lit.util.capture() in custom libcxx/Darwin code.

Author: dlj Date: Thu Jun 29 16:07:27 2017 New Revision: 306755 URL: http://llvm.org/viewvc/llvm-project?rev=306755&view=rev Log: [lit/libcxx] Fix a remaining reference to lit.util.capture() in custom libcxx/Darwin code. Summary: This reference to lit.util.capture is functionally identical to su

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

timshen updated this revision to Diff 104766. timshen marked an inline comment as done. timshen added a comment. Herald added a subscriber: aprantl. s/the debug prints/debug printing/ https://reviews.llvm.org/D34790 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Fronten

[PATCH] D34842: [X86] Add RDRND to Goldmont. Add MOVBE to all Atom CPUs

craig.topper created this revision. This adds to RDNRND to Goldmont as I believe it has that feature in addition to RDSEED. I don't know how to test the MOVBE part since we don't have a __MOVBE__ macro nor do we need one. The backend will already infer the feature from the CPU name. We do have

Re: r306692 - Initialize variable and silence potentially uninitialized warning.

This change broke clang/ubsan bot. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6047/steps/check-clang%20ubsan/logs/stdio It looks like the value you are initializing SavedAK with may itself be uninitialized? I see a few constructors that do not mention it. On Thu, Jun 29

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM. Just one minor nit on the option help string below. Thanks Comment at: clang/include/clang/Driver/CC1Options.td:329 +def fno_debug_pass_manager : Flag<["-"], "fno

r306753 - [ODRHash] Improve typedef handling.

Author: rtrieu Date: Thu Jun 29 15:53:04 2017 New Revision: 306753 URL: http://llvm.org/viewvc/llvm-project?rev=306753&view=rev Log: [ODRHash] Improve typedef handling. Follow typedef chains to find the root type when processing types, and also keep track of qualifiers. Modified: cfe/trunk/l

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. In https://reviews.llvm.org/D34784#795980, @gtbercea wrote: > In https://reviews.llvm.org/D34784#795934, @hfinkel wrote: > > > In https://reviews.llvm.org/D34784#795871, @gtbercea wrote: > > > > > In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > > > > > > > In

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This seems like a good idea. Thanks! https://reviews.llvm.org/D34839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D34606: [libcxx] Link MinGW libs for shared build

mati865 added a comment. Sorry @martell I totally forgot about it. I'll test https://reviews.llvm.org/D33638 later today. Repository: rL LLVM https://reviews.llvm.org/D34606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea added a comment. In https://reviews.llvm.org/D34784#795934, @hfinkel wrote: > In https://reviews.llvm.org/D34784#795871, @gtbercea wrote: > > > In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > > > > > In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > > > > > > > I

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

chandlerc added a comment. This looks great to me with a CC1-layer flag. But check that others are happy as well, thanks! https://reviews.llvm.org/D34790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

timshen marked 2 inline comments as done. timshen added inline comments. Comment at: clang/include/clang/Driver/Options.td:971-973 +def fexperimental_new_pass_manager_EQ : Joined<["-"], "fexperimental-new-pass-manager=">, + Group, Flags<[CC1Option]>, + HelpText<"Enables an exp

[PATCH] D34606: [libcxx] Link MinGW libs for shared build

martell added a comment. Not quite sure how this achieves anything different from what is already in `cmake/config-ix.cmake` ? https://reviews.llvm.org/D33638 addresses the remaining changes needed to build for windows shared and static in one build. Repository: rL LLVM https://reviews.llvm

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

timshen added a comment. Also add @tejohnson as a reviewer, since the LTO test changed https://reviews.llvm.org/D34790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34790: [NewPM] Add a flag -fexperimental-new-pass-manager=on/off/debug for printing debug output.

timshen updated this revision to Diff 104753. timshen added a comment. Use a cc1 flag -fdebug-pass-manager instead. https://reviews.llvm.org/D34790 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Frontend/CodeGenOptions.def clang/lib/CodeGen/BackendUtil.cpp clang/lib

r306751 - Fix openmp-offload.c test on Windows

Author: rnk Date: Thu Jun 29 15:31:16 2017 New Revision: 306751 URL: http://llvm.org/viewvc/llvm-project?rev=306751&view=rev Log: Fix openmp-offload.c test on Windows Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trunk/test/Driver/openmp-offload.c URL: http://llvm.org/viewv

[clang-tools-extra] r306750 - Fix some typos in the doc

Author: sylvestre Date: Thu Jun 29 15:26:06 2017 New Revision: 306750 URL: http://llvm.org/viewvc/llvm-project?rev=306750&view=rev Log: Fix some typos in the doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-forwarding-reference-overload.rst clang-tools-extra/trunk/docs/

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

kastiglione updated this revision to Diff 104750. kastiglione added a comment. fixup a test https://reviews.llvm.org/D34839 Files: lib/Driver/ToolChains/CrossWindows.cpp test/Driver/windows-cross.c Index: test/Driver/windows-cross.c

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. In https://reviews.llvm.org/D34784#795871, @gtbercea wrote: > In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > > > In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > > > > > In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > > > > > > > Wh

[PATCH] D34839: [Driver] Honor -nostdinc and -isystem-after on CrossWindows

kastiglione created this revision. This changes CrossWindows to look for `-nostdinc` instead of `-nostdlibinc`. In addition, fixes a bug where `-isystem-after` options would be dropped when called with `-nostdinc`. https://reviews.llvm.org/D34839 Files: lib/Driver/ToolChains/CrossWindows.cpp

[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

rtrieu added a comment. Reid is correct, the whitelisted expressions was greatly reduced during code review so only casts to void would disable the warning. While the last review did not have the description updated to reflect this, the committed code does have an accurate description. What i

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea added a comment. In https://reviews.llvm.org/D34784#795367, @hfinkel wrote: > In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > > > In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > > > > > What happens if you have multiple targets? Maybe this should be > > > -fop

[PATCH] D34725: Add sample PGO integration test to cover profile annotation and inlining.

davidxl added inline comments. Comment at: test/CodeGen/pgo-sample.c:4 +// Ensure Pass SampleProfileLoader is invoked. +// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample.prof %s -mllvm -debug-pass=Structure -mllvm -inline-threshold=0 -emit-llvm -o - 2>&1 | FileCh

r306739 - Insert llvm_unreachable at the end of a function to silence gcc's

Author: ahatanak Date: Thu Jun 29 13:44:20 2017 New Revision: 306739 URL: http://llvm.org/viewvc/llvm-project?rev=306739&view=rev Log: Insert llvm_unreachable at the end of a function to silence gcc's -Werror=return-type error. This is an attempt to fix the following failing bot: http://lab.llvm

[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

gparker42 added a comment. I thought void-returning functions were supposed to be allowed based on the description in https://reviews.llvm.org/D3976 , but later in that discussion the definition was changed to instead allow almost nothing. Repository: rL LLVM https://reviews.llvm.org/D34810

r306734 - [libFuzzer] Add Fuzzer to the list of sanitizers which support coverage.

Author: george.karpenkov Date: Thu Jun 29 12:58:20 2017 New Revision: 306734 URL: http://llvm.org/viewvc/llvm-project?rev=306734&view=rev Log: [libFuzzer] Add Fuzzer to the list of sanitizers which support coverage. Without this change, additional coverage flags specified after -fsanitize=fuzzer

r306733 - [libFuzzer] Do not link in libFuzzer with -fsanitize=fuzzer when producing a shared object

Author: george.karpenkov Date: Thu Jun 29 12:52:33 2017 New Revision: 306733 URL: http://llvm.org/viewvc/llvm-project?rev=306733&view=rev Log: [libFuzzer] Do not link in libFuzzer with -fsanitize=fuzzer when producing a shared object https://reviews.llvm.org/D34791 Modified: cfe/trunk/lib/D

[PATCH] D34788: [ASTReader] Add test for previous change r306583 / 145692e.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306732: [ASTReader] Add test for previous change r306583 / 145692e. (authored by graydon). Repository: rL LLVM https://reviews.llvm.org/D34788 Files: cfe/trunk/test/Modules/Inputs/lookup-assert-prot

r306732 - [ASTReader] Add test for previous change r306583 / 145692e.

Author: graydon Date: Thu Jun 29 12:42:35 2017 New Revision: 306732 URL: http://llvm.org/viewvc/llvm-project?rev=306732&view=rev Log: [ASTReader] Add test for previous change r306583 / 145692e. Summary: Add a test for the change to ASTReader that reproduces the logic for consolidating multiple Ob

[PATCH] D34788: [ASTReader] Add test for previous change r306583 / 145692e.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! Thanks Graydon https://reviews.llvm.org/D34788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] r306728 - [clang-tidy] Rename android-file-open-flag and fix a bug

Author: yawanng Date: Thu Jun 29 12:13:29 2017 New Revision: 306728 URL: http://llvm.org/viewvc/llvm-project?rev=306728&view=rev Log: [clang-tidy] Rename android-file-open-flag and fix a bug Summary: 1. Rename android-file-open-flag to android-cloexec-open. 2. Handle a case when the function is p

r306724 - [OpenMP] Fix test for revision D29645. NFC

Author: gbercea Date: Thu Jun 29 11:49:16 2017 New Revision: 306724 URL: http://llvm.org/viewvc/llvm-project?rev=306724&view=rev Log: [OpenMP] Fix test for revision D29645. NFC Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trunk/test/Driver/openmp-offload.c URL: http://ll

r306722 - [Sema] Issue diagnostics if a new/delete expression generates a call to

Author: ahatanak Date: Thu Jun 29 11:48:40 2017 New Revision: 306722 URL: http://llvm.org/viewvc/llvm-project?rev=306722&view=rev Log: [Sema] Issue diagnostics if a new/delete expression generates a call to a c++17 aligned allocation/deallocation function that is unavailable in the standard librar

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

This revision was automatically updated to reflect the committed changes. Closed by commit rL306722: [Sema] Issue diagnostics if a new/delete expression generates a call to (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D34574?vs=104579&id=104712#toc Repository: rL

[PATCH] D34777: CodeGen: Fix invalid bitcast for coerced function argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL306721: CodeGen: Fix invalid bitcast for coerced function argument (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D34777?vs=104505&id=104711#toc Repository: rL LLVM https://

r306721 - CodeGen: Fix invalid bitcast for coerced function argument

Author: yaxunl Date: Thu Jun 29 11:47:45 2017 New Revision: 306721 URL: http://llvm.org/viewvc/llvm-project?rev=306721&view=rev Log: CodeGen: Fix invalid bitcast for coerced function argument Clang assumes coerced function argument is in address space 0, which is not always true and results in i

[PATCH] D34633: [clang-tidy] Rename android-file-open-flag and fix a bug

yawanng updated this revision to Diff 104709. yawanng added a comment. Change the file name in toctree. https://reviews.llvm.org/D34633 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecOpenCheck.cpp clang-tidy/android/CloexecOpe

[clang-tools-extra] r306719 - [clang-tidy] Add docs to toctree

Author: yawanng Date: Thu Jun 29 11:44:28 2017 New Revision: 306719 URL: http://llvm.org/viewvc/llvm-project?rev=306719&view=rev Log: [clang-tidy] Add docs to toctree Summary: Add .rst files to toctree. Fix buildbot error. Reviewers: chh Reviewed By: chh Subscribers: srhines, JDevlieghere, xaz

[PATCH] D34633: [clang-tidy] Rename android-file-open-flag and fix a bug

chh added a comment. I think you also need to change docs/clang-tidy/checks/list.rst. https://reviews.llvm.org/D34633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang. https://reviews.llvm.org/D34824 Files: docs/ClangFormat.rst docs/ReleaseNotes.rst tools/clang-format/ClangFormat.cpp Index: docs/ReleaseNotes.rst

[PATCH] D34801: [coverage] Make smaller regions for the first case of a switch.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks for the patch! LGTM. Comment at: lib/CodeGen/CoverageMappingGen.cpp:686 +// FIXME: a break in a switch should terminate regions for all preceding +// case statements

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

sberg added a comment. see also https://reviews.llvm.org/rL306715 "Fixed -Wexceptions derived-to-base false positives" Repository: rL LLVM https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r306715 - Fixed -Wexceptions derived-to-base false positives

Author: sberg Date: Thu Jun 29 10:58:59 2017 New Revision: 306715 URL: http://llvm.org/viewvc/llvm-project?rev=306715&view=rev Log: Fixed -Wexceptions derived-to-base false positives ...as introduced with recent "Emit warning when throw exception in destruct or d

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

yawanng updated this revision to Diff 104689. yawanng added a comment. Pull back the previous change. For some reason it's lost. https://reviews.llvm.org/D34633 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecOpenCheck.cpp clan

[PATCH] D34777: CodeGen: Fix invalid bitcast for coerced function argument

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D34810: [Sema] -Wcomma should not warn for expressions that return void

rnk added a comment. I thought the intention of -Wcomma was to warn on practically all non-macro uses of the comma operator. I know it's silly to cast void to void, but I seem to recall that this was an intentional style-ish warning like -Wparentheses, which encourages `if ((x = y))` for intent

[clang-tools-extra] r306709 - [clang-tidy][Part3] Add a new module Android and three new checks.

Author: yawanng Date: Thu Jun 29 10:42:23 2017 New Revision: 306709 URL: http://llvm.org/viewvc/llvm-project?rev=306709&view=rev Log: [clang-tidy][Part3] Add a new module Android and three new checks. Summary: -- fopen() should include "e" in their mode string. [android-fopen-mode] Reviewers: c

[clang-tools-extra] r306708 - [clang-tidy][Part2] Add a new module Android and three new checks

Author: yawanng Date: Thu Jun 29 10:40:57 2017 New Revision: 306708 URL: http://llvm.org/viewvc/llvm-project?rev=306708&view=rev Log: [clang-tidy][Part2] Add a new module Android and three new checks Summary: -- creat() should be replaced by open(). [android-creat-usage] Reviewers: chh, alexfh,

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

chh requested changes to this revision. chh added a comment. This revision now requires changes to proceed. Please update the subject line and summary. The new diff shows only the renaming of check name and file names. Were the other changes for format and macro lost or are they going to be in ano

[clang-tools-extra] r306705 - [clangd] Check failure of Lexer::getRawToken in GoToDeclaration.

Author: ibiryukov Date: Thu Jun 29 10:11:32 2017 New Revision: 306705 URL: http://llvm.org/viewvc/llvm-project?rev=306705&view=rev Log: [clangd] Check failure of Lexer::getRawToken in GoToDeclaration. There was an access to unitialized memory because it wasn't checked. Modified: clang-tools-

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. In https://reviews.llvm.org/D34784#795353, @gtbercea wrote: > In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > > > What happens if you have multiple targets? Maybe this should be > > -fopenmp-targets-arch=foo,bar,whatever? > > > > Once this all lands, please

[PATCH] D34329: [clang-diff] Initial implementation.

johannes marked 2 inline comments as done. johannes added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:439 +// Computes an optimal mapping between two trees. +class ZsMatcher { + const ASTDiff::Impl &DiffImpl; arphaman wrote: > Do you know the re

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea added a comment. In https://reviews.llvm.org/D34784#795287, @hfinkel wrote: > What happens if you have multiple targets? Maybe this should be > -fopenmp-targets-arch=foo,bar,whatever? > > Once this all lands, please make sure that you add additional test cases > here. Make sure that th

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104664. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt test/Tooling/clan

r306692 - Initialize variable and silence potentially uninitialized warning.

Author: vvassilev Date: Thu Jun 29 09:08:10 2017 New Revision: 306692 URL: http://llvm.org/viewvc/llvm-project?rev=306692&view=rev Log: Initialize variable and silence potentially uninitialized warning. Patch by Liza Sakellari! Modified: cfe/trunk/include/clang/Sema/Lookup.h Modified: cfe/t

r306691 - [OpenMP] Pass -fopenmp-is-device to preprocessing and machine specific code generation stages

Author: gbercea Date: Thu Jun 29 08:59:19 2017 New Revision: 306691 URL: http://llvm.org/viewvc/llvm-project?rev=306691&view=rev Log: [OpenMP] Pass -fopenmp-is-device to preprocessing and machine specific code generation stages Summary: The preprocessing and code generation and optimization stag

r306689 - [OpenMP] Add support for auxiliary triple specification

Author: gbercea Date: Thu Jun 29 08:49:03 2017 New Revision: 306689 URL: http://llvm.org/viewvc/llvm-project?rev=306689&view=rev Log: [OpenMP] Add support for auxiliary triple specification Summary: Device offloading requires the specification of an additional flag containing the triple of the /

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiffInternal.h:184 + + std::string getNodeValueI(NodeId Id) const; + std::string getNodeValueI(const DynTypedNode &DTN) const; `getNodeValueImpl`? Comment at: lib/To

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi updated this revision to Diff 104655. schroedersi added a comment. I forgot to add the previous changes in Diff 104649 (it only contains the incremental diff of the printing context changes). This diff contains all changes between

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel added a comment. What happens if you have multiple targets? Maybe this should be -fopenmp-targets-arch=foo,bar,whatever? Once this all lands, please make sure that you add additional test cases here. Make sure that the arch is passed through to the ptx and cuda tools as it should be. M

[PATCH] D29339: [OpenMP] Add support for auxiliary triple specification

gtbercea updated this revision to Diff 104656. gtbercea added a comment. Rebase https://reviews.llvm.org/D29339 Files: lib/Driver/ToolChains/Clang.cpp lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp lib/Frontend/InitPreprocessor.cpp test/Driver/openmp-offload.c

  1   2   >