NoQ added a comment.
In https://reviews.llvm.org/D32642#789004, @baloghadamsoftware wrote:
> Now I can improve `SValBuilder` to compare `{conj_X}+n` to `conj_X}+m`, but I
> am not sure if it helps to simplify `compare()` much. How to handle cases
> where I have to compare `{conj_X}+n` to `{conj
NoQ added a comment.
Maxim, totally thanks for picking this up!
Could you explain the idea behind `shouldDeferScopeEnd`, maybe in a code
comment before the function?
In https://reviews.llvm.org/D16403#788926, @m.ostapenko wrote:
> Current patch should support basic {If, While, For, Compound, S
bcraig added inline comments.
Comment at: include/__config:234-235
+// a MS compatibility version is specified.
# ifndef __MINGW32__
-#define _LIBCPP_MSVCRT // Using Microsoft's C Runtime library
+#ifdef _MSC_VER
+# define _LIBCPP_MSVCRT // Using Microsoft's C Runt
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:985
+
+ Out << '?' << Discriminate("_block_invoke", Discriminator) << '@';
+ if (const auto *RD = dyn_cast(DC))
Should this be `Out << '?' << mangleSourceName(Discriminate("_block_i
majnemer added inline comments.
Comment at: include/__config:234-235
+// a MS compatibility version is specified.
# ifndef __MINGW32__
-#define _LIBCPP_MSVCRT // Using Microsoft's C Runtime library
+#ifdef _MSC_VER
+# define _LIBCPP_MSVCRT // Using Microsoft's C Ru
compnerd added inline comments.
Comment at: include/__config:234-235
+// a MS compatibility version is specified.
# ifndef __MINGW32__
-#define _LIBCPP_MSVCRT // Using Microsoft's C Runtime library
+#ifdef _MSC_VER
+# define _LIBCPP_MSVCRT // Using Microsoft's C Ru
erik.pilkington updated this revision to Diff 103852.
erik.pilkington added a comment.
Improve enum diagnostics, as @arphaman suggested. This causes a bit of churn
throughout the availability diagnostic machinery, if it would make it at all
easier to review, I would be happy to separate out thes
Hello everyone,
Buildbot master is back to usual work after transitional.
Please pay attention to errors.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote:
> With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is
> created in the directory
> /tools/clang/tools/extra/test/clang-tidy/Output,
>
I'd be really surprised if this is the case - why would
cmake/ninja/makefiles put the compil
On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote:
> With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is
> created in the directory
> /tools/clang/tools/extra/test/clang-tidy/Output, but the tests
> from /llvm/tools/clang/tools/extra/test/clang-tidy run in the
> directory /tool
compnerd updated this revision to Diff 103845.
compnerd added a comment.
Address feedback. Also fix the case that was previously not working. This now
covers all the various cases that have been discussed.
Repository:
rL LLVM
https://reviews.llvm.org/D34523
Files:
lib/AST/MicrosoftMangl
With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is
created in the directory
/tools/clang/tools/extra/test/clang-tidy/Output, but the tests
from /llvm/tools/clang/tools/extra/test/clang-tidy run in the
directory /tools/clang/tools/extra/test/clang-tidy, which does
not contain json
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM with a comment clarity tweak.
Comment at: lib/Driver/ToolChains/Gnu.cpp:2322-2323
case llvm::Triple::mips64el:
-// Enabled for Debian mips64/mips64el only. Othe
Prazek added a comment.
In https://reviews.llvm.org/D33470#764846, @aaron.ballman wrote:
> Once you fix the typo in the check, can you run it over some large C++ code
> bases to see if it finds any results?
I tried it on LLVM code base (after fixing bug with the numeric_limits name)
and it di
Prazek updated this revision to Diff 103837.
Prazek marked 4 inline comments as done.
Prazek added a comment.
- fixed docs
- fixes
https://reviews.llvm.org/D33470
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DefaultNumericsCheck.cpp
clang-tidy/misc/DefaultNumericsCheck.h
clang-
wangxindsb updated this revision to Diff 103832.
wangxindsb added a comment.
Add license to VirtualCallChecker.cpp
https://reviews.llvm.org/D34275
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
test/Analysis/virtualcall.cpp
Index: test/Analysis/virtualcall.cpp
==
16 matches
Mail list logo
