[PATCH] D34591: [ubsan] Diagnose invalid uses of builtins (compiler-rt)

vsk created this revision. Herald added subscribers: dberris, kubamracek. Compiler-rt changes and tests to go along with: https://reviews.llvm.org/D34590 https://reviews.llvm.org/D34591 Files: lib/ubsan/ubsan_checks.inc lib/ubsan/ubsan_handlers.cc lib/ubsan/ubsan_handlers.h lib/ubsan/ub

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

vsk created this revision. On some targets, passing zero to the clz() or ctz() builtins has undefined behavior. I ran into this issue while debugging UB in __hash_table from libcxx: the bug I was seeing manifested itself differently under -O0 vs -Os, due to a UB call to clz() (see: libcxx/r304617)

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

rsmith added a comment. In https://reviews.llvm.org/D34574#789539, @ahatanak wrote: > Is there any cases where we can turn the linker error into a compile time > error? We could possibly implicitly put an availability attribute on the implicit declarations or something equivalent, to say "hey

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

Ping (+Manuel, perhaps he's got some ideas about this, given background in the tooling & compilation database work, or could point this to someone who does?) On Thu, Jun 15, 2017 at 10:40 AM David Blaikie wrote: > https://sarcasm.github.io/notes/dev/compilation-database.html#cmake > > If you ena

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

smeenai added reviewers: compnerd, majnemer, rnk. smeenai added subscribers: majnemer, compnerd. smeenai added a comment. This looks sensible to me. I don't know if there are any scenarios in which you'd be using the Microsoft CRT without having `_MSC_VER` defined, however. Added some people who

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bruno created this revision. _LIBCPP_MSVCRT is defined because _WIN32 is defined and __MINGW32__ is not. Some non-windows targets using MS extensions define _WIN32 for compatibility with Windows but do not have MSVC compatibility. This patch is an attempt to do not have _LIBCPP_MSVCRT defined f

[PATCH] D34415: Allow passing a regex for headers to exclude from clang-tidy

toddlipcon added a comment. Anyone able to review this? Repository: rL LLVM https://reviews.llvm.org/D34415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

majnemer added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:981-984 + Out << "YAXPAU__block_literal"; + if (Discriminator) +Out<< '_' << Discriminator; + Out << "@@@Z"; compnerd wrote: > majnemer wrote: > > I think you want to u

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd added a comment. Ah, thanks for the explanation @efriedma. Comment at: lib/AST/MicrosoftMangle.cpp:981-984 + Out << "YAXPAU__block_literal"; + if (Discriminator) +Out<< '_' << Discriminator; + Out << "@@@Z"; majnemer wrote: > I t

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

ahatanak added a comment. The motivation for this change was to silence linker errors I saw when compiling and linking programs in which operator new was called to allocate over-aligned types (similar to the code in cxx1z-aligned-allocation.cpp). Linkage failed because clang would emit the call

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

majnemer added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:981-984 + Out << "YAXPAU__block_literal"; + if (Discriminator) +Out<< '_' << Discriminator; + Out << "@@@Z"; I think you want to use mangleArtificalTagType here. Repo

r306183 - Add a warning to a group

Author: vedantk Date: Fri Jun 23 18:34:32 2017 New Revision: 306183 URL: http://llvm.org/viewvc/llvm-project?rev=306183&view=rev Log: Add a warning to a group Add warn_drv_object_size_disabled_O0 to the invalid command line argument group. This should fix some bot failures: lab.llvm.org:8011/

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

kastiglione created this revision. When generating a prolog, add loads for ARC arguments passed indirectly. https://reviews.llvm.org/D34580 Files: lib/CodeGen/CGDecl.cpp test/CodeGenObjCXX/arc-indirect.mm Index: test/CodeGenObjCXX/arc-indirect.mm ==

[PATCH] D34563: [ubsan] Disable the object-size check at -O0

This revision was automatically updated to reflect the committed changes. Closed by commit rL306181: [ubsan] Disable the object size check at -O0 (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34563?vs=103778&id=103796#toc Repository: rL LLVM https://reviews.llvm.

r306181 - [ubsan] Disable the object size check at -O0

Author: vedantk Date: Fri Jun 23 18:15:24 2017 New Revision: 306181 URL: http://llvm.org/viewvc/llvm-project?rev=306181&view=rev Log: [ubsan] Disable the object size check at -O0 This check currently isn't able to diagnose any issues at -O0, not is it likely to [1]. Disabling the check at -O0 lea

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd updated this revision to Diff 103794. compnerd added a comment. This is a step in the right direction. Although the NSDMI cases and default parameter value cases are not yet handled, they break due to tracking of the global mangling number tracking, not due to the scheme. Repository:

Re: [PATCH] D34563: [ubsan] Disable the object-size check at -O0

v...@apple.com writes: > Good point, it makes sense to hand users a warning when they explicitly enable > -fsanitize=object-size at -O0. I've added in the diagnostic. PTAL. LGTM. > diff --git a/include/clang/Basic/DiagnosticDriverKinds.td > b/include/clang/Basic/DiagnosticDriverKinds.td > index

[PATCH] D34578: cmath: Support clang's -fdelayed-template-parsing

dexonsmith created this revision. r283051 added some functions to cmath (in namespace std) that have the same name as functions in math.h (in the global namespace). Clang's limited support for `-fdelayed-template-parsing` chokes on this. Rename the ones in `cmath` and their uses in `complex`

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: test/SemaCXX/PR33189.cpp:1-7 +// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s + +class U +{ + template + ~U() { } // expected-error{{destructor cann

r306175 - Revert "[MS] Don't statically initialize dllimport member function pointers"

Author: rnk Date: Fri Jun 23 17:39:01 2017 New Revision: 306175 URL: http://llvm.org/viewvc/llvm-project?rev=306175&view=rev Log: Revert "[MS] Don't statically initialize dllimport member function pointers" This reverts commit r306137. It has problems on code like this: struct __declspec(dllim

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

hubert.reinterpretcast added a comment. In https://reviews.llvm.org/D33833#789436, @kuang_he wrote: > Can we get this patch reviewed by any chance? @kuang_he; it is customary to "ping". In this case, "Ping 2". Comment at: lib/AST/DeclCXX.cpp:1421 - CXXDestructorDecl *Dtor

[clang-tools-extra] r306172 - [clang-tidy] doc format fix

Author: yawanng Date: Fri Jun 23 17:12:55 2017 New Revision: 306172 URL: http://llvm.org/viewvc/llvm-project?rev=306172&view=rev Log: [clang-tidy] doc format fix Summary: The url in the doc is wrong. Fix the url. Reviewers: chh Reviewed By: chh Subscribers: srhines, xazax.hun Tags: #clang-too

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

ahatanak updated this revision to Diff 103785. ahatanak added a comment. Remove -fno-aligned-allocation from the RUN lines. The test cases should check that new or delete operators with alignment are disabled without providing -fno-aligned-allocation. https://reviews.llvm.org/D34574 Files:

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

rsmith added a comment. Unlike with sized deallocation (which also requires a new stdlib entry point), it was intentional that this be enabled by default in C++17 mode. Implicit calls are only generated to the aligned forms of `operator new` and `operator delete` in cases where the program woul

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

kuang_he added a comment. Can we get this patch reviewed by any chance? https://reviews.llvm.org/D33833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

efriedma added a comment. > How do we end up in a state where the block invocation function is > referenced external to the TU? ODR allows certain definitions, like class definitions and inline function definitions, to be written in multiple translation units. See http://itanium-cxx-abi.git

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

ahatanak created this revision. This patch stops declaring implicitly the new and delete operators with alignment if the deployment target is earlier than the version in which support for them was introduced . This fixes linker errors which we see when the compiler emits a new or delete operato

Re: r304207 - Allow for unfinished #if blocks in preambles

On 23 June 2017 at 13:34, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Since this change went in I'm seeing spurious errors whenever editing > a header file, filed https://bugs.llvm.org/show_bug.cgi?id=33574 for > that. Does fixing the reversed condition I pointed out f

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd added a comment. @efriedma I think that Im still not understanding the case that you are trying to point out. How do we end up in a state where the block invocation function is referenced external to the TU? The block would be referenced to by name of the block, no? AFAICT, this is

[PATCH] D34563: [ubsan] Disable the object-size check at -O0

vsk updated this revision to Diff 103778. vsk added a comment. Add a diagnostic for users who explicitly turn the object-size check on at -O0, and tighten up the test a bit. https://reviews.llvm.org/D34563 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/SanitizerArgs.cpp t

[clang-tools-extra] r306165 - [clang-tidy][Part1] Add a new module Android and three new checks.

Author: yawanng Date: Fri Jun 23 16:37:29 2017 New Revision: 306165 URL: http://llvm.org/viewvc/llvm-project?rev=306165&view=rev Log: [clang-tidy][Part1] Add a new module Android and three new checks. Summary: A common source of security bugs is code that opens a file descriptors without using t

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rL306163: [ubsan] Improve diagnostics for return value checks (clang) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34299?vs=103632&id=103774#toc Repository: rL LLVM https:

r306163 - [ubsan] Improve diagnostics for return value checks (clang)

Author: vedantk Date: Fri Jun 23 16:32:38 2017 New Revision: 306163 URL: http://llvm.org/viewvc/llvm-project?rev=306163&view=rev Log: [ubsan] Improve diagnostics for return value checks (clang) This patch makes ubsan's nonnull return value diagnostics more precise, which makes the diagnostics mor

r306161 - [MSP430] Fix data layout string.

Author: dambrouski Date: Fri Jun 23 16:12:56 2017 New Revision: 306161 URL: http://llvm.org/viewvc/llvm-project?rev=306161&view=rev Log: [MSP430] Fix data layout string. Summary: Change data layout string so it would be compatible with MSP430 EABI. Depends on D34561 Reviewers: asl, awygle Revi

[PATCH] D34562: [MSP430] Fix data layout string.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306161: [MSP430] Fix data layout string. (authored by dambrouski). Changed prior to commit: https://reviews.llvm.org/D34562?vs=103751&id=103771#toc Repository: rL LLVM https://reviews.llvm.org/D3456

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

efriedma added a comment. I think we just use "0" as a sentinel value to indicate the block doesn't need a mangling number. getLambdaManglingNumber works the same way? See CXXNameMangler::mangleUnqualifiedBlock in the Itanium mangler. Repository: rL LLVM https://reviews.llvm.org/D34523

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd added a comment. @efriedma which bit of the Itanium mangling should I be looking at? A BlockDecl does not have visibility associated with them, so Im not sure what I should be checking to see if the block is visible or not. What is the best way forward for finishing this up? Reposi

Re: [PATCH] D34563: [ubsan] Disable the object-size check at -O0

Good point, it makes sense to hand users a warning when they explicitly enable -fsanitize=object-size at -O0. I've added in the diagnostic. PTAL. disable-object-size-check-O0.diff Description: Binary data vedantOn Jun 23, 2017, at 1:05 PM, Justin Bogner wrote:+++ test/Driv

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd updated this revision to Diff 103768. compnerd added a comment. Add additional test cases, improve coverage and mangling. Repository: rL LLVM https://reviews.llvm.org/D34523 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-blocks.cpp Index: test/CodeGenCXX/msabi-blocks.

Re: r304207 - Allow for unfinished #if blocks in preambles

Since this change went in I'm seeing spurious errors whenever editing a header file, filed https://bugs.llvm.org/show_bug.cgi?id=33574 for that. On Tue, May 30, 2017 at 1:54 PM, Erik Verbruggen via cfe-commits wrote: > Author: erikjv > Date: Tue May 30 06:54:55 2017 > New Revision: 304207 > > URL

r306156 - Add test for 306149, warn on throw from noexcept

Author: erichkeane Date: Fri Jun 23 15:30:33 2017 New Revision: 306156 URL: http://llvm.org/viewvc/llvm-project?rev=306156&view=rev Log: Add test for 306149, warn on throw from noexcept Added: cfe/trunk/test/SemaCXX/warn-throw-out-noexcept-func.cpp Added: cfe/trunk/test/SemaCXX/warn-throw-ou

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL306149: Emit warning when throw exception in destruct or dealloc functions which has a (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D3?vs=103519&id=103765#toc Reposi

r306149 - Emit warning when throw exception in destruct or dealloc functions which has a

Author: erichkeane Date: Fri Jun 23 15:22:19 2017 New Revision: 306149 URL: http://llvm.org/viewvc/llvm-project?rev=306149&view=rev Log: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier Throwing in the destructor is not good (C

[PATCH] D31575: [clang-format] Use configured IndentWidth instead of 2

thatguystone closed this revision. thatguystone added a comment. A similar fix was accepted in https://reviews.llvm.org/D33857 https://reviews.llvm.org/D31575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D34568: [Sema] Make BreakContinueFinder handle nested loops.

efriedma created this revision. We don't care about break or continue statements that aren't associated with the current loop, so make sure the visitor doesn't find them. Fixes https://bugs.llvm.org/show_bug.cgi?id=32648 . Repository: rL LLVM https://reviews.llvm.org/D34568 Files: lib/Sem

Re: [PATCH] D34563: [ubsan] Disable the object-size check at -O0

Vedant Kumar via Phabricator writes: > vsk created this revision. > > This is motivated by the thread: > [cfe-dev] Disabling ubsan's object size check at -O0 > > I think the driver is the best place to disable a sanitizer check at > particular optimization levels. Doing so in the frontend is messy

Two builders are off-line for maintenance

Hello everyone, I took builders llvm-clang-x86_64-expensive-checks-win and llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast off-line for maintenance. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D34563: [ubsan] Disable the object-size check at -O0

vsk created this revision. This is motivated by the thread: [cfe-dev] Disabling ubsan's object size check at -O0 I think the driver is the best place to disable a sanitizer check at particular optimization levels. Doing so in the frontend is messy, and makes it really hard to test IR generation

[PATCH] D34562: [MSP430] Fix data layout string.

pftbest added a comment. Thanks! > shall we support only EABI or... 2 different ABIs? GCC supports only EABI, and i think we should also spend our limited resources on more important issues, than supporting old abi. https://reviews.llvm.org/D34562 __

r306137 - [MS] Don't statically initialize dllimport member function pointers

Author: rnk Date: Fri Jun 23 13:29:13 2017 New Revision: 306137 URL: http://llvm.org/viewvc/llvm-project?rev=306137&view=rev Log: [MS] Don't statically initialize dllimport member function pointers We were already applying the same rules to dllimport function pointers. David Majnemer added that l

[PATCH] D34562: [MSP430] Fix data layout string.

asl added a comment. Meta-question: shall we support only EABI or... 2 different ABIs? It seems it does not make any sense to support anything besides EABI. https://reviews.llvm.org/D34562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D34562: [MSP430] Fix data layout string.

pftbest created this revision. Change data layout string so it would be compatible with MSP430 EABI. Depends on https://reviews.llvm.org/D34561 https://reviews.llvm.org/D34562 Files: lib/Basic/Targets.cpp test/CodeGen/target-data.c Index: test/CodeGen/target-data.c ==

r306127 - [GSoC] Add support for CC1 options.

Author: yamaguchi Date: Fri Jun 23 12:05:50 2017 New Revision: 306127 URL: http://llvm.org/viewvc/llvm-project?rev=306127&view=rev Log: [GSoC] Add support for CC1 options. Summary: Add value completion support for options which are defined in CC1Options.td, because we only handled options in Opti

r306126 - Add a ThinLTO cache policy for controlling the maximum cache size in bytes.

Author: pcc Date: Fri Jun 23 12:05:03 2017 New Revision: 306126 URL: http://llvm.org/viewvc/llvm-project?rev=306126&view=rev Log: Add a ThinLTO cache policy for controlling the maximum cache size in bytes. This is useful when an upper limit on the cache size needs to be controlled independently o

[PATCH] D34546: docs: Add documentation for the ThinLTO cache pruning policy string.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306125: docs: Add documentation for the ThinLTO cache pruning policy string. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D34546?vs=103682&id=103743#toc Repository: rL LLVM h

r306125 - docs: Add documentation for the ThinLTO cache pruning policy string.

Author: pcc Date: Fri Jun 23 11:56:27 2017 New Revision: 306125 URL: http://llvm.org/viewvc/llvm-project?rev=306125&view=rev Log: docs: Add documentation for the ThinLTO cache pruning policy string. Differential Revision: https://reviews.llvm.org/D34546 Modified: cfe/trunk/docs/ThinLTO.rst

[PATCH] D34329: [GSoC] Clang AST diffing

johannes added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:730 + +Mapping TreeComparator::matchTopDown() const { + PriorityList L1(T1); arphaman wrote: > Johannes, it seems to me that your implementation of the top-down portion of > the GumTree

r306123 - test: fix negative test case

Author: compnerd Date: Fri Jun 23 11:52:49 2017 New Revision: 306123 URL: http://llvm.org/viewvc/llvm-project?rev=306123&view=rev Log: test: fix negative test case Add missing -### to the driver to ensure that we dont try to run the actual command. The host may not support the IAS. Should fix t

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

arphaman added a comment. Fair enough. LGTM from my side. https://reviews.llvm.org/D34299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

dexonsmith added inline comments. Comment at: test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_deployment.fail.cpp:12-16 +// test availability of new/delete operators introduced in c++17. + +#ifdef __APPLE__ +#undef _LIBCPP_DISABLE_AVAILABILITY +#end

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

vsk added a comment. In https://reviews.llvm.org/D34299#788908, @arphaman wrote: > Ok, so now the null check `return.sloc.load` won't call the checker in > compiler-rt and so the program won't `abort` and won't hit the `unreachable`. > I have one question tough: > > This patch changes the behav

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. In https://reviews.llvm.org/D33589#789002, @alexfh wrote: > why do we want to make an exception for comments and not for regular code? This is not an exception for comments: the `PenaltyExcessCharacter` is used whenever the code is longer than the `ColumnLimit`, and used

[PATCH] D34557: Sort the autocomplete candidates before printing them out.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306116: Sort the autocomplete candidates before printing them out. (authored by ruiu). Changed prior to commit: https://reviews.llvm.org/D34557?vs=103731&id=103733#toc Repository: rL LLVM https://re

r306116 - Sort the autocomplete candidates before printing them out.

Author: ruiu Date: Fri Jun 23 10:37:52 2017 New Revision: 306116 URL: http://llvm.org/viewvc/llvm-project?rev=306116&view=rev Log: Sort the autocomplete candidates before printing them out. Currently, autocompleted options are displayed in the same order as we wrote them in .td files. This patch

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

dexonsmith added a comment. > I followed the other availability macros in using "strict", but I'm not sure > this was the right decision. The documentation seems to recommend not using > "strict" (it says that weakly-linking is almost always a better API choice). libc++ is one of the exceptions

r306115 - Revert "Revert r305164/5/7."

Author: compnerd Date: Fri Jun 23 10:34:16 2017 New Revision: 306115 URL: http://llvm.org/viewvc/llvm-project?rev=306115&view=rev Log: Revert "Revert r305164/5/7." Restore the `-gz` option to the driver with some minor tweaks to handle the additional case for `-Wa,--compress-debug-sections`. Thi

[PATCH] D34557: Sort the autocomplete candidates before printing them out.

yamaguchi accepted this revision. yamaguchi added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the patch. https://reviews.llvm.org/D34557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

erik.pilkington added inline comments. Comment at: test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_deployment.fail.cpp:35 + // expected-error@-10 {{call to unavailable function 'operator new[]': introduced in macOS 10.13}} + // expected-note@new:

[PATCH] D34557: Sort the autocomplete candidates before printing them out.

ruiu created this revision. Currently, autocompleted options are displayed in the same order as we wrote them in .td files. This patch sort them out in clang so that they are sorted alphabetically. This should improve usability. https://reviews.llvm.org/D34557 Files: clang/lib/Driver/Driver.c

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

arphaman added a comment. I reverted it in r306111 for now. Repository: rL LLVM https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306111 - Revert r306103: "PR26195: Set correct NestedNameSpecifierLoc for the

Author: arphaman Date: Fri Jun 23 10:10:54 2017 New Revision: 306111 URL: http://llvm.org/viewvc/llvm-project?rev=306111&view=rev Log: Revert r306103: "PR26195: Set correct NestedNameSpecifierLoc for the dependent initializer" It caused buildbot failures such as this one: http://bb.pgr.jp/builder

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

ahatanak created this revision. This is needed because older versions of libc++ do not have these operators. If users target an older deployment target and try to compile programs in which these operators are explicitly called, the compiler will complain. The following is the list of minimum de

[PATCH] D34329: [GSoC] Clang AST diffing

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:730 + +Mapping TreeComparator::matchTopDown() const { + PriorityList L1(T1); Johannes, it seems to me that your implementation of the top-down portion of the GumTree algorithm doesn't u

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

bader added a comment. Ping. Although this patch is already accepted, I'd like to confirm that I can commit the latest update with changes in test/SemaOpenCL/invalid-pipes-cl2.0.cl. Thanks. https://reviews.llvm.org/D33681 ___ cfe-commits mailing

r306074 - [WebAssembly] Add default -allow-undefined-file to linker args

Author: sbc Date: Thu Jun 22 19:02:55 2017 New Revision: 306074 URL: http://llvm.org/viewvc/llvm-project?rev=306074&view=rev Log: [WebAssembly] Add default -allow-undefined-file to linker args Also, don't use the outdated lib32/lib64 naming of files within the sysroot. The more modern/flexible ap

[PATCH] D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

baloghadamsoftware added a comment. Now I can improve `SValBuilder` to compare `{conj_X}+n` to `conj_X}+m`, but I am not sure if it helps to simplify `compare()` much. How to handle cases where I have to compare `{conj_X}+n` to `{conj_Y}+m`, an we have a range `[k..k]` for `{conj_X}-{conj_Y}` i

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

alexfh added a comment. Daniel is a better reviewer here than myself. A few cents from me though: why do we want to make an exception for comments and not for regular code? https://reviews.llvm.org/D33589 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

arphaman added a comment. Link to failure: http://bb.pgr.jp/builders/test-clang-msc-x64-on-i686-linux-RA/builds/3777/steps/test_clang/logs/Clang%20%3A%3A%20Index__ctor-init-source-loc.cpp Repository: rL LLVM https://reviews.llvm.org/D32439 ___ c

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

arphaman added a comment. Serge, the test seems to be failing on linux (http://bb.pgr.jp/builders/test-clang-msc-x64-on-i686-linux-RA). Can you take a look? I will have to revert it if we can't fix it soon. Repository: rL LLVM https://reviews.llvm.org/D32439 _

[PATCH] D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

baloghadamsoftware updated this revision to Diff 103728. baloghadamsoftware added a comment. `SymbolManager::getSymIntExpr()` replaced by `SValBuilder::evalBinOp()`, function `compact()` eliminated. https://reviews.llvm.org/D32642 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

This revision was automatically updated to reflect the committed changes. Closed by commit rL306103: PR26195: Set correct NestedNameSpecifierLoc for the dependent initializer (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D32439?vs=103703&id=103727#toc Repository:

r306103 - PR26195: Set correct NestedNameSpecifierLoc for the dependent initializer

Author: arphaman Date: Fri Jun 23 09:10:07 2017 New Revision: 306103 URL: http://llvm.org/viewvc/llvm-project?rev=306103&view=rev Log: PR26195: Set correct NestedNameSpecifierLoc for the dependent initializer This commit fixes incorrect source positions of dependent c'tor initializers like in the

[PATCH] D16403: Add scope information to CFG

a.sidorin added a comment. Hi Matthias, I have posted a comment about review duplication (more than a year ago!) in your review but you haven't answered. So, all this time we were thinking that you do separate non-related work. @dcoughlin As a reviewer of both patches - could you tell us what's

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Looks like a pretty mechanical change. https://reviews.llvm.org/D34513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D16403: Add scope information to CFG

mgehre added a comment. Please consider also https://reviews.llvm.org/D15031 It already handles all possible control flows. Instead of ScopeBegin and ScopeEnd, it introduces LifetimeEnds elements. It's a more specific in that is also correctly models the order of lifetime expiry of variables and

[PATCH] D34546: docs: Add documentation for the ThinLTO cache pruning policy string.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

Serge_Preis added a comment. Thank you! https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34395: clang-format: add options to merge empty record body

Typz added a comment. ping? https://reviews.llvm.org/D34395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz added a comment. ping? https://reviews.llvm.org/D32478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz added a comment. ping? https://reviews.llvm.org/D34238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This LGTM. I will commit it for you. https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D16403: Add scope information to CFG

m.ostapenko updated this revision to Diff 103719. m.ostapenko set the repository for this revision to rL LLVM. m.ostapenko added a project: clang. m.ostapenko added a comment. So, updating the diff. This is still a very experimental version and any feedback would be greatly appreciated. Current p

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

alexfh added a comment. Sorry for the delay, I was on vacation. This looks much better now, thanks! A few more comments though. Comment at: lib/Lex/Lexer.cpp:460 +/// \brief Check if new line pointed by Str is escaped. +bool isNewLineEscaped(const char *BufferStart, const char

r306094 - [clang-format] Add a SortUsingDeclaration option and enable it by default

Author: krasimir Date: Fri Jun 23 06:46:03 2017 New Revision: 306094 URL: http://llvm.org/viewvc/llvm-project?rev=306094&view=rev Log: [clang-format] Add a SortUsingDeclaration option and enable it by default Summary: This patch adds a `SortUsingDeclaration` style option and enables it for llvm s

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

arphaman added a comment. Ok, so now the null check `return.sloc.load` won't call the checker in compiler-rt and so the program won't `abort` and won't hit the `unreachable`. I have one question tough: This patch changes the behavior of this sanitizer for the example that I gave above. Previou

[PATCH] D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling

klimek added inline comments. Comment at: include/clang/Tooling/CrossTranslationUnit.h:53-58 + /// \p CrossTUDir directory, called \p IndexName. In case the declaration is + /// found in the index the corresponding AST file will be loaded and the + /// definition of the functi

[PATCH] D34552: [clang-format] Update dump_format_style.py to indent nested fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL306093: [clang-format] Update dump_format_style.py to indent nested fields (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D34552?vs=103709&id=103711#toc Repository: rL LLVM

r306093 - [clang-format] Update dump_format_style.py to indent nested fields

Author: krasimir Date: Fri Jun 23 06:29:40 2017 New Revision: 306093 URL: http://llvm.org/viewvc/llvm-project?rev=306093&view=rev Log: [clang-format] Update dump_format_style.py to indent nested fields Summary: This updates the format options documentation script to indent the documentation of ne

[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one nit. Comment at: clang-tidy/android/FileOpenFlagCheck.cpp:24 + +bool HasCloseOnExecFlag(const Expr *Flags, const SourceManager &SM, +const

[PATCH] D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling

xazax.hun updated this revision to Diff 103710. xazax.hun added a comment. - Removed an unrelated change - Made the unit test more strict https://reviews.llvm.org/D34512 Files: include/clang/Tooling/CrossTranslationUnit.h lib/AST/ASTImporter.cpp lib/Tooling/CMakeLists.txt lib/Tooling/Cr

  1   2   >